pob 13.0.0 → 13.1.0

package/CHANGELOG.md

@@ -3,6 +3,39 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [13.1.0](https://github.com/christophehurpeau/pob/compare/pob@13.0.2...pob@13.1.0) (2023-06-27)
+
+
+### Features
+
+* **pob:** fix check-package-dependencies template ([6a2f6ed](https://github.com/christophehurpeau/pob/commit/6a2f6ed50f5d04811d59a4b90f25cba0f6b72505))
+* **pob:** improve github repo config ([bfe8c29](https://github.com/christophehurpeau/pob/commit/bfe8c2992987a501f2bfe44bae26f9049002427a))
+
+
+### Bug Fixes
+
+* update to first node 18 lts version ([139fe7d](https://github.com/christophehurpeau/pob/commit/139fe7d1ac70aaae2144f1263a1a3c6c22dd26ab))
+
+
+
+## [13.0.2](https://github.com/christophehurpeau/pob/compare/pob@13.0.1...pob@13.0.2) (2023-06-26)
+
+
+### Bug Fixes
+
+* fix yarn call in ci lerna publish ([55d5dd2](https://github.com/christophehurpeau/pob/commit/55d5dd29bcf9d96d732d60f08e1ea1d780acd946))
+
+
+
+## [13.0.1](https://github.com/christophehurpeau/pob/compare/pob@13.0.0...pob@13.0.1) (2023-06-26)
+
+
+### Bug Fixes
+
+* **pob:** fix json formatter for lerna.json ([11f2df0](https://github.com/christophehurpeau/pob/commit/11f2df062abdc4336e7bed588573ba6edd22034c))
+
+
+
 ## [13.0.0](https://github.com/christophehurpeau/pob/compare/pob@12.0.0...pob@13.0.0) (2023-06-26)
 
 

package/lib/generators/core/git/generators/github/CoreGitGithubGenerator.js

@@ -51,6 +51,17 @@ const configureProtectionRule = async (owner, repo, onlyLatestLTS) => {
   }
 };
 
+const githubRepoConfig = {
+  allow_squash_merge: true,
+  allow_merge_commit: false,
+  allow_rebase_merge: true,
+  allow_auto_merge: true,
+  delete_branch_on_merge: true,
+  use_squash_pr_title_as_default: true,
+  squash_merge_commit_title: 'PR_TITLE',
+  squash_merge_commit_message: 'BLANK',
+};
+
 export default class CoreGitGithubGenerator extends Generator {
   constructor(args, opts) {
     super(args, opts);
@@ -113,9 +124,7 @@ export default class CoreGitGithubGenerator extends Generator {
               homepage: null,
               private: false,
               auto_init: false,
-              allow_squash_merge: true,
-              allow_merge_commit: false,
-              allow_rebase_merge: true,
+              ...githubRepoConfig,
             });
           } catch (err) {
             console.error('Failed to create repository');
@@ -173,9 +182,7 @@ export default class CoreGitGithubGenerator extends Generator {
             .replace(/^@([^-]*)-/, '$1-') */
         description: pkg.description,
         // homepage: null,
-        allow_squash_merge: true,
-        allow_merge_commit: false,
-        allow_rebase_merge: true,
+        ...githubRepoConfig,
       });
 
       configureProtectionRule(owner, repo, this.options.onlyLatestLTS);

package/lib/generators/core/package/CorePackageGenerator.js

@@ -37,15 +37,9 @@ export default class CorePackageGenerator extends Generator {
     if (!pkg.engines) pkg.engines = {};
 
     // dont override engines if set to latest
-    if (
-      !pkg.engines.node ||
-      !(
-        pkg.engines.node.startsWith('>=18.') ||
-        pkg.engines.node.startsWith('>=16.')
-      )
-    ) {
+    if (!pkg.engines.node || !pkg.engines.node.startsWith('>=18.')) {
       // this might be overridden by babel generator
-      pkg.engines.node = '>=18.0.0';
+      pkg.engines.node = '>=18.12.0'; // .12.0 is the first lts node 18 version
     }
 
     if (!this.options.updateOnly) {
@@ -217,8 +211,11 @@ export default class CorePackageGenerator extends Generator {
         this.fs.copyTpl(
           this.templatePath('check-package.js.ejs'),
           this.destinationPath('scripts/check-package.js'),
-          {},
+          {
+            isLibrary: pkg.private !== true,
+          },
         );
+        packageUtils.addDevDependencies(pkg, ['check-package-dependencies']);
       }
 
       packageUtils.addOrRemoveScripts(

package/lib/generators/core/package/templates/check-package.js.ejs

@@ -1,3 +1,3 @@
 import { createCheckPackage } from 'check-package-dependencies';
 
-createCheckPackage().checkRecommended({});
+await createCheckPackage({ isLibrary: <%= isLibrary ? 'true' : 'false' %> }).checkRecommended({}).run();

package/lib/generators/monorepo/lerna/templates/workflow-publish.yml.ejs

@@ -57,7 +57,7 @@ jobs:
           node-version: 18
           registry-url: "https://registry.npmjs.org"
 
-      - run: lerna publish from-git --no-verify-access --yes
+      - run: yarn lerna publish from-git --no-verify-access --yes
         if: |
           github.ref == 'refs/heads/main'
           && contains(github.event.inputs.dry-run, 'y') == false

package/lib/utils/writeAndFormat.js

@@ -13,10 +13,21 @@ export function writeAndFormat(fs, destinationPath, content, { parser } = {}) {
   );
 }
 
+function getParserFromDestinationPath(destinationPath) {
+  if (destinationPath.endsWith('/lerna.json')) {
+    return 'json-stringify';
+  }
+  if (destinationPath.endsWith('json')) {
+    return undefined;
+  }
+
+  return 'json';
+}
+
 export function writeAndFormatJson(fs, destinationPath, value) {
   writeAndFormat(fs, destinationPath, JSON.stringify(value, null, 2), {
     // project.code-workspace is json
-    parser: destinationPath.endsWith('json') ? undefined : 'json',
+    parser: getParserFromDestinationPath(destinationPath),
   });
 }
 export function copyAndFormatTpl(fs, templatePath, destinationPath, options) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "13.0.0",
+  "version": "13.1.0",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -57,14 +57,14 @@
     "mem-fs-editor": "9.7.0",
     "minimist": "1.2.8",
     "parse-author": "2.0.0",
-    "pob-dependencies": "8.0.0",
+    "pob-dependencies": "8.1.0",
     "prettier": "2.8.8",
     "semver": "7.5.3",
     "yeoman-environment": "3.19.3",
     "yeoman-generator": "5.9.0"
   },
   "devDependencies": {
-    "@pob/root": "8.0.0"
+    "@pob/root": "8.0.1"
   },
-  "gitHead": "a4de26f443da5495cac89b819833057c5535e8be"
+  "gitHead": "7632ede9dd93eeae6b75191c9a57ebbd5fe6d3d5"
 }