pob 12.0.0 → 13.0.2

package/CHANGELOG.md

@@ -3,6 +3,66 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [13.0.2](https://github.com/christophehurpeau/pob/compare/pob@13.0.1...pob@13.0.2) (2023-06-26)
+
+
+### Bug Fixes
+
+* fix yarn call in ci lerna publish ([55d5dd2](https://github.com/christophehurpeau/pob/commit/55d5dd29bcf9d96d732d60f08e1ea1d780acd946))
+
+
+
+## [13.0.1](https://github.com/christophehurpeau/pob/compare/pob@13.0.0...pob@13.0.1) (2023-06-26)
+
+
+### Bug Fixes
+
+* **pob:** fix json formatter for lerna.json ([11f2df0](https://github.com/christophehurpeau/pob/commit/11f2df062abdc4336e7bed588573ba6edd22034c))
+
+
+
+## [13.0.0](https://github.com/christophehurpeau/pob/compare/pob@12.0.0...pob@13.0.0) (2023-06-26)
+
+
+### ⚠ BREAKING CHANGES
+
+* requires node 18
+
+### Features
+
+* **deps:** update dependency eslint to v8.39.0 ([#1617](https://github.com/christophehurpeau/pob/issues/1617)) ([b42979d](https://github.com/christophehurpeau/pob/commit/b42979d8586e55afee60b1280059916293879711))
+* **deps:** update dependency eslint to v8.40.0 ([#1627](https://github.com/christophehurpeau/pob/issues/1627)) ([6d5dfe6](https://github.com/christophehurpeau/pob/commit/6d5dfe6a3576c53b9da773605e35729dcd8e5610))
+* **deps:** update dependency eslint to v8.41.0 ([#1646](https://github.com/christophehurpeau/pob/issues/1646)) ([11c8395](https://github.com/christophehurpeau/pob/commit/11c8395a08bd281c8960b6ba62999f67b21334aa))
+* **deps:** update dependency yeoman-environment to v3.16.1 ([#1630](https://github.com/christophehurpeau/pob/issues/1630)) ([5ca9ad5](https://github.com/christophehurpeau/pob/commit/5ca9ad515ead63c31c10dccac40c5942974f5760))
+* **deps:** update dependency yeoman-environment to v3.17.0 ([#1638](https://github.com/christophehurpeau/pob/issues/1638)) ([3d1a154](https://github.com/christophehurpeau/pob/commit/3d1a1546d088b4020873eca0ae566ae3ac41a45d))
+* **deps:** update dependency yeoman-environment to v3.18.1 ([#1643](https://github.com/christophehurpeau/pob/issues/1643)) ([e1144ed](https://github.com/christophehurpeau/pob/commit/e1144ed11f476729f90634b7e6c7530af1f959f4))
+* **deps:** update dependency yeoman-environment to v3.19.0 ([#1656](https://github.com/christophehurpeau/pob/issues/1656)) ([82b613f](https://github.com/christophehurpeau/pob/commit/82b613f2ada3ecef8c47b247d32b677a88b596e9))
+* remove legacy code-workspace ([c5bcdc7](https://github.com/christophehurpeau/pob/commit/c5bcdc7735dfda0b369a3045ecc618f8ea11794d))
+* requires node 18 ([bd35158](https://github.com/christophehurpeau/pob/commit/bd351582c2c3977d8d22c15b831e277acc97a00e))
+* update ci to node 18 ([1e4cf82](https://github.com/christophehurpeau/pob/commit/1e4cf828521d24c7142544de3dc3b1dbd62dc9a8))
+
+
+### Bug Fixes
+
+* **deps:** update @pob/eslint-config to v50.0.5 ([#1629](https://github.com/christophehurpeau/pob/issues/1629)) ([c7065bc](https://github.com/christophehurpeau/pob/commit/c7065bc1757c12fadb848ddd8333c0684b8880e4))
+* **deps:** update dependency prettier to v2.8.8 ([#1619](https://github.com/christophehurpeau/pob/issues/1619)) ([40f1313](https://github.com/christophehurpeau/pob/commit/40f13138243c0b53c52293314111458e6c8d2d6a))
+* **deps:** update dependency semver to v7.5.1 ([#1636](https://github.com/christophehurpeau/pob/issues/1636)) ([9556202](https://github.com/christophehurpeau/pob/commit/95562027a2cdb674b7081c614235e4a07bbc1a22))
+* **deps:** update dependency semver to v7.5.2 ([#1680](https://github.com/christophehurpeau/pob/issues/1680)) ([312c2b2](https://github.com/christophehurpeau/pob/commit/312c2b2c2e2149dbd6a99203fdbe579ffddff98e))
+* **deps:** update dependency semver to v7.5.3 ([#1682](https://github.com/christophehurpeau/pob/issues/1682)) ([8e8b2ef](https://github.com/christophehurpeau/pob/commit/8e8b2efa7ad39077299c5bcdb2c55941038e989a))
+* **deps:** update dependency yeoman-environment to v3.16.2 ([#1632](https://github.com/christophehurpeau/pob/issues/1632)) ([feb4f3a](https://github.com/christophehurpeau/pob/commit/feb4f3a1a819a67444261d1731d39e1fcb62b77d))
+* **deps:** update dependency yeoman-environment to v3.18.2 ([#1644](https://github.com/christophehurpeau/pob/issues/1644)) ([a64dede](https://github.com/christophehurpeau/pob/commit/a64dede35c0b698409644061539bd6f40a0f3c09))
+* **deps:** update dependency yeoman-environment to v3.18.4 ([#1649](https://github.com/christophehurpeau/pob/issues/1649)) ([51059b6](https://github.com/christophehurpeau/pob/commit/51059b64357b32f32f0dc85735111dff3f980fd4))
+* **deps:** update dependency yeoman-environment to v3.19.1 ([#1658](https://github.com/christophehurpeau/pob/issues/1658)) ([0d9ccf7](https://github.com/christophehurpeau/pob/commit/0d9ccf777d0b1216ea9db2bb27c3fec19f0317e2))
+* **deps:** update dependency yeoman-environment to v3.19.2 ([#1659](https://github.com/christophehurpeau/pob/issues/1659)) ([94d5b8b](https://github.com/christophehurpeau/pob/commit/94d5b8be10fd16e07cb7fd56d28393276814a92e))
+* **deps:** update dependency yeoman-environment to v3.19.3 ([#1660](https://github.com/christophehurpeau/pob/issues/1660)) ([9e0452e](https://github.com/christophehurpeau/pob/commit/9e0452e04fc6eab054d949b7954b02eb39c33e8f))
+* **deps:** update yeoman group ([#1645](https://github.com/christophehurpeau/pob/issues/1645)) ([1686097](https://github.com/christophehurpeau/pob/commit/1686097cfb644bbb5ae78a647b1cd9cc07e1f440))
+* dont enable gh-pages with node testing runner ([f1d0fe5](https://github.com/christophehurpeau/pob/commit/f1d0fe512bf4f1d014d2fa7959bb1fbadac48025))
+* fix tsconfig paths ([5aaa499](https://github.com/christophehurpeau/pob/commit/5aaa499fc5fb3a69e33705e1a72e49dbb69739db))
+* sort supportedArchitectures in yarn.yml alpha ([045c7a6](https://github.com/christophehurpeau/pob/commit/045c7a6d9e3697f68debe68a47300bbf239df58e))
+* update github ci required ([fd5afbf](https://github.com/christophehurpeau/pob/commit/fd5afbf935095fb0613f85496d1d2eb2e81ed8ea))
+
+
+
 ## [12.0.0](https://github.com/christophehurpeau/pob/compare/pob@11.9.0...pob@12.0.0) (2023-04-18)
 
 

package/lib/generators/common/babel/CommonBabelGenerator.js

@@ -54,7 +54,7 @@ export default class CommonBabelGenerator extends Generator {
       let babelEnvs = pkg.pob.babelEnvs;
       if (
         !babelEnvs.some(
-          (env) => env.target === 'node' && String(env.version) === '14',
+          (env) => env.target === 'node' && String(env.version) === '18',
         ) &&
         babelEnvs.some(
           (env) =>
@@ -62,16 +62,18 @@ export default class CommonBabelGenerator extends Generator {
             (String(env.version) === '8' ||
               String(env.version) === '6' ||
               String(env.version) === '10' ||
-              String(env.version) === '12'),
+              String(env.version) === '12' ||
+              String(env.version) === '14' ||
+              String(env.version) === '16'),
         )
       ) {
         babelEnvs.unshift({
           target: 'node',
-          version: '16',
+          version: '18',
         });
       }
       babelEnvs = babelEnvs.filter(
-        (env) => env.target !== 'node' || env.version >= 14,
+        (env) => env.target !== 'node' || env.version >= 18,
       );
 
       pkg.pob.babelEnvs = babelEnvs;
@@ -97,7 +99,7 @@ export default class CommonBabelGenerator extends Generator {
         babelEnvs
           .filter((env) => env.target === 'node')
           .map((env) => {
-            if (env.version === '14') return '16';
+            if (env.version === '14' || env.version === '16') return '18';
             return env.version;
           }),
       ),
@@ -147,8 +149,8 @@ export default class CommonBabelGenerator extends Generator {
           default: nodeVersions,
           choices: [
             {
-              name: '16 (Maintenance LTS)',
-              value: '16',
+              name: '18 (Active LTS)',
+              value: '18',
             },
           ],
         },
@@ -201,7 +203,7 @@ export default class CommonBabelGenerator extends Generator {
         formats:
           babelConfig.formats && babelConfig.formats.includes('cjs')
             ? // eslint-disable-next-line unicorn/no-nested-ternary
-              version === '16'
+              version === '16' || version === '18'
               ? babelConfig.formats
               : undefined
             : undefined,
@@ -385,11 +387,12 @@ export default class CommonBabelGenerator extends Generator {
         case '10':
         case '12':
         case '14':
-          pkg.engines.node = '>=16.0.0';
-          break;
         case '16':
           pkg.engines.node = '>=16.0.0';
           break;
+        case '18':
+          pkg.engines.node = '>=18.0.0';
+          break;
         default:
           throw new Error(`Invalid min node version: ${minNodeVersion}`);
       }
@@ -410,8 +413,8 @@ export default class CommonBabelGenerator extends Generator {
     } else {
       packageUtils.removeDependencies(pkg, ['@types/node']);
       packageUtils.removeDevDependencies(pkg, ['@types/node']);
-      // Supported LTS versions of node, that supports ESM modules.
-      pkg.engines.node = '>=16.0.0';
+      // Supports oldest current or active LTS version of node
+      pkg.engines.node = '>=18.0.0';
     }
 
     /* browserslist */

package/lib/generators/common/typescript/templates/tsconfig.json.ejs

@@ -70,8 +70,8 @@
     <% if (monorepoPackageSrcPaths && monorepoPackageSrcPaths.length !== 0) { -%>
     "paths": {
       <% monorepoPackageSrcPaths.forEach(([packageName, packageLocation], index) => { %>
-      "<%= packageName %>": ["../<%= packageLocation %>"],
-      "<%= packageName %>/*": ["../<%= packageLocation %>/*"]<%= index === monorepoPackageSrcPaths.length -1 ? '' : ',' -%>
+      "<%= packageName %>": ["<%= packageLocation %>"],
+      "<%= packageName %>/*": ["<%= packageLocation %>/*"]<%= index === monorepoPackageSrcPaths.length -1 ? '' : ',' -%>
       <% }) %>
     }<% } %>
   }<% if (monorepoPackageReferences && monorepoPackageReferences.length) { -%>,

package/lib/generators/core/ci/CoreCIGenerator.js

@@ -152,12 +152,12 @@ export default class CoreCIGenerator extends Generator {
               checks && 'checks',
               build && 'build',
               'lint',
-              testing && !this.options.onlyLatestLTS && 'test (16)',
               testing && 'test (18)',
+              testing && !this.options.onlyLatestLTS && 'test (20)',
             ].filter(Boolean)
           : [
-              !this.options.onlyLatestLTS && 'build (16.x)',
               'build (18.x)',
+              !this.options.onlyLatestLTS && 'build (20.x)',
             ].filter(Boolean)),
       );
     } else {
@@ -167,7 +167,8 @@ export default class CoreCIGenerator extends Generator {
     if (
       this.options.enable &&
       !this.options.isApp &&
-      (this.options.documentation || this.options.testing)
+      (this.options.documentation ||
+        (this.options.testing && this.options.testing.runner !== 'node'))
     ) {
       copyAndFormatTpl(
         this.fs,

package/lib/generators/core/ci/templates/github-action-documentation-workflow.yml.ejs

@@ -12,7 +12,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
 
       - name: Install Dependencies
         run: yarn install --immutable --immutable-cache

package/lib/generators/core/ci/templates/github-action-push-workflow-split.yml.ejs

@@ -72,7 +72,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [16, 18]
+        node-version: [18, 20]
 
     steps:
       - uses: actions/checkout@v3

package/lib/generators/core/ci/templates/github-action-push-workflow.yml.ejs

@@ -8,7 +8,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [<% if (!onlyLatestLTS) { -%>16.x, <% } -%>18.x]
+        node-version: [<% if (!onlyLatestLTS) { -%>18.x, <% } -%>20.x]
 
     steps:
       - uses: actions/checkout@v3

package/lib/generators/core/package/CorePackageGenerator.js

@@ -40,12 +40,12 @@ export default class CorePackageGenerator extends Generator {
     if (
       !pkg.engines.node ||
       !(
-        pkg.engines.node.startsWith('>=14.') ||
+        pkg.engines.node.startsWith('>=18.') ||
         pkg.engines.node.startsWith('>=16.')
       )
     ) {
       // this might be overridden by babel generator
-      pkg.engines.node = '>=14.13.1';
+      pkg.engines.node = '>=18.0.0';
     }
 
     if (!this.options.updateOnly) {

package/lib/generators/core/vscode/CoreVSCodeGenerator.js

@@ -1,9 +1,6 @@
 import Generator from 'yeoman-generator';
 import { readJSON5 } from '../../../utils/json5.js';
-import {
-  copyAndFormatTpl,
-  writeAndFormatJson,
-} from '../../../utils/writeAndFormat.js';
+import { copyAndFormatTpl } from '../../../utils/writeAndFormat.js';
 
 export default class CoreVSCodeGenerator extends Generator {
   constructor(args, opts) {
@@ -106,69 +103,14 @@ export default class CoreVSCodeGenerator extends Generator {
       );
 
       if (this.options.monorepo) {
-        const packageNames = JSON.parse(this.options.packageNames);
-        const packageLocations = JSON.parse(this.options.packageLocations);
-        const folders = packageLocations.map((location, i) => ({
-          name: packageNames[i],
-          path: `../${location}`,
-        }));
-        folders.sort((a, b) => a.name.localeCompare(b.name, 'en'));
-
-        packageLocations.forEach((location) => {
-          writeAndFormatJson(
-            this.fs,
-            this.destinationPath(`${location}/.vscode/settings.json`),
-            {
-              'eslint.workingDirectories': ['../../'],
-            },
-          );
-        });
-
-        const extensions = readJSON5(
-          this.fs,
-          this.destinationPath('.vscode/extensions.json'),
-          {},
-        );
-        const settings = readJSON5(
-          this.fs,
-          this.destinationPath('.vscode/settings.json'),
-          {},
-        );
-
         const projectName = pkg.name.replace('/', '-');
-        writeAndFormatJson(
-          this.fs,
+        // legacy project code-workspace
+        this.fs.delete(
           this.destinationPath(`.vscode/${projectName}.code-workspace`),
-          {
-            extensions,
-            settings: {
-              ...settings,
-              ...(settings['typescript.tsdk']
-                ? { 'typescript.tsdk': '✨ root/node_modules/typescript/lib' }
-                : {}),
-              ...(this.options.testing
-                ? {
-                    'jest.jestCommandLine':
-                      'NODE_OPTIONS=--experimental-vm-modules node_modules/.bin/jest',
-                    // disable all folders to enable only root.
-                    'jest.disabledWorkspaceFolders': folders.map(
-                      (folder) => folder.name,
-                    ),
-                  }
-                : {}),
-            },
-            folders: [
-              {
-                name: '✨ root',
-                path: '..',
-              },
-              ...folders,
-            ],
-          },
         );
       }
     } else {
-      // this.fs.delete('.vscode');
+      this.fs.delete('.vscode');
     }
   }
 }

package/lib/generators/core/yarn/CoreYarnGenerator.js

@@ -105,8 +105,8 @@ export default class CoreYarnGenerator extends Generator {
       // https://yarnpkg.dev/releases/3-1/
       // make sure all supported architectures are in yarn cache
       config.supportedArchitectures = {
-        os: ['linux', 'darwin'],
         cpu: ['x64', 'arm64'],
+        os: ['linux', 'darwin'],
       };
       writeAndFormat(this.fs, '.yarnrc.yml', yml.dump(config, {}));
     } else {

package/lib/generators/monorepo/lerna/templates/workflow-publish.yml.ejs

@@ -57,7 +57,7 @@ jobs:
           node-version: 18
           registry-url: "https://registry.npmjs.org"
 
-      - run: lerna publish from-git --no-verify-access --yes
+      - run: yarn lerna publish from-git --no-verify-access --yes
         if: |
           github.ref == 'refs/heads/main'
           && contains(github.event.inputs.dry-run, 'y') == false

package/lib/utils/writeAndFormat.js

@@ -13,10 +13,21 @@ export function writeAndFormat(fs, destinationPath, content, { parser } = {}) {
   );
 }
 
+function getParserFromDestinationPath(destinationPath) {
+  if (destinationPath.endsWith('/lerna.json')) {
+    return 'json-stringify';
+  }
+  if (destinationPath.endsWith('json')) {
+    return undefined;
+  }
+
+  return 'json';
+}
+
 export function writeAndFormatJson(fs, destinationPath, value) {
   writeAndFormat(fs, destinationPath, JSON.stringify(value, null, 2), {
     // project.code-workspace is json
-    parser: destinationPath.endsWith('json') ? undefined : 'json',
+    parser: getParserFromDestinationPath(destinationPath),
   });
 }
 export function copyAndFormatTpl(fs, templatePath, destinationPath, options) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "12.0.0",
+  "version": "13.0.2",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -38,13 +38,13 @@
   "dependencies": {
     "@lerna/package-graph": "5.5.4",
     "@lerna/project": "5.5.4",
-    "@pob/eslint-config": "50.0.4",
-    "@pob/eslint-config-typescript": "50.0.4",
-    "@pob/eslint-config-typescript-react": "50.0.4",
-    "@pob/sort-eslint-config": "4.1.1",
-    "@pob/sort-object": "5.1.1",
-    "@pob/sort-pkg": "5.2.0",
-    "eslint": "8.38.0",
+    "@pob/eslint-config": "50.0.5",
+    "@pob/eslint-config-typescript": "50.0.5",
+    "@pob/eslint-config-typescript-react": "50.0.5",
+    "@pob/sort-eslint-config": "5.0.0",
+    "@pob/sort-object": "6.0.0",
+    "@pob/sort-pkg": "6.0.0",
+    "eslint": "8.41.0",
     "findup-sync": "^5.0.0",
     "git-remote-url": "^1.0.1",
     "github-username": "^6.0.0",
@@ -57,14 +57,14 @@
     "mem-fs-editor": "9.7.0",
     "minimist": "1.2.8",
     "parse-author": "2.0.0",
-    "pob-dependencies": "7.8.0",
-    "prettier": "2.8.7",
-    "semver": "7.5.0",
-    "yeoman-environment": "3.15.1",
-    "yeoman-generator": "5.8.0"
+    "pob-dependencies": "8.0.0",
+    "prettier": "2.8.8",
+    "semver": "7.5.3",
+    "yeoman-environment": "3.19.3",
+    "yeoman-generator": "5.9.0"
   },
   "devDependencies": {
-    "@pob/root": "7.8.0"
+    "@pob/root": "8.0.0"
   },
-  "gitHead": "efa1629282be7a06f88a2b2c84b87e56c6ea3d30"
+  "gitHead": "d240a76212d544942eeaba155820a812cb69f717"
 }