pob 11.8.1 → 11.9.0

package/CHANGELOG.md

@@ -3,6 +3,28 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [11.9.0](https://github.com/christophehurpeau/pob/compare/pob@11.8.1...pob@11.9.0) (2023-04-03)
+
+
+### Features
+
+* add expo app ([5b48a8e](https://github.com/christophehurpeau/pob/commit/5b48a8e03b14a414d2e758dbe348be67afc15710))
+* **deps:** update dependency eslint to v8.37.0 ([#1589](https://github.com/christophehurpeau/pob/issues/1589)) ([e9be11e](https://github.com/christophehurpeau/pob/commit/e9be11eefc8f15e591327f7bf12397f30a4f6a4e))
+* **pob:** add supportedArchitectures in .yarnrc.yml ([21c48f5](https://github.com/christophehurpeau/pob/commit/21c48f50ae3867d9ce69e190b1f6a4437a05970a))
+* update tsconfig moduleResolution to bundler with ts 5 ([9f08112](https://github.com/christophehurpeau/pob/commit/9f08112a50c68fc38d119a5ac44cae94f264227f))
+
+
+### Bug Fixes
+
+* **deps:** update @pob/eslint-config to v50.0.4 ([#1576](https://github.com/christophehurpeau/pob/issues/1576)) ([570f4fb](https://github.com/christophehurpeau/pob/commit/570f4fb25410db55d11b29453eecef23950d19ef))
+* **deps:** update dependency prettier to v2.8.5 ([#1578](https://github.com/christophehurpeau/pob/issues/1578)) ([07d8197](https://github.com/christophehurpeau/pob/commit/07d81974a850e43792811622845182d8b36ec4ce))
+* **deps:** update dependency prettier to v2.8.6 ([#1580](https://github.com/christophehurpeau/pob/issues/1580)) ([d351ea0](https://github.com/christophehurpeau/pob/commit/d351ea01238a4899eb69cb4c54274ace45249aed))
+* **deps:** update dependency prettier to v2.8.7 ([#1585](https://github.com/christophehurpeau/pob/issues/1585)) ([742de64](https://github.com/christophehurpeau/pob/commit/742de64a8ccaeb94cea5f2edf9c6003158844934))
+* disable baseUrl for expo for now ([fbbe531](https://github.com/christophehurpeau/pob/commit/fbbe531ee6d2d51c4f4cf43a4142122e02dca7ff))
+* prevent removing eslint-config dev deps ([dec1360](https://github.com/christophehurpeau/pob/commit/dec1360e4814a216b0db50e1bcbe7dbd4c677c26))
+
+
+
 ## [11.8.1](https://github.com/christophehurpeau/pob/compare/pob@11.8.0...pob@11.8.1) (2023-03-19)
 
 

package/lib/generators/app/PobAppGenerator.js

@@ -5,7 +5,7 @@ import inLerna from '../../utils/inLerna.js';
 import * as packageUtils from '../../utils/package.js';
 import { appIgnorePaths } from './ignorePaths.js';
 
-const appsWithTypescript = ['alp', 'next.js', 'remix', 'pobpack'];
+const appsWithTypescript = ['alp', 'next.js', 'remix', 'pobpack', 'expo'];
 const appsWithBrowser = ['alp', 'next.js', 'remix'];
 
 export default class PobAppGenerator extends Generator {
@@ -75,6 +75,7 @@ export default class PobAppGenerator extends Generator {
           'node',
           'node-library', // monorepo library for app. Not a real library
           'alp-node',
+          'expo',
           'other',
         ],
       },
@@ -151,7 +152,9 @@ export default class PobAppGenerator extends Generator {
 
     this.composeWith('pob:common:typescript', {
       enable: babel,
-      // nextjs now supports src rootDir: this.appConfig.type === 'next.js' ? '.' : 'src',
+      // nextjs now supports src
+      rootDir: this.appConfig.type === 'expo' ? '.' : 'src',
+      srcDir: 'src',
       builddefs: false,
       dom: browser,
       jsx,
@@ -169,7 +172,9 @@ export default class PobAppGenerator extends Generator {
         ) {
           return './src';
         }
-        if (this.appConfig.type === 'remix') return '.';
+        if (this.appConfig.type === 'remix') {
+          return '.';
+        }
         return '';
       })(),
     });
@@ -185,6 +190,7 @@ export default class PobAppGenerator extends Generator {
         enableReleasePlease,
         testing: this.appConfig.testing,
         typescript: babel,
+        build: babel && this.appConfig.type !== 'expo',
         documentation: false,
         codecov: this.appConfig.codecov,
         ci: this.appConfig.ci,
@@ -206,7 +212,7 @@ export default class PobAppGenerator extends Generator {
         packageManager: this.options.packageManager,
         yarnNodeLinker: this.options.yarnNodeLinker,
         ignorePaths: ignorePaths.join('\n'),
-        buildDirectory: 'build',
+        buildDirectory: this.appConfig.type === 'expo' ? '.expo' : 'build',
       });
 
       this.composeWith('pob:common:release', {

package/lib/generators/app/ignorePaths.js

@@ -13,4 +13,17 @@ export const appIgnorePaths = {
   'node-library': (config) => ['/build'],
   'alp-node': (config) => ['/build'],
   other: (config) => [],
+  expo: (config) => [
+    '/.expo/',
+    '*.jks',
+    '*.p8',
+    '*.p12',
+    '*.key',
+    '*.mobileprovision',
+    '*.orig.*',
+    '/web-build/',
+
+    '# Temporary files created by Metro to check the health of the file watcher',
+    '.metro-health-check*',
+  ],
 };

package/lib/generators/common/format-lint/CommonLintGenerator.js

@@ -185,7 +185,6 @@ export default class CommonLintGenerator extends Generator {
       '@pob/eslint-config-typescript-node',
       'babel-eslint',
       'eslint-config-pob',
-      'eslint-config-prettier',
       'typescript-eslint-parser',
       'standard',
       'eslint-import-resolver-node',
@@ -196,6 +195,7 @@ export default class CommonLintGenerator extends Generator {
         'eslint-plugin-jsx-a11y',
         'eslint-config-airbnb',
         'eslint-config-airbnb-base',
+        'eslint-config-prettier',
         'eslint-plugin-babel',
         'eslint-plugin-flowtype',
         'eslint-plugin-prefer-class-properties',
@@ -222,23 +222,25 @@ export default class CommonLintGenerator extends Generator {
     }
 
     if (globalEslint && !((inLerna && inLerna.root) || this.options.monorepo)) {
-      packageUtils.removeDevDependencies(
-        pkg,
-        [
-          'eslint',
-          'prettier',
-          '@pob/eslint-config',
-          '@pob/eslint-config-typescript',
-          '@pob/eslint-config-typescript-react',
-          '@pob/eslint-config-react',
-          '@typescript-eslint/eslint-plugin',
-          '@typescript-eslint/parser',
-          'eslint-plugin-node',
-          'eslint-plugin-unicorn',
-          'eslint-plugin-import',
-        ],
-        true,
-      );
+      if (!pkg.name.startsWith('@pob/eslint-config')) {
+        packageUtils.removeDevDependencies(
+          pkg,
+          [
+            'eslint',
+            'prettier',
+            '@pob/eslint-config',
+            '@pob/eslint-config-typescript',
+            '@pob/eslint-config-typescript-react',
+            '@pob/eslint-config-react',
+            '@typescript-eslint/eslint-plugin',
+            '@typescript-eslint/parser',
+            'eslint-plugin-node',
+            'eslint-plugin-unicorn',
+            'eslint-plugin-import',
+          ],
+          true,
+        );
+      }
     } else {
       if (pkg.name !== 'pob-monorepo') {
         packageUtils.removeDevDependencies(pkg, ['prettier']);
@@ -419,7 +421,13 @@ export default class CommonLintGenerator extends Generator {
       }
 
       if ((!inLerna || !inLerna.root) && useBabel) {
-        ignorePatterns.add(`/${this.options.buildDirectory}`, '/test');
+        const buildPath = `/${this.options.buildDirectory}`;
+        if (
+          !this.options.ignorePaths ||
+          !this.options.ignorePaths.includes(buildPath)
+        ) {
+          ignorePatterns.add(buildPath);
+        }
       }
       if (inLerna && inLerna.root && this.options.typescript) {
         ignorePatterns.add('/rollup.config.mjs');
@@ -428,7 +436,7 @@ export default class CommonLintGenerator extends Generator {
       if (this.options.ignorePaths) {
         this.options.ignorePaths
           .split('\n')
-          .filter((path) => path !== `/${this.options.buildDirectory}` && path)
+          .filter(Boolean)
           .forEach((ignorePath) => {
             if (ignorePath.startsWith('#')) return;
             ignorePatterns.add(ignorePath);

package/lib/generators/common/testing/CommonTestingGenerator.js

@@ -38,6 +38,12 @@ export default class CommonTestingGenerator extends Generator {
       desc: 'typescript',
     });
 
+    this.option('build', {
+      type: Boolean,
+      required: true,
+      desc: 'build (with babel or typescript)',
+    });
+
     this.option('codecov', {
       type: Boolean,
       required: true,
@@ -81,7 +87,7 @@ export default class CommonTestingGenerator extends Generator {
         enable: this.options.ci,
         enableReleasePlease: this.options.enableReleasePlease,
         testing: this.options.enable,
-        build: this.options.typescript,
+        build: this.options.build,
         typescript: this.options.typescript,
         documentation: this.options.documentation,
         codecov: this.options.codecov,

package/lib/generators/common/typescript/CommonTypescriptGenerator.js

@@ -20,6 +20,12 @@ export default class CommonTypescriptGenerator extends Generator {
       desc: 'customize rootDir',
     });
 
+    this.option('srcDir', {
+      type: String,
+      defaults: 'src',
+      desc: 'customize srcDir, if different than rootDir',
+    });
+
     this.option('jsx', {
       type: Boolean,
       defaults: true,
@@ -186,6 +192,7 @@ export default class CommonTypescriptGenerator extends Generator {
           monorepoPackageSrcPaths,
           monorepoPackageReferences,
           rootDir: this.options.rootDir,
+          srcDir: this.options.srcDir || this.options.rootDir,
           jsx,
           jsxPreserve: this.options.jsxPreserve,
           composite,

package/lib/generators/common/typescript/templates/tsconfig.json.ejs

@@ -1,9 +1,10 @@
 {
   "include": [
-    "<%= rootDir %>/**/*.ts"<% if (jsx) { -%>,
-    "<%= rootDir %>/**/*.tsx"<% } %>
+    "<%= srcDir %>/**/*.ts"<% if (jsx) { -%>,
+    "<%= srcDir %>/**/*.tsx"<% } %><% if (srcDir !== rootDir) { -%>,
+    "<%= rootDir %>/*.ts"<% } %>
   ],
-<% if(rootDir === '.' || forceExcludeNodeModules) { -%>
+<% if(srcDir === '.' || forceExcludeNodeModules) { -%>
   "exclude": [
     "node_modules"
   ],
@@ -59,7 +60,7 @@
     "forceConsistentCasingInFileNames": true,
 
     /* Module Resolution Options */
-    "moduleResolution": "node" /* Specify module resolution strategy. */,
+    "moduleResolution": "bundler" /* Specify module resolution strategy. */,
   <% if (resolveJsonModule) { -%>
     "resolveJsonModule": <%= resolveJsonModule %>,
   <% } -%>

package/lib/generators/core/yarn/CoreYarnGenerator.js

@@ -102,6 +102,12 @@ export default class CoreYarnGenerator extends Generator {
       config.defaultSemverRangePrefix = this.options.type === 'app' ? '' : '^';
       config.enableMessageNames = false;
       config.nodeLinker = this.options.yarnNodeLinker;
+      // https://yarnpkg.dev/releases/3-1/
+      // make sure all supported architectures are in yarn cache
+      config.supportedArchitectures = {
+        os: ['linux', 'darwin'],
+        cpu: ['x64', 'arm64'],
+      };
       writeAndFormat(this.fs, '.yarnrc.yml', yml.dump(config, {}));
     } else {
       this.fs.delete('.yarn');

package/lib/generators/lib/PobLibGenerator.js

@@ -248,6 +248,7 @@ export default class PobLibGenerator extends Generator {
       enable: this.pobjson.testing,
       enableReleasePlease,
       testing: this.pobjson.testing,
+      build: withBabel,
       typescript: withBabel,
       documentation: !!this.pobjson.documentation,
       codecov: this.pobjson.testing && this.pobjson.testing.codecov,

package/lib/generators/lib/doc/templates/tsconfig.doc.json.lerna.ejs

@@ -16,7 +16,7 @@
     "module": "esnext",
     "lib": ["dom", "esnext"],
     "skipLibCheck": true,
-    "moduleResolution": "node",
+    "moduleResolution": "bundler",
     "esModuleInterop": true
   },
 

package/lib/generators/monorepo/PobMonorepoGenerator.js

@@ -219,6 +219,7 @@ export default class PobMonorepoGenerator extends Generator {
       enable: this.pobLernaConfig.testing,
       enableReleasePlease: isReleasePleaseEnabled,
       testing: this.pobLernaConfig.testing,
+      build: this.pobLernaConfig.typescript,
       typescript: this.pobLernaConfig.typescript,
       documentation: !!this.pobLernaConfig.documentation,
       codecov: this.pobLernaConfig.testing && this.pobLernaConfig.codecov,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "11.8.1",
+  "version": "11.9.0",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -38,13 +38,13 @@
   "dependencies": {
     "@lerna/package-graph": "5.5.4",
     "@lerna/project": "5.5.4",
-    "@pob/eslint-config": "50.0.0",
-    "@pob/eslint-config-typescript": "50.0.0",
-    "@pob/eslint-config-typescript-react": "50.0.0",
+    "@pob/eslint-config": "50.0.4",
+    "@pob/eslint-config-typescript": "50.0.4",
+    "@pob/eslint-config-typescript-react": "50.0.4",
     "@pob/sort-eslint-config": "4.1.1",
     "@pob/sort-object": "5.1.1",
     "@pob/sort-pkg": "5.2.0",
-    "eslint": "8.36.0",
+    "eslint": "8.37.0",
     "findup-sync": "^5.0.0",
     "git-remote-url": "^1.0.1",
     "github-username": "^6.0.0",
@@ -58,14 +58,14 @@
     "minimist": "1.2.8",
     "node-fetch": "3.3.1",
     "parse-author": "2.0.0",
-    "pob-dependencies": "7.6.1",
-    "prettier": "2.8.4",
+    "pob-dependencies": "7.7.0",
+    "prettier": "2.8.7",
     "semver": "7.3.8",
     "yeoman-environment": "3.15.1",
     "yeoman-generator": "5.8.0"
   },
   "devDependencies": {
-    "@pob/root": "7.6.1"
+    "@pob/root": "7.7.0"
   },
-  "gitHead": "831fbb0a3e31c5f4654f8930df6e5de3d07ac90a"
+  "gitHead": "512ed98cfd994cae7ceb9717f70caa1f87012449"
 }