pob 11.6.0 → 11.8.0

package/CHANGELOG.md

@@ -3,6 +3,55 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [11.8.0](https://github.com/christophehurpeau/pob/compare/pob@11.7.0...pob@11.8.0) (2023-03-19)
+
+
+### Features
+
+* add command to help migrate to monorepo ([5274068](https://github.com/christophehurpeau/pob/commit/52740680f63a0949a622831f38268d6d10007a07))
+* drop webpack 4 legacy aliases ([e714540](https://github.com/christophehurpeau/pob/commit/e7145401e52dfe3cc6eff40f2f220b4b81bce561))
+* **pob:** app add "node-library" ([bef77f5](https://github.com/christophehurpeau/pob/commit/bef77f5caee0b89aee5540c82146fea962acf6ff))
+
+
+### Bug Fixes
+
+* fix "pob add" use monorepoArg ([92d4ca5](https://github.com/christophehurpeau/pob/commit/92d4ca5faf27fc1c054fd6c28cb5b8e8256d9f87))
+* fix vscode config jestCommandLine ([434d7ad](https://github.com/christophehurpeau/pob/commit/434d7adfb4e73ba3021d516a149bcd1fb287a479))
+
+
+
+## [11.7.0](https://github.com/christophehurpeau/pob/compare/pob@11.6.0...pob@11.7.0) (2023-03-13)
+
+
+### Features
+
+* configure conventional-changelog-conventionalcommits for lerna ([77e7a22](https://github.com/christophehurpeau/pob/commit/77e7a223646b067ee554cdec42c1d9a309faced9))
+* **deps:** update dependency eslint to v8.34.0 ([#1536](https://github.com/christophehurpeau/pob/issues/1536)) ([98769e9](https://github.com/christophehurpeau/pob/commit/98769e96ae30b00495b9fb3dd1310591daec84ae))
+* **deps:** update dependency eslint to v8.35.0 ([#1552](https://github.com/christophehurpeau/pob/issues/1552)) ([c621a8b](https://github.com/christophehurpeau/pob/commit/c621a8b396978845ddef2cb058abb1eababde5b1))
+* **deps:** update dependency eslint to v8.36.0 ([#1562](https://github.com/christophehurpeau/pob/issues/1562)) ([1bf4bee](https://github.com/christophehurpeau/pob/commit/1bf4beee1d330002052399a625c10f971c4f3b16))
+* **deps:** update dependency mem-fs to v2.3.0 ([#1542](https://github.com/christophehurpeau/pob/issues/1542)) ([7b549fa](https://github.com/christophehurpeau/pob/commit/7b549fa07ac95bfe1c7d65a5768226d6b7f34e03))
+* **deps:** update dependency mem-fs-editor to v9.7.0 ([#1554](https://github.com/christophehurpeau/pob/issues/1554)) ([afc1687](https://github.com/christophehurpeau/pob/commit/afc16876a6ffc8fbc10600a345e2f255e5486085))
+* **deps:** update dependency yeoman-environment to v3.14.0 ([#1533](https://github.com/christophehurpeau/pob/issues/1533)) ([8426153](https://github.com/christophehurpeau/pob/commit/842615332b19b49d9a16560b4d018a2b01acb5a6))
+* **deps:** update dependency yeoman-environment to v3.15.0 ([#1543](https://github.com/christophehurpeau/pob/issues/1543)) ([f2a186c](https://github.com/christophehurpeau/pob/commit/f2a186c40d090dac4a1c99b724d473131d68a835))
+* **deps:** update dependency yeoman-generator to v5.8.0 ([#1541](https://github.com/christophehurpeau/pob/issues/1541)) ([664efed](https://github.com/christophehurpeau/pob/commit/664efed2802036b48c50bcd15e92c8ffc429cec3))
+* **pob:** split ci for medium-sized monorepo ([bb0bdde](https://github.com/christophehurpeau/pob/commit/bb0bdde501c3da052653b5937b44a1c2a1fda3f0))
+* support .d.ts in extraEntries ([ff348f1](https://github.com/christophehurpeau/pob/commit/ff348f1317947fb66ecb7162e20b4f45d4d79b2e))
+
+
+### Bug Fixes
+
+* **deps:** update dependency minimist to v1.2.8 ([#1532](https://github.com/christophehurpeau/pob/issues/1532)) ([e0eddbe](https://github.com/christophehurpeau/pob/commit/e0eddbe2f0466242278fa3ab208998852ce47115))
+* **deps:** update dependency node-fetch to v3.3.1 ([#1563](https://github.com/christophehurpeau/pob/issues/1563)) ([a86cf2e](https://github.com/christophehurpeau/pob/commit/a86cf2eaf232542910cc477f76cb78250cbaab8e))
+* **deps:** update dependency prettier to v2.8.4 ([#1531](https://github.com/christophehurpeau/pob/issues/1531)) ([a25a94d](https://github.com/christophehurpeau/pob/commit/a25a94d7b144626493275dcc465d6dc2076469b5))
+* **deps:** update dependency yeoman-environment to v3.14.1 ([#1535](https://github.com/christophehurpeau/pob/issues/1535)) ([f317e72](https://github.com/christophehurpeau/pob/commit/f317e7267e99c02314de5e9ea1a129dc6d0d6692))
+* **deps:** update dependency yeoman-environment to v3.15.1 ([#1544](https://github.com/christophehurpeau/pob/issues/1544)) ([adb372c](https://github.com/christophehurpeau/pob/commit/adb372c72556a73543adc03258b5f4b2c312902f))
+* **deps:** update dependency yeoman-generator to v5.7.1 ([#1538](https://github.com/christophehurpeau/pob/issues/1538)) ([a69b624](https://github.com/christophehurpeau/pob/commit/a69b62484ff3a1569b6642d8a3302d28e7f9c833))
+* pass onlyLatestLTS option to testing generator ([c705998](https://github.com/christophehurpeau/pob/commit/c7059984913fa3b0b82b7b7813bc08c7ef525640))
+* **pob:** dont delete prettier for pob monorepo ([7c0cbf7](https://github.com/christophehurpeau/pob/commit/7c0cbf753cbd53266d54fe78533d65753bfc1ebd))
+* **pob:** fix baseUrl for libraries ([dfa705f](https://github.com/christophehurpeau/pob/commit/dfa705fd49d0bdc650719ec22ff25567d0a8a1d6))
+
+
+
 # [11.6.0](https://github.com/christophehurpeau/pob/compare/pob@11.5.0...pob@11.6.0) (2023-01-31)
 
 

package/lib/generators/app/PobAppGenerator.js

@@ -73,6 +73,7 @@ export default class PobAppGenerator extends Generator {
           'next.js',
           'remix',
           'node',
+          'node-library', // monorepo library for app. Not a real library
           'alp-node',
           'other',
         ],
@@ -112,10 +113,14 @@ export default class PobAppGenerator extends Generator {
   }
 
   default() {
-    if (this.appConfig.type === 'node' || this.appConfig.type === 'alp-node') {
+    if (
+      this.appConfig.type === 'node' ||
+      this.appConfig.type === 'node-library' ||
+      this.appConfig.type === 'alp-node'
+    ) {
       this.composeWith('pob:common:babel', {
         updateOnly: this.options.updateOnly,
-        isApp: true,
+        isApp: this.appConfig.type !== 'node-library',
         useAppConfig: this.appConfig.type === 'alp-node',
         testing: this.appConfig.testing,
         documentation: false,
@@ -185,6 +190,8 @@ export default class PobAppGenerator extends Generator {
         ci: this.appConfig.ci,
         packageManager: this.options.packageManager,
         isApp: true,
+        splitCIJobs: false,
+        onlyLatestLTS: true,
       });
 
       this.composeWith('pob:common:format-lint', {

package/lib/generators/app/ignorePaths.js

@@ -10,6 +10,7 @@ export const appIgnorePaths = {
   remix: (config) => ['# remix paths', '/.cache', '/build', '/public/build'],
   pobpack: (config) => ['/build', '/public'],
   node: (config) => ['/build'],
+  'node-library': (config) => ['/build'],
   'alp-node': (config) => ['/build'],
   other: (config) => [],
 };

package/lib/generators/common/babel/CommonBabelGenerator.js

@@ -162,11 +162,11 @@ export default class CommonBabelGenerator extends Generator {
           default: browserVersions,
           choices: [
             {
-              name: 'Modern (babel-preset-modern-browsers)',
+              name: 'Modern',
               value: 'modern',
             },
             {
-              name: 'Supported (@babel/preset-env)',
+              name: 'Supported',
               value: 'supported',
             },
           ],
@@ -361,6 +361,7 @@ export default class CommonBabelGenerator extends Generator {
       'babel-preset-env', // now @babel/preset-env
       'babel-preset-jsdoc',
       'babel-plugin-add-jsdoc-annotations',
+      'babel-preset-modern-browsers',
     ]);
 
     packageUtils.addOrRemoveDevDependencies(
@@ -371,14 +372,6 @@ export default class CommonBabelGenerator extends Generator {
       ['@babel/preset-env'],
     );
 
-    packageUtils.addOrRemoveDevDependencies(
-      pkg,
-      this.babelEnvs.find(
-        (env) => env.target === 'browser' && env.version === 'modern',
-      ),
-      ['babel-preset-modern-browsers'],
-    );
-
     /* engines */
 
     if (hasTargetNode) {
@@ -424,13 +417,17 @@ export default class CommonBabelGenerator extends Generator {
     /* browserslist */
 
     if (hasTargetBrowser) {
-      pkg.browserslist = [
-        'defaults',
-        '> 0.2%',
-        'not ie < 12',
-        'not safari < 10',
-        'not ios_saf < 10',
-      ];
+      pkg.browserslist = {
+        ...(Array.isArray(pkg.browserslist) ? {} : pkg.browserslist),
+        production: [
+          'defaults',
+          '> 0.2%',
+          'not ie < 12',
+          'not safari < 10',
+          'not ios_saf < 10',
+        ],
+        modern: ['defaults and >1% and supports es6-module'],
+      };
     } else if (this.options.isApp && pkg.browserslist) {
       pkg.browserslist = {
         ...pkg.browserslist,
@@ -515,21 +512,10 @@ export default class CommonBabelGenerator extends Generator {
         (!env.formats || env.formats.includes('es')),
     );
 
-    const esModernBrowserEnv = this.babelEnvs.find(
-      (env) =>
-        env.target === 'browser' &&
-        env.version === 'modern' &&
-        (!env.formats || env.formats.includes('es')),
-    );
-
-    const esNodeEnv = this.babelEnvs.find(
-      (env) =>
-        env.target === 'node' && (!env.formats || env.formats.includes('es')),
-    );
-
     // Legacy "dev" builds
     delete pkg['module:browser'];
     delete pkg['module:browser-dev'];
+    delete pkg['module:modern-browsers'];
     delete pkg['module:modern-browsers-dev'];
     delete pkg['module:node'];
     delete pkg['module:node-dev'];
@@ -543,44 +529,6 @@ export default class CommonBabelGenerator extends Generator {
       delete pkg.browser;
     }
 
-    if (esModernBrowserEnv) {
-      pkg[
-        'module:modern-browsers'
-      ] = `./${this.options.buildDirectory}/index-browsermodern.es.js`;
-    } else {
-      delete pkg['module:modern-browsers'];
-    }
-
-    const aliases = (this.entries || []).filter((entry) => entry !== 'index');
-
-    if (useBabel && aliases.length > 0 && (esNodeEnv || esAllBrowserEnv)) {
-      [esNodeEnv, esAllBrowserEnv, esModernBrowserEnv]
-        .filter(Boolean)
-        .forEach((env) => {
-          const key = (() => {
-            if (env.target === 'node') return 'node';
-            if (env.version === 'modern') return 'modern-browsers';
-            return 'browser';
-          })();
-
-          const envAliases =
-            this.entries.includes('index') && env.target === 'node'
-              ? aliases.filter((alias) => alias !== 'browser')
-              : aliases;
-          if (envAliases.length === 0) return;
-          pkg[`module:aliases-${key}`] = {};
-
-          envAliases.forEach((aliasName) => {
-            const isBrowserOnly =
-              aliasName === 'browser' && env.target !== 'node';
-            const aliasDistName = isBrowserOnly ? 'index' : aliasName;
-            pkg[`module:aliases-${key}`][`./${aliasName}.js`] = `./${
-              this.options.buildDirectory
-            }/${aliasDistName}-${env.target}${env.version || ''}.es.js`;
-          });
-        });
-    }
-
     /* webpack 5 and node with ESM support */
     if (useBabel) {
       pkg.exports = {
@@ -666,7 +614,7 @@ export default class CommonBabelGenerator extends Generator {
           pkg.exports[`./${exportName}`] =
             pkg.type === 'module'
               ? // eslint-disable-next-line unicorn/no-nested-ternary
-                exportName.endsWith('cjs')
+                exportName.endsWith('.cjs') || exportName.endsWith('.d.ts')
                 ? `./${exportName}`
                 : `./${exportName}.js`
               : {
@@ -690,23 +638,6 @@ export default class CommonBabelGenerator extends Generator {
 
     Object.keys(pkg).forEach((key) => {
       if (!key.startsWith('module:') && !key.startsWith('webpack:')) return;
-
-      // legacy
-      if (key.endsWith('-dev')) {
-        delete pkg[key];
-        return;
-      }
-
-      if (key.startsWith('module:aliases') && aliases.length > 0) {
-        if (key.startsWith('module:aliases-node') && esNodeEnv) return;
-        if (key.startsWith('module:aliases-browser') && esAllBrowserEnv) return;
-        if (
-          key.startsWith('module:aliases-modern-browsers') &&
-          esModernBrowserEnv
-        ) {
-          return;
-        }
-      }
       delete pkg[key];
     });
 
@@ -739,12 +670,17 @@ export default class CommonBabelGenerator extends Generator {
           this.destinationPath('rollup.config.mjs'),
           {
             config: this.options.useAppConfig,
+            outDirectory: this.options.buildDirectory,
           },
         );
       } else {
-        this.fs.copy(
-          this.templatePath('lib.rollup.config.mjs.txt'),
+        copyAndFormatTpl(
+          this.fs,
+          this.templatePath('lib.rollup.config.mjs.ejs'),
           this.destinationPath('rollup.config.mjs'),
+          {
+            outDirectory: this.options.buildDirectory,
+          },
         );
       }
     } else {

package/lib/generators/common/babel/templates/app.rollup.config.mjs.ejs

@@ -10,7 +10,7 @@ const watch = process.env.ROLLUP_WATCH === 'true';
 
 export default createRollupConfig({
   cwd: dirname(fileURLToPath(import.meta.url)),
-  outDirectory: 'build',
+  outDirectory: '<%= outDirectory %>',
   plugins: [
 <% if (config) { -%>
     config({

package/lib/generators/common/babel/templates/{lib.rollup.config.mjs.txt → lib.rollup.config.mjs.ejs}

@@ -4,4 +4,5 @@ import createRollupConfig from 'pob-babel/createRollupConfig.js';
 
 export default createRollupConfig({
   cwd: dirname(fileURLToPath(import.meta.url)),
+  outDirectory: '<%= outDirectory %>',
 });

package/lib/generators/common/format-lint/CommonLintGenerator.js

@@ -207,7 +207,8 @@ export default class CommonLintGenerator extends Generator {
 
     const yoConfigPobMonorepo = inLerna && inLerna.pobMonorepoConfig;
     const globalEslint =
-      yoConfigPobMonorepo && yoConfigPobMonorepo.eslint !== false;
+      this.options.monorepo ||
+      (yoConfigPobMonorepo && yoConfigPobMonorepo.eslint !== false);
     const globalTesting = yoConfigPobMonorepo && yoConfigPobMonorepo.testing;
     const composite = yoConfigPobMonorepo && yoConfigPobMonorepo.typescript;
     const { rootPackageManager, rootYarnNodeLinker } = inLerna || {};
@@ -239,7 +240,9 @@ export default class CommonLintGenerator extends Generator {
         true,
       );
     } else {
-      packageUtils.removeDevDependencies(pkg, ['prettier']);
+      if (pkg.name !== 'pob-monorepo') {
+        packageUtils.removeDevDependencies(pkg, ['prettier']);
+      }
       packageUtils.addOrRemoveDevDependencies(
         pkg,
         !globalEslint ||

package/lib/generators/common/testing/CommonTestingGenerator.js

@@ -61,6 +61,18 @@ export default class CommonTestingGenerator extends Generator {
       required: true,
       desc: 'is app',
     });
+
+    this.option('splitCIJobs', {
+      type: Boolean,
+      required: true,
+      desc: 'split CI jobs for faster result',
+    });
+
+    this.option('onlyLatestLTS', {
+      type: Boolean,
+      required: true,
+      desc: 'only latest lts',
+    });
   }
 
   default() {
@@ -75,6 +87,8 @@ export default class CommonTestingGenerator extends Generator {
         codecov: this.options.codecov,
         packageManager: this.options.packageManager,
         isApp: this.options.isApp,
+        splitJobs: this.options.splitCIJobs,
+        onlyLatestLTS: this.options.onlyLatestLTS,
       });
     } else {
       this.composeWith('pob:core:ci', {

package/lib/generators/common/typescript/templates/tsconfig.json.ejs

@@ -10,6 +10,9 @@
 <% } -%>
   "compilerOptions": {
     "rootDir": "<%= rootDir %>",
+<% if (baseUrl !== 'none') { -%>
+    "baseUrl": "<%= baseUrl %>", /* Base directory to resolve non-absolute module names. */
+<% } -%>
     "newLine": "lf",
 <% if (emit) { -%>
     "outDir": "dist/definitions",
@@ -56,13 +59,13 @@
     "forceConsistentCasingInFileNames": true,
 
     /* Module Resolution Options */
-    "moduleResolution": "node",               /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */
-    "allowSyntheticDefaultImports": true,     /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */
-    "esModuleInterop": true,                  /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */
-    <% if (resolveJsonModule) { -%>
+    "moduleResolution": "node" /* Specify module resolution strategy. */,
+  <% if (resolveJsonModule) { -%>
     "resolveJsonModule": <%= resolveJsonModule %>,
-    <% } -%>
-    "baseUrl": "<%= baseUrl %>"<% if (monorepoPackageSrcPaths) { %>,<% } %> /* Base directory to resolve non-absolute module names. */
+  <% } -%>
+    "allowSyntheticDefaultImports": true,     /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */
+    "esModuleInterop": true<% if (monorepoPackageSrcPaths) { %>,<% } %>                  /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */
+
     <% if (monorepoPackageSrcPaths && monorepoPackageSrcPaths.length !== 0) { -%>
     "paths": {
       <% monorepoPackageSrcPaths.forEach(([packageName, packageLocation], index) => { %>

package/lib/generators/core/ci/CoreCIGenerator.js

@@ -4,6 +4,8 @@ import inLerna from '../../../utils/inLerna.js';
 import * as packageUtils from '../../../utils/package.js';
 import { copyAndFormatTpl } from '../../../utils/writeAndFormat.js';
 
+export const ciContexts = [];
+
 export default class CoreCIGenerator extends Generator {
   constructor(args, opts) {
     super(args, opts);
@@ -69,10 +71,16 @@ export default class CoreCIGenerator extends Generator {
     });
 
     this.option('onlyLatestLTS', {
-      type: String,
+      type: Boolean,
       required: true,
       desc: 'only latest lts',
     });
+
+    this.option('splitJobs', {
+      type: Boolean,
+      required: true,
+      desc: 'split CI jobs for faster result',
+    });
   }
 
   async prompting() {
@@ -105,16 +113,25 @@ export default class CoreCIGenerator extends Generator {
     if (this.options.enable) {
       const pkg = this.fs.readJSON(this.destinationPath('package.json'));
 
+      const checks = !!pkg.scripts && !!pkg.scripts.checks;
+      const testing =
+        this.options.testing && !!pkg.scripts && !!pkg.scripts.test;
+      const build = this.options.build;
+
       copyAndFormatTpl(
         this.fs,
-        this.templatePath('github-action-node-workflow.yml.ejs'),
+        this.templatePath(
+          this.options.splitJobs
+            ? 'github-action-push-workflow-split.yml.ejs'
+            : 'github-action-push-workflow.yml.ejs',
+        ),
         this.destinationPath('.github/workflows/push.yml'),
         {
           packageManager: this.options.packageManager,
-          testing: this.options.testing && !!pkg.scripts && !!pkg.scripts.test,
-          checks: !!pkg.scripts && !!pkg.scripts.checks,
+          testing,
+          checks,
           documentation: this.options.documentation,
-          build: this.options.build,
+          build,
           typescript: this.options.typescript,
           codecov: this.options.codecov,
           onlyLatestLTS: this.options.onlyLatestLTS,
@@ -127,6 +144,22 @@ export default class CoreCIGenerator extends Generator {
             inLerna.pobConfig?.project?.type === 'lib',
         },
       );
+
+      ciContexts.push(
+        'reviewflow',
+        ...(this.options.splitJobs
+          ? [
+              checks && 'checks',
+              build && 'build',
+              'lint',
+              testing && !this.options.onlyLatestLTS && 'test (16)',
+              testing && 'test (18)',
+            ].filter(Boolean)
+          : [
+              !this.options.onlyLatestLTS && 'build (16.x)',
+              'build (18.x)',
+            ].filter(Boolean)),
+      );
     } else {
       this.fs.delete(this.destinationPath('.github/workflows/push.yml'));
     }

package/lib/generators/core/ci/templates/github-action-push-workflow-split.yml.ejs

@@ -0,0 +1,135 @@
+name: Push CI
+
+on: [push]
+
+jobs:
+<% if (checks) { -%>
+  checks:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v3
+
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 18
+
+      - name: Install Dependencies
+        run: yarn install --immutable --immutable-cache
+
+      - name: Checks
+        run: yarn run checks
+
+<% } -%>
+<% if (build) { -%>
+  build:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v3
+
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 18
+
+      - name: Install Dependencies
+        run: yarn install --immutable --immutable-cache
+
+      - name: Build
+        run: yarn run build
+
+      - name: Check nothing was forgotten before commit
+        run: yarn run repository-check-dirty
+
+<% } -%>
+  lint:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v3
+
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 18
+
+      - name: Install Dependencies
+        run: yarn install --immutable --immutable-cache
+
+      - name: Prettier
+        run: yarn run lint:prettier
+<% if (typescript) { -%>
+
+      - name: Typescript
+        run: yarn run tsc
+<% } -%>
+
+      - name: Eslint
+        run: yarn run lint:eslint
+<% if (testing) { -%>
+
+  test:
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node-version: [16, 18]
+
+    steps:
+      - uses: actions/checkout@v3
+
+      - uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node-version }}
+
+      - name: Install Dependencies
+        run: yarn install --immutable --immutable-cache
+
+<% if (codecov) { -%>
+      - name: Test
+        run: <%= packageManager %> run test
+        if: matrix.node-version != 18
+
+      - name: Generate Test Coverage
+        run: <%= packageManager %> run test --coverage --coverageReporters=json --coverageReporters=text
+        if: matrix.node-version == 18
+
+      - name: Send results to codecov
+        uses: codecov/codecov-action@v3
+        if: matrix.node-version == 18
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+<% } else { -%>
+
+      - name: Test
+        run: <%= packageManager %> run test
+<% } -%>
+<% } -%>
+<% if (isReleasePleaseEnabled) { -%>
+  release:
+    runs-on: ubuntu-latest
+
+    needs: [<%= checks ? '"checks", ' : '' -%><%= build ? '"build", ' : '' -%>"lint"<%= testing ? ', "test"' : '' -%>]
+
+    steps:
+      - uses: actions/checkout@v3
+
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 18
+
+      - uses: GoogleCloudPlatform/release-please-action@v3
+        if: ${{ github.ref == 'refs/heads/main' }}
+        id: release
+        with:
+          token: ${{ secrets.GH_TOKEN }}
+          release-type: node
+
+<% if (publishSinglePackage) { -%>
+
+      # publish:
+      - run: npm publish
+        if: ${{ github.ref == 'refs/heads/main' && steps.release.outputs.release_created }}
+        env:
+          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
+<% } -%>
+<% } -%>

package/lib/generators/core/ci/templates/{github-action-node-workflow.yml.ejs → github-action-push-workflow.yml.ejs}

@@ -1,4 +1,4 @@
-name: Node CI
+name: Push CI
 
 on: [push]
 
@@ -85,7 +85,6 @@ jobs:
         with:
           token: ${{ secrets.GH_TOKEN }}
           release-type: node
-          package-name: release-please-action
 
 <% if (publishSinglePackage) { -%>
 

package/lib/generators/core/git/CoreGitGenerator.js

@@ -15,10 +15,16 @@ export default class CoreGitGenerator extends Generator {
     });
 
     this.option('onlyLatestLTS', {
-      type: String,
+      type: Boolean,
       required: true,
       desc: 'only latest lts',
     });
+
+    this.option('splitCIJobs', {
+      type: Boolean,
+      required: true,
+      desc: 'split CI jobs for faster result',
+    });
   }
 
   async initializing() {
@@ -101,6 +107,7 @@ export default class CoreGitGenerator extends Generator {
         gitHostAccount: this.gitHostAccount,
         repoName: this.repoName,
         onlyLatestLTS: this.options.onlyLatestLTS,
+        splitCIJobs: this.options.splitCIJobs,
       });
     }
   }

package/lib/generators/core/git/generators/github/CoreGitGithubGenerator.js

@@ -2,6 +2,7 @@
 
 import fetch from 'node-fetch';
 import Generator from 'yeoman-generator';
+import { ciContexts } from '../../../ci/CoreCIGenerator.js';
 // const packageUtils = require('../../../../../utils/package');
 
 const GITHUB_TOKEN = process.env.POB_GITHUB_TOKEN;
@@ -30,11 +31,7 @@ const configureProtectionRule = async (owner, repo, onlyLatestLTS) => {
       await putJson(`repos/${owner}/${repo}/branches/${branch}/protection`, {
         required_status_checks: {
           strict: false,
-          contexts: [
-            !onlyLatestLTS && 'build (16.x)',
-            'build (18.x)',
-            'reviewflow',
-          ].filter(Boolean),
+          contexts: ciContexts,
         },
         enforce_admins: false, // true,
         required_pull_request_reviews: null,
@@ -79,11 +76,17 @@ export default class CoreGitGithubGenerator extends Generator {
     });
 
     this.option('onlyLatestLTS', {
-      type: String,
+      type: Boolean,
       required: true,
       desc: 'only latest lts',
     });
 
+    this.option('splitCIJobs', {
+      type: Boolean,
+      required: true,
+      desc: 'split CI jobs for faster result',
+    });
+
     if (!GITHUB_TOKEN && process.env.CI !== 'true') {
       throw new Error(
         'Missing POB_GITHUB_TOKEN. Create one with https://github.com/settings/tokens/new?scopes=repo&description=POB%20Generator and add it in your env variables.',

package/lib/generators/core/vscode/CoreVSCodeGenerator.js

@@ -148,6 +148,8 @@ export default class CoreVSCodeGenerator extends Generator {
                 : {}),
               ...(this.options.testing
                 ? {
+                    'jest.jestCommandLine':
+                      'NODE_OPTIONS=--experimental-vm-modules node_modules/.bin/jest',
                     // disable all folders to enable only root.
                     'jest.disabledWorkspaceFolders': folders.map(
                       (folder) => folder.name,

package/lib/generators/core/vscode/templates/settings.json.ejs

@@ -34,6 +34,12 @@
     "source.organizeImports": false
   },
 
+
+<% if (testing && module) { -%>
+  // jest
+  "jest.jestCommandLine": "NODE_OPTIONS=--experimental-vm-modules node_modules/.bin/jest",
+<% } -%>
+
   // eslint config
   "eslint.workingDirectories": ["."],
   "eslint.options": {

package/lib/generators/lib/PobLibGenerator.js

@@ -228,7 +228,7 @@ export default class PobLibGenerator extends Generator {
       dom: browser,
       jsx,
       updateOnly: this.options.updateOnly,
-      baseUrl: './src',
+      baseUrl: 'none', // causes issues on dist definition files
       builddefs: true,
     });
 
@@ -254,6 +254,7 @@ export default class PobLibGenerator extends Generator {
       ci: this.pobjson.testing && this.pobjson.testing.ci,
       packageManager: this.options.packageManager,
       isApp: false,
+      splitCIJobs: false,
     });
 
     // must be after testing

package/lib/generators/monorepo/PobMonorepoGenerator.js

@@ -73,6 +73,12 @@ export default class PobMonorepoGenerator extends Generator {
       defaults: 'pnp',
       desc: 'Defines what linker should be used for installing Node packages (useful to enable the node-modules plugin), one of: pnp, node-modules.',
     });
+
+    this.option('onlyLatestLTS', {
+      type: Boolean,
+      required: true,
+      desc: 'only latest lts',
+    });
   }
 
   async initializing() {
@@ -206,6 +212,8 @@ export default class PobMonorepoGenerator extends Generator {
       this.pobLernaConfig.ci &&
       !pkg.devDependencies?.['@pob/lerna-light'];
 
+    const splitCIJobs = this.packageNames.length > 8;
+
     this.composeWith('pob:common:testing', {
       monorepo: true,
       enable: this.pobLernaConfig.testing,
@@ -217,6 +225,8 @@ export default class PobMonorepoGenerator extends Generator {
       ci: this.pobLernaConfig.ci,
       packageManager: this.options.packageManager,
       isApp: this.options.isAppProject,
+      onlyLatestLTS: this.options.onlyLatestLTS,
+      splitCIJobs,
     });
 
     this.composeWith('pob:common:format-lint', {

package/lib/generators/monorepo/lerna/templates/workflow-publish.yml.ejs

@@ -27,7 +27,7 @@ jobs:
         if: |
           github.ref == 'refs/heads/main'
           && contains(github.event.inputs.dry-run, 'y')
-        run: yarn lerna version --yes --no-push --exact --conventional-commits --conventional-graduate --no-git-tag-version --loglevel=verbose
+        run: yarn lerna version --yes --no-push --exact --conventional-commits --conventional-graduate --changelog-preset conventional-changelog-conventionalcommits --no-git-tag-version --loglevel=verbose
 
       - name: Configure Git user
         if: |
@@ -42,7 +42,7 @@ jobs:
           github.ref == 'refs/heads/main'
           && contains(github.event.inputs.dry-run, 'y') == false
         run: |
-          yarn lerna version --yes --push --exact --conventional-commits --conventional-graduate --create-release=github -m 'chore: release [skip ci]'
+          yarn lerna version --yes --push --exact --conventional-commits --conventional-graduate --changelog-preset conventional-changelog-conventionalcommits --create-release=github -m 'chore: release [skip ci]'
         env:
           HUSKY: 0
           GH_TOKEN: ${{ secrets.GH_TOKEN }}

package/lib/generators/pob/PobBaseGenerator.js

@@ -1,3 +1,4 @@
+import { fileURLToPath } from 'url';
 import Generator from 'yeoman-generator';
 import ensureJsonFileFormatted from '../../utils/ensureJsonFileFormatted.js';
 import inLerna from '../../utils/inLerna.js';
@@ -162,8 +163,11 @@ export default class PobBaseGenerator extends Generator {
           inLerna.pobConfig?.project?.onlyLatestLTS === true));
 
     if (!this.inLerna) {
+      const splitCIJobs =
+        inLerna && inLerna.pobMonorepoConfig?.packageNames.length > 8;
       this.composeWith('pob:core:git', {
         onlyLatestLTS,
+        splitCIJobs,
       });
     } else {
       if (this.fs.exists('.git-hooks')) this.fs.delete('.git-hooks');
@@ -186,12 +190,19 @@ export default class PobBaseGenerator extends Generator {
     }
 
     if (this.useLerna) {
-      this.composeWith('pob:monorepo', {
-        updateOnly: this.options.updateOnly,
-        isAppProject: this.projectConfig.type === 'app',
-        packageManager: this.projectConfig.packageManager,
-        yarnNodeLinker: this.projectConfig.yarnNodeLinker,
-      });
+      this.composeWith(
+        // pob:monorepo <= for searching PobMonorepoGenerator.js
+        fileURLToPath(
+          new URL('../monorepo/PobMonorepoGenerator.js', import.meta.url),
+        ),
+        {
+          updateOnly: this.options.updateOnly,
+          isAppProject: this.projectConfig.type === 'app',
+          packageManager: this.projectConfig.packageManager,
+          yarnNodeLinker: this.projectConfig.yarnNodeLinker,
+          onlyLatestLTS,
+        },
+      );
     } else {
       switch (this.projectConfig.type) {
         case 'lib':

package/lib/pob.js

@@ -1,7 +1,13 @@
 #!/usr/bin/env node
 
-import { spawnSync } from 'child_process';
-import fs, { existsSync, writeFileSync, readFileSync } from 'fs';
+import { execSync, spawnSync } from 'child_process';
+import fs, {
+  existsSync,
+  writeFileSync,
+  readFileSync,
+  mkdirSync,
+  readdirSync,
+} from 'fs';
 import path from 'path';
 import minimist from 'minimist';
 import yeoman from 'yeoman-environment';
@@ -30,7 +36,6 @@ import CoreYarnGenerator from './generators/core/yarn/CoreYarnGenerator.js';
 import PobLibGenerator from './generators/lib/PobLibGenerator.js';
 import LibDocGenerator from './generators/lib/doc/LibDocGenerator.js';
 import LibReadmeGenerator from './generators/lib/readme/LibReadmeGenerator.js';
-import PobMonorepoGenerator from './generators/monorepo/PobMonorepoGenerator.js';
 import MonorepoLernaGenerator from './generators/monorepo/lerna/MonorepoLernaGenerator.js';
 import MonorepoTypescriptGenerator from './generators/monorepo/typescript/MonorepoTypescriptGenerator.js';
 import PobBaseGenerator from './generators/pob/PobBaseGenerator.js';
@@ -202,11 +207,6 @@ env.registerStub(
   'pob:lib:readme',
   `${__dirname}/generators/lib/readme/LibReadmeGenerator.js`,
 );
-env.registerStub(
-  PobMonorepoGenerator,
-  'pob:monorepo',
-  `${__dirname}/generators/monorepo/PobMonorepoGenerator.js`,
-);
 env.registerStub(
   MonorepoLernaGenerator,
   'pob:monorepo:lerna',
@@ -230,7 +230,7 @@ if (action === 'add') {
     );
   }
 
-  const packageName = monorepo ? argv._[2] : argv._[1];
+  const packageName = monorepoArg ? argv._[2] : argv._[1];
 
   if (!packageName) {
     console.error('Missing argument: packageName');
@@ -260,6 +260,48 @@ if (action === 'add') {
   process.exit(0);
 }
 
+if (action === 'migrate-to-monorepo') {
+  if (projectPkg.workspaces) {
+    throw new Error('workspaces field already exists in package.json');
+  }
+
+  mkdirSync('packages');
+  mkdirSync(`packages/${projectPkg.name}`);
+
+  readdirSync('.').forEach((filename) => {
+    if (
+      ![
+        '.git',
+        '.vscode',
+        '.github',
+        '.husky',
+        '.yarn',
+        '.yarnrc.yml',
+        'packages',
+        'lint-staged.config.js',
+        'yarn.lock',
+      ].includes(filename)
+    ) {
+      execSync(`mv "${filename}" "packages/${projectPkg.name}/"`);
+    }
+  });
+
+  const monorepoName = `${path.basename(process.cwd())}-monorepo`;
+  const monorepoPkg = {
+    name: monorepoName,
+    version: projectPkg.version,
+    author: projectPkg.author,
+    license: projectPkg.license,
+    repository: projectPkg.repository,
+    engines: projectPkg.engines,
+    packageManager: projectPkg.packageManager,
+  };
+
+  writeFileSync('package.json', JSON.stringify(monorepoPkg, null, 2));
+
+  monorepo = true;
+}
+
 const updateOnly = action === 'update';
 const init = action === 'init';
 const type = updateOnly || init ? null : action;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "11.6.0",
+  "version": "11.8.0",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -28,6 +28,7 @@
   "sideEffects": false,
   "bin": "./lib/pob.js",
   "scripts": {
+    "clean:build": "true",
     "format": "prettier --write",
     "lint": "yarn run lint:eslint",
     "lint:eslint": "yarn ../.. run eslint --report-unused-disable-directives --resolve-plugins-relative-to . --quiet packages/pob"
@@ -40,10 +41,10 @@
     "@pob/eslint-config": "50.0.0",
     "@pob/eslint-config-typescript": "50.0.0",
     "@pob/eslint-config-typescript-react": "50.0.0",
-    "@pob/sort-eslint-config": "4.1.0",
-    "@pob/sort-object": "5.1.0",
-    "@pob/sort-pkg": "5.1.0",
-    "eslint": "8.33.0",
+    "@pob/sort-eslint-config": "4.1.1",
+    "@pob/sort-object": "5.1.1",
+    "@pob/sort-pkg": "5.2.0",
+    "eslint": "8.36.0",
     "findup-sync": "^5.0.0",
     "git-remote-url": "^1.0.1",
     "github-username": "^6.0.0",
@@ -52,19 +53,19 @@
     "json5": "^2.2.2",
     "lodash.camelcase": "^4.3.0",
     "lodash.kebabcase": "^4.1.1",
-    "mem-fs": "2.2.1",
-    "mem-fs-editor": "9.6.0",
-    "minimist": "1.2.7",
-    "node-fetch": "3.3.0",
+    "mem-fs": "2.3.0",
+    "mem-fs-editor": "9.7.0",
+    "minimist": "1.2.8",
+    "node-fetch": "3.3.1",
     "parse-author": "2.0.0",
-    "pob-dependencies": "7.4.0",
-    "prettier": "2.8.3",
+    "pob-dependencies": "7.6.0",
+    "prettier": "2.8.4",
     "semver": "7.3.8",
-    "yeoman-environment": "3.13.0",
-    "yeoman-generator": "5.7.0"
+    "yeoman-environment": "3.15.1",
+    "yeoman-generator": "5.8.0"
   },
   "devDependencies": {
-    "@pob/root": "7.4.0"
+    "@pob/root": "7.6.0"
   },
-  "gitHead": "d86944c4c849541089525ae17313aff0c2042bf9"
+  "gitHead": "e5930068baa1efff95c4918b66a1c8c9da3a35a8"
 }