pob 11.4.3 → 11.5.0

package/CHANGELOG.md

@@ -3,6 +3,31 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [11.5.0](https://github.com/christophehurpeau/pob/compare/pob@11.4.3...pob@11.5.0) (2022-12-30)
+
+
+### Bug Fixes
+
+* add fixes for windows ([930c09e](https://github.com/christophehurpeau/pob/commit/930c09ead7e8757a1a37e7ed92c251917c3d1571))
+* **deps:** update dependency prettier to v2.8.1 ([#1476](https://github.com/christophehurpeau/pob/issues/1476)) ([d9b8ef2](https://github.com/christophehurpeau/pob/commit/d9b8ef2e75c5c9a5e1d0a573a6c2fa81857f3f8e))
+* downgrade lerna and make sure nx is not installed ([45523f1](https://github.com/christophehurpeau/pob/commit/45523f167467bcab9d9435d9089eccc46ae5947d))
+* fixes in jest configs for windows ([b66306f](https://github.com/christophehurpeau/pob/commit/b66306f3e9cdd64b7ed8503ddab6da3947014a3f))
+* remove jest.nodeEnv as yarn test is used by default ([b96d6d6](https://github.com/christophehurpeau/pob/commit/b96d6d6b7fa090b838242728e7d5277ef87b17bd))
+* update json5 ([808e9a5](https://github.com/christophehurpeau/pob/commit/808e9a5f7be5b7460945b9748fd950ed3ddc1e9a))
+
+
+### Features
+
+* **deps:** update @pob/eslint-config to v50 (major) ([#1459](https://github.com/christophehurpeau/pob/issues/1459)) ([8180c9b](https://github.com/christophehurpeau/pob/commit/8180c9bbfc09a9101862d2568808d2ea1ad7e72f))
+* **deps:** update dependency eslint to v8.29.0 ([#1472](https://github.com/christophehurpeau/pob/issues/1472)) ([a77364c](https://github.com/christophehurpeau/pob/commit/a77364cd6805b945b2964e1bd1071f390c2408e7))
+* **deps:** update dependency eslint to v8.30.0 ([#1484](https://github.com/christophehurpeau/pob/issues/1484)) ([4e7a2b0](https://github.com/christophehurpeau/pob/commit/4e7a2b0e5adb299c409367490f353d000c475d75))
+* **deps:** update dependency prettier to v2.8.0 ([#1461](https://github.com/christophehurpeau/pob/issues/1461)) ([2ca692d](https://github.com/christophehurpeau/pob/commit/2ca692d78f53a99a3ef43af1a01df626e5bb5d70))
+* **deps:** update dependency yeoman-environment to v3.13.0 ([#1469](https://github.com/christophehurpeau/pob/issues/1469)) ([371b679](https://github.com/christophehurpeau/pob/commit/371b679f6c099497316ca51f00452596216b32a5))
+
+
+
+
+
 ## [11.4.3](https://github.com/christophehurpeau/pob/compare/pob@11.4.2...pob@11.4.3) (2022-11-19)
 
 

package/lib/generators/app/PobAppGenerator.js

@@ -1,4 +1,5 @@
 import { execSync } from 'child_process';
+import { platform } from 'process';
 import Generator from 'yeoman-generator';
 import inLerna from '../../utils/inLerna.js';
 import * as packageUtils from '../../utils/package.js';
@@ -246,11 +247,13 @@ export default class PobAppGenerator extends Generator {
         break;
     }
 
-    execSync(
-      `rm -Rf ${['lib-*', 'coverage', 'docs', 'dist']
-        .filter(Boolean)
-        .join(' ')}`,
-    );
+    if (platform !== 'win32') {
+      execSync(
+        `rm -Rf ${['lib-*', 'coverage', 'docs', 'dist']
+          .filter(Boolean)
+          .join(' ')}`,
+      );
+    }
   }
 
   writing() {

package/lib/generators/common/testing/CommonTestingGenerator.js

@@ -160,7 +160,7 @@ export default class CommonTestingGenerator extends Generator {
         const workspacesPattern =
           workspacesWithoutStar.length === 1
             ? workspacesWithoutStar[0]
-            : `(${workspacesWithoutStar.join('|')})`;
+            : `@(${workspacesWithoutStar.join('|')})`;
         hasReact = yoConfigPobMonorepo.packageNames.some((pkgName) =>
           pkgName.startsWith('react-'),
         );
@@ -170,10 +170,10 @@ export default class CommonTestingGenerator extends Generator {
           cacheDirectory: './node_modules/.cache/jest',
           testEnvironment: 'node',
           testMatch: [
-            `<rootDir>/${workspacesPattern}/*/(src|lib)/**/__tests__/**/*.${
+            `<rootDir>/${workspacesPattern}/*/@(src|lib)/**/__tests__/**/*.${
               transpileWithBabel ? '(ts|js|cjs|mjs)' : '(js|cjs|mjs)'
             }${hasReact ? '?(x)' : ''}`,
-            `<rootDir>/${workspacesPattern}/*/(src|lib)/**/*.test.${
+            `<rootDir>/${workspacesPattern}/*/@(src|lib)/**/*.test.${
               transpileWithBabel ? '(ts|js|cjs|mjs)' : '(js|cjs|mjs)'
             }${hasReact ? '?(x)' : ''}`,
           ],

package/lib/generators/core/vscode/CoreVSCodeGenerator.js

@@ -148,8 +148,6 @@ export default class CoreVSCodeGenerator extends Generator {
                 : {}),
               ...(this.options.testing
                 ? {
-                    'jest.jestCommandLine':
-                      'NODE_OPTIONS=--experimental-vm-modules node_modules/.bin/jest',
                     // disable all folders to enable only root.
                     'jest.disabledWorkspaceFolders': folders.map(
                       (folder) => folder.name,

package/lib/generators/core/vscode/templates/settings.json.ejs

@@ -34,11 +34,6 @@
     "source.organizeImports": false
   },
 
-<% if (testing && module) { -%>
-  // jest
-  "jest.jestCommandLine": "NODE_OPTIONS=--experimental-vm-modules node_modules/.bin/jest",
-<% } -%>
-
   // eslint config
   "eslint.workingDirectories": ["."],
   "eslint.options": {

package/lib/generators/core/yarn/CoreYarnGenerator.js

@@ -119,9 +119,13 @@ export default class CoreYarnGenerator extends Generator {
       if (this.options.yarnNodeLinker === 'pnp') {
         this.spawnCommandSync('yarn', ['dlx', '@yarnpkg/sdks', 'vscode']);
       } else {
-        this.spawnCommandSync('rm', ['-Rf', '.yarn/sdks']);
+        this.fs.delete('.yarn/sdks');
       }
-      this.spawnCommandSync('yarn', ['install']);
+      this.spawnCommandSync('yarn', ['install'], {
+        env: {
+          YARN_ENABLE_IMMUTABLE_INSTALLS: 'false',
+        },
+      });
       this.spawnCommandSync('yarn', ['dedupe']);
 
       this.spawnCommandSync('yarn', ['prettier', '--write', '.vscode']);

package/lib/generators/monorepo/PobMonorepoGenerator.js

@@ -1,6 +1,7 @@
 import { execSync } from 'child_process';
 import fs from 'fs';
 import path from 'path';
+import { platform } from 'process';
 import { PackageGraph } from '@lerna/package-graph';
 import { Project as LernaProject } from '@lerna/project';
 import Generator from 'yeoman-generator';
@@ -103,7 +104,10 @@ export default class PobMonorepoGenerator extends Generator {
       this.packages.push(...batch.map((node) => node.pkg));
       this.packageLocations.push(
         ...batch.map((node) =>
-          path.relative(this.destinationPath(), node.location),
+          path
+            .relative(this.destinationPath(), node.location)
+            // transform windows path to linux
+            .replace(/\\+/g, '/'),
         ),
       );
 
@@ -282,9 +286,11 @@ export default class PobMonorepoGenerator extends Generator {
 
     this.fs.writeJSON(this.destinationPath('package.json'), pkg);
 
-    execSync(
-      `rm -Rf ${['lib-*', 'coverage', 'docs'].filter(Boolean).join(' ')}`,
-    );
+    if (platform !== 'win32') {
+      execSync(
+        `rm -Rf ${['lib-*', 'coverage', 'docs'].filter(Boolean).join(' ')}`,
+      );
+    }
   }
 
   writing() {

package/lib/generators/monorepo/lerna/MonorepoLernaGenerator.js

@@ -171,6 +171,15 @@ export default class MonorepoLernaGenerator extends Generator {
           : 'npm run lint:eslint --workspaces',
     });
 
+    packageUtils.addOrRemoveScripts(
+      pkg,
+      this.options.packageManager === 'yarn',
+      {
+        version:
+          'YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn && git add yarn.lock',
+      },
+    );
+
     this.fs.copyTpl(
       this.templatePath('workflow-publish.yml.ejs'),
       this.destinationPath('.github/workflows/publish.yml'),
@@ -208,7 +217,6 @@ export default class MonorepoLernaGenerator extends Generator {
     // }
 
     delete pkg.scripts.postbuild;
-    delete pkg.scripts.version;
     delete pkg.scripts.prepublishOnly;
 
     if (this.npm) {

package/lib/utils/inLerna.js

@@ -36,7 +36,10 @@ const getInLernaThings = () => {
       rootYoConfig.pob &&
       rootYoConfig.pob.project &&
       rootYoConfig.pob.project.yarnNodeLinker,
-    relative: path.relative(rootMonorepo, cwd),
+    relative: path
+      .relative(rootMonorepo, cwd)
+      // transform windows to linux-like paths
+      .replace(/\\+/g, '/'),
     rootYoConfig,
     pobConfig: rootYoConfig && rootYoConfig.pob,
     pobMonorepoConfig:

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "11.4.3",
+  "version": "11.5.0",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -35,21 +35,21 @@
   "prettier": "@pob/root/prettier-config",
   "pob": {},
   "dependencies": {
-    "@lerna/package-graph": "^5.0.0",
-    "@lerna/project": "^5.0.0",
-    "@pob/eslint-config": "49.4.0",
-    "@pob/eslint-config-typescript": "49.4.0",
-    "@pob/eslint-config-typescript-react": "49.4.0",
+    "@lerna/package-graph": "5.5.4",
+    "@lerna/project": "5.5.4",
+    "@pob/eslint-config": "50.0.0",
+    "@pob/eslint-config-typescript": "50.0.0",
+    "@pob/eslint-config-typescript-react": "50.0.0",
     "@pob/sort-eslint-config": "4.1.0",
     "@pob/sort-object": "5.1.0",
     "@pob/sort-pkg": "5.1.0",
-    "eslint": "8.28.0",
+    "eslint": "8.30.0",
     "findup-sync": "^5.0.0",
     "git-remote-url": "^1.0.1",
     "github-username": "^6.0.0",
     "inquirer-npm-name": "^4.0.0",
     "js-yaml": "^4.1.0",
-    "json5": "^2.2.1",
+    "json5": "^2.2.2",
     "lodash.camelcase": "^4.3.0",
     "lodash.kebabcase": "^4.1.1",
     "mem-fs": "2.2.1",
@@ -57,14 +57,14 @@
     "minimist": "1.2.7",
     "node-fetch": "3.3.0",
     "parse-author": "2.0.0",
-    "pob-dependencies": "7.2.0",
-    "prettier": "2.7.1",
+    "pob-dependencies": "7.3.0",
+    "prettier": "2.8.1",
     "semver": "7.3.8",
-    "yeoman-environment": "3.12.1",
+    "yeoman-environment": "3.13.0",
     "yeoman-generator": "5.7.0"
   },
   "devDependencies": {
-    "@pob/root": "7.2.0"
+    "@pob/root": "7.3.0"
   },
-  "gitHead": "7dd064381689bf8324f688292bfa0bf266d2ec24"
+  "gitHead": "d8f2ef86402ce3aa4c7bf9d0f02175bf7be2751a"
 }