pob 11.2.0 → 11.3.0

package/CHANGELOG.md

@@ -3,6 +3,24 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [11.3.0](https://github.com/christophehurpeau/pob/compare/pob@11.2.0...pob@11.3.0) (2022-11-15)
+
+
+### Bug Fixes
+
+* **pob:** fix in babel generator when formats is not defined ([8f975c8](https://github.com/christophehurpeau/pob/commit/8f975c84a9ef48475fbd70979b8a86ede5d8f3e6))
+* **pob:** fix in babel generator when formats is not defined ([3a0fe7d](https://github.com/christophehurpeau/pob/commit/3a0fe7d8a5b937b8bdf31486e0d9cd86aa06acee))
+
+
+### Features
+
+* **pob:** improve lint:eslint and add test scripts in monorepo ([3d6c9d5](https://github.com/christophehurpeau/pob/commit/3d6c9d5f462bf11e57683b2fa1fe198503eb4f71))
+* **pob:** remove formats when cjs not in it ([e86d3f4](https://github.com/christophehurpeau/pob/commit/e86d3f4589ea19d32614ba1198018122229b1a45))
+
+
+
+
+
 # [11.2.0](https://github.com/christophehurpeau/pob/compare/pob@11.1.0...pob@11.2.0) (2022-11-15)
 
 

package/lib/generators/common/babel/CommonBabelGenerator.js

@@ -106,8 +106,10 @@ export default class CommonBabelGenerator extends Generator {
       .filter((env) => env.target === 'browser')
       .map((env) => (env.version === undefined ? 'supported' : env.version));
     const formats = [
-      babelEnvs.some((env) => env.formats.includes('cjs')) ? 'cjs' : undefined,
-      babelEnvs.some((env) => env.formats.includes('es')) ? 'es' : undefined,
+      babelEnvs.some((env) => env.formats?.includes('cjs')) ? 'cjs' : undefined,
+      babelEnvs.some((env) => !env.formats || env.formats.includes('es'))
+        ? 'es'
+        : undefined,
     ].filter(Boolean);
     const jsx =
       (pkg.pob.jsx || pkg.pob.withReact) === undefined
@@ -201,8 +203,8 @@ export default class CommonBabelGenerator extends Generator {
             ? // eslint-disable-next-line unicorn/no-nested-ternary
               version === '16'
               ? babelConfig.formats
-              : ['es']
-            : babelConfig.formats || ['es'],
+              : undefined
+            : undefined,
       })),
       ...(babelConfig.browserVersions || []).map((version) => ({
         target: 'browser',
@@ -212,8 +214,8 @@ export default class CommonBabelGenerator extends Generator {
             ? // eslint-disable-next-line unicorn/no-nested-ternary
               version === 'supported'
               ? babelConfig.formats
-              : ['es']
-            : babelConfig.formats || ['es'],
+              : undefined
+            : undefined,
       })),
     ];
 
@@ -505,18 +507,19 @@ export default class CommonBabelGenerator extends Generator {
       (env) =>
         env.target === 'browser' &&
         env.version === undefined &&
-        env.formats.includes('es'),
+        (!env.formats || env.formats.includes('es')),
     );
 
     const esModernBrowserEnv = this.babelEnvs.find(
       (env) =>
         env.target === 'browser' &&
         env.version === 'modern' &&
-        env.formats.includes('es'),
+        (!env.formats || env.formats.includes('es')),
     );
 
     const esNodeEnv = this.babelEnvs.find(
-      (env) => env.target === 'node' && env.formats.includes('es'),
+      (env) =>
+        env.target === 'node' && (!env.formats || env.formats.includes('es')),
     );
 
     // Legacy "dev" builds
@@ -601,13 +604,13 @@ export default class CommonBabelGenerator extends Generator {
 
           if (target === 'node') {
             const cjsExt = pkg.type === 'module' ? 'cjs' : 'cjs.js';
-            if (formats.includes('es')) {
+            if (!formats || formats.includes('es')) {
               exportTarget.import = `./${this.options.buildDirectory}/${entryDistName}-${target}${version}.mjs`;
 
-              if (formats.includes('cjs')) {
+              if (formats && formats.includes('cjs')) {
                 exportTarget.require = `./${this.options.buildDirectory}/${entryDistName}-${target}${version}.${cjsExt}`;
               }
-            } else if (formats.includes('cjs')) {
+            } else if (formats && formats.includes('cjs')) {
               exportTarget.default = `./${this.options.buildDirectory}/${entryDistName}-${target}${version}.${cjsExt}`;
             }
             // eslint: https://github.com/benmosher/eslint-plugin-import/issues/2132
@@ -621,13 +624,13 @@ export default class CommonBabelGenerator extends Generator {
                     exportTarget.import;
             }
           } else if (target === 'browser') {
-            if (formats.includes('es')) {
+            if (!formats || formats.includes('es')) {
               exportTarget.import = `./${
                 this.options.buildDirectory
               }/${entryDistName}-${target}${version || ''}.es.js`;
             }
 
-            if (formats.includes('cjs')) {
+            if (formats && formats.includes('cjs')) {
               exportTarget.require = `./${
                 this.options.buildDirectory
               }/index-${target}${version || ''}.cjs.js`;

package/lib/generators/common/format-lint/CommonLintGenerator.js

@@ -524,7 +524,7 @@ export default class CommonLintGenerator extends Generator {
 
       packageUtils.addScripts(pkg, {
         'lint:eslint': globalEslint
-          ? `cd ../.. && yarn run eslint ${args} ${path
+          ? `yarn ../.. run eslint ${args} ${path
               .relative('../..', '.')
               .replace('\\', '/')}`
           : `eslint ${args} ${lintPaths.join(' ')}`,

package/lib/generators/common/testing/CommonTestingGenerator.js

@@ -1,3 +1,4 @@
+import path from 'node:path';
 import Generator from 'yeoman-generator';
 import inLerna from '../../../utils/inLerna.js';
 import * as packageUtils from '../../../utils/package.js';
@@ -189,10 +190,14 @@ export default class CommonTestingGenerator extends Generator {
       } else if (globalTesting) {
         delete pkg.jest;
         if (pkg.scripts) {
-          delete pkg.scripts.test;
           delete pkg.scripts['generate:test-coverage'];
           delete pkg.scripts['test:watch'];
         }
+        pkg.addScripts(pkg, {
+          test: `yarn ../../ run test -- ${path
+            .relative('../..', '.')
+            .replace('\\', '/')}`,
+        });
       } else {
         const babelEnvs = pkg.pob.babelEnvs || [];
         const transpileWithBabel = packageUtils.transpileWithBabel(pkg);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "11.2.0",
+  "version": "11.3.0",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -66,5 +66,5 @@
   "devDependencies": {
     "@pob/root": "7.1.1"
   },
-  "gitHead": "6b13781b3dd2e49813ac3740c2706fe610152b5d"
+  "gitHead": "33e161c4d1126092c4ab2dfa490a03ac6359e663"
 }