pob 10.2.1 → 10.3.0

package/CHANGELOG.md

@@ -3,6 +3,24 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [10.3.0](https://github.com/christophehurpeau/pob/compare/pob@10.2.1...pob@10.3.0) (2022-02-20)
+
+
+### Bug Fixes
+
+* alllow "allow-unsafe" in extends in eslint configs ([e1c0d69](https://github.com/christophehurpeau/pob/commit/e1c0d695feaba044c8a80d430254481854861dec))
+* **pob:** fix tsconfig references for apps ([ea5e185](https://github.com/christophehurpeau/pob/commit/ea5e185ae67ded3ea55f5d4bc992e9526ba98c0a))
+* use buid directory option in babel generator ([03a6754](https://github.com/christophehurpeau/pob/commit/03a6754a5356ed97dd39dc4e9292126f0696a44e))
+
+
+### Features
+
+* experimental vscode tasks generator ([d7a727f](https://github.com/christophehurpeau/pob/commit/d7a727fa1f8aec1e0f6f56b8219ea781b0759240))
+
+
+
+
+
 ## [10.2.1](https://github.com/christophehurpeau/pob/compare/pob@10.2.0...pob@10.2.1) (2022-02-19)
 
 

package/lib/generators/common/babel/CommonBabelGenerator.js

@@ -470,7 +470,9 @@ export default class CommonBabelGenerator extends Generator {
     if (useBabel) {
       // see pkg.exports instead.
       delete pkg.main;
-      if (!this.options.isApp) pkg.types = './dist/index.d.ts';
+      if (!this.options.isApp) {
+        pkg.types = `./${this.options.buildDirectory}/index.d.ts`;
+      }
     } else {
       if (!pkg.main) {
         pkg.exports = './lib/index.js';
@@ -529,15 +531,17 @@ export default class CommonBabelGenerator extends Generator {
 
     /* webpack 4 */
     if (esAllBrowserEnv) {
-      pkg.module = './dist/index-browser.es.js';
-      pkg.browser = './dist/index-browser.es.js';
+      pkg.module = `./${this.options.buildDirectory}/index-browser.es.js`;
+      pkg.browser = `./${this.options.buildDirectory}/index-browser.es.js`;
     } else {
       delete pkg.module;
       delete pkg.browser;
     }
 
     if (esModernBrowserEnv) {
-      pkg['module:modern-browsers'] = './dist/index-browsermodern.es.js';
+      pkg[
+        'module:modern-browsers'
+      ] = `./${this.options.buildDirectory}/index-browsermodern.es.js`;
     } else {
       delete pkg['module:modern-browsers'];
     }
@@ -546,7 +550,7 @@ export default class CommonBabelGenerator extends Generator {
       // webpack 4 node
       pkg[
         'module:node'
-      ] = `./dist/index-${esNodeEnv.target}${esNodeEnv.version}.mjs`;
+      ] = `./${this.options.buildDirectory}/index-${esNodeEnv.target}${esNodeEnv.version}.mjs`;
     }
 
     const aliases = (this.entries || []).filter((entry) => entry !== 'index');
@@ -572,11 +576,9 @@ export default class CommonBabelGenerator extends Generator {
             const isBrowserOnly =
               aliasName === 'browser' && env.target !== 'node';
             const aliasDistName = isBrowserOnly ? 'index' : aliasName;
-            pkg[`module:aliases-${key}`][
-              `./${aliasName}.js`
-            ] = `./dist/${aliasDistName}-${env.target}${
-              env.version || ''
-            }.es.js`;
+            pkg[`module:aliases-${key}`][`./${aliasName}.js`] = `./${
+              this.options.buildDirectory
+            }/${aliasDistName}-${env.target}${env.version || ''}.es.js`;
           });
         });
     }
@@ -610,13 +612,13 @@ export default class CommonBabelGenerator extends Generator {
           if (target === 'node') {
             const cjsExt = pkg.type === 'module' ? 'cjs' : 'cjs.js';
             if (formats.includes('es')) {
-              exportTarget.import = `./dist/${entryDistName}-${target}${version}.mjs`;
+              exportTarget.import = `./${this.options.buildDirectory}/${entryDistName}-${target}${version}.mjs`;
 
               if (formats.includes('cjs')) {
-                exportTarget.require = `./dist/${entryDistName}-${target}${version}.${cjsExt}`;
+                exportTarget.require = `./${this.options.buildDirectory}/${entryDistName}-${target}${version}.${cjsExt}`;
               }
             } else if (formats.includes('cjs')) {
-              exportTarget.default = `./dist/${entryDistName}-${target}${version}.${cjsExt}`;
+              exportTarget.default = `./${this.options.buildDirectory}/${entryDistName}-${target}${version}.${cjsExt}`;
             }
             // eslint: https://github.com/benmosher/eslint-plugin-import/issues/2132
             // jest: https://github.com/facebook/jest/issues/9771
@@ -630,15 +632,15 @@ export default class CommonBabelGenerator extends Generator {
             }
           } else if (target === 'browser') {
             if (formats.includes('es')) {
-              exportTarget.import = `./dist/${entryDistName}-${target}${
-                version || ''
-              }.es.js`;
+              exportTarget.import = `./${
+                this.options.buildDirectory
+              }/${entryDistName}-${target}${version || ''}.es.js`;
             }
 
             if (formats.includes('cjs')) {
-              exportTarget.require = `./dist/index-${target}${
-                version || ''
-              }.cjs.js`;
+              exportTarget.require = `./${
+                this.options.buildDirectory
+              }/index-${target}${version || ''}.cjs.js`;
             }
           }
 

package/lib/generators/common/format-lint/updateEslintConfig.js

@@ -112,7 +112,15 @@ export default function updateEslintConfig(
   },
 ) {
   config.root = true;
-  config.extends = extendsConfig;
+  config.extends = [
+    ...extendsConfig,
+    ...(config?.extends
+      ? config.extends.filter(
+          (extendsValue) =>
+            extendsValue === '@pob/eslint-config-typescript/allow-unsafe',
+        )
+      : []),
+  ];
 
   config = updateParserAndPlugins(
     config,

package/lib/generators/common/typescript/CommonTypescriptGenerator.js

@@ -78,6 +78,7 @@ export default class CommonTypescriptGenerator extends Generator {
     if (this.options.enable) {
       const { jsx, dom } = this.options;
       let composite;
+      let monorepoPackageReferences;
       let monorepoPackageBuildReferences;
       let monorepoPackageSrcPaths;
 
@@ -122,6 +123,11 @@ export default class CommonTypescriptGenerator extends Generator {
               }`,
             ],
           );
+          monorepoPackageReferences = yoConfig.pob.monorepo.packageNames
+            .filter((packageName) =>
+              existsSync(`${packageLocations.get(packageName)}/tsconfig.json`),
+            )
+            .map((packageName) => packageLocations.get(packageName));
           monorepoPackageBuildReferences = yoConfig.pob.monorepo.packageNames
             .filter((packageName) =>
               existsSync(
@@ -138,7 +144,7 @@ export default class CommonTypescriptGenerator extends Generator {
         tsconfigPath,
         {
           monorepoPackageSrcPaths,
-          monorepoPackageBuildReferences,
+          monorepoPackageReferences,
           rootDir: this.options.rootDir,
           jsx,
           composite,

package/lib/generators/common/typescript/templates/tsconfig.json.ejs

@@ -59,10 +59,10 @@
       "<%= packageName %>/*": ["../<%= packageLocation %>/*"]<%= index === monorepoPackageSrcPaths.length -1 ? '' : ',' -%>
       <% }) %>
     }<% } %>
-  }<% if (monorepoPackageBuildReferences && monorepoPackageBuildReferences.length) { -%>,
+  }<% if (monorepoPackageReferences && monorepoPackageReferences.length) { -%>,
   "references": [
-    <% monorepoPackageBuildReferences.forEach((monorepoPackageSrcPath, index) => { -%>
-        { "path": "<%= monorepoPackageSrcPath %>/tsconfig.json" }<%= index === monorepoPackageBuildReferences.length -1 ? '' : ',' %>
+    <% monorepoPackageReferences.forEach((monorepoPackageSrcPath, index) => { -%>
+        { "path": "<%= monorepoPackageSrcPath %>/tsconfig.json" }<%= index === monorepoPackageReferences.length -1 ? '' : ',' %>
     <% }) -%>
   ],
   <% } -%>

package/lib/generators/core/vscode/CoreVSCodeGenerator.js

@@ -93,13 +93,15 @@ export default class CoreVSCodeGenerator extends Generator {
         this.destinationPath('.vscode/tasks.json'),
         {},
       );
+      const tasks = tasksConfig.tasks || [];
+
       copyAndFormatTpl(
         this.fs,
         this.templatePath('tasks.json.ejs'),
         this.destinationPath('.vscode/tasks.json'),
         {
           typescript: this.options.typescript,
-          tasks: JSON.stringify(tasksConfig.tasks || [], null, 2),
+          tasks: JSON.stringify(tasks, null, 2),
         },
       );
 

package/lib/generators/core/vscode/templates/settings.json.ejs

@@ -21,6 +21,11 @@
   "typescript.enablePromptUseWorkspaceTsdk": true,
 <% } -%>
 
+<% if (yarn) { -%>
+  // set yarn as package manager to run scripts and tasks
+  "npm.packageManager": "yarn",
+<% } -%>
+
   // save config
   "editor.formatOnSave": true,
   "eslint.codeActionsOnSave.mode": "all",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "10.2.1",
+  "version": "10.3.0",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -61,11 +61,11 @@
     "mem-fs-editor": "9.4.0",
     "minimist-argv": "^1.1.0",
     "parse-author": "^2.0.0",
-    "pob-dependencies": "6.16.0",
+    "pob-dependencies": "6.17.0",
     "prettier": "2.5.1",
     "semver": "^7.3.4",
     "yeoman-environment": "^3.5.1",
     "yeoman-generator": "^5.4.0"
   },
-  "gitHead": "f23f89112a35d2df5b8e6da96dee061043b4c362"
+  "gitHead": "033cb44fe500dedc8aed5c19484ef39baa7a90b9"
 }