pob 10.19.0 → 10.21.0

package/CHANGELOG.md

@@ -3,6 +3,52 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [10.21.0](https://github.com/christophehurpeau/pob/compare/pob@10.20.0...pob@10.21.0) (2022-10-19)
+
+
+### Bug Fixes
+
+* **deps:** update dependency minimist to v1.2.7 ([#1429](https://github.com/christophehurpeau/pob/issues/1429)) ([273c62d](https://github.com/christophehurpeau/pob/commit/273c62dddc85d92be1dbdb1d304ca15da0af2362))
+* **deps:** update dependency yeoman-environment to v3.12.1 ([#1430](https://github.com/christophehurpeau/pob/issues/1430)) ([b188b91](https://github.com/christophehurpeau/pob/commit/b188b9130527a570e39efa95f79e1769fb72ee69))
+* **pob:** fix config app eslint ([dbec241](https://github.com/christophehurpeau/pob/commit/dbec2410e2c339f2a25860968d32345b272f9b9f))
+
+
+### Features
+
+* **deps:** update dependency eslint to v8.25.0 ([#1421](https://github.com/christophehurpeau/pob/issues/1421)) ([a517b35](https://github.com/christophehurpeau/pob/commit/a517b35bfd3bd8c966538774b45eebf2199bb08c))
+* improve generator for react-native-web monorepo ([49f0cd0](https://github.com/christophehurpeau/pob/commit/49f0cd0c55b842a9d5781cf062923dfc62d91e9e))
+* **pob:** add support for cjs in extraEntries ([d46794a](https://github.com/christophehurpeau/pob/commit/d46794ac20555e3d54536f063f3b1edb5281d854))
+* **pob:** improve config for apps ([50dbce0](https://github.com/christophehurpeau/pob/commit/50dbce05a34a04da9a216260a92e5286b8010a18))
+
+
+
+
+
+# [10.20.0](https://github.com/christophehurpeau/pob/compare/pob@10.19.0...pob@10.20.0) (2022-10-05)
+
+
+### Bug Fixes
+
+* **deps:** update dependency eslint to v8.23.1 ([#1395](https://github.com/christophehurpeau/pob/issues/1395)) ([3a80c50](https://github.com/christophehurpeau/pob/commit/3a80c501ee492bf248304529488e71feb8154ff4))
+* **deps:** update dependency semver to v7.3.8 ([#1417](https://github.com/christophehurpeau/pob/issues/1417)) ([b9d4913](https://github.com/christophehurpeau/pob/commit/b9d4913b70e930d02a59c5ae753688fd08954f12))
+* **deps:** update dependency yeoman-environment to v3.11.1 ([#1405](https://github.com/christophehurpeau/pob/issues/1405)) ([bea37d3](https://github.com/christophehurpeau/pob/commit/bea37d39d2707b4eff73b1bc99b3750d35c35e23))
+* disable husky when commiting release ([8239cea](https://github.com/christophehurpeau/pob/commit/8239cea55adf2b624fe6f957ac8511245d3d9710))
+* typedoc ci fix cache tsc ([5954146](https://github.com/christophehurpeau/pob/commit/5954146ab24942f792ca6deb11f00da58daa1605))
+* use fileURLToPath ([94e5c56](https://github.com/christophehurpeau/pob/commit/94e5c56d91689205a938cb9c35d4a34eb03d3893))
+
+
+### Features
+
+* better prettier config ([329d560](https://github.com/christophehurpeau/pob/commit/329d560594cade521e35a6f3237888db49f67b87))
+* **deps:** update @pob/eslint-config to v49.4.0 ([#1390](https://github.com/christophehurpeau/pob/issues/1390)) ([a7db8f0](https://github.com/christophehurpeau/pob/commit/a7db8f09a0bee265458ce0f0fa2518fd46adcfbb))
+* **deps:** update dependency eslint to v8.24.0 ([#1403](https://github.com/christophehurpeau/pob/issues/1403)) ([1c0d9e4](https://github.com/christophehurpeau/pob/commit/1c0d9e495292610235b9c6fbcb726f5e4cea586f))
+* **deps:** update dependency yeoman-environment to v3.11.0 ([#1404](https://github.com/christophehurpeau/pob/issues/1404)) ([4f78cd4](https://github.com/christophehurpeau/pob/commit/4f78cd4f829aa88252e7f7617e5bfcf866c4842b))
+* **deps:** update dependency yeoman-environment to v3.12.0 ([#1416](https://github.com/christophehurpeau/pob/issues/1416)) ([8256499](https://github.com/christophehurpeau/pob/commit/8256499ce99b7e6b2cb954a12580c6718cef9d10))
+
+
+
+
+
 # [10.19.0](https://github.com/christophehurpeau/pob/compare/pob@10.18.0...pob@10.19.0) (2022-09-04)
 
 

package/lib/generators/app/PobAppGenerator.js

@@ -185,6 +185,7 @@ export default class PobAppGenerator extends Generator {
       });
 
       this.composeWith('pob:common:format-lint', {
+        isApp: true,
         documentation: false,
         testing: this.appConfig.testing,
         babel,

package/lib/generators/common/babel/CommonBabelGenerator.js

@@ -258,7 +258,14 @@ export default class CommonBabelGenerator extends Generator {
     if (this.entries) {
       this.entries.forEach((entry) => {
         const entryDestPath = this.destinationPath(`${entry}.js`);
-        this.fs.delete(entryDestPath);
+        if (this.options.isApp && entry !== 'index') {
+          this.fs.write(
+            entryDestPath,
+            `// resolution for eslint-plugin-import\nexport * from './src/${entry}/index.ts';\n`,
+          );
+        } else {
+          this.fs.delete(entryDestPath);
+        }
       });
     }
     //
@@ -667,7 +674,10 @@ export default class CommonBabelGenerator extends Generator {
         pkg.pob.extraEntries.forEach((exportName) => {
           pkg.exports[`./${exportName}`] =
             pkg.type === 'module'
-              ? `./${exportName}.js`
+              ? // eslint-disable-next-line unicorn/no-nested-ternary
+                exportName.endsWith('cjs')
+                ? `./${exportName}`
+                : `./${exportName}.js`
               : {
                   import: `./${exportName}.mjs`,
                   require: `./${exportName}.js`,

package/lib/generators/common/babel/templates/app.rollup.config.mjs.ejs

@@ -1,3 +1,5 @@
+import { dirname } from 'path';
+import { fileURLToPath } from 'url';
 <% if (config) { -%>
 import config from 'alp-rollup-plugin-config';
 <% } -%>
@@ -7,9 +9,7 @@ import run from 'pob-babel/plugin-run.cjs';
 const watch = process.env.ROLLUP_WATCH === 'true';
 
 export default createRollupConfig({
-  cwd: new URL('.', import.meta.url).pathname.slice(
-    process.platform === 'win32' ? 1 : 0,
-  ),
+  cwd: dirname(fileURLToPath(import.meta.url)),
   outDirectory: 'build',
   plugins: [
 <% if (config) { -%>

package/lib/generators/common/babel/templates/lib.rollup.config.mjs.txt

@@ -1,7 +1,7 @@
+import { dirname } from 'path';
+import { fileURLToPath } from 'url';
 import createRollupConfig from 'pob-babel/createRollupConfig.js';
 
 export default createRollupConfig({
-  cwd: new URL('.', import.meta.url).pathname.slice(
-    process.platform === 'win32' ? 1 : 0,
-  ),
+  cwd: dirname(fileURLToPath(import.meta.url)),
 });

package/lib/generators/common/format-lint/CommonLintGenerator.js

@@ -19,6 +19,13 @@ export default class CommonLintGenerator extends Generator {
       description: 'Is root monorepo',
     });
 
+    this.option('isApp', {
+      type: Boolean,
+      required: false,
+      defaults: false,
+      description: 'Is app',
+    });
+
     this.option('babel', {
       type: String,
       required: false,
@@ -125,12 +132,7 @@ export default class CommonLintGenerator extends Generator {
 
     delete pkg.standard;
 
-    pkg.prettier = {
-      trailingComma: 'all',
-      singleQuote: true,
-      // https://github.com/airbnb/javascript/pull/1863
-      arrowParens: 'always',
-    };
+    pkg.prettier = '@pob/root/prettier-config';
 
     if (!inLerna || inLerna.root || this.options.monorepo) {
       const rootIgnorePatterns = new Set(
@@ -345,7 +347,11 @@ export default class CommonLintGenerator extends Generator {
         return [
           '@pob/eslint-config-typescript',
           useNodeOnly && '@pob/eslint-config-typescript/node',
-          hasReact && '@pob/eslint-config-typescript-react',
+          this.options.isApp && '@pob/eslint-config-typescript/app',
+          hasReact &&
+            `@pob/eslint-config-typescript-react${
+              pkg.dependencies?.['react-native-web'] ? '/react-native-web' : ''
+            }`,
         ].filter(Boolean);
       }
 

package/lib/generators/common/testing/CommonTestingGenerator.js

@@ -101,7 +101,11 @@ export default class CommonTestingGenerator extends Generator {
     const transpileWithBabel = this.options.monorepo
       ? yoConfigPobMonorepo.typescript
       : pkg.pob && pkg.pob.babelEnvs && pkg.pob.babelEnvs.length > 0;
-    let hasReact = transpileWithBabel && packageUtils.hasReact(pkg);
+    let hasReact =
+      transpileWithBabel &&
+      (this.options.monorepo
+        ? yoConfigPobMonorepo.react ?? packageUtils.hasReact(pkg)
+        : packageUtils.hasReact(pkg));
 
     if (!this.options.enable) {
       packageUtils.removeDevDependencies(pkg, ['jest', '@types/jest']);

package/lib/generators/common/typescript/CommonTypescriptGenerator.js

@@ -109,7 +109,12 @@ export default class CommonTypescriptGenerator extends Generator {
                 packageName,
                 `../../${
                   packageName[0] === '@'
-                    ? packageName
+                    ? // eslint-disable-next-line unicorn/no-nested-ternary
+                      yoConfig.pob.project.type === 'app'
+                      ? `packages/${packageName.slice(
+                          packageName.indexOf('/') + 1,
+                        )}`
+                      : packageName
                     : `packages/${packageName}`
                 }`,
               ]),
@@ -119,7 +124,9 @@ export default class CommonTypescriptGenerator extends Generator {
             ([packageName, packageLocation]) => [
               packageName,
               `${packageLocation}/${
-                existsSync(`${packageLocation}/src`) ? 'src' : 'lib'
+                existsSync(`${packageLocations.get(packageName)}/tsconfig.json`)
+                  ? 'src'
+                  : 'lib'
               }`,
             ],
           );

package/lib/generators/core/ci/CoreCIGenerator.js

@@ -111,7 +111,9 @@ export default class CoreCIGenerator extends Generator {
           build: this.options.build,
           typescript: this.options.typescript,
           codecov: this.options.codecov,
-          supportsNode14: !this.options.isApp,
+          supportsNode14:
+            !this.options.isApp ||
+            inLerna.pobConfig?.project?.supportsNode14 !== false,
 
           isReleasePleaseEnabled: this.isReleasePleaseEnabled,
           publishSinglePackage: this.isReleasePleaseEnabled && !pkg.private,

package/lib/generators/core/ci/templates/github-action-documentation-workflow.yml.ejs

@@ -18,6 +18,9 @@ jobs:
         run: yarn install --immutable --immutable-cache
 
 <% if (typedoc) { -%>
+      - name: Run tsc for tsc cache
+        run: yarn tsc
+
       - name: Generate Typedoc
         run: yarn typedoc --tsconfig tsconfig.doc.json
 <% } -%>

package/lib/generators/lib/readme/LibReadmeGenerator.js

@@ -80,7 +80,6 @@ export default class LibReadmeGenerator extends Generator {
         {
           privatePackage: pkg.private,
           packageName: pkg.name,
-          packagePath: `${pkg.name[0] === '@' ? '' : 'packages/'}${pkg.name}`,
           camelCaseProjectName: camelCase(pkg.name),
           description: pkg.description,
           inLerna,

package/lib/generators/monorepo/lerna/templates/workflow-publish.yml.ejs

@@ -44,6 +44,7 @@ jobs:
         run: |
           yarn lerna version --yes --push --exact --conventional-commits --conventional-graduate --create-release=github -m 'chore: release [skip ci]'
         env:
+          HUSKY: 0
           GH_TOKEN: ${{ secrets.GH_TOKEN }}
           YARN_ENABLE_IMMUTABLE_INSTALLS: false
 <% if (publish) { -%>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "10.19.0",
+  "version": "10.21.0",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -32,22 +32,18 @@
     "lint": "yarn run lint:eslint",
     "lint:eslint": "cd ../.. && yarn run eslint --report-unused-disable-directives --resolve-plugins-relative-to . --quiet packages/pob"
   },
-  "prettier": {
-    "trailingComma": "all",
-    "singleQuote": true,
-    "arrowParens": "always"
-  },
+  "prettier": "@pob/root/prettier-config",
   "pob": {},
   "dependencies": {
     "@lerna/package-graph": "^5.0.0",
     "@lerna/project": "^5.0.0",
-    "@pob/eslint-config": "49.3.2",
-    "@pob/eslint-config-typescript": "49.3.3",
-    "@pob/eslint-config-typescript-react": "49.3.2",
-    "@pob/sort-eslint-config": "^3.0.1",
-    "@pob/sort-object": "^4.0.1",
-    "@pob/sort-pkg": "^4.0.1",
-    "eslint": "8.23.0",
+    "@pob/eslint-config": "49.4.0",
+    "@pob/eslint-config-typescript": "49.4.0",
+    "@pob/eslint-config-typescript-react": "49.4.0",
+    "@pob/sort-eslint-config": "3.1.0",
+    "@pob/sort-object": "4.1.0",
+    "@pob/sort-pkg": "4.1.0",
+    "eslint": "8.25.0",
     "findup-sync": "^5.0.0",
     "git-remote-url": "^1.0.1",
     "github-username": "^6.0.0",
@@ -59,16 +55,16 @@
     "lodash.kebabcase": "^4.1.1",
     "mem-fs": "2.2.1",
     "mem-fs-editor": "9.5.0",
-    "minimist": "1.2.6",
+    "minimist": "1.2.7",
     "parse-author": "2.0.0",
-    "pob-dependencies": "6.31.0",
+    "pob-dependencies": "6.33.0",
     "prettier": "2.7.1",
-    "semver": "7.3.7",
-    "yeoman-environment": "3.10.0",
+    "semver": "7.3.8",
+    "yeoman-environment": "3.12.1",
     "yeoman-generator": "5.7.0"
   },
   "devDependencies": {
-    "@pob/root": "6.22.0"
+    "@pob/root": "6.23.1"
   },
-  "gitHead": "40e2ebfeccd06b9124056bca8bf8f94fefa2fdd1"
+  "gitHead": "731b169f373af61b2aa965f8f086b229387ab6eb"
 }