pob 10.16.0 → 10.19.0

package/CHANGELOG.md

@@ -3,6 +3,61 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [10.19.0](https://github.com/christophehurpeau/pob/compare/pob@10.18.0...pob@10.19.0) (2022-09-04)
+
+
+### Features
+
+* add pob-babel-clean-out for better windows support ([1503de8](https://github.com/christophehurpeau/pob/commit/1503de8d31c7f6a288013860ba87ce047fa85456))
+* **deps:** update dependency eslint to v8.22.0 ([#1367](https://github.com/christophehurpeau/pob/issues/1367)) ([3b540b5](https://github.com/christophehurpeau/pob/commit/3b540b56c5db66d510c6015bbff36fa2ac230357))
+* **deps:** update dependency eslint to v8.23.0 ([#1379](https://github.com/christophehurpeau/pob/issues/1379)) ([839ad12](https://github.com/christophehurpeau/pob/commit/839ad12628057e03af53b0b787768574f781ecc2))
+
+
+
+
+
+# [10.18.0](https://github.com/christophehurpeau/pob/compare/pob@10.17.0...pob@10.18.0) (2022-08-12)
+
+
+### Features
+
+* **deps:** update dependency mem-fs-editor to v9.5.0 ([#1363](https://github.com/christophehurpeau/pob/issues/1363)) ([bc1d1bf](https://github.com/christophehurpeau/pob/commit/bc1d1bfcdb093d75b3be4d07ede463f2a37a5491))
+
+
+
+
+
+# [10.17.0](https://github.com/christophehurpeau/pob/compare/pob@10.16.0...pob@10.17.0) (2022-08-01)
+
+
+### Bug Fixes
+
+* **deps:** update dependency prettier to v2.7.1 ([#1322](https://github.com/christophehurpeau/pob/issues/1322)) ([ba6b521](https://github.com/christophehurpeau/pob/commit/ba6b521ccada49f36eb013a02f5eea13613ed593))
+* move pob/root in devdep of pob to avoid dep cycle ([ce9152a](https://github.com/christophehurpeau/pob/commit/ce9152a83106b330a090f1a4d1bce570ec47c90d))
+* **pob:** better support windows in rollup config ([b8a266b](https://github.com/christophehurpeau/pob/commit/b8a266b0a0b5515fda1bce6be8ddf9158c66a408))
+* update check-package-dependencies ([79a6e7f](https://github.com/christophehurpeau/pob/commit/79a6e7f32240efbaff7e3f3eb831f5d1a0fd8174))
+* update check-packages template ([9e498db](https://github.com/christophehurpeau/pob/commit/9e498db17ffc0078f5a0e04c28a14ff5831bf8a9))
+
+
+### Features
+
+* configure newLine in tsconfig.build.json for windows compat ([e5f9710](https://github.com/christophehurpeau/pob/commit/e5f97101e19c6184cc9a3c95ee8bf565df2900ac))
+* **deps:** update @pob/eslint-config ([#1341](https://github.com/christophehurpeau/pob/issues/1341)) ([55dc6ea](https://github.com/christophehurpeau/pob/commit/55dc6ea6425c3baa977b6c4224ad71f7b5e69ba4))
+* **deps:** update dependency eslint to v8.17.0 ([#1311](https://github.com/christophehurpeau/pob/issues/1311)) ([b050c31](https://github.com/christophehurpeau/pob/commit/b050c318ee4a7518e60cde4d07f6ceb9738e5123))
+* **deps:** update dependency eslint to v8.18.0 ([#1324](https://github.com/christophehurpeau/pob/issues/1324)) ([eed6d70](https://github.com/christophehurpeau/pob/commit/eed6d700a7ef5861a99d568b00216a1d2fea4bf7))
+* **deps:** update dependency eslint to v8.19.0 ([#1336](https://github.com/christophehurpeau/pob/issues/1336)) ([47fe9d6](https://github.com/christophehurpeau/pob/commit/47fe9d6180fb27dd6d1acb00dc412f8b6f7e19b4))
+* **deps:** update dependency eslint to v8.20.0 ([#1349](https://github.com/christophehurpeau/pob/issues/1349)) ([de37cf8](https://github.com/christophehurpeau/pob/commit/de37cf8d7cc90ffcee040e4dac872bade940497b))
+* **deps:** update dependency eslint to v8.21.0 ([#1361](https://github.com/christophehurpeau/pob/issues/1361)) ([04ff2df](https://github.com/christophehurpeau/pob/commit/04ff2dfb7074a31de75015bf22ffd3d0983b9f39))
+* **deps:** update dependency prettier to v2.7.0 ([#1318](https://github.com/christophehurpeau/pob/issues/1318)) ([ee2d9f3](https://github.com/christophehurpeau/pob/commit/ee2d9f313d0be390dd68e83112998960f7517792))
+* **deps:** update yeoman group ([#1358](https://github.com/christophehurpeau/pob/issues/1358)) ([fdc8bfb](https://github.com/christophehurpeau/pob/commit/fdc8bfb88c84312bf9597003f30cbd528359551e))
+* **pob:** add missing stuff in npmignore ([1748198](https://github.com/christophehurpeau/pob/commit/1748198e70ebae2f9825ad5a4e02ade7e1973eb8))
+* remove lerna-light in pob-monorepo-test-repository ([7e5c34c](https://github.com/christophehurpeau/pob/commit/7e5c34c3c865b70c4c9330d2f466231c80a329ac))
+* remove standard-version ([9ced070](https://github.com/christophehurpeau/pob/commit/9ced070767e6b9ab04f61cd80496a76b6de1d594))
+
+
+
+
+
 # [10.16.0](https://github.com/christophehurpeau/pob/compare/pob@10.15.0...pob@10.16.0) (2022-05-31)
 
 

package/lib/generators/common/babel/CommonBabelGenerator.js

@@ -284,7 +284,7 @@ export default class CommonBabelGenerator extends Generator {
     if (this.options.isApp) {
       packageUtils.removeScripts(['watch']);
       packageUtils.addOrRemoveScripts(pkg, useBabel, {
-        'clean:build': `rm -Rf ${this.options.buildDirectory}`,
+        'clean:build': `pob-babel-clean-out ${this.options.buildDirectory}`,
         build: 'yarn clean:build && rollup --config rollup.config.mjs',
         start: 'yarn clean:build && rollup --config rollup.config.mjs --watch',
         clean: 'yarn clean:build',
@@ -292,7 +292,7 @@ export default class CommonBabelGenerator extends Generator {
     } else {
       packageUtils.removeScripts(['start']);
       packageUtils.addOrRemoveScripts(pkg, useBabel, {
-        'clean:build': `rm -Rf ${this.options.buildDirectory}`,
+        'clean:build': `pob-babel-clean-out ${this.options.buildDirectory}`,
         build: 'yarn clean:build && rollup --config rollup.config.mjs',
         watch: 'yarn clean:build && rollup --config rollup.config.mjs --watch',
         clean: 'yarn clean:build',

package/lib/generators/common/babel/templates/app.rollup.config.mjs.ejs

@@ -7,7 +7,9 @@ import run from 'pob-babel/plugin-run.cjs';
 const watch = process.env.ROLLUP_WATCH === 'true';
 
 export default createRollupConfig({
-  cwd: new URL('.', import.meta.url).pathname,
+  cwd: new URL('.', import.meta.url).pathname.slice(
+    process.platform === 'win32' ? 1 : 0,
+  ),
   outDirectory: 'build',
   plugins: [
 <% if (config) { -%>

package/lib/generators/common/babel/templates/lib.rollup.config.mjs.txt

@@ -1,5 +1,7 @@
 import createRollupConfig from 'pob-babel/createRollupConfig.js';
 
 export default createRollupConfig({
-  cwd: new URL('.', import.meta.url).pathname,
+  cwd: new URL('.', import.meta.url).pathname.slice(
+    process.platform === 'win32' ? 1 : 0,
+  ),
 });

package/lib/generators/common/format-lint/CommonLintGenerator.js

@@ -518,7 +518,9 @@ export default class CommonLintGenerator extends Generator {
 
       packageUtils.addScripts(pkg, {
         'lint:eslint': globalEslint
-          ? `cd ../.. && yarn run eslint ${args} ${path.relative('../..', '.')}`
+          ? `cd ../.. && yarn run eslint ${args} ${path
+              .relative('../..', '.')
+              .replace('\\', '/')}`
           : `eslint ${args} ${lintPaths.join(' ')}`,
         lint: `${useBabel && !composite ? 'tsc && ' : ''}yarn run lint:eslint`,
       });

package/lib/generators/common/husky/CommonHuskyGenerator.js

@@ -1,5 +1,4 @@
-import { execSync } from 'child_process';
-import { readlinkSync } from 'fs';
+import { readlinkSync, rmSync } from 'fs';
 import Generator from 'yeoman-generator';
 import inLerna from '../../../utils/inLerna.js';
 import * as packageUtils from '../../../utils/package.js';
@@ -17,7 +16,7 @@ export default class CommonHuskyGenerator extends Generator {
   }
 
   writing() {
-    execSync('rm -Rf git-hooks/');
+    rmSync('git-hooks', { recursive: true, force: true });
 
     const gitHookDestination = this.destinationPath('.git/hooks/pre-commit');
     let isSymlink;

package/lib/generators/common/release/CommonReleaseGenerator.js

@@ -45,7 +45,6 @@ export default class CommonReleaseGenerator extends Generator {
         pkg.name === 'pob-dependencies' ? null : 'preversion',
       ]);
     } else {
-      packageUtils.addDevDependencies(pkg, ['standard-version']);
       packageUtils.addScripts(pkg, {
         release:
           "repository-check-dirty && yarn preversion && standard-version -a -m 'chore(release): %s [skip ci]' && git push --follow-tags origin master && npm publish",

package/lib/generators/common/typescript/templates/tsconfig.build.json.ejs

@@ -6,7 +6,8 @@
     "declaration": true,
     "declarationMap": true,
     "emitDeclarationOnly": true,
-    "outDir": "dist"<% if(composite) { -%>,
+    "outDir": "dist",
+    "newLine": "lf"<% if(composite) { -%>,
     "composite": true,
     "tsBuildInfoFile": "dist/tsbuildinfo"
 <% } -%>

package/lib/generators/core/npm/templates/npmignore.ejs

@@ -1,4 +1,7 @@
 <% if (!inLerna && ci) { -%>
+/.husky
+<% } -%>
+<% if (!inLerna) { -%>
 /.github
 <% } -%>
 <% if (!inLerna && codeclimate) { -%>
@@ -10,9 +13,12 @@
 /samples
 /test
 /*.config.js
+/*.config.cjs
+/*.config.mjs
 <% if (babel) { -%>
 /tsconfig.json
 /tsconfig.build.json
+/tsconfig.eslint.json
 /dist/tsbuildinfo
 <% if (typedoc) { -%>
 /tsconfig.doc.json
@@ -21,6 +27,7 @@ babel.config.json
 <% } -%>
 <% if (testing) { -%>
 __snapshots__
+/coverage
 <% } -%>
 .yo-rc.json
 <% if (!inLerna) { -%>

package/lib/generators/core/package/templates/check-packages.js.ejs

@@ -1,5 +1,7 @@
 import { createCheckPackageWithWorkspaces } from 'check-package-dependencies';
 
-createCheckPackageWithWorkspaces().checkRecommended({
-  isLibrary: () => true,
-});
+await createCheckPackageWithWorkspaces()
+  .checkRecommended({
+    isLibrary: () => true,
+  })
+  .run();

package/lib/generators/lib/PobLibGenerator.js

@@ -1,5 +1,4 @@
-import { execSync } from 'child_process';
-import fs from 'fs';
+import fs, { rmSync } from 'fs';
 import Generator from 'yeoman-generator';
 import inLerna from '../../utils/inLerna.js';
 import * as packageUtils from '../../utils/package.js';
@@ -351,16 +350,17 @@ export default class PobLibGenerator extends Generator {
     }
 
     this.fs.writeJSON(this.destinationPath('package.json'), pkg);
-    execSync(
-      `rm -Rf ${[
-        'lib-*',
-        'coverage',
-        this.pobjson.documentation && 'docs',
-        !withBabel && 'dist',
-      ]
-        .filter(Boolean)
-        .join(' ')}`,
-    );
+    [
+      'lib-node14',
+      'lib-node16',
+      'coverage',
+      this.pobjson.documentation && 'docs',
+      !withBabel && 'dist',
+    ]
+      .filter(Boolean)
+      .forEach((path) => {
+        rmSync(path, { recursive: true, force: true });
+      });
 
     const { pobjson } = this;
 

package/lib/generators/monorepo/lerna/MonorepoLernaGenerator.js

@@ -140,7 +140,7 @@ export default class MonorepoLernaGenerator extends Generator {
 
     if (pkg.name === 'pob-monorepo') {
       pkg.devDependencies['@pob/lerna-light'] = 'workspace:*';
-    } else {
+    } else if (pkg.name !== 'pob-monorepo-test-repository') {
       packageUtils.addDevDependencies(pkg, ['@pob/lerna-light']);
     }
 

package/lib/utils/package.js

@@ -8,6 +8,7 @@ import {
   pobEslintConfigTypescript,
   pobEslintConfigTypescriptReact,
 } from './dependenciesPackages.cjs';
+import pobPkg from './packagejson.cjs';
 
 export { default as parseAuthor } from 'parse-author';
 
@@ -103,6 +104,12 @@ const getVersionFromDependencyName = (dependency) => {
   ) {
     return pobEslintConfigTypescript.dependencies[dependency];
   }
+
+  // prevents cycle that lerna doesnt like
+  if (dependency === '@pob/root') {
+    return pobPkg.devDependencies[dependency];
+  }
+
   return pobDependencies[dependency];
 };
 

package/lib/utils/packagejson.cjs

@@ -0,0 +1,3 @@
+'use strict';
+
+module.exports = require('../../package.json');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "10.16.0",
+  "version": "10.19.0",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -41,13 +41,13 @@
   "dependencies": {
     "@lerna/package-graph": "^5.0.0",
     "@lerna/project": "^5.0.0",
-    "@pob/eslint-config": "49.1.0",
-    "@pob/eslint-config-typescript": "49.3.0",
-    "@pob/eslint-config-typescript-react": "49.3.1",
+    "@pob/eslint-config": "49.3.2",
+    "@pob/eslint-config-typescript": "49.3.3",
+    "@pob/eslint-config-typescript-react": "49.3.2",
     "@pob/sort-eslint-config": "^3.0.1",
     "@pob/sort-object": "^4.0.1",
     "@pob/sort-pkg": "^4.0.1",
-    "eslint": "8.16.0",
+    "eslint": "8.23.0",
     "findup-sync": "^5.0.0",
     "git-remote-url": "^1.0.1",
     "github-username": "^6.0.0",
@@ -58,14 +58,17 @@
     "lodash.camelcase": "^4.3.0",
     "lodash.kebabcase": "^4.1.1",
     "mem-fs": "2.2.1",
-    "mem-fs-editor": "9.4.0",
+    "mem-fs-editor": "9.5.0",
     "minimist": "1.2.6",
     "parse-author": "2.0.0",
-    "pob-dependencies": "6.26.0",
-    "prettier": "2.6.2",
+    "pob-dependencies": "6.31.0",
+    "prettier": "2.7.1",
     "semver": "7.3.7",
-    "yeoman-environment": "3.9.1",
-    "yeoman-generator": "5.6.1"
+    "yeoman-environment": "3.10.0",
+    "yeoman-generator": "5.7.0"
   },
-  "gitHead": "6e909141a6d1ee895cfc0dfa6686512cfd7ba409"
+  "devDependencies": {
+    "@pob/root": "6.22.0"
+  },
+  "gitHead": "40e2ebfeccd06b9124056bca8bf8f94fefa2fdd1"
 }