pmtiles-swarm 0.24.1 → 0.24.3

package/CHANGELOG.md

@@ -7,6 +7,33 @@
 ### 🐞 Bug fixes
 - _...Add new stuff here..._
 
+## 0.24.3
+### 🐞 Bug fixes
+- **Takes pmtiles-torrent 0.4.6.** Two things a node reading pieces on demand wanted. The sidecar
+  no longer discards the alerts that explain a failed read — `torrent_error_alert` and
+  `file_error_alert` were drained from the queue and thrown away by the one loop running while a
+  read was outstanding, so a full disk, an unwritable save path and a torrent that could not verify
+  its pieces all arrived as the same silent timeout. And the last piece of an archive is now
+  fetched before any header has been read: everything else is prioritised from the header, so until
+  one can be read nothing points anywhere but at the header, and planetiler writes the JSON
+  metadata and the leaf directories after all the tile data — where a partial mirror is least
+  likely to have them.
+
+  The floor is raised in the lockfile as well as the range. `^0.4.5` already permitted 0.4.6, and a
+  deployment installs from the lockfile, so without moving it `npm ci` would have gone on fetching
+  the version without either fix.
+
+## 0.24.2
+### 🐞 Bug fixes
+- **An empty `publicUrl` was read as an empty base rather than as no setting.** `??` treats only
+  null and undefined as absent, so `"publicUrl": ""` — which is how an operator naturally writes
+  "I do not want this" into a key already in the file — produced URLs like
+  `/archives/<hash>/{z}/{x}/{y}.pbf`. Those half-work, which is the trap: a browser resolves them
+  against the TileJSON it just fetched and renders perfectly, while everything needing an absolute
+  URL quietly gets something unusable — a torrent client handed the `torrent` link, another node
+  syncing from the feed. Empty and whitespace now mean unset, and the base falls back to the
+  request, which is what a node syncing internally by IP depends on.
+
 ## 0.24.1
 ### 🐞 Bug fixes
 - **Takes pmtiles-torrent 0.4.5, which stops a torrent that is not ready yet reporting a corrupt

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pmtiles-swarm",
-  "version": "0.24.1",
+  "version": "0.24.3",
   "description": "BitTorrent distribution for PMTiles map archives: create torrents, watch folders, publish and subscribe to RSS feeds, and seed through qBittorrent or an embedded client",
   "type": "module",
   "main": "src/index.js",
@@ -46,7 +46,7 @@
     "maplibre-gl": "^6.2.0",
     "parse-torrent": "^11.0.24",
     "pmtiles": "^4.4.1",
-    "pmtiles-torrent": "^0.4.5",
+    "pmtiles-torrent": "^0.4.6",
     "webtorrent": "^3.0.21"
   },
   "engines": {

package/src/api.js

@@ -213,8 +213,21 @@ export function createApp({
    * @param {import('express').Request} req - The request.
    * @returns {string} - Base URL without a trailing slash.
    */
-  const baseUrl = (req) =>
-    (config.publicUrl ?? `${req.protocol}://${req.host}`).replace(/\/$/, '');
+  const baseUrl = (req) => {
+    // An empty publicUrl means "not set", not "use an empty base".
+    //
+    // `??` reads only null and undefined as absent, so `"publicUrl": ""` --
+    // which is how an operator naturally writes "I do not want this" in a JSON
+    // file that already has the key -- produced a base of "" and URLs like
+    // `/archives/<hash>/{z}/{x}/{y}.pbf`. Those half-work, which is the worst
+    // of both: a browser resolves them against the TileJSON it fetched and
+    // renders perfectly, while every consumer that needs an absolute URL --
+    // a torrent client handed the `torrent` link, another node syncing from
+    // the feed -- silently gets something it cannot use.
+    const configured = String(config.publicUrl ?? '').trim();
+    const base = configured || `${req.protocol}://${req.host}`;
+    return base.replace(/\/$/, '');
+  };
 
   /**
    * Whether an archive should answer a missing tile with 404 rather than 204.