pmtiles-swarm 0.24.1 → 0.24.2

package/CHANGELOG.md

@@ -7,6 +7,17 @@
 ### 🐞 Bug fixes
 - _...Add new stuff here..._
 
+## 0.24.2
+### 🐞 Bug fixes
+- **An empty `publicUrl` was read as an empty base rather than as no setting.** `??` treats only
+  null and undefined as absent, so `"publicUrl": ""` — which is how an operator naturally writes
+  "I do not want this" into a key already in the file — produced URLs like
+  `/archives/<hash>/{z}/{x}/{y}.pbf`. Those half-work, which is the trap: a browser resolves them
+  against the TileJSON it just fetched and renders perfectly, while everything needing an absolute
+  URL quietly gets something unusable — a torrent client handed the `torrent` link, another node
+  syncing from the feed. Empty and whitespace now mean unset, and the base falls back to the
+  request, which is what a node syncing internally by IP depends on.
+
 ## 0.24.1
 ### 🐞 Bug fixes
 - **Takes pmtiles-torrent 0.4.5, which stops a torrent that is not ready yet reporting a corrupt

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pmtiles-swarm",
-  "version": "0.24.1",
+  "version": "0.24.2",
   "description": "BitTorrent distribution for PMTiles map archives: create torrents, watch folders, publish and subscribe to RSS feeds, and seed through qBittorrent or an embedded client",
   "type": "module",
   "main": "src/index.js",

package/src/api.js

@@ -213,8 +213,21 @@ export function createApp({
    * @param {import('express').Request} req - The request.
    * @returns {string} - Base URL without a trailing slash.
    */
-  const baseUrl = (req) =>
-    (config.publicUrl ?? `${req.protocol}://${req.host}`).replace(/\/$/, '');
+  const baseUrl = (req) => {
+    // An empty publicUrl means "not set", not "use an empty base".
+    //
+    // `??` reads only null and undefined as absent, so `"publicUrl": ""` --
+    // which is how an operator naturally writes "I do not want this" in a JSON
+    // file that already has the key -- produced a base of "" and URLs like
+    // `/archives/<hash>/{z}/{x}/{y}.pbf`. Those half-work, which is the worst
+    // of both: a browser resolves them against the TileJSON it fetched and
+    // renders perfectly, while every consumer that needs an absolute URL --
+    // a torrent client handed the `torrent` link, another node syncing from
+    // the feed -- silently gets something it cannot use.
+    const configured = String(config.publicUrl ?? '').trim();
+    const base = configured || `${req.protocol}://${req.host}`;
+    return base.replace(/\/$/, '');
+  };
 
   /**
    * Whether an archive should answer a missing tile with 404 rather than 204.