plum-e2e 2.9.6 → 2.9.7

package/backend/lib/rrwebPoller.js

@@ -11,7 +11,7 @@ const path = require('path');
 // picked up here.
 function startRRwebPoller(ssDir, onRRwebBatch) {
 	const seenFiles = new Set();
-	return setInterval(() => {
+	function drain() {
 		try {
 			const files = fs
 				.readdirSync(ssDir)
@@ -28,7 +28,12 @@ function startRRwebPoller(ssDir, onRRwebBatch) {
 				} catch {}
 			}
 		} catch {}
-	}, 400);
+	}
+
+	const interval = setInterval(drain, 400);
+	// A scenario faster than one 400ms tick can exit before the interval ever
+	// fires — stop() drains once more so that last batch isn't dropped.
+	return { stop: () => (clearInterval(interval), drain()) };
 }
 
 module.exports = { startRRwebPoller };

package/backend/routes/node.routes.js

@@ -60,7 +60,8 @@ router.get('/report/:jobId', authGuard, (req, res) => {
 // Poll job status and streamed logs
 router.get('/execute/:jobId', authGuard, (req, res) => {
 	const offset = parseInt(req.query.offset || '0', 10);
-	const result = nodeExecutionService.pollJob(req.params.jobId, offset);
+	const rrwebOffset = parseInt(req.query.rrwebOffset || '0', 10);
+	const result = nodeExecutionService.pollJob(req.params.jobId, offset, rrwebOffset);
 	if (!result) return res.status(404).json({ error: 'Job not found' });
 	res.json(result);
 });

package/backend/services/cronService.js

@@ -101,7 +101,7 @@ function runSingleBuiltInAttempt({ taskName, currentTag, workers, browser, suppr
 			onLog(`[ERROR] ${d.toString()}`);
 		});
 		task.on('close', (code) => {
-			clearInterval(ssPoller);
+			ssPoller.stop();
 			fs.rm(ssDir, { recursive: true, force: true }, () => {});
 			resolve({ code, raw: suppressSave ? readCucumberReportFile() : null });
 		});
@@ -379,7 +379,7 @@ async function runDistributed({
 						onLog(`[ERROR] ${d.toString()}`);
 					});
 					task.on('close', (code) => {
-						clearInterval(ssPoller);
+						ssPoller.stop();
 						fs.rm(ssDir, { recursive: true, force: true }, () => {});
 						const raw = readCucumberReportFile() ?? '[]';
 						resolve({ code, rawJson: JSON.parse(raw) });

package/backend/services/nodeExecutionService.js

@@ -82,6 +82,9 @@ function startJob({
 	jobs[jobId] = {
 		status: JOB_STATUS.RUNNING,
 		logs: '',
+		// Drained by pollJob — the HTTP-poll fallback for a node with no reachable
+		// notifyPublicUrl to stream these back over a socket instead.
+		rrwebBatches: [],
 		exitCode: null,
 		startedAt: Date.now(),
 		meta: { tags: tags || '', browser, workers },
@@ -108,6 +111,7 @@ function startJob({
 	if (workers > 1) env.PARALLEL = String(workers);
 
 	const ssPoller = startRRwebPoller(ssDir, (batch) => {
+		jobs[jobId].rrwebBatches.push(batch);
 		primaryStream?.emit('rrweb-batch', batch);
 	});
 
@@ -123,7 +127,7 @@ function startJob({
 		primaryStream?.emit('log', text);
 	});
 	proc.on('close', (code) => {
-		clearInterval(ssPoller);
+		ssPoller.stop();
 		primaryStream?.close();
 		jobs[jobId].status = code === 0 ? JOB_STATUS.DONE : JOB_STATUS.ERROR;
 		jobs[jobId].exitCode = code;
@@ -151,14 +155,15 @@ function startJob({
 	return jobId;
 }
 
-// Drains and returns logs since `offset` — used by the primary's HTTP polling
-// loop (this node has no socket.io connection back).
-function pollJob(jobId, offset) {
+// Drains and returns logs/rrweb batches since `offset`/`rrwebOffset` — used by
+// the primary's HTTP polling loop (this node has no socket.io connection back).
+function pollJob(jobId, offset, rrwebOffset = 0) {
 	const job = jobs[jobId];
 	if (!job) return null;
 	return {
 		status: job.status,
 		logs: job.logs.slice(offset),
+		rrwebBatches: job.rrwebBatches.slice(rrwebOffset),
 		exitCode: job.exitCode
 	};
 }

package/backend/services/runnerService.js

@@ -261,21 +261,30 @@ async function dispatchAndPoll(
 	}
 
 	let logOffset = 0;
+	let rrwebOffset = 0;
 	let polling = false;
 	const poll = setInterval(async () => {
 		if (polling) return;
 		polling = true;
 		try {
-			const res = await fetch(`${runner.url}/api/execute/${jobId}?offset=${logOffset}`, {
-				headers: bearerHeader(runner.token),
-				signal: AbortSignal.timeout(8000)
-			});
+			const res = await fetch(
+				`${runner.url}/api/execute/${jobId}?offset=${logOffset}&rrwebOffset=${rrwebOffset}`,
+				{
+					headers: bearerHeader(runner.token),
+					signal: AbortSignal.timeout(8000)
+				}
+			);
 			if (!res.ok) return;
 			const body = await res.json();
 
-			if (!primaryUrl && body.logs) {
-				onLog(body.logs);
-				logOffset += body.logs.length;
+			// Skip if a socket relay is active — it already pushed these live.
+			if (!primaryUrl) {
+				if (body.logs) {
+					onLog(body.logs);
+					logOffset += body.logs.length;
+				}
+				for (const batch of body.rrwebBatches ?? []) onRRwebBatch?.(batch);
+				rrwebOffset += body.rrwebBatches?.length ?? 0;
 			}
 
 			if (body.status === JOB_STATUS.DONE || body.status === JOB_STATUS.ERROR) {

package/backend/services/triggerService.js

@@ -79,7 +79,7 @@ function runAttempt({
 		proc.stderr.on('data', (d) => onLog(`[ERROR] ${d.toString()}`));
 
 		proc.on('close', (code) => {
-			clearInterval(ssPoller);
+			ssPoller.stop();
 			fs.rm(ssDir, { recursive: true, force: true }, () => {});
 			resolve({ code, raw: suppressSave ? readCucumberReportFile() : null });
 		});

package/backend/websockets/socketHandler.js

@@ -251,7 +251,7 @@ function runBuiltInAttempt({
 		proc.stderr.on('data', (d) => onLog(`[ERROR] ${d.toString()}`));
 
 		proc.on('close', (code) => {
-			clearInterval(ssPoller);
+			ssPoller.stop();
 			fs.rm(ssDir, { recursive: true, force: true }, () => {});
 			activeProcs.delete(proc);
 			resolve({ code, raw: suppressSave ? readCucumberReportFile() : null });
@@ -553,7 +553,7 @@ async function runDistributed(
 					proc.stderr.on('data', (d) => onLog(`[ERROR] ${d.toString()}`));
 
 					proc.on('close', (code) => {
-						clearInterval(ssPoller);
+						ssPoller.stop();
 						fs.rm(ssDir, { recursive: true, force: true }, () => {});
 						activeProcs.delete(proc);
 						const content =

package/frontend/src/lib/components/reports/LiveReplayer.svelte

@@ -24,9 +24,9 @@
 	let resizeObserver;
 
 	// rrweb-player renders at the recording's native resolution — scale-and-crop
-	// it to fill the stage (object-fit: cover) instead of letterboxing. Re-run on
-	// every stage resize, since the panel's own layout (tab strips appearing,
-	// window resize) can still shift its size after the player is built.
+	// it to fill the stage (object-fit: cover); letterboxing left visible bars
+	// when the aspect ratios didn't match. Re-run on every stage resize, since
+	// the panel's own layout can still shift its size after the player is built.
 	function updateScale() {
 		if (!nativeWidth || !nativeHeight) return;
 		const rect = stage.getBoundingClientRect();

package/frontend/src/lib/components/reports/RecordingPlayer.svelte

@@ -28,6 +28,9 @@
 	const MIN_PLAYER_WIDTH = 480;
 	const MIN_PLAYER_HEIGHT = 320;
 	const CONTROLLER_HEIGHT = 80;
+	// Covers rrweb's 50ms 'finish' scheduling delay after a paused seek, so it's
+	// never misread as reaching a natural finish.
+	const FINISH_SUPPRESS_MS = 150;
 	// Player would otherwise exactly fill .player-stage, leaving the button row
 	// flush against its edge — shrinks it so centering leaves a margin.
 	const STAGE_BREATHING_ROOM = 24;
@@ -116,8 +119,16 @@
 		// — e.g. after toggling Inspect there may be nothing loaded to render.
 		// Rebuild instead so the right FullSnapshot gets loaded again.
 		if (targetIdx === activeSegmentIndex && ts >= mountedFirst) {
+			if (!autoplay) suppressFinishUntil = Date.now() + FINISH_SUPPRESS_MS;
 			player?.goto(ts - mountedFirst, autoplay);
 			if (stepIndexOverride !== undefined) currentStepIndex = stepIndexOverride;
+			// goto() can cross a mid-stream FullSnapshot (e.g. a tab navigating off
+			// about:blank) and silently reset the iframe document — re-attach.
+			if (inspecting) {
+				teardownInspectListeners();
+				setupInspectListeners();
+				startInspectWatch();
+			}
 		} else {
 			activeSegmentIndex = targetIdx;
 			buildPlayer({
@@ -134,7 +145,14 @@
 		if (stepTimestamps[i] === undefined || !player) return;
 		currentStepIndex = i;
 		// Jump to the next marker — step i's own marker fires before its actions run.
-		const nextTs = stepTimestamps[i + 1] ?? segments[segments.length - 1]?.to;
+		// The last step has none: use the segment's real last event, not its `to`
+		// boundary (can sit past it) — landing at/past the real end reads as a
+		// natural finish instead of a paused seek (see suppressFinishUntil).
+		let nextTs = stepTimestamps[i + 1];
+		if (nextTs === undefined) {
+			const { first, span } = segmentEventBounds(segments[segments.length - 1]);
+			nextTs = first + Math.max(0, span - 1);
+		}
 		if (nextTs === undefined) return;
 		seekToAbsolute(nextTs, false, i);
 	}
@@ -184,6 +202,14 @@
 		doc.addEventListener('click', onClick, true);
 		doc.addEventListener('mouseleave', onLeave);
 		doc.addEventListener('keydown', onKeydown);
+		// rrweb can rebuild the document in place (document.open()/write()) without
+		// the contentDocument reference changing — watchInspectDoc's reference
+		// check alone would miss that a fresh documentElement wiped this marker.
+		try {
+			doc.documentElement.dataset.plumInspectWired = '1';
+		} catch {
+			// cross-origin/detached doc — inspect wiring is best-effort
+		}
 
 		cleanupInspect = () => {
 			doc.removeEventListener('mousemove', onMove);
@@ -220,7 +246,8 @@
 			return;
 		}
 		const doc = currentReplayer()?.iframe?.contentDocument;
-		if (doc && doc !== inspectAttachedDoc) {
+		const stillWired = doc?.documentElement?.dataset.plumInspectWired === '1';
+		if (doc && (doc !== inspectAttachedDoc || !stillWired)) {
 			teardownInspectListeners();
 			setupInspectListeners();
 		}
@@ -277,6 +304,8 @@
 	// during a paused seek's sync catch-up. Only real autoplay should trigger
 	// the auto-advance-to-next-tab below.
 	let awaitingNaturalFinish = false;
+	// Set right before any deliberate paused seek — see FINISH_SUPPRESS_MS.
+	let suppressFinishUntil = 0;
 
 	// rrweb's 50ms finish timeout isn't cancelled by destroying the replayer —
 	// a short segment can be torn down before its own stale finish fires,
@@ -304,6 +333,7 @@
 
 		replayer.on('finish', () => {
 			if (buildGeneration !== myGeneration) return;
+			if (Date.now() < suppressFinishUntil) return;
 			if (!awaitingNaturalFinish) return;
 			if (activeSegmentIndex < segments.length - 1) {
 				const speed = replayer.config.speed;
@@ -462,12 +492,18 @@
 			player.play();
 		} else if (resumeState.finished) {
 			player.setSpeed(resumeState.speed);
+			// A fresh Player starts at its first frame — without this explicit seek,
+			// rebuilding here (e.g. toggling Inspect after a natural finish) would
+			// show a blank first frame instead of staying on the last one.
+			suppressFinishUntil = Date.now() + FINISH_SUPPRESS_MS;
+			player.goto(timeOffset, false);
 			finished = true;
 			livePosition = overallTo;
 			// Restart button moved under this rebuild — recompute its position.
 			requestAnimationFrame(() => positionRestartButton(playPauseButton()));
 		} else {
 			player.setSpeed(resumeState.speed);
+			if (resumeState.paused) suppressFinishUntil = Date.now() + FINISH_SUPPRESS_MS;
 			player.goto(timeOffset, !resumeState.paused);
 		}
 

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "plum-e2e",
-	"version": "2.9.6",
+	"version": "2.9.7",
 	"repository": {
 		"type": "git",
 		"url": "https://github.com/silverlunah/plum.git"