plugin-git-manager 1.1.10 → 1.2.0

package/dist/server/collections/gitCodeReviews.d.ts

@@ -1,2 +1,2 @@
-declare const _default: any;
+declare const _default: import("@nocobase/database").CollectionOptions;
 export default _default;

package/dist/server/collections/gitCodeReviews.js

@@ -1,12 +1,3 @@
-/**
- * This file is part of the NocoBase (R) project.
- * Copyright (c) 2020-2024 NocoBase Co., Ltd.
- * Authors: NocoBase Team.
- *
- * This project is dual-licensed under AGPL-3.0 and NocoBase Commercial License.
- * For more information, please refer to: https://www.nocobase.com/agreement.
- */
-
 var __defProp = Object.defineProperty;
 var __getOwnPropDesc = Object.getOwnPropertyDescriptor;
 var __getOwnPropNames = Object.getOwnPropertyNames;
@@ -166,6 +157,7 @@ var gitCodeReviews_default = (0, import_database.defineCollection)({
           { value: "pending_approval", label: "Pending Approval" },
           { value: "approved", label: "Approved" },
           { value: "posted", label: "Posted" },
+          { value: "post_failed", label: "Post Failed" },
           { value: "skipped", label: "Skipped" },
           { value: "rejected", label: "Rejected" }
         ]

package/dist/server/collections/gitRepositories.d.ts

@@ -1,2 +1,2 @@
-declare const _default: any;
+declare const _default: import("@nocobase/database").CollectionOptions;
 export default _default;

package/dist/server/collections/gitRepositories.js

@@ -1,12 +1,3 @@
-/**
- * This file is part of the NocoBase (R) project.
- * Copyright (c) 2020-2024 NocoBase Co., Ltd.
- * Authors: NocoBase Team.
- *
- * This project is dual-licensed under AGPL-3.0 and NocoBase Commercial License.
- * For more information, please refer to: https://www.nocobase.com/agreement.
- */
-
 var __defProp = Object.defineProperty;
 var __getOwnPropDesc = Object.getOwnPropertyDescriptor;
 var __getOwnPropNames = Object.getOwnPropertyNames;

package/dist/server/collections/gitReviewFlows.d.ts

@@ -1,2 +1,2 @@
-declare const _default: any;
+declare const _default: import("@nocobase/database").CollectionOptions;
 export default _default;

package/dist/server/collections/gitReviewFlows.js

@@ -1,12 +1,3 @@
-/**
- * This file is part of the NocoBase (R) project.
- * Copyright (c) 2020-2024 NocoBase Co., Ltd.
- * Authors: NocoBase Team.
- *
- * This project is dual-licensed under AGPL-3.0 and NocoBase Commercial License.
- * For more information, please refer to: https://www.nocobase.com/agreement.
- */
-
 var __defProp = Object.defineProperty;
 var __getOwnPropDesc = Object.getOwnPropertyDescriptor;
 var __getOwnPropNames = Object.getOwnPropertyNames;

package/dist/server/index.js

@@ -1,12 +1,3 @@
-/**
- * This file is part of the NocoBase (R) project.
- * Copyright (c) 2020-2024 NocoBase Co., Ltd.
- * Authors: NocoBase Team.
- *
- * This project is dual-licensed under AGPL-3.0 and NocoBase Commercial License.
- * For more information, please refer to: https://www.nocobase.com/agreement.
- */
-
 var __create = Object.create;
 var __defProp = Object.defineProperty;
 var __getOwnPropDesc = Object.getOwnPropertyDescriptor;

package/dist/server/migrations/20260508000000-add-auto-review-flow-id.js

@@ -1,12 +1,3 @@
-/**
- * This file is part of the NocoBase (R) project.
- * Copyright (c) 2020-2024 NocoBase Co., Ltd.
- * Authors: NocoBase Team.
- *
- * This project is dual-licensed under AGPL-3.0 and NocoBase Commercial License.
- * For more information, please refer to: https://www.nocobase.com/agreement.
- */
-
 var __defProp = Object.defineProperty;
 var __getOwnPropDesc = Object.getOwnPropertyDescriptor;
 var __getOwnPropNames = Object.getOwnPropertyNames;

package/dist/server/plugin.js

@@ -1,12 +1,3 @@
-/**
- * This file is part of the NocoBase (R) project.
- * Copyright (c) 2020-2024 NocoBase Co., Ltd.
- * Authors: NocoBase Team.
- *
- * This project is dual-licensed under AGPL-3.0 and NocoBase Commercial License.
- * For more information, please refer to: https://www.nocobase.com/agreement.
- */
-
 var __create = Object.create;
 var __defProp = Object.defineProperty;
 var __getOwnPropDesc = Object.getOwnPropertyDescriptor;
@@ -105,6 +96,7 @@ class PluginGitManagerServer extends import_server.Plugin {
       }
       return next();
     });
+    (0, import_review.registerReviewQueue)(this.app);
     (0, import_ai_tools.registerGitReviewAiTools)(this.app);
     this.app.on("afterStart", async () => {
       await ensureAutoReviewFlowSchema(this.app).catch(
@@ -122,9 +114,11 @@ class PluginGitManagerServer extends import_server.Plugin {
       (0, import_poller.startPoller)(this.app);
     });
     this.app.on("beforeStop", () => {
+      (0, import_review.unregisterReviewQueue)(this.app);
       (0, import_poller.stopPoller)();
     });
     this.app.on("beforeDestroy", () => {
+      (0, import_review.unregisterReviewQueue)(this.app);
       (0, import_poller.stopPoller)();
     });
     this.app.acl.registerSnippet({
@@ -207,9 +201,11 @@ class PluginGitManagerServer extends import_server.Plugin {
     await ((_a = this.app.db.getCollection("gitRepositories")) == null ? void 0 : _a.sync());
   }
   async beforeDisable() {
+    (0, import_review.unregisterReviewQueue)(this.app);
     (0, import_poller.stopPoller)();
   }
   async beforeUnload() {
+    (0, import_review.unregisterReviewQueue)(this.app);
     (0, import_poller.stopPoller)();
   }
 }

package/dist/server/poller.js

@@ -1,12 +1,3 @@
-/**
- * This file is part of the NocoBase (R) project.
- * Copyright (c) 2020-2024 NocoBase Co., Ltd.
- * Authors: NocoBase Team.
- *
- * This project is dual-licensed under AGPL-3.0 and NocoBase Commercial License.
- * For more information, please refer to: https://www.nocobase.com/agreement.
- */
-
 var __defProp = Object.defineProperty;
 var __getOwnPropDesc = Object.getOwnPropertyDescriptor;
 var __getOwnPropNames = Object.getOwnPropertyNames;

package/dist/server/utils/gitlab-url.js

@@ -1,12 +1,3 @@
-/**
- * This file is part of the NocoBase (R) project.
- * Copyright (c) 2020-2024 NocoBase Co., Ltd.
- * Authors: NocoBase Team.
- *
- * This project is dual-licensed under AGPL-3.0 and NocoBase Commercial License.
- * For more information, please refer to: https://www.nocobase.com/agreement.
- */
-
 var __defProp = Object.defineProperty;
 var __getOwnPropDesc = Object.getOwnPropertyDescriptor;
 var __getOwnPropNames = Object.getOwnPropertyNames;

package/dist/server/utils/redact.js

@@ -1,12 +1,3 @@
-/**
- * This file is part of the NocoBase (R) project.
- * Copyright (c) 2020-2024 NocoBase Co., Ltd.
- * Authors: NocoBase Team.
- *
- * This project is dual-licensed under AGPL-3.0 and NocoBase Commercial License.
- * For more information, please refer to: https://www.nocobase.com/agreement.
- */
-
 var __defProp = Object.defineProperty;
 var __getOwnPropDesc = Object.getOwnPropertyDescriptor;
 var __getOwnPropNames = Object.getOwnPropertyNames;

package/package.json

@@ -3,7 +3,7 @@
   "displayName": "Git Manager",
   "displayName.zh-CN": "Git 管理器",
   "description": "Manage Git repositories with PAT authentication - pull, push, fetch, diff, file browsing",
-  "version": "1.1.10",
+  "version": "1.2.0",
   "license": "Apache-2.0",
   "main": "dist/server/index.js",
   "files": [
@@ -34,4 +34,4 @@
   "dependencies": {
     "simple-git": "^3.27.0"
   }
-}
+}

package/src/client/components/CommitHistory.tsx

@@ -49,6 +49,9 @@ export const CommitHistory: React.FC = () => {
       });
       const responseData = data?.data?.data || data?.data;
       setCommits(responseData?.all || []);
+    } catch (error) {
+      console.warn('Failed to load commit history:', error);
+      setCommits([]);
     } finally {
       setLoading(false);
     }

package/src/client/components/FileExplorer.tsx

@@ -75,30 +75,35 @@ export const FileExplorer: React.FC = () => {
   const loadTree = useCallback(
     async (treePath = '', ref = currentRef) => {
       if (!selectedRepo) return [];
-      const { data } = await api.request({
-        url: 'gitManager:fileTree',
-        params: { repositoryId: selectedRepo.id, ref, treePath },
-      });
-      const responseData = data?.data || data || [];
-      const list = Array.isArray(responseData) ? responseData : (Array.isArray(responseData?.data) ? responseData.data : []);
-      
-      return list.map((item: any) => ({
-        key: item.path,
-        title: (
-          <Text style={{ fontSize: 13 }}>
-            {item.name}
-            {item.type === 'blob' && item.size > 0 && (
-              <Text type="secondary" style={{ fontSize: 11, marginLeft: 8 }}>
-                {item.size > 1024 ? `${(item.size / 1024).toFixed(1)}KB` : `${item.size}B`}
-              </Text>
-            )}
-          </Text>
-        ),
-        icon: getFileIcon(item.name, item.type),
-        isLeaf: item.type === 'blob',
-        filePath: item.path,
-        fileType: item.type,
-      }));
+      try {
+        const { data } = await api.request({
+          url: 'gitManager:fileTree',
+          params: { repositoryId: selectedRepo.id, ref, treePath },
+        });
+        const responseData = data?.data || data || [];
+        const list = Array.isArray(responseData) ? responseData : (Array.isArray(responseData?.data) ? responseData.data : []);
+        
+        return list.map((item: any) => ({
+          key: item.path,
+          title: (
+            <Text style={{ fontSize: 13 }}>
+              {item.name}
+              {item.type === 'blob' && item.size > 0 && (
+                <Text type="secondary" style={{ fontSize: 11, marginLeft: 8 }}>
+                  {item.size > 1024 ? `${(item.size / 1024).toFixed(1)}KB` : `${item.size}B`}
+                </Text>
+              )}
+            </Text>
+          ),
+          icon: getFileIcon(item.name, item.type),
+          isLeaf: item.type === 'blob',
+          filePath: item.path,
+          fileType: item.type,
+        }));
+      } catch (error) {
+        console.warn('Failed to load file tree:', error);
+        return [];
+      }
     },
     [api, selectedRepo, currentRef],
   );

package/src/client/components/GitOperations.tsx

@@ -50,6 +50,9 @@ export const GitOperations: React.FC = () => {
       });
       const responseData = data?.data?.data || data?.data;
       setStatusData(responseData);
+    } catch (error) {
+      console.warn('Failed to load git status:', error);
+      setStatusData(null);
     } finally {
       setActionLoading(null);
     }

package/src/client/components/ReviewFlows.tsx

@@ -22,6 +22,15 @@ const POST_LABELS: Record<string, string> = {
   disabled: 'Disabled',
 };
 
+const DEFAULT_INSTRUCTION = `Please review the code changes with a focus on:
+1. Best Practices & Style:
+   - C#/VB.NET: Follow standard naming conventions (PascalCase for methods/properties, camelCase for fields). Ensure proper use of async/await (avoid .Result/.Wait()). Use LINQ efficiently.
+   - JS/TS: Use strict equality (===), prefer const/let. Ensure TypeScript types are explicit and avoid 'any'.
+2. Performance: Watch out for N+1 queries, unnecessary loops, and memory leaks.
+3. Security: Identify potential SQL injections, XSS vulnerabilities, and improper data validation.
+4. Maintainability: Check for readability, SOLID principles, and DRY. Ensure meaningful naming.
+5. Error Handling: Verify that exceptions are properly caught, handled, and logged.`;
+
 export const ReviewFlows: React.FC = () => {
   const t = useT();
   const api = useAPIClient();
@@ -92,6 +101,7 @@ export const ReviewFlows: React.FC = () => {
       enabled: true,
       triggerMode: 'manual',
       postMode: 'manual',
+      instructions: DEFAULT_INSTRUCTION,
     });
     setOpen(true);
   };
@@ -259,7 +269,7 @@ export const ReviewFlows: React.FC = () => {
             <Input placeholder="^(feature|hotfix)/.*$" />
           </Form.Item>
           <Form.Item name="instructions" label={t('Additional Instructions (optional)')}>
-            <Input.TextArea rows={4} placeholder={t('Extra guidance appended to every review prompt')} />
+            <Input.TextArea rows={8} placeholder={t('Extra guidance appended to every review prompt')} />
           </Form.Item>
           <Form.Item name="enabled" label={t('Enabled')} valuePropName="checked">
             <Switch />

package/src/client/components/ReviewHistory.tsx

@@ -25,6 +25,7 @@ const POST_STATUS_COLOR: Record<string, string> = {
   pending_approval: 'orange',
   approved: 'cyan',
   posted: 'green',
+  post_failed: 'red',
   skipped: 'default',
   rejected: 'red',
 };
@@ -278,6 +279,7 @@ export const ReviewHistory: React.FC<{ initialFilter?: 'all' | 'pending_approval
             { value: 'pending_approval', label: t('pending_approval') },
             { value: 'approved', label: t('approved') },
             { value: 'posted', label: t('posted') },
+            { value: 'post_failed', label: t('post_failed') },
             { value: 'skipped', label: t('skipped') },
             { value: 'rejected', label: t('rejected') },
           ]}
@@ -395,7 +397,9 @@ const ReviewDetailView: React.FC<{
   const canApprove =
     review.status === 'completed' &&
     review.targetType === 'mr' &&
-    (review.postStatus === 'pending_approval' || review.postStatus === 'approved');
+    (review.postStatus === 'pending_approval' ||
+      review.postStatus === 'approved' ||
+      review.postStatus === 'post_failed');
 
   return (
     <div>
@@ -417,6 +421,15 @@ const ReviewDetailView: React.FC<{
           style={{ marginBottom: 16 }}
         />
       )}
+      {review.status === 'completed' && review.postStatus === 'post_failed' && review.error && (
+        <Alert
+          type="error"
+          showIcon
+          message={t('Post Failed')}
+          description={<pre style={{ whiteSpace: 'pre-wrap', margin: 0 }}>{review.error}</pre>}
+          style={{ marginBottom: 16 }}
+        />
+      )}
 
       {/* Action bar */}
       {canApprove && (

package/src/locale/en-US.json

@@ -125,6 +125,8 @@
   "Posted": "Posted",
   "Pending Approval": "Pending Approval",
   "Approved": "Approved",
+  "Post Failed": "Post Failed",
+  "post_failed": "Post failed",
   "Rejected": "Rejected",
   "Skipped": "Skipped",
   "Running": "Running",

package/src/locale/vi-VN.json

@@ -125,6 +125,8 @@
   "Posted": "Đã đăng",
   "Pending Approval": "Chờ duyệt",
   "Approved": "Đã duyệt",
+  "Post Failed": "Đăng thất bại",
+  "post_failed": "Đăng thất bại",
   "Rejected": "Đã từ chối",
   "Skipped": "Đã bỏ qua",
   "Running": "Đang chạy",

package/src/server/actions/git-actions.ts

@@ -91,7 +91,10 @@ function getAuthUrl(repoUrl: string, pat: string, username?: string): string {
   return url.toString();
 }
 
-function getGit(localPath: string): SimpleGit {
+function getGit(ctx: Context, localPath: string): SimpleGit {
+  if (!fs.existsSync(localPath)) {
+    ctx.throw(400, 'Repository directory does not exist. Please clone the repository first.');
+  }
   return simpleGit(localPath);
 }
 
@@ -170,7 +173,7 @@ export async function pull(ctx: Context, next: () => Promise<void>) {
   const repoUrl = (repo.get('repoUrl') as string || '').trim();
   const username = (repo.get('username') as string || '').trim();
 
-  const git = getGit(localPath);
+  const git = getGit(ctx, localPath);
   const result = await withAuth(git, localPath, repoUrl, pat, () => git.pull(), username);
 
   ctx.body = { success: true, data: result };
@@ -184,7 +187,7 @@ export async function push(ctx: Context, next: () => Promise<void>) {
   const repoUrl = (repo.get('repoUrl') as string || '').trim();
   const username = (repo.get('username') as string || '').trim();
 
-  const git = getGit(localPath);
+  const git = getGit(ctx, localPath);
   const result = await withAuth(git, localPath, repoUrl, pat, () => git.push(), username);
 
   ctx.body = { success: true, data: result };
@@ -198,7 +201,7 @@ export async function fetch(ctx: Context, next: () => Promise<void>) {
   const repoUrl = (repo.get('repoUrl') as string || '').trim();
   const username = (repo.get('username') as string || '').trim();
 
-  const git = getGit(localPath);
+  const git = getGit(ctx, localPath);
   const result = await withAuth(git, localPath, repoUrl, pat, () => git.fetch(), username);
 
   ctx.body = { success: true, data: result };
@@ -210,7 +213,7 @@ export async function diff(ctx: Context, next: () => Promise<void>) {
   const localPath = validateLocalPath(repo.get('localPath'));
   const { file, commitHash, compareHash } = ctx.action.params;
 
-  const git = getGit(localPath);
+  const git = getGit(ctx, localPath);
   const args: string[] = [];
   if (commitHash && compareHash) {
     args.push(validateRef(commitHash), validateRef(compareHash));
@@ -230,7 +233,7 @@ export async function diff(ctx: Context, next: () => Promise<void>) {
 export async function status(ctx: Context, next: () => Promise<void>) {
   const repo = await getRepo(ctx);
   const localPath = validateLocalPath(repo.get('localPath'));
-  const result = await getGit(localPath).status();
+  const result = await getGit(ctx, localPath).status();
   ctx.body = { success: true, data: result };
   await next();
 }
@@ -247,7 +250,7 @@ export async function log(ctx: Context, next: () => Promise<void>) {
     options.file = file;
   }
 
-  const result = await getGit(localPath).log(options);
+  const result = await getGit(ctx, localPath).log(options);
   ctx.body = { success: true, data: result };
   await next();
 }
@@ -255,7 +258,7 @@ export async function log(ctx: Context, next: () => Promise<void>) {
 export async function branches(ctx: Context, next: () => Promise<void>) {
   const repo = await getRepo(ctx);
   const localPath = validateLocalPath(repo.get('localPath'));
-  const result = await getGit(localPath).branch();
+  const result = await getGit(ctx, localPath).branch();
   ctx.body = { success: true, data: result };
   await next();
 }
@@ -265,7 +268,7 @@ export async function checkout(ctx: Context, next: () => Promise<void>) {
   const localPath = validateLocalPath(repo.get('localPath'));
   const { branch } = ctx.action.params;
   validateBranch(branch);
-  await getGit(localPath).checkout(branch);
+  await getGit(ctx, localPath).checkout(branch);
   ctx.body = { success: true, message: `Switched to branch ${branch}` };
   await next();
 }
@@ -275,7 +278,7 @@ export async function fileTree(ctx: Context, next: () => Promise<void>) {
   const localPath = validateLocalPath(repo.get('localPath'));
   const { ref = 'HEAD', treePath = '' } = ctx.action.params;
 
-  const git = getGit(localPath);
+  const git = getGit(ctx, localPath);
   validateRef(ref);
   if (treePath && treePath.includes('..')) {
     ctx.throw(400, 'Invalid tree path');
@@ -324,7 +327,7 @@ export async function fileContent(ctx: Context, next: () => Promise<void>) {
   }
 
   validateRef(ref);
-  const git = getGit(localPath);
+  const git = getGit(ctx, localPath);
   const content = await git.show([`${ref}:${filePath}`]);
   ctx.body = { success: true, data: { content, filePath, ref } };
   await next();
@@ -339,7 +342,7 @@ export async function commitDetail(ctx: Context, next: () => Promise<void>) {
     ctx.throw(400, 'commitHash is required');
   }
 
-  const git = getGit(localPath);
+  const git = getGit(ctx, localPath);
   validateRef(commitHash);
 
   // Use %x00 in format string to tell git to output null bytes, avoiding null bytes in args