plugin-file-preview-auth 1.3.9 → 1.3.11

package/package.json

@@ -1,57 +1,57 @@
-{
-  "name": "plugin-file-preview-auth",
-  "displayName": "Authenticated File Previewer",
-  "displayName.vi-VN": "Xem trước file có xác thực",
-  "displayName.zh-CN": "认证文件预览",
-  "description": "Preview PDF, image, and text files with Bearer token authentication via blob URLs.",
-  "description.vi-VN": "Xem trước file PDF, hình ảnh và văn bản với xác thực Bearer token qua blob URL.",
-  "description.zh-CN": "通过 Bearer 令牌认证和 Blob URL 预览 PDF、图片和文本文件。",
-  "version": "1.3.9",
-  "main": "dist/server/index.js",
-  "files": [
-    "dist",
-    "public",
-    "client.js",
-    "client.d.ts",
-    "server.js",
-    "server.d.ts",
-    "README.md",
-    "client-v2.js",
-    "client-v2.d.ts",
-    "src"
-  ],
-  "peerDependencies": {
-    "@aws-sdk/client-s3": "*",
-    "@nocobase/client": "2.x",
-    "@nocobase/database": "2.x",
-    "@nocobase/plugin-ai": "2.x",
-    "@nocobase/plugin-file-manager": "2.x",
-    "@nocobase/server": "2.x",
-    "@nocobase/utils": "2.x",
-    "@nocobase/client-v2": "2.x",
-    "@nocobase/flow-engine": "2.x"
-  },
-  "peerDependenciesMeta": {
-    "@nocobase/plugin-ai": {
-      "optional": true
-    }
-  },
-  "devDependencies": {},
-  "keywords": [
-    "File manager",
-    "File preview",
-    "Authentication"
-  ],
-  "license": "Apache-2.0",
-  "dependencies": {
-    "docx-preview": "^0.3.3",
-    "react-pptx-preview-kit": "^0.1.9",
-    "xlsx": "^0.18.5"
-  },
-  "nocobase": {
-    "supportedVersions": [
-      "2.x"
-    ],
-    "editionLevel": 0
-  }
-}
+{
+  "name": "plugin-file-preview-auth",
+  "displayName": "Authenticated File Previewer",
+  "displayName.vi-VN": "Xem trước file có xác thực",
+  "displayName.zh-CN": "认证文件预览",
+  "description": "Preview PDF, image, and text files with Bearer token authentication via blob URLs.",
+  "description.vi-VN": "Xem trước file PDF, hình ảnh và văn bản với xác thực Bearer token qua blob URL.",
+  "description.zh-CN": "通过 Bearer 令牌认证和 Blob URL 预览 PDF、图片和文本文件。",
+  "version": "1.3.11",
+  "main": "dist/server/index.js",
+  "files": [
+    "dist",
+    "public",
+    "client.js",
+    "client.d.ts",
+    "server.js",
+    "server.d.ts",
+    "README.md",
+    "client-v2.js",
+    "client-v2.d.ts",
+    "src"
+  ],
+  "peerDependencies": {
+    "@aws-sdk/client-s3": "*",
+    "@nocobase/client": "2.x",
+    "@nocobase/database": "2.x",
+    "@nocobase/plugin-ai": "2.x",
+    "@nocobase/plugin-file-manager": "2.x",
+    "@nocobase/server": "2.x",
+    "@nocobase/utils": "2.x",
+    "@nocobase/client-v2": "2.x",
+    "@nocobase/flow-engine": "2.x"
+  },
+  "peerDependenciesMeta": {
+    "@nocobase/plugin-ai": {
+      "optional": true
+    }
+  },
+  "devDependencies": {},
+  "keywords": [
+    "File manager",
+    "File preview",
+    "Authentication"
+  ],
+  "license": "Apache-2.0",
+  "dependencies": {
+    "docx-preview": "^0.3.3",
+    "react-pptx-preview-kit": "^0.1.9",
+    "xlsx": "^0.18.5"
+  },
+  "nocobase": {
+    "supportedVersions": [
+      "2.x"
+    ],
+    "editionLevel": 0
+  }
+}

package/src/client/AIFilePreviewAction.tsx

@@ -9,8 +9,7 @@
 
 import React, { useCallback, useEffect, useMemo, useState } from 'react';
 import { FileTextOutlined, RobotOutlined } from '@ant-design/icons';
-import { Button, Dropdown, Space, Tooltip, message } from 'antd';
-import type { MenuProps } from 'antd';
+import { Button, Space, Tooltip, message } from 'antd';
 import type { Application } from '@nocobase/client';
 import { useChatBoxActions, useAIConfigRepository, type AIEmployee } from '@nocobase/plugin-ai/client';
 import { useT } from './locale';
@@ -80,10 +79,6 @@ function setStoredAIEmployeeUsername(username: string) {
   }
 }
 
-function getEmployeeLabel(employee: AIEmployee) {
-  return employee?.nickname || employee?.username || '';
-}
-
 class AIFilePreviewActionBoundary extends React.Component<{ children: React.ReactNode }, { hasError: boolean }> {
   constructor(props: { children: React.ReactNode }) {
     super(props);
@@ -186,48 +181,27 @@ const AIFilePreviewActionInner: React.FC<{ file: any }> = ({ file }) => {
     [file, t, triggerTask],
   );
 
-  const menuItems: MenuProps['items'] = orderedEmployees.map((employee) => ({
-    key: employee.username,
-    label: getEmployeeLabel(employee),
-    onClick: () => openAIChat(employee),
-  }));
-
   if (!loading && !orderedEmployees.length) {
     return null;
   }
 
-  if (orderedEmployees.length === 1) {
-    return (
-      <Tooltip title={t('Ask AI')}>
-        <Button
-          type="text"
-          size="small"
-          icon={<RobotOutlined />}
-          loading={asking || loading}
-          onClick={(event) => {
-            event.stopPropagation();
-            openAIChat(orderedEmployees[0]);
-          }}
-        >
-          {t('Ask AI')}
-        </Button>
-      </Tooltip>
-    );
-  }
-
+  // Single click attaches the file content to the chat box using the preferred
+  // employee (last used, otherwise the first available) without listing employees.
   return (
     <Tooltip title={t('Ask AI')}>
-      <Dropdown menu={{ items: menuItems }} trigger={['click']} placement="bottomRight" disabled={asking || loading}>
-        <Button
-          type="text"
-          size="small"
-          icon={<RobotOutlined />}
-          loading={asking || loading}
-          onClick={(event) => event.stopPropagation()}
-        >
-          {t('Ask AI')}
-        </Button>
-      </Dropdown>
+      <Button
+        type="text"
+        size="small"
+        icon={<RobotOutlined />}
+        loading={asking || loading}
+        disabled={!orderedEmployees.length}
+        onClick={(event) => {
+          event.stopPropagation();
+          openAIChat(orderedEmployees[0]);
+        }}
+      >
+        {t('Ask AI')}
+      </Button>
     </Tooltip>
   );
 };

package/src/client/__tests__/ocr-utils.test.ts

@@ -1,85 +1,103 @@
-import { extractOcrStatusRecord, getOcrAttachmentId, isOcrCompleteStatus, normalizeOcrAttachmentId } from '../index';
-
-describe('file preview OCR client utils', () => {
-  describe('normalizeOcrAttachmentId', () => {
-    it('accepts numeric attachment ids', () => {
-      expect(normalizeOcrAttachmentId(12)).toBe(12);
-      expect(normalizeOcrAttachmentId('12')).toBe('12');
-      expect(normalizeOcrAttachmentId(' 12 ')).toBe('12');
-    });
-
-    it('rejects URLs and upload-only ids', () => {
-      expect(normalizeOcrAttachmentId('http://localhost/storage/uploads/test.pdf')).toBeNull();
-      expect(normalizeOcrAttachmentId('/storage/uploads/test.pdf')).toBeNull();
-      expect(normalizeOcrAttachmentId('rc-upload-1710000000000-1')).toBeNull();
-    });
-  });
-
-  describe('getOcrAttachmentId', () => {
-    it('uses response.id when file.id is a storage URL', () => {
-      expect(
-        getOcrAttachmentId({
-          id: 'http://localhost/storage/uploads/yyyy-test%20(1)-lcqadd.pdf',
-          uid: 'rc-upload-1',
-          response: {
-            id: 42,
-          },
-        }),
-      ).toBe(42);
-    });
-
-    it('falls back to a numeric uid for persisted attachment records', () => {
-      expect(
-        getOcrAttachmentId({
-          id: '/storage/uploads/yyyy-test.pdf',
-          uid: '88',
-        }),
-      ).toBe('88');
-    });
-  });
-
-  describe('isOcrCompleteStatus', () => {
-    it('only treats result statuses as completed', () => {
-      expect(isOcrCompleteStatus('waiting-verify')).toBe(true);
-      expect(isOcrCompleteStatus('success')).toBe(true);
-      expect(isOcrCompleteStatus('no-ocr')).toBe(false);
-      expect(isOcrCompleteStatus('pending-ocr')).toBe(false);
-      expect(isOcrCompleteStatus('failed')).toBe(false);
-    });
-  });
-
-  describe('extractOcrStatusRecord', () => {
-    it('unwraps NocoBase double data responses', () => {
-      const record = extractOcrStatusRecord({
-        data: {
-          data: {
-            id: 4,
-            attachmentId: 57,
-            status: 'waiting-verify',
-            data: { pages: [] },
-            error: null,
-          },
-        },
-      });
-
-      expect(record?.id).toBe(4);
-      expect(record?.attachmentId).toBe(57);
-      expect(record?.status).toBe('waiting-verify');
-    });
-
-    it('unwraps action responses with ok and data', () => {
-      const record = extractOcrStatusRecord({
-        data: {
-          ok: true,
-          data: {
-            id: 5,
-            status: 'pending-ocr',
-          },
-        },
-      });
-
-      expect(record?.id).toBe(5);
-      expect(record?.status).toBe('pending-ocr');
-    });
-  });
-});
+import {
+  extractOcrStatusRecord,
+  getOcrAttachmentId,
+  isOcrCapableCollection,
+  isOcrCompleteStatus,
+  normalizeOcrAttachmentId,
+} from '../index';
+
+describe('file preview OCR client utils', () => {
+  describe('normalizeOcrAttachmentId', () => {
+    it('accepts numeric attachment ids', () => {
+      expect(normalizeOcrAttachmentId(12)).toBe(12);
+      expect(normalizeOcrAttachmentId('12')).toBe('12');
+      expect(normalizeOcrAttachmentId(' 12 ')).toBe('12');
+    });
+
+    it('rejects URLs and upload-only ids', () => {
+      expect(normalizeOcrAttachmentId('http://localhost/storage/uploads/test.pdf')).toBeNull();
+      expect(normalizeOcrAttachmentId('/storage/uploads/test.pdf')).toBeNull();
+      expect(normalizeOcrAttachmentId('rc-upload-1710000000000-1')).toBeNull();
+    });
+  });
+
+  describe('getOcrAttachmentId', () => {
+    it('uses response.id when file.id is a storage URL', () => {
+      expect(
+        getOcrAttachmentId({
+          id: 'http://localhost/storage/uploads/yyyy-test%20(1)-lcqadd.pdf',
+          uid: 'rc-upload-1',
+          response: {
+            id: 42,
+          },
+        }),
+      ).toBe(42);
+    });
+
+    it('falls back to a numeric uid for persisted attachment records', () => {
+      expect(
+        getOcrAttachmentId({
+          id: '/storage/uploads/yyyy-test.pdf',
+          uid: '88',
+        }),
+      ).toBe('88');
+    });
+  });
+
+  describe('isOcrCapableCollection', () => {
+    it('allows attachments and collection-less records', () => {
+      expect(isOcrCapableCollection({ id: 1 })).toBe(true);
+      expect(isOcrCapableCollection({ id: 1, collectionName: 'attachments' })).toBe(true);
+      expect(isOcrCapableCollection({ id: 1, collectionName: '' })).toBe(true);
+    });
+
+    it('rejects non-attachment collections like aiFiles', () => {
+      expect(isOcrCapableCollection({ id: 1, collectionName: 'aiFiles' })).toBe(false);
+    });
+  });
+
+  describe('isOcrCompleteStatus', () => {
+    it('only treats result statuses as completed', () => {
+      expect(isOcrCompleteStatus('waiting-verify')).toBe(true);
+      expect(isOcrCompleteStatus('success')).toBe(true);
+      expect(isOcrCompleteStatus('no-ocr')).toBe(false);
+      expect(isOcrCompleteStatus('pending-ocr')).toBe(false);
+      expect(isOcrCompleteStatus('failed')).toBe(false);
+    });
+  });
+
+  describe('extractOcrStatusRecord', () => {
+    it('unwraps NocoBase double data responses', () => {
+      const record = extractOcrStatusRecord({
+        data: {
+          data: {
+            id: 4,
+            attachmentId: 57,
+            status: 'waiting-verify',
+            data: { pages: [] },
+            error: null,
+          },
+        },
+      });
+
+      expect(record?.id).toBe(4);
+      expect(record?.attachmentId).toBe(57);
+      expect(record?.status).toBe('waiting-verify');
+    });
+
+    it('unwraps action responses with ok and data', () => {
+      const record = extractOcrStatusRecord({
+        data: {
+          ok: true,
+          data: {
+            id: 5,
+            status: 'pending-ocr',
+          },
+        },
+      });
+
+      expect(record?.id).toBe(5);
+      expect(record?.status).toBe('pending-ocr');
+    });
+  });
+});