plugin-agent-orchestrator 1.2.0 → 1.2.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/LICENSE +201 -0
- package/dist/client/{117.2e4cb0477da3db1f.js → 117.6c69b6a87751dd18.js} +1 -1
- package/dist/client/{253.93deb9e0192e76a5.js → 253.52f62e1bc0e9520a.js} +1 -1
- package/dist/client/{404.498d2d9516dd1dce.js → 404.86593f98c9768ed5.js} +1 -1
- package/dist/client/{627.fdd60bcc0f3a9cf6.js → 453.fa2d169576262213.js} +1 -1
- package/dist/client/{53.774ff07505d521fa.js → 53.567db3ae078650c6.js} +1 -1
- package/dist/client/{619.e342b0fa467d39ca.js → 619.01713281e5e951d3.js} +1 -1
- package/dist/client/652.69da1598312b3a3f.js +10 -0
- package/dist/client/773.648965568ff476f9.js +10 -0
- package/dist/client/{981.e0546ffc34afedcd.js → 981.37e7aeecdb1ef6fa.js} +1 -1
- package/dist/client/{993.5d04b510835ab0d2.js → 993.ac89f3852990918d.js} +1 -1
- package/dist/client/index.js +1 -1
- package/dist/client-v2/{117.ccf43ae8631f7d74.js → 117.c982d79ff68738f5.js} +1 -1
- package/dist/client-v2/{214.cdf76752053a8990.js → 214.94c4257bf2838577.js} +1 -1
- package/dist/client-v2/{253.1198df22f5baf304.js → 253.8e19956d2a44dfb8.js} +1 -1
- package/dist/client-v2/{264.78887ff88f969467.js → 264.80e8e358c8c6c2e5.js} +1 -1
- package/dist/client-v2/{404.9ba964c28a151c81.js → 404.ab032b79c95dab6f.js} +1 -1
- package/dist/client-v2/{41.b28cf7a675a603d1.js → 41.cd5610fcf7446127.js} +1 -1
- package/dist/client-v2/{627.e16f4a0dd596c3e6.js → 453.42c6d70628d56cc2.js} +1 -1
- package/dist/client-v2/{53.282081f97e4308c6.js → 53.37c08089a648f89a.js} +1 -1
- package/dist/client-v2/{619.8c03913873785fb6.js → 619.6e9618550101e819.js} +1 -1
- package/dist/client-v2/652.eeba4e0c38367321.js +10 -0
- package/dist/client-v2/{70.9166ed70906d041f.js → 70.332698e53eb59677.js} +1 -1
- package/dist/client-v2/773.4de2ba5acb07318c.js +10 -0
- package/dist/client-v2/981.76060f466e6f7c11.js +10 -0
- package/dist/client-v2/{993.ca5b28f1e2b4c1ef.js → 993.f8cdb5172566ce75.js} +1 -1
- package/dist/client-v2/index.js +1 -1
- package/dist/externalVersion.js +4 -1
- package/dist/locale/en-US.json +80 -1
- package/dist/locale/vi-VN.json +5 -1
- package/dist/locale/zh-CN.json +80 -1
- package/dist/node_modules/acorn/LICENSE +21 -0
- package/dist/node_modules/acorn/bin/acorn +4 -0
- package/dist/node_modules/acorn/dist/acorn.d.mts +857 -0
- package/dist/node_modules/acorn/dist/acorn.d.ts +857 -0
- package/dist/node_modules/acorn/dist/acorn.js +1 -0
- package/dist/node_modules/acorn/dist/bin.js +90 -0
- package/dist/node_modules/acorn/package.json +1 -0
- package/dist/node_modules/acorn-walk/LICENSE +21 -0
- package/dist/node_modules/acorn-walk/dist/walk.d.mts +177 -0
- package/dist/node_modules/acorn-walk/dist/walk.d.ts +177 -0
- package/dist/node_modules/acorn-walk/dist/walk.js +1 -0
- package/dist/node_modules/acorn-walk/node_modules/.bin/acorn +15 -0
- package/dist/node_modules/acorn-walk/node_modules/.bin/acorn.cmd +7 -0
- package/dist/node_modules/acorn-walk/node_modules/acorn/bin/acorn +4 -0
- package/dist/node_modules/acorn-walk/node_modules/acorn/dist/acorn.d.mts +866 -0
- package/dist/node_modules/acorn-walk/node_modules/acorn/dist/acorn.d.ts +866 -0
- package/dist/node_modules/acorn-walk/node_modules/acorn/dist/acorn.js +6174 -0
- package/dist/node_modules/acorn-walk/node_modules/acorn/dist/bin.js +90 -0
- package/dist/node_modules/acorn-walk/node_modules/acorn/package.json +50 -0
- package/dist/node_modules/acorn-walk/package.json +1 -0
- package/dist/node_modules/adm-zip/package.json +1 -1
- package/dist/node_modules/ajv/package.json +1 -1
- package/dist/node_modules/zod/package.json +1 -1
- package/dist/server/collections/agent-auto-approval-checkpoints.js +47 -0
- package/dist/server/collections/agent-execution-spans.js +3 -3
- package/dist/server/collections/agent-hierarchy-invocations.js +59 -0
- package/dist/server/collections/agent-routing-graph-locks.js +40 -0
- package/dist/server/collections/agent-session-auto-approvals.js +45 -0
- package/dist/server/collections/orchestrator-config.js +17 -0
- package/dist/server/migrations/20261119000000-widen-native-employee-identifiers.js +59 -0
- package/dist/server/plugin.js +80 -12
- package/dist/server/resources/agent-auto-approval.js +80 -0
- package/dist/server/resources/hierarchical-routing.js +60 -0
- package/dist/server/services/AutoApprovalCheckpoint.js +133 -0
- package/dist/server/services/CodeValidator.js +8 -4
- package/dist/server/services/GovernanceAdmission.js +60 -0
- package/dist/server/services/HarnessCompiler.js +3 -0
- package/dist/server/services/HarnessSchema.js +13 -1
- package/dist/server/services/HierarchicalAgentRuntime.js +925 -0
- package/dist/server/services/HierarchyEnrollmentGuard.js +216 -0
- package/dist/server/services/HierarchyInvocationJournal.js +157 -0
- package/dist/server/services/HierarchyRequestCancellation.js +150 -0
- package/dist/server/services/LoopRunRepository.js +1 -1
- package/dist/server/services/LoopRunStateMachine.js +2 -2
- package/dist/server/services/LoopWorkerService.js +7 -7
- package/dist/server/services/ParallelInterruptActionsPatch.js +132 -0
- package/dist/server/services/PluginAiRuntimeAdapter.js +107 -9
- package/dist/server/services/RoutingBindingRepository.js +156 -0
- package/dist/server/services/RoutingBindingValidation.js +161 -0
- package/dist/server/services/SandboxRunner.js +19 -0
- package/dist/server/services/SessionAutoApproval.js +173 -0
- package/dist/server/services/VerificationService.js +2 -2
- package/dist/server/skill-hub/plugin.js +17 -0
- package/dist/server/skill-hub/services/RegistrySkillInstallationService.js +2 -2
- package/dist/server/skill-hub/services/registry-node-package.js +191 -0
- package/dist/server/skill-hub/tasks/SkillExecutionTask.js +21 -6
- package/dist/server/tools/skill-execute.js +1 -0
- package/dist/server/utils/ensure-indexes.js +1 -0
- package/package.json +5 -2
- package/src/client/SkillPages.tsx +1 -8
- package/src/client/__tests__/embedded-settings.test.tsx +1 -8
- package/src/client/plugin.tsx +3 -8
- package/src/client/skill-hub/tools/InteractionSchemasProvider.tsx +21 -6
- package/src/client/skill-hub/tools/SkillHubCard.tsx +22 -16
- package/src/client/skill-hub/tools/__tests__/skill-hub-card.test.tsx +255 -0
- package/src/client/skill-hub/tools/registerSkillLoopCards.ts +12 -3
- package/src/client-v2/__tests__/embedded-settings.test.tsx +20 -11
- package/src/client-v2/__tests__/hierarchical-routing-settings.test.tsx +350 -0
- package/src/client-v2/auto-approval/AutoApprovalBridge.tsx +513 -0
- package/src/client-v2/auto-approval/AutoApprovalProvider.tsx +399 -0
- package/src/client-v2/auto-approval/__tests__/session-auto-approval.test.tsx +1676 -0
- package/src/client-v2/components/AgentBindingsTab.tsx +275 -3
- package/src/client-v2/components/AgentRunsTab.tsx +1 -8
- package/src/client-v2/components/EmployeeGovernanceTab.tsx +1 -8
- package/src/client-v2/components/HarnessProfilesTab.tsx +4 -8
- package/src/client-v2/components/HarnessSettingsForm.tsx +221 -0
- package/src/client-v2/components/UsageGovernanceTab.tsx +1 -8
- package/src/client-v2/pages/AgentBindingsPage.tsx +1 -8
- package/src/client-v2/pages/ApprovalsPage.tsx +1 -8
- package/src/client-v2/pages/EmployeeGovernancePage.tsx +1 -8
- package/src/client-v2/pages/ExecutionHistoryPage.tsx +1 -8
- package/src/client-v2/pages/HarnessProfilesPage.tsx +1 -8
- package/src/client-v2/pages/KnowledgeAccessPage.tsx +1 -8
- package/src/client-v2/pages/LoopSettingsPage.tsx +1 -8
- package/src/client-v2/pages/MemoryInspectorPage.tsx +1 -8
- package/src/client-v2/pages/RetrievalTracePage.tsx +1 -8
- package/src/client-v2/pages/RulesPage.tsx +1 -8
- package/src/client-v2/pages/SkillDefinitionsPage.tsx +1 -8
- package/src/client-v2/pages/SkillMetricsPage.tsx +1 -8
- package/src/client-v2/pages/TracingPage.tsx +1 -8
- package/src/client-v2/pages/UsageGovernancePage.tsx +1 -8
- package/src/client-v2/plugin.tsx +3 -8
- package/src/client-v2/skill-hub/tools/__tests__/interactions.test.ts +17 -1
- package/src/client-v2/skill-hub/tools/interactions.ts +12 -3
- package/src/locale/en-US.json +80 -1
- package/src/locale/vi-VN.json +5 -1
- package/src/locale/zh-CN.json +80 -1
- package/src/server/__tests__/agent-governance.integration.test.ts +1 -8
- package/src/server/__tests__/agent-monitor-acl.integration.test.ts +1 -8
- package/src/server/__tests__/agent-usage-report.integration.test.ts +1 -8
- package/src/server/__tests__/auto-approval-checkpoint.integration.test.ts +295 -0
- package/src/server/__tests__/harness-capabilities.test.ts +1 -8
- package/src/server/__tests__/harness-compiler.test.ts +64 -0
- package/src/server/__tests__/harness-tool-plan.test.ts +1 -8
- package/src/server/__tests__/hierarchical-routing.integration.test.ts +2318 -0
- package/src/server/__tests__/hierarchy-invocation-journal.integration.test.ts +119 -0
- package/src/server/__tests__/loop-approval-decision.test.ts +59 -12
- package/src/server/__tests__/loop-budget-service.test.ts +1 -8
- package/src/server/__tests__/loop-run-repository.test.ts +1 -8
- package/src/server/__tests__/loop-trigger-service.test.ts +1 -8
- package/src/server/__tests__/loop-worker-claim.test.ts +46 -9
- package/src/server/__tests__/loop-worker-execution.test.ts +1 -8
- package/src/server/__tests__/native-agent-monitor-sync.test.ts +1 -8
- package/src/server/__tests__/native-hierarchy-probe.integration.test.ts +527 -0
- package/src/server/__tests__/native-sub-agent-observer.test.ts +1 -8
- package/src/server/__tests__/native-usage-attribution.integration.test.ts +1 -8
- package/src/server/__tests__/parallel-interrupt-actions.test.ts +342 -0
- package/src/server/__tests__/plugin-ai-runtime-adapter.test.ts +403 -0
- package/src/server/__tests__/registry-node-package.test.ts +299 -0
- package/src/server/__tests__/routing-binding-graph.integration.test.ts +217 -0
- package/src/server/__tests__/routing-binding-validation.test.ts +256 -0
- package/src/server/__tests__/session-auto-approval.integration.test.ts +329 -0
- package/src/server/__tests__/skill-execute.test.ts +11 -0
- package/src/server/__tests__/skill-review-guard.test.ts +171 -0
- package/src/server/__tests__/token-tracker.test.ts +1 -8
- package/src/server/__tests__/tracing-retention-policy.test.ts +1 -8
- package/src/server/__tests__/usage-ledger.integration.test.ts +1 -8
- package/src/server/collections/agent-auto-approval-checkpoints.ts +18 -0
- package/src/server/collections/agent-execution-spans.ts +4 -11
- package/src/server/collections/agent-governance-audit-events.ts +1 -8
- package/src/server/collections/agent-governance-policies.ts +1 -8
- package/src/server/collections/agent-governance-policy-versions.ts +1 -8
- package/src/server/collections/agent-governance-prompt-bindings.ts +1 -8
- package/src/server/collections/agent-hierarchy-invocations.ts +30 -0
- package/src/server/collections/agent-loop-runs.ts +1 -8
- package/src/server/collections/agent-routing-graph-locks.ts +11 -0
- package/src/server/collections/agent-session-auto-approvals.ts +16 -0
- package/src/server/collections/orchestrator-config.ts +26 -0
- package/src/server/migrations/20261110000000-add-usage-pricing-snapshots.ts +1 -8
- package/src/server/migrations/20261110010000-add-usage-department-attribution.ts +1 -8
- package/src/server/migrations/20261119000000-widen-native-employee-identifiers.ts +37 -0
- package/src/server/plugin.ts +72 -8
- package/src/server/resources/agent-auto-approval.ts +51 -0
- package/src/server/resources/agent-governance.ts +1 -8
- package/src/server/resources/agent-harness-profile.ts +1 -8
- package/src/server/resources/agent-monitor.ts +1 -8
- package/src/server/resources/agent-usage.ts +1 -8
- package/src/server/resources/hierarchical-routing.ts +39 -0
- package/src/server/resources/native-monitor-format.ts +1 -8
- package/src/server/resources/tracing.ts +1 -8
- package/src/server/services/AgentGovernanceService.ts +1 -8
- package/src/server/services/AutoApprovalCheckpoint.ts +140 -0
- package/src/server/services/CodeValidator.ts +23 -4
- package/src/server/services/DepartmentAttribution.ts +1 -8
- package/src/server/services/ExecutionSpanService.ts +1 -8
- package/src/server/services/GovernanceAdmission.ts +83 -8
- package/src/server/services/HarnessCapabilities.ts +1 -8
- package/src/server/services/HarnessCompiler.ts +12 -0
- package/src/server/services/HarnessSchema.ts +30 -0
- package/src/server/services/HierarchicalAgentRuntime.ts +1052 -0
- package/src/server/services/HierarchyEnrollmentGuard.ts +211 -0
- package/src/server/services/HierarchyInvocationJournal.ts +172 -0
- package/src/server/services/HierarchyRequestCancellation.ts +132 -0
- package/src/server/services/LoopBudgetService.ts +1 -8
- package/src/server/services/LoopRunRepository.ts +2 -9
- package/src/server/services/LoopRunStateMachine.ts +3 -10
- package/src/server/services/LoopTriggerService.ts +1 -8
- package/src/server/services/LoopWorkerService.ts +8 -19
- package/src/server/services/ManagedPromptProtection.ts +1 -8
- package/src/server/services/NativeAgentMonitorSyncService.ts +1 -8
- package/src/server/services/NativeSubAgentObserver.ts +1 -8
- package/src/server/services/NativeUsageAttribution.ts +1 -8
- package/src/server/services/ParallelInterruptActionsPatch.ts +164 -0
- package/src/server/services/PluginAiRuntimeAdapter.ts +140 -9
- package/src/server/services/RoutingBindingRepository.ts +146 -0
- package/src/server/services/RoutingBindingValidation.ts +161 -0
- package/src/server/services/SandboxRunner.ts +35 -1
- package/src/server/services/SessionAutoApproval.ts +167 -0
- package/src/server/services/TokenTracker.ts +1 -8
- package/src/server/services/TracingRetentionPolicy.ts +1 -8
- package/src/server/services/VerificationService.ts +3 -10
- package/src/server/skill-hub/plugin.ts +40 -0
- package/src/server/skill-hub/services/RegistrySkillInstallationService.ts +11 -1
- package/src/server/skill-hub/services/registry-node-package.ts +191 -0
- package/src/server/skill-hub/tasks/SkillExecutionTask.ts +34 -5
- package/src/server/tools/skill-execute.ts +10 -0
- package/src/server/utils/ensure-indexes.ts +2 -8
- package/dist/client/418.6f01da17774a5a25.js +0 -10
- package/dist/client/652.477e21bfff67bc1c.js +0 -10
- package/dist/client-v2/418.55b6b28cda8bb5f3.js +0 -10
- package/dist/client-v2/652.1a48364774d5383a.js +0 -10
- package/dist/client-v2/981.a81521f0296c7db8.js +0 -10
|
@@ -0,0 +1,256 @@
|
|
|
1
|
+
/**
|
|
2
|
+
* This file is part of the NocoBase (R) project.
|
|
3
|
+
* Copyright (c) 2020-2024 NocoBase Co., Ltd.
|
|
4
|
+
* Authors: NocoBase Team.
|
|
5
|
+
*
|
|
6
|
+
* This project is dual-licensed under AGPL-3.0 and NocoBase Commercial License.
|
|
7
|
+
* For more information, please refer to: https://www.nocobase.com/agreement.
|
|
8
|
+
*/
|
|
9
|
+
|
|
10
|
+
import type { Context } from '@nocobase/actions';
|
|
11
|
+
import { describe, expect, it, vi } from 'vitest';
|
|
12
|
+
import {
|
|
13
|
+
routingBindingError,
|
|
14
|
+
routingWouldCycle,
|
|
15
|
+
validateRoutingBindingAction,
|
|
16
|
+
} from '../services/RoutingBindingValidation';
|
|
17
|
+
|
|
18
|
+
const validBinding = {
|
|
19
|
+
leaderUsername: 'orchestrator',
|
|
20
|
+
subAgentUsername: 'specialist',
|
|
21
|
+
routingEnabled: true,
|
|
22
|
+
routingRole: 'specialist',
|
|
23
|
+
llmService: 'fast',
|
|
24
|
+
model: 'lite-model',
|
|
25
|
+
};
|
|
26
|
+
|
|
27
|
+
function createContext(
|
|
28
|
+
options: {
|
|
29
|
+
actionName?: string;
|
|
30
|
+
resourceName?: string;
|
|
31
|
+
values?: Record<string, unknown> | Array<Record<string, unknown>>;
|
|
32
|
+
filterByTk?: unknown;
|
|
33
|
+
stored?: Record<string, unknown> | null;
|
|
34
|
+
affected?: Record<string, unknown> | null;
|
|
35
|
+
rows?: Array<Record<string, unknown>>;
|
|
36
|
+
} = {},
|
|
37
|
+
) {
|
|
38
|
+
const thrown = new Error('ctx.throw');
|
|
39
|
+
const repository = {
|
|
40
|
+
findOne: vi.fn(async (query?: { filterByTk?: unknown; filter?: unknown }) =>
|
|
41
|
+
query?.filterByTk != null ? options.stored ?? validBinding : options.affected ?? null,
|
|
42
|
+
),
|
|
43
|
+
find: vi.fn(async () => options.rows ?? []),
|
|
44
|
+
};
|
|
45
|
+
const getRepository = vi.fn(() => repository);
|
|
46
|
+
const ctx = {
|
|
47
|
+
action: {
|
|
48
|
+
resourceName: options.resourceName ?? 'orchestratorConfig',
|
|
49
|
+
actionName: options.actionName ?? 'create',
|
|
50
|
+
params: {
|
|
51
|
+
values: options.values ?? { ...validBinding },
|
|
52
|
+
filterByTk: options.filterByTk,
|
|
53
|
+
},
|
|
54
|
+
},
|
|
55
|
+
db: {
|
|
56
|
+
getRepository,
|
|
57
|
+
},
|
|
58
|
+
t: (message: string) => message,
|
|
59
|
+
throw: vi.fn((_status: number, _message: string) => {
|
|
60
|
+
throw thrown;
|
|
61
|
+
}),
|
|
62
|
+
};
|
|
63
|
+
return { ctx: ctx as unknown as Context, thrown, repository: getRepository, repositoryActions: repository };
|
|
64
|
+
}
|
|
65
|
+
|
|
66
|
+
describe('routing binding validation', () => {
|
|
67
|
+
it('requires a distinct parent, a supported target role, and a complete optional model pair', () => {
|
|
68
|
+
expect(routingBindingError({ ...validBinding, subAgentUsername: 'orchestrator' })).toContain(
|
|
69
|
+
'cannot delegate to itself',
|
|
70
|
+
);
|
|
71
|
+
expect(routingBindingError({ ...validBinding, routingRole: 'worker-2' })).toContain('routing role');
|
|
72
|
+
expect(routingBindingError({ ...validBinding, llmService: '' })).toContain('both an LLM service and a model');
|
|
73
|
+
expect(routingBindingError({ ...validBinding, routingPrompt: 'x'.repeat(4001) })).toContain('4000');
|
|
74
|
+
});
|
|
75
|
+
|
|
76
|
+
it('keeps legacy and explicitly disabled bindings valid', () => {
|
|
77
|
+
expect(routingBindingError({ leaderUsername: 'legacy', subAgentUsername: 'legacy' })).toBeNull();
|
|
78
|
+
expect(
|
|
79
|
+
routingBindingError({
|
|
80
|
+
...validBinding,
|
|
81
|
+
routingEnabled: false,
|
|
82
|
+
routingRole: undefined,
|
|
83
|
+
llmService: 'service-without-model',
|
|
84
|
+
model: undefined,
|
|
85
|
+
}),
|
|
86
|
+
).toBeNull();
|
|
87
|
+
});
|
|
88
|
+
|
|
89
|
+
it('validates a partial update against the stored binding', async () => {
|
|
90
|
+
const { ctx, repository } = createContext({
|
|
91
|
+
actionName: 'update',
|
|
92
|
+
filterByTk: 12,
|
|
93
|
+
values: { routingEnabled: true },
|
|
94
|
+
stored: { ...validBinding, routingEnabled: false },
|
|
95
|
+
});
|
|
96
|
+
const next = vi.fn(async () => undefined);
|
|
97
|
+
|
|
98
|
+
await validateRoutingBindingAction(ctx, next);
|
|
99
|
+
|
|
100
|
+
expect(repository).toHaveBeenCalledWith('orchestratorConfig');
|
|
101
|
+
expect(next).toHaveBeenCalledOnce();
|
|
102
|
+
});
|
|
103
|
+
|
|
104
|
+
it('rejects a partial model update that leaves an incomplete model pair', async () => {
|
|
105
|
+
const { ctx, thrown } = createContext({
|
|
106
|
+
actionName: 'update',
|
|
107
|
+
filterByTk: 12,
|
|
108
|
+
values: { model: '' },
|
|
109
|
+
stored: validBinding,
|
|
110
|
+
});
|
|
111
|
+
const next = vi.fn(async () => undefined);
|
|
112
|
+
|
|
113
|
+
await expect(validateRoutingBindingAction(ctx, next)).rejects.toBe(thrown);
|
|
114
|
+
|
|
115
|
+
expect(ctx.throw).toHaveBeenCalledWith(400, 'Select both an LLM service and a model, or leave both empty.');
|
|
116
|
+
expect(next).not.toHaveBeenCalled();
|
|
117
|
+
});
|
|
118
|
+
|
|
119
|
+
it('rejects routing updates without a single binding key', async () => {
|
|
120
|
+
const { ctx, thrown } = createContext({ actionName: 'update', values: { routingEnabled: true } });
|
|
121
|
+
|
|
122
|
+
await expect(
|
|
123
|
+
validateRoutingBindingAction(
|
|
124
|
+
ctx,
|
|
125
|
+
vi.fn(async () => undefined),
|
|
126
|
+
),
|
|
127
|
+
).rejects.toBe(thrown);
|
|
128
|
+
expect(ctx.throw).toHaveBeenCalledWith(400, 'Update routing settings for one binding at a time.');
|
|
129
|
+
});
|
|
130
|
+
|
|
131
|
+
it('lets unrelated resources and non-routing batch updates continue', async () => {
|
|
132
|
+
const unrelated = createContext({ resourceName: 'agentGovernancePolicies' });
|
|
133
|
+
const unrelatedNext = vi.fn(async () => undefined);
|
|
134
|
+
await validateRoutingBindingAction(unrelated.ctx, unrelatedNext);
|
|
135
|
+
expect(unrelatedNext).toHaveBeenCalledOnce();
|
|
136
|
+
|
|
137
|
+
const unrelatedPatch = createContext({ actionName: 'update', values: { timeout: 5000 } });
|
|
138
|
+
const patchNext = vi.fn(async () => undefined);
|
|
139
|
+
await validateRoutingBindingAction(unrelatedPatch.ctx, patchNext);
|
|
140
|
+
expect(unrelatedPatch.repository).not.toHaveBeenCalled();
|
|
141
|
+
expect(patchNext).toHaveBeenCalledOnce();
|
|
142
|
+
});
|
|
143
|
+
|
|
144
|
+
it('rejects a non-boolean enabled value', async () => {
|
|
145
|
+
const { ctx, thrown } = createContext({ values: { ...validBinding, routingEnabled: 'true' } });
|
|
146
|
+
|
|
147
|
+
await expect(
|
|
148
|
+
validateRoutingBindingAction(
|
|
149
|
+
ctx,
|
|
150
|
+
vi.fn(async () => undefined),
|
|
151
|
+
),
|
|
152
|
+
).rejects.toBe(thrown);
|
|
153
|
+
expect(ctx.throw).toHaveBeenCalledWith(400, 'Routing enabled must be a boolean.');
|
|
154
|
+
});
|
|
155
|
+
|
|
156
|
+
it('rejects a cycle in the enabled routing graph', async () => {
|
|
157
|
+
const { ctx, thrown } = createContext({
|
|
158
|
+
values: { ...validBinding, leaderUsername: 'specialist', subAgentUsername: 'orchestrator' },
|
|
159
|
+
rows: [
|
|
160
|
+
{ id: 1, leaderUsername: 'orchestrator', subAgentUsername: 'specialist', enabled: true, routingEnabled: true },
|
|
161
|
+
],
|
|
162
|
+
});
|
|
163
|
+
|
|
164
|
+
await expect(
|
|
165
|
+
validateRoutingBindingAction(
|
|
166
|
+
ctx,
|
|
167
|
+
vi.fn(async () => undefined),
|
|
168
|
+
),
|
|
169
|
+
).rejects.toBe(thrown);
|
|
170
|
+
expect(ctx.throw).toHaveBeenCalledWith(400, 'This binding would create a delegation cycle.');
|
|
171
|
+
expect(
|
|
172
|
+
routingWouldCycle({ ...validBinding, leaderUsername: 'specialist', subAgentUsername: 'orchestrator' }, [
|
|
173
|
+
{ leaderUsername: 'orchestrator', subAgentUsername: 'specialist', enabled: true, routingEnabled: true },
|
|
174
|
+
]),
|
|
175
|
+
).toBe(true);
|
|
176
|
+
});
|
|
177
|
+
|
|
178
|
+
it('rejects batch identity changes that could retarget active routing records', async () => {
|
|
179
|
+
const { ctx, thrown, repositoryActions } = createContext({
|
|
180
|
+
actionName: 'update',
|
|
181
|
+
values: { leaderUsername: 'another-orchestrator' },
|
|
182
|
+
affected: { id: 12 },
|
|
183
|
+
});
|
|
184
|
+
|
|
185
|
+
await expect(
|
|
186
|
+
validateRoutingBindingAction(
|
|
187
|
+
ctx,
|
|
188
|
+
vi.fn(async () => undefined),
|
|
189
|
+
),
|
|
190
|
+
).rejects.toBe(thrown);
|
|
191
|
+
expect(repositoryActions.findOne).toHaveBeenCalledWith({
|
|
192
|
+
filter: { $and: [{}, {}, { routingEnabled: true }] },
|
|
193
|
+
});
|
|
194
|
+
expect(ctx.throw).toHaveBeenCalledWith(400, 'Update routing settings for one binding at a time.');
|
|
195
|
+
});
|
|
196
|
+
|
|
197
|
+
it('rejects multi-row changes to routing fields while allowing unrelated batch updates', async () => {
|
|
198
|
+
const { ctx, thrown } = createContext({
|
|
199
|
+
actionName: 'update',
|
|
200
|
+
values: [{ routingEnabled: false }],
|
|
201
|
+
});
|
|
202
|
+
await expect(
|
|
203
|
+
validateRoutingBindingAction(
|
|
204
|
+
ctx,
|
|
205
|
+
vi.fn(async () => undefined),
|
|
206
|
+
),
|
|
207
|
+
).rejects.toBe(thrown);
|
|
208
|
+
expect(ctx.throw).toHaveBeenCalledWith(400, 'Update routing settings for one binding at a time.');
|
|
209
|
+
|
|
210
|
+
const unrelated = createContext({ actionName: 'update', values: [{ timeout: 1000 }] });
|
|
211
|
+
const next = vi.fn(async () => undefined);
|
|
212
|
+
await validateRoutingBindingAction(unrelated.ctx, next);
|
|
213
|
+
expect(next).toHaveBeenCalledOnce();
|
|
214
|
+
});
|
|
215
|
+
|
|
216
|
+
it('rejects mixed managed binding identity batches but allows legacy-only batches', async () => {
|
|
217
|
+
const mixedBatch = createContext({
|
|
218
|
+
actionName: 'update',
|
|
219
|
+
filterByTk: [1, 2],
|
|
220
|
+
values: { leaderUsername: 'renamed-parent' },
|
|
221
|
+
affected: { id: 2, routingEnabled: true },
|
|
222
|
+
});
|
|
223
|
+
const mixedNext = vi.fn(async () => undefined);
|
|
224
|
+
await expect(validateRoutingBindingAction(mixedBatch.ctx, mixedNext)).rejects.toBe(mixedBatch.thrown);
|
|
225
|
+
expect(mixedBatch.ctx.throw).toHaveBeenCalledWith(400, 'Update routing settings for one binding at a time.');
|
|
226
|
+
expect(mixedBatch.repositoryActions.findOne).toHaveBeenCalledWith({
|
|
227
|
+
filter: { $and: [{}, { id: [1, 2] }, { routingEnabled: true }] },
|
|
228
|
+
});
|
|
229
|
+
expect(mixedNext).not.toHaveBeenCalled();
|
|
230
|
+
|
|
231
|
+
const legacyOnlyBatch = createContext({
|
|
232
|
+
actionName: 'update',
|
|
233
|
+
filterByTk: [1, 2],
|
|
234
|
+
values: { leaderUsername: 'renamed-parent' },
|
|
235
|
+
affected: null,
|
|
236
|
+
});
|
|
237
|
+
const legacyNext = vi.fn(async () => undefined);
|
|
238
|
+
await validateRoutingBindingAction(legacyOnlyBatch.ctx, legacyNext);
|
|
239
|
+
expect(legacyNext).toHaveBeenCalledOnce();
|
|
240
|
+
|
|
241
|
+
const routingFieldsBatch = createContext({
|
|
242
|
+
actionName: 'update',
|
|
243
|
+
filterByTk: [1, 2],
|
|
244
|
+
values: { routingRole: 'worker' },
|
|
245
|
+
});
|
|
246
|
+
const routingFieldsNext = vi.fn(async () => undefined);
|
|
247
|
+
await expect(validateRoutingBindingAction(routingFieldsBatch.ctx, routingFieldsNext)).rejects.toBe(
|
|
248
|
+
routingFieldsBatch.thrown,
|
|
249
|
+
);
|
|
250
|
+
expect(routingFieldsBatch.ctx.throw).toHaveBeenCalledWith(
|
|
251
|
+
400,
|
|
252
|
+
'Update routing settings for one binding at a time.',
|
|
253
|
+
);
|
|
254
|
+
expect(routingFieldsNext).not.toHaveBeenCalled();
|
|
255
|
+
});
|
|
256
|
+
});
|
|
@@ -0,0 +1,329 @@
|
|
|
1
|
+
// SPDX-License-Identifier: Apache-2.0
|
|
2
|
+
import { createMockServer, type MockServer } from '@nocobase/test';
|
|
3
|
+
import { randomUUID } from 'node:crypto';
|
|
4
|
+
import { afterAll, beforeAll, describe, expect, it } from 'vitest';
|
|
5
|
+
import { z } from 'zod';
|
|
6
|
+
import { PluginAgentOrchestratorServer } from '../plugin';
|
|
7
|
+
import { getAIToolsManager } from '../utils/ai-manager';
|
|
8
|
+
|
|
9
|
+
describe('session auto-approval resource', () => {
|
|
10
|
+
let app: MockServer;
|
|
11
|
+
let ownerAgent: ReturnType<MockServer['agent']>;
|
|
12
|
+
let otherAgent: ReturnType<MockServer['agent']>;
|
|
13
|
+
let ownerId: number;
|
|
14
|
+
let otherId: number;
|
|
15
|
+
let ownerSessionId: string;
|
|
16
|
+
let secondOwnerSessionId: string;
|
|
17
|
+
let otherSessionId: string;
|
|
18
|
+
|
|
19
|
+
beforeAll(async () => {
|
|
20
|
+
const suffix = `${process.pid}-${Date.now()}`;
|
|
21
|
+
app = await createMockServer({
|
|
22
|
+
plugins: ['nocobase', PluginAgentOrchestratorServer],
|
|
23
|
+
name: `session-auto-approval-${suffix}`,
|
|
24
|
+
acl: true,
|
|
25
|
+
skipSupervisor: true,
|
|
26
|
+
});
|
|
27
|
+
|
|
28
|
+
const toolsManager = getAIToolsManager(app);
|
|
29
|
+
for (const name of [
|
|
30
|
+
'session_auto_approval_form_probe',
|
|
31
|
+
'session_auto_approval_select_probe',
|
|
32
|
+
'session_auto_approval_loop_probe',
|
|
33
|
+
]) {
|
|
34
|
+
toolsManager.registerTools({
|
|
35
|
+
scope: 'CUSTOM',
|
|
36
|
+
execution: 'backend',
|
|
37
|
+
defaultPermission: 'ALLOW',
|
|
38
|
+
definition: {
|
|
39
|
+
name,
|
|
40
|
+
description: 'Persisted tool fixture for auto-approval eligibility.',
|
|
41
|
+
schema: z.object({ value: z.string().optional() }),
|
|
42
|
+
},
|
|
43
|
+
invoke: async (_ctx: unknown, input: { value?: string }) => ({
|
|
44
|
+
status: 'success',
|
|
45
|
+
content: input.value ?? 'ok',
|
|
46
|
+
}),
|
|
47
|
+
});
|
|
48
|
+
}
|
|
49
|
+
|
|
50
|
+
const users = app.db.getRepository('users');
|
|
51
|
+
const owner = await users.findOne({ filter: { 'roles.name': 'root' } });
|
|
52
|
+
if (!owner) throw new Error('Mock server did not seed a root user.');
|
|
53
|
+
const other = await users.create({ values: { username: `auto-approval-other-${suffix}`, roles: ['member'] } });
|
|
54
|
+
ownerId = Number(owner.id);
|
|
55
|
+
otherId = Number(other.id);
|
|
56
|
+
ownerAgent = await app.agent().login(owner);
|
|
57
|
+
otherAgent = await app.agent().login(other);
|
|
58
|
+
|
|
59
|
+
ownerSessionId = randomUUID();
|
|
60
|
+
secondOwnerSessionId = randomUUID();
|
|
61
|
+
otherSessionId = randomUUID();
|
|
62
|
+
const conversations = app.db.getRepository('aiConversations');
|
|
63
|
+
await conversations.create({
|
|
64
|
+
values: { sessionId: ownerSessionId, userId: ownerId, aiEmployeeUsername: 'dex', title: 'Owner session' },
|
|
65
|
+
});
|
|
66
|
+
await conversations.create({
|
|
67
|
+
values: { sessionId: secondOwnerSessionId, userId: ownerId, aiEmployeeUsername: 'dex', title: 'Second session' },
|
|
68
|
+
});
|
|
69
|
+
await conversations.create({
|
|
70
|
+
values: { sessionId: otherSessionId, userId: otherId, aiEmployeeUsername: 'dex', title: 'Other owner session' },
|
|
71
|
+
});
|
|
72
|
+
});
|
|
73
|
+
|
|
74
|
+
afterAll(async () => {
|
|
75
|
+
await app?.destroy();
|
|
76
|
+
});
|
|
77
|
+
|
|
78
|
+
it('persists explicit enable and disable per owned root session and defaults a new session to off', async () => {
|
|
79
|
+
const get = (sessionId: string) => ownerAgent.resource('agentAutoApproval').get({ values: { sessionId } });
|
|
80
|
+
const set = (sessionId: string, enabled: boolean) =>
|
|
81
|
+
ownerAgent.resource('agentAutoApproval').set({ values: { sessionId, enabled } });
|
|
82
|
+
|
|
83
|
+
expect((await get(ownerSessionId)).body.data.enabled).toBe(false);
|
|
84
|
+
expect((await set(ownerSessionId, true)).status).toBe(200);
|
|
85
|
+
expect((await get(ownerSessionId)).body.data.enabled).toBe(true);
|
|
86
|
+
expect((await get(secondOwnerSessionId)).body.data.enabled).toBe(false);
|
|
87
|
+
|
|
88
|
+
expect((await set(ownerSessionId, false)).status).toBe(200);
|
|
89
|
+
expect((await get(ownerSessionId)).body.data.enabled).toBe(false);
|
|
90
|
+
|
|
91
|
+
const settingRows = await app.db.getRepository('agentSessionAutoApprovals').find({
|
|
92
|
+
filter: { ownerId, sessionId: ownerSessionId },
|
|
93
|
+
});
|
|
94
|
+
expect(settingRows).toHaveLength(1);
|
|
95
|
+
expect(settingRows[0].get('enabled')).toBe(false);
|
|
96
|
+
});
|
|
97
|
+
|
|
98
|
+
it('scopes settings by owner and refuses missing, malformed, or child conversations', async () => {
|
|
99
|
+
const memberSet = await otherAgent.resource('agentAutoApproval').set({
|
|
100
|
+
values: { sessionId: otherSessionId, enabled: true },
|
|
101
|
+
});
|
|
102
|
+
expect(memberSet.status).toBe(200);
|
|
103
|
+
expect(
|
|
104
|
+
(await otherAgent.resource('agentAutoApproval').get({ values: { sessionId: otherSessionId } })).body.data.enabled,
|
|
105
|
+
).toBe(true);
|
|
106
|
+
expect((await ownerAgent.resource('agentAutoApproval').get({ values: { sessionId: otherSessionId } })).status).toBe(
|
|
107
|
+
404,
|
|
108
|
+
);
|
|
109
|
+
expect(
|
|
110
|
+
(
|
|
111
|
+
await ownerAgent.resource('agentAutoApproval').set({
|
|
112
|
+
values: { sessionId: ownerSessionId, enabled: 'true' },
|
|
113
|
+
})
|
|
114
|
+
).status,
|
|
115
|
+
).toBe(400);
|
|
116
|
+
expect((await ownerAgent.resource('agentAutoApproval').get({ values: { sessionId: randomUUID() } })).status).toBe(
|
|
117
|
+
404,
|
|
118
|
+
);
|
|
119
|
+
|
|
120
|
+
const childSessionId = randomUUID();
|
|
121
|
+
await app.db.getRepository('aiConversations').create({
|
|
122
|
+
values: {
|
|
123
|
+
sessionId: childSessionId,
|
|
124
|
+
userId: ownerId,
|
|
125
|
+
aiEmployeeUsername: 'dex',
|
|
126
|
+
from: 'sub-agent',
|
|
127
|
+
title: 'Child session',
|
|
128
|
+
},
|
|
129
|
+
});
|
|
130
|
+
expect(
|
|
131
|
+
(await ownerAgent.resource('agentAutoApproval').set({ values: { sessionId: childSessionId, enabled: true } }))
|
|
132
|
+
.status,
|
|
133
|
+
).toBe(404);
|
|
134
|
+
expect(
|
|
135
|
+
await app.db.getRepository('agentSessionAutoApprovals').count({ filter: { ownerId, sessionId: childSessionId } }),
|
|
136
|
+
).toBe(0);
|
|
137
|
+
});
|
|
138
|
+
|
|
139
|
+
it('checks eligibility against persisted root interrupts, frontend ASK manifests, and interactive Skill Hub schemas', async () => {
|
|
140
|
+
const username = 'dex';
|
|
141
|
+
const sessionId = randomUUID();
|
|
142
|
+
const conversations = app.db.getRepository('aiConversations');
|
|
143
|
+
await conversations.create({
|
|
144
|
+
values: { sessionId, userId: ownerId, aiEmployeeUsername: username, title: 'Eligibility fixtures' },
|
|
145
|
+
});
|
|
146
|
+
|
|
147
|
+
const approvals = app.db.getRepository('agentSessionAutoApprovals');
|
|
148
|
+
await approvals.create({ values: { ownerId, sessionId, enabled: true } });
|
|
149
|
+
|
|
150
|
+
let nextId = Date.now() * 1000;
|
|
151
|
+
const persistInterrupt = async (
|
|
152
|
+
targetSessionId: string,
|
|
153
|
+
toolName: string,
|
|
154
|
+
args: Record<string, unknown>,
|
|
155
|
+
from: 'main-agent' | 'sub-agent' = 'main-agent',
|
|
156
|
+
) => {
|
|
157
|
+
const messageId = ++nextId;
|
|
158
|
+
const toolMessageId = ++nextId;
|
|
159
|
+
const toolCallId = `auto-approval-${randomUUID()}`;
|
|
160
|
+
const interruptId = `interrupt-${randomUUID()}`;
|
|
161
|
+
await app.db.getRepository('aiConversations.messages', targetSessionId).create({
|
|
162
|
+
values: {
|
|
163
|
+
messageId,
|
|
164
|
+
role: username,
|
|
165
|
+
content: { type: 'text', content: 'Persisted ASK fixture.' },
|
|
166
|
+
toolCalls: [{ id: toolCallId, name: toolName, args }],
|
|
167
|
+
metadata: { interruptId },
|
|
168
|
+
},
|
|
169
|
+
});
|
|
170
|
+
await app.db.getRepository('aiToolMessages').create({
|
|
171
|
+
values: {
|
|
172
|
+
id: toolMessageId,
|
|
173
|
+
sessionId: targetSessionId,
|
|
174
|
+
messageId,
|
|
175
|
+
toolCallId,
|
|
176
|
+
toolName,
|
|
177
|
+
status: null,
|
|
178
|
+
content: null,
|
|
179
|
+
invokeStatus: 'interrupted',
|
|
180
|
+
auto: false,
|
|
181
|
+
execution: toolName === 'executeFrontendTool' ? 'frontend' : 'backend',
|
|
182
|
+
interruptActionOrder: 0,
|
|
183
|
+
interruptAction: {
|
|
184
|
+
order: 0,
|
|
185
|
+
toolCall: { id: toolCallId, name: toolName },
|
|
186
|
+
allowedDecisions: ['approve', 'reject', 'edit'],
|
|
187
|
+
currentConversation: { sessionId: targetSessionId, username, from },
|
|
188
|
+
},
|
|
189
|
+
},
|
|
190
|
+
});
|
|
191
|
+
return { sessionId: targetSessionId, messageId: String(messageId), toolCallId };
|
|
192
|
+
};
|
|
193
|
+
const eligible = (identity: { sessionId: string; messageId: string; toolCallId: string }) =>
|
|
194
|
+
ownerAgent.resource('agentAutoApproval').eligible({ values: identity });
|
|
195
|
+
|
|
196
|
+
const probeCall = await persistInterrupt(sessionId, 'session_auto_approval_form_probe', { value: 'root' });
|
|
197
|
+
expect((await eligible(probeCall)).body.data.eligible).toBe(true);
|
|
198
|
+
expect((await eligible({ ...probeCall, toolCallId: 'different-tool-call' })).body.data.eligible).toBe(false);
|
|
199
|
+
|
|
200
|
+
const frontendManifest = {
|
|
201
|
+
id: 'report-block:refresh_report',
|
|
202
|
+
blockUid: 'report-block',
|
|
203
|
+
name: 'refresh_report',
|
|
204
|
+
title: 'Refresh report',
|
|
205
|
+
description: 'Refresh the report block.',
|
|
206
|
+
permission: 'ASK',
|
|
207
|
+
inputSchema: { type: 'object', properties: { force: { type: 'boolean' } } },
|
|
208
|
+
};
|
|
209
|
+
await conversations.update({
|
|
210
|
+
filter: { sessionId },
|
|
211
|
+
values: { options: { frontendTools: [frontendManifest] } },
|
|
212
|
+
});
|
|
213
|
+
const frontendCall = await persistInterrupt(sessionId, 'executeFrontendTool', {
|
|
214
|
+
toolId: frontendManifest.id,
|
|
215
|
+
args: { force: true },
|
|
216
|
+
});
|
|
217
|
+
expect((await eligible(frontendCall)).body.data.eligible).toBe(true);
|
|
218
|
+
|
|
219
|
+
await conversations.update({
|
|
220
|
+
filter: { sessionId },
|
|
221
|
+
values: {
|
|
222
|
+
options: {
|
|
223
|
+
frontendTools: [{ ...frontendManifest, permission: 'ALLOW' }],
|
|
224
|
+
},
|
|
225
|
+
},
|
|
226
|
+
});
|
|
227
|
+
expect((await eligible(frontendCall)).body.data.eligible).toBe(false);
|
|
228
|
+
await conversations.update({
|
|
229
|
+
filter: { sessionId },
|
|
230
|
+
values: { options: { frontendTools: [{ ...frontendManifest, id: 'report-block:other_tool' }] } },
|
|
231
|
+
});
|
|
232
|
+
expect((await eligible(frontendCall)).body.data.eligible).toBe(false);
|
|
233
|
+
|
|
234
|
+
const skillDefinitions = app.db.getRepository('skillDefinitions');
|
|
235
|
+
const formSkill = await skillDefinitions.create({
|
|
236
|
+
values: {
|
|
237
|
+
name: `auto-approval-form-${Date.now()}`,
|
|
238
|
+
toolName: 'session_auto_approval_form_probe',
|
|
239
|
+
title: 'Form input fixture',
|
|
240
|
+
description: 'Requires user form input.',
|
|
241
|
+
instructions: 'Do not invent the form fields.',
|
|
242
|
+
language: 'node',
|
|
243
|
+
codeTemplate: '',
|
|
244
|
+
inputSchema: '{}',
|
|
245
|
+
interactionSchema: JSON.stringify({
|
|
246
|
+
type: 'form',
|
|
247
|
+
prompt: 'Complete the form.',
|
|
248
|
+
fields: { value: { type: 'text', title: 'Value', required: true } },
|
|
249
|
+
}),
|
|
250
|
+
enabled: true,
|
|
251
|
+
toolScope: 'CUSTOM',
|
|
252
|
+
autoCall: false,
|
|
253
|
+
storageType: 'database',
|
|
254
|
+
},
|
|
255
|
+
});
|
|
256
|
+
const selectSkill = await skillDefinitions.create({
|
|
257
|
+
values: {
|
|
258
|
+
name: `auto-approval-select-${Date.now()}`,
|
|
259
|
+
toolName: 'session_auto_approval_select_probe',
|
|
260
|
+
title: 'Select input fixture',
|
|
261
|
+
description: 'Requires user selection.',
|
|
262
|
+
instructions: 'Wait for the user to choose an option.',
|
|
263
|
+
language: 'node',
|
|
264
|
+
codeTemplate: '',
|
|
265
|
+
inputSchema: '{}',
|
|
266
|
+
interactionSchema: JSON.stringify({
|
|
267
|
+
type: 'select',
|
|
268
|
+
prompt: 'Choose an option.',
|
|
269
|
+
options: [{ label: 'One', value: 'one' }],
|
|
270
|
+
}),
|
|
271
|
+
enabled: true,
|
|
272
|
+
toolScope: 'CUSTOM',
|
|
273
|
+
autoCall: false,
|
|
274
|
+
storageType: 'database',
|
|
275
|
+
},
|
|
276
|
+
});
|
|
277
|
+
const loopSkill = await skillDefinitions.create({
|
|
278
|
+
values: {
|
|
279
|
+
name: `auto-approval-loop-${Date.now()}`,
|
|
280
|
+
toolName: 'session_auto_approval_loop_probe',
|
|
281
|
+
title: 'Skill loop fixture',
|
|
282
|
+
description: 'Requires user confirmation through a loop config.',
|
|
283
|
+
instructions: 'Do not bypass the configured interaction.',
|
|
284
|
+
language: 'node',
|
|
285
|
+
codeTemplate: '',
|
|
286
|
+
inputSchema: '{}',
|
|
287
|
+
interactionSchema: null,
|
|
288
|
+
enabled: true,
|
|
289
|
+
toolScope: 'CUSTOM',
|
|
290
|
+
autoCall: false,
|
|
291
|
+
storageType: 'database',
|
|
292
|
+
},
|
|
293
|
+
});
|
|
294
|
+
await app.db.getRepository('skillLoopConfigs').create({
|
|
295
|
+
values: {
|
|
296
|
+
skillId: loopSkill.id,
|
|
297
|
+
enabled: true,
|
|
298
|
+
title: 'Review before execution',
|
|
299
|
+
templateKey: 'confirm',
|
|
300
|
+
schema: JSON.stringify({ type: 'confirm', prompt: 'Review this operation.' }),
|
|
301
|
+
},
|
|
302
|
+
});
|
|
303
|
+
|
|
304
|
+
const formCall = await persistInterrupt(sessionId, 'session_auto_approval_form_probe', { value: 'fabricated' });
|
|
305
|
+
const selectCall = await persistInterrupt(sessionId, 'session_auto_approval_select_probe', { value: 'fabricated' });
|
|
306
|
+
const loopCall = await persistInterrupt(sessionId, 'session_auto_approval_loop_probe', { value: 'fabricated' });
|
|
307
|
+
const suggestionCall = await persistInterrupt(sessionId, 'suggestions', { value: 'fabricated' });
|
|
308
|
+
const workflowOutputCall = await persistInterrupt(sessionId, 'aiEmployeeWorkflowTaskOutput', {
|
|
309
|
+
value: 'fabricated',
|
|
310
|
+
});
|
|
311
|
+
for (const identity of [formCall, selectCall, loopCall, suggestionCall, workflowOutputCall]) {
|
|
312
|
+
expect((await eligible(identity)).body.data.eligible).toBe(false);
|
|
313
|
+
}
|
|
314
|
+
|
|
315
|
+
const childSessionId = randomUUID();
|
|
316
|
+
await conversations.create({
|
|
317
|
+
values: {
|
|
318
|
+
sessionId: childSessionId,
|
|
319
|
+
userId: ownerId,
|
|
320
|
+
aiEmployeeUsername: username,
|
|
321
|
+
from: 'sub-agent',
|
|
322
|
+
title: 'Child eligibility fixture',
|
|
323
|
+
},
|
|
324
|
+
});
|
|
325
|
+
await approvals.create({ values: { ownerId, sessionId: childSessionId, enabled: true } });
|
|
326
|
+
const childCall = await persistInterrupt(childSessionId, 'session_auto_approval_form_probe', { value: 'child' });
|
|
327
|
+
expect((await eligible(childCall)).status).toBe(404);
|
|
328
|
+
});
|
|
329
|
+
});
|
|
@@ -1,3 +1,12 @@
|
|
|
1
|
+
/**
|
|
2
|
+
* This file is part of the NocoBase (R) project.
|
|
3
|
+
* Copyright (c) 2020-2024 NocoBase Co., Ltd.
|
|
4
|
+
* Authors: NocoBase Team.
|
|
5
|
+
*
|
|
6
|
+
* This project is dual-licensed under AGPL-3.0 and NocoBase Commercial License.
|
|
7
|
+
* For more information, please refer to: https://www.nocobase.com/agreement.
|
|
8
|
+
*/
|
|
9
|
+
|
|
1
10
|
import { describe, expect, it, vi } from 'vitest';
|
|
2
11
|
import { createSkillExecuteTool } from '../tools/skill-execute';
|
|
3
12
|
|
|
@@ -20,6 +29,7 @@ describe('createSkillExecuteTool', () => {
|
|
|
20
29
|
findOne: vi.fn(async () => skill),
|
|
21
30
|
})),
|
|
22
31
|
},
|
|
32
|
+
assertSkillReviewApproved: vi.fn().mockResolvedValue(undefined),
|
|
23
33
|
executeSkill,
|
|
24
34
|
};
|
|
25
35
|
|
|
@@ -27,6 +37,7 @@ describe('createSkillExecuteTool', () => {
|
|
|
27
37
|
const result = await tool.invoke(ctx, { action: 'execute', skillName: 'demo', input: { ok: true } }, runtime);
|
|
28
38
|
|
|
29
39
|
expect(result.status).toBe('success');
|
|
40
|
+
expect(plugin.assertSkillReviewApproved).toHaveBeenCalledWith(skill, runtime, 'skill_hub_execute', ctx);
|
|
30
41
|
expect(executeSkill).toHaveBeenCalledOnce();
|
|
31
42
|
expect(ctx.runtime).toBeUndefined();
|
|
32
43
|
});
|