plugin-agent-orchestrator 1.1.8 → 1.2.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (413) hide show
  1. package/README.md +207 -204
  2. package/client-v2.d.ts +2 -2
  3. package/client-v2.js +1 -1
  4. package/client.d.ts +2 -2
  5. package/client.js +1 -1
  6. package/dist/client/117.2e4cb0477da3db1f.js +10 -0
  7. package/dist/client/253.93deb9e0192e76a5.js +10 -0
  8. package/dist/client/325.8f7f509bdb35e142.js +10 -0
  9. package/dist/client/404.498d2d9516dd1dce.js +10 -0
  10. package/dist/client/418.6f01da17774a5a25.js +10 -0
  11. package/dist/client/53.774ff07505d521fa.js +10 -0
  12. package/dist/client/619.e342b0fa467d39ca.js +10 -0
  13. package/dist/client/627.fdd60bcc0f3a9cf6.js +10 -0
  14. package/dist/client/652.477e21bfff67bc1c.js +10 -0
  15. package/dist/client/981.e0546ffc34afedcd.js +10 -0
  16. package/dist/client/993.5d04b510835ab0d2.js +10 -0
  17. package/dist/client/index.js +1 -1
  18. package/dist/client-v2/117.ccf43ae8631f7d74.js +10 -0
  19. package/dist/client-v2/214.cdf76752053a8990.js +10 -0
  20. package/dist/client-v2/253.1198df22f5baf304.js +10 -0
  21. package/dist/client-v2/264.78887ff88f969467.js +10 -0
  22. package/dist/client-v2/325.fafe5a6e83ba9cb3.js +10 -0
  23. package/dist/client-v2/404.9ba964c28a151c81.js +10 -0
  24. package/dist/client-v2/{41.3deb9e57a0f64fc4.js → 41.b28cf7a675a603d1.js} +1 -1
  25. package/dist/client-v2/418.55b6b28cda8bb5f3.js +10 -0
  26. package/dist/client-v2/{53.349fff8db80b19d4.js → 53.282081f97e4308c6.js} +1 -1
  27. package/dist/client-v2/{619.0a2144aaffefe018.js → 619.8c03913873785fb6.js} +1 -1
  28. package/dist/client-v2/627.e16f4a0dd596c3e6.js +10 -0
  29. package/dist/client-v2/652.1a48364774d5383a.js +10 -0
  30. package/dist/client-v2/{70.ffff2997c10fd4b0.js → 70.9166ed70906d041f.js} +1 -1
  31. package/dist/client-v2/{981.e4a1f41cfc94a856.js → 981.a81521f0296c7db8.js} +1 -1
  32. package/dist/client-v2/993.ca5b28f1e2b4c1ef.js +10 -0
  33. package/dist/client-v2/index.js +1 -1
  34. package/dist/externalVersion.js +10 -7
  35. package/dist/locale/en-US.json +229 -1
  36. package/dist/locale/zh-CN.json +229 -1
  37. package/dist/node_modules/adm-zip/adm-zip.js +1 -1
  38. package/dist/node_modules/adm-zip/package.json +1 -1
  39. package/dist/node_modules/ajv/package.json +1 -1
  40. package/dist/node_modules/zod/index.cjs +1 -1
  41. package/dist/node_modules/zod/package.json +1 -1
  42. package/dist/server/collections/agent-execution-spans.js +145 -6
  43. package/dist/server/collections/agent-governance-audit-events.js +47 -0
  44. package/dist/server/collections/agent-governance-policies.js +47 -0
  45. package/dist/server/collections/agent-governance-policy-versions.js +48 -0
  46. package/dist/server/collections/agent-governance-prompt-bindings.js +50 -0
  47. package/dist/server/collections/agent-loop-runs.js +23 -5
  48. package/dist/server/migrations/20261110000000-add-usage-pricing-snapshots.js +117 -0
  49. package/dist/server/migrations/20261110010000-add-usage-department-attribution.js +54 -0
  50. package/dist/server/plugin.js +114 -33
  51. package/dist/server/resources/agent-governance.js +192 -0
  52. package/dist/server/resources/agent-harness-profile.js +11 -3
  53. package/dist/server/resources/agent-monitor.js +109 -339
  54. package/dist/server/resources/agent-usage.js +423 -0
  55. package/dist/server/resources/native-monitor-format.js +179 -0
  56. package/dist/server/resources/tracing.js +35 -12
  57. package/dist/server/services/AgentGovernanceService.js +500 -0
  58. package/dist/server/services/DepartmentAttribution.js +65 -0
  59. package/dist/server/services/ExecutionSpanService.js +96 -3
  60. package/dist/server/services/GovernanceAdmission.js +211 -0
  61. package/dist/server/services/HarnessCapabilities.js +118 -0
  62. package/dist/server/services/LoopBudgetService.js +29 -11
  63. package/dist/server/services/LoopRunRepository.js +15 -6
  64. package/dist/server/services/LoopRunStateMachine.js +18 -7
  65. package/dist/server/services/LoopTriggerService.js +1 -1
  66. package/dist/server/services/LoopWorkerService.js +66 -32
  67. package/dist/server/services/ManagedPromptProtection.js +99 -0
  68. package/dist/server/services/NativeAgentMonitorSyncService.js +584 -0
  69. package/dist/server/services/NativeSubAgentObserver.js +141 -508
  70. package/dist/server/services/NativeUsageAttribution.js +97 -0
  71. package/dist/server/services/TokenTracker.js +787 -104
  72. package/dist/server/services/TracingRetentionPolicy.js +66 -0
  73. package/dist/server/services/VerificationService.js +18 -8
  74. package/dist/server/skill-hub/sandbox-config.json +6 -6
  75. package/dist/server/utils/ensure-indexes.js +14 -5
  76. package/package.json +63 -53
  77. package/server.d.ts +2 -2
  78. package/server.js +1 -1
  79. package/src/client/AgentRunsTab.tsx +2 -2
  80. package/src/client/ApprovalsTab.tsx +2 -2
  81. package/src/client/HarnessProfilesTab.tsx +2 -2
  82. package/src/client/OrchestratorSettings.tsx +152 -152
  83. package/src/client/SkillPages.tsx +41 -0
  84. package/src/client/__tests__/embedded-settings.test.tsx +232 -0
  85. package/src/client/hooks/useRunEventStream.ts +76 -76
  86. package/src/client/index.tsx +2 -2
  87. package/src/client/plugin.tsx +76 -33
  88. package/src/client/skill-hub/components/ExecutionHistory.tsx +200 -200
  89. package/src/client/skill-hub/components/GitSkillImport.tsx +562 -562
  90. package/src/client/skill-hub/components/LoopSettings.tsx +331 -331
  91. package/src/client/skill-hub/components/SkillEditor.tsx +460 -460
  92. package/src/client/skill-hub/components/SkillManager.tsx +194 -194
  93. package/src/client/skill-hub/components/SkillMetrics.tsx +162 -162
  94. package/src/client/skill-hub/components/SkillTestPanel.tsx +141 -141
  95. package/src/client/skill-hub/index.tsx +6 -6
  96. package/src/client/skill-hub/locale.ts +16 -16
  97. package/src/client/skill-hub/tools/InteractionSchemasProvider.tsx +132 -132
  98. package/src/client/skill-hub/tools/SkillHubCard.tsx +104 -104
  99. package/src/client/skill-hub/tools/loopTemplates.ts +52 -52
  100. package/src/client/skill-hub/tools/registerSkillLoopCards.ts +71 -71
  101. package/src/client/skill-hub/utils/jsonFields.ts +41 -41
  102. package/src/client-v2/__tests__/embedded-settings.test.tsx +193 -0
  103. package/src/client-v2/components/AIEmployeeSelect.tsx +47 -47
  104. package/src/client-v2/components/AIEmployeesContext.tsx +97 -97
  105. package/src/client-v2/components/AgentBindingsTab.tsx +269 -269
  106. package/src/client-v2/components/AgentRunsTab.tsx +92 -83
  107. package/src/client-v2/components/ApprovalsTab.tsx +337 -337
  108. package/src/client-v2/components/EmployeeGovernanceTab.tsx +702 -0
  109. package/src/client-v2/components/HarnessProfilesTab.tsx +704 -541
  110. package/src/client-v2/components/KnowledgeAccessTab.tsx +116 -116
  111. package/src/client-v2/components/RetrievalTraceTab.tsx +162 -162
  112. package/src/client-v2/components/UsageGovernanceTab.tsx +386 -0
  113. package/src/client-v2/index.tsx +1 -1
  114. package/src/client-v2/pages/AgentBindingsPage.tsx +22 -13
  115. package/src/client-v2/pages/ApprovalsPage.tsx +19 -10
  116. package/src/client-v2/pages/EmployeeGovernancePage.tsx +22 -0
  117. package/src/client-v2/pages/ExecutionHistoryPage.tsx +19 -10
  118. package/src/client-v2/pages/HarnessProfilesPage.tsx +19 -10
  119. package/src/client-v2/pages/KnowledgeAccessPage.tsx +19 -10
  120. package/src/client-v2/pages/LoopSettingsPage.tsx +19 -10
  121. package/src/client-v2/pages/MemoryInspectorPage.tsx +22 -13
  122. package/src/client-v2/pages/RetrievalTracePage.tsx +19 -10
  123. package/src/client-v2/pages/RulesPage.tsx +22 -13
  124. package/src/client-v2/pages/SkillDefinitionsPage.tsx +19 -10
  125. package/src/client-v2/pages/SkillMetricsPage.tsx +19 -10
  126. package/src/client-v2/pages/TracingPage.tsx +22 -13
  127. package/src/client-v2/pages/UsageGovernancePage.tsx +22 -0
  128. package/src/client-v2/plugin.tsx +139 -111
  129. package/src/client-v2/skill-hub/components/ExecutionHistory.tsx +196 -196
  130. package/src/client-v2/skill-hub/components/FileLinkList.tsx +37 -37
  131. package/src/client-v2/skill-hub/components/GitSkillImport.tsx +539 -539
  132. package/src/client-v2/skill-hub/components/LoopSettings.tsx +331 -331
  133. package/src/client-v2/skill-hub/components/SkillEditor.tsx +453 -453
  134. package/src/client-v2/skill-hub/components/SkillManager.tsx +191 -174
  135. package/src/client-v2/skill-hub/components/SkillMetrics.tsx +162 -162
  136. package/src/client-v2/skill-hub/components/SkillTestPanel.tsx +135 -135
  137. package/src/client-v2/skill-hub/locale.ts +13 -13
  138. package/src/client-v2/skill-hub/tools/InteractionSchemasProvider.tsx +62 -0
  139. package/src/client-v2/skill-hub/tools/SkillHubCard.tsx +104 -0
  140. package/src/client-v2/skill-hub/tools/__tests__/interactions.test.ts +110 -0
  141. package/src/client-v2/skill-hub/tools/interactions.ts +128 -0
  142. package/src/client-v2/skill-hub/tools/loopTemplates.ts +52 -52
  143. package/src/client-v2/skill-hub/utils/jsonFields.ts +41 -41
  144. package/src/client-v2/utils/jsonFields.ts +41 -41
  145. package/src/index.ts +2 -2
  146. package/src/locale/en-US.json +229 -1
  147. package/src/locale/zh-CN.json +229 -1
  148. package/src/server/__tests__/agent-execution-context.test.ts +18 -18
  149. package/src/server/__tests__/agent-governance.integration.test.ts +392 -0
  150. package/src/server/__tests__/agent-knowledge-insights.test.ts +123 -123
  151. package/src/server/__tests__/agent-monitor-acl.integration.test.ts +274 -0
  152. package/src/server/__tests__/agent-registry-service.test.ts +147 -147
  153. package/src/server/__tests__/agent-runtime-lifecycle.test.ts +46 -46
  154. package/src/server/__tests__/agent-usage-report.integration.test.ts +342 -0
  155. package/src/server/__tests__/code-validator.test.ts +63 -63
  156. package/src/server/__tests__/external-rag-search.test.ts +107 -107
  157. package/src/server/__tests__/harness-capabilities.test.ts +95 -0
  158. package/src/server/__tests__/harness-compiler.test.ts +214 -214
  159. package/src/server/__tests__/harness-profile-service.test.ts +167 -167
  160. package/src/server/__tests__/harness-runtime-policy.test.ts +293 -293
  161. package/src/server/__tests__/harness-tool-plan.test.ts +182 -172
  162. package/src/server/__tests__/input-schema-validator.test.ts +26 -26
  163. package/src/server/__tests__/loop-approval-decision.test.ts +577 -512
  164. package/src/server/__tests__/loop-approval-expiry.test.ts +258 -258
  165. package/src/server/__tests__/loop-budget-service.test.ts +36 -0
  166. package/src/server/__tests__/loop-pattern-schema.test.ts +73 -73
  167. package/src/server/__tests__/loop-run-repository.test.ts +32 -0
  168. package/src/server/__tests__/loop-run-state-machine.test.ts +101 -101
  169. package/src/server/__tests__/loop-trigger-service.test.ts +192 -148
  170. package/src/server/__tests__/loop-worker-claim.test.ts +72 -9
  171. package/src/server/__tests__/loop-worker-execution.test.ts +382 -317
  172. package/src/server/__tests__/native-agent-monitor-sync.test.ts +350 -0
  173. package/src/server/__tests__/native-sub-agent-observer.test.ts +470 -662
  174. package/src/server/__tests__/native-usage-attribution.integration.test.ts +175 -0
  175. package/src/server/__tests__/skill-access-service.test.ts +64 -64
  176. package/src/server/__tests__/skill-execute.test.ts +70 -70
  177. package/src/server/__tests__/skill-execution-task-policy.test.ts +140 -140
  178. package/src/server/__tests__/skill-sandbox-worker-mode.test.ts +15 -15
  179. package/src/server/__tests__/skill-settings.test.ts +63 -63
  180. package/src/server/__tests__/skill-tool-name.test.ts +23 -23
  181. package/src/server/__tests__/token-tracker.test.ts +639 -0
  182. package/src/server/__tests__/tool-loop-detection.test.ts +276 -276
  183. package/src/server/__tests__/tracing-retention-policy.test.ts +37 -0
  184. package/src/server/__tests__/usage-ledger.integration.test.ts +194 -0
  185. package/src/server/collections/agent-execution-spans.ts +393 -245
  186. package/src/server/collections/agent-governance-audit-events.ts +26 -0
  187. package/src/server/collections/agent-governance-policies.ts +26 -0
  188. package/src/server/collections/agent-governance-policy-versions.ts +27 -0
  189. package/src/server/collections/agent-governance-prompt-bindings.ts +29 -0
  190. package/src/server/collections/agent-loop-action-approvals.ts +39 -39
  191. package/src/server/collections/agent-loop-runs.ts +396 -369
  192. package/src/server/collections/agent-loop-steps.ts +220 -220
  193. package/src/server/collections/agent-memory-contexts.ts +95 -95
  194. package/src/server/collections/orchestrator-config.ts +87 -87
  195. package/src/server/collections/orchestrator-logs.ts +116 -116
  196. package/src/server/collections/skill-definitions.ts +159 -159
  197. package/src/server/collections/skill-executions.ts +154 -154
  198. package/src/server/collections/skill-loop-configs.ts +65 -65
  199. package/src/server/collections/skill-metrics.ts +36 -36
  200. package/src/server/collections/skill-registry-installations.ts +41 -41
  201. package/src/server/collections/skill-worker-configs.ts +86 -86
  202. package/src/server/index.ts +1 -1
  203. package/src/server/migrations/20260423000000-add-progress-fields.ts +50 -50
  204. package/src/server/migrations/20260425000000-add-interaction-schema.ts +37 -37
  205. package/src/server/migrations/20260427000000-add-tracing-detail-fields.ts +41 -41
  206. package/src/server/migrations/20260427000001-change-other-json-to-text.ts +61 -61
  207. package/src/server/migrations/20260524001000-add-plan-approval-and-harness-profiles.ts +145 -145
  208. package/src/server/migrations/20260601000000-add-token-fields.ts +89 -89
  209. package/src/server/migrations/20260615000000-normalize-ai-employee-tool-bindings.ts +39 -39
  210. package/src/server/migrations/20260621000000-native-policy-profile-defaults.ts +190 -190
  211. package/src/server/migrations/20260727000000-remove-unused-knowledge-scopes.ts +25 -25
  212. package/src/server/migrations/20260727010000-backfill-skill-tool-names.ts +45 -45
  213. package/src/server/migrations/20261110000000-add-usage-pricing-snapshots.ts +117 -0
  214. package/src/server/migrations/20261110010000-add-usage-department-attribution.ts +35 -0
  215. package/src/server/plugin.ts +674 -573
  216. package/src/server/resources/agent-governance.ts +168 -0
  217. package/src/server/resources/agent-harness-profile.ts +110 -94
  218. package/src/server/resources/agent-knowledge-insights.ts +306 -306
  219. package/src/server/resources/agent-loop-approval.ts +84 -84
  220. package/src/server/resources/agent-loop-events-stream.ts +108 -108
  221. package/src/server/resources/agent-loop.ts +252 -252
  222. package/src/server/resources/agent-monitor.ts +215 -482
  223. package/src/server/resources/agent-usage.ts +420 -0
  224. package/src/server/resources/native-monitor-format.ts +157 -0
  225. package/src/server/resources/tracing.ts +303 -267
  226. package/src/server/services/AgentExecutionContext.ts +23 -23
  227. package/src/server/services/AgentGovernanceService.ts +548 -0
  228. package/src/server/services/AgentMemoryContextService.ts +344 -344
  229. package/src/server/services/AgentRegistryService.ts +220 -220
  230. package/src/server/services/AgentRuntimeLifecycle.ts +64 -64
  231. package/src/server/services/CodeValidator.ts +238 -238
  232. package/src/server/services/DepartmentAttribution.ts +54 -0
  233. package/src/server/services/DurableCircuitBreakerService.ts +235 -235
  234. package/src/server/services/ExecutionSpanService.ts +278 -146
  235. package/src/server/services/FileManager.ts +159 -159
  236. package/src/server/services/GovernanceAdmission.ts +239 -0
  237. package/src/server/services/HarnessCapabilities.ts +119 -0
  238. package/src/server/services/HarnessCompiler.ts +170 -170
  239. package/src/server/services/HarnessProfileService.ts +235 -235
  240. package/src/server/services/HarnessSchema.ts +194 -194
  241. package/src/server/services/InputSchemaValidator.ts +44 -44
  242. package/src/server/services/LoopBudgetService.ts +332 -271
  243. package/src/server/services/LoopControlService.ts +120 -120
  244. package/src/server/services/LoopPatternSchema.ts +231 -231
  245. package/src/server/services/LoopPatternService.ts +171 -171
  246. package/src/server/services/LoopRunRepository.ts +350 -332
  247. package/src/server/services/LoopRunStateMachine.ts +545 -525
  248. package/src/server/services/LoopSchedulerService.ts +195 -195
  249. package/src/server/services/LoopTriggerService.ts +169 -159
  250. package/src/server/services/LoopWorkerService.ts +986 -912
  251. package/src/server/services/ManagedPromptProtection.ts +88 -0
  252. package/src/server/services/NativeAgentMonitorSyncService.ts +691 -0
  253. package/src/server/services/NativeSubAgentObserver.ts +331 -757
  254. package/src/server/services/NativeUsageAttribution.ts +98 -0
  255. package/src/server/services/PathLockService.ts +317 -317
  256. package/src/server/services/PluginAiRuntimeAdapter.ts +387 -387
  257. package/src/server/services/RunEventBus.ts +58 -58
  258. package/src/server/services/SandboxRunner.ts +492 -492
  259. package/src/server/services/SkillAccessService.ts +175 -175
  260. package/src/server/services/SkillManager.ts +585 -585
  261. package/src/server/services/SkillRepositoryService.ts +236 -236
  262. package/src/server/services/TokenTracker.ts +1158 -287
  263. package/src/server/services/ToolLoopDetectionService.ts +210 -210
  264. package/src/server/services/TracingRetentionPolicy.ts +56 -0
  265. package/src/server/services/VerificationSchema.ts +31 -31
  266. package/src/server/services/VerificationService.ts +332 -313
  267. package/src/server/services/WorkerEnvManager.ts +198 -198
  268. package/src/server/services/__tests__/SkillRepositoryService.test.ts +33 -33
  269. package/src/server/services/harness-runtime-policy.ts +134 -134
  270. package/src/server/services/pythonGuardTemplate.ts +87 -87
  271. package/src/server/services/sandboxCapabilities.ts +348 -348
  272. package/src/server/skill-hub/actions/__tests__/git-import.test.ts +563 -563
  273. package/src/server/skill-hub/actions/git-import.ts +936 -936
  274. package/src/server/skill-hub/mcp/McpController.ts +107 -107
  275. package/src/server/skill-hub/middlewares/git-import-request-method-policy.ts +51 -51
  276. package/src/server/skill-hub/plugin.ts +1232 -1232
  277. package/src/server/skill-hub/sandbox-config.json +6 -6
  278. package/src/server/skill-hub/services/RegistrySkillInstallationService.ts +281 -281
  279. package/src/server/skill-hub/services/__tests__/RegistrySkillInstallationService.test.ts +295 -295
  280. package/src/server/skill-hub/tasks/SkillExecutionTask.ts +568 -568
  281. package/src/server/skill-hub/utils/json-fields.ts +57 -57
  282. package/src/server/tools/delegate-task.ts +30 -30
  283. package/src/server/tools/external-rag-search.ts +329 -329
  284. package/src/server/tools/skill-execute.ts +216 -216
  285. package/src/server/types.ts +21 -21
  286. package/src/server/utils/ai-manager.ts +24 -24
  287. package/src/server/utils/ctx-utils.ts +132 -132
  288. package/src/server/utils/ensure-indexes.ts +119 -96
  289. package/src/server/utils/ha-lock.ts +80 -80
  290. package/src/server/utils/loop-pattern-context.ts +84 -84
  291. package/src/server/utils/record-utils.ts +19 -19
  292. package/src/server/utils/skill-settings.ts +135 -135
  293. package/src/server/utils/skill-tool-name.ts +58 -58
  294. package/dist/client-v2/117.7565cff57c39318a.js +0 -10
  295. package/dist/client-v2/214.106635011859dede.js +0 -10
  296. package/dist/client-v2/253.59577b40d9875be0.js +0 -10
  297. package/dist/client-v2/264.7ed8bee71fa5935c.js +0 -10
  298. package/dist/client-v2/418.41ed200e7d6da332.js +0 -10
  299. package/dist/client-v2/794.a67a2614405ba627.js +0 -10
  300. package/dist/client-v2/993.b0688fdc5ccb000a.js +0 -10
  301. package/dist/node_modules/simple-git/dist/cjs/index.js +0 -7399
  302. package/dist/node_modules/simple-git/dist/esm/index.js +0 -4745
  303. package/dist/node_modules/simple-git/dist/esm/package.json +0 -3
  304. package/dist/node_modules/simple-git/dist/src/lib/api.d.ts +0 -13
  305. package/dist/node_modules/simple-git/dist/src/lib/args/log-format.d.ts +0 -9
  306. package/dist/node_modules/simple-git/dist/src/lib/errors/git-construct-error.d.ts +0 -15
  307. package/dist/node_modules/simple-git/dist/src/lib/errors/git-error.d.ts +0 -30
  308. package/dist/node_modules/simple-git/dist/src/lib/errors/git-plugin-error.d.ts +0 -7
  309. package/dist/node_modules/simple-git/dist/src/lib/errors/git-response-error.d.ts +0 -32
  310. package/dist/node_modules/simple-git/dist/src/lib/errors/task-configuration-error.d.ts +0 -12
  311. package/dist/node_modules/simple-git/dist/src/lib/git-factory.d.ts +0 -15
  312. package/dist/node_modules/simple-git/dist/src/lib/git-logger.d.ts +0 -21
  313. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-branch-delete.d.ts +0 -5
  314. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-branch.d.ts +0 -2
  315. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-commit.d.ts +0 -2
  316. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-diff-summary.d.ts +0 -3
  317. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-fetch.d.ts +0 -2
  318. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-list-log-summary.d.ts +0 -6
  319. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-merge.d.ts +0 -11
  320. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-move.d.ts +0 -2
  321. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-pull.d.ts +0 -6
  322. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-push.d.ts +0 -4
  323. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-remote-messages.d.ts +0 -5
  324. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-remote-objects.d.ts +0 -3
  325. package/dist/node_modules/simple-git/dist/src/lib/plugins/abort-plugin.d.ts +0 -3
  326. package/dist/node_modules/simple-git/dist/src/lib/plugins/block-unsafe-operations-plugin.d.ts +0 -3
  327. package/dist/node_modules/simple-git/dist/src/lib/plugins/command-config-prefixing-plugin.d.ts +0 -2
  328. package/dist/node_modules/simple-git/dist/src/lib/plugins/completion-detection.plugin.d.ts +0 -3
  329. package/dist/node_modules/simple-git/dist/src/lib/plugins/custom-binary.plugin.d.ts +0 -3
  330. package/dist/node_modules/simple-git/dist/src/lib/plugins/error-detection.plugin.d.ts +0 -7
  331. package/dist/node_modules/simple-git/dist/src/lib/plugins/index.d.ts +0 -11
  332. package/dist/node_modules/simple-git/dist/src/lib/plugins/plugin-store.d.ts +0 -11
  333. package/dist/node_modules/simple-git/dist/src/lib/plugins/progress-monitor-plugin.d.ts +0 -3
  334. package/dist/node_modules/simple-git/dist/src/lib/plugins/simple-git-plugin.d.ts +0 -48
  335. package/dist/node_modules/simple-git/dist/src/lib/plugins/spawn-options-plugin.d.ts +0 -3
  336. package/dist/node_modules/simple-git/dist/src/lib/plugins/suffix-paths.plugin.d.ts +0 -2
  337. package/dist/node_modules/simple-git/dist/src/lib/plugins/timout-plugin.d.ts +0 -3
  338. package/dist/node_modules/simple-git/dist/src/lib/responses/BranchDeleteSummary.d.ts +0 -12
  339. package/dist/node_modules/simple-git/dist/src/lib/responses/BranchSummary.d.ts +0 -14
  340. package/dist/node_modules/simple-git/dist/src/lib/responses/CheckIgnore.d.ts +0 -4
  341. package/dist/node_modules/simple-git/dist/src/lib/responses/CleanSummary.d.ts +0 -9
  342. package/dist/node_modules/simple-git/dist/src/lib/responses/ConfigList.d.ts +0 -13
  343. package/dist/node_modules/simple-git/dist/src/lib/responses/DiffSummary.d.ts +0 -10
  344. package/dist/node_modules/simple-git/dist/src/lib/responses/FileStatusSummary.d.ts +0 -9
  345. package/dist/node_modules/simple-git/dist/src/lib/responses/GetRemoteSummary.d.ts +0 -11
  346. package/dist/node_modules/simple-git/dist/src/lib/responses/InitSummary.d.ts +0 -9
  347. package/dist/node_modules/simple-git/dist/src/lib/responses/MergeSummary.d.ts +0 -16
  348. package/dist/node_modules/simple-git/dist/src/lib/responses/PullSummary.d.ts +0 -25
  349. package/dist/node_modules/simple-git/dist/src/lib/responses/StatusSummary.d.ts +0 -19
  350. package/dist/node_modules/simple-git/dist/src/lib/responses/TagList.d.ts +0 -7
  351. package/dist/node_modules/simple-git/dist/src/lib/runners/git-executor-chain.d.ts +0 -25
  352. package/dist/node_modules/simple-git/dist/src/lib/runners/git-executor.d.ts +0 -14
  353. package/dist/node_modules/simple-git/dist/src/lib/runners/promise-wrapped.d.ts +0 -2
  354. package/dist/node_modules/simple-git/dist/src/lib/runners/scheduler.d.ts +0 -11
  355. package/dist/node_modules/simple-git/dist/src/lib/runners/tasks-pending-queue.d.ts +0 -23
  356. package/dist/node_modules/simple-git/dist/src/lib/simple-git-api.d.ts +0 -20
  357. package/dist/node_modules/simple-git/dist/src/lib/task-callback.d.ts +0 -2
  358. package/dist/node_modules/simple-git/dist/src/lib/tasks/apply-patch.d.ts +0 -3
  359. package/dist/node_modules/simple-git/dist/src/lib/tasks/branch.d.ts +0 -7
  360. package/dist/node_modules/simple-git/dist/src/lib/tasks/change-working-directory.d.ts +0 -2
  361. package/dist/node_modules/simple-git/dist/src/lib/tasks/check-ignore.d.ts +0 -2
  362. package/dist/node_modules/simple-git/dist/src/lib/tasks/check-is-repo.d.ts +0 -9
  363. package/dist/node_modules/simple-git/dist/src/lib/tasks/checkout.d.ts +0 -2
  364. package/dist/node_modules/simple-git/dist/src/lib/tasks/clean.d.ts +0 -25
  365. package/dist/node_modules/simple-git/dist/src/lib/tasks/clone.d.ts +0 -9
  366. package/dist/node_modules/simple-git/dist/src/lib/tasks/commit.d.ts +0 -4
  367. package/dist/node_modules/simple-git/dist/src/lib/tasks/config.d.ts +0 -8
  368. package/dist/node_modules/simple-git/dist/src/lib/tasks/count-objects.d.ts +0 -12
  369. package/dist/node_modules/simple-git/dist/src/lib/tasks/diff-name-status.d.ts +0 -12
  370. package/dist/node_modules/simple-git/dist/src/lib/tasks/diff.d.ts +0 -5
  371. package/dist/node_modules/simple-git/dist/src/lib/tasks/fetch.d.ts +0 -4
  372. package/dist/node_modules/simple-git/dist/src/lib/tasks/first-commit.d.ts +0 -2
  373. package/dist/node_modules/simple-git/dist/src/lib/tasks/grep.d.ts +0 -12
  374. package/dist/node_modules/simple-git/dist/src/lib/tasks/hash-object.d.ts +0 -5
  375. package/dist/node_modules/simple-git/dist/src/lib/tasks/init.d.ts +0 -3
  376. package/dist/node_modules/simple-git/dist/src/lib/tasks/log.d.ts +0 -32
  377. package/dist/node_modules/simple-git/dist/src/lib/tasks/merge.d.ts +0 -4
  378. package/dist/node_modules/simple-git/dist/src/lib/tasks/move.d.ts +0 -3
  379. package/dist/node_modules/simple-git/dist/src/lib/tasks/pull.d.ts +0 -3
  380. package/dist/node_modules/simple-git/dist/src/lib/tasks/push.d.ts +0 -9
  381. package/dist/node_modules/simple-git/dist/src/lib/tasks/remote.d.ts +0 -8
  382. package/dist/node_modules/simple-git/dist/src/lib/tasks/reset.d.ts +0 -11
  383. package/dist/node_modules/simple-git/dist/src/lib/tasks/show.d.ts +0 -2
  384. package/dist/node_modules/simple-git/dist/src/lib/tasks/stash-list.d.ts +0 -4
  385. package/dist/node_modules/simple-git/dist/src/lib/tasks/status.d.ts +0 -3
  386. package/dist/node_modules/simple-git/dist/src/lib/tasks/sub-module.d.ts +0 -5
  387. package/dist/node_modules/simple-git/dist/src/lib/tasks/tag.d.ts +0 -18
  388. package/dist/node_modules/simple-git/dist/src/lib/tasks/task.d.ts +0 -14
  389. package/dist/node_modules/simple-git/dist/src/lib/tasks/version.d.ts +0 -9
  390. package/dist/node_modules/simple-git/dist/src/lib/types/handlers.d.ts +0 -21
  391. package/dist/node_modules/simple-git/dist/src/lib/types/index.d.ts +0 -136
  392. package/dist/node_modules/simple-git/dist/src/lib/types/tasks.d.ts +0 -19
  393. package/dist/node_modules/simple-git/dist/src/lib/utils/argument-filters.d.ts +0 -14
  394. package/dist/node_modules/simple-git/dist/src/lib/utils/exit-codes.d.ts +0 -10
  395. package/dist/node_modules/simple-git/dist/src/lib/utils/git-output-streams.d.ts +0 -7
  396. package/dist/node_modules/simple-git/dist/src/lib/utils/index.d.ts +0 -8
  397. package/dist/node_modules/simple-git/dist/src/lib/utils/line-parser.d.ts +0 -15
  398. package/dist/node_modules/simple-git/dist/src/lib/utils/simple-git-options.d.ts +0 -2
  399. package/dist/node_modules/simple-git/dist/src/lib/utils/task-options.d.ts +0 -13
  400. package/dist/node_modules/simple-git/dist/src/lib/utils/task-parser.d.ts +0 -5
  401. package/dist/node_modules/simple-git/dist/src/lib/utils/util.d.ts +0 -47
  402. package/dist/node_modules/simple-git/dist/typings/errors.d.ts +0 -5
  403. package/dist/node_modules/simple-git/dist/typings/index.d.ts +0 -14
  404. package/dist/node_modules/simple-git/dist/typings/response.d.ts +0 -556
  405. package/dist/node_modules/simple-git/dist/typings/simple-git.d.ts +0 -1033
  406. package/dist/node_modules/simple-git/dist/typings/types.d.ts +0 -22
  407. package/dist/node_modules/simple-git/node_modules/debug/package.json +0 -64
  408. package/dist/node_modules/simple-git/node_modules/debug/src/browser.js +0 -272
  409. package/dist/node_modules/simple-git/node_modules/debug/src/common.js +0 -292
  410. package/dist/node_modules/simple-git/node_modules/debug/src/index.js +0 -10
  411. package/dist/node_modules/simple-git/node_modules/debug/src/node.js +0 -263
  412. package/dist/node_modules/simple-git/package.json +0 -1
  413. package/dist/node_modules/simple-git/promise.js +0 -17
@@ -1,512 +1,577 @@
1
- import type { Database } from '@nocobase/database';
2
- import type { Application } from '@nocobase/server';
3
- import { beforeEach, describe, expect, it, vi } from 'vitest';
4
- import { compileHarness } from '../services/HarnessCompiler';
5
- import type { CompiledHarness } from '../services/HarnessCompiler';
6
- import { loopPatternPolicySchema } from '../services/LoopPatternSchema';
7
-
8
- type Row = Record<string, unknown>;
9
-
10
- type InvokeCall = { username: string; prompt: string; harness: CompiledHarness };
11
- type ResumeCall = {
12
- username: string;
13
- sessionId: string;
14
- messageId: string;
15
- decisions: Array<{ toolCallId: string; decision: { type: string; message?: string; editedAction?: unknown } }>;
16
- };
17
- type ResumeOutcome = {
18
- sessionId: string;
19
- messageId: string;
20
- interrupted: Array<{ toolCallId: string; toolName: string; args: unknown; interruptId: string }>;
21
- content: string;
22
- };
23
-
24
- const invokeCalls: InvokeCall[] = [];
25
- const resumeCalls: ResumeCall[] = [];
26
- let resumeOutcome: ResumeOutcome = { sessionId: 'session-1', messageId: 'message-2', interrupted: [], content: '' };
27
-
28
- vi.mock('../services/PluginAiRuntimeAdapter', () => ({
29
- PluginAiRuntimeAdapter: class {
30
- async createConversation() {
31
- return 'session-1';
32
- }
33
- async invoke(input: InvokeCall) {
34
- invokeCalls.push(input);
35
- return { sessionId: 'session-1', messageId: 'message-1', interrupted: [], content: `${input.username} done` };
36
- }
37
- async resume(input: ResumeCall) {
38
- resumeCalls.push(input);
39
- return resumeOutcome;
40
- }
41
- },
42
- }));
43
-
44
- vi.mock('../services/VerificationService', () => ({
45
- VerificationService: class {
46
- async verifyAndFinalize() {
47
- return { verdict: { verdict: 'pass' }, finalStatus: 'succeeded' as const };
48
- }
49
- },
50
- }));
51
-
52
- const { LoopRunRepository } = await import('../services/LoopRunRepository');
53
- const { LoopWorkerService } = await import('../services/LoopWorkerService');
54
-
55
- class MemoryRepository {
56
- private nextId = 1;
57
-
58
- constructor(readonly rows: Row[] = []) {
59
- this.nextId = rows.reduce((maximum, row) => Math.max(maximum, Number(row.id) || 0), 0) + 1;
60
- }
61
-
62
- async find(options: Row = {}) {
63
- const filter = (options.filter as Row | undefined) || {};
64
- return this.rows.filter((row) => Object.entries(filter).every(([key, value]) => row[key] === value));
65
- }
66
-
67
- async findOne(options: Row) {
68
- if (options.filterByTk !== undefined) return this.rows.find((row) => row.id === options.filterByTk) || null;
69
- return (await this.find(options))[0] || null;
70
- }
71
-
72
- async create(options: Row) {
73
- const row = { id: this.nextId++, ...((options.values as Row | undefined) || {}) };
74
- this.rows.push(row);
75
- return row;
76
- }
77
-
78
- async update(options: Row) {
79
- const values = (options.values as Row | undefined) || {};
80
- for (const row of this.rows) {
81
- if (row.id === options.filterByTk) Object.assign(row, values);
82
- }
83
- }
84
- }
85
-
86
- function createDatabase(repositories: Map<string, MemoryRepository>) {
87
- return {
88
- getRepository(name: string) {
89
- const repository = repositories.get(name);
90
- if (!repository) throw new Error(`Unexpected repository ${name}`);
91
- return repository;
92
- },
93
- sequelize: {
94
- transaction<T>(callback: (value: { LOCK: { UPDATE: string } }) => Promise<T>) {
95
- return callback({ LOCK: { UPDATE: 'UPDATE' } });
96
- },
97
- },
98
- } as unknown as Database;
99
- }
100
-
101
- beforeEach(() => {
102
- invokeCalls.length = 0;
103
- resumeCalls.length = 0;
104
- resumeOutcome = { sessionId: 'session-1', messageId: 'message-2', interrupted: [], content: 'resumed done' };
105
- });
106
-
107
- function waitingRun(overrides: Row = {}) {
108
- return {
109
- id: 1,
110
- runtimeVersion: 'control-plane-v2',
111
- patternId: 1,
112
- userId: 7,
113
- status: 'waiting_approval',
114
- approvalStatus: 'pending',
115
- resumeContext: null,
116
- lockedBy: null,
117
- lockedUntil: null,
118
- ...overrides,
119
- };
120
- }
121
-
122
- function pendingApproval(overrides: Row = {}) {
123
- return {
124
- id: 10,
125
- runId: 1,
126
- toolCallId: 'call-1',
127
- toolName: 'editFile',
128
- inputHash: 'hash-1',
129
- status: 'pending',
130
- assignedToId: null,
131
- expiresAt: new Date(Date.now() + 3_600_000),
132
- consumedAt: null,
133
- decisionNote: null,
134
- editedInput: undefined,
135
- ...overrides,
136
- };
137
- }
138
-
139
- describe('LoopRunRepository.decideApproval', () => {
140
- function setup(runs: Row[], approvals: Row[]) {
141
- const repositories = new Map<string, MemoryRepository>([
142
- ['agentLoopRuns', new MemoryRepository(runs)],
143
- ['agentLoopActionApprovals', new MemoryRepository(approvals)],
144
- ['agentLoopEvents', new MemoryRepository()],
145
- ]);
146
- return { repositories, repository: new LoopRunRepository(createDatabase(repositories)) };
147
- }
148
-
149
- it('records the decision and requeues the run once every approval is decided', async () => {
150
- const { repositories, repository } = setup(
151
- [waitingRun()],
152
- [pendingApproval({ id: 10, status: 'approved', consumedAt: null }), pendingApproval({ id: 11 })],
153
- );
154
-
155
- const result = await repository.decideApproval({
156
- approvalId: 11,
157
- userId: 7,
158
- isAdmin: false,
159
- decision: 'approved',
160
- note: 'looks safe',
161
- });
162
-
163
- expect(result).toMatchObject({ status: 'approved', decidedById: 7, requeued: true });
164
- expect(repositories.get('agentLoopRuns')?.rows[0]).toMatchObject({ status: 'queued', approvalStatus: 'decided' });
165
- const decided = repositories.get('agentLoopActionApprovals')?.rows.find((row) => row.id === 11);
166
- expect(decided).toMatchObject({ status: 'approved', decidedById: 7, decisionNote: 'looks safe' });
167
- expect(decided?.decidedAt).toBeInstanceOf(Date);
168
-
169
- const events = repositories.get('agentLoopEvents')?.rows || [];
170
- expect(events).toHaveLength(1);
171
- expect(events[0]).toMatchObject({ runId: 1, type: 'run_approval_decided', actorType: 'human' });
172
- });
173
-
174
- it('records the decision but keeps the run parked while approvals remain pending', async () => {
175
- const { repositories, repository } = setup(
176
- [waitingRun()],
177
- [pendingApproval({ id: 10 }), pendingApproval({ id: 11 })],
178
- );
179
-
180
- const result = await repository.decideApproval({ approvalId: 10, userId: 7, isAdmin: false, decision: 'rejected' });
181
-
182
- expect(result).toMatchObject({ status: 'rejected', requeued: false });
183
- expect(repositories.get('agentLoopRuns')?.rows[0].status).toBe('waiting_approval');
184
- expect(repositories.get('agentLoopEvents')?.rows).toHaveLength(0);
185
- });
186
-
187
- it('stores editedInput only for approvals', async () => {
188
- const { repositories, repository } = setup([waitingRun()], [pendingApproval()]);
189
-
190
- await repository.decideApproval({
191
- approvalId: 10,
192
- userId: 7,
193
- isAdmin: false,
194
- decision: 'approved',
195
- editedInput: { path: '/tmp/safe.txt' },
196
- });
197
-
198
- expect(repositories.get('agentLoopActionApprovals')?.rows[0].editedInput).toEqual({ path: '/tmp/safe.txt' });
199
- });
200
-
201
- it('rejects a decision on an approval that is already decided', async () => {
202
- const { repository } = setup([waitingRun()], [pendingApproval({ status: 'approved' })]);
203
-
204
- await expect(
205
- repository.decideApproval({ approvalId: 10, userId: 7, isAdmin: false, decision: 'rejected' }),
206
- ).rejects.toMatchObject({ status: 409 });
207
- });
208
-
209
- it('rejects a decision once the approval window has expired', async () => {
210
- const { repositories, repository } = setup(
211
- [waitingRun()],
212
- [pendingApproval({ expiresAt: new Date(Date.now() - 1_000) })],
213
- );
214
-
215
- await expect(
216
- repository.decideApproval({ approvalId: 10, userId: 7, isAdmin: false, decision: 'approved' }),
217
- ).rejects.toMatchObject({ status: 409 });
218
- // Fail closed: the row stays pending for the reaper to expire, a late click cannot revive it.
219
- expect(repositories.get('agentLoopActionApprovals')?.rows[0].status).toBe('pending');
220
- });
221
-
222
- it('rejects a decision once the run has moved on', async () => {
223
- const { repository } = setup([waitingRun({ status: 'running' })], [pendingApproval()]);
224
-
225
- await expect(
226
- repository.decideApproval({ approvalId: 10, userId: 7, isAdmin: false, decision: 'approved' }),
227
- ).rejects.toMatchObject({ status: 409 });
228
- });
229
-
230
- it('records decisions for a paused run without requeueing it', async () => {
231
- const { repositories, repository } = setup([waitingRun({ status: 'paused' })], [pendingApproval()]);
232
-
233
- const result = await repository.decideApproval({
234
- approvalId: 10,
235
- userId: 7,
236
- isAdmin: false,
237
- decision: 'approved',
238
- });
239
-
240
- expect(result).toMatchObject({ status: 'approved', requeued: false });
241
- expect(repositories.get('agentLoopRuns')?.rows[0].status).toBe('paused');
242
- });
243
-
244
- it('refuses decisions from users who own neither the run nor the approval', async () => {
245
- const { repository } = setup([waitingRun()], [pendingApproval({ assignedToId: 8 })]);
246
-
247
- await expect(
248
- repository.decideApproval({ approvalId: 10, userId: 9, isAdmin: false, decision: 'approved' }),
249
- ).rejects.toMatchObject({ status: 403 });
250
- });
251
-
252
- it('lets the assigned approver decide even without owning the run', async () => {
253
- const { repository } = setup([waitingRun()], [pendingApproval({ assignedToId: 8 })]);
254
-
255
- const result = await repository.decideApproval({
256
- approvalId: 10,
257
- userId: 8,
258
- isAdmin: false,
259
- decision: 'approved',
260
- });
261
-
262
- expect(result).toMatchObject({ status: 'approved', decidedById: 8 });
263
- });
264
- });
265
-
266
- describe('LoopWorkerService approval resume-mode', () => {
267
- type WorkerInternals = { execute(claimed: { run: Row; leaseToken: string; leaseUntil: Date }): Promise<void> };
268
-
269
- function harnessSnapshot(allow: string[]) {
270
- return { effective: compileHarness([{ source: 'test', settings: { tools: { allow } } }]) };
271
- }
272
-
273
- const policy = loopPatternPolicySchema.parse({ maxConcurrency: 1 });
274
-
275
- function createWorker(run: Row, approvals: Row[] = []) {
276
- const repositories = new Map<string, MemoryRepository>([
277
- [
278
- 'agentLoopControlSettings',
279
- new MemoryRepository([
280
- { id: 1, key: 'global', state: 'running', acceptNewRuns: true, globalMaxConcurrency: 5 },
281
- ]),
282
- ],
283
- ['agentLoopRuns', new MemoryRepository([{ ...run }])],
284
- ['agentLoopActionApprovals', new MemoryRepository(approvals)],
285
- ['agentLoopEvents', new MemoryRepository()],
286
- ['agentLoopSteps', new MemoryRepository()],
287
- ['aiMessages', new MemoryRepository()],
288
- ['agentLoopUsageBuckets', new MemoryRepository()],
289
- ['agentLoopCircuitStates', new MemoryRepository()],
290
- ['agentLoopPathLocks', new MemoryRepository()],
291
- ['agentLoopArtifacts', new MemoryRepository()],
292
- ]);
293
- const app = {
294
- name: 'test',
295
- logger: { warn: vi.fn(), error: vi.fn(), info: vi.fn() },
296
- log: { warn: vi.fn(), error: vi.fn(), info: vi.fn() },
297
- lockManager: { runExclusive: <T>(_key: string, operation: () => Promise<T>) => operation() },
298
- };
299
- const worker = new LoopWorkerService(app as unknown as Application, createDatabase(repositories));
300
- return { repositories, worker: worker as unknown as WorkerInternals };
301
- }
302
-
303
- function resumedRun(overrides: Row = {}) {
304
- return {
305
- id: 1,
306
- runtimeVersion: 'control-plane-v2',
307
- patternId: 1,
308
- userId: 7,
309
- status: 'preparing',
310
- lockedBy: 'worker-a:lease',
311
- lockedUntil: new Date(Date.now() + 60_000),
312
- goal: 'Ship the feature',
313
- autonomyLevel: 'L1',
314
- policySnapshot: policy,
315
- roleBindingsSnapshot: { leader: 'lead', makers: ['maker-one', 'maker-two'], verifier: 'checker' },
316
- leaderHarnessSnapshot: harnessSnapshot(['readFile']),
317
- makerHarnessSnapshot: {
318
- 'maker-one': harnessSnapshot(['editFile']),
319
- 'maker-two': harnessSnapshot(['runTests']),
320
- },
321
- verifierHarnessSnapshot: harnessSnapshot(['readFile']),
322
- repositoryKey: '',
323
- actingOn: [],
324
- approvalStatus: 'decided',
325
- resumeContext: {
326
- role: 'maker',
327
- username: 'maker-one',
328
- sessionId: 'session-1',
329
- messageId: 'message-1',
330
- makerReports: ['the leader plan'],
331
- makerQueue: ['maker-two'],
332
- },
333
- ...overrides,
334
- };
335
- }
336
-
337
- function claimed(run: Row) {
338
- return { run, leaseToken: 'worker-a:lease', leaseUntil: new Date(Date.now() + 60_000) };
339
- }
340
-
341
- it('resumes the interrupted role instead of restarting from the leader', async () => {
342
- const run = resumedRun();
343
- const { repositories, worker } = createWorker(run, [
344
- pendingApproval({ status: 'approved', decidedById: 7, consumedAt: null }),
345
- ]);
346
-
347
- await worker.execute(claimed(run));
348
-
349
- expect(resumeCalls).toHaveLength(1);
350
- expect(resumeCalls[0]).toMatchObject({
351
- username: 'maker-one',
352
- sessionId: 'session-1',
353
- messageId: 'message-1',
354
- decisions: [{ toolCallId: 'call-1', decision: { type: 'approve' } }],
355
- });
356
- // Only the makers still queued run; the leader and completed makers are not re-invoked.
357
- expect(invokeCalls.map((call) => call.username)).toEqual(['maker-two']);
358
- expect(repositories.get('agentLoopRuns')?.rows[0].status).toBe('verifying');
359
- });
360
-
361
- it('maps edited and rejected approvals onto plugin-ai decisions', async () => {
362
- const run = resumedRun();
363
- const { worker } = createWorker(run, [
364
- pendingApproval({
365
- id: 10,
366
- toolCallId: 'call-1',
367
- status: 'approved',
368
- editedInput: { path: '/tmp/safe.txt' },
369
- consumedAt: null,
370
- }),
371
- pendingApproval({
372
- id: 11,
373
- toolCallId: 'call-2',
374
- status: 'rejected',
375
- decisionNote: 'too risky',
376
- consumedAt: null,
377
- }),
378
- ]);
379
-
380
- await worker.execute(claimed(run));
381
-
382
- expect(resumeCalls[0].decisions).toEqual([
383
- {
384
- toolCallId: 'call-1',
385
- decision: { type: 'edit', editedAction: { name: 'editFile', args: { path: '/tmp/safe.txt' } } },
386
- },
387
- { toolCallId: 'call-2', decision: { type: 'reject', message: 'too risky' } },
388
- ]);
389
- });
390
-
391
- it('consumes each decision exactly once', async () => {
392
- const run = resumedRun();
393
- const { repositories, worker } = createWorker(run, [pendingApproval({ status: 'approved', consumedAt: null })]);
394
-
395
- await worker.execute(claimed(run));
396
-
397
- const approval = repositories.get('agentLoopActionApprovals')?.rows[0];
398
- expect(approval?.consumedAt).toBeInstanceOf(Date);
399
- });
400
-
401
- it('parks again with the same resume point when the resumed call hits another gate', async () => {
402
- resumeOutcome = {
403
- sessionId: 'session-1',
404
- messageId: 'message-3',
405
- interrupted: [{ toolCallId: 'call-9', toolName: 'runShell', args: { cmd: 'rm' }, interruptId: 'int-9' }],
406
- content: '',
407
- };
408
- const run = resumedRun();
409
- const { repositories, worker } = createWorker(run, [pendingApproval({ status: 'approved', consumedAt: null })]);
410
-
411
- await worker.execute(claimed(run));
412
-
413
- const row = repositories.get('agentLoopRuns')?.rows[0];
414
- expect(row?.status).toBe('waiting_approval');
415
- expect(row?.approvalStatus).toBe('pending');
416
- // The queue and reports survive the second gate, so the next resume continues in place.
417
- expect(row?.resumeContext).toMatchObject({
418
- role: 'maker',
419
- username: 'maker-one',
420
- messageId: 'message-3',
421
- makerQueue: ['maker-two'],
422
- makerReports: ['the leader plan'],
423
- });
424
- const approvals = repositories.get('agentLoopActionApprovals')?.rows || [];
425
- expect(approvals.filter((approval) => approval.status === 'pending')).toHaveLength(1);
426
- expect(approvals[approvals.length - 1]).toMatchObject({ toolCallId: 'call-9' });
427
- });
428
-
429
- it('tags approvals for escalatable tools as escalations', async () => {
430
- resumeOutcome = {
431
- sessionId: 'session-1',
432
- messageId: 'message-3',
433
- interrupted: [
434
- { toolCallId: 'call-9', toolName: 'runShell', args: { cmd: 'ls' }, interruptId: 'int-9' },
435
- { toolCallId: 'call-10', toolName: 'editFile', args: { path: '/tmp/x' }, interruptId: 'int-10' },
436
- ],
437
- content: '',
438
- };
439
- const run = resumedRun({
440
- makerHarnessSnapshot: {
441
- 'maker-one': {
442
- // runShell is not granted but escalatable; editFile is granted yet still ask-gated here
443
- // because the interrupted call reached the approval gate through the plan.
444
- effective: compileHarness([
445
- { source: 'test', settings: { tools: { allow: ['editFile'], escalate: ['runShell'] } } },
446
- ]),
447
- },
448
- 'maker-two': harnessSnapshot(['runTests']),
449
- },
450
- });
451
- const { repositories, worker } = createWorker(run, [pendingApproval({ status: 'approved', consumedAt: null })]);
452
-
453
- await worker.execute(claimed(run));
454
-
455
- const approvals = repositories.get('agentLoopActionApprovals')?.rows || [];
456
- const escalation = approvals.find((approval) => approval.toolCallId === 'call-9');
457
- const plain = approvals.find((approval) => approval.toolCallId === 'call-10');
458
- expect(escalation).toMatchObject({
459
- actionType: 'escalation',
460
- toolName: 'runShell',
461
- status: 'pending',
462
- });
463
- expect(String(escalation?.reason)).toContain('widens authority for this single call only');
464
- expect(plain).toMatchObject({ actionType: 'tool_call', toolName: 'editFile' });
465
- expect(String(plain?.reason)).toContain('requires human approval');
466
- });
467
-
468
- it('re-parks a requeued run whose decisions never arrived', async () => {
469
- const run = resumedRun({ approvalStatus: 'pending' });
470
- const { repositories, worker } = createWorker(run, [pendingApproval()]);
471
-
472
- await worker.execute(claimed(run));
473
-
474
- expect(resumeCalls).toHaveLength(0);
475
- expect(invokeCalls).toHaveLength(0);
476
- expect(repositories.get('agentLoopRuns')?.rows[0].status).toBe('waiting_approval');
477
- });
478
-
479
- it('ignores a stale resume context left behind by an expired window', async () => {
480
- // The reaper blocks expired runs; a later retry clears approvalStatus to null. Either way the
481
- // saved context must not replay an old conversation, so the run starts fresh from the leader.
482
- const run = resumedRun({ approvalStatus: 'expired' });
483
- const { worker } = createWorker(run, []);
484
-
485
- await worker.execute(claimed(run));
486
-
487
- expect(resumeCalls).toHaveLength(0);
488
- expect(invokeCalls.map((call) => call.username)).toEqual(['lead', 'maker-one', 'maker-two']);
489
- });
490
-
491
- it('resumes the leader into a full maker pass', async () => {
492
- const run = resumedRun({
493
- resumeContext: {
494
- role: 'leader',
495
- username: 'lead',
496
- sessionId: 'session-1',
497
- messageId: 'message-1',
498
- makerReports: [],
499
- makerQueue: ['maker-one', 'maker-two'],
500
- },
501
- });
502
- resumeOutcome = { sessionId: 'session-1', messageId: 'message-2', interrupted: [], content: 'the resumed plan' };
503
- const { worker } = createWorker(run, [pendingApproval({ status: 'approved', consumedAt: null })]);
504
-
505
- await worker.execute(claimed(run));
506
-
507
- expect(resumeCalls).toHaveLength(1);
508
- expect(invokeCalls.map((call) => call.username)).toEqual(['maker-one', 'maker-two']);
509
- // The resumed leader content replaces the plan handed to the makers.
510
- expect(invokeCalls[0].prompt).toContain('the resumed plan');
511
- });
512
- });
1
+ /**
2
+ * This file is part of the NocoBase (R) project.
3
+ * Copyright (c) 2020-2024 NocoBase Co., Ltd.
4
+ * Authors: NocoBase Team.
5
+ *
6
+ * This project is dual-licensed under AGPL-3.0 and NocoBase Commercial License.
7
+ * For more information, please refer to: https://www.nocobase.com/agreement.
8
+ */
9
+
10
+ import type { Database } from '@nocobase/database';
11
+ import type { Application } from '@nocobase/server';
12
+ import { beforeEach, describe, expect, it, vi } from 'vitest';
13
+ import { compileHarness } from '../services/HarnessCompiler';
14
+ import type { CompiledHarness } from '../services/HarnessCompiler';
15
+ import { loopPatternPolicySchema } from '../services/LoopPatternSchema';
16
+
17
+ type Row = Record<string, unknown>;
18
+
19
+ type InvokeCall = { username: string; prompt: string; harness: CompiledHarness };
20
+ type ResumeCall = {
21
+ username: string;
22
+ sessionId: string;
23
+ messageId: string;
24
+ decisions: Array<{ toolCallId: string; decision: { type: string; message?: string; editedAction?: unknown } }>;
25
+ };
26
+ type ResumeOutcome = {
27
+ sessionId: string;
28
+ messageId: string;
29
+ interrupted: Array<{ toolCallId: string; toolName: string; args: unknown; interruptId: string }>;
30
+ content: string;
31
+ };
32
+
33
+ const invokeCalls: InvokeCall[] = [];
34
+ const resumeCalls: ResumeCall[] = [];
35
+ let resumeOutcome: ResumeOutcome = { sessionId: 'session-1', messageId: 'message-2', interrupted: [], content: '' };
36
+
37
+ vi.mock('../services/PluginAiRuntimeAdapter', () => ({
38
+ PluginAiRuntimeAdapter: class {
39
+ async createConversation() {
40
+ return 'session-1';
41
+ }
42
+ async invoke(input: InvokeCall) {
43
+ invokeCalls.push(input);
44
+ return { sessionId: 'session-1', messageId: 'message-1', interrupted: [], content: `${input.username} done` };
45
+ }
46
+ async resume(input: ResumeCall) {
47
+ resumeCalls.push(input);
48
+ return resumeOutcome;
49
+ }
50
+ },
51
+ }));
52
+
53
+ vi.mock('../services/VerificationService', () => ({
54
+ VerificationService: class {
55
+ async verifyAndFinalize() {
56
+ return { verdict: { verdict: 'pass' }, finalStatus: 'succeeded' as const };
57
+ }
58
+ },
59
+ }));
60
+
61
+ const { LoopRunRepository } = await import('../services/LoopRunRepository');
62
+ const { LoopRunStateMachine } = await import('../services/LoopRunStateMachine');
63
+ const { LoopWorkerService } = await import('../services/LoopWorkerService');
64
+
65
+ class MemoryRepository {
66
+ private nextId = 1;
67
+
68
+ constructor(readonly rows: Row[] = []) {
69
+ this.nextId = rows.reduce((maximum, row) => Math.max(maximum, Number(row.id) || 0), 0) + 1;
70
+ }
71
+
72
+ async find(options: Row = {}) {
73
+ const filter = (options.filter as Row | undefined) || {};
74
+ return this.rows.filter((row) =>
75
+ Object.entries(filter).every(([key, value]) => {
76
+ if (value && typeof value === 'object' && '$in' in value && Array.isArray(value.$in)) {
77
+ return value.$in.includes(row[key]);
78
+ }
79
+ return row[key] === value;
80
+ }),
81
+ );
82
+ }
83
+
84
+ async findOne(options: Row) {
85
+ if (options.filterByTk !== undefined) return this.rows.find((row) => row.id === options.filterByTk) || null;
86
+ return (await this.find(options))[0] || null;
87
+ }
88
+
89
+ async count(options: Row = {}) {
90
+ return (await this.find(options)).length;
91
+ }
92
+
93
+ async create(options: Row) {
94
+ const row = { id: this.nextId++, ...((options.values as Row | undefined) || {}) };
95
+ this.rows.push(row);
96
+ return row;
97
+ }
98
+
99
+ async update(options: Row) {
100
+ const values = (options.values as Row | undefined) || {};
101
+ for (const row of this.rows) {
102
+ if (row.id === options.filterByTk) Object.assign(row, values);
103
+ }
104
+ }
105
+ }
106
+
107
+ function createDatabase(repositories: Map<string, MemoryRepository>) {
108
+ return {
109
+ getRepository(name: string) {
110
+ const repository = repositories.get(name);
111
+ if (!repository) throw new Error(`Unexpected repository ${name}`);
112
+ return repository;
113
+ },
114
+ sequelize: {
115
+ transaction<T>(callback: (value: { LOCK: { UPDATE: string } }) => Promise<T>) {
116
+ return callback({ LOCK: { UPDATE: 'UPDATE' } });
117
+ },
118
+ },
119
+ } as unknown as Database;
120
+ }
121
+
122
+ beforeEach(() => {
123
+ invokeCalls.length = 0;
124
+ resumeCalls.length = 0;
125
+ resumeOutcome = { sessionId: 'session-1', messageId: 'message-2', interrupted: [], content: 'resumed done' };
126
+ });
127
+
128
+ function waitingRun(overrides: Row = {}) {
129
+ return {
130
+ id: 1,
131
+ runtimeVersion: 'control-plane-v2',
132
+ patternId: 1,
133
+ userId: 7,
134
+ status: 'waiting_approval',
135
+ approvalStatus: 'pending',
136
+ resumeContext: null,
137
+ lockedBy: null,
138
+ lockedUntil: null,
139
+ ...overrides,
140
+ };
141
+ }
142
+
143
+ function pendingApproval(overrides: Row = {}) {
144
+ return {
145
+ id: 10,
146
+ runId: 1,
147
+ toolCallId: 'call-1',
148
+ toolName: 'editFile',
149
+ inputHash: 'hash-1',
150
+ status: 'pending',
151
+ assignedToId: null,
152
+ expiresAt: new Date(Date.now() + 3_600_000),
153
+ consumedAt: null,
154
+ decisionNote: null,
155
+ editedInput: undefined,
156
+ ...overrides,
157
+ };
158
+ }
159
+
160
+ describe('LoopRunRepository.decideApproval', () => {
161
+ function setup(runs: Row[], approvals: Row[]) {
162
+ const repositories = new Map<string, MemoryRepository>([
163
+ ['agentLoopRuns', new MemoryRepository(runs)],
164
+ ['agentLoopActionApprovals', new MemoryRepository(approvals)],
165
+ ['agentLoopEvents', new MemoryRepository()],
166
+ ]);
167
+ return { repositories, repository: new LoopRunRepository(createDatabase(repositories)) };
168
+ }
169
+
170
+ it('records the decision and requeues the run once every approval is decided', async () => {
171
+ const { repositories, repository } = setup(
172
+ [waitingRun()],
173
+ [pendingApproval({ id: 10, status: 'approved', consumedAt: null }), pendingApproval({ id: 11 })],
174
+ );
175
+
176
+ const result = await repository.decideApproval({
177
+ approvalId: 11,
178
+ userId: 7,
179
+ isAdmin: false,
180
+ decision: 'approved',
181
+ note: 'looks safe',
182
+ });
183
+
184
+ expect(result).toMatchObject({ status: 'approved', decidedById: 7, requeued: true });
185
+ expect(repositories.get('agentLoopRuns')?.rows[0]).toMatchObject({ status: 'queued', approvalStatus: 'decided' });
186
+ const decided = repositories.get('agentLoopActionApprovals')?.rows.find((row) => row.id === 11);
187
+ expect(decided).toMatchObject({ status: 'approved', decidedById: 7, decisionNote: 'looks safe' });
188
+ expect(decided?.decidedAt).toBeInstanceOf(Date);
189
+
190
+ const events = repositories.get('agentLoopEvents')?.rows || [];
191
+ expect(events).toHaveLength(1);
192
+ expect(events[0]).toMatchObject({ runId: 1, type: 'run_approval_decided', actorType: 'human' });
193
+ });
194
+
195
+ it('records the decision but keeps the run parked while approvals remain pending', async () => {
196
+ const { repositories, repository } = setup(
197
+ [waitingRun()],
198
+ [pendingApproval({ id: 10 }), pendingApproval({ id: 11 })],
199
+ );
200
+
201
+ const result = await repository.decideApproval({ approvalId: 10, userId: 7, isAdmin: false, decision: 'rejected' });
202
+
203
+ expect(result).toMatchObject({ status: 'rejected', requeued: false });
204
+ expect(repositories.get('agentLoopRuns')?.rows[0].status).toBe('waiting_approval');
205
+ expect(repositories.get('agentLoopEvents')?.rows).toHaveLength(0);
206
+ });
207
+
208
+ it('stores editedInput only for approvals', async () => {
209
+ const { repositories, repository } = setup([waitingRun()], [pendingApproval()]);
210
+
211
+ await repository.decideApproval({
212
+ approvalId: 10,
213
+ userId: 7,
214
+ isAdmin: false,
215
+ decision: 'approved',
216
+ editedInput: { path: '/tmp/safe.txt' },
217
+ });
218
+
219
+ expect(repositories.get('agentLoopActionApprovals')?.rows[0].editedInput).toEqual({ path: '/tmp/safe.txt' });
220
+ });
221
+
222
+ it('rejects a decision on an approval that is already decided', async () => {
223
+ const { repository } = setup([waitingRun()], [pendingApproval({ status: 'approved' })]);
224
+
225
+ await expect(
226
+ repository.decideApproval({ approvalId: 10, userId: 7, isAdmin: false, decision: 'rejected' }),
227
+ ).rejects.toMatchObject({ status: 409 });
228
+ });
229
+
230
+ it('rejects a decision once the approval window has expired', async () => {
231
+ const { repositories, repository } = setup(
232
+ [waitingRun()],
233
+ [pendingApproval({ expiresAt: new Date(Date.now() - 1_000) })],
234
+ );
235
+
236
+ await expect(
237
+ repository.decideApproval({ approvalId: 10, userId: 7, isAdmin: false, decision: 'approved' }),
238
+ ).rejects.toMatchObject({ status: 409 });
239
+ // Fail closed: the row stays pending for the reaper to expire, a late click cannot revive it.
240
+ expect(repositories.get('agentLoopActionApprovals')?.rows[0].status).toBe('pending');
241
+ });
242
+
243
+ it('rejects a decision once the run has moved on', async () => {
244
+ const { repository } = setup([waitingRun({ status: 'running' })], [pendingApproval()]);
245
+
246
+ await expect(
247
+ repository.decideApproval({ approvalId: 10, userId: 7, isAdmin: false, decision: 'approved' }),
248
+ ).rejects.toMatchObject({ status: 409 });
249
+ });
250
+
251
+ it('records decisions for a paused run without requeueing it', async () => {
252
+ const { repositories, repository } = setup([waitingRun({ status: 'paused' })], [pendingApproval()]);
253
+
254
+ const result = await repository.decideApproval({
255
+ approvalId: 10,
256
+ userId: 7,
257
+ isAdmin: false,
258
+ decision: 'approved',
259
+ });
260
+
261
+ expect(result).toMatchObject({ status: 'approved', requeued: false });
262
+ expect(repositories.get('agentLoopRuns')?.rows[0]).toMatchObject({
263
+ status: 'paused',
264
+ approvalStatus: 'decided',
265
+ });
266
+ });
267
+
268
+ it('keeps a paused run pending until all approvals have decisions', async () => {
269
+ const { repositories, repository } = setup(
270
+ [waitingRun({ status: 'paused' })],
271
+ [pendingApproval(), pendingApproval({ id: 11 })],
272
+ );
273
+
274
+ await repository.decideApproval({ approvalId: 10, userId: 7, isAdmin: false, decision: 'approved' });
275
+
276
+ expect(repositories.get('agentLoopRuns')?.rows[0]).toMatchObject({
277
+ status: 'paused',
278
+ approvalStatus: 'pending',
279
+ });
280
+ });
281
+
282
+ it('refuses decisions from users who own neither the run nor the approval', async () => {
283
+ const { repository } = setup([waitingRun()], [pendingApproval({ assignedToId: 8 })]);
284
+
285
+ await expect(
286
+ repository.decideApproval({ approvalId: 10, userId: 9, isAdmin: false, decision: 'approved' }),
287
+ ).rejects.toMatchObject({ status: 403 });
288
+ });
289
+
290
+ it('lets the assigned approver decide even without owning the run', async () => {
291
+ const { repository } = setup([waitingRun()], [pendingApproval({ assignedToId: 8 })]);
292
+
293
+ const result = await repository.decideApproval({
294
+ approvalId: 10,
295
+ userId: 8,
296
+ isAdmin: false,
297
+ decision: 'approved',
298
+ });
299
+
300
+ expect(result).toMatchObject({ status: 'approved', decidedById: 8 });
301
+ });
302
+ });
303
+
304
+ describe('LoopWorkerService approval resume-mode', () => {
305
+ type WorkerInternals = { execute(claimed: { run: Row; leaseToken: string; leaseUntil: Date }): Promise<void> };
306
+
307
+ function harnessSnapshot(allow: string[]) {
308
+ return { effective: compileHarness([{ source: 'test', settings: { tools: { allow } } }]) };
309
+ }
310
+
311
+ const policy = loopPatternPolicySchema.parse({ maxConcurrency: 1 });
312
+
313
+ function createWorker(run: Row, approvals: Row[] = []) {
314
+ const repositories = new Map<string, MemoryRepository>([
315
+ [
316
+ 'agentLoopControlSettings',
317
+ new MemoryRepository([
318
+ { id: 1, key: 'global', state: 'running', acceptNewRuns: true, globalMaxConcurrency: 5 },
319
+ ]),
320
+ ],
321
+ ['agentLoopRuns', new MemoryRepository([{ ...run }])],
322
+ ['agentLoopPatterns', new MemoryRepository([{ id: 1, enabled: true }])],
323
+ ['agentLoopActionApprovals', new MemoryRepository(approvals)],
324
+ ['agentLoopEvents', new MemoryRepository()],
325
+ ['agentLoopSteps', new MemoryRepository()],
326
+ ['aiMessages', new MemoryRepository()],
327
+ ['agentLoopUsageBuckets', new MemoryRepository()],
328
+ ['agentLoopCircuitStates', new MemoryRepository()],
329
+ ['agentLoopPathLocks', new MemoryRepository()],
330
+ ['agentLoopArtifacts', new MemoryRepository()],
331
+ ]);
332
+ const app = {
333
+ name: 'test',
334
+ logger: { warn: vi.fn(), error: vi.fn(), info: vi.fn() },
335
+ log: { warn: vi.fn(), error: vi.fn(), info: vi.fn() },
336
+ lockManager: { runExclusive: <T>(_key: string, operation: () => Promise<T>) => operation() },
337
+ };
338
+ const database = createDatabase(repositories);
339
+ const worker = new LoopWorkerService(app as unknown as Application, database);
340
+ return { repositories, database, worker: worker as unknown as WorkerInternals };
341
+ }
342
+
343
+ function resumedRun(overrides: Row = {}) {
344
+ return {
345
+ id: 1,
346
+ runtimeVersion: 'control-plane-v2',
347
+ patternId: 1,
348
+ userId: 7,
349
+ status: 'preparing',
350
+ lockedBy: 'worker-a:lease',
351
+ lockedUntil: new Date(Date.now() + 60_000),
352
+ goal: 'Ship the feature',
353
+ autonomyLevel: 'L1',
354
+ policySnapshot: policy,
355
+ roleBindingsSnapshot: { leader: 'lead', makers: ['maker-one', 'maker-two'], verifier: 'checker' },
356
+ leaderHarnessSnapshot: harnessSnapshot(['readFile']),
357
+ makerHarnessSnapshot: {
358
+ 'maker-one': harnessSnapshot(['editFile']),
359
+ 'maker-two': harnessSnapshot(['runTests']),
360
+ },
361
+ verifierHarnessSnapshot: harnessSnapshot(['readFile']),
362
+ repositoryKey: '',
363
+ actingOn: [],
364
+ approvalStatus: 'decided',
365
+ resumeContext: {
366
+ role: 'maker',
367
+ username: 'maker-one',
368
+ sessionId: 'session-1',
369
+ messageId: 'message-1',
370
+ makerReports: ['the leader plan'],
371
+ makerQueue: ['maker-two'],
372
+ },
373
+ ...overrides,
374
+ };
375
+ }
376
+
377
+ function claimed(run: Row) {
378
+ return { run, leaseToken: 'worker-a:lease', leaseUntil: new Date(Date.now() + 60_000) };
379
+ }
380
+
381
+ it('resumes the interrupted role instead of restarting from the leader', async () => {
382
+ const run = resumedRun();
383
+ const { repositories, worker } = createWorker(run, [
384
+ pendingApproval({ status: 'approved', decidedById: 7, consumedAt: null }),
385
+ ]);
386
+
387
+ await worker.execute(claimed(run));
388
+
389
+ expect(resumeCalls).toHaveLength(1);
390
+ expect(resumeCalls[0]).toMatchObject({
391
+ username: 'maker-one',
392
+ sessionId: 'session-1',
393
+ messageId: 'message-1',
394
+ decisions: [{ toolCallId: 'call-1', decision: { type: 'approve' } }],
395
+ });
396
+ // Only the makers still queued run; the leader and completed makers are not re-invoked.
397
+ expect(invokeCalls.map((call) => call.username)).toEqual(['maker-two']);
398
+ expect(repositories.get('agentLoopRuns')?.rows[0].status).toBe('verifying');
399
+ });
400
+
401
+ it.each(['approved', 'rejected'] as const)(
402
+ 'resumes the interrupted role after a paused approval is %s and the owner resumes the run',
403
+ async (decision) => {
404
+ const run = resumedRun({ status: 'paused', approvalStatus: 'pending', lockedBy: null, lockedUntil: null });
405
+ const { repositories, database, worker } = createWorker(run, [pendingApproval()]);
406
+ const repository = new LoopRunRepository(database);
407
+ const stateMachine = new LoopRunStateMachine(database);
408
+
409
+ await repository.decideApproval({ approvalId: 10, userId: 7, isAdmin: false, decision });
410
+ await stateMachine.transition({ runId: 1, to: 'queued', actorType: 'human', actorIdentity: '7' });
411
+ const nextClaim = await stateMachine.claimNext('worker-a', 60_000);
412
+ if (!nextClaim) throw new Error('Expected the resumed run to be claimed.');
413
+ await worker.execute(nextClaim);
414
+
415
+ expect(resumeCalls).toHaveLength(1);
416
+ expect(resumeCalls[0]).toMatchObject({
417
+ username: 'maker-one',
418
+ decisions: [{ toolCallId: 'call-1', decision: { type: decision === 'approved' ? 'approve' : 'reject' } }],
419
+ });
420
+ expect(invokeCalls.map((call) => call.username)).toEqual(['maker-two']);
421
+ expect(repositories.get('agentLoopActionApprovals')?.rows[0].consumedAt).toBeInstanceOf(Date);
422
+ expect(repositories.get('agentLoopRuns')?.rows[0].status).toBe('verifying');
423
+ },
424
+ );
425
+
426
+ it('maps edited and rejected approvals onto plugin-ai decisions', async () => {
427
+ const run = resumedRun();
428
+ const { worker } = createWorker(run, [
429
+ pendingApproval({
430
+ id: 10,
431
+ toolCallId: 'call-1',
432
+ status: 'approved',
433
+ editedInput: { path: '/tmp/safe.txt' },
434
+ consumedAt: null,
435
+ }),
436
+ pendingApproval({
437
+ id: 11,
438
+ toolCallId: 'call-2',
439
+ status: 'rejected',
440
+ decisionNote: 'too risky',
441
+ consumedAt: null,
442
+ }),
443
+ ]);
444
+
445
+ await worker.execute(claimed(run));
446
+
447
+ expect(resumeCalls[0].decisions).toEqual([
448
+ {
449
+ toolCallId: 'call-1',
450
+ decision: { type: 'edit', editedAction: { name: 'editFile', args: { path: '/tmp/safe.txt' } } },
451
+ },
452
+ { toolCallId: 'call-2', decision: { type: 'reject', message: 'too risky' } },
453
+ ]);
454
+ });
455
+
456
+ it('consumes each decision exactly once', async () => {
457
+ const run = resumedRun();
458
+ const { repositories, worker } = createWorker(run, [pendingApproval({ status: 'approved', consumedAt: null })]);
459
+
460
+ await worker.execute(claimed(run));
461
+
462
+ const approval = repositories.get('agentLoopActionApprovals')?.rows[0];
463
+ expect(approval?.consumedAt).toBeInstanceOf(Date);
464
+ });
465
+
466
+ it('parks again with the same resume point when the resumed call hits another gate', async () => {
467
+ resumeOutcome = {
468
+ sessionId: 'session-1',
469
+ messageId: 'message-3',
470
+ interrupted: [{ toolCallId: 'call-9', toolName: 'runShell', args: { cmd: 'rm' }, interruptId: 'int-9' }],
471
+ content: '',
472
+ };
473
+ const run = resumedRun();
474
+ const { repositories, worker } = createWorker(run, [pendingApproval({ status: 'approved', consumedAt: null })]);
475
+
476
+ await worker.execute(claimed(run));
477
+
478
+ const row = repositories.get('agentLoopRuns')?.rows[0];
479
+ expect(row?.status).toBe('waiting_approval');
480
+ expect(row?.approvalStatus).toBe('pending');
481
+ // The queue and reports survive the second gate, so the next resume continues in place.
482
+ expect(row?.resumeContext).toMatchObject({
483
+ role: 'maker',
484
+ username: 'maker-one',
485
+ messageId: 'message-3',
486
+ makerQueue: ['maker-two'],
487
+ makerReports: ['the leader plan'],
488
+ });
489
+ const approvals = repositories.get('agentLoopActionApprovals')?.rows || [];
490
+ expect(approvals.filter((approval) => approval.status === 'pending')).toHaveLength(1);
491
+ expect(approvals[approvals.length - 1]).toMatchObject({ toolCallId: 'call-9' });
492
+ });
493
+
494
+ it('tags approvals for escalatable tools as escalations', async () => {
495
+ resumeOutcome = {
496
+ sessionId: 'session-1',
497
+ messageId: 'message-3',
498
+ interrupted: [
499
+ { toolCallId: 'call-9', toolName: 'runShell', args: { cmd: 'ls' }, interruptId: 'int-9' },
500
+ { toolCallId: 'call-10', toolName: 'editFile', args: { path: '/tmp/x' }, interruptId: 'int-10' },
501
+ ],
502
+ content: '',
503
+ };
504
+ const run = resumedRun({
505
+ makerHarnessSnapshot: {
506
+ 'maker-one': {
507
+ // runShell is not granted but escalatable; editFile is granted yet still ask-gated here
508
+ // because the interrupted call reached the approval gate through the plan.
509
+ effective: compileHarness([
510
+ { source: 'test', settings: { tools: { allow: ['editFile'], escalate: ['runShell'] } } },
511
+ ]),
512
+ },
513
+ 'maker-two': harnessSnapshot(['runTests']),
514
+ },
515
+ });
516
+ const { repositories, worker } = createWorker(run, [pendingApproval({ status: 'approved', consumedAt: null })]);
517
+
518
+ await worker.execute(claimed(run));
519
+
520
+ const approvals = repositories.get('agentLoopActionApprovals')?.rows || [];
521
+ const escalation = approvals.find((approval) => approval.toolCallId === 'call-9');
522
+ const plain = approvals.find((approval) => approval.toolCallId === 'call-10');
523
+ expect(escalation).toMatchObject({
524
+ actionType: 'escalation',
525
+ toolName: 'runShell',
526
+ status: 'pending',
527
+ });
528
+ expect(String(escalation?.reason)).toContain('widens authority for this single call only');
529
+ expect(plain).toMatchObject({ actionType: 'tool_call', toolName: 'editFile' });
530
+ expect(String(plain?.reason)).toContain('requires human approval');
531
+ });
532
+
533
+ it('re-parks a requeued run whose decisions never arrived', async () => {
534
+ const run = resumedRun({ approvalStatus: 'pending' });
535
+ const { repositories, worker } = createWorker(run, [pendingApproval()]);
536
+
537
+ await worker.execute(claimed(run));
538
+
539
+ expect(resumeCalls).toHaveLength(0);
540
+ expect(invokeCalls).toHaveLength(0);
541
+ expect(repositories.get('agentLoopRuns')?.rows[0].status).toBe('waiting_approval');
542
+ });
543
+
544
+ it('ignores a stale resume context left behind by an expired window', async () => {
545
+ // The reaper blocks expired runs; a later retry clears approvalStatus to null. Either way the
546
+ // saved context must not replay an old conversation, so the run starts fresh from the leader.
547
+ const run = resumedRun({ approvalStatus: 'expired' });
548
+ const { worker } = createWorker(run, []);
549
+
550
+ await worker.execute(claimed(run));
551
+
552
+ expect(resumeCalls).toHaveLength(0);
553
+ expect(invokeCalls.map((call) => call.username)).toEqual(['lead', 'maker-one', 'maker-two']);
554
+ });
555
+
556
+ it('resumes the leader into a full maker pass', async () => {
557
+ const run = resumedRun({
558
+ resumeContext: {
559
+ role: 'leader',
560
+ username: 'lead',
561
+ sessionId: 'session-1',
562
+ messageId: 'message-1',
563
+ makerReports: [],
564
+ makerQueue: ['maker-one', 'maker-two'],
565
+ },
566
+ });
567
+ resumeOutcome = { sessionId: 'session-1', messageId: 'message-2', interrupted: [], content: 'the resumed plan' };
568
+ const { worker } = createWorker(run, [pendingApproval({ status: 'approved', consumedAt: null })]);
569
+
570
+ await worker.execute(claimed(run));
571
+
572
+ expect(resumeCalls).toHaveLength(1);
573
+ expect(invokeCalls.map((call) => call.username)).toEqual(['maker-one', 'maker-two']);
574
+ // The resumed leader content replaces the plan handed to the makers.
575
+ expect(invokeCalls[0].prompt).toContain('the resumed plan');
576
+ });
577
+ });