plugin-agent-orchestrator 1.1.7 → 1.2.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (413) hide show
  1. package/README.md +207 -204
  2. package/client-v2.d.ts +2 -2
  3. package/client-v2.js +1 -1
  4. package/client.d.ts +2 -2
  5. package/client.js +1 -1
  6. package/dist/client/117.2e4cb0477da3db1f.js +10 -0
  7. package/dist/client/253.93deb9e0192e76a5.js +10 -0
  8. package/dist/client/325.8f7f509bdb35e142.js +10 -0
  9. package/dist/client/404.498d2d9516dd1dce.js +10 -0
  10. package/dist/client/418.6f01da17774a5a25.js +10 -0
  11. package/dist/client/53.774ff07505d521fa.js +10 -0
  12. package/dist/client/619.e342b0fa467d39ca.js +10 -0
  13. package/dist/client/627.fdd60bcc0f3a9cf6.js +10 -0
  14. package/dist/client/652.477e21bfff67bc1c.js +10 -0
  15. package/dist/client/981.e0546ffc34afedcd.js +10 -0
  16. package/dist/client/993.5d04b510835ab0d2.js +10 -0
  17. package/dist/client/index.js +1 -1
  18. package/dist/client-v2/117.ccf43ae8631f7d74.js +10 -0
  19. package/dist/client-v2/214.cdf76752053a8990.js +10 -0
  20. package/dist/client-v2/253.1198df22f5baf304.js +10 -0
  21. package/dist/client-v2/264.78887ff88f969467.js +10 -0
  22. package/dist/client-v2/325.fafe5a6e83ba9cb3.js +10 -0
  23. package/dist/client-v2/404.9ba964c28a151c81.js +10 -0
  24. package/dist/client-v2/{41.3deb9e57a0f64fc4.js → 41.b28cf7a675a603d1.js} +1 -1
  25. package/dist/client-v2/418.55b6b28cda8bb5f3.js +10 -0
  26. package/dist/client-v2/{53.349fff8db80b19d4.js → 53.282081f97e4308c6.js} +1 -1
  27. package/dist/client-v2/{619.0a2144aaffefe018.js → 619.8c03913873785fb6.js} +1 -1
  28. package/dist/client-v2/627.e16f4a0dd596c3e6.js +10 -0
  29. package/dist/client-v2/652.1a48364774d5383a.js +10 -0
  30. package/dist/client-v2/{70.ffff2997c10fd4b0.js → 70.9166ed70906d041f.js} +1 -1
  31. package/dist/client-v2/{981.e4a1f41cfc94a856.js → 981.a81521f0296c7db8.js} +1 -1
  32. package/dist/client-v2/993.ca5b28f1e2b4c1ef.js +10 -0
  33. package/dist/client-v2/index.js +1 -1
  34. package/dist/externalVersion.js +10 -7
  35. package/dist/locale/en-US.json +229 -1
  36. package/dist/locale/zh-CN.json +229 -1
  37. package/dist/node_modules/adm-zip/adm-zip.js +1 -1
  38. package/dist/node_modules/adm-zip/package.json +1 -1
  39. package/dist/node_modules/ajv/package.json +1 -1
  40. package/dist/node_modules/zod/index.cjs +1 -1
  41. package/dist/node_modules/zod/package.json +1 -1
  42. package/dist/server/collections/agent-execution-spans.js +145 -6
  43. package/dist/server/collections/agent-governance-audit-events.js +47 -0
  44. package/dist/server/collections/agent-governance-policies.js +47 -0
  45. package/dist/server/collections/agent-governance-policy-versions.js +48 -0
  46. package/dist/server/collections/agent-governance-prompt-bindings.js +50 -0
  47. package/dist/server/collections/agent-loop-runs.js +23 -5
  48. package/dist/server/migrations/20261110000000-add-usage-pricing-snapshots.js +117 -0
  49. package/dist/server/migrations/20261110010000-add-usage-department-attribution.js +54 -0
  50. package/dist/server/plugin.js +114 -33
  51. package/dist/server/resources/agent-governance.js +192 -0
  52. package/dist/server/resources/agent-harness-profile.js +11 -3
  53. package/dist/server/resources/agent-monitor.js +109 -339
  54. package/dist/server/resources/agent-usage.js +423 -0
  55. package/dist/server/resources/native-monitor-format.js +179 -0
  56. package/dist/server/resources/tracing.js +35 -12
  57. package/dist/server/services/AgentGovernanceService.js +500 -0
  58. package/dist/server/services/DepartmentAttribution.js +65 -0
  59. package/dist/server/services/ExecutionSpanService.js +96 -3
  60. package/dist/server/services/GovernanceAdmission.js +211 -0
  61. package/dist/server/services/HarnessCapabilities.js +118 -0
  62. package/dist/server/services/LoopBudgetService.js +29 -11
  63. package/dist/server/services/LoopRunRepository.js +15 -6
  64. package/dist/server/services/LoopRunStateMachine.js +18 -7
  65. package/dist/server/services/LoopTriggerService.js +1 -1
  66. package/dist/server/services/LoopWorkerService.js +66 -32
  67. package/dist/server/services/ManagedPromptProtection.js +99 -0
  68. package/dist/server/services/NativeAgentMonitorSyncService.js +584 -0
  69. package/dist/server/services/NativeSubAgentObserver.js +141 -508
  70. package/dist/server/services/NativeUsageAttribution.js +97 -0
  71. package/dist/server/services/TokenTracker.js +787 -104
  72. package/dist/server/services/TracingRetentionPolicy.js +66 -0
  73. package/dist/server/services/VerificationService.js +18 -8
  74. package/dist/server/skill-hub/sandbox-config.json +6 -6
  75. package/dist/server/utils/ensure-indexes.js +14 -5
  76. package/package.json +63 -53
  77. package/server.d.ts +2 -2
  78. package/server.js +1 -1
  79. package/src/client/AgentRunsTab.tsx +2 -2
  80. package/src/client/ApprovalsTab.tsx +2 -2
  81. package/src/client/HarnessProfilesTab.tsx +2 -2
  82. package/src/client/OrchestratorSettings.tsx +152 -152
  83. package/src/client/SkillPages.tsx +41 -0
  84. package/src/client/__tests__/embedded-settings.test.tsx +232 -0
  85. package/src/client/hooks/useRunEventStream.ts +76 -76
  86. package/src/client/index.tsx +2 -2
  87. package/src/client/plugin.tsx +76 -32
  88. package/src/client/skill-hub/components/ExecutionHistory.tsx +200 -200
  89. package/src/client/skill-hub/components/GitSkillImport.tsx +562 -562
  90. package/src/client/skill-hub/components/LoopSettings.tsx +331 -331
  91. package/src/client/skill-hub/components/SkillEditor.tsx +460 -460
  92. package/src/client/skill-hub/components/SkillManager.tsx +194 -194
  93. package/src/client/skill-hub/components/SkillMetrics.tsx +162 -162
  94. package/src/client/skill-hub/components/SkillTestPanel.tsx +141 -141
  95. package/src/client/skill-hub/index.tsx +6 -6
  96. package/src/client/skill-hub/locale.ts +16 -16
  97. package/src/client/skill-hub/tools/InteractionSchemasProvider.tsx +132 -132
  98. package/src/client/skill-hub/tools/SkillHubCard.tsx +104 -104
  99. package/src/client/skill-hub/tools/loopTemplates.ts +52 -52
  100. package/src/client/skill-hub/tools/registerSkillLoopCards.ts +71 -71
  101. package/src/client/skill-hub/utils/jsonFields.ts +41 -41
  102. package/src/client-v2/__tests__/embedded-settings.test.tsx +193 -0
  103. package/src/client-v2/components/AIEmployeeSelect.tsx +47 -47
  104. package/src/client-v2/components/AIEmployeesContext.tsx +97 -97
  105. package/src/client-v2/components/AgentBindingsTab.tsx +269 -269
  106. package/src/client-v2/components/AgentRunsTab.tsx +92 -83
  107. package/src/client-v2/components/ApprovalsTab.tsx +337 -337
  108. package/src/client-v2/components/EmployeeGovernanceTab.tsx +702 -0
  109. package/src/client-v2/components/HarnessProfilesTab.tsx +704 -541
  110. package/src/client-v2/components/KnowledgeAccessTab.tsx +116 -116
  111. package/src/client-v2/components/RetrievalTraceTab.tsx +162 -162
  112. package/src/client-v2/components/UsageGovernanceTab.tsx +386 -0
  113. package/src/client-v2/index.tsx +1 -1
  114. package/src/client-v2/pages/AgentBindingsPage.tsx +22 -13
  115. package/src/client-v2/pages/ApprovalsPage.tsx +19 -10
  116. package/src/client-v2/pages/EmployeeGovernancePage.tsx +22 -0
  117. package/src/client-v2/pages/ExecutionHistoryPage.tsx +19 -10
  118. package/src/client-v2/pages/HarnessProfilesPage.tsx +19 -10
  119. package/src/client-v2/pages/KnowledgeAccessPage.tsx +19 -10
  120. package/src/client-v2/pages/LoopSettingsPage.tsx +19 -10
  121. package/src/client-v2/pages/MemoryInspectorPage.tsx +22 -13
  122. package/src/client-v2/pages/RetrievalTracePage.tsx +19 -10
  123. package/src/client-v2/pages/RulesPage.tsx +22 -13
  124. package/src/client-v2/pages/SkillDefinitionsPage.tsx +19 -10
  125. package/src/client-v2/pages/SkillMetricsPage.tsx +19 -10
  126. package/src/client-v2/pages/TracingPage.tsx +22 -13
  127. package/src/client-v2/pages/UsageGovernancePage.tsx +22 -0
  128. package/src/client-v2/plugin.tsx +139 -99
  129. package/src/client-v2/skill-hub/components/ExecutionHistory.tsx +196 -196
  130. package/src/client-v2/skill-hub/components/FileLinkList.tsx +37 -37
  131. package/src/client-v2/skill-hub/components/GitSkillImport.tsx +539 -539
  132. package/src/client-v2/skill-hub/components/LoopSettings.tsx +331 -331
  133. package/src/client-v2/skill-hub/components/SkillEditor.tsx +453 -453
  134. package/src/client-v2/skill-hub/components/SkillManager.tsx +191 -174
  135. package/src/client-v2/skill-hub/components/SkillMetrics.tsx +162 -162
  136. package/src/client-v2/skill-hub/components/SkillTestPanel.tsx +135 -135
  137. package/src/client-v2/skill-hub/locale.ts +13 -13
  138. package/src/client-v2/skill-hub/tools/InteractionSchemasProvider.tsx +62 -0
  139. package/src/client-v2/skill-hub/tools/SkillHubCard.tsx +104 -0
  140. package/src/client-v2/skill-hub/tools/__tests__/interactions.test.ts +110 -0
  141. package/src/client-v2/skill-hub/tools/interactions.ts +128 -0
  142. package/src/client-v2/skill-hub/tools/loopTemplates.ts +52 -52
  143. package/src/client-v2/skill-hub/utils/jsonFields.ts +41 -41
  144. package/src/client-v2/utils/jsonFields.ts +41 -41
  145. package/src/index.ts +2 -2
  146. package/src/locale/en-US.json +229 -1
  147. package/src/locale/zh-CN.json +229 -1
  148. package/src/server/__tests__/agent-execution-context.test.ts +18 -18
  149. package/src/server/__tests__/agent-governance.integration.test.ts +392 -0
  150. package/src/server/__tests__/agent-knowledge-insights.test.ts +123 -123
  151. package/src/server/__tests__/agent-monitor-acl.integration.test.ts +274 -0
  152. package/src/server/__tests__/agent-registry-service.test.ts +147 -147
  153. package/src/server/__tests__/agent-runtime-lifecycle.test.ts +46 -46
  154. package/src/server/__tests__/agent-usage-report.integration.test.ts +342 -0
  155. package/src/server/__tests__/code-validator.test.ts +63 -63
  156. package/src/server/__tests__/external-rag-search.test.ts +107 -107
  157. package/src/server/__tests__/harness-capabilities.test.ts +95 -0
  158. package/src/server/__tests__/harness-compiler.test.ts +214 -214
  159. package/src/server/__tests__/harness-profile-service.test.ts +167 -167
  160. package/src/server/__tests__/harness-runtime-policy.test.ts +293 -293
  161. package/src/server/__tests__/harness-tool-plan.test.ts +182 -172
  162. package/src/server/__tests__/input-schema-validator.test.ts +26 -26
  163. package/src/server/__tests__/loop-approval-decision.test.ts +577 -512
  164. package/src/server/__tests__/loop-approval-expiry.test.ts +258 -258
  165. package/src/server/__tests__/loop-budget-service.test.ts +36 -0
  166. package/src/server/__tests__/loop-pattern-schema.test.ts +73 -73
  167. package/src/server/__tests__/loop-run-repository.test.ts +32 -0
  168. package/src/server/__tests__/loop-run-state-machine.test.ts +101 -101
  169. package/src/server/__tests__/loop-trigger-service.test.ts +192 -148
  170. package/src/server/__tests__/loop-worker-claim.test.ts +72 -9
  171. package/src/server/__tests__/loop-worker-execution.test.ts +382 -317
  172. package/src/server/__tests__/native-agent-monitor-sync.test.ts +350 -0
  173. package/src/server/__tests__/native-sub-agent-observer.test.ts +470 -662
  174. package/src/server/__tests__/native-usage-attribution.integration.test.ts +175 -0
  175. package/src/server/__tests__/skill-access-service.test.ts +64 -64
  176. package/src/server/__tests__/skill-execute.test.ts +70 -70
  177. package/src/server/__tests__/skill-execution-task-policy.test.ts +140 -140
  178. package/src/server/__tests__/skill-sandbox-worker-mode.test.ts +15 -15
  179. package/src/server/__tests__/skill-settings.test.ts +63 -63
  180. package/src/server/__tests__/skill-tool-name.test.ts +23 -23
  181. package/src/server/__tests__/token-tracker.test.ts +639 -0
  182. package/src/server/__tests__/tool-loop-detection.test.ts +276 -276
  183. package/src/server/__tests__/tracing-retention-policy.test.ts +37 -0
  184. package/src/server/__tests__/usage-ledger.integration.test.ts +194 -0
  185. package/src/server/collections/agent-execution-spans.ts +393 -245
  186. package/src/server/collections/agent-governance-audit-events.ts +26 -0
  187. package/src/server/collections/agent-governance-policies.ts +26 -0
  188. package/src/server/collections/agent-governance-policy-versions.ts +27 -0
  189. package/src/server/collections/agent-governance-prompt-bindings.ts +29 -0
  190. package/src/server/collections/agent-loop-action-approvals.ts +39 -39
  191. package/src/server/collections/agent-loop-runs.ts +396 -369
  192. package/src/server/collections/agent-loop-steps.ts +220 -220
  193. package/src/server/collections/agent-memory-contexts.ts +95 -95
  194. package/src/server/collections/orchestrator-config.ts +87 -87
  195. package/src/server/collections/orchestrator-logs.ts +116 -116
  196. package/src/server/collections/skill-definitions.ts +159 -159
  197. package/src/server/collections/skill-executions.ts +154 -154
  198. package/src/server/collections/skill-loop-configs.ts +65 -65
  199. package/src/server/collections/skill-metrics.ts +36 -36
  200. package/src/server/collections/skill-registry-installations.ts +41 -41
  201. package/src/server/collections/skill-worker-configs.ts +86 -86
  202. package/src/server/index.ts +1 -1
  203. package/src/server/migrations/20260423000000-add-progress-fields.ts +50 -50
  204. package/src/server/migrations/20260425000000-add-interaction-schema.ts +37 -37
  205. package/src/server/migrations/20260427000000-add-tracing-detail-fields.ts +41 -41
  206. package/src/server/migrations/20260427000001-change-other-json-to-text.ts +61 -61
  207. package/src/server/migrations/20260524001000-add-plan-approval-and-harness-profiles.ts +145 -145
  208. package/src/server/migrations/20260601000000-add-token-fields.ts +89 -89
  209. package/src/server/migrations/20260615000000-normalize-ai-employee-tool-bindings.ts +39 -39
  210. package/src/server/migrations/20260621000000-native-policy-profile-defaults.ts +190 -190
  211. package/src/server/migrations/20260727000000-remove-unused-knowledge-scopes.ts +25 -25
  212. package/src/server/migrations/20260727010000-backfill-skill-tool-names.ts +45 -45
  213. package/src/server/migrations/20261110000000-add-usage-pricing-snapshots.ts +117 -0
  214. package/src/server/migrations/20261110010000-add-usage-department-attribution.ts +35 -0
  215. package/src/server/plugin.ts +674 -573
  216. package/src/server/resources/agent-governance.ts +168 -0
  217. package/src/server/resources/agent-harness-profile.ts +110 -94
  218. package/src/server/resources/agent-knowledge-insights.ts +306 -306
  219. package/src/server/resources/agent-loop-approval.ts +84 -84
  220. package/src/server/resources/agent-loop-events-stream.ts +108 -108
  221. package/src/server/resources/agent-loop.ts +252 -252
  222. package/src/server/resources/agent-monitor.ts +215 -482
  223. package/src/server/resources/agent-usage.ts +420 -0
  224. package/src/server/resources/native-monitor-format.ts +157 -0
  225. package/src/server/resources/tracing.ts +303 -267
  226. package/src/server/services/AgentExecutionContext.ts +23 -23
  227. package/src/server/services/AgentGovernanceService.ts +548 -0
  228. package/src/server/services/AgentMemoryContextService.ts +344 -344
  229. package/src/server/services/AgentRegistryService.ts +220 -220
  230. package/src/server/services/AgentRuntimeLifecycle.ts +64 -64
  231. package/src/server/services/CodeValidator.ts +238 -238
  232. package/src/server/services/DepartmentAttribution.ts +54 -0
  233. package/src/server/services/DurableCircuitBreakerService.ts +235 -235
  234. package/src/server/services/ExecutionSpanService.ts +278 -146
  235. package/src/server/services/FileManager.ts +159 -159
  236. package/src/server/services/GovernanceAdmission.ts +239 -0
  237. package/src/server/services/HarnessCapabilities.ts +119 -0
  238. package/src/server/services/HarnessCompiler.ts +170 -170
  239. package/src/server/services/HarnessProfileService.ts +235 -235
  240. package/src/server/services/HarnessSchema.ts +194 -194
  241. package/src/server/services/InputSchemaValidator.ts +44 -44
  242. package/src/server/services/LoopBudgetService.ts +332 -271
  243. package/src/server/services/LoopControlService.ts +120 -120
  244. package/src/server/services/LoopPatternSchema.ts +231 -231
  245. package/src/server/services/LoopPatternService.ts +171 -171
  246. package/src/server/services/LoopRunRepository.ts +350 -332
  247. package/src/server/services/LoopRunStateMachine.ts +545 -525
  248. package/src/server/services/LoopSchedulerService.ts +195 -195
  249. package/src/server/services/LoopTriggerService.ts +169 -159
  250. package/src/server/services/LoopWorkerService.ts +986 -912
  251. package/src/server/services/ManagedPromptProtection.ts +88 -0
  252. package/src/server/services/NativeAgentMonitorSyncService.ts +691 -0
  253. package/src/server/services/NativeSubAgentObserver.ts +331 -757
  254. package/src/server/services/NativeUsageAttribution.ts +98 -0
  255. package/src/server/services/PathLockService.ts +317 -317
  256. package/src/server/services/PluginAiRuntimeAdapter.ts +387 -387
  257. package/src/server/services/RunEventBus.ts +58 -58
  258. package/src/server/services/SandboxRunner.ts +492 -492
  259. package/src/server/services/SkillAccessService.ts +175 -175
  260. package/src/server/services/SkillManager.ts +585 -585
  261. package/src/server/services/SkillRepositoryService.ts +236 -236
  262. package/src/server/services/TokenTracker.ts +1158 -287
  263. package/src/server/services/ToolLoopDetectionService.ts +210 -210
  264. package/src/server/services/TracingRetentionPolicy.ts +56 -0
  265. package/src/server/services/VerificationSchema.ts +31 -31
  266. package/src/server/services/VerificationService.ts +332 -313
  267. package/src/server/services/WorkerEnvManager.ts +198 -198
  268. package/src/server/services/__tests__/SkillRepositoryService.test.ts +33 -33
  269. package/src/server/services/harness-runtime-policy.ts +134 -134
  270. package/src/server/services/pythonGuardTemplate.ts +87 -87
  271. package/src/server/services/sandboxCapabilities.ts +348 -348
  272. package/src/server/skill-hub/actions/__tests__/git-import.test.ts +563 -563
  273. package/src/server/skill-hub/actions/git-import.ts +936 -936
  274. package/src/server/skill-hub/mcp/McpController.ts +107 -107
  275. package/src/server/skill-hub/middlewares/git-import-request-method-policy.ts +51 -51
  276. package/src/server/skill-hub/plugin.ts +1232 -1232
  277. package/src/server/skill-hub/sandbox-config.json +6 -6
  278. package/src/server/skill-hub/services/RegistrySkillInstallationService.ts +281 -281
  279. package/src/server/skill-hub/services/__tests__/RegistrySkillInstallationService.test.ts +295 -295
  280. package/src/server/skill-hub/tasks/SkillExecutionTask.ts +568 -568
  281. package/src/server/skill-hub/utils/json-fields.ts +57 -57
  282. package/src/server/tools/delegate-task.ts +30 -30
  283. package/src/server/tools/external-rag-search.ts +329 -329
  284. package/src/server/tools/skill-execute.ts +216 -216
  285. package/src/server/types.ts +21 -21
  286. package/src/server/utils/ai-manager.ts +24 -24
  287. package/src/server/utils/ctx-utils.ts +132 -132
  288. package/src/server/utils/ensure-indexes.ts +119 -96
  289. package/src/server/utils/ha-lock.ts +80 -80
  290. package/src/server/utils/loop-pattern-context.ts +84 -84
  291. package/src/server/utils/record-utils.ts +19 -19
  292. package/src/server/utils/skill-settings.ts +135 -135
  293. package/src/server/utils/skill-tool-name.ts +58 -58
  294. package/dist/client-v2/117.7565cff57c39318a.js +0 -10
  295. package/dist/client-v2/214.106635011859dede.js +0 -10
  296. package/dist/client-v2/253.59577b40d9875be0.js +0 -10
  297. package/dist/client-v2/264.7ed8bee71fa5935c.js +0 -10
  298. package/dist/client-v2/418.41ed200e7d6da332.js +0 -10
  299. package/dist/client-v2/794.a67a2614405ba627.js +0 -10
  300. package/dist/client-v2/993.b0688fdc5ccb000a.js +0 -10
  301. package/dist/node_modules/simple-git/dist/cjs/index.js +0 -7399
  302. package/dist/node_modules/simple-git/dist/esm/index.js +0 -4745
  303. package/dist/node_modules/simple-git/dist/esm/package.json +0 -3
  304. package/dist/node_modules/simple-git/dist/src/lib/api.d.ts +0 -13
  305. package/dist/node_modules/simple-git/dist/src/lib/args/log-format.d.ts +0 -9
  306. package/dist/node_modules/simple-git/dist/src/lib/errors/git-construct-error.d.ts +0 -15
  307. package/dist/node_modules/simple-git/dist/src/lib/errors/git-error.d.ts +0 -30
  308. package/dist/node_modules/simple-git/dist/src/lib/errors/git-plugin-error.d.ts +0 -7
  309. package/dist/node_modules/simple-git/dist/src/lib/errors/git-response-error.d.ts +0 -32
  310. package/dist/node_modules/simple-git/dist/src/lib/errors/task-configuration-error.d.ts +0 -12
  311. package/dist/node_modules/simple-git/dist/src/lib/git-factory.d.ts +0 -15
  312. package/dist/node_modules/simple-git/dist/src/lib/git-logger.d.ts +0 -21
  313. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-branch-delete.d.ts +0 -5
  314. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-branch.d.ts +0 -2
  315. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-commit.d.ts +0 -2
  316. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-diff-summary.d.ts +0 -3
  317. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-fetch.d.ts +0 -2
  318. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-list-log-summary.d.ts +0 -6
  319. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-merge.d.ts +0 -11
  320. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-move.d.ts +0 -2
  321. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-pull.d.ts +0 -6
  322. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-push.d.ts +0 -4
  323. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-remote-messages.d.ts +0 -5
  324. package/dist/node_modules/simple-git/dist/src/lib/parsers/parse-remote-objects.d.ts +0 -3
  325. package/dist/node_modules/simple-git/dist/src/lib/plugins/abort-plugin.d.ts +0 -3
  326. package/dist/node_modules/simple-git/dist/src/lib/plugins/block-unsafe-operations-plugin.d.ts +0 -3
  327. package/dist/node_modules/simple-git/dist/src/lib/plugins/command-config-prefixing-plugin.d.ts +0 -2
  328. package/dist/node_modules/simple-git/dist/src/lib/plugins/completion-detection.plugin.d.ts +0 -3
  329. package/dist/node_modules/simple-git/dist/src/lib/plugins/custom-binary.plugin.d.ts +0 -3
  330. package/dist/node_modules/simple-git/dist/src/lib/plugins/error-detection.plugin.d.ts +0 -7
  331. package/dist/node_modules/simple-git/dist/src/lib/plugins/index.d.ts +0 -11
  332. package/dist/node_modules/simple-git/dist/src/lib/plugins/plugin-store.d.ts +0 -11
  333. package/dist/node_modules/simple-git/dist/src/lib/plugins/progress-monitor-plugin.d.ts +0 -3
  334. package/dist/node_modules/simple-git/dist/src/lib/plugins/simple-git-plugin.d.ts +0 -48
  335. package/dist/node_modules/simple-git/dist/src/lib/plugins/spawn-options-plugin.d.ts +0 -3
  336. package/dist/node_modules/simple-git/dist/src/lib/plugins/suffix-paths.plugin.d.ts +0 -2
  337. package/dist/node_modules/simple-git/dist/src/lib/plugins/timout-plugin.d.ts +0 -3
  338. package/dist/node_modules/simple-git/dist/src/lib/responses/BranchDeleteSummary.d.ts +0 -12
  339. package/dist/node_modules/simple-git/dist/src/lib/responses/BranchSummary.d.ts +0 -14
  340. package/dist/node_modules/simple-git/dist/src/lib/responses/CheckIgnore.d.ts +0 -4
  341. package/dist/node_modules/simple-git/dist/src/lib/responses/CleanSummary.d.ts +0 -9
  342. package/dist/node_modules/simple-git/dist/src/lib/responses/ConfigList.d.ts +0 -13
  343. package/dist/node_modules/simple-git/dist/src/lib/responses/DiffSummary.d.ts +0 -10
  344. package/dist/node_modules/simple-git/dist/src/lib/responses/FileStatusSummary.d.ts +0 -9
  345. package/dist/node_modules/simple-git/dist/src/lib/responses/GetRemoteSummary.d.ts +0 -11
  346. package/dist/node_modules/simple-git/dist/src/lib/responses/InitSummary.d.ts +0 -9
  347. package/dist/node_modules/simple-git/dist/src/lib/responses/MergeSummary.d.ts +0 -16
  348. package/dist/node_modules/simple-git/dist/src/lib/responses/PullSummary.d.ts +0 -25
  349. package/dist/node_modules/simple-git/dist/src/lib/responses/StatusSummary.d.ts +0 -19
  350. package/dist/node_modules/simple-git/dist/src/lib/responses/TagList.d.ts +0 -7
  351. package/dist/node_modules/simple-git/dist/src/lib/runners/git-executor-chain.d.ts +0 -25
  352. package/dist/node_modules/simple-git/dist/src/lib/runners/git-executor.d.ts +0 -14
  353. package/dist/node_modules/simple-git/dist/src/lib/runners/promise-wrapped.d.ts +0 -2
  354. package/dist/node_modules/simple-git/dist/src/lib/runners/scheduler.d.ts +0 -11
  355. package/dist/node_modules/simple-git/dist/src/lib/runners/tasks-pending-queue.d.ts +0 -23
  356. package/dist/node_modules/simple-git/dist/src/lib/simple-git-api.d.ts +0 -20
  357. package/dist/node_modules/simple-git/dist/src/lib/task-callback.d.ts +0 -2
  358. package/dist/node_modules/simple-git/dist/src/lib/tasks/apply-patch.d.ts +0 -3
  359. package/dist/node_modules/simple-git/dist/src/lib/tasks/branch.d.ts +0 -7
  360. package/dist/node_modules/simple-git/dist/src/lib/tasks/change-working-directory.d.ts +0 -2
  361. package/dist/node_modules/simple-git/dist/src/lib/tasks/check-ignore.d.ts +0 -2
  362. package/dist/node_modules/simple-git/dist/src/lib/tasks/check-is-repo.d.ts +0 -9
  363. package/dist/node_modules/simple-git/dist/src/lib/tasks/checkout.d.ts +0 -2
  364. package/dist/node_modules/simple-git/dist/src/lib/tasks/clean.d.ts +0 -25
  365. package/dist/node_modules/simple-git/dist/src/lib/tasks/clone.d.ts +0 -9
  366. package/dist/node_modules/simple-git/dist/src/lib/tasks/commit.d.ts +0 -4
  367. package/dist/node_modules/simple-git/dist/src/lib/tasks/config.d.ts +0 -8
  368. package/dist/node_modules/simple-git/dist/src/lib/tasks/count-objects.d.ts +0 -12
  369. package/dist/node_modules/simple-git/dist/src/lib/tasks/diff-name-status.d.ts +0 -12
  370. package/dist/node_modules/simple-git/dist/src/lib/tasks/diff.d.ts +0 -5
  371. package/dist/node_modules/simple-git/dist/src/lib/tasks/fetch.d.ts +0 -4
  372. package/dist/node_modules/simple-git/dist/src/lib/tasks/first-commit.d.ts +0 -2
  373. package/dist/node_modules/simple-git/dist/src/lib/tasks/grep.d.ts +0 -12
  374. package/dist/node_modules/simple-git/dist/src/lib/tasks/hash-object.d.ts +0 -5
  375. package/dist/node_modules/simple-git/dist/src/lib/tasks/init.d.ts +0 -3
  376. package/dist/node_modules/simple-git/dist/src/lib/tasks/log.d.ts +0 -32
  377. package/dist/node_modules/simple-git/dist/src/lib/tasks/merge.d.ts +0 -4
  378. package/dist/node_modules/simple-git/dist/src/lib/tasks/move.d.ts +0 -3
  379. package/dist/node_modules/simple-git/dist/src/lib/tasks/pull.d.ts +0 -3
  380. package/dist/node_modules/simple-git/dist/src/lib/tasks/push.d.ts +0 -9
  381. package/dist/node_modules/simple-git/dist/src/lib/tasks/remote.d.ts +0 -8
  382. package/dist/node_modules/simple-git/dist/src/lib/tasks/reset.d.ts +0 -11
  383. package/dist/node_modules/simple-git/dist/src/lib/tasks/show.d.ts +0 -2
  384. package/dist/node_modules/simple-git/dist/src/lib/tasks/stash-list.d.ts +0 -4
  385. package/dist/node_modules/simple-git/dist/src/lib/tasks/status.d.ts +0 -3
  386. package/dist/node_modules/simple-git/dist/src/lib/tasks/sub-module.d.ts +0 -5
  387. package/dist/node_modules/simple-git/dist/src/lib/tasks/tag.d.ts +0 -18
  388. package/dist/node_modules/simple-git/dist/src/lib/tasks/task.d.ts +0 -14
  389. package/dist/node_modules/simple-git/dist/src/lib/tasks/version.d.ts +0 -9
  390. package/dist/node_modules/simple-git/dist/src/lib/types/handlers.d.ts +0 -21
  391. package/dist/node_modules/simple-git/dist/src/lib/types/index.d.ts +0 -136
  392. package/dist/node_modules/simple-git/dist/src/lib/types/tasks.d.ts +0 -19
  393. package/dist/node_modules/simple-git/dist/src/lib/utils/argument-filters.d.ts +0 -14
  394. package/dist/node_modules/simple-git/dist/src/lib/utils/exit-codes.d.ts +0 -10
  395. package/dist/node_modules/simple-git/dist/src/lib/utils/git-output-streams.d.ts +0 -7
  396. package/dist/node_modules/simple-git/dist/src/lib/utils/index.d.ts +0 -8
  397. package/dist/node_modules/simple-git/dist/src/lib/utils/line-parser.d.ts +0 -15
  398. package/dist/node_modules/simple-git/dist/src/lib/utils/simple-git-options.d.ts +0 -2
  399. package/dist/node_modules/simple-git/dist/src/lib/utils/task-options.d.ts +0 -13
  400. package/dist/node_modules/simple-git/dist/src/lib/utils/task-parser.d.ts +0 -5
  401. package/dist/node_modules/simple-git/dist/src/lib/utils/util.d.ts +0 -47
  402. package/dist/node_modules/simple-git/dist/typings/errors.d.ts +0 -5
  403. package/dist/node_modules/simple-git/dist/typings/index.d.ts +0 -14
  404. package/dist/node_modules/simple-git/dist/typings/response.d.ts +0 -556
  405. package/dist/node_modules/simple-git/dist/typings/simple-git.d.ts +0 -1033
  406. package/dist/node_modules/simple-git/dist/typings/types.d.ts +0 -22
  407. package/dist/node_modules/simple-git/node_modules/debug/package.json +0 -64
  408. package/dist/node_modules/simple-git/node_modules/debug/src/browser.js +0 -272
  409. package/dist/node_modules/simple-git/node_modules/debug/src/common.js +0 -292
  410. package/dist/node_modules/simple-git/node_modules/debug/src/index.js +0 -10
  411. package/dist/node_modules/simple-git/node_modules/debug/src/node.js +0 -263
  412. package/dist/node_modules/simple-git/package.json +0 -1
  413. package/dist/node_modules/simple-git/promise.js +0 -17
@@ -1,563 +1,563 @@
1
- import type { Context } from '@nocobase/actions';
2
-
3
- import { GIT_SKILL_MARKDOWN_LIMITS, gitListSkills, gitSyncSkills } from '../git-import';
4
- import { createGitImportRequestMethodPolicy } from '../../middlewares/git-import-request-method-policy';
5
-
6
- const commitSha = 'a'.repeat(40);
7
- const actor = { kind: 'user' as const, roles: ['developer'] };
8
-
9
- type GitEntry = { type: 'blob' | 'tree'; path: string; size: number };
10
-
11
- type SkillDefinitionsRepository = {
12
- find?: ReturnType<typeof vi.fn>;
13
- findOne: ReturnType<typeof vi.fn>;
14
- create?: ReturnType<typeof vi.fn>;
15
- };
16
-
17
- type ContentService = {
18
- contractVersion: number;
19
- capabilities: string[];
20
- resolveCommit: ReturnType<typeof vi.fn>;
21
- listTree: ReturnType<typeof vi.fn>;
22
- readFile: ReturnType<typeof vi.fn>;
23
- };
24
-
25
- type TestContext = {
26
- context: Context;
27
- getRepository: ReturnType<typeof vi.fn>;
28
- skillDefinitions: SkillDefinitionsRepository;
29
- };
30
-
31
- function gitError(code: string, message = code): Error & { code: string } {
32
- const error = new Error(message) as Error & { code: string };
33
- error.code = code;
34
- return error;
35
- }
36
-
37
- function httpError(status: number, message: string): Error & { status: number } {
38
- const error = new Error(message) as Error & { status: number };
39
- error.status = status;
40
- return error;
41
- }
42
-
43
- function createContentService(input?: Partial<ContentService>): ContentService {
44
- return {
45
- contractVersion: 2,
46
- capabilities: ['skill-hub-content-with-actor'],
47
- resolveCommit: vi.fn().mockResolvedValue(commitSha),
48
- listTree: vi.fn().mockResolvedValue([]),
49
- readFile: vi.fn().mockResolvedValue(Buffer.from(JSON.stringify({ skills: [] }))),
50
- ...input,
51
- };
52
- }
53
-
54
- function skillsRootEntries(rootPath: string): GitEntry[] {
55
- if (rootPath === 'skills') {
56
- return [{ type: 'tree', path: 'alpha', size: 0 }];
57
- }
58
- if (rootPath === 'skills/alpha') {
59
- return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
60
- }
61
- return [];
62
- }
63
-
64
- function createContext(input: {
65
- service?: ContentService;
66
- params: Record<string, unknown>;
67
- skillDefinitions?: SkillDefinitionsRepository;
68
- }): TestContext {
69
- const skillDefinitions =
70
- input.skillDefinitions ||
71
- ({
72
- find: vi.fn().mockResolvedValue([]),
73
- findOne: vi.fn().mockResolvedValue(null),
74
- create: vi.fn().mockResolvedValue(undefined),
75
- } satisfies SkillDefinitionsRepository);
76
- const getRepository = vi.fn((name: string) => {
77
- if (name === 'gitRepositories') {
78
- throw new Error('Git repositories must only be read through Git Manager.');
79
- }
80
- if (name === 'skillDefinitions') {
81
- return skillDefinitions;
82
- }
83
- throw new Error(`Unexpected repository: ${name}`);
84
- });
85
- const context = {
86
- action: { params: input.params },
87
- state: { currentRoles: actor.roles },
88
- app: {
89
- pm: {
90
- get: vi.fn().mockReturnValue(input.service ? { skillHubContentService: input.service } : undefined),
91
- },
92
- },
93
- db: { getRepository },
94
- throw(status: number, message: string): never {
95
- throw httpError(status, message);
96
- },
97
- } as unknown as Context;
98
- return { context, getRepository, skillDefinitions };
99
- }
100
-
101
- function createMethodContext(actionName: 'gitListSkills' | 'gitSyncSkills', method: string) {
102
- const headers = new Map<string, string>();
103
- return {
104
- headers,
105
- method,
106
- action: { resourceName: 'skillHub', actionName, params: {} },
107
- set(name: string, value: string) {
108
- headers.set(name, value);
109
- },
110
- throw(status: number, message: string): never {
111
- throw httpError(status, message);
112
- },
113
- } as unknown as Context;
114
- }
115
-
116
- describe('Skill Hub Git import', () => {
117
- it('allows only GET/HEAD for listing and POST for syncing', async () => {
118
- const middleware = createGitImportRequestMethodPolicy();
119
- const next = vi.fn().mockResolvedValue(undefined);
120
-
121
- await middleware(createMethodContext('gitListSkills', 'GET'), next);
122
- await middleware(createMethodContext('gitListSkills', 'HEAD'), next);
123
- await middleware(createMethodContext('gitSyncSkills', 'POST'), next);
124
- expect(next).toHaveBeenCalledTimes(3);
125
-
126
- const rejectedList = createMethodContext('gitListSkills', 'POST');
127
- await expect(middleware(rejectedList, next)).rejects.toMatchObject({ status: 405 });
128
- expect((rejectedList as unknown as { headers: Map<string, string> }).headers.get('Allow')).toBe('GET, HEAD');
129
-
130
- const rejectedSync = createMethodContext('gitSyncSkills', 'GET');
131
- await expect(middleware(rejectedSync, next)).rejects.toMatchObject({ status: 405 });
132
- expect((rejectedSync as unknown as { headers: Map<string, string> }).headers.get('Allow')).toBe('POST');
133
- });
134
-
135
- it('lists skills through the actor-aware Git Manager service without reading gitRepositories', async () => {
136
- const service = createContentService({
137
- listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => skillsRootEntries(rootPath)),
138
- readFile: vi
139
- .fn()
140
- .mockResolvedValue(
141
- Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha', title: 'Alpha' }] })),
142
- ),
143
- });
144
- const { context, getRepository } = createContext({
145
- service,
146
- params: { repositoryId: 42, rootFolder: 'skills' },
147
- });
148
- const next = vi.fn().mockResolvedValue(undefined);
149
-
150
- await gitListSkills(context, next);
151
-
152
- expect(service.resolveCommit).toHaveBeenCalledWith(42, 'HEAD', actor);
153
- expect(service.readFile).toHaveBeenCalledWith(
154
- { repositoryId: 42, commitSha, filePath: 'skills/skills.json' },
155
- actor,
156
- );
157
- expect(getRepository).toHaveBeenCalledWith('skillDefinitions');
158
- expect(getRepository).not.toHaveBeenCalledWith('gitRepositories');
159
- expect((context as unknown as { body: { data: Array<{ name: string }> } }).body.data).toEqual([
160
- expect.objectContaining({ name: 'alpha', existsInDb: false }),
161
- ]);
162
- expect(next).toHaveBeenCalledOnce();
163
- });
164
-
165
- it('rejects a role outside the Git repository scope before any database read', async () => {
166
- const service = createContentService({
167
- resolveCommit: vi.fn().mockRejectedValue(gitError('SKILL_HUB_REPOSITORY_ACCESS_DENIED', 'Scope denied')),
168
- });
169
- const { context, getRepository } = createContext({
170
- service,
171
- params: { repositoryId: 42, rootFolder: 'skills' },
172
- });
173
-
174
- await expect(gitListSkills(context, vi.fn())).rejects.toMatchObject({ status: 403, message: 'Scope denied' });
175
- expect(getRepository).not.toHaveBeenCalled();
176
- expect(service.listTree).not.toHaveBeenCalled();
177
- expect(service.readFile).not.toHaveBeenCalled();
178
- });
179
-
180
- it('localizes Git Manager bridge setup errors', async () => {
181
- const { context } = createContext({ params: { repositoryId: 42, rootFolder: 'skills' } });
182
- const translate = vi.fn((key: string) => `localized:${key}`);
183
- (context as unknown as { t: typeof translate }).t = translate;
184
-
185
- await expect(gitListSkills(context, vi.fn())).rejects.toMatchObject({
186
- status: 424,
187
- message: 'localized:Git Manager is not enabled for Skill Hub imports.',
188
- });
189
- expect(translate).toHaveBeenCalledWith('Git Manager is not enabled for Skill Hub imports.', {
190
- ns: 'plugin-agent-orchestrator',
191
- });
192
- });
193
-
194
- it('uses a virtual manifest without writing a Git checkout when skills.json is missing', async () => {
195
- const service = createContentService({
196
- listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => skillsRootEntries(rootPath)),
197
- readFile: vi.fn().mockRejectedValue(gitError('REGISTRY_GIT_FILE_NOT_FOUND')),
198
- });
199
- const { context } = createContext({
200
- service,
201
- params: { repositoryId: 42, rootFolder: 'skills' },
202
- });
203
-
204
- await gitListSkills(context, vi.fn());
205
-
206
- const body = context as unknown as {
207
- body: { data: Array<{ name: string }>; config: { initializedSkillsJson: boolean } };
208
- };
209
- expect(body.body.data).toEqual([expect.objectContaining({ name: 'alpha' })]);
210
- expect(body.body.config.initializedSkillsJson).toBe(false);
211
- });
212
-
213
- it('uses the same actor and pinned commit when syncing a selected skill', async () => {
214
- const created: Array<Record<string, unknown>> = [];
215
- const service = createContentService({
216
- listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => skillsRootEntries(rootPath)),
217
- readFile: vi
218
- .fn()
219
- .mockResolvedValue(
220
- Buffer.from(JSON.stringify({ skills: [{ name: 'alpha', storageType: 'plugin', pluginSource: 'alpha' }] })),
221
- ),
222
- });
223
- const skillDefinitions: SkillDefinitionsRepository = {
224
- findOne: vi.fn().mockResolvedValue(null),
225
- create: vi.fn().mockImplementation(async ({ values }: { values: Record<string, unknown> }) => {
226
- created.push(values);
227
- }),
228
- };
229
- const { context, getRepository } = createContext({
230
- service,
231
- skillDefinitions,
232
- params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['alpha'] } },
233
- });
234
-
235
- await gitSyncSkills(context, vi.fn());
236
-
237
- expect(getRepository).not.toHaveBeenCalledWith('gitRepositories');
238
- expect(service.resolveCommit).toHaveBeenCalledWith(42, 'HEAD', actor);
239
- expect(service.readFile).toHaveBeenCalledWith(
240
- { repositoryId: 42, commitSha, filePath: 'skills/skills.json' },
241
- actor,
242
- );
243
- expect(created).toEqual([
244
- expect.objectContaining({ name: 'alpha', storageUrl: `git://42/skills@${commitSha}#alpha` }),
245
- ]);
246
- });
247
-
248
- it('rejects a selected key absent from an explicit skills.json manifest before writing a skill', async () => {
249
- const service = createContentService({
250
- listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => skillsRootEntries(rootPath)),
251
- readFile: vi
252
- .fn()
253
- .mockResolvedValue(Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha' }] }))),
254
- });
255
- const skillDefinitions: SkillDefinitionsRepository = {
256
- findOne: vi.fn(),
257
- create: vi.fn(),
258
- };
259
- const { context } = createContext({
260
- service,
261
- skillDefinitions,
262
- params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['unlisted'] } },
263
- });
264
-
265
- await expect(gitSyncSkills(context, vi.fn())).rejects.toMatchObject({
266
- status: 400,
267
- message: 'Selected skills are not listed in the explicit skills.json manifest: unlisted',
268
- });
269
- expect(skillDefinitions.findOne).not.toHaveBeenCalled();
270
- expect(skillDefinitions.create).not.toHaveBeenCalled();
271
- });
272
-
273
- it('allows a selected key from a virtual manifest when skills.json is absent', async () => {
274
- const service = createContentService({
275
- listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => skillsRootEntries(rootPath)),
276
- readFile: vi.fn().mockRejectedValue(gitError('REGISTRY_GIT_FILE_NOT_FOUND')),
277
- });
278
- const skillDefinitions: SkillDefinitionsRepository = {
279
- findOne: vi.fn().mockResolvedValue(null),
280
- create: vi.fn(),
281
- };
282
- const { context } = createContext({
283
- service,
284
- skillDefinitions,
285
- params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['alpha'] } },
286
- });
287
-
288
- await gitSyncSkills(context, vi.fn());
289
-
290
- expect(skillDefinitions.create).toHaveBeenCalledOnce();
291
- });
292
-
293
- it('rejects too many supplemental Markdown files before reading any of them', async () => {
294
- const supplementalFiles: GitEntry[] = Array.from(
295
- { length: GIT_SKILL_MARKDOWN_LIMITS.maxFiles + 1 },
296
- (_, index) => ({
297
- type: 'blob',
298
- path: `docs/${index}.md`,
299
- size: 1,
300
- }),
301
- );
302
- const service = createContentService({
303
- listTree: vi
304
- .fn()
305
- .mockImplementation(async ({ rootPath, recursive }: { rootPath: string; recursive: boolean }) => {
306
- if (rootPath === 'skills') return [{ type: 'tree', path: 'alpha', size: 0 }];
307
- if (rootPath === 'skills/alpha' && recursive) return supplementalFiles;
308
- if (rootPath === 'skills/alpha') return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
309
- return [];
310
- }),
311
- readFile: vi.fn().mockImplementation(async ({ filePath }: { filePath: string }) => {
312
- if (filePath === 'skills/skills.json') {
313
- return Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha' }] }));
314
- }
315
- if (filePath === 'skills/alpha/SKILL.md') {
316
- return Buffer.from('# Alpha');
317
- }
318
- throw new Error(`Unexpected file read: ${filePath}`);
319
- }),
320
- });
321
- const skillDefinitions: SkillDefinitionsRepository = {
322
- findOne: vi.fn(),
323
- create: vi.fn(),
324
- };
325
- const { context } = createContext({
326
- service,
327
- skillDefinitions,
328
- params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['alpha'] } },
329
- });
330
-
331
- await expect(gitSyncSkills(context, vi.fn())).rejects.toMatchObject({ status: 422 });
332
- expect(service.readFile).not.toHaveBeenCalledWith(
333
- expect.objectContaining({ filePath: 'skills/alpha/docs/0.md' }),
334
- actor,
335
- );
336
- expect(skillDefinitions.create).not.toHaveBeenCalled();
337
- });
338
-
339
- it('rejects supplemental Markdown whose declared aggregate size exceeds the import limit before reading it', async () => {
340
- const service = createContentService({
341
- listTree: vi
342
- .fn()
343
- .mockImplementation(async ({ rootPath, recursive }: { rootPath: string; recursive: boolean }) => {
344
- if (rootPath === 'skills') return [{ type: 'tree', path: 'alpha', size: 0 }];
345
- if (rootPath === 'skills/alpha' && recursive) {
346
- return [{ type: 'blob', path: 'GUIDE.md', size: GIT_SKILL_MARKDOWN_LIMITS.maxBytes }];
347
- }
348
- if (rootPath === 'skills/alpha') return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
349
- return [];
350
- }),
351
- readFile: vi.fn().mockImplementation(async ({ filePath }: { filePath: string }) => {
352
- if (filePath === 'skills/skills.json') {
353
- return Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha' }] }));
354
- }
355
- if (filePath === 'skills/alpha/SKILL.md') {
356
- return Buffer.from('# Alpha');
357
- }
358
- throw new Error(`Unexpected file read: ${filePath}`);
359
- }),
360
- });
361
- const skillDefinitions: SkillDefinitionsRepository = {
362
- findOne: vi.fn(),
363
- create: vi.fn(),
364
- };
365
- const { context } = createContext({
366
- service,
367
- skillDefinitions,
368
- params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['alpha'] } },
369
- });
370
-
371
- await expect(gitSyncSkills(context, vi.fn())).rejects.toMatchObject({ status: 422 });
372
- expect(service.readFile).not.toHaveBeenCalledWith(
373
- expect.objectContaining({ filePath: 'skills/alpha/GUIDE.md' }),
374
- actor,
375
- );
376
- expect(skillDefinitions.create).not.toHaveBeenCalled();
377
- });
378
-
379
- it('caps each supplemental Markdown read by the remaining aggregate budget', async () => {
380
- const service = createContentService({
381
- listTree: vi
382
- .fn()
383
- .mockImplementation(async ({ rootPath, recursive }: { rootPath: string; recursive: boolean }) => {
384
- if (rootPath === 'skills') return [{ type: 'tree', path: 'alpha', size: 0 }];
385
- if (rootPath === 'skills/alpha' && recursive) return [{ type: 'blob', path: 'GUIDE.md', size: 1 }];
386
- if (rootPath === 'skills/alpha') return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
387
- return [];
388
- }),
389
- readFile: vi.fn().mockImplementation(async ({ filePath }: { filePath: string }) => {
390
- if (filePath === 'skills/skills.json') {
391
- return Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha' }] }));
392
- }
393
- if (filePath === 'skills/alpha/SKILL.md') {
394
- return Buffer.from('# Alpha');
395
- }
396
- if (filePath === 'skills/alpha/GUIDE.md') {
397
- return Buffer.alloc(GIT_SKILL_MARKDOWN_LIMITS.maxBytes, 'a');
398
- }
399
- throw new Error(`Unexpected file read: ${filePath}`);
400
- }),
401
- });
402
- const skillDefinitions: SkillDefinitionsRepository = {
403
- findOne: vi.fn(),
404
- create: vi.fn(),
405
- };
406
- const { context } = createContext({
407
- service,
408
- skillDefinitions,
409
- params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['alpha'] } },
410
- });
411
-
412
- await expect(gitSyncSkills(context, vi.fn())).rejects.toMatchObject({ status: 422 });
413
- expect(service.readFile).toHaveBeenCalledWith(
414
- expect.objectContaining({
415
- filePath: 'skills/alpha/GUIDE.md',
416
- maxBytes: expect.any(Number),
417
- }),
418
- actor,
419
- );
420
- expect(skillDefinitions.create).not.toHaveBeenCalled();
421
- });
422
-
423
- it('does not convert an access denial during sync into a per-skill error', async () => {
424
- const service = createContentService({
425
- listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => skillsRootEntries(rootPath)),
426
- readFile: vi.fn().mockImplementation(async ({ filePath }: { filePath: string }) => {
427
- if (filePath === 'skills/skills.json') {
428
- return Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha' }] }));
429
- }
430
- throw gitError('SKILL_HUB_REPOSITORY_ACCESS_DENIED', 'Scope was revoked');
431
- }),
432
- });
433
- const skillDefinitions: SkillDefinitionsRepository = {
434
- findOne: vi.fn().mockResolvedValue(null),
435
- create: vi.fn(),
436
- };
437
- const { context } = createContext({
438
- service,
439
- skillDefinitions,
440
- params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['alpha'] } },
441
- });
442
-
443
- await expect(gitSyncSkills(context, vi.fn())).rejects.toMatchObject({ status: 403, message: 'Scope was revoked' });
444
- expect(skillDefinitions.create).not.toHaveBeenCalled();
445
- });
446
-
447
- it('requires the Skill Hub actor-aware Git Manager contract', async () => {
448
- const service = createContentService({
449
- contractVersion: 1,
450
- capabilities: ['registry-content-with-actor'],
451
- });
452
- const { context, getRepository } = createContext({
453
- service,
454
- params: { repositoryId: 42, rootFolder: 'skills' },
455
- });
456
-
457
- await expect(gitListSkills(context, vi.fn())).rejects.toMatchObject({ status: 424 });
458
- expect(getRepository).not.toHaveBeenCalled();
459
- expect(service.resolveCommit).not.toHaveBeenCalled();
460
- });
461
-
462
- it('uses the configured skills root before falling back to a nested skills folder', async () => {
463
- const service = createContentService({
464
- listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => {
465
- if (rootPath === 'agent-assets/skills') {
466
- return [{ type: 'tree', path: 'alpha', size: 0 }];
467
- }
468
- if (rootPath === 'agent-assets/skills/alpha') {
469
- return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
470
- }
471
- if (rootPath === 'agent-assets/skills/skills') {
472
- throw new Error('must not fall back to skills/skills');
473
- }
474
- return [];
475
- }),
476
- readFile: vi.fn().mockRejectedValue(gitError('REGISTRY_GIT_FILE_NOT_FOUND')),
477
- });
478
- const { context } = createContext({
479
- service,
480
- params: { repositoryId: 42, rootFolder: 'agent-assets/skills' },
481
- });
482
-
483
- await gitListSkills(context, vi.fn());
484
-
485
- expect(service.listTree).not.toHaveBeenCalledWith(
486
- expect.objectContaining({ rootPath: 'agent-assets/skills/skills' }),
487
- actor,
488
- );
489
- });
490
-
491
- it('falls back to a nested skills folder only when the configured root has no direct skill', async () => {
492
- const created: Array<Record<string, unknown>> = [];
493
- const service = createContentService({
494
- listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => {
495
- if (rootPath === 'agent-assets') {
496
- return [{ type: 'tree', path: 'skills', size: 0 }];
497
- }
498
- if (rootPath === 'agent-assets/skills') {
499
- return [{ type: 'tree', path: 'alpha', size: 0 }];
500
- }
501
- if (rootPath === 'agent-assets/skills/alpha') {
502
- return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
503
- }
504
- return [];
505
- }),
506
- readFile: vi.fn().mockImplementation(async ({ filePath }: { filePath: string }) => {
507
- if (filePath === 'agent-assets/skills/skills.json') {
508
- return Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha' }] }));
509
- }
510
- if (filePath === 'agent-assets/skills/alpha/SKILL.md') {
511
- return Buffer.from('# Alpha');
512
- }
513
- throw gitError('REGISTRY_GIT_FILE_NOT_FOUND');
514
- }),
515
- });
516
- const skillDefinitions: SkillDefinitionsRepository = {
517
- findOne: vi.fn().mockResolvedValue(null),
518
- create: vi.fn().mockImplementation(async ({ values }: { values: Record<string, unknown> }) => {
519
- created.push(values);
520
- }),
521
- };
522
- const { context } = createContext({
523
- service,
524
- skillDefinitions,
525
- params: { repositoryId: 42, rootFolder: 'agent-assets', values: { skills: ['alpha'] } },
526
- });
527
-
528
- await gitSyncSkills(context, vi.fn());
529
-
530
- expect(service.readFile).toHaveBeenCalledWith(
531
- expect.objectContaining({ filePath: 'agent-assets/skills/alpha/SKILL.md' }),
532
- actor,
533
- );
534
- expect(created).toEqual([
535
- expect.objectContaining({ name: 'alpha', storageUrl: `git://42/agent-assets/skills/alpha@${commitSha}` }),
536
- ]);
537
- });
538
-
539
- it('keeps a direct child folder named skills when the configured root already ends in skills', async () => {
540
- const service = createContentService({
541
- listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => {
542
- if (rootPath === 'agent-assets/skills') {
543
- return [{ type: 'tree', path: 'skills', size: 0 }];
544
- }
545
- if (rootPath === 'agent-assets/skills/skills') {
546
- return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
547
- }
548
- return [];
549
- }),
550
- readFile: vi.fn().mockRejectedValue(gitError('REGISTRY_GIT_FILE_NOT_FOUND')),
551
- });
552
- const { context } = createContext({
553
- service,
554
- params: { repositoryId: 42, rootFolder: 'agent-assets/skills' },
555
- });
556
-
557
- await gitListSkills(context, vi.fn());
558
-
559
- expect((context as unknown as { body: { data: Array<{ name: string }> } }).body.data).toEqual([
560
- expect.objectContaining({ name: 'skills' }),
561
- ]);
562
- });
563
- });
1
+ import type { Context } from '@nocobase/actions';
2
+
3
+ import { GIT_SKILL_MARKDOWN_LIMITS, gitListSkills, gitSyncSkills } from '../git-import';
4
+ import { createGitImportRequestMethodPolicy } from '../../middlewares/git-import-request-method-policy';
5
+
6
+ const commitSha = 'a'.repeat(40);
7
+ const actor = { kind: 'user' as const, roles: ['developer'] };
8
+
9
+ type GitEntry = { type: 'blob' | 'tree'; path: string; size: number };
10
+
11
+ type SkillDefinitionsRepository = {
12
+ find?: ReturnType<typeof vi.fn>;
13
+ findOne: ReturnType<typeof vi.fn>;
14
+ create?: ReturnType<typeof vi.fn>;
15
+ };
16
+
17
+ type ContentService = {
18
+ contractVersion: number;
19
+ capabilities: string[];
20
+ resolveCommit: ReturnType<typeof vi.fn>;
21
+ listTree: ReturnType<typeof vi.fn>;
22
+ readFile: ReturnType<typeof vi.fn>;
23
+ };
24
+
25
+ type TestContext = {
26
+ context: Context;
27
+ getRepository: ReturnType<typeof vi.fn>;
28
+ skillDefinitions: SkillDefinitionsRepository;
29
+ };
30
+
31
+ function gitError(code: string, message = code): Error & { code: string } {
32
+ const error = new Error(message) as Error & { code: string };
33
+ error.code = code;
34
+ return error;
35
+ }
36
+
37
+ function httpError(status: number, message: string): Error & { status: number } {
38
+ const error = new Error(message) as Error & { status: number };
39
+ error.status = status;
40
+ return error;
41
+ }
42
+
43
+ function createContentService(input?: Partial<ContentService>): ContentService {
44
+ return {
45
+ contractVersion: 2,
46
+ capabilities: ['skill-hub-content-with-actor'],
47
+ resolveCommit: vi.fn().mockResolvedValue(commitSha),
48
+ listTree: vi.fn().mockResolvedValue([]),
49
+ readFile: vi.fn().mockResolvedValue(Buffer.from(JSON.stringify({ skills: [] }))),
50
+ ...input,
51
+ };
52
+ }
53
+
54
+ function skillsRootEntries(rootPath: string): GitEntry[] {
55
+ if (rootPath === 'skills') {
56
+ return [{ type: 'tree', path: 'alpha', size: 0 }];
57
+ }
58
+ if (rootPath === 'skills/alpha') {
59
+ return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
60
+ }
61
+ return [];
62
+ }
63
+
64
+ function createContext(input: {
65
+ service?: ContentService;
66
+ params: Record<string, unknown>;
67
+ skillDefinitions?: SkillDefinitionsRepository;
68
+ }): TestContext {
69
+ const skillDefinitions =
70
+ input.skillDefinitions ||
71
+ ({
72
+ find: vi.fn().mockResolvedValue([]),
73
+ findOne: vi.fn().mockResolvedValue(null),
74
+ create: vi.fn().mockResolvedValue(undefined),
75
+ } satisfies SkillDefinitionsRepository);
76
+ const getRepository = vi.fn((name: string) => {
77
+ if (name === 'gitRepositories') {
78
+ throw new Error('Git repositories must only be read through Git Manager.');
79
+ }
80
+ if (name === 'skillDefinitions') {
81
+ return skillDefinitions;
82
+ }
83
+ throw new Error(`Unexpected repository: ${name}`);
84
+ });
85
+ const context = {
86
+ action: { params: input.params },
87
+ state: { currentRoles: actor.roles },
88
+ app: {
89
+ pm: {
90
+ get: vi.fn().mockReturnValue(input.service ? { skillHubContentService: input.service } : undefined),
91
+ },
92
+ },
93
+ db: { getRepository },
94
+ throw(status: number, message: string): never {
95
+ throw httpError(status, message);
96
+ },
97
+ } as unknown as Context;
98
+ return { context, getRepository, skillDefinitions };
99
+ }
100
+
101
+ function createMethodContext(actionName: 'gitListSkills' | 'gitSyncSkills', method: string) {
102
+ const headers = new Map<string, string>();
103
+ return {
104
+ headers,
105
+ method,
106
+ action: { resourceName: 'skillHub', actionName, params: {} },
107
+ set(name: string, value: string) {
108
+ headers.set(name, value);
109
+ },
110
+ throw(status: number, message: string): never {
111
+ throw httpError(status, message);
112
+ },
113
+ } as unknown as Context;
114
+ }
115
+
116
+ describe('Skill Hub Git import', () => {
117
+ it('allows only GET/HEAD for listing and POST for syncing', async () => {
118
+ const middleware = createGitImportRequestMethodPolicy();
119
+ const next = vi.fn().mockResolvedValue(undefined);
120
+
121
+ await middleware(createMethodContext('gitListSkills', 'GET'), next);
122
+ await middleware(createMethodContext('gitListSkills', 'HEAD'), next);
123
+ await middleware(createMethodContext('gitSyncSkills', 'POST'), next);
124
+ expect(next).toHaveBeenCalledTimes(3);
125
+
126
+ const rejectedList = createMethodContext('gitListSkills', 'POST');
127
+ await expect(middleware(rejectedList, next)).rejects.toMatchObject({ status: 405 });
128
+ expect((rejectedList as unknown as { headers: Map<string, string> }).headers.get('Allow')).toBe('GET, HEAD');
129
+
130
+ const rejectedSync = createMethodContext('gitSyncSkills', 'GET');
131
+ await expect(middleware(rejectedSync, next)).rejects.toMatchObject({ status: 405 });
132
+ expect((rejectedSync as unknown as { headers: Map<string, string> }).headers.get('Allow')).toBe('POST');
133
+ });
134
+
135
+ it('lists skills through the actor-aware Git Manager service without reading gitRepositories', async () => {
136
+ const service = createContentService({
137
+ listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => skillsRootEntries(rootPath)),
138
+ readFile: vi
139
+ .fn()
140
+ .mockResolvedValue(
141
+ Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha', title: 'Alpha' }] })),
142
+ ),
143
+ });
144
+ const { context, getRepository } = createContext({
145
+ service,
146
+ params: { repositoryId: 42, rootFolder: 'skills' },
147
+ });
148
+ const next = vi.fn().mockResolvedValue(undefined);
149
+
150
+ await gitListSkills(context, next);
151
+
152
+ expect(service.resolveCommit).toHaveBeenCalledWith(42, 'HEAD', actor);
153
+ expect(service.readFile).toHaveBeenCalledWith(
154
+ { repositoryId: 42, commitSha, filePath: 'skills/skills.json' },
155
+ actor,
156
+ );
157
+ expect(getRepository).toHaveBeenCalledWith('skillDefinitions');
158
+ expect(getRepository).not.toHaveBeenCalledWith('gitRepositories');
159
+ expect((context as unknown as { body: { data: Array<{ name: string }> } }).body.data).toEqual([
160
+ expect.objectContaining({ name: 'alpha', existsInDb: false }),
161
+ ]);
162
+ expect(next).toHaveBeenCalledOnce();
163
+ });
164
+
165
+ it('rejects a role outside the Git repository scope before any database read', async () => {
166
+ const service = createContentService({
167
+ resolveCommit: vi.fn().mockRejectedValue(gitError('SKILL_HUB_REPOSITORY_ACCESS_DENIED', 'Scope denied')),
168
+ });
169
+ const { context, getRepository } = createContext({
170
+ service,
171
+ params: { repositoryId: 42, rootFolder: 'skills' },
172
+ });
173
+
174
+ await expect(gitListSkills(context, vi.fn())).rejects.toMatchObject({ status: 403, message: 'Scope denied' });
175
+ expect(getRepository).not.toHaveBeenCalled();
176
+ expect(service.listTree).not.toHaveBeenCalled();
177
+ expect(service.readFile).not.toHaveBeenCalled();
178
+ });
179
+
180
+ it('localizes Git Manager bridge setup errors', async () => {
181
+ const { context } = createContext({ params: { repositoryId: 42, rootFolder: 'skills' } });
182
+ const translate = vi.fn((key: string) => `localized:${key}`);
183
+ (context as unknown as { t: typeof translate }).t = translate;
184
+
185
+ await expect(gitListSkills(context, vi.fn())).rejects.toMatchObject({
186
+ status: 424,
187
+ message: 'localized:Git Manager is not enabled for Skill Hub imports.',
188
+ });
189
+ expect(translate).toHaveBeenCalledWith('Git Manager is not enabled for Skill Hub imports.', {
190
+ ns: 'plugin-agent-orchestrator',
191
+ });
192
+ });
193
+
194
+ it('uses a virtual manifest without writing a Git checkout when skills.json is missing', async () => {
195
+ const service = createContentService({
196
+ listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => skillsRootEntries(rootPath)),
197
+ readFile: vi.fn().mockRejectedValue(gitError('REGISTRY_GIT_FILE_NOT_FOUND')),
198
+ });
199
+ const { context } = createContext({
200
+ service,
201
+ params: { repositoryId: 42, rootFolder: 'skills' },
202
+ });
203
+
204
+ await gitListSkills(context, vi.fn());
205
+
206
+ const body = context as unknown as {
207
+ body: { data: Array<{ name: string }>; config: { initializedSkillsJson: boolean } };
208
+ };
209
+ expect(body.body.data).toEqual([expect.objectContaining({ name: 'alpha' })]);
210
+ expect(body.body.config.initializedSkillsJson).toBe(false);
211
+ });
212
+
213
+ it('uses the same actor and pinned commit when syncing a selected skill', async () => {
214
+ const created: Array<Record<string, unknown>> = [];
215
+ const service = createContentService({
216
+ listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => skillsRootEntries(rootPath)),
217
+ readFile: vi
218
+ .fn()
219
+ .mockResolvedValue(
220
+ Buffer.from(JSON.stringify({ skills: [{ name: 'alpha', storageType: 'plugin', pluginSource: 'alpha' }] })),
221
+ ),
222
+ });
223
+ const skillDefinitions: SkillDefinitionsRepository = {
224
+ findOne: vi.fn().mockResolvedValue(null),
225
+ create: vi.fn().mockImplementation(async ({ values }: { values: Record<string, unknown> }) => {
226
+ created.push(values);
227
+ }),
228
+ };
229
+ const { context, getRepository } = createContext({
230
+ service,
231
+ skillDefinitions,
232
+ params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['alpha'] } },
233
+ });
234
+
235
+ await gitSyncSkills(context, vi.fn());
236
+
237
+ expect(getRepository).not.toHaveBeenCalledWith('gitRepositories');
238
+ expect(service.resolveCommit).toHaveBeenCalledWith(42, 'HEAD', actor);
239
+ expect(service.readFile).toHaveBeenCalledWith(
240
+ { repositoryId: 42, commitSha, filePath: 'skills/skills.json' },
241
+ actor,
242
+ );
243
+ expect(created).toEqual([
244
+ expect.objectContaining({ name: 'alpha', storageUrl: `git://42/skills@${commitSha}#alpha` }),
245
+ ]);
246
+ });
247
+
248
+ it('rejects a selected key absent from an explicit skills.json manifest before writing a skill', async () => {
249
+ const service = createContentService({
250
+ listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => skillsRootEntries(rootPath)),
251
+ readFile: vi
252
+ .fn()
253
+ .mockResolvedValue(Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha' }] }))),
254
+ });
255
+ const skillDefinitions: SkillDefinitionsRepository = {
256
+ findOne: vi.fn(),
257
+ create: vi.fn(),
258
+ };
259
+ const { context } = createContext({
260
+ service,
261
+ skillDefinitions,
262
+ params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['unlisted'] } },
263
+ });
264
+
265
+ await expect(gitSyncSkills(context, vi.fn())).rejects.toMatchObject({
266
+ status: 400,
267
+ message: 'Selected skills are not listed in the explicit skills.json manifest: unlisted',
268
+ });
269
+ expect(skillDefinitions.findOne).not.toHaveBeenCalled();
270
+ expect(skillDefinitions.create).not.toHaveBeenCalled();
271
+ });
272
+
273
+ it('allows a selected key from a virtual manifest when skills.json is absent', async () => {
274
+ const service = createContentService({
275
+ listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => skillsRootEntries(rootPath)),
276
+ readFile: vi.fn().mockRejectedValue(gitError('REGISTRY_GIT_FILE_NOT_FOUND')),
277
+ });
278
+ const skillDefinitions: SkillDefinitionsRepository = {
279
+ findOne: vi.fn().mockResolvedValue(null),
280
+ create: vi.fn(),
281
+ };
282
+ const { context } = createContext({
283
+ service,
284
+ skillDefinitions,
285
+ params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['alpha'] } },
286
+ });
287
+
288
+ await gitSyncSkills(context, vi.fn());
289
+
290
+ expect(skillDefinitions.create).toHaveBeenCalledOnce();
291
+ });
292
+
293
+ it('rejects too many supplemental Markdown files before reading any of them', async () => {
294
+ const supplementalFiles: GitEntry[] = Array.from(
295
+ { length: GIT_SKILL_MARKDOWN_LIMITS.maxFiles + 1 },
296
+ (_, index) => ({
297
+ type: 'blob',
298
+ path: `docs/${index}.md`,
299
+ size: 1,
300
+ }),
301
+ );
302
+ const service = createContentService({
303
+ listTree: vi
304
+ .fn()
305
+ .mockImplementation(async ({ rootPath, recursive }: { rootPath: string; recursive: boolean }) => {
306
+ if (rootPath === 'skills') return [{ type: 'tree', path: 'alpha', size: 0 }];
307
+ if (rootPath === 'skills/alpha' && recursive) return supplementalFiles;
308
+ if (rootPath === 'skills/alpha') return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
309
+ return [];
310
+ }),
311
+ readFile: vi.fn().mockImplementation(async ({ filePath }: { filePath: string }) => {
312
+ if (filePath === 'skills/skills.json') {
313
+ return Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha' }] }));
314
+ }
315
+ if (filePath === 'skills/alpha/SKILL.md') {
316
+ return Buffer.from('# Alpha');
317
+ }
318
+ throw new Error(`Unexpected file read: ${filePath}`);
319
+ }),
320
+ });
321
+ const skillDefinitions: SkillDefinitionsRepository = {
322
+ findOne: vi.fn(),
323
+ create: vi.fn(),
324
+ };
325
+ const { context } = createContext({
326
+ service,
327
+ skillDefinitions,
328
+ params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['alpha'] } },
329
+ });
330
+
331
+ await expect(gitSyncSkills(context, vi.fn())).rejects.toMatchObject({ status: 422 });
332
+ expect(service.readFile).not.toHaveBeenCalledWith(
333
+ expect.objectContaining({ filePath: 'skills/alpha/docs/0.md' }),
334
+ actor,
335
+ );
336
+ expect(skillDefinitions.create).not.toHaveBeenCalled();
337
+ });
338
+
339
+ it('rejects supplemental Markdown whose declared aggregate size exceeds the import limit before reading it', async () => {
340
+ const service = createContentService({
341
+ listTree: vi
342
+ .fn()
343
+ .mockImplementation(async ({ rootPath, recursive }: { rootPath: string; recursive: boolean }) => {
344
+ if (rootPath === 'skills') return [{ type: 'tree', path: 'alpha', size: 0 }];
345
+ if (rootPath === 'skills/alpha' && recursive) {
346
+ return [{ type: 'blob', path: 'GUIDE.md', size: GIT_SKILL_MARKDOWN_LIMITS.maxBytes }];
347
+ }
348
+ if (rootPath === 'skills/alpha') return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
349
+ return [];
350
+ }),
351
+ readFile: vi.fn().mockImplementation(async ({ filePath }: { filePath: string }) => {
352
+ if (filePath === 'skills/skills.json') {
353
+ return Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha' }] }));
354
+ }
355
+ if (filePath === 'skills/alpha/SKILL.md') {
356
+ return Buffer.from('# Alpha');
357
+ }
358
+ throw new Error(`Unexpected file read: ${filePath}`);
359
+ }),
360
+ });
361
+ const skillDefinitions: SkillDefinitionsRepository = {
362
+ findOne: vi.fn(),
363
+ create: vi.fn(),
364
+ };
365
+ const { context } = createContext({
366
+ service,
367
+ skillDefinitions,
368
+ params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['alpha'] } },
369
+ });
370
+
371
+ await expect(gitSyncSkills(context, vi.fn())).rejects.toMatchObject({ status: 422 });
372
+ expect(service.readFile).not.toHaveBeenCalledWith(
373
+ expect.objectContaining({ filePath: 'skills/alpha/GUIDE.md' }),
374
+ actor,
375
+ );
376
+ expect(skillDefinitions.create).not.toHaveBeenCalled();
377
+ });
378
+
379
+ it('caps each supplemental Markdown read by the remaining aggregate budget', async () => {
380
+ const service = createContentService({
381
+ listTree: vi
382
+ .fn()
383
+ .mockImplementation(async ({ rootPath, recursive }: { rootPath: string; recursive: boolean }) => {
384
+ if (rootPath === 'skills') return [{ type: 'tree', path: 'alpha', size: 0 }];
385
+ if (rootPath === 'skills/alpha' && recursive) return [{ type: 'blob', path: 'GUIDE.md', size: 1 }];
386
+ if (rootPath === 'skills/alpha') return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
387
+ return [];
388
+ }),
389
+ readFile: vi.fn().mockImplementation(async ({ filePath }: { filePath: string }) => {
390
+ if (filePath === 'skills/skills.json') {
391
+ return Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha' }] }));
392
+ }
393
+ if (filePath === 'skills/alpha/SKILL.md') {
394
+ return Buffer.from('# Alpha');
395
+ }
396
+ if (filePath === 'skills/alpha/GUIDE.md') {
397
+ return Buffer.alloc(GIT_SKILL_MARKDOWN_LIMITS.maxBytes, 'a');
398
+ }
399
+ throw new Error(`Unexpected file read: ${filePath}`);
400
+ }),
401
+ });
402
+ const skillDefinitions: SkillDefinitionsRepository = {
403
+ findOne: vi.fn(),
404
+ create: vi.fn(),
405
+ };
406
+ const { context } = createContext({
407
+ service,
408
+ skillDefinitions,
409
+ params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['alpha'] } },
410
+ });
411
+
412
+ await expect(gitSyncSkills(context, vi.fn())).rejects.toMatchObject({ status: 422 });
413
+ expect(service.readFile).toHaveBeenCalledWith(
414
+ expect.objectContaining({
415
+ filePath: 'skills/alpha/GUIDE.md',
416
+ maxBytes: expect.any(Number),
417
+ }),
418
+ actor,
419
+ );
420
+ expect(skillDefinitions.create).not.toHaveBeenCalled();
421
+ });
422
+
423
+ it('does not convert an access denial during sync into a per-skill error', async () => {
424
+ const service = createContentService({
425
+ listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => skillsRootEntries(rootPath)),
426
+ readFile: vi.fn().mockImplementation(async ({ filePath }: { filePath: string }) => {
427
+ if (filePath === 'skills/skills.json') {
428
+ return Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha' }] }));
429
+ }
430
+ throw gitError('SKILL_HUB_REPOSITORY_ACCESS_DENIED', 'Scope was revoked');
431
+ }),
432
+ });
433
+ const skillDefinitions: SkillDefinitionsRepository = {
434
+ findOne: vi.fn().mockResolvedValue(null),
435
+ create: vi.fn(),
436
+ };
437
+ const { context } = createContext({
438
+ service,
439
+ skillDefinitions,
440
+ params: { repositoryId: 42, rootFolder: 'skills', values: { skills: ['alpha'] } },
441
+ });
442
+
443
+ await expect(gitSyncSkills(context, vi.fn())).rejects.toMatchObject({ status: 403, message: 'Scope was revoked' });
444
+ expect(skillDefinitions.create).not.toHaveBeenCalled();
445
+ });
446
+
447
+ it('requires the Skill Hub actor-aware Git Manager contract', async () => {
448
+ const service = createContentService({
449
+ contractVersion: 1,
450
+ capabilities: ['registry-content-with-actor'],
451
+ });
452
+ const { context, getRepository } = createContext({
453
+ service,
454
+ params: { repositoryId: 42, rootFolder: 'skills' },
455
+ });
456
+
457
+ await expect(gitListSkills(context, vi.fn())).rejects.toMatchObject({ status: 424 });
458
+ expect(getRepository).not.toHaveBeenCalled();
459
+ expect(service.resolveCommit).not.toHaveBeenCalled();
460
+ });
461
+
462
+ it('uses the configured skills root before falling back to a nested skills folder', async () => {
463
+ const service = createContentService({
464
+ listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => {
465
+ if (rootPath === 'agent-assets/skills') {
466
+ return [{ type: 'tree', path: 'alpha', size: 0 }];
467
+ }
468
+ if (rootPath === 'agent-assets/skills/alpha') {
469
+ return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
470
+ }
471
+ if (rootPath === 'agent-assets/skills/skills') {
472
+ throw new Error('must not fall back to skills/skills');
473
+ }
474
+ return [];
475
+ }),
476
+ readFile: vi.fn().mockRejectedValue(gitError('REGISTRY_GIT_FILE_NOT_FOUND')),
477
+ });
478
+ const { context } = createContext({
479
+ service,
480
+ params: { repositoryId: 42, rootFolder: 'agent-assets/skills' },
481
+ });
482
+
483
+ await gitListSkills(context, vi.fn());
484
+
485
+ expect(service.listTree).not.toHaveBeenCalledWith(
486
+ expect.objectContaining({ rootPath: 'agent-assets/skills/skills' }),
487
+ actor,
488
+ );
489
+ });
490
+
491
+ it('falls back to a nested skills folder only when the configured root has no direct skill', async () => {
492
+ const created: Array<Record<string, unknown>> = [];
493
+ const service = createContentService({
494
+ listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => {
495
+ if (rootPath === 'agent-assets') {
496
+ return [{ type: 'tree', path: 'skills', size: 0 }];
497
+ }
498
+ if (rootPath === 'agent-assets/skills') {
499
+ return [{ type: 'tree', path: 'alpha', size: 0 }];
500
+ }
501
+ if (rootPath === 'agent-assets/skills/alpha') {
502
+ return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
503
+ }
504
+ return [];
505
+ }),
506
+ readFile: vi.fn().mockImplementation(async ({ filePath }: { filePath: string }) => {
507
+ if (filePath === 'agent-assets/skills/skills.json') {
508
+ return Buffer.from(JSON.stringify({ skills: [{ folder: 'alpha', name: 'alpha' }] }));
509
+ }
510
+ if (filePath === 'agent-assets/skills/alpha/SKILL.md') {
511
+ return Buffer.from('# Alpha');
512
+ }
513
+ throw gitError('REGISTRY_GIT_FILE_NOT_FOUND');
514
+ }),
515
+ });
516
+ const skillDefinitions: SkillDefinitionsRepository = {
517
+ findOne: vi.fn().mockResolvedValue(null),
518
+ create: vi.fn().mockImplementation(async ({ values }: { values: Record<string, unknown> }) => {
519
+ created.push(values);
520
+ }),
521
+ };
522
+ const { context } = createContext({
523
+ service,
524
+ skillDefinitions,
525
+ params: { repositoryId: 42, rootFolder: 'agent-assets', values: { skills: ['alpha'] } },
526
+ });
527
+
528
+ await gitSyncSkills(context, vi.fn());
529
+
530
+ expect(service.readFile).toHaveBeenCalledWith(
531
+ expect.objectContaining({ filePath: 'agent-assets/skills/alpha/SKILL.md' }),
532
+ actor,
533
+ );
534
+ expect(created).toEqual([
535
+ expect.objectContaining({ name: 'alpha', storageUrl: `git://42/agent-assets/skills/alpha@${commitSha}` }),
536
+ ]);
537
+ });
538
+
539
+ it('keeps a direct child folder named skills when the configured root already ends in skills', async () => {
540
+ const service = createContentService({
541
+ listTree: vi.fn().mockImplementation(async ({ rootPath }: { rootPath: string }) => {
542
+ if (rootPath === 'agent-assets/skills') {
543
+ return [{ type: 'tree', path: 'skills', size: 0 }];
544
+ }
545
+ if (rootPath === 'agent-assets/skills/skills') {
546
+ return [{ type: 'blob', path: 'SKILL.md', size: 16 }];
547
+ }
548
+ return [];
549
+ }),
550
+ readFile: vi.fn().mockRejectedValue(gitError('REGISTRY_GIT_FILE_NOT_FOUND')),
551
+ });
552
+ const { context } = createContext({
553
+ service,
554
+ params: { repositoryId: 42, rootFolder: 'agent-assets/skills' },
555
+ });
556
+
557
+ await gitListSkills(context, vi.fn());
558
+
559
+ expect((context as unknown as { body: { data: Array<{ name: string }> } }).body.data).toEqual([
560
+ expect.objectContaining({ name: 'skills' }),
561
+ ]);
562
+ });
563
+ });