plugin-agent-orchestrator 1.1.4 → 1.1.6
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +204 -114
- package/dist/client/index.js +1 -1
- package/dist/client-v2/117.7565cff57c39318a.js +10 -0
- package/dist/client-v2/214.106635011859dede.js +10 -0
- package/dist/client-v2/418.41ed200e7d6da332.js +10 -0
- package/dist/client-v2/53.349fff8db80b19d4.js +10 -0
- package/dist/client-v2/981.e4a1f41cfc94a856.js +10 -0
- package/dist/client-v2/index.js +1 -1
- package/dist/externalVersion.js +7 -8
- package/dist/locale/en-US.json +226 -170
- package/dist/locale/vi-VN.json +226 -170
- package/dist/locale/zh-CN.json +226 -170
- package/dist/server/collections/agent-execution-spans.js +8 -0
- package/dist/server/collections/agent-loop-action-approvals.js +1 -0
- package/dist/server/collections/agent-loop-runs.js +7 -1
- package/dist/server/collections/agent-loop-steps.js +7 -0
- package/dist/server/collections/skill-executions.js +8 -0
- package/dist/server/plugin.js +3 -1
- package/dist/server/resources/agent-harness-profile.js +117 -0
- package/dist/server/resources/agent-knowledge-insights.js +1 -3
- package/dist/server/resources/agent-loop-approval.js +25 -0
- package/dist/server/resources/agent-loop.js +3 -1
- package/dist/server/services/AgentMemoryContextService.js +34 -0
- package/dist/server/services/HarnessCompiler.js +35 -2
- package/dist/server/services/HarnessProfileService.js +74 -9
- package/dist/server/services/HarnessSchema.js +30 -3
- package/dist/server/services/LoopPatternSchema.js +16 -1
- package/dist/server/services/LoopRunRepository.js +80 -0
- package/dist/server/services/LoopRunStateMachine.js +92 -3
- package/dist/server/services/LoopTriggerService.js +37 -0
- package/dist/server/services/LoopWorkerService.js +261 -23
- package/dist/server/services/NativeSubAgentObserver.js +165 -23
- package/dist/server/services/PluginAiRuntimeAdapter.js +16 -5
- package/dist/server/services/ToolLoopDetectionService.js +210 -0
- package/dist/server/services/VerificationService.js +66 -0
- package/dist/server/services/harness-runtime-policy.js +139 -0
- package/dist/server/skill-hub/plugin.js +36 -3
- package/dist/server/skill-hub/tasks/SkillExecutionTask.js +29 -0
- package/package.json +53 -53
- package/src/client/ApprovalsTab.tsx +2 -0
- package/src/client/OrchestratorSettings.tsx +11 -0
- package/src/client/skill-hub/components/GitSkillImport.tsx +3 -3
- package/src/client/skill-hub/components/SkillMetrics.tsx +15 -10
- package/src/client/skill-hub/index.tsx +0 -52
- package/src/client-v2/components/AgentRunsTab.tsx +576 -576
- package/src/client-v2/components/ApprovalsTab.tsx +337 -0
- package/src/client-v2/components/HarnessProfilesTab.tsx +385 -105
- package/src/client-v2/components/MemoryInspectorTab.tsx +141 -141
- package/src/client-v2/components/TracingTab.tsx +515 -515
- package/src/client-v2/hooks/useApiRequest.ts +141 -141
- package/src/client-v2/pages/ApprovalsPage.tsx +10 -0
- package/src/client-v2/plugin.tsx +6 -6
- package/src/client-v2/skill-hub/components/SkillMetrics.tsx +5 -2
- package/src/locale/en-US.json +226 -174
- package/src/locale/vi-VN.json +226 -174
- package/src/locale/zh-CN.json +226 -174
- package/src/server/__tests__/circuit-breaker.test.ts +248 -248
- package/src/server/__tests__/harness-compiler.test.ts +83 -0
- package/src/server/__tests__/harness-profile-service.test.ts +51 -0
- package/src/server/__tests__/harness-runtime-policy.test.ts +293 -0
- package/src/server/__tests__/harness-tool-plan.test.ts +24 -0
- package/src/server/__tests__/loop-approval-decision.test.ts +512 -0
- package/src/server/__tests__/loop-approval-expiry.test.ts +258 -0
- package/src/server/__tests__/loop-budget-service.test.ts +255 -255
- package/src/server/__tests__/loop-control-plane-backfill.test.ts +266 -266
- package/src/server/__tests__/loop-pattern-schema.test.ts +18 -1
- package/src/server/__tests__/loop-pattern-service.test.ts +148 -148
- package/src/server/__tests__/loop-run-state-machine.test.ts +11 -0
- package/src/server/__tests__/loop-trigger-service.test.ts +148 -0
- package/src/server/__tests__/loop-worker-claim.test.ts +341 -341
- package/src/server/__tests__/loop-worker-execution.test.ts +82 -1
- package/src/server/__tests__/native-sub-agent-observer.test.ts +288 -4
- package/src/server/__tests__/path-lock-service.test.ts +254 -254
- package/src/server/__tests__/skill-execution-task-policy.test.ts +140 -0
- package/src/server/__tests__/smoke.test.ts +162 -162
- package/src/server/__tests__/tool-loop-detection.test.ts +275 -0
- package/src/server/collections/agent-execution-spans.ts +8 -0
- package/src/server/collections/agent-harness-profile-versions.ts +26 -26
- package/src/server/collections/agent-harness-profiles.ts +71 -71
- package/src/server/collections/agent-loop-action-approvals.ts +1 -0
- package/src/server/collections/agent-loop-artifacts.ts +25 -25
- package/src/server/collections/agent-loop-circuit-states.ts +23 -23
- package/src/server/collections/agent-loop-control-settings.ts +21 -21
- package/src/server/collections/agent-loop-events.ts +98 -98
- package/src/server/collections/agent-loop-path-locks.ts +27 -27
- package/src/server/collections/agent-loop-patterns.ts +42 -42
- package/src/server/collections/agent-loop-runs.ts +7 -1
- package/src/server/collections/agent-loop-steps.ts +7 -0
- package/src/server/collections/agent-loop-usage-buckets.ts +22 -22
- package/src/server/collections/agent-loop-worktrees.ts +25 -25
- package/src/server/collections/skill-executions.ts +8 -0
- package/src/server/migrations/20260427000002-change-packages-to-text.ts +52 -52
- package/src/server/migrations/20260429000000-add-llm-fields.ts +47 -47
- package/src/server/migrations/20260429000001-fix-inputargs-json-to-text.ts +45 -45
- package/src/server/migrations/20260503000000-add-orchestrator-trace-fields.ts +33 -33
- package/src/server/migrations/20260524000000-add-agent-loop-fields-to-skill-executions.ts +31 -31
- package/src/server/migrations/20260803010000-backfill-loop-control-plane-data.ts +293 -293
- package/src/server/plugin.ts +3 -1
- package/src/server/resources/agent-harness-profile.ts +94 -0
- package/src/server/resources/agent-knowledge-insights.ts +5 -3
- package/src/server/resources/agent-loop-approval.ts +32 -0
- package/src/server/resources/agent-loop-artifact.ts +56 -56
- package/src/server/resources/agent-loop-events-stream.ts +105 -105
- package/src/server/resources/agent-loop.ts +3 -1
- package/src/server/resources/resource-helpers.ts +33 -33
- package/src/server/resources/tracing.ts +266 -266
- package/src/server/services/AgentMemoryContextService.ts +44 -0
- package/src/server/services/DurableCircuitBreakerService.ts +239 -239
- package/src/server/services/ExecutionSpanService.ts +2 -0
- package/src/server/services/HarnessCompiler.ts +37 -0
- package/src/server/services/HarnessProfileService.ts +92 -10
- package/src/server/services/HarnessSchema.ts +31 -0
- package/src/server/services/LoopBudgetService.ts +275 -275
- package/src/server/services/LoopControlService.ts +124 -124
- package/src/server/services/LoopPatternSchema.ts +19 -1
- package/src/server/services/LoopPatternService.ts +143 -143
- package/src/server/services/LoopRunRepository.ts +99 -0
- package/src/server/services/LoopRunStateMachine.ts +100 -3
- package/src/server/services/LoopSchedulerService.ts +199 -199
- package/src/server/services/LoopTriggerService.ts +42 -0
- package/src/server/services/LoopWorkerService.ts +327 -27
- package/src/server/services/NativeSubAgentObserver.ts +186 -21
- package/src/server/services/PathLockService.ts +321 -321
- package/src/server/services/PluginAiRuntimeAdapter.ts +24 -7
- package/src/server/services/ToolLoopDetectionService.ts +213 -0
- package/src/server/services/VerificationSchema.ts +31 -31
- package/src/server/services/VerificationService.ts +81 -2
- package/src/server/services/harness-runtime-policy.ts +141 -0
- package/src/server/skill-hub/plugin.ts +41 -3
- package/src/server/skill-hub/services/RegistrySkillSnapshotService.ts +235 -235
- package/src/server/skill-hub/services/__tests__/RegistrySkillSnapshotService.test.ts +61 -61
- package/src/server/skill-hub/tasks/SkillExecutionTask.ts +43 -2
- package/src/server/utils/ensure-indexes.ts +96 -96
- package/src/server/utils/logging.ts +62 -62
- package/src/server/utils/loop-pattern-context.ts +20 -20
- package/dist/client-v2/214.b063f33ba044a808.js +0 -10
- package/dist/client-v2/373.f5d5292e53c4e832.js +0 -10
- package/dist/client-v2/418.58fa350f5496efd3.js +0 -10
- package/dist/client-v2/53.9a10455323390f14.js +0 -10
- package/dist/client-v2/677.a991ce0250ff5c77.js +0 -10
- package/dist/client-v2/925.e5925bf21ed68e7a.js +0 -10
- package/src/client/AIEmployeeSelect.tsx +0 -47
- package/src/client/AIEmployeesContext.tsx +0 -102
- package/src/client/RulesTab.tsx +0 -2
- package/src/client/TracingTab.tsx +0 -436
- package/src/client/skill-hub/components/ExecutionProgress.tsx +0 -51
- package/src/client-v2/components/RulesTab.tsx +0 -2
- package/src/client-v2/pages/AgentRunsPage.tsx +0 -13
|
@@ -51,7 +51,14 @@ class MemoryRepository {
|
|
|
51
51
|
|
|
52
52
|
async find(options: Row = {}) {
|
|
53
53
|
const filter = (options.filter as Row | undefined) || {};
|
|
54
|
-
return this.rows.filter((row) =>
|
|
54
|
+
return this.rows.filter((row) =>
|
|
55
|
+
Object.entries(filter).every(([key, value]) => {
|
|
56
|
+
if (value && typeof value === 'object' && Array.isArray((value as Row).$in)) {
|
|
57
|
+
return ((value as Row).$in as unknown[]).includes(row[key]);
|
|
58
|
+
}
|
|
59
|
+
return row[key] === value;
|
|
60
|
+
}),
|
|
61
|
+
);
|
|
55
62
|
}
|
|
56
63
|
|
|
57
64
|
async findOne(options: Row) {
|
|
@@ -88,6 +95,7 @@ function createWorker(run: Row) {
|
|
|
88
95
|
['agentLoopRuns', new MemoryRepository([{ ...run }])],
|
|
89
96
|
['agentLoopEvents', new MemoryRepository()],
|
|
90
97
|
['agentLoopSteps', new MemoryRepository()],
|
|
98
|
+
['aiMessages', new MemoryRepository()],
|
|
91
99
|
['agentLoopUsageBuckets', new MemoryRepository()],
|
|
92
100
|
['agentLoopCircuitStates', new MemoryRepository()],
|
|
93
101
|
['agentLoopPathLocks', new MemoryRepository()],
|
|
@@ -234,3 +242,76 @@ describe('LoopWorkerService path lock lifecycle', () => {
|
|
|
234
242
|
expect(repositories.get('agentLoopPathLocks')?.rows[0]).toMatchObject({ status: 'held', owner: 'worker-b:lease' });
|
|
235
243
|
});
|
|
236
244
|
});
|
|
245
|
+
|
|
246
|
+
describe('LoopWorkerService tool loop guard', () => {
|
|
247
|
+
function seedIdenticalCalls(repositories: Map<string, MemoryRepository>, count: number) {
|
|
248
|
+
const messages = repositories.get('aiMessages');
|
|
249
|
+
if (!messages) throw new Error('aiMessages repository missing');
|
|
250
|
+
onInvoke = async (call) => {
|
|
251
|
+
if (call.username !== 'lead') return;
|
|
252
|
+
for (let index = 0; index < count; index += 1) {
|
|
253
|
+
await messages.create({
|
|
254
|
+
values: {
|
|
255
|
+
sessionId: 'session-1',
|
|
256
|
+
role: 'assistant',
|
|
257
|
+
toolCalls: [{ id: `call-${index}`, name: 'searchDocs', args: { query: 'loop' } }],
|
|
258
|
+
},
|
|
259
|
+
});
|
|
260
|
+
}
|
|
261
|
+
onInvoke = null;
|
|
262
|
+
};
|
|
263
|
+
}
|
|
264
|
+
|
|
265
|
+
it('warns later prompts and records one guard step at the warn threshold', async () => {
|
|
266
|
+
const run = baseRun();
|
|
267
|
+
const { repositories, worker } = createWorker(run);
|
|
268
|
+
seedIdenticalCalls(repositories, 3);
|
|
269
|
+
|
|
270
|
+
await worker.execute(claimedRun(run));
|
|
271
|
+
|
|
272
|
+
const makerPrompt = invokeCalls[1]?.prompt || '';
|
|
273
|
+
expect(makerPrompt).toContain('<tool_loop_warning>');
|
|
274
|
+
expect(makerPrompt).toContain('searchDocs');
|
|
275
|
+
|
|
276
|
+
const guardSteps = (repositories.get('agentLoopSteps')?.rows || []).filter((step) => step.kind === 'guard');
|
|
277
|
+
// Recorded once on first observation; later passes see the same signature and skip it.
|
|
278
|
+
expect(guardSteps).toHaveLength(1);
|
|
279
|
+
expect(guardSteps[0]).toMatchObject({ type: 'tool_loop', toolName: 'searchDocs', role: 'leader' });
|
|
280
|
+
|
|
281
|
+
const loopEvents = (repositories.get('agentLoopEvents')?.rows || []).filter(
|
|
282
|
+
(event) => event.type === 'tool_loop_detected',
|
|
283
|
+
);
|
|
284
|
+
expect(loopEvents).toHaveLength(1);
|
|
285
|
+
|
|
286
|
+
// A warning alone must not stop the run.
|
|
287
|
+
expect(invokeCalls.map((call) => call.username)).toEqual(['lead', 'maker-one', 'maker-two']);
|
|
288
|
+
expect(verifyCalls).toHaveLength(1);
|
|
289
|
+
expect(repositories.get('agentLoopRuns')?.rows[0].status).toBe('verifying');
|
|
290
|
+
});
|
|
291
|
+
|
|
292
|
+
it('blocks the run at the block threshold before any further pass', async () => {
|
|
293
|
+
const run = baseRun();
|
|
294
|
+
const { repositories, worker } = createWorker(run);
|
|
295
|
+
seedIdenticalCalls(repositories, 5);
|
|
296
|
+
|
|
297
|
+
await worker.execute(claimedRun(run));
|
|
298
|
+
|
|
299
|
+
expect(invokeCalls.map((call) => call.username)).toEqual(['lead']);
|
|
300
|
+
expect(verifyCalls).toHaveLength(0);
|
|
301
|
+
expect(repositories.get('agentLoopRuns')?.rows[0]).toMatchObject({ status: 'blocked' });
|
|
302
|
+
expect(String(repositories.get('agentLoopRuns')?.rows[0].blockedReason)).toContain('searchDocs');
|
|
303
|
+
});
|
|
304
|
+
|
|
305
|
+
it('escalates the run to a human at the escalate threshold', async () => {
|
|
306
|
+
const run = baseRun();
|
|
307
|
+
const { repositories, worker } = createWorker(run);
|
|
308
|
+
seedIdenticalCalls(repositories, 8);
|
|
309
|
+
|
|
310
|
+
await worker.execute(claimedRun(run));
|
|
311
|
+
|
|
312
|
+
expect(invokeCalls.map((call) => call.username)).toEqual(['lead']);
|
|
313
|
+
expect(verifyCalls).toHaveLength(0);
|
|
314
|
+
expect(repositories.get('agentLoopRuns')?.rows[0]).toMatchObject({ status: 'waiting_human' });
|
|
315
|
+
expect(String(repositories.get('agentLoopRuns')?.rows[0].escalationReason)).toContain('searchDocs');
|
|
316
|
+
});
|
|
317
|
+
});
|
|
@@ -1,7 +1,20 @@
|
|
|
1
|
-
import { describe, expect, it, vi } from 'vitest';
|
|
1
|
+
import { beforeEach, describe, expect, it, vi } from 'vitest';
|
|
2
|
+
import { writeFileSync } from 'fs';
|
|
2
3
|
import { AgentMemoryContextService } from '../services/AgentMemoryContextService';
|
|
4
|
+
import { compileHarness } from '../services/HarnessCompiler';
|
|
3
5
|
import { NativeSubAgentObserver } from '../services/NativeSubAgentObserver';
|
|
4
6
|
import { getAgentExecutionContext } from '../services/AgentExecutionContext';
|
|
7
|
+
import { REDACTED_PLACEHOLDER } from '../services/harness-runtime-policy';
|
|
8
|
+
|
|
9
|
+
// The observer spills oversized sub-agent results to storage; keep tests side-effect free.
|
|
10
|
+
vi.mock('fs', async (importOriginal) => {
|
|
11
|
+
const actual = await importOriginal<typeof import('fs')>();
|
|
12
|
+
return {
|
|
13
|
+
...actual,
|
|
14
|
+
mkdirSync: vi.fn(),
|
|
15
|
+
writeFileSync: vi.fn(),
|
|
16
|
+
};
|
|
17
|
+
});
|
|
5
18
|
|
|
6
19
|
function createObserverHarness(
|
|
7
20
|
profileSettings: Record<string, unknown> | null = {},
|
|
@@ -10,6 +23,14 @@ function createObserverHarness(
|
|
|
10
23
|
orchestratorConfig?: unknown;
|
|
11
24
|
knowledgeBasePlugin?: unknown;
|
|
12
25
|
toolCallResult?: unknown;
|
|
26
|
+
toolCallArgs?: Record<string, unknown>;
|
|
27
|
+
runResult?: string;
|
|
28
|
+
parentConversation?: Record<string, unknown>;
|
|
29
|
+
loopRuns?: Record<number, Record<string, unknown>>;
|
|
30
|
+
spanFindOne?: (query: {
|
|
31
|
+
filterByTk?: string | number;
|
|
32
|
+
filter?: Record<string, unknown>;
|
|
33
|
+
}) => Promise<Record<string, unknown> | null>;
|
|
13
34
|
} = {},
|
|
14
35
|
) {
|
|
15
36
|
let nextSpanId = 1;
|
|
@@ -18,6 +39,7 @@ function createObserverHarness(
|
|
|
18
39
|
const spanRepo = {
|
|
19
40
|
create: vi.fn(async ({ values }) => ({ id: nextSpanId++, ...values })),
|
|
20
41
|
update: vi.fn(async () => ({})),
|
|
42
|
+
findOne: options.spanFindOne ? vi.fn(options.spanFindOne) : undefined,
|
|
21
43
|
};
|
|
22
44
|
const skillExecutionRepo = {
|
|
23
45
|
update: vi.fn(async () => ({})),
|
|
@@ -31,7 +53,7 @@ function createObserverHarness(
|
|
|
31
53
|
toolCall: {
|
|
32
54
|
id: 'tool-1',
|
|
33
55
|
name: 'skill_hub_execute',
|
|
34
|
-
args: { input: 'x' },
|
|
56
|
+
args: options.toolCallArgs ?? { input: 'x' },
|
|
35
57
|
messageId: 'msg-1',
|
|
36
58
|
},
|
|
37
59
|
},
|
|
@@ -60,7 +82,7 @@ function createObserverHarness(
|
|
|
60
82
|
from: 'sub-agent',
|
|
61
83
|
},
|
|
62
84
|
});
|
|
63
|
-
return `answer:${task.question}`;
|
|
85
|
+
return options.runResult ?? `answer:${task.question}`;
|
|
64
86
|
});
|
|
65
87
|
const dispatcher = { run: originalRun };
|
|
66
88
|
const repos: Record<string, unknown> = {
|
|
@@ -83,10 +105,13 @@ function createObserverHarness(
|
|
|
83
105
|
aiConversations: {
|
|
84
106
|
findOne: vi.fn(async ({ filter }) =>
|
|
85
107
|
filter?.sessionId === 'parent-session'
|
|
86
|
-
? { sessionId: 'parent-session', aiEmployeeUsername: 'leader', userId: 7 }
|
|
108
|
+
? options.parentConversation ?? { sessionId: 'parent-session', aiEmployeeUsername: 'leader', userId: 7 }
|
|
87
109
|
: null,
|
|
88
110
|
),
|
|
89
111
|
},
|
|
112
|
+
agentLoopRuns: {
|
|
113
|
+
findOne: vi.fn(async ({ filterByTk }) => options.loopRuns?.[Number(filterByTk)] ?? null),
|
|
114
|
+
},
|
|
90
115
|
orchestratorConfig: {
|
|
91
116
|
findOne: vi.fn(async () => options.orchestratorConfig ?? null),
|
|
92
117
|
},
|
|
@@ -344,6 +369,59 @@ describe('AgentMemoryContextService', () => {
|
|
|
344
369
|
service.resolvePolicySettings({ ctx: createTask().ctx, employee: { username: 'sub-agent' } }),
|
|
345
370
|
).resolves.toEqual(expect.objectContaining({ harnessTag: 'safe', maxMemoryContextChars: 1200 }));
|
|
346
371
|
});
|
|
372
|
+
|
|
373
|
+
it('prefers the published version over raw row settings and flattens the contract', async () => {
|
|
374
|
+
const versionSettings = {
|
|
375
|
+
memory: { enabled: true, scopes: ['public'], maxChars: 1500 },
|
|
376
|
+
observability: { enabled: true, tracingRetentionDays: 7 },
|
|
377
|
+
};
|
|
378
|
+
const plugin = {
|
|
379
|
+
app: { logger: { warn: vi.fn() }, pm: { get: vi.fn() } },
|
|
380
|
+
db: {
|
|
381
|
+
getRepository: vi.fn((name: string) => {
|
|
382
|
+
if (name === 'agentHarnessProfiles') {
|
|
383
|
+
return {
|
|
384
|
+
findOne: vi.fn(async ({ filter }: { filter: { tag: string } }) =>
|
|
385
|
+
filter.tag === 'strict' ? { id: 1, tag: 'strict', enabled: true, currentVersionId: 5 } : null,
|
|
386
|
+
),
|
|
387
|
+
};
|
|
388
|
+
}
|
|
389
|
+
if (name === 'agentHarnessProfileVersions') {
|
|
390
|
+
return {
|
|
391
|
+
findOne: vi.fn(async ({ filter }: { filter: { id: number; status: string } }) =>
|
|
392
|
+
filter.id === 5 && filter.status === 'published'
|
|
393
|
+
? {
|
|
394
|
+
id: 5,
|
|
395
|
+
profileId: 1,
|
|
396
|
+
version: 2,
|
|
397
|
+
schemaVersion: 1,
|
|
398
|
+
status: 'published',
|
|
399
|
+
settings: versionSettings,
|
|
400
|
+
}
|
|
401
|
+
: null,
|
|
402
|
+
),
|
|
403
|
+
};
|
|
404
|
+
}
|
|
405
|
+
return null;
|
|
406
|
+
}),
|
|
407
|
+
},
|
|
408
|
+
};
|
|
409
|
+
const service = new AgentMemoryContextService(plugin);
|
|
410
|
+
|
|
411
|
+
const settings = await service.resolvePolicySettings({
|
|
412
|
+
ctx: { action: { params: { values: { harnessTag: 'strict' } } } },
|
|
413
|
+
employee: { username: 'sub-agent' },
|
|
414
|
+
});
|
|
415
|
+
|
|
416
|
+
expect(settings).toMatchObject({
|
|
417
|
+
harnessTag: 'strict',
|
|
418
|
+
memoryInjectionEnabled: true,
|
|
419
|
+
memoryScopes: ['public'],
|
|
420
|
+
maxMemoryContextChars: 1500,
|
|
421
|
+
nativeObserverEnabled: true,
|
|
422
|
+
tracingRetentionDays: 7,
|
|
423
|
+
});
|
|
424
|
+
});
|
|
347
425
|
});
|
|
348
426
|
|
|
349
427
|
describe('NativeSubAgentObserver memory injection', () => {
|
|
@@ -376,3 +454,209 @@ describe('NativeSubAgentObserver memory injection', () => {
|
|
|
376
454
|
expect(runWithAgentContext).toHaveBeenCalledWith('sub-agent', expect.any(Function));
|
|
377
455
|
});
|
|
378
456
|
});
|
|
457
|
+
|
|
458
|
+
describe('NativeSubAgentObserver harness policy', () => {
|
|
459
|
+
beforeEach(() => {
|
|
460
|
+
vi.mocked(writeFileSync).mockClear();
|
|
461
|
+
});
|
|
462
|
+
|
|
463
|
+
it('persists no spans at all when sharing is disabled', async () => {
|
|
464
|
+
const { plugin, dispatcher, originalRun, spanRepo } = createObserverHarness({
|
|
465
|
+
observability: { sharing: 'disabled' },
|
|
466
|
+
});
|
|
467
|
+
const observer = new NativeSubAgentObserver(plugin);
|
|
468
|
+
observer.install();
|
|
469
|
+
|
|
470
|
+
const result = await dispatcher.run(createTask());
|
|
471
|
+
|
|
472
|
+
expect(result).toBe('answer:do the work');
|
|
473
|
+
expect(originalRun).toHaveBeenCalledTimes(1);
|
|
474
|
+
expect(spanRepo.create).not.toHaveBeenCalled();
|
|
475
|
+
expect(spanRepo.update).not.toHaveBeenCalled();
|
|
476
|
+
});
|
|
477
|
+
|
|
478
|
+
it('captures outputs but omits inputs under feedback-only sharing', async () => {
|
|
479
|
+
const { plugin, dispatcher, spanRepo } = createObserverHarness({
|
|
480
|
+
observability: { sharing: 'feedback-only' },
|
|
481
|
+
});
|
|
482
|
+
const observer = new NativeSubAgentObserver(plugin);
|
|
483
|
+
observer.install();
|
|
484
|
+
|
|
485
|
+
await dispatcher.run(createTask());
|
|
486
|
+
|
|
487
|
+
const rootSpanValues = spanRepo.create.mock.calls[0][0].values;
|
|
488
|
+
const toolSpanValues = spanRepo.create.mock.calls[1][0].values;
|
|
489
|
+
expect(rootSpanValues.input).toBeUndefined();
|
|
490
|
+
expect(toolSpanValues.input).toBeUndefined();
|
|
491
|
+
const toolSpanUpdate = spanRepo.update.mock.calls[0][0].values;
|
|
492
|
+
expect(toolSpanUpdate.output).toBeDefined();
|
|
493
|
+
});
|
|
494
|
+
|
|
495
|
+
it('redacts secret-looking keys in captured tool args by default', async () => {
|
|
496
|
+
const { plugin, dispatcher, spanRepo } = createObserverHarness(
|
|
497
|
+
{},
|
|
498
|
+
{ toolCallArgs: { apiKey: 'secret-value', path: '/tmp/x' } },
|
|
499
|
+
);
|
|
500
|
+
const observer = new NativeSubAgentObserver(plugin);
|
|
501
|
+
observer.install();
|
|
502
|
+
|
|
503
|
+
await dispatcher.run(createTask());
|
|
504
|
+
|
|
505
|
+
const toolSpanValues = spanRepo.create.mock.calls[1][0].values;
|
|
506
|
+
expect(toolSpanValues.input).toEqual({ apiKey: REDACTED_PLACEHOLDER, path: '/tmp/x' });
|
|
507
|
+
});
|
|
508
|
+
|
|
509
|
+
it('keeps raw tool args when the profile disables redaction', async () => {
|
|
510
|
+
const { plugin, dispatcher, spanRepo } = createObserverHarness(
|
|
511
|
+
{ observability: { redactSecrets: false } },
|
|
512
|
+
{ toolCallArgs: { apiKey: 'secret-value' } },
|
|
513
|
+
);
|
|
514
|
+
const observer = new NativeSubAgentObserver(plugin);
|
|
515
|
+
observer.install();
|
|
516
|
+
|
|
517
|
+
await dispatcher.run(createTask());
|
|
518
|
+
|
|
519
|
+
const toolSpanValues = spanRepo.create.mock.calls[1][0].values;
|
|
520
|
+
expect(toolSpanValues.input).toEqual({ apiKey: 'secret-value' });
|
|
521
|
+
});
|
|
522
|
+
|
|
523
|
+
it('spills oversized sub-agent results to disk and returns a bounded preview', async () => {
|
|
524
|
+
const longAnswer = `ANSWER-HEAD ${'y'.repeat(6000)} ANSWER-TAIL`;
|
|
525
|
+
const { plugin, dispatcher, spanRepo } = createObserverHarness(
|
|
526
|
+
{ context: { spill: { maxInlineBytes: 400 } } },
|
|
527
|
+
{ runResult: longAnswer },
|
|
528
|
+
);
|
|
529
|
+
const observer = new NativeSubAgentObserver(plugin);
|
|
530
|
+
observer.install();
|
|
531
|
+
|
|
532
|
+
const result = await dispatcher.run(createTask());
|
|
533
|
+
|
|
534
|
+
expect(result).toContain('ANSWER-HEAD');
|
|
535
|
+
expect(result).toContain('ANSWER-TAIL');
|
|
536
|
+
expect(result).toContain('bytes omitted');
|
|
537
|
+
expect(Buffer.byteLength(result, 'utf8')).toBeLessThanOrEqual(400);
|
|
538
|
+
expect(writeFileSync).toHaveBeenCalledTimes(1);
|
|
539
|
+
const spillPath = vi.mocked(writeFileSync).mock.calls[0][0] as string;
|
|
540
|
+
expect(spillPath).toContain('spills');
|
|
541
|
+
// The root span (created first, id 1) stores the spilled preview, not the full text.
|
|
542
|
+
const rootSpanUpdate = spanRepo.update.mock.calls.map((call) => call[0]).find((values) => values.filterByTk === 1);
|
|
543
|
+
expect(rootSpanUpdate.values.output).toBe(result);
|
|
544
|
+
});
|
|
545
|
+
|
|
546
|
+
it('keeps small results inline when no spill budget is configured', async () => {
|
|
547
|
+
const { plugin, dispatcher } = createObserverHarness({}, { runResult: 'short answer' });
|
|
548
|
+
const observer = new NativeSubAgentObserver(plugin);
|
|
549
|
+
observer.install();
|
|
550
|
+
|
|
551
|
+
const result = await dispatcher.run(createTask());
|
|
552
|
+
|
|
553
|
+
expect(result).toBe('short answer');
|
|
554
|
+
expect(writeFileSync).not.toHaveBeenCalled();
|
|
555
|
+
});
|
|
556
|
+
});
|
|
557
|
+
|
|
558
|
+
describe('NativeSubAgentObserver delegation inheritance', () => {
|
|
559
|
+
function loopParentConversation() {
|
|
560
|
+
return {
|
|
561
|
+
sessionId: 'parent-session',
|
|
562
|
+
aiEmployeeUsername: 'leader',
|
|
563
|
+
userId: 7,
|
|
564
|
+
options: { controlPlaneRunId: 5 },
|
|
565
|
+
};
|
|
566
|
+
}
|
|
567
|
+
|
|
568
|
+
function loopRunHarness(settings: Record<string, unknown>) {
|
|
569
|
+
return {
|
|
570
|
+
id: 5,
|
|
571
|
+
roleBindingsSnapshot: { leader: 'leader' },
|
|
572
|
+
leaderHarnessSnapshot: {
|
|
573
|
+
effective: compileHarness([{ source: 'run-snapshot', settings }]),
|
|
574
|
+
},
|
|
575
|
+
};
|
|
576
|
+
}
|
|
577
|
+
|
|
578
|
+
it('inherits the loop role harness as an extra compile layer', async () => {
|
|
579
|
+
const { plugin, dispatcher, spanRepo } = createObserverHarness(
|
|
580
|
+
{},
|
|
581
|
+
{
|
|
582
|
+
parentConversation: loopParentConversation(),
|
|
583
|
+
loopRuns: {
|
|
584
|
+
5: loopRunHarness({
|
|
585
|
+
observability: { sharing: 'feedback-only' },
|
|
586
|
+
delegation: { maxDepth: 4 },
|
|
587
|
+
}),
|
|
588
|
+
},
|
|
589
|
+
},
|
|
590
|
+
);
|
|
591
|
+
const observer = new NativeSubAgentObserver(plugin);
|
|
592
|
+
observer.install();
|
|
593
|
+
|
|
594
|
+
await dispatcher.run(createTask(plugin.db.getRepository));
|
|
595
|
+
|
|
596
|
+
const rootSpanValues = spanRepo.create.mock.calls[0][0].values;
|
|
597
|
+
// The parent layer tightens sharing to feedback-only even though the child profile defaults
|
|
598
|
+
// to full; the run linkage is persisted on the span and in its metadata.
|
|
599
|
+
expect(rootSpanValues.input).toBeUndefined();
|
|
600
|
+
expect(rootSpanValues.depth).toBe(1);
|
|
601
|
+
expect(rootSpanValues.agentLoopRunId).toBe(5);
|
|
602
|
+
expect(rootSpanValues.metadata.agentLoopRunId).toBe(5);
|
|
603
|
+
});
|
|
604
|
+
|
|
605
|
+
it('does not inherit a run harness when the parent conversation is not a loop session', async () => {
|
|
606
|
+
const { plugin, dispatcher, spanRepo, repos } = createObserverHarness(
|
|
607
|
+
{},
|
|
608
|
+
{
|
|
609
|
+
loopRuns: { 5: loopRunHarness({ observability: { sharing: 'feedback-only' } }) },
|
|
610
|
+
},
|
|
611
|
+
);
|
|
612
|
+
const observer = new NativeSubAgentObserver(plugin);
|
|
613
|
+
observer.install();
|
|
614
|
+
|
|
615
|
+
await dispatcher.run(createTask(plugin.db.getRepository));
|
|
616
|
+
|
|
617
|
+
const rootSpanValues = spanRepo.create.mock.calls[0][0].values;
|
|
618
|
+
// Full sharing from the child profile: without controlPlaneRunId no parent layer is applied.
|
|
619
|
+
expect(rootSpanValues.input).toBeDefined();
|
|
620
|
+
expect(rootSpanValues.agentLoopRunId).toBeUndefined();
|
|
621
|
+
const runRepo = repos.agentLoopRuns as { findOne: ReturnType<typeof vi.fn> };
|
|
622
|
+
expect(runRepo.findOne).not.toHaveBeenCalled();
|
|
623
|
+
});
|
|
624
|
+
|
|
625
|
+
it('derives the child depth from the parent span persisted in the database', async () => {
|
|
626
|
+
const { plugin, dispatcher, spanRepo } = createObserverHarness(
|
|
627
|
+
{},
|
|
628
|
+
{
|
|
629
|
+
spanFindOne: async (query) => (query.filter?.subSessionId === 'parent-session' ? { id: 99, depth: 2 } : null),
|
|
630
|
+
},
|
|
631
|
+
);
|
|
632
|
+
const observer = new NativeSubAgentObserver(plugin);
|
|
633
|
+
observer.install();
|
|
634
|
+
|
|
635
|
+
await dispatcher.run(createTask());
|
|
636
|
+
|
|
637
|
+
const rootSpanValues = spanRepo.create.mock.calls[0][0].values;
|
|
638
|
+
expect(rootSpanValues.depth).toBe(3);
|
|
639
|
+
expect(rootSpanValues.parentSpanId).toBe('99');
|
|
640
|
+
});
|
|
641
|
+
|
|
642
|
+
it('fails the dispatch when the child depth exceeds the inherited maxDepth', async () => {
|
|
643
|
+
const { plugin, dispatcher, originalRun, spanRepo } = createObserverHarness(
|
|
644
|
+
{},
|
|
645
|
+
{
|
|
646
|
+
parentConversation: loopParentConversation(),
|
|
647
|
+
loopRuns: { 5: loopRunHarness({ delegation: { maxDepth: 2 } }) },
|
|
648
|
+
spanFindOne: async (query) => (query.filter?.subSessionId === 'parent-session' ? { id: 99, depth: 2 } : null),
|
|
649
|
+
},
|
|
650
|
+
);
|
|
651
|
+
const observer = new NativeSubAgentObserver(plugin);
|
|
652
|
+
observer.install();
|
|
653
|
+
|
|
654
|
+
await expect(dispatcher.run(createTask(plugin.db.getRepository))).rejects.toThrow(
|
|
655
|
+
'delegation depth 3 exceeds the harness limit of 2',
|
|
656
|
+
);
|
|
657
|
+
expect(originalRun).not.toHaveBeenCalled();
|
|
658
|
+
const rootSpanUpdate = spanRepo.update.mock.calls.map((call) => call[0]).find((values) => values.filterByTk === 1);
|
|
659
|
+
expect(rootSpanUpdate.values.status).toBe('error');
|
|
660
|
+
expect(rootSpanUpdate.values.error).toContain('exceeds the harness limit');
|
|
661
|
+
});
|
|
662
|
+
});
|