plugin-agent-orchestrator 1.1.4 → 1.1.5
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +204 -114
- package/dist/client/index.js +1 -1
- package/dist/client-v2/117.7565cff57c39318a.js +10 -0
- package/dist/client-v2/214.106635011859dede.js +10 -0
- package/dist/client-v2/418.41ed200e7d6da332.js +10 -0
- package/dist/client-v2/53.349fff8db80b19d4.js +10 -0
- package/dist/client-v2/981.e4a1f41cfc94a856.js +10 -0
- package/dist/client-v2/index.js +1 -1
- package/dist/externalVersion.js +7 -8
- package/dist/locale/en-US.json +226 -170
- package/dist/locale/vi-VN.json +226 -170
- package/dist/locale/zh-CN.json +226 -170
- package/dist/server/collections/agent-execution-spans.js +8 -0
- package/dist/server/collections/agent-loop-action-approvals.js +1 -0
- package/dist/server/collections/agent-loop-runs.js +7 -1
- package/dist/server/collections/agent-loop-steps.js +7 -0
- package/dist/server/collections/skill-executions.js +8 -0
- package/dist/server/plugin.js +3 -1
- package/dist/server/resources/agent-harness-profile.js +117 -0
- package/dist/server/resources/agent-knowledge-insights.js +1 -3
- package/dist/server/resources/agent-loop-approval.js +25 -0
- package/dist/server/resources/agent-loop.js +3 -1
- package/dist/server/services/AgentMemoryContextService.js +34 -0
- package/dist/server/services/HarnessCompiler.js +35 -2
- package/dist/server/services/HarnessProfileService.js +74 -9
- package/dist/server/services/HarnessSchema.js +30 -3
- package/dist/server/services/LoopPatternSchema.js +16 -1
- package/dist/server/services/LoopRunRepository.js +80 -0
- package/dist/server/services/LoopRunStateMachine.js +92 -3
- package/dist/server/services/LoopTriggerService.js +37 -0
- package/dist/server/services/LoopWorkerService.js +261 -23
- package/dist/server/services/NativeSubAgentObserver.js +165 -23
- package/dist/server/services/PluginAiRuntimeAdapter.js +16 -5
- package/dist/server/services/ToolLoopDetectionService.js +210 -0
- package/dist/server/services/VerificationService.js +66 -0
- package/dist/server/services/harness-runtime-policy.js +139 -0
- package/dist/server/skill-hub/plugin.js +36 -3
- package/dist/server/skill-hub/tasks/SkillExecutionTask.js +29 -0
- package/package.json +53 -53
- package/src/client/ApprovalsTab.tsx +2 -0
- package/src/client/OrchestratorSettings.tsx +11 -0
- package/src/client/skill-hub/components/GitSkillImport.tsx +3 -3
- package/src/client/skill-hub/components/SkillMetrics.tsx +15 -10
- package/src/client/skill-hub/index.tsx +0 -52
- package/src/client-v2/components/AgentRunsTab.tsx +576 -576
- package/src/client-v2/components/ApprovalsTab.tsx +337 -0
- package/src/client-v2/components/HarnessProfilesTab.tsx +385 -105
- package/src/client-v2/components/MemoryInspectorTab.tsx +141 -141
- package/src/client-v2/components/TracingTab.tsx +515 -515
- package/src/client-v2/hooks/useApiRequest.ts +141 -141
- package/src/client-v2/pages/ApprovalsPage.tsx +10 -0
- package/src/client-v2/plugin.tsx +6 -6
- package/src/client-v2/skill-hub/components/SkillMetrics.tsx +5 -2
- package/src/locale/en-US.json +226 -174
- package/src/locale/vi-VN.json +226 -174
- package/src/locale/zh-CN.json +226 -174
- package/src/server/__tests__/circuit-breaker.test.ts +248 -248
- package/src/server/__tests__/harness-compiler.test.ts +83 -0
- package/src/server/__tests__/harness-profile-service.test.ts +51 -0
- package/src/server/__tests__/harness-runtime-policy.test.ts +293 -0
- package/src/server/__tests__/harness-tool-plan.test.ts +24 -0
- package/src/server/__tests__/loop-approval-decision.test.ts +512 -0
- package/src/server/__tests__/loop-approval-expiry.test.ts +258 -0
- package/src/server/__tests__/loop-budget-service.test.ts +255 -255
- package/src/server/__tests__/loop-control-plane-backfill.test.ts +266 -266
- package/src/server/__tests__/loop-pattern-schema.test.ts +18 -1
- package/src/server/__tests__/loop-pattern-service.test.ts +148 -148
- package/src/server/__tests__/loop-run-state-machine.test.ts +11 -0
- package/src/server/__tests__/loop-trigger-service.test.ts +148 -0
- package/src/server/__tests__/loop-worker-claim.test.ts +341 -341
- package/src/server/__tests__/loop-worker-execution.test.ts +82 -1
- package/src/server/__tests__/native-sub-agent-observer.test.ts +288 -4
- package/src/server/__tests__/path-lock-service.test.ts +254 -254
- package/src/server/__tests__/skill-execution-task-policy.test.ts +140 -0
- package/src/server/__tests__/smoke.test.ts +162 -162
- package/src/server/__tests__/tool-loop-detection.test.ts +275 -0
- package/src/server/collections/agent-execution-spans.ts +8 -0
- package/src/server/collections/agent-harness-profile-versions.ts +26 -26
- package/src/server/collections/agent-harness-profiles.ts +71 -71
- package/src/server/collections/agent-loop-action-approvals.ts +1 -0
- package/src/server/collections/agent-loop-artifacts.ts +25 -25
- package/src/server/collections/agent-loop-circuit-states.ts +23 -23
- package/src/server/collections/agent-loop-control-settings.ts +21 -21
- package/src/server/collections/agent-loop-events.ts +98 -98
- package/src/server/collections/agent-loop-path-locks.ts +27 -27
- package/src/server/collections/agent-loop-patterns.ts +42 -42
- package/src/server/collections/agent-loop-runs.ts +7 -1
- package/src/server/collections/agent-loop-steps.ts +7 -0
- package/src/server/collections/agent-loop-usage-buckets.ts +22 -22
- package/src/server/collections/agent-loop-worktrees.ts +25 -25
- package/src/server/collections/skill-executions.ts +8 -0
- package/src/server/migrations/20260427000002-change-packages-to-text.ts +52 -52
- package/src/server/migrations/20260429000000-add-llm-fields.ts +47 -47
- package/src/server/migrations/20260429000001-fix-inputargs-json-to-text.ts +45 -45
- package/src/server/migrations/20260503000000-add-orchestrator-trace-fields.ts +33 -33
- package/src/server/migrations/20260524000000-add-agent-loop-fields-to-skill-executions.ts +31 -31
- package/src/server/migrations/20260803010000-backfill-loop-control-plane-data.ts +293 -293
- package/src/server/plugin.ts +3 -1
- package/src/server/resources/agent-harness-profile.ts +94 -0
- package/src/server/resources/agent-knowledge-insights.ts +5 -3
- package/src/server/resources/agent-loop-approval.ts +32 -0
- package/src/server/resources/agent-loop-artifact.ts +56 -56
- package/src/server/resources/agent-loop-events-stream.ts +105 -105
- package/src/server/resources/agent-loop.ts +3 -1
- package/src/server/resources/resource-helpers.ts +33 -33
- package/src/server/resources/tracing.ts +266 -266
- package/src/server/services/AgentMemoryContextService.ts +44 -0
- package/src/server/services/DurableCircuitBreakerService.ts +239 -239
- package/src/server/services/ExecutionSpanService.ts +2 -0
- package/src/server/services/HarnessCompiler.ts +37 -0
- package/src/server/services/HarnessProfileService.ts +92 -10
- package/src/server/services/HarnessSchema.ts +31 -0
- package/src/server/services/LoopBudgetService.ts +275 -275
- package/src/server/services/LoopControlService.ts +124 -124
- package/src/server/services/LoopPatternSchema.ts +19 -1
- package/src/server/services/LoopPatternService.ts +143 -143
- package/src/server/services/LoopRunRepository.ts +99 -0
- package/src/server/services/LoopRunStateMachine.ts +100 -3
- package/src/server/services/LoopSchedulerService.ts +199 -199
- package/src/server/services/LoopTriggerService.ts +42 -0
- package/src/server/services/LoopWorkerService.ts +327 -27
- package/src/server/services/NativeSubAgentObserver.ts +186 -21
- package/src/server/services/PathLockService.ts +321 -321
- package/src/server/services/PluginAiRuntimeAdapter.ts +24 -7
- package/src/server/services/ToolLoopDetectionService.ts +213 -0
- package/src/server/services/VerificationSchema.ts +31 -31
- package/src/server/services/VerificationService.ts +81 -2
- package/src/server/services/harness-runtime-policy.ts +141 -0
- package/src/server/skill-hub/plugin.ts +41 -3
- package/src/server/skill-hub/services/RegistrySkillSnapshotService.ts +235 -235
- package/src/server/skill-hub/services/__tests__/RegistrySkillSnapshotService.test.ts +61 -61
- package/src/server/skill-hub/tasks/SkillExecutionTask.ts +43 -2
- package/src/server/utils/ensure-indexes.ts +96 -96
- package/src/server/utils/logging.ts +62 -62
- package/src/server/utils/loop-pattern-context.ts +20 -20
- package/dist/client-v2/214.b063f33ba044a808.js +0 -10
- package/dist/client-v2/373.f5d5292e53c4e832.js +0 -10
- package/dist/client-v2/418.58fa350f5496efd3.js +0 -10
- package/dist/client-v2/53.9a10455323390f14.js +0 -10
- package/dist/client-v2/677.a991ce0250ff5c77.js +0 -10
- package/dist/client-v2/925.e5925bf21ed68e7a.js +0 -10
- package/src/client/AIEmployeeSelect.tsx +0 -47
- package/src/client/AIEmployeesContext.tsx +0 -102
- package/src/client/RulesTab.tsx +0 -2
- package/src/client/TracingTab.tsx +0 -436
- package/src/client/skill-hub/components/ExecutionProgress.tsx +0 -51
- package/src/client-v2/components/RulesTab.tsx +0 -2
- package/src/client-v2/pages/AgentRunsPage.tsx +0 -13
|
@@ -1,148 +1,148 @@
|
|
|
1
|
-
import type { Database } from '@nocobase/database';
|
|
2
|
-
import { describe, expect, it } from 'vitest';
|
|
3
|
-
import { LoopPatternService } from '../services/LoopPatternService';
|
|
4
|
-
|
|
5
|
-
type Row = Record<string, unknown>;
|
|
6
|
-
|
|
7
|
-
class MemoryRepository {
|
|
8
|
-
constructor(readonly rows: Row[] = []) {}
|
|
9
|
-
|
|
10
|
-
async find(options: Row = {}) {
|
|
11
|
-
const filter = (options.filter as Row | undefined) || {};
|
|
12
|
-
return this.rows.filter((row) => Object.entries(filter).every(([key, value]) => row[key] === value));
|
|
13
|
-
}
|
|
14
|
-
|
|
15
|
-
async findOne(options: Row) {
|
|
16
|
-
if (options.filterByTk !== undefined) {
|
|
17
|
-
return this.rows.find((row) => String(row.id) === String(options.filterByTk)) || null;
|
|
18
|
-
}
|
|
19
|
-
return (await this.find(options))[0] || null;
|
|
20
|
-
}
|
|
21
|
-
}
|
|
22
|
-
|
|
23
|
-
function pattern(values: Row = {}) {
|
|
24
|
-
return {
|
|
25
|
-
id: 1,
|
|
26
|
-
key: 'nightly-report',
|
|
27
|
-
title: 'Nightly report',
|
|
28
|
-
goalTemplate: 'Summarize yesterday.',
|
|
29
|
-
enabled: true,
|
|
30
|
-
autonomyLevel: 'L1',
|
|
31
|
-
triggerType: 'manual',
|
|
32
|
-
leaderUsername: 'leader',
|
|
33
|
-
makerUsernames: ['maker-a', 'maker-b'],
|
|
34
|
-
verifierUsername: 'verifier',
|
|
35
|
-
leaderHarnessTag: 'default',
|
|
36
|
-
makerHarnessTag: 'default',
|
|
37
|
-
verifierHarnessTag: 'safe',
|
|
38
|
-
...values,
|
|
39
|
-
};
|
|
40
|
-
}
|
|
41
|
-
|
|
42
|
-
function createService(input: { patterns: Row[]; employeeHarnesses?: Record<string, unknown> }) {
|
|
43
|
-
const repositories = new Map<string, MemoryRepository>([
|
|
44
|
-
['agentLoopPatterns', new MemoryRepository(input.patterns)],
|
|
45
|
-
[
|
|
46
|
-
'agentHarnessProfiles',
|
|
47
|
-
new MemoryRepository([
|
|
48
|
-
{ id: 1, tag: 'default', enabled: true, currentVersionId: 1 },
|
|
49
|
-
{ id: 2, tag: 'safe', enabled: true, currentVersionId: 2 },
|
|
50
|
-
]),
|
|
51
|
-
],
|
|
52
|
-
[
|
|
53
|
-
'agentHarnessProfileVersions',
|
|
54
|
-
new MemoryRepository([
|
|
55
|
-
{
|
|
56
|
-
id: 1,
|
|
57
|
-
profileId: 1,
|
|
58
|
-
version: 3,
|
|
59
|
-
schemaVersion: 1,
|
|
60
|
-
status: 'published',
|
|
61
|
-
settings: { tools: { allow: ['read_file'] } },
|
|
62
|
-
},
|
|
63
|
-
{
|
|
64
|
-
id: 2,
|
|
65
|
-
profileId: 2,
|
|
66
|
-
version: 1,
|
|
67
|
-
schemaVersion: 1,
|
|
68
|
-
status: 'published',
|
|
69
|
-
settings: { tools: { allow: ['read_file'], deny: ['write_file'] } },
|
|
70
|
-
},
|
|
71
|
-
]),
|
|
72
|
-
],
|
|
73
|
-
]);
|
|
74
|
-
const database = {
|
|
75
|
-
getRepository(name: string) {
|
|
76
|
-
const repository = repositories.get(name);
|
|
77
|
-
if (!repository) throw new Error(`Unexpected repository ${name}`);
|
|
78
|
-
return repository;
|
|
79
|
-
},
|
|
80
|
-
};
|
|
81
|
-
const employeeHarnesses = input.employeeHarnesses || {};
|
|
82
|
-
return new LoopPatternService(
|
|
83
|
-
database as unknown as Database,
|
|
84
|
-
async (username: string) => employeeHarnesses[username],
|
|
85
|
-
async () => ({ available: false }),
|
|
86
|
-
);
|
|
87
|
-
}
|
|
88
|
-
|
|
89
|
-
describe('LoopPatternService compilation', () => {
|
|
90
|
-
it('compiles a distinct harness snapshot for every maker', async () => {
|
|
91
|
-
const service = createService({
|
|
92
|
-
patterns: [pattern()],
|
|
93
|
-
employeeHarnesses: {
|
|
94
|
-
// Employee-level overrides differ per username, so reusing the first maker's
|
|
95
|
-
// compilation would grant or deny the wrong tools for the second maker.
|
|
96
|
-
'maker-b': { tools: { deny: ['read_file'], ask: ['run_tests'] } },
|
|
97
|
-
},
|
|
98
|
-
});
|
|
99
|
-
|
|
100
|
-
const compiled = await service.compile(1);
|
|
101
|
-
|
|
102
|
-
expect(Object.keys(compiled.makerHarnesses)).toEqual(['maker-a', 'maker-b']);
|
|
103
|
-
expect(compiled.makerHarnesses['maker-a'].effective.tools.deny).toEqual([]);
|
|
104
|
-
expect(compiled.makerHarnesses['maker-a'].effective.tools.allow).toContain('read_file');
|
|
105
|
-
expect(compiled.makerHarnesses['maker-b'].effective.tools.deny).toEqual(['read_file']);
|
|
106
|
-
expect(compiled.makerHarnesses['maker-b'].effective.tools.ask).toEqual(['run_tests']);
|
|
107
|
-
expect(compiled.makerHarnesses['maker-a'].effective.sources).not.toContain('employee:maker-b');
|
|
108
|
-
expect(compiled.makerHarnesses['maker-b'].effective.sources).toContain('employee:maker-b');
|
|
109
|
-
expect(compiled.roleBindings).toMatchObject({
|
|
110
|
-
leader: 'leader',
|
|
111
|
-
makers: ['maker-a', 'maker-b'],
|
|
112
|
-
verifier: 'verifier',
|
|
113
|
-
});
|
|
114
|
-
});
|
|
115
|
-
|
|
116
|
-
it('falls back to the leader when a pattern declares no makers', async () => {
|
|
117
|
-
const service = createService({ patterns: [pattern({ makerUsernames: [] })] });
|
|
118
|
-
|
|
119
|
-
const compiled = await service.compile(1);
|
|
120
|
-
|
|
121
|
-
// The worker iterates `roleBindings.makers`, so returning the raw empty array here made it run
|
|
122
|
-
// zero makers while `makerHarnesses` held a leader snapshot: the whole execution phase was
|
|
123
|
-
// skipped and the verifier only ever saw the leader's plan.
|
|
124
|
-
expect(Object.keys(compiled.makerHarnesses)).toEqual(['leader']);
|
|
125
|
-
expect(compiled.roleBindings.makers).toEqual(['leader']);
|
|
126
|
-
});
|
|
127
|
-
|
|
128
|
-
it('refuses to compile a disabled pattern', async () => {
|
|
129
|
-
const service = createService({ patterns: [pattern({ enabled: false })] });
|
|
130
|
-
await expect(service.compile(1)).rejects.toThrow('is disabled');
|
|
131
|
-
});
|
|
132
|
-
|
|
133
|
-
it('blocks L2 patterns when no worktree provider is available', async () => {
|
|
134
|
-
const service = createService({
|
|
135
|
-
patterns: [
|
|
136
|
-
pattern({
|
|
137
|
-
autonomyLevel: 'L2',
|
|
138
|
-
repositoryKey: 'repo',
|
|
139
|
-
repositoryRoot: '/srv/repo',
|
|
140
|
-
actingOn: ['src/**'],
|
|
141
|
-
policy: { harness: { isolation: { mode: 'worktree', requireWorktree: true } } },
|
|
142
|
-
}),
|
|
143
|
-
],
|
|
144
|
-
});
|
|
145
|
-
|
|
146
|
-
await expect(service.compile(1)).rejects.toThrow('worktree provider');
|
|
147
|
-
});
|
|
148
|
-
});
|
|
1
|
+
import type { Database } from '@nocobase/database';
|
|
2
|
+
import { describe, expect, it } from 'vitest';
|
|
3
|
+
import { LoopPatternService } from '../services/LoopPatternService';
|
|
4
|
+
|
|
5
|
+
type Row = Record<string, unknown>;
|
|
6
|
+
|
|
7
|
+
class MemoryRepository {
|
|
8
|
+
constructor(readonly rows: Row[] = []) {}
|
|
9
|
+
|
|
10
|
+
async find(options: Row = {}) {
|
|
11
|
+
const filter = (options.filter as Row | undefined) || {};
|
|
12
|
+
return this.rows.filter((row) => Object.entries(filter).every(([key, value]) => row[key] === value));
|
|
13
|
+
}
|
|
14
|
+
|
|
15
|
+
async findOne(options: Row) {
|
|
16
|
+
if (options.filterByTk !== undefined) {
|
|
17
|
+
return this.rows.find((row) => String(row.id) === String(options.filterByTk)) || null;
|
|
18
|
+
}
|
|
19
|
+
return (await this.find(options))[0] || null;
|
|
20
|
+
}
|
|
21
|
+
}
|
|
22
|
+
|
|
23
|
+
function pattern(values: Row = {}) {
|
|
24
|
+
return {
|
|
25
|
+
id: 1,
|
|
26
|
+
key: 'nightly-report',
|
|
27
|
+
title: 'Nightly report',
|
|
28
|
+
goalTemplate: 'Summarize yesterday.',
|
|
29
|
+
enabled: true,
|
|
30
|
+
autonomyLevel: 'L1',
|
|
31
|
+
triggerType: 'manual',
|
|
32
|
+
leaderUsername: 'leader',
|
|
33
|
+
makerUsernames: ['maker-a', 'maker-b'],
|
|
34
|
+
verifierUsername: 'verifier',
|
|
35
|
+
leaderHarnessTag: 'default',
|
|
36
|
+
makerHarnessTag: 'default',
|
|
37
|
+
verifierHarnessTag: 'safe',
|
|
38
|
+
...values,
|
|
39
|
+
};
|
|
40
|
+
}
|
|
41
|
+
|
|
42
|
+
function createService(input: { patterns: Row[]; employeeHarnesses?: Record<string, unknown> }) {
|
|
43
|
+
const repositories = new Map<string, MemoryRepository>([
|
|
44
|
+
['agentLoopPatterns', new MemoryRepository(input.patterns)],
|
|
45
|
+
[
|
|
46
|
+
'agentHarnessProfiles',
|
|
47
|
+
new MemoryRepository([
|
|
48
|
+
{ id: 1, tag: 'default', enabled: true, currentVersionId: 1 },
|
|
49
|
+
{ id: 2, tag: 'safe', enabled: true, currentVersionId: 2 },
|
|
50
|
+
]),
|
|
51
|
+
],
|
|
52
|
+
[
|
|
53
|
+
'agentHarnessProfileVersions',
|
|
54
|
+
new MemoryRepository([
|
|
55
|
+
{
|
|
56
|
+
id: 1,
|
|
57
|
+
profileId: 1,
|
|
58
|
+
version: 3,
|
|
59
|
+
schemaVersion: 1,
|
|
60
|
+
status: 'published',
|
|
61
|
+
settings: { tools: { allow: ['read_file'] } },
|
|
62
|
+
},
|
|
63
|
+
{
|
|
64
|
+
id: 2,
|
|
65
|
+
profileId: 2,
|
|
66
|
+
version: 1,
|
|
67
|
+
schemaVersion: 1,
|
|
68
|
+
status: 'published',
|
|
69
|
+
settings: { tools: { allow: ['read_file'], deny: ['write_file'] } },
|
|
70
|
+
},
|
|
71
|
+
]),
|
|
72
|
+
],
|
|
73
|
+
]);
|
|
74
|
+
const database = {
|
|
75
|
+
getRepository(name: string) {
|
|
76
|
+
const repository = repositories.get(name);
|
|
77
|
+
if (!repository) throw new Error(`Unexpected repository ${name}`);
|
|
78
|
+
return repository;
|
|
79
|
+
},
|
|
80
|
+
};
|
|
81
|
+
const employeeHarnesses = input.employeeHarnesses || {};
|
|
82
|
+
return new LoopPatternService(
|
|
83
|
+
database as unknown as Database,
|
|
84
|
+
async (username: string) => employeeHarnesses[username],
|
|
85
|
+
async () => ({ available: false }),
|
|
86
|
+
);
|
|
87
|
+
}
|
|
88
|
+
|
|
89
|
+
describe('LoopPatternService compilation', () => {
|
|
90
|
+
it('compiles a distinct harness snapshot for every maker', async () => {
|
|
91
|
+
const service = createService({
|
|
92
|
+
patterns: [pattern()],
|
|
93
|
+
employeeHarnesses: {
|
|
94
|
+
// Employee-level overrides differ per username, so reusing the first maker's
|
|
95
|
+
// compilation would grant or deny the wrong tools for the second maker.
|
|
96
|
+
'maker-b': { tools: { deny: ['read_file'], ask: ['run_tests'] } },
|
|
97
|
+
},
|
|
98
|
+
});
|
|
99
|
+
|
|
100
|
+
const compiled = await service.compile(1);
|
|
101
|
+
|
|
102
|
+
expect(Object.keys(compiled.makerHarnesses)).toEqual(['maker-a', 'maker-b']);
|
|
103
|
+
expect(compiled.makerHarnesses['maker-a'].effective.tools.deny).toEqual([]);
|
|
104
|
+
expect(compiled.makerHarnesses['maker-a'].effective.tools.allow).toContain('read_file');
|
|
105
|
+
expect(compiled.makerHarnesses['maker-b'].effective.tools.deny).toEqual(['read_file']);
|
|
106
|
+
expect(compiled.makerHarnesses['maker-b'].effective.tools.ask).toEqual(['run_tests']);
|
|
107
|
+
expect(compiled.makerHarnesses['maker-a'].effective.sources).not.toContain('employee:maker-b');
|
|
108
|
+
expect(compiled.makerHarnesses['maker-b'].effective.sources).toContain('employee:maker-b');
|
|
109
|
+
expect(compiled.roleBindings).toMatchObject({
|
|
110
|
+
leader: 'leader',
|
|
111
|
+
makers: ['maker-a', 'maker-b'],
|
|
112
|
+
verifier: 'verifier',
|
|
113
|
+
});
|
|
114
|
+
});
|
|
115
|
+
|
|
116
|
+
it('falls back to the leader when a pattern declares no makers', async () => {
|
|
117
|
+
const service = createService({ patterns: [pattern({ makerUsernames: [] })] });
|
|
118
|
+
|
|
119
|
+
const compiled = await service.compile(1);
|
|
120
|
+
|
|
121
|
+
// The worker iterates `roleBindings.makers`, so returning the raw empty array here made it run
|
|
122
|
+
// zero makers while `makerHarnesses` held a leader snapshot: the whole execution phase was
|
|
123
|
+
// skipped and the verifier only ever saw the leader's plan.
|
|
124
|
+
expect(Object.keys(compiled.makerHarnesses)).toEqual(['leader']);
|
|
125
|
+
expect(compiled.roleBindings.makers).toEqual(['leader']);
|
|
126
|
+
});
|
|
127
|
+
|
|
128
|
+
it('refuses to compile a disabled pattern', async () => {
|
|
129
|
+
const service = createService({ patterns: [pattern({ enabled: false })] });
|
|
130
|
+
await expect(service.compile(1)).rejects.toThrow('is disabled');
|
|
131
|
+
});
|
|
132
|
+
|
|
133
|
+
it('blocks L2 patterns when no worktree provider is available', async () => {
|
|
134
|
+
const service = createService({
|
|
135
|
+
patterns: [
|
|
136
|
+
pattern({
|
|
137
|
+
autonomyLevel: 'L2',
|
|
138
|
+
repositoryKey: 'repo',
|
|
139
|
+
repositoryRoot: '/srv/repo',
|
|
140
|
+
actingOn: ['src/**'],
|
|
141
|
+
policy: { harness: { isolation: { mode: 'worktree', requireWorktree: true } } },
|
|
142
|
+
}),
|
|
143
|
+
],
|
|
144
|
+
});
|
|
145
|
+
|
|
146
|
+
await expect(service.compile(1)).rejects.toThrow('worktree provider');
|
|
147
|
+
});
|
|
148
|
+
});
|
|
@@ -87,4 +87,15 @@ describe('LoopRunStateMachine transition guard', () => {
|
|
|
87
87
|
}),
|
|
88
88
|
).not.toThrow();
|
|
89
89
|
});
|
|
90
|
+
|
|
91
|
+
it('allows a behavioral guard to escalate straight from the active statuses', () => {
|
|
92
|
+
// Tool loop detection escalates an in-flight run to a human; routing it through `blocked`
|
|
93
|
+
// first would mislabel the run as mechanically retryable.
|
|
94
|
+
for (const from of ['running', 'verifying'] as const) {
|
|
95
|
+
expect(() =>
|
|
96
|
+
assertRunTransition({ from, to: 'waiting_human', runtimeVersion: 'control-plane-v2' }),
|
|
97
|
+
).not.toThrow();
|
|
98
|
+
expect(() => assertRunTransition({ from, to: 'blocked', runtimeVersion: 'control-plane-v2' })).not.toThrow();
|
|
99
|
+
}
|
|
100
|
+
});
|
|
90
101
|
});
|
|
@@ -0,0 +1,148 @@
|
|
|
1
|
+
import type { Database } from '@nocobase/database';
|
|
2
|
+
import { describe, expect, it, vi } from 'vitest';
|
|
3
|
+
import { compileHarness } from '../services/HarnessCompiler';
|
|
4
|
+
import type { CompiledPatternSnapshot, HarnessSnapshot } from '../services/LoopPatternService';
|
|
5
|
+
import type { LoopPatternService } from '../services/LoopPatternService';
|
|
6
|
+
import { LoopTriggerService } from '../services/LoopTriggerService';
|
|
7
|
+
|
|
8
|
+
type Row = Record<string, unknown>;
|
|
9
|
+
|
|
10
|
+
class MemoryRepository {
|
|
11
|
+
private nextId: number;
|
|
12
|
+
|
|
13
|
+
constructor(readonly rows: Row[] = []) {
|
|
14
|
+
this.nextId = rows.reduce((maximum, row) => Math.max(maximum, Number(row.id) || 0), 0) + 1;
|
|
15
|
+
}
|
|
16
|
+
|
|
17
|
+
async findOne(options: Row = {}) {
|
|
18
|
+
if (options.filterByTk !== undefined) return this.rows.find((row) => row.id === options.filterByTk) || null;
|
|
19
|
+
const filter = (options.filter as Row | undefined) || {};
|
|
20
|
+
return this.rows.find((row) => Object.entries(filter).every(([key, value]) => row[key] === value)) || null;
|
|
21
|
+
}
|
|
22
|
+
|
|
23
|
+
async create(options: Row) {
|
|
24
|
+
const row = { id: this.nextId++, ...((options.values as Row | undefined) || {}) };
|
|
25
|
+
this.rows.push(row);
|
|
26
|
+
return row;
|
|
27
|
+
}
|
|
28
|
+
}
|
|
29
|
+
|
|
30
|
+
function createDatabase(repositories: Map<string, MemoryRepository>) {
|
|
31
|
+
return {
|
|
32
|
+
getRepository(name: string) {
|
|
33
|
+
const repository = repositories.get(name);
|
|
34
|
+
if (!repository) throw new Error(`Unexpected repository ${name}`);
|
|
35
|
+
return repository;
|
|
36
|
+
},
|
|
37
|
+
sequelize: {
|
|
38
|
+
transaction<T>(callback: (transaction: unknown) => Promise<T>) {
|
|
39
|
+
return callback({});
|
|
40
|
+
},
|
|
41
|
+
},
|
|
42
|
+
} as unknown as Database;
|
|
43
|
+
}
|
|
44
|
+
|
|
45
|
+
function harnessAt(tag: string, version: number): HarnessSnapshot {
|
|
46
|
+
return {
|
|
47
|
+
tag,
|
|
48
|
+
versionId: version * 10,
|
|
49
|
+
version,
|
|
50
|
+
schemaVersion: 1,
|
|
51
|
+
effective: compileHarness([{ source: 'test', settings: {} }]),
|
|
52
|
+
};
|
|
53
|
+
}
|
|
54
|
+
|
|
55
|
+
function compiledSnapshot(): CompiledPatternSnapshot {
|
|
56
|
+
return {
|
|
57
|
+
pattern: {
|
|
58
|
+
key: 'nightly-release',
|
|
59
|
+
triggerType: 'cron',
|
|
60
|
+
goalTemplate: 'Ship the nightly release',
|
|
61
|
+
autonomyLevel: 'L1',
|
|
62
|
+
repositoryKey: '',
|
|
63
|
+
repositoryRoot: '',
|
|
64
|
+
baseRef: '',
|
|
65
|
+
actingOn: [],
|
|
66
|
+
} as unknown as CompiledPatternSnapshot['pattern'],
|
|
67
|
+
roleBindings: { leader: 'lead', makers: ['maker-one'], verifier: 'check' },
|
|
68
|
+
leaderHarness: harnessAt('strict', 3),
|
|
69
|
+
makerHarnesses: { 'maker-one': harnessAt('default', 1) },
|
|
70
|
+
verifierHarness: harnessAt('strict', 3),
|
|
71
|
+
policy: {} as unknown as CompiledPatternSnapshot['policy'],
|
|
72
|
+
};
|
|
73
|
+
}
|
|
74
|
+
|
|
75
|
+
function setup(compiled: CompiledPatternSnapshot) {
|
|
76
|
+
const repositories = new Map<string, MemoryRepository>([
|
|
77
|
+
[
|
|
78
|
+
'agentLoopControlSettings',
|
|
79
|
+
new MemoryRepository([{ id: 1, key: 'global', state: 'running', acceptNewRuns: true, globalMaxConcurrency: 5 }]),
|
|
80
|
+
],
|
|
81
|
+
['agentLoopRuns', new MemoryRepository()],
|
|
82
|
+
['agentLoopEvents', new MemoryRepository()],
|
|
83
|
+
]);
|
|
84
|
+
const patterns = { compile: vi.fn(async () => compiled) } as unknown as LoopPatternService;
|
|
85
|
+
return {
|
|
86
|
+
repositories,
|
|
87
|
+
service: new LoopTriggerService(createDatabase(repositories), patterns),
|
|
88
|
+
};
|
|
89
|
+
}
|
|
90
|
+
|
|
91
|
+
describe('LoopTriggerService.enqueue harness audit', () => {
|
|
92
|
+
it('records one harness_applied audit event per role when a run is queued', async () => {
|
|
93
|
+
const { repositories, service } = setup(compiledSnapshot());
|
|
94
|
+
|
|
95
|
+
const result = await service.enqueue({
|
|
96
|
+
patternId: 1,
|
|
97
|
+
triggerType: 'manual',
|
|
98
|
+
triggerKey: 'manual-1',
|
|
99
|
+
userId: 7,
|
|
100
|
+
goal: 'Ship the feature',
|
|
101
|
+
});
|
|
102
|
+
|
|
103
|
+
expect(result.created).toBe(true);
|
|
104
|
+
expect(repositories.get('agentLoopRuns')?.rows[0]).toMatchObject({
|
|
105
|
+
status: 'queued',
|
|
106
|
+
leaderUsername: 'lead',
|
|
107
|
+
verifierUsername: 'check',
|
|
108
|
+
});
|
|
109
|
+
|
|
110
|
+
const events = repositories.get('agentLoopEvents')?.rows || [];
|
|
111
|
+
expect(events.filter((event) => event.type === 'run_queued')).toHaveLength(1);
|
|
112
|
+
const applied = events.filter((event) => event.type === 'harness_applied');
|
|
113
|
+
expect(applied.map((event) => event.title)).toEqual([
|
|
114
|
+
'Harness strict@v3 applied to leader',
|
|
115
|
+
'Harness default@v1 applied to maker',
|
|
116
|
+
'Harness strict@v3 applied to verifier',
|
|
117
|
+
]);
|
|
118
|
+
expect(applied[0]).toMatchObject({
|
|
119
|
+
runId: 1,
|
|
120
|
+
status: 'queued',
|
|
121
|
+
actorType: 'user',
|
|
122
|
+
actorIdentity: '7',
|
|
123
|
+
correlationKey: 'harness:leader:lead',
|
|
124
|
+
payload: { role: 'leader', username: 'lead', tag: 'strict', version: 3, versionId: 30, schemaVersion: 1 },
|
|
125
|
+
});
|
|
126
|
+
expect(applied[1]).toMatchObject({ correlationKey: 'harness:maker:maker-one' });
|
|
127
|
+
expect(applied[2]).toMatchObject({ correlationKey: 'harness:verifier:check' });
|
|
128
|
+
});
|
|
129
|
+
|
|
130
|
+
it('skips roles whose harness snapshot is missing', async () => {
|
|
131
|
+
const snapshot = compiledSnapshot();
|
|
132
|
+
snapshot.makerHarnesses = {};
|
|
133
|
+
const { repositories, service } = setup(snapshot);
|
|
134
|
+
|
|
135
|
+
await service.enqueue({
|
|
136
|
+
patternId: 1,
|
|
137
|
+
triggerType: 'manual',
|
|
138
|
+
triggerKey: 'manual-2',
|
|
139
|
+
goal: 'Ship it',
|
|
140
|
+
});
|
|
141
|
+
|
|
142
|
+
const applied = (repositories.get('agentLoopEvents')?.rows || []).filter(
|
|
143
|
+
(event) => event.type === 'harness_applied',
|
|
144
|
+
);
|
|
145
|
+
expect(applied).toHaveLength(2);
|
|
146
|
+
expect(applied.map((event) => (event.payload as Row).role)).toEqual(['leader', 'verifier']);
|
|
147
|
+
});
|
|
148
|
+
});
|