plotline-engage 5.7.4 → 5.7.6

package/android/build.gradle

@@ -49,6 +49,6 @@ rootProject.allprojects {
 
 dependencies {
     implementation 'com.facebook.react:react-native:+'
-    implementation 'com.gitlab.plotline:plotline-android-sdk:5.3.0'
+    implementation 'com.gitlab.plotline:plotline-android-sdk:5.3.1'
 }
   

package/android/src/main/java/com/reactnativeplotline/PlotlineWrapperView.java

@@ -61,24 +61,18 @@ public class PlotlineWrapperView extends FrameLayout {
         try {
             ThemedReactContext themedReactContext = (ThemedReactContext) getContext();
             if (themedReactContext.hasActiveReactInstance()) {
-                if (UIManagerHelper.getUIManager(themedReactContext, getId()) instanceof FabricUIManager) {
-
-                    WritableMap eventData = Arguments.createMap();
-                    eventData.putDouble("width", PixelUtil.toDIPFromPixel(finalWidth));
-                    eventData.putDouble("height", PixelUtil.toDIPFromPixel(finalHeight));
+                WritableMap eventData = Arguments.createMap();
+                eventData.putDouble("width", PixelUtil.toDIPFromPixel(finalWidth));
+                eventData.putDouble("height", PixelUtil.toDIPFromPixel(finalHeight));
 
+                if (UIManagerHelper.getUIManager(themedReactContext, getId()) instanceof FabricUIManager) {
                     EventDispatcher eventDispatcher = UIManagerHelper.getEventDispatcherForReactTag(themedReactContext, getId());
                     if (eventDispatcher != null) {
                         eventDispatcher.dispatchEvent(new SizeChangedEvent(UIManagerHelper.getSurfaceId(getContext()), getId(), eventData));
                     }
                 } else {
-                    // LEGACY ARCHITECTURE PATH
-                    themedReactContext.runOnNativeModulesQueueThread(() -> {
-                        UIManagerModule uiManagerModule = themedReactContext.getNativeModule(UIManagerModule.class);
-                        if (uiManagerModule != null) {
-                            uiManagerModule.updateNodeSize(getId(), finalWidth, finalHeight);
-                        }
-                    });
+                    // LEGACY ARCHITECTURE PATH: same event as Fabric; updateNodeSize pinned the width in points, so the view never followed later parent resizes.
+                    themedReactContext.getJSModule(RCTEventEmitter.class).receiveEvent(getId(), SizeChangedEvent.EVENT_NAME, eventData);
                 }
             } 
         } catch (Exception e) {

package/index.js

@@ -245,7 +245,8 @@ const PlotlineWidget = ({ testID }) => {
     const { width, height } = event.nativeEvent;
 
     if (width > 0) {
-      setSize({ width, height });
+      // Android: keep the width at 100% so the view follows later parent resizes; the native width only echoes the parent width at measure time.
+      setSize({ width: '100%', height });
     }
   };
 

package/ios/PlotlineViewContent.m

@@ -9,6 +9,27 @@
 #import "PlotlineWidgetEventEmitter.h"
 #import <Plotline/Plotline.h>
 
+// Each native widget needs its own listener because size callbacks have no sender.
+@interface PlotlineWidgetSizeListener : NSObject <PlotlineWidgetListener>
+@property (nonatomic, weak) PlotlineViewContent *owner;
+@property (nonatomic) NSUInteger generation;
+@end
+
+@interface PlotlineViewContent ()
+@property (nonatomic, strong) PlotlineWidgetSizeListener *widgetListener;
+@property (nonatomic) NSUInteger widgetGeneration;
+@end
+
+@implementation PlotlineWidgetSizeListener
+- (void)onWidgetReadyWithWidth:(CGFloat)width height:(CGFloat)height {
+    PlotlineViewContent *owner = self.owner;
+    if (!owner || owner.widgetListener != self || owner.widgetGeneration != self.generation) {
+        return;
+    }
+    [owner onWidgetReadyWithWidth:width height:height];
+}
+@end
+
 @implementation PlotlineViewContent
 
 - (instancetype)initWithFrame:(CGRect)frame {
@@ -22,12 +43,30 @@
 - (void)setParentWidth:(NSString *)parentWidth {
     if (![_parentWidth isEqualToString:parentWidth]) {
         _parentWidth = parentWidth;
+        NSUInteger generation = ++self.widgetGeneration;
+        // Invalidate immediately, including callbacks before the queued replacement runs.
+        self.widgetListener.owner = nil;
         dispatch_async(dispatch_get_main_queue(), ^{
+            if (generation != self.widgetGeneration) {
+                return;
+            }
             [self.plotlineView removeFromSuperview];
+            self.plotlineView = nil;
+            self.widgetListener = nil;
             if (parentWidth.integerValue != 0) {
-                self.plotlineView = [[PlotlineWidget alloc] initWithClientElementId:self.testID frame:CGRectMake(0, 0, parentWidth.integerValue, 0) plotlineWidgetListener:self];
+                PlotlineWidgetSizeListener *listener = [PlotlineWidgetSizeListener new];
+                listener.owner = self;
+                listener.generation = generation;
+                self.widgetListener = listener;
+                self.plotlineView = [[PlotlineWidget alloc] initWithClientElementId:self.testID frame:CGRectMake(0, 0, parentWidth.integerValue, 0) plotlineWidgetListener:listener];
                 self.plotlineView.translatesAutoresizingMaskIntoConstraints = NO;
                 [self addSubview:self.plotlineView];
+                // Pin the width: with no constraints the host layout pass resizes the widget to this view's stale JS size (0 after an empty callback).
+                [NSLayoutConstraint activateConstraints:@[
+                    [self.plotlineView.leadingAnchor constraintEqualToAnchor:self.leadingAnchor],
+                    [self.plotlineView.topAnchor constraintEqualToAnchor:self.topAnchor],
+                    [self.plotlineView.widthAnchor constraintEqualToConstant:parentWidth.integerValue],
+                ]];
             }
         });
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "plotline-engage",
-  "version": "5.7.4",
+  "version": "5.7.6",
   "description": "React Native plugin for Plotline",
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1"