plotline-engage 5.6.2 → 5.6.4

package/android/build.gradle

@@ -40,6 +40,6 @@ repositories {
 
 dependencies {
     implementation 'com.facebook.react:react-native:+'
-    implementation 'com.gitlab.plotline:plotline-android-sdk:5.2.0'
+    implementation 'com.gitlab.plotline:plotline-android-sdk:5.2.1'
 }
   

package/ios/RNPlotline.m

@@ -1,4 +1,3 @@
-
 #import "RNPlotline.h"
 #import <Plotline/Plotline-Swift.h>
 #import <React/RCTEventEmitter.h>
@@ -9,15 +8,37 @@
   return @[@"PlotlineEvents",@"PlotlineRedirect"];
 }
 
+// Central handler for any NSException caught at the RN bridge boundary.
+// Any uncaught NSException from a void RCT_EXPORT_METHOD is converted to a JS error by
+// React Native ON the TurboModule background queue (convertNSExceptionToJSError), which
+// touches the single-threaded Hermes runtime off the JS thread and corrupts its heap
+// (PLO-4202). We catch here to stop that cascade.
+// NOTE: NSLog-only for now (device-visible, not production telemetry). Routing caught
+// bridge exceptions to production telemetry is a tracked follow-up on PLO-4202.
++ (void)logAndReportException:(NSException *)exception forMethod:(NSString *)method
+{
+  // Self-guarded: this runs inside @catch blocks, so it must never throw - an exception
+  // escaping here would re-enter RN's off-thread error conversion, the exact bug we fixed.
+  @try {
+    NSString *reason = exception.reason ?: @"unknown";
+    NSString *message = [NSString stringWithFormat:@"[Plotline] %@ failed: %@ (%@)", method, reason, exception.name];
+    NSLog(@"%@", message);
+  } @catch (NSException *ignored) {}
+}
+
 RCT_EXPORT_METHOD(init:(NSString *)apiKey userId:(NSString *)userId endpoint:(NSString *)endpoint)
 {
- [Plotline setPlotlineFrameworkWithFramework:@"REACT_NATIVE"];
- if (endpoint != nil) {
-    [Plotline initializeWithApiKey:apiKey userId:userId endpoint:endpoint];
- } else {
-    [Plotline initializeWithApiKey:apiKey userId:userId];
+ @try {
+   [Plotline setPlotlineFrameworkWithFramework:@"REACT_NATIVE"];
+   if (endpoint != nil) {
+      [Plotline initializeWithApiKey:apiKey userId:userId endpoint:endpoint];
+   } else {
+      [Plotline initializeWithApiKey:apiKey userId:userId];
+   }
+   [self registerPlotlineListeners];
+ } @catch (NSException *exception) {
+   [RNPlotline logAndReportException:exception forMethod:@"init"];
  }
- [self registerPlotlineListeners];
 }
 
 - (void)registerPlotlineListeners
@@ -36,87 +57,151 @@ RCT_EXPORT_METHOD(init:(NSString *)apiKey userId:(NSString *)userId endpoint:(NS
 
 RCT_EXPORT_METHOD(initAnonymousUser:(NSString *)apiKey deviceId:(NSString *)deviceId)
 {
- [Plotline setPlotlineFrameworkWithFramework:@"REACT_NATIVE"];
- [Plotline initializeAnonymousUserWithApiKey:apiKey deviceId:deviceId ?: @""];
- [self registerPlotlineListeners];
+ @try {
+   [Plotline setPlotlineFrameworkWithFramework:@"REACT_NATIVE"];
+   [Plotline initializeAnonymousUserWithApiKey:apiKey deviceId:deviceId ?: @""];
+   [self registerPlotlineListeners];
+ } @catch (NSException *exception) {
+   [RNPlotline logAndReportException:exception forMethod:@"initAnonymousUser"];
+ }
 }
 
 RCT_EXPORT_METHOD(track:(NSString *)eventName properties: (NSDictionary *) properties)
 {
- if(properties != nil) {
-  [Plotline trackWithEventName:eventName properties:properties];
- } else {
-  [Plotline trackWithEventName:eventName];
+ @try {
+   if(properties != nil) {
+    [Plotline trackWithEventName:eventName properties:properties];
+   } else {
+    [Plotline trackWithEventName:eventName];
+   }
+ } @catch (NSException *exception) {
+   [RNPlotline logAndReportException:exception forMethod:@"track"];
  }
 }
 
 RCT_EXPORT_METHOD(showStory:(NSString *)storyId slideId: (NSString *)slideId)
 {
-  [Plotline showStoryWithStoryId:storyId slideId:slideId];
+  @try {
+    [Plotline showStoryWithStoryId:storyId slideId:slideId];
+  } @catch (NSException *exception) {
+    [RNPlotline logAndReportException:exception forMethod:@"showStory"];
+  }
 }
 
 RCT_EXPORT_METHOD(setLocale:(NSString *)locale)
 {
- [Plotline setLocaleWithLocale:locale];
+ @try {
+   [Plotline setLocaleWithLocale:locale];
+ } @catch (NSException *exception) {
+   [RNPlotline logAndReportException:exception forMethod:@"setLocale"];
+ }
 }
 
 RCT_EXPORT_METHOD(identify:(NSDictionary *)attribute)
 {
- [Plotline identifyWithAttributes:attribute];
+ @try {
+   [Plotline identifyWithAttributes:attribute];
+ } @catch (NSException *exception) {
+   [RNPlotline logAndReportException:exception forMethod:@"identify"];
+ }
 }
 
 RCT_EXPORT_METHOD(showMockStudy)
 {
- [Plotline showMockStudy];
+ @try {
+   [Plotline showMockStudy];
+ } @catch (NSException *exception) {
+   [RNPlotline logAndReportException:exception forMethod:@"showMockStudy"];
+ }
 }
 
 RCT_EXPORT_METHOD(setColor:(NSDictionary *)colors)
 {
- [Plotline setColorWithColors:colors];
+ @try {
+   [Plotline setColorWithColors:colors];
+ } @catch (NSException *exception) {
+   [RNPlotline logAndReportException:exception forMethod:@"setColor"];
+ }
 }
 
 RCT_EXPORT_METHOD(setShouldDisablePlotline:(nonnull NSNumber *)shouldDisablePlotline)
 {
+  @try {
     BOOL boolValue = [shouldDisablePlotline boolValue];
     [Plotline setShouldDisablePlotlineWithShouldDisablePlotline:boolValue];
+  } @catch (NSException *exception) {
+    [RNPlotline logAndReportException:exception forMethod:@"setShouldDisablePlotline"];
+  }
 }
 
 RCT_EXPORT_METHOD(setShouldEnableScrollDelegates:(nonnull NSNumber *)shouldEnableScrollDelegates)
 {
+  @try {
     BOOL boolValue = [shouldEnableScrollDelegates boolValue];
     [Plotline setShouldEnableScrollDelegatesWithShouldEnableScrollDelegates:boolValue];
+  } @catch (NSException *exception) {
+    [RNPlotline logAndReportException:exception forMethod:@"setShouldEnableScrollDelegates"];
+  }
 }
 
 RCT_EXPORT_METHOD(debug)
 {
- [Plotline debugWithShouldDebug:true];
+ @try {
+   [Plotline debugWithShouldDebug:true];
+ } @catch (NSException *exception) {
+   [RNPlotline logAndReportException:exception forMethod:@"debug"];
+ }
 }
 
 RCT_EXPORT_METHOD(notifyScroll)
 {
- [Plotline notifyScroll];
+ @try {
+   [Plotline notifyScroll];
+ } @catch (NSException *exception) {
+   [RNPlotline logAndReportException:exception forMethod:@"notifyScroll"];
+ }
 }
 
 RCT_EXPORT_METHOD(trackPage:(NSString *)pageName)
 {
- [Plotline trackPageWithPageName:pageName];
+ @try {
+   [Plotline trackPageWithPageName:pageName];
+ } @catch (NSException *exception) {
+   [RNPlotline logAndReportException:exception forMethod:@"trackPage"];
+ }
 }
 
 RCT_EXPORT_METHOD(logout)
 {
- [Plotline logout];
+ @try {
+   [Plotline logout];
+ } @catch (NSException *exception) {
+   [RNPlotline logAndReportException:exception forMethod:@"logout"];
+ }
 }
 
 RCT_EXPORT_METHOD(setToken:(NSString *)token)
 {
-  NSMutableData *deviceTokenData = [NSMutableData data];
-  for (int i = 0; i < token.length; i += 2) {
-    NSString *hexByte = [token substringWithRange:NSMakeRange(i, 2)];
-    unsigned int byte;
-    [[NSScanner scannerWithString:hexByte] scanHexInt:&byte];
-    [deviceTokenData appendBytes:&byte length:1];
+  @try {
+    // APNs device tokens are an even-length hex string; anything else (e.g. an FCM
+    // token passed on iOS) previously crashed the hex-decode below (PLO-4202) - skip it.
+    NSCharacterSet *nonHex = [[NSCharacterSet characterSetWithCharactersInString:@"0123456789abcdefABCDEF"] invertedSet];
+    if (token.length == 0 || token.length % 2 != 0 ||
+        [token rangeOfCharacterFromSet:nonHex].location != NSNotFound) {
+      NSLog(@"[Plotline] setToken: not an APNs hex token (length=%lu); skipping", (unsigned long)token.length);
+      return;
+    }
+    NSMutableData *deviceTokenData = [NSMutableData data];
+    for (NSUInteger i = 0; i + 2 <= token.length; i += 2) {
+      unsigned int byte = 0;
+      [[NSScanner scannerWithString:[token substringWithRange:NSMakeRange(i, 2)]] scanHexInt:&byte];
+      unsigned char byteValue = (unsigned char)byte;
+      [deviceTokenData appendBytes:&byteValue length:1];
+    }
+    [PlotlinePush setPushTokenWithDeviceToken:deviceTokenData];
+  } @catch (NSException *exception) {
+    [RNPlotline logAndReportException:exception forMethod:@"setToken"];
   }
-  [PlotlinePush setPushTokenWithDeviceToken:deviceTokenData];
 }
 
 
@@ -126,11 +211,21 @@ RCT_EXPORT_METHOD(isFeatureEnabled:(NSString *)key
                   rejecter:(RCTPromiseRejectBlock)reject)
 {
   @try {
+    // NOTE: the @try below guards ONLY the registration of the listener. The listener block
+    // itself runs asynchronously (when feature flags load), on the SDK's callback thread, so
+    // any exception thrown by isFeatureEnabledWithKey: inside it is NOT covered by this outer
+    // @try - it would escape as an uncaught NSException (PLO-4202). Guard the block body too.
     [Plotline setOnFeatureFlagsLoadedListenerWithFeatureFlagsLoadedListener:^{
-        BOOL result = [Plotline isFeatureEnabledWithKey:key];
-        resolve(@(result));
+        @try {
+          BOOL result = [Plotline isFeatureEnabledWithKey:key];
+          resolve(@(result));
+        } @catch (NSException *exception) {
+          [RNPlotline logAndReportException:exception forMethod:@"isFeatureEnabled"];
+          reject(@"error", exception.reason, nil);
+        }
     }];
   } @catch (NSException *exception) {
+    [RNPlotline logAndReportException:exception forMethod:@"isFeatureEnabled"];
     reject(@"error", exception.reason, nil); // Handle errors
   }
 }
@@ -142,10 +237,16 @@ RCT_EXPORT_METHOD(getFeatureFlag:(NSString *)key
 {
   @try {
     [Plotline setOnFeatureFlagsLoadedListenerWithFeatureFlagsLoadedListener:^{
-        NSString *result = [Plotline getFeatureFlagWithKey:key];
-        resolve(result);
+        @try {
+          NSString *result = [Plotline getFeatureFlagWithKey:key];
+          resolve(result);
+        } @catch (NSException *exception) {
+          [RNPlotline logAndReportException:exception forMethod:@"getFeatureFlag"];
+          reject(@"error", exception.reason, nil);
+        }
     }];
   } @catch (NSException *exception) {
+    [RNPlotline logAndReportException:exception forMethod:@"getFeatureFlag"];
     reject(@"error", exception.reason, nil); // Handle errors
   }
 }
@@ -157,10 +258,16 @@ RCT_EXPORT_METHOD(getFeatureFlagPayload:(NSString *)key
 {
   @try {
     [Plotline setOnFeatureFlagsLoadedListenerWithFeatureFlagsLoadedListener:^{
-        NSString *result = [Plotline getFeatureFlagPayloadWithKey:key];
-        resolve(result);
+        @try {
+          NSString *result = [Plotline getFeatureFlagPayloadWithKey:key];
+          resolve(result);
+        } @catch (NSException *exception) {
+          [RNPlotline logAndReportException:exception forMethod:@"getFeatureFlagPayload"];
+          reject(@"error", exception.reason, nil);
+        }
     }];
   } @catch (NSException *exception) {
+    [RNPlotline logAndReportException:exception forMethod:@"getFeatureFlagPayload"];
     reject(@"error", exception.reason, nil); // Handle errors
   }
 }
@@ -168,4 +275,3 @@ RCT_EXPORT_METHOD(getFeatureFlagPayload:(NSString *)key
 RCT_EXPORT_MODULE();
 
 @end
-  

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "plotline-engage",
-  "version": "5.6.2",
+  "version": "5.6.4",
   "description": "React Native plugin for Plotline",
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1"