playwright-slack-report-burak 3.0.2 → 3.0.3

package/dist/src/ResultsParser.js

@@ -343,19 +343,53 @@ class ResultsParser {
 
     async fetchAllArtifacts() {
         const summariesDir = path.join('./', 'playwright-report');
-        while (!this.allNodeSummaryFilesExist() || !this.allBlobZipsExist()) {
-          console.log('Waiting for all blob zips to exist...');
-          if (!fs.existsSync(summariesDir)) {
-              fs.mkdirSync(summariesDir, { recursive: true });
-          }
-          // Fetch artifacts for shards 1 to totalShardCount-1 (if using 1-based) or 0 to totalShardCount-1 (if 0-based)
-          // Since we're shard 0, we need to fetch from other shards
-          // The workflow uses 1-based shards (1, 2, 3...), but we need to map them to 0-based internally (0, 1, 2...)
-          // So shard 1 in workflow = shard 0 internally, shard 2 = shard 1, etc.
-          for (let i = 1; i < this.totalShardCount; i++) {            
-              await this.fetchArtifact(i, `node_summary_${i}.json`, summariesDir);
-              await this.fetchArtifact(i, `blob-report-node-${i}.zip`, summariesDir);
-          }
+        if (!fs.existsSync(summariesDir)) {
+            fs.mkdirSync(summariesDir, { recursive: true });
+        }
+        
+        console.log(`Shard 0: Waiting for artifacts from ${this.totalShardCount - 1} other shard(s)...`);
+        
+        // Fetch artifacts for shards 1 to totalShardCount-1 (since we're shard 0)
+        // We need to fetch from all other shards before proceeding
+        for (let i = 1; i < this.totalShardCount; i++) {
+            console.log(`Shard 0: Fetching artifacts from shard ${i}...`);
+            await this.fetchArtifact(i, `node_summary_${i}.json`, summariesDir);
+            await this.fetchArtifact(i, `blob-report-node-${i}.zip`, summariesDir);
+        }
+        
+        // After fetching, verify all files exist and wait if needed
+        let retryCount = 0;
+        const maxRetries = 60; // Wait up to 10 minutes (60 * 10 seconds)
+        
+        while ((!this.allNodeSummaryFilesExist() || !this.allBlobZipsExist()) && retryCount < maxRetries) {
+            console.log(`Shard 0: Waiting for all artifacts to be available (attempt ${retryCount + 1}/${maxRetries})...`);
+            
+            // Re-fetch any missing artifacts
+            for (let i = 1; i < this.totalShardCount; i++) {
+                const nodeSummaryFile = path.join(summariesDir, `node_summary_${i}.json`);
+                const blobZipFile = path.join(summariesDir, `blob-report-node-${i}.zip`);
+                
+                if (!fs.existsSync(nodeSummaryFile)) {
+                    console.log(`Shard 0: Re-fetching missing node_summary_${i}.json...`);
+                    await this.fetchArtifact(i, `node_summary_${i}.json`, summariesDir);
+                }
+                
+                if (!fs.existsSync(blobZipFile)) {
+                    console.log(`Shard 0: Re-fetching missing blob-report-node-${i}.zip...`);
+                    await this.fetchArtifact(i, `blob-report-node-${i}.zip`, summariesDir);
+                }
+            }
+            
+            retryCount++;
+            if (!this.allNodeSummaryFilesExist() || !this.allBlobZipsExist()) {
+                await new Promise(resolve => setTimeout(resolve, 10000)); // Wait 10 seconds before retry
+            }
+        }
+        
+        if (this.allNodeSummaryFilesExist() && this.allBlobZipsExist()) {
+            console.log(`Shard 0: Successfully fetched all artifacts from ${this.totalShardCount - 1} other shard(s).`);
+        } else {
+            console.warn(`Shard 0: Warning - Some artifacts may still be missing after ${maxRetries} attempts.`);
         }
     }
 

package/dist/src/SlackReporter.js

@@ -70,16 +70,15 @@ class SlackReporter {
             this.log(message);
             return;
         }
-        const resultSummary = await this.resultsParser.getParsedResults();
         // SHARDING SUPPORT - Stop slack messages for non-zero index shard(s)
-        // The workflow uses 1-based shards (1, 2, 3...), but we need to determine which shard we are
-        // Only shard 0 (0-based) or shard 1 (1-based) should post when aggregating
+        // Only shard 0 (0-based) should post when aggregating results from multiple shards
         
+        // Detect shard index from multiple sources (GitHub Actions compatible)
         let currentShardIndex = process.env.MATRIX_SHARD !== undefined 
             ? process.env.MATRIX_SHARD 
             : (process.env.MATRIX_INDEX !== undefined ? process.env.MATRIX_INDEX : undefined);
         
-        // Get shard info from ResultsParser which might have detected it from artifact fetching
+        // Get shard info from ResultsParser which might have detected it
         const parserShardIndex = this.resultsParser.shardIndex;
         const parserTotalShards = this.resultsParser.totalShardCount;
         
@@ -91,30 +90,27 @@ class SlackReporter {
             currentShardIndex = parserShardIndex.toString();
         }
         
-        // CRITICAL: If we're in CI and don't know which shard we are, we MUST block posting
-        // This prevents all shards from posting when MATRIX_SHARD is not set
-        // Exception: If we're certain it's a single shard (totalShards === 1 AND no artifacts to fetch)
-        if (process.env.CI && currentShardIndex === undefined) {
-            // In CI without shard index = assume multiple shards and block all posts
-            // Only shard 0/1 should post when aggregating, but we can't detect it without MATRIX_SHARD
-            this.log(`❌ CI environment detected but shard index not set (MATRIX_SHARD/MATRIX_INDEX missing).`);
+        // Convert to number for comparison (default to 0 if undefined)
+        const shardIndexNum = currentShardIndex !== undefined ? parseInt(currentShardIndex, 10) : 0;
+        
+        // CRITICAL: For GitHub Actions with multiple shards, only shard 0 should post
+        // If we're in CI with multiple shards and don't know which shard we are, block all posts
+        // This prevents duplicate messages when MATRIX_SHARD/MATRIX_INDEX is not set
+        if (process.env.CI && totalShards > 1 && currentShardIndex === undefined) {
+            this.log(`❌ GitHub Actions detected with ${totalShards} shards but shard index not set (MATRIX_SHARD/MATRIX_INDEX missing).`);
             this.log(`❌ Skipping Slack report to prevent duplicate messages from all shards.`);
             this.log(`💡 Fix: Add these env vars to your workflow:`);
             this.log(`💡   env:`);
-            this.log(`💡     MATRIX_SHARD: $\{\{ matrix.shard - 1 \}\}  # 0-based (shard 1 posts)`);
+            this.log(`💡     MATRIX_SHARD: $\{\{ strategy.job-index \}\}  # 0-based (only shard 0 posts)`);
             this.log(`💡     MATRIX_COUNT: $\{\{ strategy.job-total \}\}`);
-            this.log(`💡   OR use 1-based: MATRIX_SHARD: $\{\{ matrix.shard \}\} (then only shard 1 posts)`);
             return;
         }
         
-        // Convert to number for comparison
-        const shardIndexNum = currentShardIndex !== undefined ? parseInt(currentShardIndex, 10) : 0;
-        
-        // Only allow shard 0 (0-based) or shard 1 (1-based) to post when there are multiple shards
+        // Only allow shard 0 (0-based) to post when there are multiple shards
         // This ensures only one shard posts the aggregated report
-        if (totalShards > 1 && shardIndexNum !== 0 && shardIndexNum !== 1) {
+        if (totalShards > 1 && shardIndexNum !== 0) {
             this.log(`❌ Stopping reporter for non-zero index shard ${currentShardIndex} of ${totalShards}`);
-            this.log(`ℹ️ Only shard 0 (0-based) or shard 1 (1-based) will post the aggregated report.`);
+            this.log(`ℹ️ Only shard 0 will post the aggregated report.`);
             return;
         }
         
@@ -124,6 +120,8 @@ class SlackReporter {
         } else {
             this.log(`ℹ️ Multiple shards detected (${totalShards}). Shard ${currentShardIndex} will post aggregated report.`);
         }
+        
+        const resultSummary = await this.resultsParser.getParsedResults();
         resultSummary.meta = this.meta;
         const maxRetry = Math.max(...resultSummary.tests.map((o) => o.retry));
         if (this.sendResults === 'on-failure'

package/package.json

@@ -31,7 +31,7 @@
     "lint-fix": "npx eslint . --ext .ts --fix"
   },
   "name": "playwright-slack-report-burak",
-  "version": "3.0.2",
+  "version": "3.0.3",
   "main": "index.js",
   "types": "dist/index.d.ts",
   "author": "Burak B. <burak.boluk@hotmail.com>",