playwright-slack-report-burak 3.0.15 → 3.0.16

package/dist/src/SlackReporter.js

@@ -46,9 +46,11 @@ class SlackReporter {
     suite;
     separateFlaky = false;
     logs = [];
+    fullConfig;
     onBegin(fullConfig, suite) {
         // Log package version
         console.log(`📦 [SlackReporter] playwright-slack-report-burak v${packageVersion}`);
+        this.fullConfig = fullConfig;
         this.suite = suite;
         this.logs = [];
         const slackReporterConfig = fullConfig.reporter.filter((f) => f[0].toLowerCase().includes('slackreporter'))[0][1];
@@ -323,38 +325,66 @@ class SlackReporter {
         
         this.log('🔍 [Shard Detection] Starting shard detection logic...');
         
+        // Check if we're actually running in GitHub Actions (not just env vars set locally)
+        const isActuallyInGitHubActions = process.env.GITHUB_ACTIONS === 'true' && 
+                                          process.env.GITHUB_RUN_ID !== undefined &&
+                                          process.env.GITHUB_RUNNER_NAME !== undefined;
+        
         // Log all relevant environment variables
         this.log(`🔍 [Shard Detection] Environment variables:`);
         this.log(`🔍   CI: ${process.env.CI !== undefined ? `"${process.env.CI}"` : 'undefined'}`);
         this.log(`🔍   GITHUB_ACTIONS: ${process.env.GITHUB_ACTIONS !== undefined ? `"${process.env.GITHUB_ACTIONS}"` : 'undefined'}`);
         this.log(`🔍   GITHUB_JOB: ${process.env.GITHUB_JOB !== undefined ? `"${process.env.GITHUB_JOB}"` : 'undefined'}`);
+        this.log(`🔍   GITHUB_RUN_ID: ${process.env.GITHUB_RUN_ID !== undefined ? `"${process.env.GITHUB_RUN_ID}"` : 'undefined'}`);
+        this.log(`🔍   GITHUB_RUNNER_NAME: ${process.env.GITHUB_RUNNER_NAME !== undefined ? `"${process.env.GITHUB_RUNNER_NAME}"` : 'undefined'}`);
         this.log(`🔍   MATRIX_SHARD: ${process.env.MATRIX_SHARD !== undefined ? `"${process.env.MATRIX_SHARD}"` : 'undefined'}`);
         this.log(`🔍   MATRIX_INDEX: ${process.env.MATRIX_INDEX !== undefined ? `"${process.env.MATRIX_INDEX}"` : 'undefined'}`);
         this.log(`🔍   MATRIX_COUNT: ${process.env.MATRIX_COUNT !== undefined ? `"${process.env.MATRIX_COUNT}"` : 'undefined'}`);
         
-        // Step 1: Try GitHub Actions API detection (most robust for GitHub Actions)
+        // Check Playwright's shard config (highest priority for local runs)
+        let playwrightShardInfo = null;
+        if (this.fullConfig && this.fullConfig.shard) {
+            playwrightShardInfo = {
+                current: this.fullConfig.shard.current,
+                total: this.fullConfig.shard.total
+            };
+            this.log(`🔍 [Shard Detection] Found Playwright shard config: ${playwrightShardInfo.current}/${playwrightShardInfo.total}`);
+        }
+        
+        // Step 1: Try GitHub Actions API detection (only if actually in GitHub Actions)
         let githubApiShardInfo = null;
-        if (process.env.GITHUB_ACTIONS === 'true') {
-            this.log(`🔍 [Shard Detection] Attempting GitHub Actions API detection...`);
+        if (isActuallyInGitHubActions) {
+            this.log(`🔍 [Shard Detection] Actually running in GitHub Actions - attempting API detection...`);
             githubApiShardInfo = await this.detectGitHubActionsShardInfo();
+        } else if (process.env.GITHUB_ACTIONS === 'true') {
+            this.log(`🔍 [Shard Detection] GitHub Actions env vars set but not actually in runner - skipping API detection`);
         }
         
-        // Step 2: Detect shard index from environment variables (priority)
-        let currentShardIndex = process.env.MATRIX_SHARD !== undefined 
-            ? process.env.MATRIX_SHARD 
-            : (process.env.MATRIX_INDEX !== undefined ? process.env.MATRIX_INDEX : undefined);
-        
-        // Step 3: Use GitHub API detection if env vars not set
-        if (currentShardIndex === undefined && githubApiShardInfo) {
+        // Step 2: Detect shard index (priority order: Playwright config > env vars > GitHub API)
+        let currentShardIndex;
+        if (playwrightShardInfo) {
+            // Playwright uses 1-based indexing, convert to 0-based
+            currentShardIndex = (playwrightShardInfo.current - 1).toString();
+            this.log(`🔍 [Shard Detection] Using Playwright shard config (converted to 0-based): "${currentShardIndex}"`);
+        } else if (process.env.MATRIX_SHARD !== undefined) {
+            currentShardIndex = process.env.MATRIX_SHARD;
+            this.log(`🔍 [Shard Detection] Using MATRIX_SHARD env var: "${currentShardIndex}"`);
+        } else if (process.env.MATRIX_INDEX !== undefined) {
+            currentShardIndex = process.env.MATRIX_INDEX;
+            this.log(`🔍 [Shard Detection] Using MATRIX_INDEX env var: "${currentShardIndex}"`);
+        } else if (githubApiShardInfo) {
             currentShardIndex = githubApiShardInfo.shardIndex.toString();
             this.log(`🔍 [Shard Detection] Using GitHub API detected shardIndex: "${currentShardIndex}"`);
         }
         
         this.log(`🔍 [Shard Detection] Initial currentShardIndex: ${currentShardIndex !== undefined ? `"${currentShardIndex}"` : 'undefined'}`);
         
-        // Step 4: Get shard count from multiple sources (priority order)
+        // Step 3: Get shard count from multiple sources (priority order)
         let totalShards;
-        if (process.env.MATRIX_COUNT !== undefined) {
+        if (playwrightShardInfo) {
+            totalShards = playwrightShardInfo.total;
+            this.log(`🔍 [Shard Detection] Using Playwright shard config totalShards: ${totalShards}`);
+        } else if (process.env.MATRIX_COUNT !== undefined) {
             totalShards = parseInt(process.env.MATRIX_COUNT, 10);
             this.log(`🔍 [Shard Detection] Using MATRIX_COUNT env var: ${totalShards}`);
         } else if (githubApiShardInfo && githubApiShardInfo.totalShards > 1) {
@@ -390,7 +420,8 @@ class SlackReporter {
         
         // CRITICAL: In CI (especially GitHub Actions), if we can't detect shard info, block posting
         // This prevents duplicate messages when running with multiple shards
-        if (process.env.CI && currentShardIndex === undefined) {
+        // BUT: Don't block if we're running locally (even if CI env vars are set)
+        if (isActuallyInGitHubActions && currentShardIndex === undefined) {
             if (process.env.GITHUB_ACTIONS === 'true') {
                 this.log(`❌ [Shard Detection] BLOCKING: GitHub Actions detected but shard index cannot be determined.`);
                 this.log(`❌   Attempted: GitHub API detection ${githubApiShardInfo ? 'succeeded' : 'failed'}, env vars not set`);
@@ -421,11 +452,17 @@ class SlackReporter {
         // This ensures ResultsParser always has correct values, even if we block posting
         this.resultsParser.updateShardInfo(shardIndexNum, totalShards);
         
+        // For local runs with CI env vars set but not actually in CI, allow posting if single shard
+        // or if shard index is 0
+        if (!isActuallyInGitHubActions && process.env.CI && totalShards > 1 && currentShardIndex === undefined) {
+            this.log(`⚠️ [Shard Detection] Local run with CI env vars but shard info unclear - allowing post (may cause duplicates)`);
+        }
+        
         // CRITICAL: For GitHub Actions with multiple shards, only shard 0 should post
         // If we're in CI with multiple shards and don't know which shard we are, block all posts
         // This prevents duplicate messages when MATRIX_SHARD/MATRIX_INDEX is not set
-        if (process.env.CI && totalShards > 1 && currentShardIndex === undefined) {
-            this.log(`❌ [Shard Detection] BLOCKING: CI environment detected with ${totalShards} shards but shard index not set (MATRIX_SHARD/MATRIX_INDEX missing).`);
+        if (isActuallyInGitHubActions && totalShards > 1 && currentShardIndex === undefined) {
+            this.log(`❌ [Shard Detection] BLOCKING: GitHub Actions detected with ${totalShards} shards but shard index not set (MATRIX_SHARD/MATRIX_INDEX missing).`);
             this.log(`❌ Skipping Slack report to prevent duplicate messages from all shards.`);
             this.log(`💡 Fix: Add these env vars to your workflow:`);
             this.log(`💡   env:`);

package/package.json

@@ -32,7 +32,7 @@
     "lint-fix": "npx eslint . --ext .ts --fix"
   },
   "name": "playwright-slack-report-burak",
-  "version": "3.0.15",
+  "version": "3.0.16",
   "main": "index.js",
   "types": "dist/index.d.ts",
   "author": "Burak B. <burak.boluk@hotmail.com>",