playwright-slack-report-burak 3.0.0 → 3.0.2

package/dist/src/SlackReporter.js

@@ -72,19 +72,58 @@ class SlackReporter {
         }
         const resultSummary = await this.resultsParser.getParsedResults();
         // SHARDING SUPPORT - Stop slack messages for non-zero index shard(s)
-        // Support both explicit MATRIX_SHARD/MATRIX_INDEX and workflow-style 1-based indexing
-        // If MATRIX_SHARD is not set, shard 0 will still send reports (handles single shard case)
-        const currentShardIndex = process.env.MATRIX_SHARD !== undefined 
+        // The workflow uses 1-based shards (1, 2, 3...), but we need to determine which shard we are
+        // Only shard 0 (0-based) or shard 1 (1-based) should post when aggregating
+        
+        let currentShardIndex = process.env.MATRIX_SHARD !== undefined 
             ? process.env.MATRIX_SHARD 
             : (process.env.MATRIX_INDEX !== undefined ? process.env.MATRIX_INDEX : undefined);
         
-        // Only skip if explicitly set and not 0 (or '0')
-        // This allows shard 0 to send reports even when MATRIX_SHARD is not set
-        if (currentShardIndex !== undefined && currentShardIndex !== '0' && currentShardIndex !== 0) {
-            const totalShards = process.env.MATRIX_COUNT || '1';
+        // Get shard info from ResultsParser which might have detected it from artifact fetching
+        const parserShardIndex = this.resultsParser.shardIndex;
+        const parserTotalShards = this.resultsParser.totalShardCount;
+        
+        // Use parser values if env vars not set
+        const totalShards = process.env.MATRIX_COUNT ? parseInt(process.env.MATRIX_COUNT, 10) : parserTotalShards;
+        
+        // If we still don't have shard index, try to infer from parser
+        if (currentShardIndex === undefined && parserShardIndex !== undefined) {
+            currentShardIndex = parserShardIndex.toString();
+        }
+        
+        // CRITICAL: If we're in CI and don't know which shard we are, we MUST block posting
+        // This prevents all shards from posting when MATRIX_SHARD is not set
+        // Exception: If we're certain it's a single shard (totalShards === 1 AND no artifacts to fetch)
+        if (process.env.CI && currentShardIndex === undefined) {
+            // In CI without shard index = assume multiple shards and block all posts
+            // Only shard 0/1 should post when aggregating, but we can't detect it without MATRIX_SHARD
+            this.log(`❌ CI environment detected but shard index not set (MATRIX_SHARD/MATRIX_INDEX missing).`);
+            this.log(`❌ Skipping Slack report to prevent duplicate messages from all shards.`);
+            this.log(`💡 Fix: Add these env vars to your workflow:`);
+            this.log(`💡   env:`);
+            this.log(`💡     MATRIX_SHARD: $\{\{ matrix.shard - 1 \}\}  # 0-based (shard 1 posts)`);
+            this.log(`💡     MATRIX_COUNT: $\{\{ strategy.job-total \}\}`);
+            this.log(`💡   OR use 1-based: MATRIX_SHARD: $\{\{ matrix.shard \}\} (then only shard 1 posts)`);
+            return;
+        }
+        
+        // Convert to number for comparison
+        const shardIndexNum = currentShardIndex !== undefined ? parseInt(currentShardIndex, 10) : 0;
+        
+        // Only allow shard 0 (0-based) or shard 1 (1-based) to post when there are multiple shards
+        // This ensures only one shard posts the aggregated report
+        if (totalShards > 1 && shardIndexNum !== 0 && shardIndexNum !== 1) {
             this.log(`❌ Stopping reporter for non-zero index shard ${currentShardIndex} of ${totalShards}`);
+            this.log(`ℹ️ Only shard 0 (0-based) or shard 1 (1-based) will post the aggregated report.`);
             return;
         }
+        
+        // Single shard - always allow posting
+        if (totalShards === 1) {
+            this.log(`ℹ️ Single shard detected. Posting Slack report.`);
+        } else {
+            this.log(`ℹ️ Multiple shards detected (${totalShards}). Shard ${currentShardIndex} will post aggregated report.`);
+        }
         resultSummary.meta = this.meta;
         const maxRetry = Math.max(...resultSummary.tests.map((o) => o.retry));
         if (this.sendResults === 'on-failure'

package/package.json

@@ -31,7 +31,7 @@
     "lint-fix": "npx eslint . --ext .ts --fix"
   },
   "name": "playwright-slack-report-burak",
-  "version": "3.0.0",
+  "version": "3.0.2",
   "main": "index.js",
   "types": "dist/index.d.ts",
   "author": "Burak B. <burak.boluk@hotmail.com>",