playwright-core 1.58.0-alpha-1764708599000 → 1.58.0-alpha-2025-12-04

package/lib/protocol/validator.js

@@ -512,7 +512,6 @@ import_validatorPrimitives.scheme.BrowserTypeLaunchParams = (0, import_validator
   timeout: import_validatorPrimitives.tFloat,
   env: (0, import_validatorPrimitives.tOptional)((0, import_validatorPrimitives.tArray)((0, import_validatorPrimitives.tType)("NameValue"))),
   headless: (0, import_validatorPrimitives.tOptional)(import_validatorPrimitives.tBoolean),
-  devtools: (0, import_validatorPrimitives.tOptional)(import_validatorPrimitives.tBoolean),
   proxy: (0, import_validatorPrimitives.tOptional)((0, import_validatorPrimitives.tObject)({
     server: import_validatorPrimitives.tString,
     bypass: (0, import_validatorPrimitives.tOptional)(import_validatorPrimitives.tString),
@@ -542,7 +541,6 @@ import_validatorPrimitives.scheme.BrowserTypeLaunchPersistentContextParams = (0,
   timeout: import_validatorPrimitives.tFloat,
   env: (0, import_validatorPrimitives.tOptional)((0, import_validatorPrimitives.tArray)((0, import_validatorPrimitives.tType)("NameValue"))),
   headless: (0, import_validatorPrimitives.tOptional)(import_validatorPrimitives.tBoolean),
-  devtools: (0, import_validatorPrimitives.tOptional)(import_validatorPrimitives.tBoolean),
   proxy: (0, import_validatorPrimitives.tOptional)((0, import_validatorPrimitives.tObject)({
     server: import_validatorPrimitives.tString,
     bypass: (0, import_validatorPrimitives.tOptional)(import_validatorPrimitives.tString),

package/lib/remote/playwrightServer.js

@@ -321,8 +321,7 @@ const defaultLaunchOptions = {
   handleSIGINT: false,
   handleSIGTERM: false,
   handleSIGHUP: false,
-  headless: true,
-  devtools: false
+  headless: true
 };
 const optionsThatAllowBrowserReuse = [
   "headless",

package/lib/server/bidi/bidiBrowser.js

@@ -130,10 +130,13 @@ class BidiBrowser extends import_browser.Browser {
       const page2 = this._findPageForFrame(parentFrameId);
       if (page2) {
         page2._session.addFrameBrowsingContext(event.context);
-        page2._page.frameManager.frameAttached(event.context, parentFrameId);
-        const frame = page2._page.frameManager.frame(event.context);
-        if (frame)
-          frame._url = event.url;
+        const frame = page2._page.frameManager.frameAttached(event.context, parentFrameId);
+        frame._url = event.url;
+        page2._getFrameNode(frame).then((node) => {
+          const attributes = node?.value?.attributes;
+          frame._name = attributes?.name ?? attributes?.id ?? "";
+        });
+        return;
       }
       return;
     }

package/lib/server/bidi/bidiChromium.js

@@ -112,8 +112,6 @@ class BidiChromium extends import_browserType.BrowserType {
     if (import_os.default.platform() === "darwin") {
       chromeArguments.push("--enable-unsafe-swiftshader");
     }
-    if (options.devtools)
-      chromeArguments.push("--auto-open-devtools-for-tabs");
     if (options.headless) {
       chromeArguments.push("--headless");
       chromeArguments.push(

package/lib/server/bidi/bidiPage.js

@@ -178,10 +178,11 @@ class BidiPage {
   }
   _onNavigationCommitted(params) {
     const frameId = params.context;
+    const frame = this._page.frameManager.frame(frameId);
     this._page.frameManager.frameCommittedNewDocumentNavigation(
       frameId,
       params.url,
-      "",
+      frame._name,
       params.navigation,
       /* initial */
       false
@@ -536,26 +537,22 @@ ${params.stackTrace?.callFrames.map((f) => {
     const parent = frame.parentFrame();
     if (!parent)
       throw new Error("Frame has been detached.");
-    const parentContext = await parent._mainContext();
-    const list = await parentContext.evaluateHandle(() => {
-      return [...document.querySelectorAll("iframe,frame")];
-    });
-    const length = await list.evaluate((list2) => list2.length);
-    let foundElement = null;
-    for (let i = 0; i < length; i++) {
-      const element = await list.evaluateHandle((list2, i2) => list2[i2], i);
-      const candidate = await element.contentFrame();
-      if (frame === candidate) {
-        foundElement = element;
-        break;
-      } else {
-        element.dispose();
-      }
-    }
-    list.dispose();
-    if (!foundElement)
+    const node = await this._getFrameNode(frame);
+    if (!node?.sharedId)
       throw new Error("Frame has been detached.");
-    return foundElement;
+    const parentFrameExecutionContext = await parent._mainContext();
+    return await toBidiExecutionContext(parentFrameExecutionContext).remoteObjectForNodeId(parentFrameExecutionContext, { sharedId: node.sharedId });
+  }
+  async _getFrameNode(frame) {
+    const parent = frame.parentFrame();
+    if (!parent)
+      return void 0;
+    const result = await this._session.send("browsingContext.locateNodes", {
+      context: parent._id,
+      locator: { type: "context", value: { context: frame._id } }
+    });
+    const node = result.nodes[0];
+    return node;
   }
   shouldToggleStyleSheetToSyncAnimations() {
     return true;

package/lib/server/browserType.js

@@ -276,15 +276,14 @@ class BrowserType extends import_instrumentation.SdkObject {
     throw new Error("Connecting to SELENIUM_REMOTE_URL is only supported by Chromium");
   }
   _validateLaunchOptions(options) {
-    const { devtools = false } = options;
-    let { headless = !devtools, downloadsPath, proxy } = options;
+    let { headless = true, downloadsPath, proxy } = options;
     if ((0, import_debug.debugMode)() === "inspector")
       headless = false;
     if (downloadsPath && !import_path.default.isAbsolute(downloadsPath))
       downloadsPath = import_path.default.join(process.cwd(), downloadsPath);
     if (options.socksProxyPort)
       proxy = { server: `socks5://127.0.0.1:${options.socksProxyPort}` };
-    return { ...options, devtools, headless, downloadsPath, proxy };
+    return { ...options, headless, downloadsPath, proxy };
   }
   _createUserDataDirArgMisuseError(userDataDirArg) {
     switch (this.attribution.playwright.options.sdkLanguage) {

package/lib/server/chromium/chromium.js

@@ -128,13 +128,8 @@ class Chromium extends import_browserType.BrowserType {
     return directory ? new import_crDevTools.CRDevTools(import_path.default.join(directory, "devtools-preferences.json")) : void 0;
   }
   async connectToTransport(transport, options, browserLogsCollector) {
-    let devtools = this._devtools;
-    if (options.__testHookForDevTools) {
-      devtools = this._createDevTools();
-      await options.__testHookForDevTools(devtools);
-    }
     try {
-      return await import_crBrowser.CRBrowser.connect(this.attribution.playwright, transport, options, devtools);
+      return await import_crBrowser.CRBrowser.connect(this.attribution.playwright, transport, options, this._devtools);
     } catch (e) {
       if (browserLogsCollector.recentLogs().some((log) => log.includes("Failed to create a ProcessSingleton for your profile directory."))) {
         throw new Error(
@@ -287,8 +282,6 @@ class Chromium extends import_browserType.BrowserType {
     if (import_os.default.platform() === "darwin") {
       chromeArguments.push("--enable-unsafe-swiftshader");
     }
-    if (options.devtools)
-      chromeArguments.push("--auto-open-devtools-for-tabs");
     if (options.headless) {
       chromeArguments.push("--headless");
       chromeArguments.push(

package/lib/server/chromium/crDevTools.js

@@ -44,8 +44,6 @@ class CRDevTools {
         return;
       const parsed = JSON.parse(event.payload);
       let result = void 0;
-      if (this.__testHookOnBinding)
-        this.__testHookOnBinding(parsed);
       if (parsed.method === "getPreferences") {
         if (this._prefs === void 0) {
           try {

package/lib/utils/isomorphic/trace/snapshotServer.js

@@ -92,7 +92,10 @@ class SnapshotServer {
     headers.set("Access-Control-Allow-Origin", "*");
     headers.delete("Content-Length");
     headers.set("Content-Length", String(content.size));
-    headers.set("Cache-Control", "public, max-age=31536000");
+    if (this._snapshotStorage.hasResourceOverride(resource.request.url))
+      headers.set("Cache-Control", "no-store, no-cache, max-age=0");
+    else
+      headers.set("Cache-Control", "public, max-age=31536000");
     const { status } = resource.response;
     const isNullBodyStatus = status === 101 || status === 204 || status === 205 || status === 304;
     return new Response(isNullBodyStatus ? null : content, {

package/lib/utils/isomorphic/trace/snapshotStorage.js

@@ -29,6 +29,7 @@ class SnapshotStorage {
     this._cache = new import_lruCache.LRUCache(1e8);
     // 100MB per each trace
     this._contextToResources = /* @__PURE__ */ new Map();
+    this._resourceUrlsWithOverrides = /* @__PURE__ */ new Set();
   }
   addResource(contextId, resource) {
     resource.request.url = (0, import_snapshotRenderer.rewriteURLForCustomProtocol)(resource.request.url);
@@ -63,6 +64,15 @@ class SnapshotStorage {
   finalize() {
     for (const resources of this._contextToResources.values())
       resources.sort((a, b) => (a._monotonicTime || 0) - (b._monotonicTime || 0));
+    for (const frameSnapshots of this._frameSnapshots.values()) {
+      for (const snapshot of frameSnapshots.raw) {
+        for (const override of snapshot.resourceOverrides)
+          this._resourceUrlsWithOverrides.add(override.url);
+      }
+    }
+  }
+  hasResourceOverride(url) {
+    return this._resourceUrlsWithOverrides.has(url);
   }
   _ensureResourcesForContext(contextId) {
     let resources = this._contextToResources.get(contextId);