playwright-core 1.56.0-beta-1759527268000 → 1.57.0-alpha-2025-10-04

package/lib/client/playwright.js

@@ -43,10 +43,6 @@ class Playwright extends import_channelOwner.ChannelOwner {
     this._android._playwright = this;
     this._electron = import_electron.Electron.from(initializer.electron);
     this._electron._playwright = this;
-    this._bidiChromium = import_browserType.BrowserType.from(initializer._bidiChromium);
-    this._bidiChromium._playwright = this;
-    this._bidiFirefox = import_browserType.BrowserType.from(initializer._bidiFirefox);
-    this._bidiFirefox._playwright = this;
     this.devices = this._connection.localUtils()?.devices ?? {};
     this.selectors = new import_selectors.Selectors(this._connection._platform);
     this.errors = { TimeoutError: import_errors.TimeoutError };
@@ -55,7 +51,7 @@ class Playwright extends import_channelOwner.ChannelOwner {
     return channel._object;
   }
   _browserTypes() {
-    return [this.chromium, this.firefox, this.webkit, this._bidiChromium, this._bidiFirefox];
+    return [this.chromium, this.firefox, this.webkit];
   }
   _preLaunchedBrowser() {
     const browser = import_browser.Browser.from(this._initializer.preLaunchedBrowser);

package/lib/inProcessFactory.js

@@ -43,8 +43,6 @@ function createInProcessPlaywright() {
   playwrightAPI.firefox._serverLauncher = new import_browserServerImpl.BrowserServerLauncherImpl("firefox");
   playwrightAPI.webkit._serverLauncher = new import_browserServerImpl.BrowserServerLauncherImpl("webkit");
   playwrightAPI._android._serverLauncher = new import_androidServerImpl.AndroidServerLauncherImpl();
-  playwrightAPI._bidiChromium._serverLauncher = new import_browserServerImpl.BrowserServerLauncherImpl("_bidiChromium");
-  playwrightAPI._bidiFirefox._serverLauncher = new import_browserServerImpl.BrowserServerLauncherImpl("_bidiFirefox");
   dispatcherConnection.onmessage = (message) => setImmediate(() => clientConnection.dispatch(message));
   clientConnection.onmessage = (message) => setImmediate(() => dispatcherConnection.dispatch(message));
   clientConnection.toImpl = (x) => {

package/lib/protocol/validator.js

@@ -383,8 +383,6 @@ import_validatorPrimitives.scheme.PlaywrightInitializer = (0, import_validatorPr
   chromium: (0, import_validatorPrimitives.tChannel)(["BrowserType"]),
   firefox: (0, import_validatorPrimitives.tChannel)(["BrowserType"]),
   webkit: (0, import_validatorPrimitives.tChannel)(["BrowserType"]),
-  _bidiChromium: (0, import_validatorPrimitives.tChannel)(["BrowserType"]),
-  _bidiFirefox: (0, import_validatorPrimitives.tChannel)(["BrowserType"]),
   android: (0, import_validatorPrimitives.tChannel)(["Android"]),
   electron: (0, import_validatorPrimitives.tChannel)(["Electron"]),
   utils: (0, import_validatorPrimitives.tOptional)((0, import_validatorPrimitives.tChannel)(["LocalUtils"])),

package/lib/server/bidi/bidiChromium.js

@@ -40,7 +40,7 @@ var import_chromiumSwitches = require("../chromium/chromiumSwitches");
 var import_chromium = require("../chromium/chromium");
 class BidiChromium extends import_browserType.BrowserType {
   constructor(parent) {
-    super(parent, "_bidiChromium");
+    super(parent, "chromium");
   }
   async connectToTransport(transport, options, browserLogsCollector) {
     const bidiTransport = await require("./bidiOverCdp").connectBidiOverCdp(transport);

package/lib/server/bidi/bidiFirefox.js

@@ -41,7 +41,7 @@ var import_firefoxPrefs = require("./third_party/firefoxPrefs");
 var import_manualPromise = require("../../utils/isomorphic/manualPromise");
 class BidiFirefox extends import_browserType.BrowserType {
   constructor(parent) {
-    super(parent, "_bidiFirefox");
+    super(parent, "firefox");
   }
   executablePath() {
     return "";

package/lib/server/chromium/chromium.js

@@ -55,11 +55,22 @@ var import_fileUtils = require("../utils/fileUtils");
 var import_processLauncher = require("../utils/processLauncher");
 const ARTIFACTS_FOLDER = import_path.default.join(import_os.default.tmpdir(), "playwright-artifacts-");
 class Chromium extends import_browserType.BrowserType {
-  constructor(parent) {
+  constructor(parent, bidiChromium) {
     super(parent, "chromium");
+    this._bidiChromium = bidiChromium;
     if ((0, import_utils.debugMode)() === "inspector")
       this._devtools = this._createDevTools();
   }
+  launch(progress, options, protocolLogger) {
+    if (options.channel?.startsWith("bidi-"))
+      return this._bidiChromium.launch(progress, options, protocolLogger);
+    return super.launch(progress, options, protocolLogger);
+  }
+  async launchPersistentContext(progress, userDataDir, options) {
+    if (options.channel?.startsWith("bidi-"))
+      return this._bidiChromium.launchPersistentContext(progress, userDataDir, options);
+    return super.launchPersistentContext(progress, userDataDir, options);
+  }
   async connectOverCDP(progress, endpointURL, options) {
     return await this._connectOverCDPInternal(progress, endpointURL, options);
   }

package/lib/server/dispatchers/browserContextDispatcher.js

@@ -118,7 +118,7 @@ class BrowserContextDispatcher extends import_dispatcher.Dispatcher {
       return true;
     };
     context.dialogManager.addDialogHandler(this._dialogHandler);
-    if (context._browser.options.name === "chromium") {
+    if (context._browser.options.name === "chromium" && this._object._browser instanceof import_crBrowser.CRBrowser) {
       for (const serviceWorker of context.serviceWorkers())
         this._dispatchEvent("serviceWorker", { worker: new import_pageDispatcher.WorkerDispatcher(this, serviceWorker) });
       this.addObjectListener(import_crBrowser.CRBrowserContext.CREvents.ServiceWorker, (serviceWorker) => this._dispatchEvent("serviceWorker", { worker: new import_pageDispatcher.WorkerDispatcher(this, serviceWorker) }));
@@ -277,7 +277,7 @@ class BrowserContextDispatcher extends import_dispatcher.Dispatcher {
     await import_recorderApp.RecorderApp.show(this._context, params);
   }
   async disableRecorder(params, progress) {
-    const recorder = import_recorder.Recorder.existingForContext(this._context);
+    const recorder = await import_recorder.Recorder.existingForContext(this._context);
     if (recorder)
       recorder.setMode("none");
   }

package/lib/server/dispatchers/playwrightDispatcher.js

@@ -39,15 +39,11 @@ class PlaywrightDispatcher extends import_dispatcher.Dispatcher {
     const chromium = new import_browserTypeDispatcher.BrowserTypeDispatcher(scope, playwright.chromium, denyLaunch);
     const firefox = new import_browserTypeDispatcher.BrowserTypeDispatcher(scope, playwright.firefox, denyLaunch);
     const webkit = new import_browserTypeDispatcher.BrowserTypeDispatcher(scope, playwright.webkit, denyLaunch);
-    const _bidiChromium = new import_browserTypeDispatcher.BrowserTypeDispatcher(scope, playwright._bidiChromium, denyLaunch);
-    const _bidiFirefox = new import_browserTypeDispatcher.BrowserTypeDispatcher(scope, playwright._bidiFirefox, denyLaunch);
     const android = new import_androidDispatcher.AndroidDispatcher(scope, playwright.android);
     const initializer = {
       chromium,
       firefox,
       webkit,
-      _bidiChromium,
-      _bidiFirefox,
       android,
       electron: new import_electronDispatcher.ElectronDispatcher(scope, playwright.electron, denyLaunch),
       utils: playwright.options.isServer ? void 0 : new import_localUtilsDispatcher.LocalUtilsDispatcher(scope, playwright),

package/lib/server/firefox/firefox.js

@@ -39,8 +39,19 @@ var import_ascii = require("../utils/ascii");
 var import_browserType = require("../browserType");
 var import_manualPromise = require("../../utils/isomorphic/manualPromise");
 class Firefox extends import_browserType.BrowserType {
-  constructor(parent) {
+  constructor(parent, bidiFirefox) {
     super(parent, "firefox");
+    this._bidiFirefox = bidiFirefox;
+  }
+  launch(progress, options, protocolLogger) {
+    if (options.channel?.startsWith("moz-"))
+      return this._bidiFirefox.launch(progress, options, protocolLogger);
+    return super.launch(progress, options, protocolLogger);
+  }
+  async launchPersistentContext(progress, userDataDir, options) {
+    if (options.channel?.startsWith("moz-"))
+      return this._bidiFirefox.launchPersistentContext(progress, userDataDir, options);
+    return super.launchPersistentContext(progress, userDataDir, options);
   }
   connectToTransport(transport, options) {
     return import_ffBrowser.FFBrowser.connect(this.attribution.playwright, transport, options);

package/lib/server/page.js

@@ -582,7 +582,8 @@ class Page extends import_instrumentation.SdkObject {
       this.closeReason = options.reason;
     const runBeforeUnload = !!options.runBeforeUnload;
     if (this._closedState !== "closing") {
-      this._closedState = "closing";
+      if (!runBeforeUnload)
+        this._closedState = "closing";
       await this.delegate.closePage(runBeforeUnload).catch((e) => import_debugLogger.debugLogger.log("error", e));
     }
     if (!runBeforeUnload)

package/lib/server/playwright.js

@@ -45,10 +45,8 @@ class Playwright extends import_instrumentation.SdkObject {
       onPageOpen: (page) => this._allPages.add(page),
       onPageClose: (page) => this._allPages.delete(page)
     }, null);
-    this.chromium = new import_chromium.Chromium(this);
-    this._bidiChromium = new import_bidiChromium.BidiChromium(this);
-    this._bidiFirefox = new import_bidiFirefox.BidiFirefox(this);
-    this.firefox = new import_firefox.Firefox(this);
+    this.chromium = new import_chromium.Chromium(this, new import_bidiChromium.BidiChromium(this));
+    this.firefox = new import_firefox.Firefox(this, new import_bidiFirefox.BidiFirefox(this));
     this.webkit = new import_webkit.WebKit(this);
     this.electron = new import_electron.Electron(this);
     this.android = new import_android.Android(this, new import_backendAdb.AdbBackend());

package/lib/server/recorder.js

@@ -112,8 +112,9 @@ class Recorder extends import_events.default {
     }
     return recorderPromise;
   }
-  static existingForContext(context) {
-    return context[recorderSymbol];
+  static async existingForContext(context) {
+    const recorderPromise = context[recorderSymbol];
+    return await recorderPromise;
   }
   static async _create(context, params = {}) {
     const recorder = new Recorder(context, params);

package/lib/server/registry/index.js

@@ -417,10 +417,7 @@ const DOWNLOAD_PATHS = {
     "mac15": "builds/android/%s/android.zip",
     "mac15-arm64": "builds/android/%s/android.zip",
     "win64": "builds/android/%s/android.zip"
-  },
-  // TODO(bidi): implement downloads.
-  "_bidiFirefox": {},
-  "_bidiChromium": {}
+  }
 };
 const registryDirectory = (() => {
   let result;
@@ -674,9 +671,9 @@ ${(0, import_ascii.wrapInASCIIBox)(prettyMessage, 1)}`);
       "win32": `\\Google\\Chrome SxS\\Application\\chrome.exe`
     }));
     this._executables.push({
-      type: "browser",
-      name: "_bidiChromium",
-      browserName: "_bidiChromium",
+      type: "channel",
+      name: "bidi-chromium",
+      browserName: "chromium",
       directory: chromium.dir,
       executablePath: () => chromiumExecutable,
       executablePathOrDie: (sdkLanguage) => executablePathOrDie("chromium", chromiumExecutable, chromium.installByDefault, sdkLanguage),
@@ -887,13 +884,14 @@ Run "${buildPlaywrightCLICommand(sdkLanguage, "install " + name)}"` : "";
           return executablePath2;
       }
       if (shouldThrow)
-        throw new Error(`Cannot find Firefox installation for channel '${name}' at the standard system paths.`);
+        throw new Error(`Cannot find Firefox installation for channel '${name}' at the standard system paths. ${`Tried paths:
+  ${prefixes.map((p) => import_path.default.join(p, suffix)).join("\n  ")}`}`);
       return void 0;
     };
     return {
       type: "channel",
       name,
-      browserName: "_bidiFirefox",
+      browserName: "firefox",
       directory: void 0,
       executablePath: (sdkLanguage) => executablePath(sdkLanguage, false),
       executablePathOrDie: (sdkLanguage) => executablePath(sdkLanguage, true),
@@ -934,7 +932,7 @@ Run "${buildPlaywrightCLICommand(sdkLanguage, "install " + name)}"` : "";
     return {
       type: "channel",
       name,
-      browserName: "_bidiChromium",
+      browserName: "chromium",
       directory: void 0,
       executablePath: (sdkLanguage) => executablePath(sdkLanguage, false),
       executablePathOrDie: (sdkLanguage) => executablePath(sdkLanguage, true),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "playwright-core",
-  "version": "1.56.0-beta-1759527268000",
+  "version": "1.57.0-alpha-2025-10-04",
   "description": "A high-level API to automate web browsers",
   "repository": {
     "type": "git",

package/types/types.d.ts

@@ -16290,8 +16290,6 @@ export type AndroidKey =
 
 export const _electron: Electron;
 export const _android: Android;
-export const _bidiChromium: BrowserType;
-export const _bidiFirefox: BrowserType;
 
 // This is required to not export everything by default. See https://github.com/Microsoft/TypeScript/issues/19545#issuecomment-340490459
 export {};