playov2-js-utilities 0.3.36 → 0.3.38

package/lib/models/scheduled.tasks.js

@@ -3,8 +3,18 @@ const Schema = mongoose.Schema;
 
 // compound index on queuId and taskId and status, so that a task is saved only once per queue
 const scheduledTaskSchema = new Schema({
+    httpMethod: {
+        type: String,
+        enum: ["GET", "POST", "PUT", "DELETE"],
+        default: "POST",
+    },
     taskId: { type: String, required: true },
     queueId: { type: String, required: true },
+    url: {
+        type: String,
+        required: true,
+    },
+    ttl: {},
     payload: {
 
     },
@@ -20,7 +30,7 @@ const scheduledTaskSchema = new Schema({
         type: String,
         enum: ['saved', 'executed', 'failed', 'cancelled'],
         default: 'saved',
-        required: true  
+        required: true
     },
     lastExecutionDetails: {
 

package/lib/taskscheduler/index.js

@@ -16,8 +16,9 @@ const MAX_RETRY_COUNT = 5;
  * @param {String} name - Optional - If "RetryableException", then function will be retried till MAX_RETRY_COUNT
  */
 function CTException(message, name) {
-    this.message = message;
-    this.name = name;
+    const error = new Error(message);
+    error.name = name;
+    return error;
 };
 
 /**
@@ -52,10 +53,15 @@ const saveFutureTask = async (queueId, taskId, payload, eta, count = MAX_RETRY_C
         await task.save();
 
     } catch (err) {
-        if (err.message !== "RetryableException") {
+        const errMessage = err && err.message ? err.message : 'Exception';
+        // in case there's an exception which shouldn't be retried, such as improper parameter, this throws the error to be 
+        // handled by the originating calling function
+        if (errMessage !== "RetryableException") {
             throw err;
         }
 
+        // This is a mechanism to handle unexpected network failure / disconnection to db.
+        // This seems lame though, probably should pair with set timeout for exponential back off.
         if (count === 0) {
             Logger.prepareAlertLog(requestId, { func: 'saveFutureTask', queueId, taskId, payload, eta, err }, 'saving future task failed!');
             throw err;
@@ -65,7 +71,6 @@ const saveFutureTask = async (queueId, taskId, payload, eta, count = MAX_RETRY_C
     }
 };
 
-
 const deleteScheduledTask = async (queueId, taskId, count = MAX_RETRY_COUNT, requestId) => {
     try {
         if (!queueId || !taskId) {
@@ -92,6 +97,5 @@ const deleteScheduledTask = async (queueId, taskId, count = MAX_RETRY_COUNT, req
 
 module.exports = {
     saveFutureTask,
-    // pushScheduledTaskToQueue,
     deleteScheduledTask
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "playov2-js-utilities",
-  "version": "0.3.36",
+  "version": "0.3.38",
   "description": "Private package for JS utility functions",
   "main": "index.js",
   "scripts": {