pixl-server-storage 3.2.5 → 3.2.7

package/engines/SQLite.js

@@ -393,12 +393,11 @@ module.exports = Class.create({
 		this.db.run( this.commands.delete, { $key: key }, function(err) {
 			// In sqlite3 callbacks `this` is special, and contains `changes`
 			if (!err && !this.changes) {
-				err = new Error("Not found");
+				err = new Error("Failed to delete object: " + key + ": Not found");
 				err.code = "NoSuchKey";
 			}
 			if (err) {
 				self.logError('sqlite', "Failed to delete object: " + key + ": " + err);
-				err = new Error("Failed to delete object: " + key + ": " + err);
 				return callback(err);
 			}
 			self.logDebug(9, "Delete complete: " + key);

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "pixl-server-storage",
-	"version": "3.2.5",
+	"version": "3.2.7",
 	"description": "A key/value/list storage component for the pixl-server framework.",
 	"author": "Joseph Huckaby <jhuckaby@gmail.com>",
 	"homepage": "https://github.com/jhuckaby/pixl-server-storage",

package/storage.js

@@ -169,7 +169,7 @@ module.exports = Class.create({
 		// sanity checks
 		if (!value) return callback( new Error("Record value cannot be false.") );
 		
-		var isBuffer = !!value.fill;
+		var isBuffer = Buffer.isBuffer(value);
 		if (isBuffer && !this.isBinaryKey(key)) {
 			return callback( new Error("Buffer values are only allowed with keys containing file extensions, e.g. " + key + ".bin") );
 		}
@@ -521,6 +521,15 @@ module.exports = Class.create({
 		var self = this;
 		this.logDebug(9, "Copying record: " + old_key + " to " + new_key);
 		
+		// branch here if binary keys
+		if (this.isBinaryKey(old_key) && this.isBinaryKey(new_key)) {
+			this.getStream(old_key, function(err, stream) {
+				if (err) return callback(err, null);
+				self.putStream(new_key, stream, callback);
+			} );
+			return;
+		}
+		
 		// load old key
 		this.get(old_key, function(err, data) {
 			if (err) return callback(err, null);

package/transaction.js

@@ -40,7 +40,7 @@ var TransStorageFunctions = {
 		// binary keys not part of transaction system
 		if (this.isBinaryKey(key)) return this.rawStorage.put(key, value, callback);
 		if (!value) return callback( new Error("Value cannot be false.") );
-		if (value.fill) return callback( new Error("Buffers not allowed in transactions.") );
+		if (Buffer.isBuffer(value)) return callback( new Error("Buffers not allowed in transactions.") );
 		
 		this.logDebug(9, "Storing JSON Object in transaction: " + key, this.debugLevel(10) ? value : null);
 		value = JSON.stringify( value );