piral-cli 0.15.0-alpha.4332 → 0.15.0-alpha.4345

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "piral-cli",
-  "version": "0.15.0-alpha.4332",
+  "version": "0.15.0-alpha.4345",
   "description": "The standard CLI for creating and building a Piral instance or a Pilet.",
   "keywords": [
     "portal",
@@ -78,5 +78,5 @@
     "typescript": "^4.7.3",
     "yargs": "^15.4.1"
   },
-  "gitHead": "109cacf66ffee5af60faf7bc861e5ffe8c9a7cd2"
+  "gitHead": "56ecd6ad080b3d275752b19afcf8435e4bd09140"
 }

package/src/common/npm.test.ts

@@ -66,7 +66,7 @@ jest.mock('fs', () => ({
   existsSync: (file: string) => {
     return true;
   },
-  readFile: (file: string, type: string, callback: (err: NodeJS.ErrnoException, data: string) => void) => {
+  readFile: (file: string, type: string, callback: (err: NodeJS.ErrnoException | undefined, data: string) => void) => {
     return callback(undefined, '');
   },
   realpathSync: () => ({}),
@@ -320,7 +320,7 @@ describe('npm Module', () => {
   });
 
   it('check if package from nothing is not local', () => {
-    const result = isLocalPackage('./', null);
+    const result = isLocalPackage('./', '');
     expect(result).toBeFalsy();
   });
 
@@ -364,7 +364,7 @@ describe('npm Module', () => {
     expect(result).toBeTruthy();
     result = isGitPackage('git+');
     expect(result).toBeTruthy();
-    result = isGitPackage(null);
+    result = isGitPackage('');
     expect(result).toBeFalsy();
   });
 
@@ -395,11 +395,11 @@ describe('npm Module', () => {
   it('combine package refernce', () => {
     let result = combinePackageRef('foo', '1.0.0', 'registry');
     expect(result).toBe('foo@1.0.0');
-    result = combinePackageRef('foo', null, 'registry');
+    result = combinePackageRef('foo', '', 'registry');
     expect(result).toBe('foo@latest');
-    result = combinePackageRef('foo', null, 'file');
+    result = combinePackageRef('foo', '', 'file');
     expect(result).toBe('foo');
-    result = combinePackageRef('foo', null, 'git');
+    result = combinePackageRef('foo', '', 'git');
     expect(result).toBe('foo');
   });
 
@@ -430,18 +430,18 @@ describe('npm Module', () => {
     expect(result).toEqual('1.0.0');
     result = getPackageVersion(false, 'foo', '1.0.0', 'registry', './');
     expect(result).toBeFalsy();
-    result = getPackageVersion(true, './foo.tgz', null, 'file', './');
+    result = getPackageVersion(true, './foo.tgz', '', 'file', './');
     expect(result).toEqual('file:foo.tgz');
-    result = getPackageVersion(true, 'git+https://.foo.git', null, 'git', null);
+    result = getPackageVersion(true, 'git+https://.foo.git', '', 'git', '');
     expect(result).toEqual('git+https://.foo.git');
   });
 
   it('gets path to git package', () => {
-    const result = getCurrentPackageDetails('./', './foo.tgz', null, 'file://foo.tgz', './');
+    const result = getCurrentPackageDetails('./', './foo.tgz', '', 'file://foo.tgz', './');
     result.then(([path, version]) => {
       expect(path).not.toBeUndefined();
     });
-    const result2 = getCurrentPackageDetails('./', './foo.tgz', null, 'git+https://.foo.git', './');
+    const result2 = getCurrentPackageDetails('./', './foo.tgz', '', 'git+https://.foo.git', './');
     result2.then(([path, version]) => {
       expect(path).not.toBeUndefined();
     });
@@ -454,32 +454,12 @@ describe('npm Module', () => {
 
   it('makeExternals without externals returns coreExternals', () => {
     const externals = makeExternals(process.cwd(), { piral: '*' });
-    expect(externals).toEqual([
-      'react',
-      'react-dom',
-      'react-router',
-      'react-router-dom',
-      'history',
-      'tslib',
-      'path-to-regexp',
-      '@libre/atom',
-      '@dbeining/react-atom',
-    ]);
+    expect(externals).toEqual(['react', 'react-dom', 'react-router', 'react-router-dom', 'history', 'tslib']);
   });
 
   it('makeExternals with no externals returns coreExternals', () => {
     const externals = makeExternals(process.cwd(), { piral: '*' }, []);
-    expect(externals).toEqual([
-      'react',
-      'react-dom',
-      'react-router',
-      'react-router-dom',
-      'history',
-      'tslib',
-      'path-to-regexp',
-      '@libre/atom',
-      '@dbeining/react-atom',
-    ]);
+    expect(externals).toEqual(['react', 'react-dom', 'react-router', 'react-router-dom', 'history', 'tslib']);
   });
 
   it('makeExternals with exclude coreExternals returns empty set', () => {
@@ -498,41 +478,17 @@ describe('npm Module', () => {
       'react-router-dom',
       'history',
       'tslib',
-      'path-to-regexp',
-      '@libre/atom',
-      '@dbeining/react-atom',
     ]);
   });
 
   it('makeExternals with external duplicate only reflects coreExternals', () => {
     const externals = makeExternals(process.cwd(), { piral: '*' }, ['react', 'foo']);
-    expect(externals).toEqual([
-      'react',
-      'foo',
-      'react-dom',
-      'react-router',
-      'react-router-dom',
-      'history',
-      'tslib',
-      'path-to-regexp',
-      '@libre/atom',
-      '@dbeining/react-atom',
-    ]);
+    expect(externals).toEqual(['react', 'foo', 'react-dom', 'react-router', 'react-router-dom', 'history', 'tslib']);
   });
 
   it('makeExternals with explicit include and exclude', () => {
     const externals = makeExternals(process.cwd(), { piral: '*' }, ['react', 'react-calendar', '!history']);
-    expect(externals).toEqual([
-      'react',
-      'react-calendar',
-      'react-dom',
-      'react-router',
-      'react-router-dom',
-      'tslib',
-      'path-to-regexp',
-      '@libre/atom',
-      '@dbeining/react-atom',
-    ]);
+    expect(externals).toEqual(['react', 'react-calendar', 'react-dom', 'react-router', 'react-router-dom', 'tslib']);
   });
 
   it('makeExternals with all exclude and explicit include', () => {