pipwave-ekyc-uikit 3.6.0-beta.1 → 3.6.0

package/docs/release-uikit-3.6.0.md

@@ -0,0 +1,16 @@
+# Release drafts: pipwave-ekyc-uikit 3.6.0
+
+## #hello-serverless (post when the release MR is ready to merge)
+
+```
+pipwave eKYC Web UI Release 3.6 is ready
+• <https://gitlab.g2g.com/pipwave-frontend/pw-ekyc-web-ui/-/merge_requests/100|MR>
+• <https://gitlab.g2g.com/pipwave-frontend/pw-ekyc-web-ui/-/wikis/**Release-3.6-Deployment-Notes#release-36|Release Notes>
+@Jia Chong Ong
+```
+
+Thread reply when the deploy starts:
+
+```
+deploying
+```

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pipwave-ekyc-uikit",
-  "version": "3.6.0-beta.1",
+  "version": "3.6.0",
   "description": "",
   "main": "dist/pw-bundle.js",
   "module": "dist/pw-bundle.mjs",

package/.claude/settings.json

@@ -1,55 +0,0 @@
-{
-  "permissions": {
-    "allow": [
-      "Bash(grep -o \"facingMode[^,]*,width:{ideal:[0-9]*},height:{ideal:[0-9]*}\" dist/pw-bundle.js)",
-      "Bash(grep -o 'facingMode:\"environment\",width:{ideal:[0-9]*},height:{ideal:[0-9]*}')",
-      "Bash(npm whoami *)",
-      "Bash(npm view *)",
-      "Bash(git -C \"/Users/chechin/Documents/2. pipwave Projects/pw-ekyc-web-ui /pw-ekyc-web-ui\" status --porcelain)",
-      "Bash(echo \"---exit:$?\")",
-      "Bash(ls -d /Applications/*.app 2>/dev/null | grep -iE \"visual|code|cursor|windsurf\"; echo \"---\"; ls \"/Applications/Visual Studio Code.app/Contents/Resources/app/bin/code\" 2>/dev/null && echo \"VSCODE_CLI_FOUND\")",
-      "Read(//Applications/**)",
-      "Read(//Applications/Visual Studio Code.app/Contents/Resources/app/bin/**)",
-      "Bash(ps -Ao comm=)",
-      "Bash(\"/Applications/Visual Studio Code.app/Contents/Resources/app/bin/code\" -r ~/.claude/skills/release-uikit/SKILL.md ~/.claude/skills/rollout-uikit/SKILL.md)",
-      "Bash(mv release-uikit *)",
-      "Bash(mv rollout-uikit *)",
-      "Bash(\"/Applications/Visual Studio Code.app/Contents/Resources/app/bin/code\" -r ~/.claude/skills/release-ekyc-uikit/SKILL.md ~/.claude/skills/rollout-ekyc-uikit/SKILL.md)",
-      "Bash(rm -rf ~/.claude/skills/rollout-ekyc-uikit && echo \"deleted\" && ls ~/.claude/skills && echo \"=== stale refs? ===\" && grep -rn \"rollout-ekyc-uikit\" ~/.claude/skills 2>/dev/null || echo \"none\")",
-      "Edit(~/.claude/skills/release-ekyc-uikit/**)",
-      "Bash(node -p 'require\\('\\\\''/Users/chechin/Documents/2. pipwave Projects/pw-ekyc-web-ui /pw-ekyc-web-ui/package.json'\\\\''\\).name')",
-      "Bash(node -p 'require\\('\\\\''/Users/chechin/Documents/2. pipwave Projects/pw-ekyc-web-ui /pw-ekyc-web-ui/package.json'\\\\''\\).version')",
-      "Bash(git -C '/Users/chechin/Documents/2. pipwave Projects/pw-ekyc-web-ui /pw-ekyc-web-ui' rev-parse --abbrev-ref HEAD)",
-      "Bash(git -C '/Users/chechin/Documents/2. pipwave Projects/pw-ekyc-web-ui /pw-ekyc-web-ui' status --porcelain)",
-      "Bash(npm -v)",
-      "Bash(node -e ' *)",
-      "Bash(grep -o 'facingMode:\"environment\",width:{ideal:[0-9]*},height:{ideal:[0-9]*}' dist/pw-bundle.js)",
-      "Bash(grep -o 'facingMode:\"user\",width:{ideal:[0-9]*},height:{ideal:[0-9]*}' dist/pw-bundle.js)",
-      "Bash(sed -E 's/\\(=.{4}\\).*/\\\\1****REDACTED****/' .env.development)",
-      "Bash(sed -E 's/\\(=.{4}\\).*/\\\\1****REDACTED****/' .env.production)",
-      "Bash(node -p \"Object.keys\\(require\\('./.claude/settings.local.json'\\)\\).join\\(', '\\)\")",
-      "Bash(grep -n \"Remove the \\\\`face-api.js\\\\` dependency\\\\|face-api.js\\\\`, \\\\`public/face-models/\\\\`\\\\|minScore\\\\|livenessScore\\\\|Within scope\\\\|declare/require\" docs/stories/e-sc-354880-signal-package-adapter-and-geometry.md)",
-      "Bash(echo \"\\(exit $?\\)\")",
-      "Bash(awk '/^## Description/,0' docs/stories/tickets/e-sc-354880-signal-package-adapter-and-geometry.md)",
-      "Bash(awk '{print length\"\\\\t\"NR\"\\\\t\"substr\\($0,1,90\\)}' docs/stories/tickets/e-sc-354880-signal-package-adapter-and-geometry.md)",
-      "Bash(awk '/^# Documents/,0' docs/stories/tickets/e-sc-354880-signal-package-adapter-and-geometry.md)",
-      "Bash(git diff *)",
-      "Bash(grep -rn \"Mapping \\\\`14025\\\\`\" stories/)",
-      "Bash(cd \"/Users/chechin/Documents/2. pipwave Projects/pw-ekyc-web-ui /pw-ekyc-web-ui/docs\" && grep -n \"^## 7\\\\.0\\\\|^### \\\\|^## 7\" plan-epic-342056-selfie-action-checking.md | sed -n '1,40p' && echo \"=== §7.0 blocker table + contract items ===\" && sed -n '/^## 7.0/,/^## 7.1\\\\|^## 8/p' plan-epic-342056-selfie-action-checking.md | head -60)",
-      "Bash(awk '/^### |^## /{sec=$0} /livenessScore|liveness_score/{printf \"%-56s L%-5s %s\\\\n\", substr\\(sec,1,54\\), NR, substr\\($0,1,90\\)}' plan-epic-342056-selfie-action-checking.md)",
-      "Bash(cd \"/Users/chechin/Documents/2. pipwave Projects/pw-ekyc-web-ui /pw-ekyc-web-ui/docs\" && echo \"=== §6.3 sequencing \\(first 30 lines\\) ===\" && sed -n '/^### 6.3 Sequencing/,/^### 6.4/p' plan-epic-342056-selfie-action-checking.md | head -32 *)",
-      "Bash(awk 'NR>=30 && NR<=42 {printf \"%d:[%s]\\\\n\", NR, $0}' a-sc-353927-web-sdk-facematch-selfie-fields.md)",
-      "Bash(perl -0777 -i -pe 's{\\\\*\\\\*Signal-package adapter \\\\+ phase-1 geometry\\\\*\\\\*; delete face-api\\\\.js\\\\.}{**Signal-package adapter + phase-1 geometry**; delete face-api.js **and the `livenessScore` chain, incl. `StartSelfie.ts:137,142` \\(§3 item 5\\)**.}' plan-epic-342056-selfie-action-checking.md)",
-      "Bash(perl -0777 -i -pe 's{outside this story\\\\.\\\\n\\\\n\\\\n# Acceptance Criteria}{outside this story.\\\\n\\\\n# Acceptance Criteria}' stories/a-sc-353927-web-sdk-facematch-selfie-fields.md)",
-      "Bash(perl -0777 -ne 'print \"  found\\\\n\" if /\\\\n\\\\n\\\\n/' stories/a-sc-353927-web-sdk-facematch-selfie-fields.md)",
-      "Bash(python3 -c ' *)",
-      "Bash(grep -rn 'export.*\\\\$t\\\\|const $t\\\\|function $t' src/)",
-      "Bash(node -e \"const p=require\\('./package.json'\\);console.log\\(p.name,p.version,'private:',p.private,'main:',p.main,'files:',JSON.stringify\\(p.files\\)\\)\")"
-    ],
-    "additionalDirectories": [
-      "/Users/chechin/.claude/skills/rollout-ekyc-uikit",
-      "/Users/chechin/Documents/2. pipwave Projects/pw-ekyc-web-ui /pw-ekyc-web-ui/docs",
-      "/Users/chechin/.claude"
-    ]
-  }
-}

package/.claude/settings.local.json

@@ -1,61 +0,0 @@
-{
-  "permissions": {
-    "allow": [
-      "Bash(xargs git log --oneline -1)",
-      "Skill(code-review)",
-      "Skill(code-review:*)",
-      "Bash(kill 60053 69150 84076)",
-      "Bash(lsof -iTCP -sTCP:LISTEN -P -n)",
-      "Bash(npx vitest *)",
-      "Bash(git -C \"/Users/chechin/Documents/2. pipwave Projects/pw-ekyc-web-ui /pw-ekyc-web-ui\" remote -v)",
-      "Bash(ssh-keygen -t ed25519 -C \"chechin.tang@g2g.com\" -f ~/.ssh/id_ed25519_gitlab_g2g -N \"\")",
-      "Bash(pbcopy)",
-      "Bash(pbpaste)",
-      "Bash(ssh -o BatchMode=yes -T git@gitlab.g2g.com)",
-      "Bash(ssh -v -T git@gitlab.g2g.com)",
-      "Bash(git log *)",
-      "Bash(lsof -nP -iTCP -sTCP:LISTEN)",
-      "Bash(node -e ' *)",
-      "Bash(node -e \"const p=require\\('./package.json'\\);console.log\\(JSON.stringify\\(p.scripts,null,2\\)\\);console.log\\('files:',p.files,'main:',p.main\\)\")",
-      "Bash(ffprobe -v error -select_streams v:0 -show_entries stream=width,height,r_frame_rate -of default=noprint_wrappers=1 \"/Users/chechin/Desktop/Screen Recording 2026-08-12 at 7.27.54 AM.mov\")",
-      "Bash(ffprobe -v error -select_streams a -show_entries stream=codec_name -of default=noprint_wrappers=1 \"/Users/chechin/Desktop/Screen Recording 2026-08-12 at 7.27.54 AM.mov\")",
-      "Bash(grep -i -E \"\\\\.\\(mov|mp4|m4v\\)$\")",
-      "Bash(~/.claude/skills/compress-video/compress-video.sh --help)",
-      "mcp__claude_ai_G2G_Shortcut__stories-get-by-id",
-      "Bash(python3 -c ' *)",
-      "Bash(python3 -)",
-      "mcp__claude_ai_Figma__get_screenshot",
-      "Bash(cd \"/Users/chechin/Documents/2. pipwave Projects/pw-ekyc-web-ui /pw-ekyc-web-ui\" && sed -n '/^### Overlap resolution/,/^---/p' docs/plan-epic-342056-selfie-action-checking.md)",
-      "Bash(mv \"support-facematch-selfie-fields-in-web-sdk.md\" \"a-support-facematch-selfie-fields-in-web-sdk.md\")",
-      "Bash(mv \"selfie-flow-and-orchestration.md\" \"b-selfie-flow-and-orchestration.md\")",
-      "Bash(python3 -c \"print\\('A .5 + B1 2.5 + C 3 + D 3 + E 3.25 + F 5.25 + G 1.5 + B2 3 =', 0.5+2.5+3+3+3.25+5.25+1.5+3\\)\")",
-      "Bash(grep -n \"story \\\\*\\\\*B\\\\*\\\\*\\\\|\\(B\\)\\\\b\\\\|B's mocks\\\\|B's debug\\\\|B's \\\\`\" docs/plan-epic-342056-selfie-action-checking.md)",
-      "Bash(grep -n \"^#\\\\{2,4\\\\} \" plan-epic-342056-selfie-action-checking.md)",
-      "Bash(grep -v \"are$\\\\|dropped\\\\|superseded\")",
-      "Bash(cd \"/Users/chechin/Documents/2. pipwave Projects/pw-ekyc-web-ui /pw-ekyc-web-ui/docs\" && echo \"=== §7.0 refs ===\" && sed -n '1532,1533p' plan-epic-342056-selfie-action-checking.md | grep -o \"\\\\*\\\\*[FG]\\\\*\\\\*[^.]*\"; echo; echo \"=== §6.3 sequencing prose ===\" && sed -n '/^### 6.3 Sequencing/,/^### 6.4/p' plan-epic-342056-selfie-action-checking.md | grep -n \"\\\\*\\\\*[FG]\\\\*\\\\*\\\\|── [FG] \\\\|[FG] visibility\\\\|[FG] sequencer\" | sed 's/\\\\\\(.\\\\{130\\\\}\\\\\\).*/\\\\1…/')",
-      "Bash(cd \"/Users/chechin/Documents/2. pipwave Projects/pw-ekyc-web-ui /pw-ekyc-web-ui/docs\" && sed -n '/^### 6.3 Sequencing/,/^### 6.4/p' plan-epic-342056-selfie-action-checking.md | grep -n \"\\\\bF\\\\b\\\\|\\\\bG\\\\b\" | sed 's/\\\\\\(.\\\\{150\\\\}\\\\\\).*/\\\\1…/')",
-      "mcp__claude_ai_G2G_Shortcut__stories-search",
-      "mcp__claude_ai_Figma__get_metadata",
-      "Bash(cd \"/Users/chechin/Documents/2. pipwave Projects/pw-ekyc-web-ui /pw-ekyc-web-ui/docs\" && sed -n '/Invalidate with a dirty flag/,/^### /p' plan-epic-342056-selfie-action-checking.md | sed -n '8,30p')",
-      "Bash(cd \"/Users/chechin/Documents/2. pipwave Projects/pw-ekyc-web-ui /pw-ekyc-web-ui/docs/..\" && grep -rn \"requestAnimationFrame\\\\|cancelAnimationFrame\" src/plugins/*.ts | sed 's/\\\\\\(.\\\\{110\\\\}\\\\\\).*/\\\\1…/')",
-      "Read(//Users/chechin/Documents/2. pipwave Projects/pw-ekyc-web-ui /pw-ekyc-web-ui/**)",
-      "Bash(— a *)",
-      "Bash(grep -n \"config.ts` — a skeleton\\\\|config.ts` — skeleton\" stories/b-selfie-flow-scaffold.md plan-epic-342056-selfie-action-checking.md)",
-      "Bash(cd \"/Users/chechin/Documents/2. pipwave Projects/pw-ekyc-web-ui /pw-ekyc-web-ui\" && grep -n \"^_Rev 2[4-9]\" docs/plan-epic-342056-selfie-action-checking.md | head && sed -n '/^_Rev 26/,/^_Rev 25/p' docs/plan-epic-342056-selfie-action-checking.md | head -30)",
-      "Bash(awk '/^\\\\| \\\\| Shortcut \\\\| Draft/,/^$/' docs/plan-epic-342056-selfie-action-checking.md)",
-      "Bash(awk -F'|' '{print NF-2\" cols: \"$2}')",
-      "Bash(perl -i -pe 'if \\(/^_/\\) { s/the flow scaffold story/the flow scaffold story \\(sc-354838\\)/; s/the flow scaffold\\(?! story\\)\\(?! \\\\\\(sc\\)/the flow scaffold \\(sc-354838\\)/; }' docs/stories/c-selfie-camera-screen-ui.md docs/stories/d-selfie-non-camera-screens.md docs/stories/f-visibility-prompts-and-fallback.md docs/stories/h-selfie-submission-and-result.md docs/stories/tickets/c-selfie-camera-screen-ui.md docs/stories/tickets/d-selfie-non-camera-screens.md docs/stories/tickets/f-visibility-prompts-and-fallback.md docs/stories/tickets/h-selfie-submission-and-result.md)",
-      "Bash(perl -i -pe 's/^As a Frontend Developer, I want the SDK package to accept the facematch selfie fields, so that the UI can submit action-stage images\\\\.$/As a Frontend Developer, I want the pw-ekyc-web-sdk to accept the facematch selfie fields, so that the pw-ekyc-web-ui can submit action-stage images./' docs/stories/a-support-facematch-selfie-fields-in-web-sdk.md docs/stories/tickets/a-web-sdk-facematch-selfie-fields.md)",
-      "Bash(awk '/^# Documents$/{f=1} f' e-signal-package-adapter-and-geometry.md)",
-      "Bash(awk '/^# Documents$/{f=1} f' g-action-sequencer-and-capture.md)",
-      "Bash(perl -0777 -i -pe ' *)",
-      "Bash(perl -0777 -i -pe 's/- Only one image is captured and uploaded; the new flow sends three\\\\./- Only one image is captured and uploaded; the new flow sends 3./' g-action-sequencer-and-capture.md)",
-      "mcp__claude_ai_G2G_Shortcut__stories-create",
-      "mcp__claude_ai_G2G_Shortcut__stories-update",
-      "Bash(set -e)"
-    ],
-    "additionalDirectories": [
-      "/Users/chechin/Documents/2. pipwave Projects/pw-ekyc-web-ui /pw-ekyc-web-ui/docs"
-    ]
-  }
-}

package/branch-review-sc-356160.md

@@ -1,184 +0,0 @@
-# Branch review: `hotfix-teojunjie-sc-356160-fix-face-model-load-deadlock`
-
-Compared against `origin/master`. The branch is 2 commits ahead, 0 behind.
-
-- `1cb8851` [sc-356160] Add timeout and retry to face model load
-- `09fb8c1` [sc-356160] Add Retry dialog when face model load fails
-
-```
- src/plugins/face-camera.ts                      |  16 ++
- src/plugins/face-detection.ts                   |  80 ++++--
- src/plugins/test/face-detection.load.test.ts    | 221 +++++++++++++++++ (new)
- src/plugins/{ => test}/card-detection.inference.test.ts
- src/plugins/{ => test}/card-detection.test.ts
- src/plugins/{ => test}/detection-failure.test.ts
- src/plugins/{ => test}/face-detection.test.ts
- src/translations/en.ts                          |   1 +
- 8 files changed, 308 insertions(+), 30 deletions(-)
-```
-
-## The bug being fixed
-
-The selfie screen downloads face-api model files before it can start. The old code in
-`src/plugins/face-detection.ts` did this:
-
-1. Set `loadedModelState` to `"LOADING"`.
-2. Start the download.
-3. Wait in a loop: `while (loadedModelState === "LOADING") { sleep 500ms }`.
-
-If a download stalled but never actually failed, step 1's `"LOADING"` value was never changed. So the loop
-in step 3 kept waiting forever, and the user was stuck looking at the "Initializing Camera..." spinner with
-no error and no way forward.
-
-## What the branch changes
-
-### 1. `src/plugins/face-detection.ts` — bound the download and retry it
-
-- **One shared download.** A new module-level `loadPromise` holds the single download in progress. The
-  background pre-warm (from `src/uisdk.ts`) and the selfie screen now wait on the same promise instead of
-  each watching the `loadedModelState` variable. It is set back to `null` when the download finishes, so a
-  failed download can be tried again later.
-- **A time limit and retries.** The new `_attemptLoadModel()` wraps the four loader calls in
-  `withTimeout(..., 10000, "face model load")` and retries up to 2 more times, waiting 500ms then 1s between
-  tries. If all 3 attempts fail, it sets `loadedModelState` back to `"NOT_LOADED"` and throws.
-- **`init()` handles the failure.** It now wraps the download in try/catch. On failure it hides the spinner,
-  calls a new `onModelLoadFailed?.()` callback, and returns without starting detection. The old endless
-  `while` loop is gone.
-- **Reuses existing helpers.** `withTimeout` and `computeBackoffMs` already existed in
-  `src/plugins/detection-failure.ts` (written for the card model loader), so nothing was duplicated. It
-  skips the third helper, `classifyFailure`, and the comment explains why: face-api's loaders only download
-  files, so every failure here is worth retrying.
-
-### 2. `src/plugins/face-camera.ts` — show a Retry dialog
-
-`init()` now sets `faceDetectionSdk.onModelLoadFailed` to a new `showModelLoadFailedDialog()` method. That
-method opens a `BaseDialog` with the message `$t("face_camera_unavailable")` and a `$t("btn_retry")` button,
-plus a Cancel button.
-
-Pressing Retry calls `faceDetectionSdk.init()` again. That works because the state was already reset to
-`"NOT_LOADED"`, so it starts a genuinely new download instead of waiting on the dead one. Cancel just closes
-the dialog and leaves the back button in the header as the way out.
-
-### 3. `src/translations/en.ts` — one new string
-
-`face_camera_unavailable: "Couldn't start the camera. Please check your connection and retry."`
-
-`en.ts` is the only translation file in this repo, so there are no other languages left missing the string.
-
-### 4. Tests moved and added
-
-Four existing test files moved from `src/plugins/` into `src/plugins/test/`. I checked the diff: the only
-content change is the import paths getting one level deeper (`./card-detection` became `../card-detection`,
-`../classes/MainPage` became `../../classes/MainPage`). No config change was needed because
-`vitest.config.ts` already looks for `src/**/*.test.ts`.
-
-`face-detection.load.test.ts` is new and adds 9 tests:
-
-- a normal successful load
-- a load that fails once then succeeds on retry
-- a stalled load that times out, fails, and resets the state cleanly
-- a fresh retry working after an earlier failure
-- two callers at once sharing a single download (not downloading twice)
-- the failure reaching the second caller too, so it isn't left hanging
-- a download that finishes *after* its attempt already timed out, which must be ignored
-- `init()` hiding the spinner when the load fails
-- `init()` calling `onModelLoadFailed` so the dialog can appear
-
-## Checks I ran
-
-| Check | Result |
-| --- | --- |
-| `npx vitest run` | 5 files, **76 tests passed** |
-| `npx tsc --noEmit` | no errors |
-| `npm run build` | builds fine; only the bundle-size warnings that were already there |
-
-One thing to watch: the tests need Node 18 or newer. On Node 16 (the shell default here) vitest crashes at
-startup with a `node:util` / `styleText` SyntaxError before running a single test. Worth checking that CI and
-other developers aren't on Node 16.
-
-## Problems found
-
-### 1. The 10-second limit is probably too short (most important)
-
-The four loaders download about 7 MB in total, from `public/face-models`:
-
-| file | size |
-| --- | --- |
-| `tiny_face_detector_model-shard1` | 193 KB |
-| `face_landmark_68_model-shard1` | 357 KB |
-| `face_expression_model-shard1` | 329 KB |
-| `face_recognition_model-shard1` + `shard2` | 6.44 MB |
-| **total** | **~7.0 MB** |
-
-To finish 7 MB in 10 seconds you need about 700 KB/s, which is roughly 5.6 Mbps held steady. On a weak
-mobile connection the download is fine, just slow, but the new code gives up on it. It then retries twice,
-also giving up, and shows "Couldn't start the camera" after about 31.5 seconds (three 10s attempts plus
-500ms and 1s of waiting).
-
-So we've fixed a rare freeze but made slow connections fail where they used to eventually work.
-
-Two smaller side effects of the same setting:
-
-- `withTimeout` doesn't cancel the download it gave up on. Sometimes that helps, because the first download
-  may finish and fill the browser cache in time for retry 2 or 3 to reuse it. But that depends on the cache
-  headers on `assets.pipwave.com` and on lucky timing, so we can't rely on it.
-- Because nothing is cancelled, up to 3 attempts x 4 loaders can be downloading at the same time, all
-  fighting over the same slow connection.
-
-What I'd suggest, best option first:
-
-1. Raise the limit per attempt to 30-45 seconds. The point is to catch a download that has stopped moving,
-   not one that is merely slow, so the limit doesn't need to be tight.
-2. Or detect a stall instead of a total time (give up only when no bytes have arrived for a while).
-3. Or pass an `AbortController` so a given-up attempt stops using bandwidth. face-api's loaders may not
-   accept one, in which case option 1 matters more.
-
-Worth noting this mostly affects the slow-connection minority: the pre-warm in `src/uisdk.ts:83` starts
-downloading early in the eKYC flow, so most users are done well before they reach the selfie screen.
-
-### 2. The 90-second idle timer can fire while the Retry dialog is open
-
-`FaceCamera.init()` starts a 90-second idle timer (`src/plugins/face-camera.ts:233-245`) before the model
-download begins. One failed download cycle uses up to 31.5 seconds of that.
-
-So if the user reads the dialog and taps Retry late, the idle timer can go off in the middle of the retry.
-The timer calls `stopVideoStream()`, which kills the camera tracks, while the retrying `init()` carries on
-and calls `startDetection()` on a camera that no longer works. The result is a stuck camera with no spinner
-and no error message.
-
-Simple fix: reset the idle timer inside the Retry callback (or clear it when the load fails and restart it
-on Retry).
-
-### 3. Two dialogs could stack up (minor)
-
-`init()` doesn't check whether it is already running before starting the download. The
-`!this.iFrameRef && !this.isStartingDetection` check happens after the `await`, not before it. If the video
-element fires `loadedmetadata` twice (for example the camera stream is re-acquired, or the device rotates),
-both calls share the same failing download and both call `onModelLoadFailed`, so two dialogs appear on top
-of each other. A simple "already showed the dialog" flag would prevent it.
-
-### 4. Cosmetic
-
-- `src/plugins/face-detection.ts:745` has trailing whitespace on a new blank line inside
-  `_attemptLoadModel()`. Two similar cases were already in the file. There's no eslint config in this repo,
-  so nothing flags it.
-- The Cancel button text is hardcoded as `"Cancel"` in `src/components/baseDialog.ts:73` instead of using
-  `$t(...)`. This isn't new, and it doesn't matter while English is the only locale, but this new dialog is
-  one more place using it.
-
-## Things I checked that are correct
-
-- **No way back into the old freeze.** There is never a moment where `loadedModelState` is `"LOADING"` while
-  `loadPromise` is `null`. An async function runs up to its first `await` immediately, so `"LOADING"` is set
-  before the promise is handed to anyone, and on failure `"NOT_LOADED"` is set before the throw. So a caller
-  arriving at any point either joins the live download or starts a new one.
-- **No unhandled promise rejections.** The caller that starts the download always awaits it, and the
-  pre-warm at `src/uisdk.ts:83` has a `.catch(...)`.
-- **Retry really does start over.** The state is reset and `loadPromise` cleared before the dialog appears,
-  so Retry downloads again rather than waiting on the failed promise. Test 4 covers this.
-- **Retry shows a spinner.** `FACEDETECTIONSDK.init()` calls `createFullLoading` itself, so pressing Retry
-  gives visible feedback instead of looking like nothing happened.
-- **The `finally` block in `FaceCamera.init()`** still hides the spinner based on
-  `getLoadedModelState() !== "LOADING"`. This branch doesn't change that behaviour.
-- **`dist/pw-bundle.js` doesn't include these changes.** That's expected: this repo only commits `dist/` when
-  the version is bumped for a release.

package/branch-review-sc-357460.md

@@ -1,88 +0,0 @@
-**Code review notes**
-
-18 findings from reviewing `2012a78` and `f647878`, grouped by urgency. Files covered: `card-camera.ts`, `VerifyId.ts`, `manualCapture.ts`, `manualCapture.test.ts`, `en.ts`.
-
----
-
-### Must fix before merge
-
-**1. One failed tap permanently locks the shutter** — `card-camera.ts:627-637`
-`triggerManualCapture()` sets `hasAutoCaptured = true` and locks the button before awaiting `captureImage()`, with no try/catch. If the capture throws (for example iOS Safari after backgrounding, where the video reports width 0) the error disappears, the button stays locked, and manual mode has no other way to capture.
-Fix: wrap it in try/catch. On error, reset the flag, unlock the button, and restore the hint.
-
----
-
-### To confirm and resolve (no code change expected)
-
-**2. The capture is still cropped to the card-ratio frame** — `card-camera.ts:111`, ratio from `src/constant/id.ts:27`
-The overlay frame and `captureImage()` crop still use the credit-card ratio (1.586), so the UA booklet has to be fitted into a card-shaped frame. Understanding is this is expected: we cannot define a different ratio for every doc type per country/region, and since capture is manual, the user adjusts the document to fit the frame themselves. Please confirm and resolve.
-
-**3. The flow still asks for a "back side" of the booklet** — `VerifyId.ts:282`, `idCardTypeMapping` says national ID has a back
-After the front capture the user gets the "flip your card" step for a document with no card back. Nothing to change in this MR, since BE currently enforces submission of both sides. Reminder for the future: consider a BE-side change to make the back side optional for booklet-style documents, subject to business requirements. Please acknowledge and resolve.
-
----
-
-### Recommended (worth doing in this MR)
-
-**4. Tapping the shutter gives no feedback** — `src/plugins/card-camera.ts:627-637`
-Auto capture shows the ring filling and a green tick; manual capture shows nothing until the loading screen. Users will assume the button is broken and tap again. This was a rare fallback before, but it is now the only path for UA. Suggest reusing `setRingProgress(1)` + `showCaptureTick()` in `triggerManualCapture`.
-
-**5. Scanning brackets show while nothing is scanning** — `src/plugins/card-camera.ts:928`
-The detector corner brackets still render in manual mode but never change colour, since no detection runs. It reads as "the app is scanning", so the user may wait instead of tapping. `disableDetection()` already exists and the face camera uses it for exactly this.
-
-**6. The same hint ternary is copy-pasted in three places** — `card-camera.ts:402`, `:588`, `:798`
-`$t(this.manualOnly ? "doc_manual_capture" : "doc_align_card")` appears in three methods. The next person resetting the hint will likely copy nearby code and write `$t("doc_align_card")`, telling UA users to "align your card" with no auto-capture running. One getter used at all three sites:
-
-```ts
-private get idleHint(): string {
-  return $t(this.manualOnly ? "doc_manual_capture" : "doc_align_card");
-}
-```
-
-**7. Two separate lists will break when we add a second country** — `src/helper/manualCapture.ts:9-13`
-The check is "country in list A AND doc type in list B". The real rule is per-country ("UA's national ID is a booklet"). If we later add a country whose passport is the booklet, adding `PASSPORT` to the shared list would silently enable manual capture for UA passports too, and the current test would not catch it. One map instead, same amount of code:
-
-```ts
-const MANUAL_CAPTURE_DOCS: Record<string, readonly IdType[]> = {
-  UA: [ID_TYPE.NATIONAL_ID],
-};
-return (MANUAL_CAPTURE_DOCS[issuingCountry.toUpperCase()] ?? []).includes(idType);
-```
-
-**8. Doc-type constants live in the wrong file** — `manualCapture.ts:9-13` vs `src/constant/id.ts:4`
-Everything else describing "what a document type does" lives in `constant/id.ts` (`idCardTypeMapping`, `ID_TYPE`, `ID_CARD_RATIO`). These new tables sit in `helper/`, so someone adding a doc type will update `constant/id.ts` and never find this file. Suggest keeping `isManualCaptureOnly()` in `helper/` but moving the constant table next to `idCardTypeMapping`.
-
-**9. `updateType` turns the shutter off just to turn it back on** — `card-camera.ts:552-570`
-On a side flip in manual mode we call `disableManualCapture()` then `enableManualCapture()` a few lines later. The round trip only exists to get past the `dataset.manual` guard, and that dependency is invisible unless you read both methods. An early return would let the shutter stay active across the flip:
-
-```ts
-if (this.manualOnly) {
-  this.cardType = cardType;
-  this.hasAutoCaptured = false;
-  updateTitle();
-  this.setHint(this.idleHint);
-  return;
-}
-```
-
----
-
-### Can wait (follow-up is fine)
-
-**10.** `src/pageClass/VerifyId.ts:282` — if `defaultCountry` were ever empty, manual mode would silently skip and the upload would send an empty `issuing_country`. Not an issue today since country selection is enforced on the first page, but worth defensive handling if that enforcement is ever removed.
-
-**11.** `card-camera.ts:797-798` — the `manualOnly` branch in `cancelHold()` only resets detector state that manual mode never sets, so it is dead code once finding 6's getter exists.
-
-**12.** `VerifyId.ts:277`, `card-camera.ts:688`, `:558` — comments are long and sit in the wrong place. The "init() carries no model work" note is a fact about `card-detection.ts` and belongs on `CardDetection.init` itself (`card-detection.ts:303`).
-
-**13.** `card-camera.ts:584-594` — the `dataset.manual` early return sits above the "scanner unavailable" dialog, so if anyone ever runs the detector in manual mode the Retry dialog would silently never show. Moving the dialog check up removes the trap.
-
-**14.** `card-camera.ts:716`, `:531` — the `screen.orientation` listener is never removed, so every `CARDCAMERA` instance leaks after teardown along with its canvases (~7.7MB each). `_cleanup()` also does not detach `_manualClickHandler`. Pre-existing, but this MR's handler is now part of what gets retained.
-
-**15.** `manualCapture.ts:9` — the country rule is hardcoded, unlike `excludedDocTypes` which comes from the backend token. The next booklet country will need a package release plus every merchant upgrading. Fine for a first version, worth raising with backend later.
-
-**16.** `card-camera.ts:684`, `VerifyId.ts:282` — `manualOnly` is fixed for the life of the camera and `loadModel()` never runs in manual mode, so a future mid-session mode switch would report "scanner unavailable" on a healthy device. Loading the model inside `startDetection()` would keep it switchable.
-
-**17.** `src/translations/index.ts:12` — `mapped[key] || ""` means a second locale added without `doc_manual_capture` renders an empty hint rather than falling back to English. No live impact while `en.ts` is the only locale.
-
-**18.** *(addressed in `e97f4fd`)* `card-camera.ts:696` — shutter activation relies on event order: `#takePicButton` only exists when `loadedmetadata` runs because the video `resize` event (which builds the footer) happens to fire first. Verified that Chromium and WebKit both fire `resize` first, so this works today, but the spec does not guarantee the order. Also calling `enableManualCapture()` at the end of `renderCameraBottomUi()` when `manualOnly` is true (safe, it no-ops if already active) would make activation order-independent.