pipework 0.98.0 → 0.99.0

package/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.99.0
+
+- **Fixed: an alert or email audit record no longer waits on the Flow's own transaction** (#562). `auditAlert` (raise, resolve, acknowledge, link, digest, delivery) and the email audit wrote on a second connection; with `audit: { chain: true }`, after an audited write in the same transaction that insert waited on the tenant's chain-head lock, held until the transaction committed, while the transaction waited on the call: a hang Postgres cannot see. When the Flow has a transaction open on that database, the record is now written in it (a savepoint, so a failed write cannot abort it) and commits or rolls back with it; the alert row itself is still written on the system channel and kept on rollback. With no transaction open, nothing changes.
+
 ## 0.98.0
 
 - **Changed: access links' `resolveRateLimit` counts only codes that match no link, in Postgres across processes** (#560). It used to count every `resolve` and `beginUse`, hits included, in each process's memory, so 30 per minute served about 5 people opening one link from one address, and N processes gave a guesser N times the budget. Now only a code that matches no link counts (revoked, expired and exhausted links do not), in the new `access_link_miss` table, one fixed window per client shared by every process. Default 30 misses per 60 s; a client over it gets `rate-limited` for every code, valid ones included. `max` and `windowMs` are now checked at `accessLinks.create`. **Migration:** the new `access_link_miss` table; regenerate migrations.

package/dist/data/write/audit/bound-transaction.d.ts

@@ -0,0 +1,4 @@
+import type { DB } from '../../db/index.js';
+import type { Flow } from '../../../request/context/types.js';
+export declare function boundTransaction(flow: Flow, database?: string): DB | null;
+//# sourceMappingURL=bound-transaction.d.ts.map

package/dist/data/write/audit/bound-transaction.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"bound-transaction.d.ts","sourceRoot":"","sources":["../../../../src/data/write/audit/bound-transaction.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAAE,EAAE,EAAE,MAAM,mBAAmB,CAAA;AAC3C,OAAO,KAAK,EAAE,IAAI,EAAE,MAAM,mCAAmC,CAAA;AAG7D,wBAAgB,gBAAgB,CAAC,IAAI,EAAE,IAAI,EAAE,QAAQ,CAAC,EAAE,MAAM,GAAG,EAAE,GAAG,IAAI,CAMzE"}

package/dist/data/write/audit/bound-transaction.js

@@ -0,0 +1,12 @@
+// The Flow's open transaction on a database, for audit writers that must not
+// wait on it from a second connection. Null when none is bound.
+import { verifyTransactionBinding } from '../../../request/context/guard.js';
+export function boundTransaction(flow, database) {
+    const name = database ?? flow.instance.config.defaultDatabaseName();
+    const bound = flow.transactions.get(name);
+    if (bound === undefined)
+        return null;
+    verifyTransactionBinding(flow, bound, name);
+    return bound.drizzle;
+}
+//# sourceMappingURL=bound-transaction.js.map

package/dist/data/write/audit/bound-transaction.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"bound-transaction.js","sourceRoot":"","sources":["../../../../src/data/write/audit/bound-transaction.ts"],"names":[],"mappings":"AAAA,6EAA6E;AAC7E,gEAAgE;AAIhE,OAAO,EAAE,wBAAwB,EAAE,MAAM,mCAAmC,CAAA;AAE5E,MAAM,UAAU,gBAAgB,CAAC,IAAU,EAAE,QAAiB;IAC5D,MAAM,IAAI,GAAG,QAAQ,IAAI,IAAI,CAAC,QAAQ,CAAC,MAAM,CAAC,mBAAmB,EAAE,CAAA;IACnE,MAAM,KAAK,GAAG,IAAI,CAAC,YAAY,CAAC,GAAG,CAAC,IAAI,CAAC,CAAA;IACzC,IAAI,KAAK,KAAK,SAAS;QAAE,OAAO,IAAI,CAAA;IACpC,wBAAwB,CAAC,IAAI,EAAE,KAAK,EAAE,IAAI,CAAC,CAAA;IAC3C,OAAO,KAAK,CAAC,OAAO,CAAA;AACtB,CAAC"}

package/dist/infra/alerts/audit.d.ts

@@ -1,3 +1,7 @@
-/** Writes an `Alert` audit record under the Flow's open trace step; does nothing when no step is open. */
+/**
+ * Writes an `Alert` audit record under the Flow's open trace step; does nothing when no step is open.
+ * In the Flow's transaction on that database when one is open (a savepoint, so a failed write cannot abort it; it
+ * commits or rolls back with it), else on the system channel.
+ */
 export declare function auditAlert(verb: string, key: string, details: Record<string, unknown>, database?: string): Promise<void>;
 //# sourceMappingURL=audit.d.ts.map

package/dist/infra/alerts/audit.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"audit.d.ts","sourceRoot":"","sources":["../../../src/infra/alerts/audit.ts"],"names":[],"mappings":"AAMA,0GAA0G;AAC1G,wBAAsB,UAAU,CAAC,IAAI,EAAE,MAAM,EAAE,GAAG,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,EAAE,QAAQ,CAAC,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,CAe9H"}
+{"version":3,"file":"audit.d.ts","sourceRoot":"","sources":["../../../src/infra/alerts/audit.ts"],"names":[],"mappings":"AAQA;;;;GAIG;AACH,wBAAsB,UAAU,CAAC,IAAI,EAAE,MAAM,EAAE,GAAG,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,EAAE,QAAQ,CAAC,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC,CAoB9H"}

package/dist/infra/alerts/audit.js

@@ -1,9 +1,14 @@
 import { sql } from '../../data/db/sql.js';
 import { pipeSystem } from '../../data/db/db.js';
+import { boundTransaction } from '../../data/write/audit/bound-transaction.js';
 import { getContext } from '../../request/context/store.js';
 import { resolveActorId } from '../../data/write/audit/actor.js';
 import { getBaseLogger } from '../../core/logging/index.js';
-/** Writes an `Alert` audit record under the Flow's open trace step; does nothing when no step is open. */
+/**
+ * Writes an `Alert` audit record under the Flow's open trace step; does nothing when no step is open.
+ * In the Flow's transaction on that database when one is open (a savepoint, so a failed write cannot abort it; it
+ * commits or rolls back with it), else on the system channel.
+ */
 export async function auditAlert(verb, key, details, database) {
     const flow = getContext();
     const trace = flow?.trace;
@@ -11,12 +16,19 @@ export async function auditAlert(verb, key, details, database) {
     if (flow === undefined || trace === undefined || trace === null || stepId === null)
         return;
     try {
-        await pipeSystem(database).execute(sql `
-      INSERT INTO audit_record
-        (trace_day, trace_id, trace_step_id, tenant_id, actor_id, entity, verb, entity_id, after, occurred_at)
-      VALUES (${trace.openedDay}, ${trace.id}, ${stepId}, ${flow.tenant}, ${resolveActorId(flow)},
-        'Alert', ${verb}, ${key}, ${JSON.stringify(details)}::jsonb, now())
-    `);
+        const write = async (db) => {
+            await db.execute(sql `
+        INSERT INTO audit_record
+          (trace_day, trace_id, trace_step_id, tenant_id, actor_id, entity, verb, entity_id, after, occurred_at)
+        VALUES (${trace.openedDay}, ${trace.id}, ${stepId}, ${flow.tenant}, ${resolveActorId(flow)},
+          'Alert', ${verb}, ${key}, ${JSON.stringify(details)}::jsonb, now())
+      `);
+        };
+        const tx = boundTransaction(flow, database);
+        if (tx === null)
+            await write(pipeSystem(database));
+        else
+            await tx.transaction(write);
     }
     catch (err) {
         getBaseLogger().error({ err, traceId: trace.id }, `Failed to write the alert ${verb} audit record`);

package/dist/infra/alerts/audit.js.map

@@ -1 +1 @@
-{"version":3,"file":"audit.js","sourceRoot":"","sources":["../../../src/infra/alerts/audit.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,GAAG,EAAE,MAAM,sBAAsB,CAAA;AAC1C,OAAO,EAAE,UAAU,EAAE,MAAM,qBAAqB,CAAA;AAChD,OAAO,EAAE,UAAU,EAAE,MAAM,gCAAgC,CAAA;AAC3D,OAAO,EAAE,cAAc,EAAE,MAAM,iCAAiC,CAAA;AAChE,OAAO,EAAE,aAAa,EAAE,MAAM,6BAA6B,CAAA;AAE3D,0GAA0G;AAC1G,MAAM,CAAC,KAAK,UAAU,UAAU,CAAC,IAAY,EAAE,GAAW,EAAE,OAAgC,EAAE,QAAiB;IAC7G,MAAM,IAAI,GAAG,UAAU,EAAE,CAAA;IACzB,MAAM,KAAK,GAAG,IAAI,EAAE,KAAK,CAAA;IACzB,MAAM,MAAM,GAAG,KAAK,EAAE,MAAM,CAAC,UAAU,IAAI,IAAI,CAAA;IAC/C,IAAI,IAAI,KAAK,SAAS,IAAI,KAAK,KAAK,SAAS,IAAI,KAAK,KAAK,IAAI,IAAI,MAAM,KAAK,IAAI;QAAE,OAAM;IAC1F,IAAI,CAAC;QACH,MAAM,UAAU,CAAC,QAAQ,CAAC,CAAC,OAAO,CAAC,GAAG,CAAA;;;gBAG1B,KAAK,CAAC,SAAS,KAAK,KAAK,CAAC,EAAE,KAAK,MAAM,KAAK,IAAI,CAAC,MAAM,KAAK,cAAc,CAAC,IAAI,CAAC;mBAC7E,IAAI,KAAK,GAAG,KAAK,IAAI,CAAC,SAAS,CAAC,OAAO,CAAC;KACtD,CAAC,CAAA;IACJ,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,aAAa,EAAE,CAAC,KAAK,CAAC,EAAE,GAAG,EAAE,OAAO,EAAE,KAAK,CAAC,EAAE,EAAE,EAAE,6BAA6B,IAAI,eAAe,CAAC,CAAA;IACrG,CAAC;AACH,CAAC"}
+{"version":3,"file":"audit.js","sourceRoot":"","sources":["../../../src/infra/alerts/audit.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,GAAG,EAAE,MAAM,sBAAsB,CAAA;AAC1C,OAAO,EAAE,UAAU,EAAE,MAAM,qBAAqB,CAAA;AAEhD,OAAO,EAAE,gBAAgB,EAAE,MAAM,6CAA6C,CAAA;AAC9E,OAAO,EAAE,UAAU,EAAE,MAAM,gCAAgC,CAAA;AAC3D,OAAO,EAAE,cAAc,EAAE,MAAM,iCAAiC,CAAA;AAChE,OAAO,EAAE,aAAa,EAAE,MAAM,6BAA6B,CAAA;AAE3D;;;;GAIG;AACH,MAAM,CAAC,KAAK,UAAU,UAAU,CAAC,IAAY,EAAE,GAAW,EAAE,OAAgC,EAAE,QAAiB;IAC7G,MAAM,IAAI,GAAG,UAAU,EAAE,CAAA;IACzB,MAAM,KAAK,GAAG,IAAI,EAAE,KAAK,CAAA;IACzB,MAAM,MAAM,GAAG,KAAK,EAAE,MAAM,CAAC,UAAU,IAAI,IAAI,CAAA;IAC/C,IAAI,IAAI,KAAK,SAAS,IAAI,KAAK,KAAK,SAAS,IAAI,KAAK,KAAK,IAAI,IAAI,MAAM,KAAK,IAAI;QAAE,OAAM;IAC1F,IAAI,CAAC;QACH,MAAM,KAAK,GAAG,KAAK,EAAE,EAAM,EAAiB,EAAE;YAC5C,MAAM,EAAE,CAAC,OAAO,CAAC,GAAG,CAAA;;;kBAGR,KAAK,CAAC,SAAS,KAAK,KAAK,CAAC,EAAE,KAAK,MAAM,KAAK,IAAI,CAAC,MAAM,KAAK,cAAc,CAAC,IAAI,CAAC;qBAC7E,IAAI,KAAK,GAAG,KAAK,IAAI,CAAC,SAAS,CAAC,OAAO,CAAC;OACtD,CAAC,CAAA;QACJ,CAAC,CAAA;QACD,MAAM,EAAE,GAAG,gBAAgB,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAA;QAC3C,IAAI,EAAE,KAAK,IAAI;YAAE,MAAM,KAAK,CAAC,UAAU,CAAC,QAAQ,CAAC,CAAC,CAAA;;YAC7C,MAAM,EAAE,CAAC,WAAW,CAAC,KAAK,CAAC,CAAA;IAClC,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,aAAa,EAAE,CAAC,KAAK,CAAC,EAAE,GAAG,EAAE,OAAO,EAAE,KAAK,CAAC,EAAE,EAAE,EAAE,6BAA6B,IAAI,eAAe,CAAC,CAAA;IACrG,CAAC;AACH,CAAC"}

package/dist/infra/email/audit.d.ts

@@ -1,3 +1,7 @@
-/** Writes an audit record (entity `Email` unless given) under the Flow's open trace step; does nothing when no step is open. */
+/**
+ * Writes an audit record (entity `Email` unless given) under the Flow's open trace step; does nothing when no step is open.
+ * In the Flow's transaction on that database when one is open (a savepoint, so a failed write cannot abort it; it
+ * commits or rolls back with it), else on the system channel.
+ */
 export declare function auditEmail(verb: string, entityId: string | null, details: Record<string, unknown>, entity?: string): Promise<void>;
 //# sourceMappingURL=audit.d.ts.map

package/dist/infra/email/audit.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"audit.d.ts","sourceRoot":"","sources":["../../../src/infra/email/audit.ts"],"names":[],"mappings":"AAMA,gIAAgI;AAChI,wBAAsB,UAAU,CAAC,IAAI,EAAE,MAAM,EAAE,QAAQ,EAAE,MAAM,GAAG,IAAI,EAAE,OAAO,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,EAAE,MAAM,SAAU,GAAG,OAAO,CAAC,IAAI,CAAC,CAezI"}
+{"version":3,"file":"audit.d.ts","sourceRoot":"","sources":["../../../src/infra/email/audit.ts"],"names":[],"mappings":"AAQA;;;;GAIG;AACH,wBAAsB,UAAU,CAAC,IAAI,EAAE,MAAM,EAAE,QAAQ,EAAE,MAAM,GAAG,IAAI,EAAE,OAAO,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,EAAE,MAAM,SAAU,GAAG,OAAO,CAAC,IAAI,CAAC,CAoBzI"}

package/dist/infra/email/audit.js

@@ -1,9 +1,14 @@
 import { sql } from '../../data/db/sql.js';
 import { pipeSystem } from '../../data/db/db.js';
+import { boundTransaction } from '../../data/write/audit/bound-transaction.js';
 import { getContext } from '../../request/context/store.js';
 import { resolveActorId } from '../../data/write/audit/actor.js';
 import { getBaseLogger } from '../../core/logging/index.js';
-/** Writes an audit record (entity `Email` unless given) under the Flow's open trace step; does nothing when no step is open. */
+/**
+ * Writes an audit record (entity `Email` unless given) under the Flow's open trace step; does nothing when no step is open.
+ * In the Flow's transaction on that database when one is open (a savepoint, so a failed write cannot abort it; it
+ * commits or rolls back with it), else on the system channel.
+ */
 export async function auditEmail(verb, entityId, details, entity = 'Email') {
     const flow = getContext();
     const trace = flow?.trace;
@@ -11,12 +16,19 @@ export async function auditEmail(verb, entityId, details, entity = 'Email') {
     if (flow === undefined || trace === undefined || trace === null || stepId === null)
         return;
     try {
-        await pipeSystem().execute(sql `
-      INSERT INTO audit_record
-        (trace_day, trace_id, trace_step_id, tenant_id, actor_id, entity, verb, entity_id, after, occurred_at)
-      VALUES (${trace.openedDay}, ${trace.id}, ${stepId}, ${flow.tenant}, ${resolveActorId(flow)},
-        ${entity}, ${verb}, ${entityId}, ${JSON.stringify(details)}::jsonb, now())
-    `);
+        const write = async (db) => {
+            await db.execute(sql `
+        INSERT INTO audit_record
+          (trace_day, trace_id, trace_step_id, tenant_id, actor_id, entity, verb, entity_id, after, occurred_at)
+        VALUES (${trace.openedDay}, ${trace.id}, ${stepId}, ${flow.tenant}, ${resolveActorId(flow)},
+          ${entity}, ${verb}, ${entityId}, ${JSON.stringify(details)}::jsonb, now())
+      `);
+        };
+        const tx = boundTransaction(flow);
+        if (tx === null)
+            await write(pipeSystem());
+        else
+            await tx.transaction(write);
     }
     catch (err) {
         getBaseLogger().error({ err, traceId: trace.id }, `Failed to write the email ${verb} audit record`);

package/dist/infra/email/audit.js.map

@@ -1 +1 @@
-{"version":3,"file":"audit.js","sourceRoot":"","sources":["../../../src/infra/email/audit.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,GAAG,EAAE,MAAM,sBAAsB,CAAA;AAC1C,OAAO,EAAE,UAAU,EAAE,MAAM,qBAAqB,CAAA;AAChD,OAAO,EAAE,UAAU,EAAE,MAAM,gCAAgC,CAAA;AAC3D,OAAO,EAAE,cAAc,EAAE,MAAM,iCAAiC,CAAA;AAChE,OAAO,EAAE,aAAa,EAAE,MAAM,6BAA6B,CAAA;AAE3D,gIAAgI;AAChI,MAAM,CAAC,KAAK,UAAU,UAAU,CAAC,IAAY,EAAE,QAAuB,EAAE,OAAgC,EAAE,MAAM,GAAG,OAAO;IACxH,MAAM,IAAI,GAAG,UAAU,EAAE,CAAA;IACzB,MAAM,KAAK,GAAG,IAAI,EAAE,KAAK,CAAA;IACzB,MAAM,MAAM,GAAG,KAAK,EAAE,MAAM,CAAC,UAAU,IAAI,IAAI,CAAA;IAC/C,IAAI,IAAI,KAAK,SAAS,IAAI,KAAK,KAAK,SAAS,IAAI,KAAK,KAAK,IAAI,IAAI,MAAM,KAAK,IAAI;QAAE,OAAM;IAC1F,IAAI,CAAC;QACH,MAAM,UAAU,EAAE,CAAC,OAAO,CAAC,GAAG,CAAA;;;gBAGlB,KAAK,CAAC,SAAS,KAAK,KAAK,CAAC,EAAE,KAAK,MAAM,KAAK,IAAI,CAAC,MAAM,KAAK,cAAc,CAAC,IAAI,CAAC;UACtF,MAAM,KAAK,IAAI,KAAK,QAAQ,KAAK,IAAI,CAAC,SAAS,CAAC,OAAO,CAAC;KAC7D,CAAC,CAAA;IACJ,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,aAAa,EAAE,CAAC,KAAK,CAAC,EAAE,GAAG,EAAE,OAAO,EAAE,KAAK,CAAC,EAAE,EAAE,EAAE,6BAA6B,IAAI,eAAe,CAAC,CAAA;IACrG,CAAC;AACH,CAAC"}
+{"version":3,"file":"audit.js","sourceRoot":"","sources":["../../../src/infra/email/audit.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,GAAG,EAAE,MAAM,sBAAsB,CAAA;AAC1C,OAAO,EAAE,UAAU,EAAE,MAAM,qBAAqB,CAAA;AAEhD,OAAO,EAAE,gBAAgB,EAAE,MAAM,6CAA6C,CAAA;AAC9E,OAAO,EAAE,UAAU,EAAE,MAAM,gCAAgC,CAAA;AAC3D,OAAO,EAAE,cAAc,EAAE,MAAM,iCAAiC,CAAA;AAChE,OAAO,EAAE,aAAa,EAAE,MAAM,6BAA6B,CAAA;AAE3D;;;;GAIG;AACH,MAAM,CAAC,KAAK,UAAU,UAAU,CAAC,IAAY,EAAE,QAAuB,EAAE,OAAgC,EAAE,MAAM,GAAG,OAAO;IACxH,MAAM,IAAI,GAAG,UAAU,EAAE,CAAA;IACzB,MAAM,KAAK,GAAG,IAAI,EAAE,KAAK,CAAA;IACzB,MAAM,MAAM,GAAG,KAAK,EAAE,MAAM,CAAC,UAAU,IAAI,IAAI,CAAA;IAC/C,IAAI,IAAI,KAAK,SAAS,IAAI,KAAK,KAAK,SAAS,IAAI,KAAK,KAAK,IAAI,IAAI,MAAM,KAAK,IAAI;QAAE,OAAM;IAC1F,IAAI,CAAC;QACH,MAAM,KAAK,GAAG,KAAK,EAAE,EAAM,EAAiB,EAAE;YAC5C,MAAM,EAAE,CAAC,OAAO,CAAC,GAAG,CAAA;;;kBAGR,KAAK,CAAC,SAAS,KAAK,KAAK,CAAC,EAAE,KAAK,MAAM,KAAK,IAAI,CAAC,MAAM,KAAK,cAAc,CAAC,IAAI,CAAC;YACtF,MAAM,KAAK,IAAI,KAAK,QAAQ,KAAK,IAAI,CAAC,SAAS,CAAC,OAAO,CAAC;OAC7D,CAAC,CAAA;QACJ,CAAC,CAAA;QACD,MAAM,EAAE,GAAG,gBAAgB,CAAC,IAAI,CAAC,CAAA;QACjC,IAAI,EAAE,KAAK,IAAI;YAAE,MAAM,KAAK,CAAC,UAAU,EAAE,CAAC,CAAA;;YACrC,MAAM,EAAE,CAAC,WAAW,CAAC,KAAK,CAAC,CAAA;IAClC,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,aAAa,EAAE,CAAC,KAAK,CAAC,EAAE,GAAG,EAAE,OAAO,EAAE,KAAK,CAAC,EAAE,EAAE,EAAE,6BAA6B,IAAI,eAAe,CAAC,CAAA;IACrG,CAAC;AACH,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pipework",
-  "version": "0.98.0",
+  "version": "0.99.0",
   "description": "TypeScript framework for multi-tenant SaaS applications. PostgreSQL-only.",
   "type": "module",
   "license": "MIT",