pipework 0.258.0 → 0.259.0

package/src/test/setup.ts

@@ -238,10 +238,10 @@ async function runSetup(instance: Manifold, tracker: PhaseTracker): Promise<Map<
 async function prepareRun(adminUrl: string, liveTemplates: ReadonlySet<string>, tracker: PhaseTracker): Promise<void> {
   runAdminUrl = adminUrl
   if (adminClient === null) {
-    adminClient = postgres(adminUrl, { max: 1, onnotice: () => {} })
+    adminClient = postgres(adminUrl, { max: 1, fetch_types: false, onnotice: () => {} })
   }
   if (lockClient === null) {
-    lockClient = postgres(adminUrl, { max: 1, idle_timeout: 0, max_lifetime: 0, onnotice: () => {} })
+    lockClient = postgres(adminUrl, { max: 1, fetch_types: false, idle_timeout: 0, max_lifetime: 0, onnotice: () => {} })
     await lockClient`SELECT pg_advisory_lock(${runLockKey(runNonce).toString()}::bigint)`
   }
   armWorkerShutdown()
@@ -416,6 +416,7 @@ async function templateIsReady(plan: TemplatePlan): Promise<boolean> {
 async function readTemplateMarker(plan: TemplatePlan): Promise<boolean> {
   const client = postgres(siblingUrl(plan.dbConfig, plan.templateDb), {
     max: 1,
+    fetch_types: false,
     onnotice: () => {},
   })
   try {
@@ -782,7 +783,7 @@ async function provisionTestSystemPolicy(
   beat: (detail: string) => void,
 ): Promise<void> {
   for (const url of migrateUrl === undefined ? [templateUrl] : [templateUrl, migrateUrl]) {
-    const client = postgres(url, { max: 1, onnotice: () => {} })
+    const client = postgres(url, { max: 1, fetch_types: false, onnotice: () => {} })
     try {
       const tables = await client<{ ident: string; name: string }[]>`
         SELECT c.oid::regclass::text AS ident, c.relname AS name
@@ -1060,7 +1061,7 @@ async function provisionTemplateRole(
     `END $$`,
   )))
 
-  const templateClient = postgres(templateUrl, { max: 1, onnotice: () => {} })
+  const templateClient = postgres(templateUrl, { max: 1, fetch_types: false, onnotice: () => {} })
   const templateDb = drizzle(templateClient)
 
   await templateDb.execute(sql.raw(`GRANT USAGE ON SCHEMA public TO ${roleIdent}`))
@@ -1089,7 +1090,7 @@ async function provisionTemplateRole(
   // grantor grants what it owns and nothing else.
   await grantOwnedObjects(templateClient, roleIdent, APP_ROLE_GRANTS, beat)
 
-  const migrateClient = postgres(migrateUrl, { max: 1, onnotice: () => {} })
+  const migrateClient = postgres(migrateUrl, { max: 1, fetch_types: false, onnotice: () => {} })
   try {
     await grantOwnedObjects(migrateClient, roleIdent, APP_ROLE_GRANTS, beat)
     // The test login is the role tests connect as, and it no longer owns what

package/src/test/watch.ts

@@ -74,7 +74,8 @@ async function sampleLine(target: TestWatchTarget): Promise<string> {
 }
 
 async function backends(adminUrl: string, databases: string[]): Promise<string[]> {
-  const client = postgres(adminUrl, { max: 1, onnotice: () => {}, connect_timeout: 5 })
+  // A probe ended with a destroy timeout must not have an un-awaited type fetch in flight.
+  const client = postgres(adminUrl, { max: 1, onnotice: () => {}, connect_timeout: 5, fetch_types: false })
   try {
     const rows = await Promise.race([
       client<BackendRow[]>`
@@ -82,7 +83,7 @@ async function backends(adminUrl: string, databases: string[]): Promise<string[]
                round(extract(epoch FROM (now() - state_change))::numeric, 1)::text AS state_s,
                pg_blocking_pids(pid)::text AS blocked_by, query
           FROM pg_stat_activity
-         WHERE datname = ANY(${databases}) AND pid <> pg_backend_pid()
+         WHERE datname IN (SELECT jsonb_array_elements_text(${client.json(databases)})) AND pid <> pg_backend_pid()
          ORDER BY datname, pid`,
       new Promise<never>((_, reject) => {
         setTimeout(() => reject(new Error('pg_stat_activity query timed out')), WATCH_QUERY_TIMEOUT_MS).unref()