piper-utils 1.1.69 → 1.1.71

package/src/index.js

@@ -34,6 +34,7 @@ import { requireCrmAccess as requireCrmAccessImport, requireTicketAccess as requ
 import { scopeToOwnBusiness as scopeToOwnBusinessImport, scopeToPartnerBook as scopeToPartnerBookImport, scopeToBookUnionOwn as scopeToBookUnionOwnImport } from './database/dbUtils/partnerAccess/accessScope.js';
 import { assertCanWriteOwnBusiness as assertCanWriteOwnBusinessImport, assertCanWriteBookBusiness as assertCanWriteBookBusinessImport, assertCanWriteBookUnionOwn as assertCanWriteBookUnionOwnImport, stampOwnBusinessId as stampOwnBusinessIdImport } from './database/dbUtils/partnerAccess/accessWrites.js';
 import { createAccessHelpers as createAccessHelpersImport } from './database/dbUtils/partnerAccess/createAccessHelpers.js';
+import { contractChoices as contractChoicesImport, contractStatuses as contractStatusesImport, isContractChoice as isContractChoiceImport } from './contract/contract.js';
 import {
     attachAudit as attachAuditImport,
     bindAuditRequest as bindAuditRequestImport,
@@ -96,3 +97,6 @@ export const decrementWithAudit = decrementWithAuditImport;
 export const getAuditFilter = getAuditFilterImport;
 export const getAuditModel = getAuditModelImport;
 export const incrementWithAudit = incrementWithAuditImport;
+export const contractChoices = contractChoicesImport;
+export const contractStatuses = contractStatusesImport;
+export const isContractChoice = isContractChoiceImport;

package/src/requestResponse/requestResponse.test.js

@@ -135,6 +135,64 @@ describe('requestResponse', () => {
             expect(res.headers['Access-Control-Allow-Origin']).toEqual('*');
             expect(res.headers['Referrer-Policy']).toEqual('strict-origin-when-cross-origin');
         });
+        it('should NOT log a known/handled 4xx error (errorCode + 4xx)', () => {
+            const prevBuildEnv = process.env.BUILD_ENV;
+            const prevUtilLog = process.env.UTIL_LOG;
+            process.env.BUILD_ENV = 'production';
+            delete process.env.UTIL_LOG;
+            const errorSpy = spyOn(console, 'error');
+
+            const res = failure({ statusCode: 400, errorCode: '4007', message: 'Insufficient funds' }, {});
+
+            expect(errorSpy).not.toHaveBeenCalled();
+            expect(res.statusCode).toEqual(400);
+
+            process.env.BUILD_ENV = prevBuildEnv;
+            if (prevUtilLog === undefined) {
+                delete process.env.UTIL_LOG;
+            } else {
+                process.env.UTIL_LOG = prevUtilLog;
+            }
+        });
+        it('should log the full object for a 5xx error', () => {
+            const prevBuildEnv = process.env.BUILD_ENV;
+            const prevUtilLog = process.env.UTIL_LOG;
+            process.env.BUILD_ENV = 'production';
+            delete process.env.UTIL_LOG;
+            const errorSpy = spyOn(console, 'error');
+            const body = { statusCode: 500, errorCode: '5001', message: 'boom' };
+
+            failure(body, {});
+
+            expect(errorSpy).toHaveBeenCalledWith('------->UTIL ERROR:', 500, 'boom', body);
+
+            process.env.BUILD_ENV = prevBuildEnv;
+            if (prevUtilLog === undefined) {
+                delete process.env.UTIL_LOG;
+            } else {
+                process.env.UTIL_LOG = prevUtilLog;
+            }
+        });
+        it('should log a concise one-liner for an unmapped 4xx error (no deliberate errorCode)', () => {
+            const prevBuildEnv = process.env.BUILD_ENV;
+            const prevUtilLog = process.env.UTIL_LOG;
+            process.env.BUILD_ENV = 'production';
+            delete process.env.UTIL_LOG;
+            const errorSpy = spyOn(console, 'error');
+
+            // A Joi-style error (has `details`, no errorCode) maps to a 4xx via detectJoyError,
+            // so the original body is not a known client error -> concise branch, no object dump.
+            failure({ details: 'bar' }, {});
+
+            expect(errorSpy).toHaveBeenCalledWith('------->UTIL ERROR:', 400, 'INTERNAL UTIL ERROR');
+
+            process.env.BUILD_ENV = prevBuildEnv;
+            if (prevUtilLog === undefined) {
+                delete process.env.UTIL_LOG;
+            } else {
+                process.env.UTIL_LOG = prevUtilLog;
+            }
+        });
     });
     describe('parseBody', () => {
         it('parse a json string', () => {