piper-utils 1.1.68 → 1.1.70

package/src/requestResponse/requestResponse.js

@@ -125,6 +125,12 @@ export function failure(body = {}, options) {
     }
     const newBody = _.merge(NORMAL_ERROR, cleanedErrorBody);
 
+    const debugLogging = process.env.UTIL_LOG === 'LOG_ALL' || process.env.BUILD_ENV === 'test';
+    if (!debugLogging && newBody.statusCode >= 500) {
+        // Log the raw error object so thrown Error stacks survive (JSON.stringify drops them)
+        console.error('------->UTIL ERROR:', newBody.statusCode, _.get(body, 'message', ''), body);
+    }
+
     return buildResponse(newBody.statusCode, newBody);
 }
 
@@ -266,7 +272,6 @@ export function detectJoyError(body) {
         return acc;
     }, '');
 
-    console.error('USER VALIDATION ERROR:', body);
     const msg = (joyError?.message || '') + v;
 
     if (msg) {

package/src/requestResponse/requestResponse.test.js

@@ -135,6 +135,64 @@ describe('requestResponse', () => {
             expect(res.headers['Access-Control-Allow-Origin']).toEqual('*');
             expect(res.headers['Referrer-Policy']).toEqual('strict-origin-when-cross-origin');
         });
+        it('should NOT log a known/handled 4xx error (errorCode + 4xx)', () => {
+            const prevBuildEnv = process.env.BUILD_ENV;
+            const prevUtilLog = process.env.UTIL_LOG;
+            process.env.BUILD_ENV = 'production';
+            delete process.env.UTIL_LOG;
+            const errorSpy = spyOn(console, 'error');
+
+            const res = failure({ statusCode: 400, errorCode: '4007', message: 'Insufficient funds' }, {});
+
+            expect(errorSpy).not.toHaveBeenCalled();
+            expect(res.statusCode).toEqual(400);
+
+            process.env.BUILD_ENV = prevBuildEnv;
+            if (prevUtilLog === undefined) {
+                delete process.env.UTIL_LOG;
+            } else {
+                process.env.UTIL_LOG = prevUtilLog;
+            }
+        });
+        it('should log the full object for a 5xx error', () => {
+            const prevBuildEnv = process.env.BUILD_ENV;
+            const prevUtilLog = process.env.UTIL_LOG;
+            process.env.BUILD_ENV = 'production';
+            delete process.env.UTIL_LOG;
+            const errorSpy = spyOn(console, 'error');
+            const body = { statusCode: 500, errorCode: '5001', message: 'boom' };
+
+            failure(body, {});
+
+            expect(errorSpy).toHaveBeenCalledWith('------->UTIL ERROR:', 500, 'boom', body);
+
+            process.env.BUILD_ENV = prevBuildEnv;
+            if (prevUtilLog === undefined) {
+                delete process.env.UTIL_LOG;
+            } else {
+                process.env.UTIL_LOG = prevUtilLog;
+            }
+        });
+        it('should log a concise one-liner for an unmapped 4xx error (no deliberate errorCode)', () => {
+            const prevBuildEnv = process.env.BUILD_ENV;
+            const prevUtilLog = process.env.UTIL_LOG;
+            process.env.BUILD_ENV = 'production';
+            delete process.env.UTIL_LOG;
+            const errorSpy = spyOn(console, 'error');
+
+            // A Joi-style error (has `details`, no errorCode) maps to a 4xx via detectJoyError,
+            // so the original body is not a known client error -> concise branch, no object dump.
+            failure({ details: 'bar' }, {});
+
+            expect(errorSpy).toHaveBeenCalledWith('------->UTIL ERROR:', 400, 'INTERNAL UTIL ERROR');
+
+            process.env.BUILD_ENV = prevBuildEnv;
+            if (prevUtilLog === undefined) {
+                delete process.env.UTIL_LOG;
+            } else {
+                process.env.UTIL_LOG = prevUtilLog;
+            }
+        });
     });
     describe('parseBody', () => {
         it('parse a json string', () => {