pinokiod 8.0.78 → 8.0.80

package/kernel/api/notify/index.js

@@ -6,7 +6,8 @@
       href: <link location to open>,
       target: <target for window.open()>,
       features: <windowFeatures>,
-      audio: <play audio if true>,
+      type: <notification type>,
+      silent: <disable the notification sound if true>,
     }
   }
 (*/

package/kernel/vault/automatic_scans.js

@@ -1,7 +1,6 @@
 const fs = require("fs")
 const path = require("path")
 const {
-  SIZE_THRESHOLD,
   isCandidateFileSize,
   SHA256_RE,
   ENTRY_BATCH_SIZE
@@ -276,7 +275,7 @@ class AutomaticScans {
     if (!collected.size) this.discardChangedPaths(app)
   }
 
-  async candidatePolicy() {
+  async candidatePolicy(app = null) {
     const cached = this.vault.lastScanCache &&
       typeof this.vault.lastScanCache.get === "function"
       ? this.vault.lastScanCache.get("")
@@ -284,13 +283,13 @@ class AutomaticScans {
     const scan = cached || (this.vault.registry
       ? await this.vault.registry.scanFor()
       : null)
-    const threshold = scan ? Number(scan.candidate_min_bytes) : NaN
+    const threshold = app
+      ? await this.vault.candidateSizeForApp(app)
+      : await this.vault.candidateSizeSetting(null)
     const hasLinkableDevices = !!(
       scan && Array.isArray(scan.linkable_devices))
     return {
-      threshold: Number.isFinite(threshold) && threshold >= 0
-        ? threshold
-        : SIZE_THRESHOLD,
+      threshold,
       linkability_known: hasLinkableDevices,
       linkable_devices: new Set(hasLinkableDevices
         ? scan.linkable_devices
@@ -1039,7 +1038,7 @@ class AutomaticScans {
       unstable_hashes: 0
     }
     markStage("policy-read")
-    const policy = await this.candidatePolicy()
+    const policy = await this.candidatePolicy(app)
     const threshold = await this.candidateThreshold(policy)
     const linkableDevices = policy.linkable_devices
     const paths = [...new Set(active.paths || [])].filter((filePath) =>

package/kernel/vault/index.js

@@ -1899,6 +1899,25 @@ class Vault {
         }
         return this.runMutation(() =>
           this.removeExternalSource(payload.source_id))
+      case "set_candidate_size": {
+        if (payload.scope_id != null &&
+            typeof payload.scope_id !== "string") {
+          return { error: "Choose a valid scan scope." }
+        }
+        const scopeId = typeof payload.scope_id === "string" && payload.scope_id
+          ? payload.scope_id
+          : null
+        if (scopeId) {
+          const source = this.scanSource(scopeId)
+          if (!source || source.kind !== "app") {
+            return { error: "That app is no longer available." }
+          }
+        }
+        return this.setCandidateSizeSetting(
+          scopeId,
+          payload.candidate_size
+        )
+      }
       case "scan": {
         const scanSource = payload.scope_id
           ? this.scanSource(payload.scope_id)
@@ -1913,22 +1932,21 @@ class Vault {
             code: "global_scan_required"
           }
         }
-        let threshold = this.sizeThreshold
-        if (payload.candidate_size != null) {
-          if (!CANDIDATE_SIZE_OPTIONS.includes(payload.candidate_size)) {
-            return { error: "Choose a valid minimum file size." }
-          }
-          threshold = payload.candidate_size
-        }
+        const settingScopeId = scanSource && scanSource.kind === "app"
+          ? scanSource.id
+          : null
+        const threshold = await this.candidateSizeSetting(settingScopeId)
         return this.startScan(payload.scope_id || null, threshold)
       }
       case "cancel_scan":
         return this.cancelScan()
-      case "find_folders":
+      case "find_folders": {
+        const threshold = await this.candidateSizeSetting(null)
         return this.startFolderDiscovery(
           payload.path,
-          payload.candidate_size
+          threshold
         )
+      }
       case "cancel_find_folders":
         return this.cancelFolderDiscovery()
       case "clear_find_folders":
@@ -3115,6 +3133,33 @@ class Vault {
     return scoped
   }
 
+  async candidateSizeSetting(scopeId = null) {
+    const setting = await this.registry.scanSetting(scopeId)
+    const minimum = setting && Number(setting.candidate_min_bytes)
+    if (CANDIDATE_SIZE_OPTIONS.includes(minimum)) return minimum
+    return SIZE_THRESHOLD
+  }
+
+  async setCandidateSizeSetting(scopeId = null, candidateMinBytes) {
+    if (!Number.isSafeInteger(candidateMinBytes) ||
+        !CANDIDATE_SIZE_OPTIONS.includes(candidateMinBytes)) {
+      return { error: "Choose a valid minimum file size." }
+    }
+    const setting = await this.registry.setScanSetting(
+      scopeId,
+      candidateMinBytes
+    )
+    return {
+      scope_id: scopeId || null,
+      candidate_min_bytes: setting.candidate_min_bytes,
+      updated_at: setting.updated_at
+    }
+  }
+
+  candidateSizeForApp(app) {
+    return this.candidateSizeSetting(sourceId("app", app))
+  }
+
   sourceCountMaps(summaryRows) {
     const counts = {
       all: {},
@@ -3391,13 +3436,10 @@ class Vault {
     const lastScan = await this.scanForScope(scopeId)
     const globalScan = scopeId ? await this.scanForScope(null) : lastScan
     const globalScanReady = this.globalScanIsReady(globalScan)
-    const publishedCandidateMinimum = globalScan
-      ? Number(globalScan.candidate_min_bytes)
-      : NaN
-    const globalCandidateMinimum = Number.isFinite(
-      publishedCandidateMinimum) && publishedCandidateMinimum >= 0
-      ? publishedCandidateMinimum
-      : SIZE_THRESHOLD
+    const candidateMinimum = await this.candidateSizeSetting(scopeId)
+    const globalCandidateMinimum = scopeId
+      ? await this.candidateSizeSetting(null)
+      : candidateMinimum
     const before = lastScan && Number.isFinite(lastScan.bytes_total)
       ? lastScan.bytes_total
       : 0
@@ -3435,6 +3477,7 @@ class Vault {
     const result = {
       enabled: true,
       global_scan_ready: globalScanReady,
+      candidate_min_bytes: candidateMinimum,
       global_candidate_min_bytes: globalCandidateMinimum,
       mode: this.mode,
       scan: this.scanStatus(),

package/kernel/vault/registry.js

@@ -172,6 +172,8 @@ for (const method of [
   "removeAutomaticAppScanApp",
   "setAutomaticAppScanState",
   "scanFor",
+  "scanSetting",
+  "setScanSetting",
   "removeScan",
   "beginScan",
   "abortScan",

package/kernel/vault/registry_core.js

@@ -306,6 +306,13 @@ class RegistryCore {
       FROM automatic_app_scans
       WHERE state = 'paused';
 
+      CREATE TABLE IF NOT EXISTS minimum_size_settings (
+        scope_id TEXT PRIMARY KEY,
+        candidate_min_bytes INTEGER NOT NULL CHECK (
+          candidate_min_bytes >= 0
+        ),
+        updated_at INTEGER NOT NULL
+      );
     `)
     const automaticScanColumns = new Set(this.database.prepare(
       "PRAGMA table_info(automatic_app_scans)"
@@ -2670,6 +2677,38 @@ class RegistryCore {
     })
   }
 
+  scanSetting(scopeId = null) {
+    const row = this.database.prepare(`
+      SELECT candidate_min_bytes, updated_at
+      FROM minimum_size_settings
+      WHERE scope_id = ?
+    `).get(scopeId || "")
+    return row ? {
+      candidate_min_bytes: Number(row.candidate_min_bytes),
+      updated_at: Number(row.updated_at) || 0
+    } : null
+  }
+
+  setScanSetting(scopeId = null, candidateMinBytes) {
+    const minimum = candidateMinBytes
+    if (!Number.isSafeInteger(minimum) || minimum < 0) {
+      throw new Error("Invalid minimum file size setting.")
+    }
+    const updatedAt = Date.now()
+    this.database.prepare(`
+      INSERT INTO minimum_size_settings(
+        scope_id, candidate_min_bytes, updated_at
+      ) VALUES (?, ?, ?)
+      ON CONFLICT(scope_id) DO UPDATE SET
+        candidate_min_bytes = excluded.candidate_min_bytes,
+        updated_at = excluded.updated_at
+    `).run(scopeId || "", minimum, updatedAt)
+    return {
+      candidate_min_bytes: minimum,
+      updated_at: updatedAt
+    }
+  }
+
   automaticAppScanStates() {
     return this.database.prepare(`
       SELECT app, state, signature, updated_at

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pinokiod",
-  "version": "8.0.78",
+  "version": "8.0.80",
   "description": "",
   "main": "index.js",
   "scripts": {

package/server/index.js

@@ -1870,8 +1870,10 @@ class Server {
       }
       return ""
     }
+    const launcherPath = this.kernel.path("api", name)
+    const launcherDisplayPath = this.formatLogsDisplayPath(launcherPath)
     const launcherRemote = this.kernel.api && typeof this.kernel.api.parentGitURI === "function"
-      ? (this.kernel.api.parentGitURI(this.kernel.path("api", name)) || "")
+      ? (this.kernel.api.parentGitURI(launcherPath) || "")
       : ""
     const launcherRemoteUrl = buildGitRemoteWebUrl(launcherRemote)
 
@@ -1926,7 +1928,8 @@ class Server {
       dev_link,
 //      repos,
       current_urls,
-      path: this.kernel.path("api", name),
+      path: launcherPath,
+      launcher_path_display: launcherDisplayPath,
       log_path: this.kernel.path("api", name, "logs"),
       plugin_menu: null,
       portal: this.portal,

package/server/public/tab-idle-notifier.js

@@ -276,17 +276,24 @@
       return;
     }
     const rect = anchor.getBoundingClientRect();
-    const scrollX = window.scrollX || window.pageXOffset || 0;
-    const scrollY = window.scrollY || window.pageYOffset || 0;
-    const top = rect.bottom + scrollY + 6;
-    let left = rect.left + scrollX;
+    const viewportPadding = 12;
+    const menuGap = 6;
     const menuWidth = menu.offsetWidth || 0;
-    const viewportRight = scrollX + window.innerWidth;
-    if (left + menuWidth > viewportRight - 12) {
-      left = Math.max(scrollX + 12, viewportRight - menuWidth - 12);
-    }
-    if (left < scrollX + 12) {
-      left = scrollX + 12;
+    const menuHeight = menu.offsetHeight || 0;
+    let left = rect.left;
+    let top = rect.bottom + menuGap;
+    if (left + menuWidth > window.innerWidth - viewportPadding) {
+      left = Math.max(viewportPadding, window.innerWidth - menuWidth - viewportPadding);
+    }
+    if (left < viewportPadding) {
+      left = viewportPadding;
+    }
+    const topAbove = rect.top - menuHeight - menuGap;
+    if (top + menuHeight > window.innerHeight - viewportPadding && topAbove >= viewportPadding) {
+      top = topAbove;
+    } else {
+      top = Math.min(top, Math.max(viewportPadding, window.innerHeight - menuHeight - viewportPadding));
+      top = Math.max(viewportPadding, top);
     }
     menu.style.top = `${Math.round(top)}px`;
     menu.style.left = `${Math.round(left)}px`;
@@ -857,10 +864,13 @@
   color: var(--pinokio-focus-color, #4c9afe);
 }
 .pinokio-notify-popover {
-  position: absolute;
+  position: fixed;
   z-index: 2147482000;
   min-width: 220px;
   max-width: 280px;
+  max-height: calc(100dvh - 24px);
+  overflow-y: auto;
+  overscroll-behavior: contain;
   color: #f8fafc;
   background: rgba(15, 23, 42, 0.97);
   border-radius: 10px;
@@ -980,6 +990,133 @@ const syncToggleAppearance = (toggle, enabled) => {
     });
   };
 
+  const updateNotificationPreferenceForFrame = (frameName, enabled) => {
+    const state = getOrCreateState(frameName);
+    if (!state) {
+      return null;
+    }
+    const next = Boolean(enabled);
+    state.notifyEnabled = next;
+    setPreference(frameName, next);
+    syncInlineToggleStateForFrame(frameName);
+    return next;
+  };
+
+  const populateInlineSoundSelect = (select, options) => {
+    if (!(select instanceof HTMLSelectElement)) {
+      return;
+    }
+    const effectiveOptions = Array.isArray(options) && options.length > 0
+      ? options
+      : baseSoundOptions();
+    const selectedChoice = globalSoundPreference?.choice || SOUND_DEFAULT_CHOICE;
+    select.replaceChildren();
+    effectiveOptions.forEach((option) => {
+      if (!option || !option.value || !option.label) {
+        return;
+      }
+      const node = document.createElement('option');
+      node.value = option.value;
+      node.textContent = option.label;
+      node.selected = option.value === selectedChoice;
+      select.appendChild(node);
+    });
+    if (Array.from(select.options).some((option) => option.value === selectedChoice)) {
+      select.value = selectedChoice;
+    } else {
+      select.value = SOUND_DEFAULT_CHOICE;
+    }
+  };
+
+  const mountNotificationSettingsForLink = (link, container, callbacks = {}) => {
+    if (!(container instanceof HTMLElement)) {
+      return false;
+    }
+    const context = getNotificationMenuStateForLink(link);
+    if (!context.available || !context.frameName) {
+      return false;
+    }
+    const state = getOrCreateState(context.frameName);
+    if (!state) {
+      return false;
+    }
+
+    container.replaceChildren();
+
+    const toggleRow = document.createElement('div');
+    toggleRow.className = 'tab-link-notification-setting-row';
+    const toggleLabel = document.createElement('span');
+    toggleLabel.className = 'tab-link-notification-setting-label';
+    toggleLabel.textContent = 'Notifications for this tab';
+    const toggleControl = document.createElement('div');
+    toggleControl.className = 'tab-link-notification-toggle-control';
+    const toggleStatus = document.createElement('span');
+    toggleStatus.className = 'tab-link-notification-toggle-status';
+    const toggle = document.createElement('button');
+    toggle.type = 'button';
+    toggle.className = 'tab-link-notification-switch';
+    toggle.setAttribute('role', 'switch');
+    toggle.setAttribute('aria-label', 'Notifications for this tab');
+    const toggleThumb = document.createElement('span');
+    toggleThumb.className = 'tab-link-notification-switch-thumb';
+    toggle.setAttribute('aria-describedby', `${container.id || 'tab-link-notification-settings'}-status`);
+    toggleStatus.id = `${container.id || 'tab-link-notification-settings'}-status`;
+    toggle.appendChild(toggleThumb);
+    toggleControl.append(toggleStatus, toggle);
+    toggleRow.append(toggleLabel, toggleControl);
+
+    const soundRow = document.createElement('label');
+    soundRow.className = 'tab-link-notification-setting-row';
+    const soundLabel = document.createElement('span');
+    soundLabel.className = 'tab-link-notification-setting-label';
+    soundLabel.textContent = 'Sound';
+    const soundSelect = document.createElement('select');
+    soundSelect.className = 'tab-link-notification-sound-select';
+    soundSelect.setAttribute('aria-label', 'Notification sound');
+    soundRow.append(soundLabel, soundSelect);
+
+    const syncToggle = (enabled) => {
+      toggle.setAttribute('aria-checked', enabled ? 'true' : 'false');
+      toggle.dataset.enabled = enabled ? 'true' : 'false';
+      toggleStatus.textContent = enabled ? 'On' : 'Off';
+    };
+
+    syncToggle(Boolean(state.notifyEnabled));
+    populateInlineSoundSelect(soundSelect, soundOptionsCache || baseSoundOptions());
+    container.append(toggleRow, soundRow);
+
+    toggle.addEventListener('click', () => {
+      const current = getOrCreateState(context.frameName);
+      if (!current) {
+        return;
+      }
+      const enabled = updateNotificationPreferenceForFrame(context.frameName, !current.notifyEnabled);
+      if (enabled === null) {
+        return;
+      }
+      syncToggle(enabled);
+      if (typeof callbacks.onEnabledChange === 'function') {
+        callbacks.onEnabledChange(enabled);
+      }
+    });
+
+    soundSelect.addEventListener('change', () => {
+      applySoundSelection(soundSelect.value);
+      if (typeof callbacks.onSoundChange === 'function') {
+        callbacks.onSoundChange(globalSoundPreference.choice);
+      }
+    });
+
+    loadSoundOptions().then((options) => {
+      if (!container.isConnected || !container.contains(soundSelect)) {
+        return;
+      }
+      populateInlineSoundSelect(soundSelect, options);
+    }).catch(() => {});
+
+    return true;
+  };
+
   const getNotificationMenuStateForLink = (link) => {
     if (!(link instanceof HTMLElement)) {
       return { available: false, enabled: true, frameName: null };
@@ -1498,5 +1635,8 @@ const ensureTabAccessories = aggregateDebounce(() => {
     openMenuForLink(link, anchor) {
       return openNotificationMenuForLink(link, anchor);
     },
+    mountSettingsForLink(link, container, callbacks) {
+      return mountNotificationSettingsForLink(link, container, callbacks);
+    },
   };
 })();

package/server/public/tab-link-popover.css

@@ -220,6 +220,113 @@ body.dark .tab-link-popover .tab-link-popover-item:hover,
 body.dark .tab-link-popover .tab-link-popover-item:focus-visible {
   background: rgba(148, 163, 184, 0.12);
 }
+.tab-link-popover .tab-link-popover-item[aria-expanded="true"] {
+  background: rgba(15, 23, 42, 0.04);
+}
+body.dark .tab-link-popover .tab-link-popover-item[aria-expanded="true"] {
+  background: rgba(148, 163, 184, 0.08);
+}
+.tab-link-notification-settings {
+  margin: 0 14px 10px 40px;
+  border: 1px solid rgba(15, 23, 42, 0.1);
+  border-radius: 7px;
+  background: rgba(15, 23, 42, 0.025);
+  overflow: hidden;
+}
+body.dark .tab-link-notification-settings {
+  border-color: rgba(148, 163, 184, 0.18);
+  background: rgba(148, 163, 184, 0.045);
+}
+.tab-link-notification-setting-row {
+  min-height: 44px;
+  padding: 7px 10px;
+  display: grid;
+  grid-template-columns: minmax(0, 1fr) auto;
+  align-items: center;
+  gap: 12px;
+  box-sizing: border-box;
+  color: inherit;
+}
+.tab-link-notification-setting-row + .tab-link-notification-setting-row {
+  border-top: 1px solid rgba(15, 23, 42, 0.08);
+}
+body.dark .tab-link-notification-setting-row + .tab-link-notification-setting-row {
+  border-top-color: rgba(148, 163, 184, 0.14);
+}
+.tab-link-notification-setting-label {
+  min-width: 0;
+  font-size: 12px;
+  font-weight: 500;
+  color: rgba(15, 23, 42, 0.76);
+}
+body.dark .tab-link-notification-setting-label {
+  color: rgba(226, 232, 240, 0.86);
+}
+.tab-link-notification-toggle-control {
+  display: inline-flex;
+  align-items: center;
+  gap: 7px;
+}
+.tab-link-notification-toggle-status {
+  min-width: 18px;
+  font-size: 11px;
+  text-align: right;
+  color: rgba(15, 23, 42, 0.56);
+}
+body.dark .tab-link-notification-toggle-status {
+  color: rgba(226, 232, 240, 0.62);
+}
+.tab-link-notification-switch {
+  position: relative;
+  width: 36px;
+  height: 26px;
+  padding: 4px;
+  appearance: none;
+  border: 0;
+  border-radius: 999px;
+  background: rgba(100, 116, 139, 0.42);
+  cursor: pointer;
+  transition: background-color 140ms ease;
+}
+.tab-link-notification-switch[data-enabled="true"] {
+  background: var(--pinokio-focus-color, #2563eb);
+}
+.tab-link-notification-switch-thumb {
+  display: block;
+  width: 18px;
+  height: 18px;
+  border-radius: 50%;
+  background: #f8fafc;
+  box-shadow: 0 1px 2px rgba(15, 23, 42, 0.24);
+  transform: translateX(0);
+  transition: transform 140ms ease;
+}
+.tab-link-notification-switch[data-enabled="true"] .tab-link-notification-switch-thumb {
+  transform: translateX(10px);
+}
+.tab-link-notification-switch:focus-visible,
+.tab-link-notification-sound-select:focus-visible {
+  outline: 2px solid var(--pinokio-focus-color, #2563eb);
+  outline-offset: 2px;
+}
+.tab-link-notification-sound-select {
+  width: min(160px, 44vw);
+  min-height: 32px;
+  padding: 5px 28px 5px 9px;
+  border: 1px solid rgba(15, 23, 42, 0.14);
+  border-radius: 6px;
+  background: var(--pinokio-sidebar-tabbar-bg, #ffffff);
+  color: rgba(15, 23, 42, 0.82);
+  font: inherit;
+  font-size: 12px;
+  cursor: pointer;
+}
+body.dark .tab-link-notification-sound-select {
+  border-color: rgba(148, 163, 184, 0.22);
+  background: rgba(15, 23, 42, 0.42);
+  color: rgba(241, 245, 249, 0.9);
+  color-scheme: dark;
+}
 .tab-link-popover .tab-link-popover-item .label {
   font-size: 11px;
   font-weight: 600;
@@ -344,6 +451,27 @@ body.dark .tab-link-popover .tab-link-popover-footer:focus-visible {
     padding-right: 16px;
     padding-left: 16px;
   }
+  .tab-link-notification-settings {
+    margin-right: 16px;
+    margin-left: 42px;
+  }
+  .tab-link-notification-setting-row {
+    padding-right: 8px;
+    padding-left: 8px;
+  }
+}
+@media (pointer: coarse) {
+  .tab-link-notification-switch {
+    width: 44px;
+    height: 30px;
+    padding: 4px;
+  }
+  .tab-link-notification-switch[data-enabled="true"] .tab-link-notification-switch-thumb {
+    transform: translateX(14px);
+  }
+  .tab-link-notification-sound-select {
+    min-height: 44px;
+  }
 }
 .appcanvas > aside .menu-container .tab-link-popover-host {
   display: flex;

package/server/public/tab-link-popover.js

@@ -266,10 +266,39 @@
         if (action === "notifications") {
           const activeLink = tabLinkActiveLink
           const notifier = typeof window !== "undefined" ? window.PinokioIdleNotifier : null
-          const anchor = activeLink ? (activeLink.querySelector(`.${TAB_LINK_TRIGGER_CLASS}`) || activeLink) : null
-          hideTabLinkPopover({ immediate: true })
-          if (notifier && typeof notifier.openMenuForLink === "function") {
-            notifier.openMenuForLink(activeLink, anchor)
+          const existingPanel = item.nextElementSibling
+          if (existingPanel && existingPanel.classList.contains("tab-link-notification-settings")) {
+            existingPanel.remove()
+            item.setAttribute("aria-expanded", "false")
+            item.removeAttribute("aria-controls")
+            return
+          }
+          if (notifier && typeof notifier.mountSettingsForLink === "function") {
+            const panel = document.createElement("div")
+            panel.className = "tab-link-notification-settings"
+            panel.id = `${TAB_LINK_POPOVER_ID}-notification-settings`
+            panel.setAttribute("role", "group")
+            panel.setAttribute("aria-label", "Desktop notification settings")
+            item.insertAdjacentElement("afterend", panel)
+            const value = item.querySelector(".value")
+            const icon = item.querySelector(".tab-link-popover-action-icon i")
+            const mounted = notifier.mountSettingsForLink(activeLink, panel, {
+              onEnabledChange(enabled) {
+                if (value) {
+                  value.textContent = enabled ? "Enabled for this tab" : "Disabled for this tab"
+                }
+                if (icon) {
+                  icon.classList.toggle("fa-bell", enabled)
+                  icon.classList.toggle("fa-bell-slash", !enabled)
+                }
+              }
+            })
+            if (mounted) {
+              item.setAttribute("aria-controls", panel.id)
+              item.setAttribute("aria-expanded", "true")
+            } else {
+              panel.remove()
+            }
           }
           return
         }
@@ -1898,6 +1927,9 @@
       if (actionItem.action) {
         item.setAttribute("data-action", actionItem.action)
       }
+      if (actionItem.action === "notifications") {
+        item.setAttribute("aria-expanded", "false")
+      }
       if (actionItem.url) {
         item.setAttribute("data-url", actionItem.url)
       }