pinokiod 8.0.106 → 8.0.108

package/kernel/vault/index.js

@@ -3407,7 +3407,6 @@ class Vault {
         status: PUBLIC_FILE_STATUS[row.status] || null
       }, this.locationForPath(row.path, row.source_id))),
       total: Number(result.total) || 0,
-      deduplicatable: Number(result.duplicateTotal) || 0,
       next_cursor: result.nextCursor || null
     }
   }

package/kernel/vault/registry_core.js

@@ -5691,18 +5691,9 @@ class RegistryCore {
       WHERE ${identityWhere}
         AND ${authorized.where.join(" AND ")}
     `).get(...identityValues, ...authorized.values).count) || 0
-    // Only paths still storing their own copy can free anything.
-    const duplicateTotal = Number(this.database.prepare(`
-      SELECT COUNT(*) AS count
-      FROM files child
-      WHERE ${identityWhere}
-        AND child.status = 'duplicate'
-        AND ${authorized.where.join(" AND ")}
-    `).get(...identityValues, ...authorized.values).count) || 0
     return {
       rows,
       total,
-      duplicateTotal,
       nextCursor: hasMore && last
         ? this.encodeCursor({
             sort: "file-locations",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pinokiod",
-  "version": "8.0.106",
+  "version": "8.0.108",
   "description": "",
   "main": "index.js",
   "scripts": {

package/server/index.js

@@ -1833,6 +1833,13 @@ class Server {
     const dev_initial_tab = type === "browse" && req.query && req.query.pinokio_dev_tab === "files"
       ? "files"
       : "plugins"
+    // Disk Saver hands one content group to another app: the page opens with
+    // its Disk Saver tab selected and that group already expanded.
+    const vault_initial_group = req.query &&
+      typeof req.query.vault_group === "string" &&
+      /^[a-f0-9]{64}$/i.test(req.query.vault_group)
+      ? req.query.vault_group.toLowerCase()
+      : null
 
     const registryEnabled = await this.isRegistryEnabled().catch(() => false)
     let community_url = ""
@@ -1956,6 +1963,7 @@ class Server {
       tabs: savedTabs,
       editor_tab: editor_tab,
       dev_initial_tab,
+      vault_initial_group,
       config,
       protection_enabled: protectionPreference ? protectionPreference.protection_enabled !== false : false,
       autolaunch_app: autolaunchAppState,

package/server/public/vault.js

@@ -238,7 +238,7 @@ const COPY = {
   show_more_copies: "Show {count} more copies",
   loading_locations: "Loading locations…",
   open_in_disk_saver: "Open this file in Disk Saver",
-  open_location_confirm: "Open Disk Saver for {location}?",
+  open_location_confirm: "Open Disk Saver to review {location}?",
   open_location_accept: "Open",
   show_more_locations: "Show {count} more locations",
   making_separate: "Making file separate",
@@ -658,26 +658,22 @@ const confirmLeave = (message, confirmLabel) => new Promise((resolve) => {
 const openGlobalWorkspace = () => {
   window.parent.location.assign("/vault")
 }
-// Opens a new tab rather than navigating: this workspace can be embedded in an
-// app page, where navigating would either nest a second copy of the interface
-// or drop the user out of the app they were looking at.
-// A copy that belongs to another app opens that app's own workspace, where it
-// can actually be acted on. Anything else — caches, external folders — has no
-// app page, so it opens the global one. Either way the user is leaving this
-// page, so it is confirmed first and the parent window is replaced rather than
-// nesting a second copy of the interface inside this frame.
+// A copy in another app opens that app's page with its Disk Saver tab selected
+// and the group expanded, because an app's workspace only exists inside that
+// page; opening the workspace URL directly strands the user with no navigation.
+// Locations that are not apps have no such page and open the global workspace.
+// The label and kind travel with the row: an app workspace cannot look up
+// sources belonging to other apps.
 const openContentGroup = async (group, kind, label) => {
-  // The label and kind travel with the row: an app workspace cannot look up
-  // sources belonging to other apps, so a lookup here would name every one of
-  // them "unknown" and send them all to the global page.
-  const app = kind === "app" && label ? label : null
-  const name = label || COPY.unknown_location
   const accepted = await confirmLeave(
-    COPY.open_location_confirm.replace("{location}", name),
+    COPY.open_location_confirm.replace(
+      "{location}", label || COPY.unknown_location),
     COPY.open_location_accept)
   if (!accepted) return
-  const base = app ? `/vault/app/${encodeURIComponent(app)}` : "/vault"
-  window.parent.location.assign(`${base}?group=${encodeURIComponent(group)}`)
+  const target = kind === "app" && label
+    ? `/pinokio/browser/${encodeURIComponent(label)}?vault_group=${encodeURIComponent(group)}`
+    : `/vault?group=${encodeURIComponent(group)}`
+  window.parent.location.assign(target)
 }
 const applyAutomaticScanSnapshot = (snapshot) => {
   if (!IS_APP_MODE || !AUTOMATIC_SUPPORTED) return
@@ -2968,9 +2964,6 @@ const loadPagedChildren = async (cache, key, buildUrl, append) => {
     const items = Array.isArray(result.items) ? result.items : []
     current.items = append ? current.items.concat(items) : items
     current.total = Math.max(0, Number(result.total) || 0)
-    // Location lists carry how many copies still cost space; group children
-    // do not, and read as zero.
-    current.deduplicatable = Math.max(0, Number(result.deduplicatable) || 0)
     current.nextCursor = result.next_cursor || null
     current.loaded = true
   } catch (error) {

package/server/views/app.ejs

@@ -8694,7 +8694,7 @@ body.dark .pinokio-custom-terminal-header {
         <% const vaultAutomaticSupported = typeof vault_automatic_supported === 'undefined' || vault_automatic_supported === true %>
         <% const vaultAutomaticResultSignature = vaultAutomaticSupported && typeof vault_automatic_result_signature === 'string' ? vault_automatic_result_signature : '' %>
         <% const vaultSidebarLabel = !vaultGlobalScanReady ? 'Disk Saver — Set up required' : vaultAutomaticSupported ? `Disk Saver — ${vaultAutomaticMode === 'automatic' ? 'Automatic' : 'Manual'} checking${vaultAutomaticResultSignature ? ' — Duplicate files found' : ''}` : 'Disk Saver' %>
-        <a id='save-space-tab' data-mode="refresh" target="app-vault" href="/vault/app/<%=encodeURIComponent(name)%>" class="btn header-item frame-link<%=vaultAutomaticResultSignature ? ' app-vault-result-attention' : ''%>" data-index="vault" data-static="retain" data-tab-link-popover="false" aria-label="<%=vaultSidebarLabel%>">
+        <a id='save-space-tab' data-mode="refresh" target="app-vault" href="/vault/app/<%=encodeURIComponent(name)%><%=typeof vault_initial_group === 'string' && vault_initial_group ? `?group=${vault_initial_group}` : ''%>" class="btn header-item frame-link<%=vaultAutomaticResultSignature ? ' app-vault-result-attention' : ''%>" data-index="vault" data-static="retain" data-tab-link-popover="false" aria-label="<%=vaultSidebarLabel%>">
           <div class='tab'>
             <i class="fa-solid fa-hard-drive menu-action-leading-icon"></i>
             <div class='display'>Disk Saver</div>
@@ -9183,6 +9183,14 @@ body.dark .pinokio-custom-terminal-header {
     window.history.replaceState(window.history.state, "", `${devTabUrl.pathname}${devTabUrl.search}${devTabUrl.hash}`)
   } catch (_) {}
   <% } %>
+  <% if (typeof vault_initial_group === 'string' && vault_initial_group) { %>
+  global_selector = "#save-space-tab.frame-link"
+  try {
+    const vaultTabUrl = new URL(window.location.href)
+    vaultTabUrl.searchParams.delete("vault_group")
+    window.history.replaceState(window.history.state, "", `${vaultTabUrl.pathname}${vaultTabUrl.search}${vaultTabUrl.hash}`)
+  } catch (_) {}
+  <% } %>
   let pendingSelectionRetry = null
   let pendingHomeSelectionRetry = null
   let initialWorkspaceDiskUsageRequested = false

package/test/vault-ui.test.js

@@ -825,7 +825,6 @@ describe("Save Space interface", () => {
             relative_path: `models/${name}.bin`
           })),
           total: 3,
-          deduplicatable: 1,
           next_cursor: null
         }
       }