pinokiod 7.0.1 → 7.0.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pinokiod",
-  "version": "7.0.1",
+  "version": "7.0.3",
   "description": "",
   "main": "index.js",
   "scripts": {

package/prototype/system/SKILL_PINOKIO.md

@@ -113,7 +113,7 @@ Follow these sections in order:
   - `running`: script is running
   - `ready`: app is reachable/ready
   - `ready_url`: default base URL for API calls when available
-  - `external_ready_url`: optional non-loopback app URL, usually a LAN-accessible or otherwise externally reachable address exposed by Pinokio; use it only when `ready_url` fails due to loopback restrictions
+  - `external_ready_urls`: optional ordered non-loopback app URLs for caller-side access; use them only when `ready_url` fails due to loopback restrictions
   - `state`: `offline | starting | online`
   - `source`: machine identity for federated results
 - Use `--probe` only for readiness confirmation before first API call (or when status is uncertain).
@@ -121,7 +121,7 @@ Follow these sections in order:
 - Treat `offline` as expected before first run.
 - If `app_id` contains `@<host>` or `source.local=false`, the app is remote:
   - treat `path` and `ready_url` as source-local fields, not caller-usable local paths/URLs
-  - use `external_ready_url` for caller-side API access when available
+  - use `external_ready_urls` in order for caller-side API access when available
   - do not assume `pterm run <path>` can launch a remote app from the current machine
 - If app is offline or not ready, run it:
   - Run `pterm run <app_path>`.
@@ -132,8 +132,8 @@ Follow these sections in order:
 - Success criteria:
   - `state=online` and `ready=true`
   - use `ready_url` by default
-  - if `ready_url` fails because the client cannot access loopback and `external_ready_url` exists, use `external_ready_url`
-  - missing `external_ready_url` is normal; it usually means network sharing is off
+  - if `ready_url` fails because the client cannot access loopback and `external_ready_urls` exists, try those URLs in order
+  - missing `external_ready_urls` is normal; it usually means network sharing is off
 - Failure criteria:
   - timeout before success
   - app drops back to `offline` during startup after a run attempt
@@ -174,7 +174,7 @@ Follow these sections in order:
 - Prefer returning full logs over brittle deterministic error parsing.
 - REST endpoints may be used for diagnostics only when pterm is unavailable; do not claim full install/launch lifecycle completion without compatible pterm commands.
 - Do not keep searching after app selection; move to status/run.
-- Do not assume `external_ready_url` exists; localhost-only apps are normal.
+- Do not assume `external_ready_urls` exists; localhost-only apps are normal.
 - Do not conflate loopback access failure, sandbox denial, or missing permission with "Pinokio is not running" or "`pterm` is not installed."
 - On `pterm` permission failure, prefer asking for permission over asking the user to manually run commands.
 - If `pterm` exists locally but cannot reach the control plane, explicitly tell the user this looks like a client permission/sandbox issue.

package/server/lib/app_registry.js

@@ -70,7 +70,9 @@ class AppRegistryService {
         seen.add(signature)
         entries.push({
           host: String(externalHost.host).trim(),
-          port: Number.parseInt(String(externalHost.port), 10)
+          port: Number.parseInt(String(externalHost.port), 10),
+          scope: externalHost.scope || null,
+          interface: externalHost.interface || null
         })
       }
       if (item.external_ip && typeof item.external_ip === 'string') {
@@ -81,7 +83,9 @@ class AppRegistryService {
             seen.add(signature)
             entries.push({
               host: parsed.hostname,
-              port: Number.parseInt(parsed.port, 10)
+              port: Number.parseInt(parsed.port, 10),
+              scope: null,
+              interface: null
             })
           }
         } catch (_) {}
@@ -90,68 +94,88 @@ class AppRegistryService {
     return entries
   }
 
-  buildExternalReadyUrl(url, source = null) {
+  sortExternalHostEntries(entries = [], source = null) {
+    const sourceInfo = this.normalizeSource(source)
+    const scopedEntries = Array.isArray(entries) ? entries.slice() : []
+    const scopeRank = (scope = '') => {
+      switch (String(scope || '').toLowerCase()) {
+        case 'lan':
+          return 0
+        case 'cgnat':
+          return 1
+        default:
+          return 2
+      }
+    }
+    return scopedEntries.sort((a, b) => {
+      const aHost = String(a && a.host ? a.host : '').toLowerCase()
+      const bHost = String(b && b.host ? b.host : '').toLowerCase()
+      const aMatchesCaller = sourceInfo.hostname && aHost === sourceInfo.hostname ? 1 : 0
+      const bMatchesCaller = sourceInfo.hostname && bHost === sourceInfo.hostname ? 1 : 0
+      if (aMatchesCaller !== bMatchesCaller) {
+        return bMatchesCaller - aMatchesCaller
+      }
+      const aScope = scopeRank(a && a.scope)
+      const bScope = scopeRank(b && b.scope)
+      if (aScope !== bScope) {
+        return aScope - bScope
+      }
+      return `${aHost}:${a && a.port ? a.port : ''}`.localeCompare(`${bHost}:${b && b.port ? b.port : ''}`)
+    })
+  }
+
+  buildExternalReadyUrls(url, source = null) {
     if (!url || typeof url !== 'string') {
-      return null
+      return []
     }
     const originalUrl = String(url)
     let parsed
     try {
       parsed = new URL(originalUrl)
     } catch (_) {
-      return null
+      return []
     }
     const originalProtocol = parsed.protocol === 'https:' ? 'https:' : 'http:'
     const hostname = (parsed.hostname || '').trim().toLowerCase()
-    if (!hostname) {
-      return null
-    }
-    if (!this.isLoopbackHostname(hostname)) {
-      let result = parsed.toString()
-      if (/^https?:\/\/[^/?#]+$/i.test(originalUrl) && parsed.pathname === '/' && !parsed.search && !parsed.hash) {
-        result = result.replace(/\/$/, '')
-      }
-      return result
+    if (!hostname || !this.isLoopbackHostname(hostname)) {
+      return []
     }
 
-    const sourceInfo = this.normalizeSource(source)
-    const externalEntries = this.findExternalHostEntries(parsed.port)
-    let nextHost = ''
-    let nextPort = Number.parseInt(parsed.port, 10)
-
-    if (externalEntries.length > 0) {
-      const matchingEntry = sourceInfo.hostname
-        ? externalEntries.find((entry) => entry.host === sourceInfo.hostname)
-        : null
-      const selectedEntry = matchingEntry || externalEntries[0]
-      nextHost = selectedEntry.host
-      nextPort = selectedEntry.port
-    } else {
-      const mappedPort = this.kernel && this.kernel.router && this.kernel.router.port_mapping
-        ? this.kernel.router.port_mapping[String(parsed.port)]
-        : null
-      if (sourceInfo.hostname && !this.isLoopbackHostname(sourceInfo.hostname)) {
-        nextHost = sourceInfo.hostname
-      } else if (this.kernel && this.kernel.peer && this.kernel.peer.host) {
-        nextHost = String(this.kernel.peer.host).trim()
+    const externalEntries = this.sortExternalHostEntries(this.findExternalHostEntries(parsed.port), source)
+    const results = []
+    const seen = new Set()
+    for (const entry of externalEntries) {
+      if (!entry || !entry.host || !entry.port) {
+        continue
       }
-      if (mappedPort) {
-        nextPort = Number.parseInt(String(mappedPort), 10)
+      const next = new URL(parsed.toString())
+      next.protocol = originalProtocol
+      next.hostname = entry.host
+      next.port = String(entry.port)
+      let nextUrl = next.toString()
+      if (/^https?:\/\/[^/?#]+$/i.test(originalUrl) && next.pathname === '/' && !next.search && !next.hash) {
+        nextUrl = nextUrl.replace(/\/$/, '')
       }
+      if (seen.has(nextUrl)) {
+        continue
+      }
+      seen.add(nextUrl)
+      const item = {
+        url: nextUrl,
+        transport: 'ip',
+        scope: entry.scope || 'unknown'
+      }
+      if (entry.interface) {
+        item.interface = entry.interface
+      }
+      results.push(item)
     }
+    return results
+  }
 
-    if (!nextHost || !Number.isFinite(nextPort) || nextPort <= 0) {
-      return null
-    }
-
-    parsed.protocol = originalProtocol
-    parsed.hostname = nextHost
-    parsed.port = String(nextPort)
-    let result = parsed.toString()
-    if (/^https?:\/\/[^/?#]+$/i.test(originalUrl) && parsed.pathname === '/' && !parsed.search && !parsed.hash) {
-      result = result.replace(/\/$/, '')
-    }
-    return result
+  buildExternalReadyUrl(url, source = null) {
+    const externalReadyUrls = this.buildExternalReadyUrls(url, source)
+    return externalReadyUrls.length > 0 ? externalReadyUrls[0].url : null
   }
 
   isPathWithin(parentPath, childPath) {
@@ -241,7 +265,7 @@ class AppRegistryService {
       ready: false,
       state: 'offline',
       ready_url: null,
-      external_ready_url: null,
+      external_ready_urls: [],
       ready_script: null,
       running_scripts: [],
       local_entries: []
@@ -419,7 +443,7 @@ class AppRegistryService {
     }
 
     const runtime = this.collectAppRuntime(appRoot)
-    runtime.external_ready_url = this.buildExternalReadyUrl(runtime.ready_url, options.source || null)
+    runtime.external_ready_urls = this.buildExternalReadyUrls(runtime.ready_url, options.source || null)
     const installScript = await this.firstExistingScript(appRoot, ['install.js', 'install.json'])
     const startScript = await this.firstExistingScript(appRoot, ['start.js', 'start.json'])
     let defaultTarget = null
@@ -457,7 +481,7 @@ class AppRegistryService {
       running: runtime.running,
       ready,
       ready_url: runtime.ready_url,
-      external_ready_url: runtime.external_ready_url,
+      external_ready_urls: runtime.external_ready_urls,
       state,
       running_scripts: runtime.running_scripts,
       ready_script: runtime.ready_script,

package/server/lib/app_search.js

@@ -515,14 +515,14 @@ class AppSearchService {
   decorateAppWithRuntime(app, extras = {}, source = null) {
     const appRoot = this.kernel.path('api', app.name)
     const runtime = this.registry.collectAppRuntime(appRoot)
-    const externalReadyUrl = this.registry.buildExternalReadyUrl(runtime.ready_url, source)
+    const externalReadyUrls = this.registry.buildExternalReadyUrls(runtime.ready_url, source)
     return {
       app_id: app.name,
       ...app,
       running: runtime.running,
       ready: runtime.ready,
       ready_url: runtime.ready_url,
-      external_ready_url: externalReadyUrl,
+      external_ready_urls: externalReadyUrls,
       state: runtime.state,
       ...extras
     }

package/server/routes/apps.js

@@ -112,8 +112,43 @@ module.exports = function registerAppRoutes(app, { registry, preferences, appSea
     }
     return `${normalizedAppId}@${host}`
   }
-  const decorateSearchResult = (appResult, source) => {
+  const neutralizeRemoteSearchPreferences = (appResult) => {
     const next = appResult && typeof appResult === 'object' ? { ...appResult } : {}
+    next.starred = false
+    next.starred_at = null
+    next.last_launch_at = null
+    next.last_launch_source = 'unknown'
+    next.launch_count_total = 0
+    next.launch_count_pterm = 0
+    next.launch_count_ui = 0
+    next.preference_boost = 0
+    if (typeof next.score === 'number') {
+      next.adjusted_score = next.score
+    } else {
+      next.adjusted_score = null
+    }
+    return next
+  }
+  const runtimeRank = (appResult) => {
+    if (appResult && appResult.ready) {
+      return 2
+    }
+    if (appResult && appResult.running) {
+      return 1
+    }
+    return 0
+  }
+  const parseTimestamp = (value) => {
+    if (typeof value !== 'string' || !value.trim()) {
+      return 0
+    }
+    const parsed = Date.parse(value)
+    return Number.isFinite(parsed) ? parsed : 0
+  }
+  const decorateSearchResult = (appResult, source) => {
+    const next = source && !source.local
+      ? neutralizeRemoteSearchPreferences(appResult)
+      : (appResult && typeof appResult === 'object' ? { ...appResult } : {})
     next.app_id = qualifyAppId(next.app_id || next.name || '', source.host)
     next.source = source
     if (!source.local) {
@@ -171,11 +206,31 @@ module.exports = function registerAppRoutes(app, { registry, preferences, appSea
     }
     push(localApps)
     push(remoteApps)
-    const normalizedQuery = typeof query === 'string' ? query.trim() : ''
-    if (!normalizedQuery) {
-      return merged
-    }
     return merged.sort((a, b) => {
+      const aRuntimeRank = runtimeRank(a)
+      const bRuntimeRank = runtimeRank(b)
+      if (aRuntimeRank !== bRuntimeRank) {
+        return bRuntimeRank - aRuntimeRank
+      }
+      const normalizedQuery = typeof query === 'string' ? query.trim() : ''
+      if (!normalizedQuery) {
+        const aStarred = a && a.starred ? 1 : 0
+        const bStarred = b && b.starred ? 1 : 0
+        if (aStarred !== bStarred) {
+          return bStarred - aStarred
+        }
+        const aLaunchCount = Math.max(0, Number.parseInt(String(a && a.launch_count_total || 0), 10) || 0)
+        const bLaunchCount = Math.max(0, Number.parseInt(String(b && b.launch_count_total || 0), 10) || 0)
+        if (aLaunchCount !== bLaunchCount) {
+          return bLaunchCount - aLaunchCount
+        }
+        const aLastLaunch = parseTimestamp(a && a.last_launch_at)
+        const bLastLaunch = parseTimestamp(b && b.last_launch_at)
+        if (aLastLaunch !== bLastLaunch) {
+          return bLastLaunch - aLastLaunch
+        }
+        return String(a.app_id || '').localeCompare(String(b.app_id || ''))
+      }
       const aAdjusted = typeof a.adjusted_score === 'number' ? a.adjusted_score : -Infinity
       const bAdjusted = typeof b.adjusted_score === 'number' ? b.adjusted_score : -Infinity
       if (aAdjusted !== bAdjusted) {
@@ -259,6 +314,11 @@ module.exports = function registerAppRoutes(app, { registry, preferences, appSea
       res.status(400).json({ error: 'Invalid app_id' })
       return
     }
+    const parsedAppId = parseQualifiedAppId(appId)
+    if (parsedAppId.qualified && parsedAppId.host !== currentPeerHost()) {
+      res.status(400).json({ error: 'Remote app preferences are not supported' })
+      return
+    }
     const body = req.body && typeof req.body === 'object' ? req.body : {}
     const hasStarred = Object.prototype.hasOwnProperty.call(body, 'starred')
     if (!hasStarred) {