pinokiod 3.2.184 → 3.2.186

package/kernel/bin/conda.js

@@ -299,15 +299,6 @@ create_default_packages:
         this.kernel.bin.path("miniconda", "python3.exe"),
       )
 
-      // give full permission
-      console.log("Give full permission")
-      await this.kernel.bin.exec({
-        sudo: true,
-        message: `icacls ${install_path} /grant Users:(OI)(CI)F /T`
-      }, (stream) => {
-        ondata(stream)
-      })
-      console.log("Give full permission done")
 
     }
     ondata({ raw: `Install finished\r\n` })

package/kernel/bin/index.js

@@ -397,7 +397,7 @@ class Bin {
       // check brew_installed
       console.log("checking brew installed")
       let e = await this.kernel.bin.exists("homebrew")
-      let { stdout }= await this.kernel.bin.exec({ message: "xcode-select -p" }, (stream) => { })
+      let { stdout }= await this.exec({ message: "xcode-select -p" }, (stream) => { })
       let e2 = /(.*Library.*Developer.*CommandLineTools.*|.*Xcode.*Developer.*)/gi.test(stdout)
       let e3 = await this.kernel.exists("/Library/Developer/CommandLineTools")
 
@@ -408,7 +408,7 @@ class Bin {
       // - no
 
       let e4;
-      let result = await this.kernel.bin.exec({ message: "xcode-select --version" }, (stream) => { })
+      let result = await this.exec({ message: "xcode-select --version" }, (stream) => { })
       if (result && result.stdout) {
         e4 = /xcode-select version ([0-9]+)/gi.exec(result.stdout)
         if (e4 && e4.length > 1) {

package/kernel/index.js

@@ -310,7 +310,24 @@ class Kernel {
       if (this.homedir) {
 
         // 0. create homedir
-        await fs.promises.mkdir(this.homedir, { recursive: true }).catch((e) => {})
+        let home_exists = await this.exists(this.homedir)
+        if (!home_exists) {
+          await fs.promises.mkdir(this.homedir, { recursive: true }).catch((e) => {})
+
+          // If the homedir was newly created, give full permission to pinokio folder on windows
+          if (this.kernel.platform === "win32") {
+            console.log("2 Give full permission")
+            await this.bin.exec({
+              sudo: true,
+              message: `icacls ${this.homedir} /grant Users:(OI)(CI)F /T`
+            }, (stream) => {
+              ondata(stream)
+            })
+            console.log("2 Give full permission done")
+          }
+        }
+
+
 
         // 1. check if ENVIRONMENT exists
         // if it doesn't exist, write to ~/pinokio/ENVIRONMENT

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pinokiod",
-  "version": "3.2.184",
+  "version": "3.2.186",
   "description": "",
   "main": "index.js",
   "scripts": {

package/server/index.js

@@ -2141,6 +2141,20 @@ class Server {
       } else {
       // update the py module if it's already installed
         console.log("not up to date")
+
+        // give full permission to pinokio folder on windows
+        if (this.kernel.platform === "win32") {
+          console.log("1 Give full permission")
+          await this.kernel.bin.exec({
+            sudo: true,
+            message: `icacls ${this.kernel.homedir} /grant Users:(OI)(CI)F /T`
+          }, (stream) => {
+            ondata(stream)
+          })
+          console.log("1 Give full permission done")
+        }
+
+
         await new Promise((resolve, reject) => {
           let interval = setInterval(async () => {
             console.log("checking mod.py")