pinelabs-mcp 1.0.5 → 1.0.6

package/README.md

@@ -119,7 +119,7 @@ See the [complete tools reference](https://developer.pinelabsonline.com/docs/mcp
 |-------|-----|
 | Missing credentials | Run `npx pinelabs-mcp configure` or set `PINELABS_CLIENT_ID` / `PINELABS_CLIENT_SECRET` in your MCP client's `env` block |
 | Tools not appearing | Restart your AI assistant; verify Node.js 18+ (`node --version`); set `"DEBUG": "true"` in `env` |
-| Connection issues | Verify credentials; check network access to `mcp.pluralpay.in`; allow HTTPS if behind a proxy |
+| Connection issues | Verify credentials; check network access to `mcp.pinelabs.com`; allow HTTPS if behind a proxy |
 
 ## License
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pinelabs-mcp",
-  "version": "1.0.5",
+  "version": "1.0.6",
   "description": "MCP client for Pine Labs payment gateway — connect Claude Desktop, Cursor, and VS Code to Pine Labs payment APIs using your client credentials.",
   "main": "src/config.js",
   "bin": {

package/src/commands/proxy.js

@@ -31,24 +31,51 @@ function startProxy() {
 
   const mcpRemoteBin = require.resolve("mcp-remote/dist/proxy.js");
 
-  const args = [
-    mcpRemoteBin,
+  // SECURITY: Do NOT place client secret in spawn argv — process arguments are
+  // visible to other local users/processes via `ps`, /proc, monitoring agents,
+  // and crash dumps. Instead we:
+  //   1. Pass the secret to the child via a dedicated env var.
+  //   2. Use `node -e <bootstrap>` so the OS-visible command line never
+  //      contains the secret.
+  //   3. The bootstrap reads the secret from env, deletes it from
+  //      `process.env`, rebuilds `process.argv`, then loads mcp-remote
+  //      in-process via `require()` (no further child spawn).
+  const proxyArgs = [
     endpoint,
     "--header",
     `X-Client-Id:${clientId}`,
-    "--header",
-    `X-Client-Secret:${clientSecret}`,
     "--transport",
     "http-first",
   ];
 
   if (debug) {
-    args.push("--debug");
+    proxyArgs.push("--debug");
   }
 
-  const child = spawn(process.execPath, args, {
+  const SECRET_ENV_VAR = "PINELABS_MCP_CLIENT_SECRET_INTERNAL";
+  const bootstrap = `
+    const secret = process.env[${JSON.stringify(SECRET_ENV_VAR)}];
+    if (!secret) {
+      process.stderr.write("[pinelabs-mcp] Missing client secret in child process environment\\n");
+      process.exit(1);
+    }
+    delete process.env[${JSON.stringify(SECRET_ENV_VAR)}];
+    process.argv = [
+      process.execPath,
+      ${JSON.stringify(mcpRemoteBin)},
+      ...${JSON.stringify(proxyArgs)},
+      "--header",
+      "X-Client-Secret:" + secret,
+    ];
+    require(${JSON.stringify(mcpRemoteBin)});
+  `;
+
+  const child = spawn(process.execPath, ["-e", bootstrap], {
     stdio: ["pipe", "pipe", "pipe"],
-    env: { ...process.env },
+    env: {
+      ...process.env,
+      [SECRET_ENV_VAR]: clientSecret,
+    },
   });
 
   process.stdin.pipe(child.stdin);

package/src/config.js

@@ -9,10 +9,51 @@
  */
 
 const ENDPOINTS = {
-  prod: "https://mcp.pluralpay.in/mcp",
+  prod: "https://mcp.pinelabs.com/mcp",
   uat: "https://pluralai.v2.pinepg.in/mcp",
 };
 
+const LOCALHOST_HOSTNAMES = new Set([
+  "localhost",
+  "127.0.0.1",
+  "::1",
+  "0.0.0.0",
+]);
+
+/**
+ * Validate that an endpoint URL is safe to send credentials to.
+ *
+ * Enforces HTTPS for any non-localhost host so that the X-Client-Id /
+ * X-Client-Secret headers are never transmitted in cleartext.
+ *
+ * @param {string} rawUrl - The endpoint URL to validate.
+ * @throws {Error} If the URL is malformed or uses http:// for a non-local host.
+ */
+function validateEndpointUrl(rawUrl) {
+  let parsed;
+  try {
+    parsed = new URL(rawUrl);
+  } catch {
+    throw new Error(
+      `Invalid PINELABS_MCP_ENDPOINT: "${rawUrl}" is not a valid URL.`,
+    );
+  }
+
+  if (parsed.protocol === "https:") {
+    return;
+  }
+
+  if (parsed.protocol === "http:" && LOCALHOST_HOSTNAMES.has(parsed.hostname)) {
+    return;
+  }
+
+  throw new Error(
+    `Insecure PINELABS_MCP_ENDPOINT: "${rawUrl}". ` +
+      "Endpoint must use https:// (http:// is only allowed for localhost). " +
+      "Sending credentials over plain HTTP would expose your client secret.",
+  );
+}
+
 /**
  * Parse and validate configuration from environment variables.
  *
@@ -84,7 +125,9 @@ function loadConfig() {
     endpoint = ENDPOINTS.uat;
   }
 
+  validateEndpointUrl(endpoint);
+
   return { clientId, clientSecret, endpoint, debug };
 }
 
-module.exports = { loadConfig, ENDPOINTS };
+module.exports = { loadConfig, ENDPOINTS, validateEndpointUrl };