pindeck 3.2.0 → 3.3.0

package/README.md

@@ -1,6 +1,6 @@
 # PinDeck
 
-> **macOS and Linux · Version 3** (`3.2.0`). On Linux, PinDeck runs as a headless server that you use
+> **macOS and Linux · Version 3** (`3.3.0`). On Linux, PinDeck runs as a headless server that you use
 > from your Mac's browser through an SSH tunnel (see [Running on a Linux server](#running-on-a-linux-server)).
 > Windows is not supported. Coming from PinDeck 2: version 3 keeps its settings and chats in
 > `~/.pindeck-v3`, apart from 2.x (see [Models, providers and configuration](#models-providers-and-configuration)).
@@ -492,8 +492,8 @@ Without PowerPoint or Keynote (or on other systems than macOS) only the text and
   from `lib/system-prompt.md` and the deck's `CLAUDE.md` and `AGENTS.md`. Codex model and effort changes
   reuse the active thread writer and apply to the next turn. Claude changes and provider switches prepare
   a replacement process before retiring the old one. Events from replaced sessions are ignored.
-* **Permissions.** The assistant may read files, edit and create files in the deck folder, and run the
-  editor's CLI. Nothing else: no other commands, and no edits to `brand.css`, `vendor/`, `.git/` or, for a
+* **Permissions.** The assistant may read the deck folder, its screenshots, attached PDFs and asset roots,
+  edit and create files in the deck folder, and run the editor's CLI. Nothing else: no other commands, and no edits to `brand.css`, `vendor/`, `.git/` or, for a
   named deck file, the other decks in its folder. Claude Code loads no settings files and no MCP servers,
   so no allow rule in your own, the deck's or a parent folder's settings widens this. Codex has no shell
   and no file access of its own: it reads and edits through PinDeck's own tools, which apply the same
@@ -553,12 +553,18 @@ Without PowerPoint or Keynote (or on other systems than macOS) only the text and
 * One writer at a time: PinDeck is not made for editing the same deck from two editors or tools at once.
 * A deck's own scripts run sandboxed in the editor and in Present: they cannot use `localStorage`, cookies
   or the editor page. A deck that needs them for its slides to work should catch the error.
-* Decks are `.html` files; `.htm` files are not listed or opened as decks.
 * Linux: pictures of PDF pages and PowerPoint slides, and waveforms of non-WAV audio, need
   Poppler, LibreOffice and ffmpeg on the server (see [Running on a Linux server](#running-on-a-linux-server)).
 
 ## Versions
 
+* **3.3.0**: fixes from a code audit.
+  - After a PowerPoint import, refining the slides no longer deletes pictures that the deck still uses
+    (when the turn was stopped, failed or only changed `theme.css`); Undo brings removed pictures back.
+  - Long texts with non-ASCII characters (large notes, tables, SVG) no longer get broken characters.
+  - Claude reads only the deck, its screenshots, attached PDFs and asset roots, as Codex already did, and
+    cannot create a `.git` file in the deck folder.
+
 * **3.2.0**: PinDeck 3, the first stable release of version 3: everything from the 3.0, 3.1 and 3.2 betas
   below. Compared with 2.11:
   - OpenAI Codex as a second assistant next to Claude Code, with the models and efforts each backend

package/front.mjs

@@ -243,6 +243,7 @@ function follow(st, tab, key) {
 }
 async function readJson(req) {
   let s = "";
+  req.setEncoding("utf8");
   for await (const c of req) { s += c; if (s.length > 10000) throw new Error("body too large"); }
   return s ? JSON.parse(s) : {};
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pindeck",
-  "version": "3.2.0",
+  "version": "3.3.0",
   "description": "PinDeck: an editor for HTML slide decks on macOS, and on Linux through an SSH tunnel. Pin elements, describe the change, and Claude Code or OpenAI Codex edits the slides.",
   "keywords": [
     "slides",

package/server.mjs

@@ -243,6 +243,7 @@ function staleEdit(res, b) {
 const text = (res, code, s) => { res.writeHead(code, { "content-type": "text/plain; charset=utf-8" }); res.end(s); };
 async function body(req) {
   let s = "";
+  req.setEncoding("utf8");
   for await (const c of req) { s += c; if (s.length > 5e6) throw new Error("body too large"); }
   return s ? JSON.parse(s) : {};
 }
@@ -576,7 +577,7 @@ function slidesInstructions() {
    win over allow rules; a locked file changed anyway is restored after the turn (lock 2 in finishTurn). */
 function lockedPaths() {
   const { files, folders } = otherDecks();
-  return [...LOCKED, "vendor/**", ".git/**", ...files, ...folders.map((f) => `${f}/**`)];
+  return [...LOCKED, "vendor/**", ".git", ".git/**", ...files, ...folders.map((f) => `${f}/**`)];
 }
 /* The other decks in this deck's folder: its other .html files, and the subfolders that hold a deck of their
    own (as the deck menu lists them). Neither the assistant nor this deck's undo touches them. */
@@ -612,10 +613,9 @@ function othersWorkedSince(start) {
   for (const f of files) {
     try {
       const o = JSON.parse(fs.readFileSync(path.join(TURNS_DIR, f), "utf8"));
-      let alive = true;
-      try { process.kill(o.pid, 0); } catch (e) { alive = e.code === "EPERM"; }
+      const running = alive(o.pid);
       // a turn still open in a server that is gone ended when that server did, at the latest
-      if (o.turns.some((x) => (x.end ?? (alive ? now : x.start)) >= start)) names.push(o.deck);
+      if (o.turns.some((x) => (x.end ?? (running ? now : x.start)) >= start)) names.push(o.deck);
     } catch {}
   }
   return names;
@@ -671,7 +671,7 @@ function makeSession(choice) {
     args: () => ["--append-system-prompt", systemPrompt + slidesInstructions() + deckInstructions(),
       "--setting-sources", "", "--strict-mcp-config", "--safe-mode", "--disable-slash-commands",   // no settings files, no MCP servers or connectors
       "--permission-mode", "default", "--tools", "Read,Glob,Grep,Edit,Write,Bash",
-      "--allowedTools", "Read", "Glob", "Grep", "Edit(./**)", "Write(./**)",
+      "--allowedTools", ...readRules(), "Edit(./**)", "Write(./**)",
       ...["layout", "shot", "slides", "pdf", "pdf-figure"].map(command => `Bash(${CLI_CMD} ${command}:*)`),
       "--disallowedTools", ...lockedPaths().flatMap((f) => [`Edit(./${f})`, `Write(./${f})`]),
       ...(choice.model ? ["--model", choice.model] : []), ...(choice.effort ? ["--effort", choice.effort] : [])],
@@ -679,6 +679,13 @@ function makeSession(choice) {
   agent.initialEvent = () => initial;
   return agent;
 }
+/* Claude reads what Codex's tools may read (agentTools' readDirs): the deck, screenshots, attached PDFs and
+   asset roots, each by its path and its real path ("//" starts an absolute path in a rule) */
+function readRules() {
+  const dirs = [SHOT_DIR, PDF_DIR, ...ASSET_ROOTS].flatMap((d) => { try { return [d, fs.realpathSync(d)]; } catch { return [d]; } });
+  const globs = ["./**", ...new Set(dirs.map((d) => `/${d}/**`))];
+  return ["Read", "Glob", "Grep"].flatMap((tool) => globs.map((g) => `${tool}(${g})`));
+}
 const providerAvailable = (provider) => detectCapabilities()[provider];
 /* Every backend process that is stopped is waited for on exit: the discovery helpers, the session a switch
    replaced, the current one. */
@@ -892,7 +899,7 @@ function handleEvent(ev) {
 function startTurn(promptText, userEntry) {
   // every deck file as it is now: the assistant may change any of them (not brand.css or vendor/), and undo
   // takes back all it changed
-  state.turn = { id: userEntry.id, before: snapshot([...EDITABLE, ...LOCKED]), gitConfig: readDeck(".git/config"), scan: scanDeck(), touched: new Set(),
+  state.turn = { id: userEntry.id, before: snapshot([...EDITABLE, ...LOCKED]), gitConfig: readDeck(".git/config"), hadGit: fs.existsSync(path.join(DECK_DIR, ".git")), scan: scanDeck(), touched: new Set(),
     time: { start: Date.now(), end: null } };
   logTurnTime(state.turn.time);
   state.busy = true;
@@ -930,6 +937,12 @@ function finishTurn({ error, cost, duration, denials = [] }) {
       restored.push(".git/config");
     } catch (e) { console.error(e.message); }
   }
+  // a .git file ("gitdir: elsewhere") points git at another config, which the check above does not see
+  const dotGit = path.join(DECK_DIR, ".git");
+  if (!turn.hadGit && fs.lstatSync(dotGit, { throwIfNoEntry: false })?.isDirectory() === false) {
+    fs.rmSync(dotGit, { force: true });
+    restored.push(".git");
+  }
   toolEntries.clear();
   const eid = runEidPass();
   const found = scanChanges(turn.scan, scanDeck());
@@ -952,13 +965,14 @@ function finishTurn({ error, cost, duration, denials = [] }) {
   const deletedFiles = [];
   for (const rel of turn.importedFiles || []) {
     const abs = path.join(DECK_DIR, rel);
-    if (!fs.existsSync(abs) || EDITABLE.some((f) => (after[f] || "").includes(rel))) continue;
+    if (!fs.existsSync(abs) || EDITABLE.some((f) => (readDeck(f) || "").includes(rel))) continue;
     deletedFiles.push({ rel, data: fs.readFileSync(abs) });
     fs.rmSync(abs, { force: true });
   }
   const t = { id: turn.id, kind: "agent", provider: settings.provider, conversation: state.conversation, before, after, files, deletedFiles, undone: false };
-  if (files.length) { state.turns.push(t); state.redo = []; }
-  addEntry({ kind: "turn", turnId: files.length ? t.id : null, files, error, cost, duration,
+  const kept = files.length || deletedFiles.length;
+  if (kept) { state.turns.push(t); state.redo = []; }
+  addEntry({ kind: "turn", turnId: kept ? t.id : null, files, error, cost, duration,
     denials, restored, newIds: eid.assigned.length });
   if (deletedFiles.length) addEntry({ kind: "notice", text: `Removed ${deletedFiles.map((f) => f.rel).join(", ")}: replaced, and no longer used.` });
   if (notOurs.length) addEntry({ kind: "notice", text: `${notOurs.join(", ")} changed during this turn while the assistant of ` +
@@ -1243,11 +1257,7 @@ function undoConflicts(t, direction) {
   const go = direction === "undo" ? t.addedFiles || [] : t.deletedFiles || [];
   // a file to bring back or remove through a symlink out of the deck: not done (deckPath), so not begun
   for (const { rel } of [...comeBack, ...go]) { try { deckPath(rel); } catch { files.push(rel); } }
-  for (const { rel, data } of comeBack) {
-    const abs = path.join(DECK_DIR, rel);
-    if (fs.existsSync(abs) && !sameContent(abs, data)) files.push(rel);
-  }
-  for (const { rel, data } of go) {
+  for (const { rel, data } of [...comeBack, ...go]) {
     const abs = path.join(DECK_DIR, rel);
     if (fs.existsSync(abs) && !sameContent(abs, data)) files.push(rel);
   }
@@ -1330,8 +1340,7 @@ async function applyImport(imp, numbers, afterEid, refine = false) {
   const afterIdx = found < 0 ? slides.length - 1 : found;   // no such slide (any more): at the end
   const after = slides[afterIdx];
   const css = (readDeck("theme.css") || "") + (readDeck("brand.css") || "");
-  const prefix = path.basename(imp.name, path.extname(imp.name)).normalize("NFKD").replace(/[\u0300-\u036f]/g, "")
-    .toLowerCase().replace(/[^a-z0-9]+/g, "-").replace(/^-+|-+$/g, "").split("-").slice(0, 3).join("-") || "import";
+  const prefix = slug(path.basename(imp.name, path.extname(imp.name))).split("-").slice(0, 3).join("-");
   const r = await buildImport({ model: imp.model, numbers, pdf, workDir: imp.dir, deckDir: DECK_DIR, deckHtml: html0, css, after: afterIdx, prefix });
   // building takes a while (pictures are cut from the slides): a change made meanwhile must not be overwritten
   if (EDITABLE.some((f) => readDeck(f) !== before[f])) throw new Error("The deck changed during the import. Import again.");