pim-agent 0.12.0 → 0.13.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pim-agent",
-  "version": "0.12.0",
+  "version": "0.13.0",
   "description": "A batteries-included distro of Pi, accessible in your terminal, browser and Telegram.",
   "license": "MIT",
   "type": "module",
@@ -66,6 +66,7 @@
     "@types/bun": "latest",
     "happy-dom": "^20.14.0",
     "highlight.js": "^11.12.0",
+    "mermaid": "^12.0.0",
     "oxfmt": "0.67.0",
     "oxlint": "^1.82.0",
     "solid-js": "^2.0.0-rc.7",

package/packages/core/src/extensions/bash/MemoryCap.ts

@@ -0,0 +1,128 @@
+import { readFile } from "node:fs/promises";
+import { totalmem } from "node:os";
+
+export const MEMORY_LIMIT_VAR = "PIM_BASH_MEMORY_MAX";
+const DEFAULT_SHARE_OF_RAM = 0.25;
+const PROBE_LIMIT = 1024 ** 3;
+const UNITS = { "": 1, K: 1024, M: 1024 ** 2, G: 1024 ** 3, T: 1024 ** 4 };
+
+export type MemoryScope = {
+  readonly unit: string;
+  readonly limitBytes: number;
+  readonly argv: readonly string[];
+};
+
+let supported: Promise<boolean> | null = null;
+let owner: Promise<string | null> | null = null;
+
+function limitBytes(): number | null {
+  const raw = process.env[MEMORY_LIMIT_VAR]?.trim();
+  if (raw === undefined || raw === "") {
+    return Math.floor(totalmem() * DEFAULT_SHARE_OF_RAM);
+  }
+  if (/^(off|infinity|0)$/i.test(raw)) {
+    return null;
+  }
+  const match = /^(\d+(?:\.\d+)?)\s*([KMGT]?)i?B?$/i.exec(raw);
+  if (!match) {
+    throw new Error(
+      `${MEMORY_LIMIT_VAR}=${raw} is not a size: use e.g. 8G or 512M, or off to disable the limit.`
+    );
+  }
+  const unit = (match[2] ?? "").toUpperCase() as keyof typeof UNITS;
+  return Math.floor(Number(match[1]) * UNITS[unit]);
+}
+
+/** Whether a scope's MemoryMax is really enforced: without the memory controller delegated, systemd accepts it and ignores it. */
+async function probe(): Promise<boolean> {
+  if (process.platform !== "linux") {
+    return false;
+  }
+  try {
+    const proc = Bun.spawn({
+      cmd: [
+        "systemd-run",
+        "--user",
+        "--scope",
+        "--quiet",
+        "--expand-environment=no",
+        `--property=MemoryMax=${PROBE_LIMIT}`,
+        "--",
+        "sh",
+        "-c",
+        'read -r line < /proc/self/cgroup; cat "/sys/fs/cgroup${line#0::}/memory.max"',
+      ],
+      stdout: "pipe",
+      stderr: "ignore",
+    });
+    const [out, code] = await Promise.all([
+      new Response(proc.stdout).text(),
+      proc.exited,
+    ]);
+    return code === 0 && out.trim() === String(PROBE_LIMIT);
+  } catch {
+    return false;
+  }
+}
+
+/** The user-manager service this process runs in, so a command's scope stops with it. */
+async function findOwner(): Promise<string | null> {
+  try {
+    const cgroup = await readFile("/proc/self/cgroup", "utf8");
+    const path = cgroup.trim().split("\n").at(-1)?.split("::")[1] ?? "";
+    const unit = path.split("/").at(-1) ?? "";
+    const underUserManager = path.includes("/user@");
+    return underUserManager &&
+      unit.endsWith(".service") &&
+      !unit.startsWith("user@")
+      ? unit
+      : null;
+  } catch {
+    return null;
+  }
+}
+
+/** The systemd-run prefix that puts one command in its own memory-capped scope, or null when it cannot be capped. */
+async function scope(): Promise<MemoryScope | null> {
+  const limit = limitBytes();
+  if (limit === null || !(await (supported ??= probe()))) {
+    return null;
+  }
+  const bindTo = await (owner ??= findOwner());
+  const unit = `pim-bash-${crypto.randomUUID().slice(0, 8)}.scope`;
+  return {
+    unit,
+    limitBytes: limit,
+    argv: [
+      "systemd-run",
+      "--user",
+      "--scope",
+      "--quiet",
+      "--expand-environment=no",
+      "--collect",
+      `--unit=${unit}`,
+      `--property=MemoryMax=${limit}`,
+      "--property=MemorySwapMax=0",
+      "--property=OOMPolicy=kill",
+      ...(bindTo
+        ? [`--property=BindsTo=${bindTo}`, `--property=After=${bindTo}`]
+        : []),
+      "--",
+    ],
+  };
+}
+
+async function systemctl(args: readonly string[]): Promise<void> {
+  await Bun.spawn({
+    cmd: ["systemctl", "--user", ...args],
+    stdout: "ignore",
+    stderr: "ignore",
+  }).exited;
+}
+
+/** Ends whatever of a killed command is still in its scope, including a scope systemd never saw empty. */
+async function stop(unit: string): Promise<void> {
+  await systemctl(["--no-block", "stop", unit]);
+}
+
+export const MemoryCap = { limitBytes, scope, stop };

package/packages/core/src/extensions/bash/format.ts

@@ -37,6 +37,11 @@ export function formatResult(
     lines.push("Aborted.");
   } else if (result.timedOut) {
     lines.push(`Timed out after ${timeoutMs} ms.`);
+  } else if (result.memoryLimitHit !== null) {
+    lines.push(
+      `Killed: most likely it exceeded the ${Format.bytes(result.memoryLimitHit)} memory limit for one command. ` +
+        "Retrying it unchanged will fail the same way; reduce its memory use (stream or batch the data, run fewer parallel workers)."
+    );
   }
   for (const label of STREAMS) {
     const stream = result[label];

package/packages/core/src/extensions/bash/run.ts

@@ -3,6 +3,7 @@ import { SpillCache } from "../../shared/SpillCache";
 import { StreamCapture } from "./capture";
 import { isErrorResult } from "./format";
 import { normaliseStdoutImage } from "./image";
+import { MemoryCap } from "./MemoryCap";
 import {
   type BashCommandResult,
   type CapturedStream,
@@ -18,7 +19,8 @@ const COMMAND_VAR = "PIM_BASH_COMMAND";
 // argv is what `pkill -f`/`pgrep -f` match, so a command naming its own target would
 // signal this shell before its target. The env hands it over out of argv's reach, and
 // the unset keeps it out of every child's environment too.
-const RUNNER = `__pim_command=$${COMMAND_VAR}; unset ${COMMAND_VAR}; eval "$__pim_command"`;
+// The raised oom_score_adj makes the command, not the agent or the desktop, the kernel's first victim.
+const RUNNER = `{ echo 500 > /proc/self/oom_score_adj; } 2>/dev/null; __pim_command=$${COMMAND_VAR}; unset ${COMMAND_VAR}; eval "$__pim_command"`;
 
 export function killAllActiveBashGroups(sig: NodeJS.Signals = "SIGTERM"): void {
   for (const pid of activePids) {
@@ -100,10 +102,11 @@ export async function runBashCommand(
   const startedAt = Date.now();
   const stdoutCap = new StreamCapture();
   const stderrCap = new StreamCapture();
+  const scope = await MemoryCap.scope();
 
   // setsid gives the tree its own process group (pgid == proc.pid) so the whole tree can be signalled.
   const proc = Bun.spawn({
-    cmd: ["setsid", "bash", "-lc", RUNNER],
+    cmd: [...(scope?.argv ?? []), "setsid", "bash", "-lc", RUNNER],
     cwd,
     stdout: "pipe",
     stderr: "pipe",
@@ -170,6 +173,9 @@ export async function runBashCommand(
       } finally {
         clearTimeout(sigkillTimer);
       }
+      if (scope) {
+        await MemoryCap.stop(scope.unit);
+      }
     }
 
     exitCode = proc.exitCode ?? null;
@@ -207,6 +213,12 @@ export async function runBashCommand(
   const stdout = stdoutCap.snapshot(sniffed !== null);
   const stderr = stderrCap.snapshot();
 
+  // Under OOMPolicy=kill a limit hit is a SIGKILL of the whole scope; systemd's own Result for it is racy.
+  const memoryLimitHit =
+    scope !== null && signalCode === "SIGKILL" && !timedOut && !aborted
+      ? scope.limitBytes
+      : null;
+
   const [stdoutPath, stderrPath, stdoutImage] = await Promise.all([
     spillIfTruncated(stdout, stdoutCap, "out"),
     spillIfTruncated(stderr, stderrCap, "err"),
@@ -222,6 +234,7 @@ export async function runBashCommand(
     stdoutImage,
     timedOut,
     aborted,
+    memoryLimitHit,
     durationMs: Date.now() - startedAt,
   };
 }

package/packages/core/src/extensions/bash/schema.ts

@@ -43,6 +43,8 @@ export type BashCommandResult = {
   readonly stdoutImage: NormalisedImage | null;
   readonly timedOut: boolean;
   readonly aborted: boolean;
+  /** The limit in bytes, set when the capped command was SIGKILLed without pim sending it. */
+  readonly memoryLimitHit: number | null;
   readonly durationMs: number;
 };
 

package/packages/core/src/extensions/system-prompt/index.ts

@@ -5,6 +5,7 @@ import type {
 import type { Surface } from "../../shared/Surface";
 import {
   buildEnvironment,
+  buildFormatting,
   buildInstructions,
   formatDatetime,
   leadWithSystemPrompt,
@@ -36,6 +37,7 @@ export default function (surface?: Surface): ExtensionFactory {
         model: ctx.model,
         surface,
       });
+      options.sections.formatting = buildFormatting(surface);
     });
     pi.on("context_with_system", (event) => {
       const messages = leadWithSystemPrompt(event.messages);

package/packages/core/src/extensions/system-prompt/prompt.ts

@@ -13,6 +13,13 @@ type EnvironmentOptions = {
   readonly surface?: Surface;
 };
 
+const FORMATTING: Readonly<Record<Surface, string>> = {
+  "web browser":
+    "Replies render as Markdown, and ```mermaid fences render as diagrams. Prefer a diagram over ASCII art for flows, sequences, state machines and structure.",
+  terminal: "",
+  Telegram: "",
+};
+
 type RunCommand = (cmd: ReadonlyArray<string>) => string | undefined;
 
 type OsDescriptionOptions = {
@@ -71,6 +78,11 @@ export function buildEnvironment(opts: EnvironmentOptions): string {
   ].join("\n");
 }
 
+/** What the surface renders beyond plain text; empty, so pi omits the section, where that is nothing. */
+export function buildFormatting(surface: Surface | undefined): string {
+  return surface === undefined ? "" : FORMATTING[surface];
+}
+
 export function describeOs(options: OsDescriptionOptions = {}): string {
   if (options.platform === undefined && options.runCommand === undefined) {
     cachedOs ??= computeOs(options);

package/packages/core/src/shared/Supervisor.ts

@@ -379,6 +379,7 @@ function systemdUnit(unit: Unit, at: Install): string {
     `ExecStart=${at.bunPath} ${at.pimEntry} ${modeArgs(unit).join(" ")}`,
     "Restart=always",
     "RestartSec=2",
+    "OOMPolicy=continue",
     "",
     "[Install]",
     "WantedBy=default.target",

package/packages/web/dist/client/assets/abnfDiagram-O67JEVCF-CZ7V84ot.js

@@ -0,0 +1 @@
+import{m as e,t}from"./mermaid-parser.core-nQaTP3VY.js";import{n}from"./chunk-Y2CYZVJY-DsF7k-Jl.js";import{m as r}from"./src-DF7hQfMh.js";import"./chunk-O7XYJQB3-ZHvBmBO-.js";import{n as i,r as a,t as o}from"./chunk-GTNCS2PH-DG2b2LYE.js";import{t as s}from"./chunk-JWPE2WC7-DVXcaiue.js";import"./mermaid.core-Cz05yTZh.js";var c=e().RailroadAbnf.parser.LangiumParser,l=n(e=>{let t=e.alternatives.map(u);return t.length===1?t[0]:{type:`choice`,alternatives:t}},`transformAlternation`),u=n(e=>{let t=e.elements.map(f);return t.length===1?t[0]:{type:`sequence`,elements:t}},`transformConcatenation`),d=n(e=>{if(e.includes(`*`)){let[t,n]=e.split(`*`);return{min:t?parseInt(t,10):0,max:n?parseInt(n,10):1/0}}let t=parseInt(e,10);return{min:t,max:t}},`parseRepeat`),f=n(e=>{let t=p(e.primary);if(!e.repeat)return t;let{min:n,max:r}=d(e.repeat);return n===0&&r===1?{type:`optional`,element:t}:{type:`repetition`,element:t,min:n,max:r}},`transformElement`),p=n(e=>{switch(e.$type){case`AbnfStringLiteral`:return{type:`terminal`,value:e.value};case`AbnfNumVal`:return{type:`terminal`,value:e.value};case`AbnfRuleName`:return{type:`nonterminal`,name:e.name};case`AbnfGroup`:return l(e.element);case`AbnfOptionalGroup`:return{type:`optional`,element:l(e.element)};default:throw Error(`Unsupported ABNF primary node: ${e.$type}`)}},`transformPrimary`),m=n(e=>({name:e.name,definition:l(e.definition)}),`transformRule`),h=n(e=>{s(e,o),e.title&&o.setTitle(e.title),e.rules.map(e=>o.addRule(m(e)))},`populateDb`),g={parser:{parse:n(e=>{o.clear(),r.debug(`[ABNF Parser] Starting Langium parse`);let n=c.parse(e);if(n.lexerErrors.length>0||n.parserErrors.length>0)throw new t(n);let i=n.value;r.debug(`[ABNF Parser] Parsed rules:`,i.rules.length),h(i),r.debug(`[ABNF Parser] Parse complete`)},`parse`),parser:{yy:o}},db:o,renderer:a,styles:i};export{g as diagram};

package/packages/web/dist/client/assets/arc-DiHGkUvc.js

@@ -0,0 +1 @@
+import{n as e,t}from"./path-fybaL0A-.js";import{a as n,c as r,d as i,f as a,i as o,l as s,m as c,n as l,o as u,p as d,r as f,u as p}from"./dist-BddGOpie.js";function m(e){return e.innerRadius}function h(e){return e.outerRadius}function g(e){return e.startAngle}function _(e){return e.endAngle}function v(e){return e&&e.padAngle}function y(e,t,n,r,i,a,o,s){var c=n-e,l=r-t,u=o-i,d=s-a,f=d*c-u*l;if(!(f*f<1e-12))return f=(u*(t-a)-d*(e-i))/f,[e+f*c,t+f*l]}function b(e,t,n,r,i,a,o){var c=e-n,l=t-r,u=(o?a:-a)/d(c*c+l*l),f=u*l,p=-u*c,m=e+f,h=t+p,g=n+f,_=r+p,v=(m+g)/2,y=(h+_)/2,b=g-m,x=_-h,S=b*b+x*x,C=i-a,w=m*_-g*h,T=(x<0?-1:1)*d(s(0,C*C*S-w*w)),E=(w*x-b*T)/S,D=(-w*b-x*T)/S,O=(w*x+b*T)/S,k=(-w*b+x*T)/S,A=E-v,j=D-y,M=O-v,N=k-y;return A*A+j*j>M*M+N*N&&(E=O,D=k),{cx:E,cy:D,x01:-f,y01:-p,x11:E*(i/C-1),y11:D*(i/C-1)}}function x(){var s=m,x=h,S=e(0),C=null,w=g,T=_,E=v,D=null,O=t(k);function k(){var e,t,m=+s.apply(this,arguments),h=+x.apply(this,arguments),g=w.apply(this,arguments)-r,_=T.apply(this,arguments)-r,v=l(_-g),k=_>g;if(D||=e=O(),h<m&&(t=h,h=m,m=t),!(h>1e-12))D.moveTo(0,0);else if(v>c-1e-12)D.moveTo(h*u(g),h*a(g)),D.arc(0,0,h,g,_,!k),m>1e-12&&(D.moveTo(m*u(_),m*a(_)),D.arc(0,0,m,_,g,k));else{var A=g,j=_,M=g,N=_,P=v,F=v,I=E.apply(this,arguments)/2,L=I>1e-12&&(C?+C.apply(this,arguments):d(m*m+h*h)),R=p(l(h-m)/2,+S.apply(this,arguments)),z=R,B=R,V,H;if(L>1e-12){var U=o(L/m*a(I)),W=o(L/h*a(I));(P-=U*2)>1e-12?(U*=k?1:-1,M+=U,N-=U):(P=0,M=N=(g+_)/2),(F-=W*2)>1e-12?(W*=k?1:-1,A+=W,j-=W):(F=0,A=j=(g+_)/2)}var G=h*u(A),K=h*a(A),q=m*u(N),J=m*a(N);if(R>1e-12){var Y=h*u(j),X=h*a(j),Z=m*u(M),Q=m*a(M),$;if(v<i){if($=y(G,K,Z,Q,Y,X,q,J)){var ee=G-$[0],te=K-$[1],ne=Y-$[0],re=X-$[1],ie=1/a(f((ee*ne+te*re)/(d(ee*ee+te*te)*d(ne*ne+re*re)))/2),ae=d($[0]*$[0]+$[1]*$[1]);z=p(R,(m-ae)/(ie-1)),B=p(R,(h-ae)/(ie+1))}else z=B=0}}F>1e-12?B>1e-12?(V=b(Z,Q,G,K,h,B,k),H=b(Y,X,q,J,h,B,k),D.moveTo(V.cx+V.x01,V.cy+V.y01),B<R?D.arc(V.cx,V.cy,B,n(V.y01,V.x01),n(H.y01,H.x01),!k):(D.arc(V.cx,V.cy,B,n(V.y01,V.x01),n(V.y11,V.x11),!k),D.arc(0,0,h,n(V.cy+V.y11,V.cx+V.x11),n(H.cy+H.y11,H.cx+H.x11),!k),D.arc(H.cx,H.cy,B,n(H.y11,H.x11),n(H.y01,H.x01),!k))):(D.moveTo(G,K),D.arc(0,0,h,A,j,!k)):D.moveTo(G,K),!(m>1e-12)||!(P>1e-12)?D.lineTo(q,J):z>1e-12?(V=b(q,J,Y,X,m,-z,k),H=b(G,K,Z,Q,m,-z,k),D.lineTo(V.cx+V.x01,V.cy+V.y01),z<R?D.arc(V.cx,V.cy,z,n(V.y01,V.x01),n(H.y01,H.x01),!k):(D.arc(V.cx,V.cy,z,n(V.y01,V.x01),n(V.y11,V.x11),!k),D.arc(0,0,m,n(V.cy+V.y11,V.cx+V.x11),n(H.cy+H.y11,H.cx+H.x11),k),D.arc(H.cx,H.cy,z,n(H.y11,H.x11),n(H.y01,H.x01),!k))):D.arc(0,0,m,N,M,k)}if(D.closePath(),e)return D=null,e+``||null}return k.centroid=function(){var e=(+s.apply(this,arguments)+ +x.apply(this,arguments))/2,t=(+w.apply(this,arguments)+ +T.apply(this,arguments))/2-i/2;return[u(t)*e,a(t)*e]},k.innerRadius=function(t){return arguments.length?(s=typeof t==`function`?t:e(+t),k):s},k.outerRadius=function(t){return arguments.length?(x=typeof t==`function`?t:e(+t),k):x},k.cornerRadius=function(t){return arguments.length?(S=typeof t==`function`?t:e(+t),k):S},k.padRadius=function(t){return arguments.length?(C=t==null?null:typeof t==`function`?t:e(+t),k):C},k.startAngle=function(t){return arguments.length?(w=typeof t==`function`?t:e(+t),k):w},k.endAngle=function(t){return arguments.length?(T=typeof t==`function`?t:e(+t),k):T},k.padAngle=function(t){return arguments.length?(E=typeof t==`function`?t:e(+t),k):E},k.context=function(e){return arguments.length?(D=e??null,k):D},k}export{x as t};

package/packages/web/dist/client/assets/architecture-7GRP2DOG-HIzEIkwQ.js

@@ -0,0 +1 @@
+import"./chunk-FOHPRMQF-CoA4358r.js";import{M as e}from"./mermaid-parser.core-nQaTP3VY.js";export{e as createArchitectureServices};