pierre-review 0.1.86 → 0.1.88

package/dist/api/routes/activity.js

@@ -42,6 +42,7 @@ export async function activityRoutes(app) {
             allowBotIds: parseIntList(q.allowBotIds),
             botsOnly: q.botsOnly === 'true',
             botWindowDays,
+            includeAllCommits: q.includeAllCommits === 'true',
         });
     });
     // Mark the Activity Feed as seen (bumps the account's server-side "seen" marker to

package/dist/api/routes/bot-triage.js

@@ -1,4 +1,4 @@
-import { addBotMuteRule, deleteBotMuteRule, getBotAnalytics, getBotOnlyPrs, getBotVendorPrs, getBotDedupClusters, getResolvableBotThreadPrs, getResolvableBotThreadsForScope, listBotMuteRules, listDetectedReviewers, resolveScopeRepoIds, setReviewerOverride, SCOPE_RESOLVE_THREAD_CAP, } from '../../db/queries.js';
+import { addBotMuteRule, deleteBotMuteRule, getBotAnalytics, getBotBehaviourAnalytics, getBotOnlyPrs, getBotVendorPrs, getBotDedupClusters, getResolvableBotThreadPrs, getResolvableBotThreadsForScope, listBotMuteRules, listDetectedReviewers, resolveScopeRepoIds, setReviewerOverride, SCOPE_RESOLVE_THREAD_CAP, } from '../../db/queries.js';
 import { resolveThreadsOnGitHub } from '../../bot-triage/resolve.js';
 import { accountIdOf } from '../plugins/auth.js';
 // Parse a comma-separated id list into a positive-int array, or null when empty/absent (so
@@ -173,6 +173,18 @@ export async function botTriageRoutes(app) {
         const resp = await getBotAnalytics(accountId, window, scopeRepoIds);
         return resp;
     });
+    // EXPERIMENTAL bot BEHAVIOUR analytics (CORE, deterministic — no AI). Per bot, over the same
+    // window/scope resolution as /api/bot-analytics: time-to-first-review, LoC-to-comments ratio,
+    // the week×hour activity heatmap (coverage / rate-limit inference), and post-first-review
+    // follow-up behaviour. Powers the Bots "Behaviour" sub-tab, kept separate from the ROI panel.
+    app.get('/api/bot-behaviour', { schema: analyticsSchema }, async (req) => {
+        const { window, scope, repoIds } = req.query;
+        const accountId = accountIdOf(req);
+        const explicit = parseIntList(repoIds);
+        const scopeRepoIds = explicit ?? (scope ? await resolveScopeRepoIds(accountId, scope) : null);
+        const resp = await getBotBehaviourAnalytics(accountId, window, scopeRepoIds);
+        return resp;
+    });
     // The exact PR list behind the analytics totals.botOnlyPrs count — "only a bot reviewed these".
     // Same window/scope resolution as /api/bot-analytics (a specific `repoIds` wins over `scope`) so
     // the amber caption's number and this expandable list are computed identically and can't drift.

package/dist/api/routes/mentions.js

@@ -0,0 +1,17 @@
+import { getScopeMentionCandidates, resolveScopeRepoIds } from '../../db/queries.js';
+import { accountIdOf } from '../plugins/auth.js';
+// Scope-wide @mention candidates (CORE) — the team/repo-scoped sibling of
+// GET /api/prs/:id/mention-candidates. Powers the ad-hoc Insights "Ask about the sprint" box,
+// whose questions span the whole selected scope rather than one PR. `scope` mirrors the Insights
+// scope string ('all' | 'none' | 'teams' | '<teamId>'); it's resolved to the account's repo set
+// server-side (resolveScopeRepoIds), so a caller can't widen it. Self + bots excluded. Returns a
+// bare User[] exactly like the PR route so MentionTextarea can consume it directly.
+export async function mentionsRoutes(app) {
+    app.get('/api/mention-candidates', async (req) => {
+        const q = req.query;
+        const accountId = accountIdOf(req);
+        const repoIds = await resolveScopeRepoIds(accountId, q.scope ?? 'all');
+        return getScopeMentionCandidates(accountId, repoIds);
+    });
+}
+//# sourceMappingURL=mentions.js.map

package/dist/api/routes/prs.js

@@ -2,9 +2,8 @@ import { createHash } from 'node:crypto';
 import { config } from '../../config.js';
 import { getAccessToken, getAccountUserId } from '../../auth/account.js';
 import { fetchActionsJobLog } from '../../github/actions-logs.js';
-import { getMentionCandidates, getPrDetail, getPrFilesContext, getPrWriteContext, getReviewerLogins, getResolvableBotThreads, getSuggestedReviewersBasis, getUsersByLogins, markAllViewed, markPrMergedLocally, markPrViewed, stampReviewRequests, upsertLocalPrComment, upsertLocalReview, } from '../../db/queries.js';
-import { getCodeownersMatch } from '../../github/codeowners.js';
-import { suggestTeamsFromHistory } from '../../github/team-reviewers.js';
+import { getMentionCandidates, getPrDetail, getPrBotBehaviour, getPrFilesContext, getPrWriteContext, getReviewerLogins, getResolvableBotThreads, getSuggestedReviewersBasis, getUsersByLogins, markAllViewed, markPrMergedLocally, markPrViewed, stampReviewRequests, upsertLocalPrComment, upsertLocalReview, } from '../../db/queries.js';
+import { enrichReviewerSuggestions } from '../../github/reviewer-suggest.js';
 import { buildFileAnchors, fallbackAnchor, isFindingAnchored, } from '../../github/diff-anchor.js';
 import { addIssueComment, fetchHeadShaFor, fetchMergeability, fetchPrFilesWithPatch, fetchPrHeadInfo, fetchRepoMergeConfig, mergePullRequest, postInlineComment, requestReviewers, rerunWorkflowRun, submitPrReview, updatePullRequestBranch, } from '../../github/mutations.js';
 import { hydratePrDetail } from '../../sync/hydrate-detail.js';
@@ -170,77 +169,17 @@ async function buildSuggestedReviewers(basis, accountId) {
     if (!basis.wants)
         return { suggestedReviewers: [], users: [] };
     const { owner, name, authorLogin, paths, suggestions, users } = basis;
-    const extraUsers = [];
-    let merged = suggestions;
-    try {
-        const token = await getAccessToken(accountId);
-        const emptyMatch = { logins: [], teams: [] };
-        const [match, historyTeams] = await Promise.all([
-            paths.length > 0
-                ? getCodeownersMatch(token, owner, name, accountId, paths)
-                : Promise.resolve(emptyMatch),
-            suggestTeamsFromHistory(token, owner, name, accountId),
-        ]);
-        // Resolve @user owners to synced users (avatar/link); unsynced owners show login-only.
-        // Exclude the PR author (GitHub rejects self-review requests).
-        const uniqueLogins = [...new Set(match.logins)].filter((l) => l !== authorLogin);
-        const resolved = await getUsersByLogins(uniqueLogins);
-        const byLogin = new Map(resolved.map((u) => [u.githubLogin, u]));
-        const codeownerUsers = uniqueLogins.map((login) => ({
-            kind: 'user',
-            login,
-            userId: byLogin.get(login)?.id ?? null,
-            teamSlug: null,
-            teamName: null,
-            reason: 'owns this path (CODEOWNERS)',
-            source: 'codeowners',
-        }));
-        const codeownerTeams = match.teams.map((t) => ({
-            kind: 'team',
-            login: null,
-            userId: null,
-            teamSlug: t.slug,
-            teamName: t.name,
-            reason: 'owns this path (CODEOWNERS)',
-            source: 'codeowners',
-        }));
-        const historyTeamSuggestions = historyTeams.map((t) => ({
-            kind: 'team',
-            login: null,
-            userId: null,
-            teamSlug: t.slug,
-            teamName: t.name,
-            reason: `usually requested here (${t.count} recent PR${t.count === 1 ? '' : 's'})`,
-            source: 'history',
-        }));
-        // Merge = precedence: CODEOWNERS users, CODEOWNERS teams (declared), inferred teams, then
-        // the history-user suggestions. Dedup users by login and teams by slug (so a team that's
-        // both a CODEOWNER and historically requested shows once, as the CODEOWNER).
-        const seenLogins = new Set();
-        const seenTeams = new Set();
-        merged = [];
-        for (const s of [...codeownerUsers, ...codeownerTeams, ...historyTeamSuggestions, ...suggestions]) {
-            if (s.kind === 'team') {
-                if (s.teamSlug && !seenTeams.has(s.teamSlug)) {
-                    seenTeams.add(s.teamSlug);
-                    merged.push(s);
-                }
-            }
-            else if (s.login && !seenLogins.has(s.login)) {
-                seenLogins.add(s.login);
-                merged.push(s);
-            }
-        }
-        // The newly-resolved codeowner users the basis didn't already carry.
-        const known = new Set(users.map((u) => u.id));
-        for (const u of resolved)
-            if (!known.has(u.id))
-                extraUsers.push(u);
-    }
-    catch {
-        /* best-effort: fall back to the history-user suggestions */
-    }
-    return { suggestedReviewers: merged.slice(0, 5), users: [...users, ...extraUsers] };
+    const { suggestions: merged, extraUsers } = await enrichReviewerSuggestions({
+        accountId,
+        owner,
+        name,
+        authorLogin,
+        paths,
+        userSuggestions: suggestions,
+        knownUserIds: new Set(users.map((u) => u.id)),
+        resolveUsers: getUsersByLogins,
+    });
+    return { suggestedReviewers: merged, users: [...users, ...extraUsers] };
 }
 export async function prRoutes(app) {
     // Bulk "mark all seen": stamp every open PR (optionally scoped to repoIds) viewed
@@ -265,6 +204,19 @@ export async function prRoutes(app) {
         // cached detail never freezes a stale suggestion.)
         return hydratePrDetail(pr, accountId);
     });
+    // PR-scoped bot behaviour (EXPERIMENTAL, CORE, deterministic — no AI): each automated reviewer's
+    // touch timeline ON THIS PR + how it compares to that bot's OWN typical (an 84-day account-wide
+    // robust baseline). Powers the PrDetail "Bot activity" tab + the Overview chip warn badge.
+    // Account-scoped: 404 when the PR isn't the caller's; empty `bots` when no bot touched it.
+    app.get('/api/prs/:id/bot-behaviour', { schema: idParamSchema }, async (req, reply) => {
+        const { id } = req.params;
+        const resp = await getPrBotBehaviour(id, accountIdOf(req));
+        if (!resp) {
+            reply.status(404);
+            return { error: 'NotFound', message: `PR ${id} not found` };
+        }
+        return resp;
+    });
     // Suggested reviewers — its OWN live query (not embedded in the cached PR detail) so it
     // always reflects current state: it empties the instant a reviewer is requested (the assign
     // route stamps review_requests locally), rather than staying frozen until the PR's updatedAt

package/dist/app.js

@@ -20,6 +20,7 @@ import { feedRoutes } from './api/routes/feed.js';
 import { mergersRoutes } from './api/routes/mergers.js';
 import { insightsRoutes } from './api/routes/insights.js';
 import { activityRoutes } from './api/routes/activity.js';
+import { mentionsRoutes } from './api/routes/mentions.js';
 import { billingRoutes } from './api/routes/billing.js';
 import { botTriageRoutes } from './api/routes/bot-triage.js';
 import { webhookRoutes } from './api/routes/webhooks.js';
@@ -137,6 +138,7 @@ export async function buildApp() {
     await app.register(mergersRoutes);
     await app.register(insightsRoutes);
     await app.register(activityRoutes);
+    await app.register(mentionsRoutes);
     // Bot-triage platform (CORE, always registered): detection/override, ROI analytics,
     // cross-bot dedup, mute / auto-triage rules. Account-scoped; no AI.
     await app.register(botTriageRoutes);

package/dist/db/migrations/0034_thread_resolved_at.sql

@@ -0,0 +1,6 @@
+-- Resolution-latency support: record WHEN a review thread was first observed resolved. Nullable
+-- (unknown for threads already resolved at first sight); stamped by sync only on a witnessed
+-- unresolved→resolved transition. Additive — the backfill is a no-op (existing resolved threads
+-- keep a null resolvedAt; the metric only counts resolves observed going forward).
+-- The Postgres baseline is regenerated separately via `pnpm db:generate:pg`.
+ALTER TABLE `review_threads` ADD `resolved_at` integer;

package/dist/db/migrations/0035_pr_first_review_requested_at.sql

@@ -0,0 +1,5 @@
+-- Review-pickup support: store the earliest review-request time (first ReviewRequestedEvent) so
+-- we can trend request→first-review latency. Nullable (null = never requested / pre-existing PRs
+-- until the next sync backfills it from the timeline). Additive.
+-- The Postgres baseline is regenerated separately via `pnpm db:generate:pg`.
+ALTER TABLE `pull_requests` ADD `first_review_requested_at` integer;

package/dist/db/migrations/meta/_journal.json

@@ -239,6 +239,20 @@
       "when": 1784200000000,
       "tag": "0033_thread_addressed_confidence",
       "breakpoints": true
+    },
+    {
+      "idx": 34,
+      "version": "6",
+      "when": 1784300000000,
+      "tag": "0034_thread_resolved_at",
+      "breakpoints": true
+    },
+    {
+      "idx": 35,
+      "version": "6",
+      "when": 1784400000000,
+      "tag": "0035_pr_first_review_requested_at",
+      "breakpoints": true
     }
   ]
 }

package/dist/db/migrations-pg/0021_green_salo.sql

@@ -0,0 +1 @@
+ALTER TABLE "review_threads" ADD COLUMN "resolved_at" timestamp with time zone;

package/dist/db/migrations-pg/0022_wise_baron_strucker.sql

@@ -0,0 +1 @@
+ALTER TABLE "pull_requests" ADD COLUMN "first_review_requested_at" timestamp with time zone;