pierre-review 0.1.6 → 0.1.8

package/README.md

@@ -55,6 +55,7 @@ pierre-review [options]
 | `--no-open` | `NO_OPEN` | — | Don't open the browser on start. |
 | `--port <n>` | `PORT` | `4000` | Port to listen on. |
 | `--db <path>` | `DATABASE_URL` | `~/.pierre-review/pierre-review.sqlite` | SQLite DB path. |
+| — | `PERSIST_BODIES` | `false` | Store full comment/PR text in the DB instead of loading it on demand (larger DB, but PR detail works fully offline). |
 | `-h`, `--help` | — | — | Show usage. |
 
 Examples:
@@ -83,6 +84,12 @@ repositories you want to watch from the in-app picker; the app syncs their PR
 activity (full backfill on first sync, incremental every few minutes thereafter)
 into your local DB and renders it as a timeline.
 
+To keep the database small and backfills fast, bulky text — PR/comment/review
+bodies and diff hunks — isn't stored; it's fetched from GitHub (using your `gh`
+token) the first time you open a PR and cached in your browser, so re-opening an
+unchanged PR is instant and offline. Set `PERSIST_BODIES=true` to store that text
+locally instead — a larger database, but PR detail then works fully offline.
+
 ## License
 
 MIT

package/dist/api/routes/prs.js

@@ -1,4 +1,5 @@
 import { getPrDetail, markPrViewed } from '../../db/queries.js';
+import { hydratePrDetail } from '../../sync/hydrate-detail.js';
 import { accountIdOf } from '../plugins/auth.js';
 const idParamSchema = {
     params: {
@@ -18,12 +19,15 @@ const markViewedSchema = {
 export async function prRoutes(app) {
     app.get('/api/prs/:id', { schema: idParamSchema }, async (req, reply) => {
         const { id } = req.params;
-        const pr = await getPrDetail(id, accountIdOf(req));
+        const accountId = accountIdOf(req);
+        const pr = await getPrDetail(id, accountId);
         if (!pr) {
             reply.status(404);
             return { error: 'NotFound', message: `PR ${id} not found` };
         }
-        return pr;
+        // Cloud lean mode: fill in bulky text from GitHub (no-op in local). The client
+        // caches the result in IndexedDB keyed by updatedAt so unchanged PRs don't refetch.
+        return hydratePrDetail(pr, accountId);
     });
     // Record that the local user has seen this PR up to `sha` (defaults to the
     // current head). Clears "new since last viewed" badges.

package/dist/api/routes/threads.js

@@ -1,4 +1,5 @@
 import { getThreadDetail } from '../../db/queries.js';
+import { hydrateThreadDetail } from '../../sync/hydrate-detail.js';
 import { accountIdOf } from '../plugins/auth.js';
 const idParamSchema = {
     params: {
@@ -10,12 +11,13 @@ const idParamSchema = {
 export async function threadRoutes(app) {
     app.get('/api/threads/:id', { schema: idParamSchema }, async (req, reply) => {
         const { id } = req.params;
-        const thread = await getThreadDetail(id, accountIdOf(req));
+        const accountId = accountIdOf(req);
+        const thread = await getThreadDetail(id, accountId);
         if (!thread) {
             reply.status(404);
             return { error: 'NotFound', message: `Thread ${id} not found` };
         }
-        return thread;
+        return hydrateThreadDetail(thread, accountId);
     });
 }
 //# sourceMappingURL=threads.js.map

package/dist/config.js

@@ -52,6 +52,18 @@ export const config = {
     isCloud,
     // Drives the DB driver + schema selection in client.ts.
     dbDialect: (isCloud ? 'postgres' : 'sqlite'),
+    // ---- Lean storage (both modes by default) ----
+    // When false (the default), sync does NOT persist bulky user-authored text —
+    // comment / review / PR bodies, review-comment diff hunks, commit messages, and
+    // the per-job checkRuns JSON (the ci_status summary enum is kept). That text is
+    // regenerable from GitHub (and duplicated per tenant in cloud), so it's the
+    // dominant storage cost; it's hydrated on demand when a PR/thread is opened
+    // (sync/hydrate-detail.ts, via the gh-CLI token locally or the OAuth token in
+    // cloud) and cached in the browser. Not storing it also shrinks the DB and the
+    // sync payload, speeding up an initial backfill. Set PERSIST_BODIES=true to store
+    // full bodies instead — instant, fully-offline detail at the cost of a larger DB
+    // (e.g. a local instance used without network).
+    persistBodies: process.env.PERSIST_BODIES === 'true',
     // Postgres connection string (cloud only). Empty in local mode.
     databaseUrl: process.env.DATABASE_URL ?? '',
     port: intFromEnv('PORT', 4000),

package/dist/db/cleanup.js

@@ -1,5 +1,6 @@
 import { and, eq, inArray, isNull, or, sql } from 'drizzle-orm';
 import { db, schema } from './client.js';
+import { config } from '../config.js';
 // One-time / idempotent maintenance run at startup.
 //
 // GitHub wraps inline-only reviews in an empty "commented" review, which the
@@ -12,6 +13,14 @@ import { db, schema } from './client.js';
 // Written as portable drizzle (no raw better-sqlite3 / db.execute) so it runs on
 // both dialects; the count comes from `.returning().length` (dialect-neutral).
 export async function cleanupRedundantReviewEvents() {
+    // In cloud "lean storage" mode (config.persistBodies false) reviews.body is
+    // always null, so the body-emptiness signal this relies on is unavailable — and
+    // unnecessary: persistPr already only emits review_submitted for *substantive*
+    // reviews (it checks the in-memory GraphQL body, not the stored one), and cloud
+    // starts empty, so there are no wrapper events to remove. Skipping here avoids
+    // wrongly deleting markers for substantive "commented" reviews.
+    if (!config.persistBodies)
+        return 0;
     const { events, reviews } = schema;
     const emptyCommentedReviews = db
         .select({ id: reviews.id })

package/dist/db/migrations/0009_lean_bodies.sql

@@ -0,0 +1,13 @@
+-- Lean cloud storage groundwork (additive).
+--
+-- Adds review_comments.excerpt: a short (~160 char) preview of the comment body,
+-- kept even when the full body is dropped in cloud "lean storage" mode so the
+-- triage path (getMyTurn / getThreadsAwaiting) and graceful UI degradation work
+-- without a network round trip. Local mode still stores the full body.
+--
+-- Note: in the Drizzle schema review_comments.body / pr_comments.body are now
+-- nullable (to allow cloud's lean Postgres rows to omit them). SQLite cannot drop
+-- a NOT NULL via ALTER, but local mode always persists bodies (config.persistBodies
+-- is true whenever the driver is sqlite), so the live NOT NULL constraint is never
+-- exercised — only the additive column below is needed here.
+ALTER TABLE `review_comments` ADD `excerpt` text;

package/dist/db/migrations/0010_lean_bodies_nullable.sql

@@ -0,0 +1,56 @@
+-- Make review_comments.body and pr_comments.body NULLABLE for lean storage
+-- (config.persistBodies false, now the default in both modes): the full body is
+-- dropped from storage and hydrated on demand, leaving review_comments.excerpt
+-- (from 0009) as the kept preview. SQLite can't drop a NOT NULL via ALTER, so the
+-- two tables are rebuilt. This is safe: no other table has a foreign key pointing
+-- at them, and the copied data already satisfies their own (unchanged) outbound
+-- FKs. The rebuilt tables keep the excerpt column and every current index.
+CREATE TABLE `__new_review_comments` (
+	`id` integer PRIMARY KEY AUTOINCREMENT NOT NULL,
+	`github_node_id` text NOT NULL,
+	`thread_id` integer NOT NULL,
+	`pr_id` integer NOT NULL,
+	`author_id` integer,
+	`body` text,
+	`excerpt` text,
+	`diff_hunk` text,
+	`database_id` text,
+	`created_at` integer NOT NULL,
+	FOREIGN KEY (`thread_id`) REFERENCES `review_threads`(`id`) ON UPDATE no action ON DELETE no action,
+	FOREIGN KEY (`pr_id`) REFERENCES `pull_requests`(`id`) ON UPDATE no action ON DELETE no action,
+	FOREIGN KEY (`author_id`) REFERENCES `users`(`id`) ON UPDATE no action ON DELETE no action
+);
+--> statement-breakpoint
+INSERT INTO `__new_review_comments` (`id`, `github_node_id`, `thread_id`, `pr_id`, `author_id`, `body`, `excerpt`, `diff_hunk`, `database_id`, `created_at`)
+	SELECT `id`, `github_node_id`, `thread_id`, `pr_id`, `author_id`, `body`, `excerpt`, `diff_hunk`, `database_id`, `created_at` FROM `review_comments`;
+--> statement-breakpoint
+DROP TABLE `review_comments`;
+--> statement-breakpoint
+ALTER TABLE `__new_review_comments` RENAME TO `review_comments`;
+--> statement-breakpoint
+CREATE INDEX `rc_thread_idx` ON `review_comments` (`thread_id`);
+--> statement-breakpoint
+CREATE UNIQUE INDEX `rc_pr_node` ON `review_comments` (`pr_id`,`github_node_id`);
+--> statement-breakpoint
+CREATE TABLE `__new_pr_comments` (
+	`id` integer PRIMARY KEY AUTOINCREMENT NOT NULL,
+	`github_node_id` text NOT NULL,
+	`pr_id` integer NOT NULL,
+	`author_id` integer,
+	`body` text,
+	`database_id` text,
+	`created_at` integer NOT NULL,
+	FOREIGN KEY (`pr_id`) REFERENCES `pull_requests`(`id`) ON UPDATE no action ON DELETE no action,
+	FOREIGN KEY (`author_id`) REFERENCES `users`(`id`) ON UPDATE no action ON DELETE no action
+);
+--> statement-breakpoint
+INSERT INTO `__new_pr_comments` (`id`, `github_node_id`, `pr_id`, `author_id`, `body`, `database_id`, `created_at`)
+	SELECT `id`, `github_node_id`, `pr_id`, `author_id`, `body`, `database_id`, `created_at` FROM `pr_comments`;
+--> statement-breakpoint
+DROP TABLE `pr_comments`;
+--> statement-breakpoint
+ALTER TABLE `__new_pr_comments` RENAME TO `pr_comments`;
+--> statement-breakpoint
+CREATE INDEX `prc_pr_idx` ON `pr_comments` (`pr_id`);
+--> statement-breakpoint
+CREATE UNIQUE INDEX `prc_pr_node` ON `pr_comments` (`pr_id`,`github_node_id`);

package/dist/db/migrations/meta/_journal.json

@@ -64,6 +64,20 @@
       "when": 1780700000000,
       "tag": "0008_multitenant_accounts",
       "breakpoints": true
+    },
+    {
+      "idx": 9,
+      "version": "6",
+      "when": 1780800000000,
+      "tag": "0009_lean_bodies",
+      "breakpoints": true
+    },
+    {
+      "idx": 10,
+      "version": "6",
+      "when": 1780800000001,
+      "tag": "0010_lean_bodies_nullable",
+      "breakpoints": true
     }
   ]
 }

package/dist/db/migrations-pg/0001_dizzy_mockingbird.sql

@@ -0,0 +1,3 @@
+ALTER TABLE "pr_comments" ALTER COLUMN "body" DROP NOT NULL;--> statement-breakpoint
+ALTER TABLE "review_comments" ALTER COLUMN "body" DROP NOT NULL;--> statement-breakpoint
+ALTER TABLE "review_comments" ADD COLUMN "excerpt" text;