pierre-review 0.1.27 → 0.1.29

package/dist/api/plugins/auth.js

@@ -27,6 +27,7 @@ export function registerAccountContext(app) {
                     id: LOCAL_ACCOUNT_ID,
                     githubUserId: '',
                     githubLogin: '',
+                    displayName: null,
                     avatarUrl: null,
                     isLocal: true,
                 };

package/dist/api/routes/auth.js

@@ -92,6 +92,7 @@ export async function authRoutes(app) {
         const account = await upsertCloudAccount({
             githubUserId: user.node_id,
             githubLogin: user.login,
+            displayName: user.name ?? null,
             avatarUrl: user.avatar_url,
             accessTokenEnc: encryptToken(token),
         });

package/dist/api/routes/claude-review.js

@@ -4,7 +4,7 @@ import { markFindingPosted, markReviewPosted, updateFinding, updateReviewDraft,
 import { getReviewStatus, listActiveReviews, requestReviewCancel, startReview, } from '../../review/review-manager.js';
 import { detectClaudeAuth } from '../../review/auth.js';
 import { hasUserAnthropicKey, setUserAnthropicKey, } from '../../review/local-settings.js';
-import { buildAnchorIndex, buildReview, fallbackAnchor, fetchCurrentHeadSha, fetchPrDiff, findingCommentBody, stripNoiseFromDiff, submitGithubComment, submitGithubReview, } from '../../review/post-review.js';
+import { buildAnchorIndex, buildReview, fallbackAnchor, fetchCurrentHeadSha, fetchPrDiff, findingCommentBody, prLevelFindingBody, stripNoiseFromDiff, submitGithubComment, submitGithubIssueComment, submitGithubReview, } from '../../review/post-review.js';
 import { isNoiseFile } from '../../review/prompt.js';
 import { accountIdOf } from '../plugins/auth.js';
 const MODELS = ['claude-opus-4-8', 'claude-sonnet-4-6'];
@@ -233,8 +233,12 @@ export async function claudeReviewRoutes(app) {
         }
         return { status: 'ok' };
     });
-    // Post a single anchored finding as a standalone inline comment (no review
-    // submitted). Pins to the run's head SHA; 409 if the PR head has since moved.
+    // Post a single finding as a standalone comment (no review submitted). The
+    // destination is chosen AUTOMATICALLY from the live diff: anchorable on its own
+    // line → an inline comment there; unanchored but its file is in the diff → an
+    // inline comment on the file's first change; its file is NOT in the diff (e.g. a
+    // deep review on an unchanged file) → a standalone PR-level comment marked as
+    // outside the PR's diff. Pins to the run's head SHA; 409 if the PR head has moved.
     app.post('/api/claude-findings/:findingId/post', { schema: findingIdParam }, async (req, reply) => {
         if (!config.claudeReviewEnabled)
             return featureOff(reply);
@@ -254,47 +258,61 @@ export async function claudeReviewRoutes(app) {
                     message: 'The PR head has moved since this review. Re-review before posting.',
                 };
             }
-            // Anchor: the finding's own line if addable, else the file's first change
-            // (added preferred). A finding whose file isn't in the diff can't inline.
-            let line;
-            let side = f.side;
-            let onFallback = false;
+            const postedAt = new Date().toISOString();
+            // Anchorable on its own line → inline comment there.
             if (f.line != null && f.anchored) {
-                line = f.line;
+                const { commentId } = await submitGithubComment({
+                    owner: ctx.owner,
+                    name: ctx.name,
+                    prNumber: ctx.prNumber,
+                    commitId: ctx.reviewHeadSha,
+                    path: f.path,
+                    line: f.line,
+                    side: f.side,
+                    body: findingCommentBody({
+                        body: f.body,
+                        editedBody: f.editedBody,
+                        suggestion: f.suggestion,
+                    }),
+                });
+                await markFindingPosted(findingId, commentId, 'inline');
+                const result = { githubCommentId: commentId, postedAt };
+                return result;
             }
-            else {
-                const { diff } = stripNoiseFromDiff(await fetchPrDiff(ctx.owner, ctx.name, ctx.prNumber), isNoiseFile);
-                const fb = fallbackAnchor(buildAnchorIndex(diff), f.path);
-                if (!fb) {
-                    reply.status(400);
-                    return {
-                        error: 'NotAnchored',
-                        message: "This finding's file has no changes in the PR diff, so it can't post inline.",
-                    };
-                }
-                line = fb.line;
-                side = fb.side;
-                onFallback = true;
+            // Otherwise consult the diff. If the file IS in the diff, re-anchor to its
+            // first change (inline). If it isn't, post a standalone PR-level comment.
+            const { diff } = stripNoiseFromDiff(await fetchPrDiff(ctx.owner, ctx.name, ctx.prNumber), isNoiseFile);
+            const fb = fallbackAnchor(buildAnchorIndex(diff), f.path);
+            if (fb) {
+                const { commentId } = await submitGithubComment({
+                    owner: ctx.owner,
+                    name: ctx.name,
+                    prNumber: ctx.prNumber,
+                    commitId: ctx.reviewHeadSha,
+                    path: f.path,
+                    line: fb.line,
+                    side: fb.side,
+                    body: findingCommentBody({ body: f.body, editedBody: f.editedBody, suggestion: f.suggestion }, { fallbackNote: true }),
+                });
+                await markFindingPosted(findingId, commentId, 'inline');
+                const result = { githubCommentId: commentId, postedAt };
+                return result;
             }
-            const { commentId } = await submitGithubComment({
+            // File outside the PR's diff → standalone PR-level (issue) comment.
+            const { commentId } = await submitGithubIssueComment({
                 owner: ctx.owner,
                 name: ctx.name,
                 prNumber: ctx.prNumber,
-                commitId: ctx.reviewHeadSha,
-                path: f.path,
-                line,
-                side,
-                body: findingCommentBody({
+                body: prLevelFindingBody({
+                    path: f.path,
+                    line: f.line,
                     body: f.body,
                     editedBody: f.editedBody,
                     suggestion: f.suggestion,
-                }, onFallback ? { fallbackNote: true } : undefined),
+                }),
             });
-            await markFindingPosted(findingId, commentId);
-            const result = {
-                githubCommentId: commentId,
-                postedAt: new Date().toISOString(),
-            };
+            await markFindingPosted(findingId, commentId, 'pr_comment');
+            const result = { githubCommentId: commentId, postedAt };
             return result;
         }
         catch (err) {
@@ -356,12 +374,36 @@ export async function claudeReviewRoutes(app) {
                 event: userVerdict,
                 comments: built.preview.comments,
             });
-            await markReviewPosted(reviewId, ghReviewId, built.postedFindingIds);
+            // The review is now LIVE on GitHub and can't be un-posted. Findings whose
+            // file isn't in the diff post as standalone PR-level comments alongside it
+            // (one issue comment each), so a deep review's findings on unchanged files
+            // still land rather than being dropped. Each post is best-effort: a single
+            // failed comment must NOT strand the already-posted review (that would leave
+            // the run unstamped and tempt a duplicate re-post), so we collect what lands
+            // and ALWAYS stamp afterwards. Findings that fail simply stay un-posted and
+            // can be posted individually from their row.
+            const prCommentResults = [];
+            for (const pc of built.preview.prComments) {
+                try {
+                    const { commentId } = await submitGithubIssueComment({
+                        owner: ctx.owner,
+                        name: ctx.name,
+                        prNumber: ctx.prNumber,
+                        body: pc.body,
+                    });
+                    prCommentResults.push({ findingId: pc.findingId, commentId });
+                }
+                catch (err) {
+                    req.log.warn({ err, findingId: pc.findingId, path: pc.path }, 'failed to post a PR-level comment for an off-diff finding');
+                }
+            }
+            await markReviewPosted(reviewId, ghReviewId, built.inlineFindingIds, prCommentResults);
             const result = {
                 postedReviewId: ghReviewId,
                 postedAt: new Date().toISOString(),
                 postedCommentCount: built.preview.comments.length,
-                skippedUnanchored: built.preview.skippedUnanchored,
+                // Count what actually posted (a comment may have failed best-effort above).
+                prCommentCount: prCommentResults.length,
             };
             return result;
         }

package/dist/auth/account.js

@@ -15,6 +15,7 @@ function fetchFromGh() {
         return {
             login: parsed.login,
             node_id: parsed.node_id,
+            name: parsed.name ?? null,
             avatar_url: parsed.avatar_url ?? null,
         };
     }
@@ -28,6 +29,7 @@ function rowToAccount(row) {
         id: row.id,
         githubUserId: row.githubUserId,
         githubLogin: row.githubLogin,
+        displayName: row.displayName,
         avatarUrl: row.avatarUrl,
         isLocal: row.isLocal,
     };
@@ -53,7 +55,11 @@ export async function ensureLocalAccount() {
     const fresh = existing &&
         existing.githubUserId !== '' &&
         existing.lastLoginAt != null &&
-        Date.now() - existing.lastLoginAt.getTime() < STALE_MS;
+        Date.now() - existing.lastLoginAt.getTime() < STALE_MS &&
+        // Backfill the display name on the first run after it was added (older rows have
+        // it NULL). A genuinely name-less GitHub user re-fetches each startup — cheap;
+        // the daily refresh would repopulate it anyway.
+        existing.displayName != null;
     if (existing && fresh) {
         cachedLocalAccount = rowToAccount(existing);
         return cachedLocalAccount;
@@ -70,6 +76,7 @@ export async function ensureLocalAccount() {
         id: LOCAL_ACCOUNT_ID,
         githubUserId: gh.node_id,
         githubLogin: gh.login,
+        displayName: gh.name,
         avatarUrl: gh.avatar_url,
         isLocal: true,
         lastLoginAt: new Date(),
@@ -79,6 +86,7 @@ export async function ensureLocalAccount() {
         set: {
             githubUserId: gh.node_id,
             githubLogin: gh.login,
+            displayName: gh.name,
             avatarUrl: gh.avatar_url,
             isLocal: true,
             lastLoginAt: new Date(),
@@ -106,6 +114,7 @@ export async function upsertCloudAccount(input) {
         .values({
         githubUserId: input.githubUserId,
         githubLogin: input.githubLogin,
+        displayName: input.displayName,
         avatarUrl: input.avatarUrl,
         accessTokenEnc: input.accessTokenEnc,
         isLocal: false,
@@ -118,6 +127,7 @@ export async function upsertCloudAccount(input) {
         target: accounts.githubUserId,
         set: {
             githubLogin: input.githubLogin,
+            displayName: input.displayName,
             avatarUrl: input.avatarUrl,
             accessTokenEnc: input.accessTokenEnc,
             lastLoginAt: now,
@@ -218,6 +228,7 @@ export function accountToLocalUser(account) {
         login: account.githubLogin,
         githubId: account.githubUserId,
         avatarUrl: account.avatarUrl,
+        displayName: account.displayName,
     };
 }
 //# sourceMappingURL=account.js.map

package/dist/db/migrations/0017_account_display_name.sql

@@ -0,0 +1,7 @@
+-- The signed-in user's GitHub display name (additive). `display_name` captures the
+-- `name` field from `gh api user` (local) / OAuth `GET /user` (cloud), shown wherever
+-- the logged-in identity appears (header, greeting) in place of the @login. Nullable;
+-- existing rows stay NULL until the next identity refresh repopulates them (local:
+-- ensureLocalAccount refetches when display_name is NULL; cloud: on next sign-in).
+-- Postgres baseline is regenerated separately via db:generate:pg.
+ALTER TABLE `accounts` ADD `display_name` text;

package/dist/db/migrations/0018_finding_comment_kind.sql

@@ -0,0 +1,7 @@
+-- Records how a posted Claude-review finding was attached to the PR (additive):
+-- 'inline' = a review comment on a diff line, 'pr_comment' = a standalone PR-level
+-- issue comment (used when the user posts an UNANCHORED finding individually rather
+-- than forcing it onto a diff line). Null until posted; the UI uses it to build the
+-- correct GitHub permalink (#discussion_r vs #issuecomment). SQLite-only — Claude
+-- Review is force-disabled in cloud, so the Postgres table is never populated.
+ALTER TABLE `claude_review_findings` ADD `posted_comment_kind` text;

package/dist/db/migrations/0019_finding_file_in_diff.sql

@@ -0,0 +1,7 @@
+-- Whether a Claude-review finding's file is part of the PR's diff (additive). true ⇒
+-- an unanchored finding posts inline on the file's first change; false ⇒ the file is
+-- outside the PR's diff (e.g. a deep review on an unchanged file) so it posts as a
+-- standalone PR-level comment instead of being forced onto a diff line. NOT NULL
+-- DEFAULT 1 so pre-existing findings keep the inline-on-first-change behavior.
+-- SQLite-only — Claude Review is force-disabled in cloud.
+ALTER TABLE `claude_review_findings` ADD `file_in_diff` integer NOT NULL DEFAULT 1;

package/dist/db/migrations/meta/_journal.json

@@ -120,6 +120,27 @@
       "when": 1780800000007,
       "tag": "0016_repo_viewer_permission",
       "breakpoints": true
+    },
+    {
+      "idx": 17,
+      "version": "6",
+      "when": 1780800000008,
+      "tag": "0017_account_display_name",
+      "breakpoints": true
+    },
+    {
+      "idx": 18,
+      "version": "6",
+      "when": 1780800000009,
+      "tag": "0018_finding_comment_kind",
+      "breakpoints": true
+    },
+    {
+      "idx": 19,
+      "version": "6",
+      "when": 1780800000010,
+      "tag": "0019_finding_file_in_diff",
+      "breakpoints": true
     }
   ]
 }

package/dist/db/migrations-pg/0007_same_human_torch.sql

@@ -0,0 +1,2 @@
+ALTER TABLE "accounts" ADD COLUMN "display_name" text;--> statement-breakpoint
+ALTER TABLE "claude_review_findings" ADD COLUMN "posted_comment_kind" text;

package/dist/db/migrations-pg/0008_slimy_toxin.sql

@@ -0,0 +1 @@
+ALTER TABLE "claude_review_findings" ADD COLUMN "file_in_diff" boolean DEFAULT true NOT NULL;