pierre-review 0.1.20 → 0.1.22

package/dist/api/routes/timeline.js

@@ -17,6 +17,12 @@ const EVENT_TYPES = [
     'commit_pushed',
 ];
 const PR_STATUSES = ['draft', 'open', 'merged', 'closed'];
+const REVIEW_FILTER_STATES = [
+    'approved',
+    'changes_requested',
+    'commented',
+    'dismissed',
+];
 function parseIntList(raw) {
     if (!raw)
         return null;
@@ -48,6 +54,18 @@ function parseStatuses(raw) {
         .map((s) => s.trim())
         .filter((s) => allowed.has(s));
 }
+// Absent (undefined) → null = no review-verdict filter (show all). Present, even
+// empty ("") → an explicit (possibly empty) set, so deselecting every verdict hides
+// all review markers rather than falling back to "all". Mirrors parseStatuses.
+function parseReviewStates(raw) {
+    if (raw === undefined)
+        return null;
+    const allowed = new Set(REVIEW_FILTER_STATES);
+    return raw
+        .split(',')
+        .map((s) => s.trim())
+        .filter((s) => allowed.has(s));
+}
 function parseDate(raw, fallback) {
     if (!raw)
         return fallback;
@@ -66,6 +84,7 @@ export async function timelineRoutes(app) {
             userIds: parseIntList(q.userIds),
             types: parseTypes(q.types),
             statuses: parseStatuses(q.statuses),
+            reviewStates: parseReviewStates(q.reviewStates),
             excludeBots: q.excludeBots === 'true',
             excludeStale: q.excludeStale === 'true',
         };

package/dist/db/queries.js

@@ -1,5 +1,5 @@
 import { createHash } from 'node:crypto';
-import { and, asc, count, desc, eq, exists, gt, gte, inArray, isNotNull, isNull, lte, notInArray, or, sql, } from 'drizzle-orm';
+import { and, asc, count, desc, eq, exists, gt, gte, inArray, isNotNull, isNull, lte, ne, notInArray, or, sql, } from 'drizzle-orm';
 // Local copy of the shared `REASON_PRIORITY` value constant. `@pierre-review/shared`
 // is a types-only workspace package that is NOT shipped in the published tarball,
 // so the backend must only `import type` from it. Keep in sync with packages/shared.
@@ -222,7 +222,7 @@ function mapTimelinePr(p, counts, tr) {
     };
 }
 export async function getTimeline(filters) {
-    const { accountId, from, to, repoIds, userIds, types, statuses, excludeBots, excludeStale, } = filters;
+    const { accountId, from, to, repoIds, userIds, types, statuses, reviewStates, excludeBots, excludeStale, } = filters;
     // ---- PRs that overlap the window ----
     const prConds = [
         eq(pullRequests.accountId, accountId),
@@ -280,6 +280,19 @@ export async function getTimeline(filters) {
             .from(pullRequests)
             .where(and(eq(pullRequests.id, events.prId), prStatusWhere(statuses)))));
     }
+    // Review-verdict filter: keep every NON-review event; for review_submitted events,
+    // keep only those whose referenced review's state is selected. An empty selection
+    // drops all review markers (the review row exists but no verdict matches). null =
+    // no filter. Pure-reviewer rows vanish when their verdict is deselected because the
+    // event is removed here (not just hidden client-side), so no empty row lingers.
+    if (reviewStates) {
+        evConds.push(reviewStates.length === 0
+            ? ne(events.type, 'review_submitted')
+            : or(ne(events.type, 'review_submitted'), exists(db
+                .select({ x: sql `1` })
+                .from(reviews)
+                .where(and(eq(reviews.id, events.refId), eq(events.refTable, 'reviews'), inArray(reviews.state, reviewStates))))));
+    }
     // Likewise drop a stale open PR's own events (only ever lifecycle markers, since
     // by definition it has no activity events in-window) so its contributor row can
     // disappear instead of lingering empty. Keep events with no PR (defensive).
@@ -310,21 +323,40 @@ export async function getTimeline(filters) {
         for (const r of rows)
             reviewStateById.set(r.id, r.state);
     }
-    const timelineEvents = evRows.map((e) => ({
-        id: e.id,
-        repoId: e.repoId,
-        actorId: e.actorId,
-        prId: e.prId,
-        type: e.type,
-        occurredAt: e.occurredAt.toISOString(),
-        threadId: e.type === 'review_comment' && e.refTable === 'review_threads'
-            ? e.refId
-            : null,
-        refId: e.refId,
-        reviewState: e.type === 'review_submitted' && e.refTable === 'reviews' && e.refId != null
-            ? (reviewStateById.get(e.refId) ?? null)
-            : null,
-    }));
+    // Batch-load the derived state of each review_comment event's thread, so the
+    // timeline's "Threads" filter can narrow markers to a specific thread state
+    // (e.g. only resolved) instead of every comment on a PR that has a matching
+    // thread. A single keyed lookup; the thread's id is the event's refId.
+    const threadRefIds = evRows
+        .filter((e) => e.type === 'review_comment' && e.refTable === 'review_threads' && e.refId != null)
+        .map((e) => e.refId);
+    const threadStateById = new Map();
+    if (threadRefIds.length > 0) {
+        const rows = await db
+            .select({ id: reviewThreads.id, state: reviewThreads.derivedState })
+            .from(reviewThreads)
+            .where(inArray(reviewThreads.id, threadRefIds))
+            .execute();
+        for (const r of rows)
+            threadStateById.set(r.id, r.state);
+    }
+    const timelineEvents = evRows.map((e) => {
+        const threadId = e.type === 'review_comment' && e.refTable === 'review_threads' ? e.refId : null;
+        return {
+            id: e.id,
+            repoId: e.repoId,
+            actorId: e.actorId,
+            prId: e.prId,
+            type: e.type,
+            occurredAt: e.occurredAt.toISOString(),
+            threadId,
+            derivedState: threadId != null ? (threadStateById.get(threadId) ?? null) : null,
+            refId: e.refId,
+            reviewState: e.type === 'review_submitted' && e.refTable === 'reviews' && e.refId != null
+                ? (reviewStateById.get(e.refId) ?? null)
+                : null,
+        };
+    });
     return { prs, events: timelineEvents };
 }
 export async function getOpenPrs(filters) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pierre-review",
-  "version": "0.1.20",
+  "version": "0.1.22",
   "description": "Dashboard for tracking your team's GitHub PR activity across repos — local (SQLite + gh) or self-hosted multi-tenant cloud (Postgres + GitHub App).",
   "type": "module",
   "author": "Alex Wakeman",