pierre-review 0.1.10 → 0.1.12

package/dist/api/routes/auth.js

@@ -26,6 +26,14 @@ export async function authRoutes(app) {
     // Verify state → exchange code for a token → fetch the user → upsert account →
     // set session → 302 to the app.
     app.get('/api/auth/callback', async (req, reply) => {
+        // Already signed in? The callback URL carries a one-time ?code= that GitHub
+        // expires in ~10 min and invalidates on first use. A back-button, a restored
+        // tab, or a Chrome profile switch can re-request this exact URL; re-running the
+        // exchange would then fail on the already-consumed code ("code incorrect or
+        // expired"). Short-circuit a valid session straight to the app instead.
+        if (req.session.get('accountId') != null) {
+            return reply.redirect('/app');
+        }
         const { code, state } = req.query;
         const rawCookie = req.cookies.pierre_oauth_state;
         const unsigned = rawCookie
@@ -33,9 +41,9 @@ export async function authRoutes(app) {
             : { valid: false, value: null };
         reply.clearCookie('pierre_oauth_state', { path: '/' });
         if (!code || !state || !unsigned.valid || unsigned.value !== state) {
-            return reply
-                .code(400)
-                .send({ error: 'BadRequest', message: 'Invalid or expired OAuth state.' });
+            // Stale/replayed callback (state cookie expired or CSRF mismatch). Bounce
+            // back so the user starts a fresh sign-in — never render raw JSON to a human.
+            return reply.redirect('/app?auth=expired');
         }
         // Exchange the code for a user access token.
         let token;
@@ -52,18 +60,14 @@ export async function authRoutes(app) {
             });
             const json = (await res.json());
             if (!json.access_token) {
-                return reply.code(401).send({
-                    error: 'Unauthorized',
-                    message: `OAuth token exchange failed: ${json.error_description ?? json.error ?? 'no token'}`,
-                });
+                req.log.warn({ err: json.error_description ?? json.error }, 'oauth token exchange returned no token');
+                return reply.redirect('/app?auth=failed');
             }
             token = json.access_token;
         }
         catch (err) {
-            return reply.code(502).send({
-                error: 'GitHubError',
-                message: `OAuth exchange request failed: ${err instanceof Error ? err.message : err}`,
-            });
+            req.log.error({ err }, 'oauth token exchange request failed');
+            return reply.redirect('/app?auth=error');
         }
         // Identify the user.
         let user;
@@ -76,17 +80,14 @@ export async function authRoutes(app) {
                 },
             });
             if (!res.ok) {
-                return reply
-                    .code(401)
-                    .send({ error: 'Unauthorized', message: 'Failed to fetch GitHub user.' });
+                req.log.warn({ status: res.status }, 'failed to fetch github user');
+                return reply.redirect('/app?auth=failed');
             }
             user = (await res.json());
         }
         catch (err) {
-            return reply.code(502).send({
-                error: 'GitHubError',
-                message: `Fetching GitHub user failed: ${err instanceof Error ? err.message : err}`,
-            });
+            req.log.error({ err }, 'fetching github user failed');
+            return reply.redirect('/app?auth=error');
         }
         const account = await upsertCloudAccount({
             githubUserId: user.node_id,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pierre-review",
-  "version": "0.1.10",
+  "version": "0.1.12",
   "description": "Dashboard for tracking your team's GitHub PR activity across repos — local (SQLite + gh) or self-hosted multi-tenant cloud (Postgres + GitHub App).",
   "type": "module",
   "author": "Alex Wakeman",