pict-section-recordset 1.20.0 → 1.21.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pict-section-recordset",
-  "version": "1.20.0",
+  "version": "1.21.1",
   "description": "Pict dynamic record set management views",
   "main": "source/Pict-Section-RecordSet.js",
   "files": [

package/source/providers/RecordSet-AssociationManager.js

@@ -395,6 +395,32 @@ class PictRecordSetAssociationManager extends libPictProvider
 	 * @param {string|number} pThisID
 	 * @return {Promise<Array<any>>}
 	 */
+	/**
+	 * Does this join row reference a real other-side record? An unset key (undefined / null / '') is
+	 * not an association; nor is 0 / '0' on an id-keyed side, where 0 is never a real auto-increment id
+	 * (Meadow ids start at 1). Some hosts park sentinel rows in the join table — e.g. a "default set"
+	 * keyed by IDProject = 0 that a SynthesizeDefaults hook reads — and those must not surface as broken
+	 * "#0" rows in the editor. The 0-guard is gated to id-keyed sides (JoinField === IDField) so a
+	 * name-keyed side, where '0' could pathologically be a real key, is never affected.
+	 *
+	 * @param {Record<string, any>} pJoin - a join row.
+	 * @param {Record<string, any>} pOtherSide - the resolved other side.
+	 * @return {Boolean}
+	 */
+	_joinReferencesRealRecord(pJoin, pOtherSide)
+	{
+		const tmpValue = pJoin[pOtherSide.JoinField];
+		if ((tmpValue === undefined) || (tmpValue === null) || (tmpValue === ''))
+		{
+			return false;
+		}
+		if ((pOtherSide.JoinField === pOtherSide.IDField) && ((tmpValue === 0) || (tmpValue === '0')))
+		{
+			return false;
+		}
+		return true;
+	}
+
 	async listAssociatedIDs(pAssociationHash, pThisRecordSetName, pThisID)
 	{
 		const tmpSides = this.resolveSides(pAssociationHash, pThisRecordSetName);
@@ -404,8 +430,8 @@ class PictRecordSetAssociationManager extends libPictProvider
 		}
 		const tmpJoins = await this.listJoinRecords(pAssociationHash, pThisRecordSetName, pThisID);
 		return tmpJoins
-			.map((pJoin) => pJoin[tmpSides.otherSide.JoinField])
-			.filter((pValue) => (pValue !== undefined && pValue !== null && pValue !== ''));
+			.filter((pJoin) => this._joinReferencesRealRecord(pJoin, tmpSides.otherSide))
+			.map((pJoin) => pJoin[tmpSides.otherSide.JoinField]);
 	}
 
 	/**
@@ -428,9 +454,10 @@ class PictRecordSetAssociationManager extends libPictProvider
 		}
 		const tmpJoinIDField = this.getJoinIDField(tmpSides.association);
 		const tmpJoins = await this.listJoinRecords(pAssociationHash, pThisRecordSetName, pThisID);
-		const tmpOtherIDs = tmpJoins
-			.map((pJoin) => pJoin[tmpSides.otherSide.JoinField])
-			.filter((pValue) => (pValue !== undefined && pValue !== null && pValue !== ''));
+		// Drop sentinel / unset rows (e.g. a "default set" keyed by other-side id 0) so they don't
+		// surface as broken "#0" rows; everything downstream works off the real-association set.
+		const tmpRealJoins = tmpJoins.filter((pJoin) => this._joinReferencesRealRecord(pJoin, tmpSides.otherSide));
+		const tmpOtherIDs = tmpRealJoins.map((pJoin) => pJoin[tmpSides.otherSide.JoinField]);
 
 		let tmpByID = {};
 		if (tmpOtherIDs.length > 0)
@@ -455,8 +482,7 @@ class PictRecordSetAssociationManager extends libPictProvider
 			}
 		}
 
-		return tmpJoins
-			.filter((pJoin) => (pJoin[tmpSides.otherSide.JoinField] !== undefined && pJoin[tmpSides.otherSide.JoinField] !== null && pJoin[tmpSides.otherSide.JoinField] !== ''))
+		return tmpRealJoins
 			.map((pJoin) =>
 			{
 				const tmpOtherID = pJoin[tmpSides.otherSide.JoinField];

package/source/views/associate/RecordSet-AssociationEditor.js

@@ -31,6 +31,12 @@ const _DEFAULT_CONFIGURATION_AssociationEditor = (
 		DefaultDestinationAddress: '#PRSP_AssociationEditor_Container',
 		DefaultTemplateRecordAddress: false,
 
+		// Show the "Add defaults" affordance when the association has a defaults synthesizer. Set false
+		// on an instance where synthesis is directionally meaningless (e.g. anchored on the type side of
+		// a "seed a project with default types" synthesizer) — the synthesizer stays registered for the
+		// side it applies to; this just hides the button on the side it does not.
+		AllowSynthesize: true,
+
 		AutoInitialize: false,
 		AutoInitializeOrdinal: 0,
 		AutoRender: false,
@@ -265,8 +271,10 @@ class viewRecordSetAssociationEditor extends libPictView
 			// One-or-zero-element slot drives the empty-state line (TS parses inner tags; NE would not).
 			EmptySlot: (tmpItems.length === 0) ? [ { EmptyText: `No ${tmpOtherLabel} associated yet — use the search above to add some.` } ] : [],
 			PickerMissing: !tmpPickerPresent,
-			// The "Add defaults" button shows only when the host registered a defaults synthesizer.
-			SynthesizeSlot: this.manager.hasDefaultSynthesizer(this.options.AssociationHash) ? [ { ViewHash: this.Hash } ] : [],
+			// The "Add defaults" button shows only when the host registered a defaults synthesizer AND this
+			// instance opts in (AllowSynthesize, default true) — an embedding anchored on the side the
+			// synthesizer does not apply to sets AllowSynthesize:false to hide it.
+			SynthesizeSlot: ((this.options.AllowSynthesize !== false) && this.manager.hasDefaultSynthesizer(this.options.AssociationHash)) ? [ { ViewHash: this.Hash } ] : [],
 		};
 
 		return new Promise((resolve) =>

package/source/views/read/RecordSet-Read.js

@@ -59,6 +59,18 @@ const _DEFAULT_CONFIGURATION__Read = (
 			.prsp-record-read input.input[readonly], .prsp-record-read input.input[disabled], .prsp-record-read textarea[readonly], .prsp-record-read textarea[disabled], .prsp-record-read select[disabled] { background: transparent !important; border-color: transparent !important; box-shadow: none !important; padding-left: 0 !important; padding-right: 0 !important; height: auto !important; min-height: 0 !important; opacity: 1 !important; cursor: default !important; color: var(--theme-color-text-primary, #1f2733) !important; -webkit-text-fill-color: var(--theme-color-text-primary, #1f2733) !important; font-weight: 600 !important; font-size: 1.1rem !important; }
 			.prsp-record-read .label { font-size: 0.68rem !important; font-weight: 600 !important; text-transform: uppercase !important; letter-spacing: 0.05em !important; color: var(--theme-color-text-muted, #6b7686) !important; margin-bottom: 0.05rem !important; }
 			.prsp-record-read .section-header { background: var(--theme-color-background-selected, #e3edfb) !important; color: var(--theme-color-brand-primary, #156dd1) !important; font-size: 0.74rem !important; font-weight: 700 !important; text-transform: uppercase !important; letter-spacing: 0.06em !important; padding: 0.4rem 0.8rem !important; border-radius: 6px !important; border-bottom: 0 !important; margin: 1.1rem 0 0.7rem !important; }
+				/* Record header — a readable title (the record's own name, via a heuristic) with the entity
+				   type as an eyebrow, instead of a raw "RecordSet GUIDField [guid]" string. */
+			.prsp-read-head { margin: 0 0 1.1rem; }
+			.prsp-read-eyebrow { font-size: 0.72rem; font-weight: 650; text-transform: uppercase; letter-spacing: 0.06em; color: var(--theme-color-text-muted, #6b7686); }
+			.prsp-read-title { font-size: 1.5rem; font-weight: 700; line-height: 1.2; margin: 0.1rem 0 0; color: var(--theme-color-text-primary, #1f2733); }
+				/* Read-view association tabs — pill nav, shared by the Tab and Split layouts (single source;
+				   layouts style only their own nav container). */
+			.psrs-tab { padding: 0.4rem 0.85rem; border: 1px solid var(--theme-color-border-default, #d7dce3); border-radius: 8px; cursor: pointer; font-size: 0.88rem; color: var(--theme-color-text-secondary, #45505f); background: var(--theme-color-background-panel, #fff); user-select: none; transition: all 0.15s ease; }
+			.psrs-tab:hover { background: var(--theme-color-background-tertiary, #eceef2); color: var(--theme-color-text-primary, #1f2733); }
+			.psrs-tab.is-active { border-color: var(--theme-color-brand-primary, #156dd1); background: var(--theme-color-background-selected, #e3edfb); color: var(--theme-color-brand-primary, #156dd1); font-weight: 600; }
+			.psrs-tab-body { display: none; }
+			.psrs-tab-body.is-active { display: block; }
 		`,
 		CSSPriority: 500,
 
@@ -119,11 +131,22 @@ const _DEFAULT_CONFIGURATION__Read = (
 					Hash: 'PRSP-Read-RecordTabNav-Template',
 					Template: /*html*/`<!-- Placeholder for tabs, something has gone wrong if this comment is rendered. -->`
 				},
+				{
+					// Readable record header, shared by all three layouts: the record's display name (heuristic)
+					// over a small entity-type eyebrow, falling back to the GUID field + value when the record
+					// has no obvious name. DisplayTitle / TitleEyebrow are computed in renderRead().
+					Hash: 'PRSP-Read-Header-Template',
+					Template: /*html*/`
+						<div class="prsp-read-head">
+							<div class="prsp-read-eyebrow">{~D:Record.TitleEyebrow~}</div>
+							<h1 class="prsp-read-title">{~D:Record.DisplayTitle~}</h1>
+						</div>`
+				},
 				{
 					Hash: 'PRSP-Read-Basic-Template',
 					Template: /*html*/`
 						<!-- DefaultPackage pict view template: [PRSP-Read-Basic-Template] -->
-						<h1>{~D:Record.RecordSet~} {~D:Record.GUIDAddress~} [{~D:Record.RecordConfiguration.GUIDRecord~}]</h1>
+						{~T:PRSP-Read-Header-Template~}
 						<!--
 						{~DJ:Record~}
 						-->
@@ -156,7 +179,7 @@ const _DEFAULT_CONFIGURATION__Read = (
 							.psrs-split-view.psrs-collapsed #psrs-resize { display: none; }
 							.psrs-split-view.psrs-collapsed .psrs-left-panel { min-width: 100% !important; width: 100%; }
 						</style>
-						<h1>{~D:Record.RecordSet~} {~D:Record.GUIDAddress~} [{~D:Record.RecordConfiguration.GUIDRecord~}]</h1>
+						{~T:PRSP-Read-Header-Template~}
 						<div class="psrs-split-tabnav">{~T:PRSP-Read-RecordTabNav-Template~}</div>
 						<div class="psrs-split-view psrs-collapsed">
 							<div class="psrs-left-panel" style="min-width: {~D:Record.SplitLeftWidth~};">
@@ -174,36 +197,14 @@ const _DEFAULT_CONFIGURATION__Read = (
 					Hash: 'PRSP-Read-Tab-Template',
 					Template: /*html*/`
 						<!-- DefaultPackage pict view template: [PRSP-Read-Tab-Template] -->
-						<h1>{~D:Record.RecordSet~} {~D:Record.GUIDAddress~} [{~D:Record.RecordConfiguration.GUIDRecord~}]</h1>
+						{~T:PRSP-Read-Header-Template~}
 						<!--
 						{~DJ:Record~}
 						-->
 						<style>
-							#PRSP-Read-Tab-Nav
-							{
-								display: flex;
-								border-bottom: 1px solid rgba(0,0,0,0.5);
-								margin-bottom: 20px;
-								width: 100%;
-							}
-							.psrs-tab.is-active
-							{
-								border: 1px solid rgba(0,0,0,0.5);
-							}
-							.psrs-tab
-							{
-								padding: 10px;
-								border-right: 1px solid rgba(0,0,0,0.5);
-								border-left: 1px solid rgba(0,0,0,0.5);
-							}
-							.psrs-tab-body
-							{
-								display: none;
-							}
-							.psrs-tab-body.is-active
-							{
-								display: inherit;
-							}
+							/* Tab layout owns only its nav container; the pill styling for .psrs-tab /
+							   .psrs-tab-body is shared from the view's persistent CSS block. */
+							#PRSP-Read-Tab-Nav { display: flex; flex-wrap: wrap; gap: 0.35rem; width: 100%; margin: 0 0 1.25rem; padding-bottom: 0.5rem; border-bottom: 1px solid var(--theme-color-border-light, #e8ebf0); }
 						</style>
 						<div class="psrs-tab-view">
 							<div id="PRSP-Read-Tabs-Container">
@@ -821,6 +822,14 @@ class viewRecordSetRead extends libPictRecordSetRecordView
 			`);
 		}
 
+		// Readable record header: the record's own name (heuristic — Name / Title / DisplayName / …),
+		// with the entity type (camelCase split) as an eyebrow. Falls back to the GUID field + value
+		// when the record has no obvious display field. Computed before onBeforeRenderRead so apps can
+		// still override DisplayTitle / TitleEyebrow there.
+		const tmpReadableName = this._computeDisplayName(tmpRecordReadData.Record);
+		tmpRecordReadData.DisplayTitle = tmpReadableName || `${ tmpRecordReadData.GUIDAddress } [${ pRecordConfiguration.GUIDRecord }]`;
+		tmpRecordReadData.TitleEyebrow = String(pRecordConfiguration.RecordSet || '').replace(/([a-z0-9])([A-Z])/g, '$1 $2');
+
 		tmpRecordReadData = this.onBeforeRenderRead(tmpRecordReadData);
 
 		this.renderAsync(`PRSP_Renderable_Read_${ this.layoutType }`, tmpRecordReadData.RenderDestination, tmpRecordReadData,