pict-section-flow 1.4.0 → 2.0.0

package/test/Renderer_tests.js

@@ -1,133 +0,0 @@
-const libFable = require('fable');
-const libChai = require('chai');
-const libExpect = libChai.expect;
-
-const libRenderer = require('../source/providers/PictProvider-Flow-Renderer.js');
-
-suite('PictProvider-Flow-Renderer',
-function ()
-{
-	let _Fable;
-	let _Renderer;
-
-	setup(function ()
-	{
-		_Fable = new libFable({});
-		_Renderer = new libRenderer(_Fable, {}, 'Renderer-Test');
-	});
-
-	suite('Built-in renderer registry', function ()
-	{
-		test('registers clean, bracket, sketch, crt, workstation by default', function ()
-		{
-			let tmpKeys = _Renderer.getRendererKeys();
-			libExpect(tmpKeys).to.include('clean');
-			libExpect(tmpKeys).to.include('bracket');
-			libExpect(tmpKeys).to.include('sketch');
-			libExpect(tmpKeys).to.include('crt');
-			libExpect(tmpKeys).to.include('workstation');
-		});
-
-		test('clean is the default active renderer', function ()
-		{
-			libExpect(_Renderer.getActiveRendererKey()).to.equal('clean');
-		});
-
-		test('each built-in renderer has the required shape', function ()
-		{
-			let tmpKeys = _Renderer.getRendererKeys();
-			for (let i = 0; i < tmpKeys.length; i++)
-			{
-				let tmpR = _Renderer.getActiveRenderer.call(
-					{ _Renderers: _Renderer._Renderers, _ActiveRendererKey: tmpKeys[i] });
-				libExpect(tmpR, `renderer ${tmpKeys[i]}`).to.have.property('Key', tmpKeys[i]);
-				libExpect(tmpR).to.have.property('NodeBodyMode');
-				libExpect(tmpR).to.have.property('NoiseConfig');
-				libExpect(tmpR).to.have.property('ConnectionConfig');
-				libExpect(tmpR).to.have.property('GeometryCSS');
-			}
-		});
-	});
-
-	suite('setRenderer()', function ()
-	{
-		test('switches the active renderer + updates noise default', function ()
-		{
-			_Renderer.setRenderer('sketch');
-			libExpect(_Renderer.getActiveRendererKey()).to.equal('sketch');
-			let tmpActive = _Renderer.getActiveRenderer();
-			libExpect(tmpActive.NodeBodyMode).to.equal('bracket');
-			libExpect(_Renderer.getNoiseLevel()).to.equal(0.4);
-		});
-
-		test('returns false for unknown renderer + leaves state unchanged', function ()
-		{
-			_Renderer.setRenderer('sketch');
-			let tmpResult = _Renderer.setRenderer('nonexistent');
-			libExpect(tmpResult).to.equal(false);
-			libExpect(_Renderer.getActiveRendererKey()).to.equal('sketch');
-		});
-
-		test('switching to a renderer with noise disabled resets noise to 0', function ()
-		{
-			_Renderer.setRenderer('sketch');   // 0.4
-			_Renderer.setRenderer('clean');    // 0
-			libExpect(_Renderer.getNoiseLevel()).to.equal(0);
-		});
-	});
-
-	suite('register()', function ()
-	{
-		test('registers a custom renderer + reads back through getActiveRenderer', function ()
-		{
-			_Renderer.register('custom', {
-				Label: 'Custom',
-				NodeBodyMode: 'rect',
-				NoiseConfig: { Enabled: false, DefaultLevel: 0, MaxJitterPx: 0, AffectsNodes: false, AffectsConnections: false },
-				ConnectionConfig: { StrokeWidth: 3, ArrowheadStyle: 'triangle' },
-				GeometryCSS: '',
-				AdditionalCSS: ''
-			});
-			let tmpResult = _Renderer.setRenderer('custom');
-			libExpect(tmpResult).to.equal(true);
-			let tmpActive = _Renderer.getActiveRenderer();
-			libExpect(tmpActive.Key).to.equal('custom');
-			libExpect(tmpActive.Label).to.equal('Custom');
-		});
-	});
-
-	suite('Noise APIs', function ()
-	{
-		test('setNoiseLevel clamps to [0,1]', function ()
-		{
-			_Renderer.setNoiseLevel(-1);
-			libExpect(_Renderer.getNoiseLevel()).to.equal(0);
-			_Renderer.setNoiseLevel(2);
-			libExpect(_Renderer.getNoiseLevel()).to.equal(1);
-			_Renderer.setNoiseLevel(0.5);
-			libExpect(_Renderer.getNoiseLevel()).to.equal(0.5);
-		});
-
-		test('getNodeNoiseAmplitude is 0 when active renderer disables noise', function ()
-		{
-			_Renderer.setRenderer('clean');
-			_Renderer.setNoiseLevel(1);
-			libExpect(_Renderer.getNodeNoiseAmplitude()).to.equal(0);
-		});
-
-		test('getNodeNoiseAmplitude scales with noise level when sketch is active', function ()
-		{
-			_Renderer.setRenderer('sketch');
-			_Renderer.setNoiseLevel(0.5);
-			// sketch.MaxJitterPx is 4 — 0.5 * 4 = 2
-			libExpect(_Renderer.getNodeNoiseAmplitude()).to.equal(2);
-		});
-
-		test('processPathString is a no-op when noise is disabled', function ()
-		{
-			_Renderer.setRenderer('clean');
-			let tmpResult = _Renderer.processPathString('M 0 0 L 10 10', 'seed');
-			libExpect(tmpResult).to.equal('M 0 0 L 10 10');
-		});
-	});
-});

package/test/SelectionManager_tests.js

@@ -1,185 +0,0 @@
-const libFable = require('fable');
-const libChai = require('chai');
-const libExpect = libChai.expect;
-
-const libSelectionManager = require('../source/services/PictService-Flow-SelectionManager.js');
-
-// A minimal FlowView stand-in: just the surface the selection manager touches.
-function makeMockFlowView(pNodes)
-{
-	let tmpFired = [];
-	let tmpRemoved = [];
-	return {
-		_FlowData:
-		{
-			Nodes: pNodes.slice(),
-			Connections: [],
-			OpenPanels: [],
-			ViewState: { SelectedNodeHash: null, SelectedNodeHashes: [], SelectedConnectionHash: null, SelectedTetherHash: null }
-		},
-		renderFlow: function () { this._rendered = (this._rendered || 0) + 1; },
-		removeNode: function (pHash) { tmpRemoved.push(pHash); this._FlowData.Nodes = this._FlowData.Nodes.filter((n) => n.Hash !== pHash); return true; },
-		removeConnection: function (pHash) { tmpRemoved.push('conn:' + pHash); return true; },
-		_EventHandlerProvider: { fireEvent: function (pName, pPayload) { tmpFired.push({ Name: pName, Payload: pPayload }); } },
-		_firedEvents: tmpFired,
-		_removed: tmpRemoved
-	};
-}
-
-function makeManager(pFable, pNodes)
-{
-	let tmpFV = makeMockFlowView(pNodes);
-	let tmpSM = new libSelectionManager(pFable, { FlowView: tmpFV }, 'SM-Test');
-	return { sm: tmpSM, fv: tmpFV, vs: tmpFV._FlowData.ViewState };
-}
-
-suite('PictService-Flow-SelectionManager',
-function ()
-{
-	let _Fable;
-	let _Nodes;
-	setup(function ()
-	{
-		_Fable = new libFable({});
-		_Nodes = [ { Hash: 'n1', X: 0, Y: 0, Width: 100, Height: 80 }, { Hash: 'n2', X: 200, Y: 0, Width: 100, Height: 80 }, { Hash: 'n3', X: 400, Y: 0, Width: 100, Height: 80 } ];
-	});
-
-	suite('single selection keeps the set in lockstep',
-	function ()
-	{
-		test('selectNode sets the primary and a one-element set',
-		function ()
-		{
-			let tmp = makeManager(_Fable, _Nodes);
-			tmp.sm.selectNode('n2');
-			libExpect(tmp.vs.SelectedNodeHash).to.equal('n2');
-			libExpect(tmp.vs.SelectedNodeHashes).to.deep.equal(['n2']);
-		});
-
-		test('selectNode(null) clears both the primary and the set',
-		function ()
-		{
-			let tmp = makeManager(_Fable, _Nodes);
-			tmp.sm.selectNode('n2');
-			tmp.sm.selectNode(null);
-			libExpect(tmp.vs.SelectedNodeHash).to.equal(null);
-			libExpect(tmp.vs.SelectedNodeHashes).to.deep.equal([]);
-		});
-	});
-
-	suite('toggleNodeSelection',
-	function ()
-	{
-		test('adds a node, then a second, then removes the first',
-		function ()
-		{
-			let tmp = makeManager(_Fable, _Nodes);
-			tmp.sm.toggleNodeSelection('n1');
-			libExpect(tmp.vs.SelectedNodeHashes).to.deep.equal(['n1']);
-			libExpect(tmp.vs.SelectedNodeHash).to.equal('n1');
-
-			tmp.sm.toggleNodeSelection('n3');
-			libExpect(tmp.vs.SelectedNodeHashes).to.deep.equal(['n1', 'n3']);
-			libExpect(tmp.vs.SelectedNodeHash).to.equal('n3');
-
-			tmp.sm.toggleNodeSelection('n1');
-			libExpect(tmp.vs.SelectedNodeHashes).to.deep.equal(['n3']);
-			libExpect(tmp.vs.SelectedNodeHash).to.equal('n3');
-		});
-
-		test('toggling the last member empties the set and nulls the primary',
-		function ()
-		{
-			let tmp = makeManager(_Fable, _Nodes);
-			tmp.sm.toggleNodeSelection('n1');
-			tmp.sm.toggleNodeSelection('n1');
-			libExpect(tmp.vs.SelectedNodeHashes).to.deep.equal([]);
-			libExpect(tmp.vs.SelectedNodeHash).to.equal(null);
-		});
-	});
-
-	suite('selectNodes',
-	function ()
-	{
-		test('replaces the set and sets the primary to the last hash',
-		function ()
-		{
-			let tmp = makeManager(_Fable, _Nodes);
-			tmp.sm.selectNode('n1');
-			tmp.sm.selectNodes(['n2', 'n3']);
-			libExpect(tmp.vs.SelectedNodeHashes).to.deep.equal(['n2', 'n3']);
-			libExpect(tmp.vs.SelectedNodeHash).to.equal('n3');
-		});
-
-		test('an empty array clears the selection',
-		function ()
-		{
-			let tmp = makeManager(_Fable, _Nodes);
-			tmp.sm.selectNodes(['n1', 'n2']);
-			tmp.sm.selectNodes([]);
-			libExpect(tmp.vs.SelectedNodeHashes).to.deep.equal([]);
-			libExpect(tmp.vs.SelectedNodeHash).to.equal(null);
-		});
-
-		test('getSelectedNodeHashes returns a copy (mutating it does not change state)',
-		function ()
-		{
-			let tmp = makeManager(_Fable, _Nodes);
-			tmp.sm.selectNodes(['n1', 'n2']);
-			let tmpCopy = tmp.sm.getSelectedNodeHashes();
-			tmpCopy.push('n3');
-			libExpect(tmp.vs.SelectedNodeHashes).to.deep.equal(['n1', 'n2']);
-		});
-	});
-
-	suite('deleteSelected (multi)',
-	function ()
-	{
-		test('removes every node in the selection set',
-		function ()
-		{
-			let tmp = makeManager(_Fable, _Nodes);
-			tmp.sm.selectNodes(['n1', 'n3']);
-			let tmpResult = tmp.sm.deleteSelected();
-			libExpect(tmpResult).to.equal(true);
-			libExpect(tmp.fv._removed).to.deep.equal(['n1', 'n3']);
-			libExpect(tmp.vs.SelectedNodeHashes).to.deep.equal([]);
-			libExpect(tmp.vs.SelectedNodeHash).to.equal(null);
-		});
-
-		test('falls back to the single primary when the set is empty',
-		function ()
-		{
-			let tmp = makeManager(_Fable, _Nodes);
-			tmp.fv._FlowData.ViewState.SelectedNodeHash = 'n2';
-			tmp.fv._FlowData.ViewState.SelectedNodeHashes = [];
-			tmp.sm.deleteSelected();
-			libExpect(tmp.fv._removed).to.deep.equal(['n2']);
-		});
-
-		test('deletes the selected connection when no nodes are selected',
-		function ()
-		{
-			let tmp = makeManager(_Fable, _Nodes);
-			tmp.fv._FlowData.ViewState.SelectedConnectionHash = 'c1';
-			tmp.sm.deleteSelected();
-			libExpect(tmp.fv._removed).to.deep.equal(['conn:c1']);
-		});
-	});
-
-	suite('deselectAll',
-	function ()
-	{
-		test('clears the primary, the set, and the connection/tether selections',
-		function ()
-		{
-			let tmp = makeManager(_Fable, _Nodes);
-			tmp.sm.selectNodes(['n1', 'n2']);
-			tmp.fv._FlowData.ViewState.SelectedConnectionHash = 'c1';
-			tmp.sm.deselectAll();
-			libExpect(tmp.vs.SelectedNodeHash).to.equal(null);
-			libExpect(tmp.vs.SelectedNodeHashes).to.deep.equal([]);
-			libExpect(tmp.vs.SelectedConnectionHash).to.equal(null);
-		});
-	});
-});

package/test/StylePresets_tests.js

@@ -1,153 +0,0 @@
-const libFable = require('fable');
-const libChai = require('chai');
-const libExpect = libChai.expect;
-
-const libRenderer = require('../source/providers/PictProvider-Flow-Renderer.js');
-const libStylePresets = require('../source/providers/PictProvider-Flow-StylePresets.js');
-
-// Minimal FlowView shim — captures the apply calls so we can verify each
-// preset axis fires. The real FlowView wires Renderer + setEdgeTheme; here
-// we substitute a fake whose setEdgeTheme just records its argument.
-function makeFakeFlowView(pFable)
-{
-	let tmpRenderer = new libRenderer(pFable, {}, 'Renderer-Test');
-	let tmpView =
-	{
-		_RendererProvider: tmpRenderer,
-		setEdgeThemeCalls: [],
-		setEdgeTheme: function (pName)
-		{
-			tmpView.setEdgeThemeCalls.push(pName);
-		}
-	};
-	tmpRenderer._FlowView = tmpView;
-	return tmpView;
-}
-
-// pict-provider-theme mock that records applyTheme calls.
-function attachFakeThemeProvider(pFable)
-{
-	pFable.providers = pFable.providers || {};
-	let tmpCalls = [];
-	pFable.providers.Theme =
-	{
-		applyTheme: function (pHash) { tmpCalls.push(pHash); }
-	};
-	return tmpCalls;
-}
-
-suite('PictProvider-Flow-StylePresets',
-function ()
-{
-	let _Fable;
-	let _FlowView;
-	let _ThemeCalls;
-	let _Presets;
-
-	setup(function ()
-	{
-		_Fable = new libFable({});
-		_FlowView = makeFakeFlowView(_Fable);
-		_ThemeCalls = attachFakeThemeProvider(_Fable);
-		_Presets = new libStylePresets(_Fable, { FlowView: _FlowView }, 'Presets-Test');
-	});
-
-	suite('Built-in preset registry', function ()
-	{
-		test('registers all 7 bundled presets', function ()
-		{
-			let tmpHashes = _Presets.getPresetHashes();
-			libExpect(tmpHashes).to.include('modern');
-			libExpect(tmpHashes).to.include('sketch');
-			libExpect(tmpHashes).to.include('blueprint');
-			libExpect(tmpHashes).to.include('mono');
-			libExpect(tmpHashes).to.include('retro-80s');
-			libExpect(tmpHashes).to.include('retro-90s');
-			libExpect(tmpHashes).to.include('whiteboard');
-		});
-
-		test('each bundled preset has ColorTheme + Renderer + EdgeTheme', function ()
-		{
-			let tmpHashes = _Presets.getPresetHashes();
-			for (let i = 0; i < tmpHashes.length; i++)
-			{
-				let tmpPreset = _Presets.getPreset(tmpHashes[i]);
-				libExpect(tmpPreset, `preset ${tmpHashes[i]}`).to.have.property('Hash', tmpHashes[i]);
-				libExpect(tmpPreset).to.have.property('ColorTheme');
-				libExpect(tmpPreset).to.have.property('Renderer');
-				libExpect(tmpPreset).to.have.property('EdgeTheme');
-			}
-		});
-	});
-
-	suite('applyPreset()', function ()
-	{
-		test('applies ColorTheme + Renderer + EdgeTheme + optional NoiseLevel', function ()
-		{
-			let tmpOk = _Presets.applyPreset('sketch');
-			libExpect(tmpOk).to.equal(true);
-			libExpect(_ThemeCalls).to.deep.equal(['flow-sketch']);
-			libExpect(_FlowView._RendererProvider.getActiveRendererKey()).to.equal('sketch');
-			libExpect(_FlowView.setEdgeThemeCalls).to.deep.equal(['bezier']);
-			libExpect(_FlowView._RendererProvider.getNoiseLevel()).to.equal(0.4);
-		});
-
-		test('blueprint applies bracket renderer + orthogonal edges', function ()
-		{
-			_Presets.applyPreset('blueprint');
-			libExpect(_ThemeCalls).to.deep.equal(['flow-blueprint']);
-			libExpect(_FlowView._RendererProvider.getActiveRendererKey()).to.equal('bracket');
-			libExpect(_FlowView.setEdgeThemeCalls).to.deep.equal(['orthogonal']);
-		});
-
-		test('returns false + leaves state unchanged for unknown preset hash', function ()
-		{
-			_Presets.applyPreset('sketch');
-			let tmpResult = _Presets.applyPreset('nonexistent');
-			libExpect(tmpResult).to.equal(false);
-			libExpect(_Presets.getActivePresetHash()).to.equal('sketch');
-		});
-
-		test('records active preset hash on success', function ()
-		{
-			libExpect(_Presets.getActivePresetHash()).to.equal(null);
-			_Presets.applyPreset('mono');
-			libExpect(_Presets.getActivePresetHash()).to.equal('mono');
-		});
-	});
-
-	suite('register() + custom presets', function ()
-	{
-		test('apps can register their own preset and apply it', function ()
-		{
-			_Presets.register({
-				Hash: 'corporate',
-				Label: 'Corporate',
-				ColorTheme: 'pict-default',
-				Renderer:   'clean',
-				EdgeTheme:  'orthogonal'
-			});
-			let tmpOk = _Presets.applyPreset('corporate');
-			libExpect(tmpOk).to.equal(true);
-			libExpect(_ThemeCalls).to.deep.equal(['pict-default']);
-			libExpect(_FlowView._RendererProvider.getActiveRendererKey()).to.equal('clean');
-		});
-
-		test('register() rejects payloads missing a Hash', function ()
-		{
-			let tmpOk = _Presets.register({ Label: 'Bad' });
-			libExpect(tmpOk).to.equal(false);
-		});
-	});
-
-	suite('markCustomized()', function ()
-	{
-		test('clears the active preset hash so consumers know we deviated', function ()
-		{
-			_Presets.applyPreset('sketch');
-			libExpect(_Presets.getActivePresetHash()).to.equal('sketch');
-			_Presets.markCustomized();
-			libExpect(_Presets.getActivePresetHash()).to.equal(null);
-		});
-	});
-});

package/test/ToolbarExtraButtons_tests.js

@@ -1,138 +0,0 @@
-const libChai = require('chai');
-const libExpect = libChai.expect;
-
-const libPictViewFlow = require('../source/views/PictView-Flow.js');
-const libPictViewFlowToolbar = require('../source/views/PictView-Flow-Toolbar.js');
-const libPictViewFlowFloatingToolbar = require('../source/views/PictView-Flow-FloatingToolbar.js');
-
-// The toolbar custom-button API (ToolbarExtraButtons + onToolbarButton) lets a host add its own buttons
-// to the flow toolbar. They render in both the docked and the floating toolbar (so they survive every
-// toolbar mode) and, on click, fire the FlowView's onToolbarButton hook. These are harness-free unit
-// tests: the render-time stamping and the click dispatch are prototype methods called against light
-// stubs, so no DOM or full Pict app is needed.
-suite('Flow Toolbar custom buttons (ToolbarExtraButtons)',
-function ()
-{
-	suite('default_configuration is additive + backward compatible',
-	function ()
-	{
-		test('the flow view defaults to no extra buttons and no hook',
-		function ()
-		{
-			libExpect(libPictViewFlow.default_configuration.ToolbarExtraButtons).to.be.an('array');
-			libExpect(libPictViewFlow.default_configuration.ToolbarExtraButtons.length).to.equal(0);
-			libExpect(libPictViewFlow.default_configuration.onToolbarButton).to.equal(false);
-		});
-
-		test('both toolbar views default to an empty extra-button list',
-		function ()
-		{
-			libExpect(libPictViewFlowToolbar.default_configuration.ToolbarExtraButtons).to.be.an('array');
-			libExpect(libPictViewFlowToolbar.default_configuration.ToolbarExtraButtons.length).to.equal(0);
-			libExpect(libPictViewFlowFloatingToolbar.default_configuration.ToolbarExtraButtons).to.be.an('array');
-			libExpect(libPictViewFlowFloatingToolbar.default_configuration.ToolbarExtraButtons.length).to.equal(0);
-		});
-
-		test('both toolbar templates render the extra-button group + row template',
-		function ()
-		{
-			let tmpDockedTemplates = libPictViewFlowToolbar.default_configuration.Templates;
-			let tmpDockedBar = tmpDockedTemplates.find((pT) => pT.Hash === 'Flow-Toolbar-Template');
-			let tmpDockedRow = tmpDockedTemplates.find((pT) => pT.Hash === 'Flow-Toolbar-Extra-Button');
-			libExpect(tmpDockedBar.Template).to.contain('{~TS:Flow-Toolbar-Extra-Button:Record.ToolbarExtraButtons~}');
-			libExpect(tmpDockedRow).to.be.an('object');
-			libExpect(tmpDockedRow.Template).to.contain('_handleExtraAction');
-
-			let tmpFloatTemplates = libPictViewFlowFloatingToolbar.default_configuration.Templates;
-			let tmpFloatBar = tmpFloatTemplates.find((pT) => pT.Hash === 'Flow-FloatingToolbar-Template');
-			let tmpFloatRow = tmpFloatTemplates.find((pT) => pT.Hash === 'Flow-FloatingToolbar-Extra-Button');
-			libExpect(tmpFloatBar.Template).to.contain('{~TS:Flow-FloatingToolbar-Extra-Button:Record.ToolbarExtraButtons~}');
-			libExpect(tmpFloatRow).to.be.an('object');
-			libExpect(tmpFloatRow.Template).to.contain('_handleExtraClick');
-		});
-	});
-
-	suite('_stampExtraButtons (render-time per-row fields)',
-	function ()
-	{
-		test('stamps FlowViewIdentifier and an empty ActiveClass onto each button',
-		function ()
-		{
-			let tmpStub =
-			{
-				options:
-				{
-					FlowViewIdentifier: 'MB-FlowView-7',
-					ToolbarExtraButtons: [ { Hash: 'background', Icon: 'background' }, { Hash: 'done', Icon: 'check' } ]
-				}
-			};
-			libPictViewFlowToolbar.prototype._stampExtraButtons.call(tmpStub);
-			libExpect(tmpStub.options.ToolbarExtraButtons[0].FlowViewIdentifier).to.equal('MB-FlowView-7');
-			libExpect(tmpStub.options.ToolbarExtraButtons[0].ActiveClass).to.equal('');
-			libExpect(tmpStub.options.ToolbarExtraButtons[1].FlowViewIdentifier).to.equal('MB-FlowView-7');
-		});
-
-		test('an Active button gets the active class',
-		function ()
-		{
-			let tmpStub =
-			{
-				options:
-				{
-					FlowViewIdentifier: 'Pict-Flow',
-					ToolbarExtraButtons: [ { Hash: 'edit', Icon: 'edit', Active: true } ]
-				}
-			};
-			libPictViewFlowToolbar.prototype._stampExtraButtons.call(tmpStub);
-			libExpect(tmpStub.options.ToolbarExtraButtons[0].ActiveClass).to.equal(' pict-flow-toolbar-btn-active');
-		});
-
-		test('a non-array extra-button option is tolerated',
-		function ()
-		{
-			let tmpStub = { options: { FlowViewIdentifier: 'Pict-Flow', ToolbarExtraButtons: false } };
-			libExpect(function () { libPictViewFlowToolbar.prototype._stampExtraButtons.call(tmpStub); }).to.not.throw();
-		});
-	});
-
-	suite('click dispatch fires onToolbarButton(hash, element)',
-	function ()
-	{
-		test('the docked toolbar routes a click to the FlowView hook with the element',
-		function ()
-		{
-			let tmpFired = [];
-			let tmpElement = { id: 'the-button' };
-			let tmpStub =
-			{
-				_FlowView: { options: { onToolbarButton: (pHash, pEl) => { tmpFired.push({ Hash: pHash, El: pEl }); } } }
-			};
-			libPictViewFlowToolbar.prototype._handleExtraAction.call(tmpStub, 'background', tmpElement);
-			libExpect(tmpFired.length).to.equal(1);
-			libExpect(tmpFired[0].Hash).to.equal('background');
-			libExpect(tmpFired[0].El).to.equal(tmpElement);
-		});
-
-		test('no hook configured is a no-op (does not throw)',
-		function ()
-		{
-			let tmpStub = { _FlowView: { options: { onToolbarButton: false } } };
-			libExpect(function () { libPictViewFlowToolbar.prototype._handleExtraAction.call(tmpStub, 'edit', {}); }).to.not.throw();
-		});
-
-		test('the floating toolbar routes its click through the docked toolbar dispatch',
-		function ()
-		{
-			let tmpSeen = [];
-			let tmpElement = { id: 'floating-button' };
-			let tmpFloatStub =
-			{
-				_ToolbarView: { _handleExtraAction: (pHash, pEl) => { tmpSeen.push({ Hash: pHash, El: pEl }); } }
-			};
-			libPictViewFlowFloatingToolbar.prototype._handleExtraClick.call(tmpFloatStub, 'done', tmpElement);
-			libExpect(tmpSeen.length).to.equal(1);
-			libExpect(tmpSeen[0].Hash).to.equal('done');
-			libExpect(tmpSeen[0].El).to.equal(tmpElement);
-		});
-	});
-});

package/test/UndirectedConnections_tests.js

@@ -1,70 +0,0 @@
-const libFable = require('fable');
-const libChai = require('chai');
-const libExpect = libChai.expect;
-
-const libInteractionManager = require('../source/services/PictService-Flow-InteractionManager.js');
-const STATES = libInteractionManager.INTERACTION_STATES;
-
-// EnableUndirectedConnections lets a connection be drawn between ANY two ports rather than only
-// output -> input. A free-form canvas (a moodboard) turns it on so a card's ports connect in any
-// direction; directed graphs (workflows) leave it off. These tests cover the start side of the drag
-// (the gate that previously hard-required an output port). The completion side uses
-// document.elementFromPoint, so it is exercised in the browser rather than here.
-function makeFlowView(pUndirected)
-{
-	return {
-		options: { EnableConnectionCreation: true, EnableUndirectedConnections: pUndirected },
-		// Returning null skips the drag-line DOM creation, so no document is needed.
-		getPortPosition: function () { return null; },
-		_ViewportElement: { appendChild: function () {} }
-	};
-}
-
-function makeManager(pFable, pFlowView)
-{
-	let tmpManager = new libInteractionManager(pFable, { FlowView: pFlowView }, 'IM-Test');
-	tmpManager._SVGElement = { classList: { add: function () {}, remove: function () {} } };
-	return tmpManager;
-}
-
-function makePort(pNodeHash, pPortHash, pDirection)
-{
-	let tmpAttrs = { 'data-node-hash': pNodeHash, 'data-port-hash': pPortHash, 'data-port-direction': pDirection };
-	return { getAttribute: function (pName) { return Object.prototype.hasOwnProperty.call(tmpAttrs, pName) ? tmpAttrs[pName] : null; } };
-}
-
-suite('Flow undirected connections (EnableUndirectedConnections)',
-function ()
-{
-	let _Fable;
-	setup(function () { _Fable = new libFable({}); });
-
-	test('directed mode (default): an input port does NOT start a connection',
-	function ()
-	{
-		let tmpManager = makeManager(_Fable, makeFlowView(false));
-		tmpManager._startConnection({ stopPropagation: function () {} }, makePort('n1', 'p1', 'input'));
-		libExpect(tmpManager._State).to.not.equal(STATES.CONNECTING);
-	});
-
-	test('undirected mode: an input port DOES start a connection',
-	function ()
-	{
-		let tmpManager = makeManager(_Fable, makeFlowView(true));
-		tmpManager._startConnection({ stopPropagation: function () {} }, makePort('n1', 'p1', 'input'));
-		libExpect(tmpManager._State).to.equal(STATES.CONNECTING);
-		libExpect(tmpManager._ConnectSourceNodeHash).to.equal('n1');
-		libExpect(tmpManager._ConnectSourcePortHash).to.equal('p1');
-	});
-
-	test('an output port starts a connection in either mode',
-	function ()
-	{
-		[ false, true ].forEach(function (pUndirected)
-		{
-			let tmpManager = makeManager(_Fable, makeFlowView(pUndirected));
-			tmpManager._startConnection({ stopPropagation: function () {} }, makePort('n1', 'p1', 'output'));
-			libExpect(tmpManager._State).to.equal(STATES.CONNECTING);
-		});
-	});
-});