pi-zellij 0.3.1 → 0.4.0

package/CHANGELOG.md

@@ -5,11 +5,6 @@
 ### Added
 
 - Initial `pi-zellij` release with zellij-powered pane workflows for Pi.
-
-### Changed
-
-- Clarified README notification wording to match the current `zv-notify` behavior: `Waiting`, `Task Complete`, and `Error`.
-- Added `zv-notify` for desktop notifications using `osascript` on macOS or `notify-send` on Linux.
 - Added `/zv`, `/zj`, and `/zt` to open a new zellij pane or tab and start a fresh Pi session in the same working directory.
 - Added `/zo` and `/zoh` to open a new pane and run any shell command there.
 - Added configurable floating app commands via `pi-zellij.commands` in Pi `settings.json`, including shorthand entries such as `"zh": "hx"` and `"zg": "lazygit"`, plus object entries with `acceptArgs` support.
@@ -18,3 +13,7 @@
 - Added `/zz` and `/zzh` to open a new pane from a zoxide match or direct directory path and start Pi there.
 - Added `zv-review` with `/zrv` and `/zrh`, plus bundled `code-review` skill and `/review` / `/review-diff` prompt templates for focused review workflows, including GitHub pull request review via `gh` when given a PR URL.
 - Added `zv-continue` with `/zcv` and `/zch` for split-based task handoff in the current checkout or by creating a git worktree branch with `-c <branch>`.
+
+### Removed
+
+- Removed the bundled `zv-notify` extension so `pi-zellij` does not conflict with separate notification packages or user-specific notification setups.

package/README.md

@@ -4,9 +4,9 @@ Pi package with zellij-powered terminal integrations for [Pi](https://pi.dev).
 
 ## Why
 
-[Pi](https://pi.dev) works well in the terminal, but pane orchestration is better handled by a terminal multiplexer. `pi-zellij` adds zellij-native split workflows for Pi, plus optional desktop notifications.
+[Pi](https://pi.dev) works well in the terminal, but pane orchestration is better handled by a terminal multiplexer. `pi-zellij` adds zellij-native split workflows for Pi.
 
-It includes split and tab commands, generic tool launchers, settings-driven floating app shortcuts, zoxide jumps, review workflows, split-based task handoff, and automatic run notifications.
+It includes split and tab commands, generic tool launchers, settings-driven floating app shortcuts, zoxide jumps, review workflows, and split-based task handoff.
 
 ## Usage
 
@@ -33,9 +33,6 @@ If pi is already running, use:
 - `zellij` must be installed
 - pane, tab, and floating commands must be run from inside an active zellij session
 - `zoxide` is required for the zoxide commands
-- notifications use:
-  - `osascript` on macOS
-  - `notify-send` on Linux
 
 ## Feature overview
 
@@ -64,15 +61,9 @@ If pi is already running, use:
 - `/skill:code-review`
   - loads the bundled structured review skill for files, directories, diffs, and PRs
 
-### Notifications
-
-- automatic via `zv-notify`
-  - sends desktop notifications for Pi run states such as `Waiting`, `Task Complete`, and `Error`
-
 ## Bundled extensions and resources
 
 Extensions:
-- `zv-notify`
 - `zv-split`
 - `zv-open`
 - `zv-zoxide`
@@ -159,7 +150,9 @@ Examples:
 /zg
 ```
 
-For commands that should accept extra arguments, use the object form:
+For commands that should accept extra arguments, use the object form.
+
+Helix and lazygit example:
 
 ```json
 {
@@ -169,16 +162,22 @@ For commands that should accept extra arguments, use the object form:
         "run": "hx",
         "acceptArgs": true,
         "description": "Open Helix in a floating pane"
+      },
+      "zg": {
+        "run": "lazygit",
+        "description": "Open lazygit in a floating pane"
       }
     }
   }
 }
 ```
 
-Then you can pass arguments through to the configured command:
+Then you can use:
 
 ```text
+/zh
 /zh src/auth.ts
+/zg
 ```
 
 Configured command names cannot reuse built-in Pi commands such as `/settings`, `/model`, or `/reload`, and they also cannot replace pi-zellij's own slash commands such as `/zv`, `/zj`, `/zt`, `/zz`, or `/zcv`.
@@ -273,24 +272,3 @@ Examples:
 
 If the target is a GitHub pull request URL, the review workflow switches to PR review and instructs pi to inspect the pull request with `gh pr view` and `gh pr diff`.
 
-## Notifications
-
-The bundled `zv-notify` extension summarizes each run and sends a desktop notification when supported by the host system.
-
-Current notification types:
-- `Waiting`
-- `Task Complete`
-- `Error`
-
-You can control notification noise with one setting:
-- `PI_ZV_NOTIFY_LEVEL=all` - `Waiting`, `Task Complete`, and `Error`
-- `PI_ZV_NOTIFY_LEVEL=medium` - `Task Complete` and `Error`
-- `PI_ZV_NOTIFY_LEVEL=low` - `Error` only
-- `PI_ZV_NOTIFY_LEVEL=disabled` - disable notifications
-
-## Environment variables
-
-- `PI_ZV_NOTIFY_LEVEL` - notification level: `all`, `medium`, `low`, or `disabled` (default: `all`)
-- `PI_ZV_NOTIFY_THRESHOLD_MS` - duration threshold before a run is labeled `Task Complete` instead of `Waiting` (default: `15000`)
-- `PI_ZV_NOTIFY_DEBOUNCE_MS` - minimum delay between duplicate notifications (default: `3000`)
-- `PI_ZV_NOTIFY_TITLE` - notification title override (default: `Pi`)

package/extensions/index.ts

@@ -1,5 +1,4 @@
 import type { ExtensionAPI } from "@mariozechner/pi-coding-agent";
-import zvNotifyExtension from "./zv-notify.ts";
 import zvSplitExtension from "./zv-split.ts";
 import zvZoxideExtension from "./zv-zoxide.ts";
 import zvReviewExtension from "./zv-review.ts";
@@ -7,7 +6,6 @@ import zvContinueExtension from "./zv-continue.ts";
 import zvOpenExtension from "./zv-open.ts";
 
 export default function piZellijExtensionBundle(pi: ExtensionAPI) {
-	zvNotifyExtension(pi);
 	zvSplitExtension(pi);
 	zvZoxideExtension(pi);
 	zvReviewExtension(pi);

package/install.mjs

@@ -21,7 +21,7 @@ const isRemove = args.includes("--remove") || args.includes("-r");
 const isHelp = args.includes("--help") || args.includes("-h");
 
 function printHelp() {
-	console.log(`\n${PACKAGE_NAME}\n\nWhy:\n  ${PACKAGE_NAME} adds zellij-powered pane workflows and system notifications to pi.\n\nUsage:\n  npx ${PACKAGE_NAME}          Install or update the package\n  npx ${PACKAGE_NAME} --remove Remove the installed package\n  npx ${PACKAGE_NAME} --help   Show this help\n`);
+	console.log(`\n${PACKAGE_NAME}\n\nWhy:\n  ${PACKAGE_NAME} adds zellij-powered pane workflows to pi.\n\nUsage:\n  npx ${PACKAGE_NAME}          Install or update the package\n  npx ${PACKAGE_NAME} --remove Remove the installed package\n  npx ${PACKAGE_NAME} --help   Show this help\n`);
 }
 
 function ensureDir(dir) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-zellij",
-  "version": "0.3.1",
+  "version": "0.4.0",
   "description": "Pi package with zellij-powered terminal integrations",
   "author": "Javi Molina",
   "license": "MIT",
@@ -10,8 +10,7 @@
     "pi",
     "pi-coding-agent",
     "zellij",
-    "terminal",
-    "notifications"
+    "terminal"
   ],
   "homepage": "https://github.com/javiermolinar/pi-zellij#readme",
   "repository": {

package/extensions/zv-notify.ts

@@ -1,303 +0,0 @@
-import type { ExtensionAPI, ToolResultEvent } from "@mariozechner/pi-coding-agent";
-import {
-	isBashToolResult,
-	isEditToolResult,
-	isFindToolResult,
-	isGrepToolResult,
-	isReadToolResult,
-	isWriteToolResult,
-} from "@mariozechner/pi-coding-agent";
-import { basename } from "node:path";
-
-const DEFAULT_THRESHOLD_MS = 15000;
-const DEFAULT_DEBOUNCE_MS = 3000;
-const NOTIFY_TIMEOUT_MS = 5000;
-const DEFAULT_NOTIFY_LEVEL = "all";
-
-type NotifyLevel = "all" | "medium" | "low" | "disabled";
-type NotifyBackend = "unknown" | "osascript" | "notify-send" | "unavailable";
-
-interface RunState {
-	startedAt: number;
-	readFiles: Set<string>;
-	changedFiles: Set<string>;
-	searchCount: number;
-	bashCount: number;
-	firstToolError: string | undefined;
-}
-
-interface AssistantMessageLike {
-	role: "assistant";
-	stopReason?: string;
-	errorMessage?: string;
-	content?: Array<{ type?: string; text?: string }>;
-}
-
-function getNumberFromEnv(name: string, fallback: number): number {
-	const value = process.env[name];
-	if (!value) return fallback;
-	const parsed = Number.parseInt(value, 10);
-	return Number.isFinite(parsed) && parsed >= 0 ? parsed : fallback;
-}
-
-function getNotifyLevelFromEnv(): NotifyLevel {
-	const value = process.env.PI_ZV_NOTIFY_LEVEL?.trim().toLowerCase();
-	if (value === "all" || value === "medium" || value === "low" || value === "disabled") {
-		return value;
-	}
-	return DEFAULT_NOTIFY_LEVEL;
-}
-
-function pluralize(count: number, singular: string, plural: string = `${singular}s`): string {
-	return count === 1 ? singular : plural;
-}
-
-function formatDuration(ms: number): string {
-	const totalSeconds = Math.max(1, Math.round(ms / 1000));
-	const minutes = Math.floor(totalSeconds / 60);
-	const seconds = totalSeconds % 60;
-	if (minutes === 0) return `${seconds}s`;
-	if (seconds === 0) return `${minutes}m`;
-	return `${minutes}m ${seconds}s`;
-}
-
-function getPathFromInput(event: ToolResultEvent): string | undefined {
-	const path = event.input.path;
-	return typeof path === "string" && path.length > 0 ? path : undefined;
-}
-
-function getFirstText(event: ToolResultEvent): string | undefined {
-	const textPart = event.content.find((part) => part.type === "text");
-	if (!textPart || textPart.type !== "text") return undefined;
-	const text = textPart.text.trim();
-	return text.length > 0 ? text : undefined;
-}
-
-function summarizeError(event: ToolResultEvent): string {
-	const path = getPathFromInput(event);
-	if (path) {
-		return `${event.toolName} failed for ${basename(path)}`;
-	}
-	if (isBashToolResult(event)) {
-		return "bash command failed";
-	}
-	const text = getFirstText(event);
-	if (!text) {
-		return `${event.toolName} failed`;
-	}
-	return text.length > 120 ? `${text.slice(0, 117)}...` : text;
-}
-
-function summarizeSuccess(state: RunState, durationMs: number, thresholdMs: number): string {
-	const changedCount = state.changedFiles.size;
-	if (changedCount === 1) {
-		const [file] = [...state.changedFiles];
-		const summary = `Updated ${basename(file)}`;
-		return durationMs >= thresholdMs ? `${summary} in ${formatDuration(durationMs)}` : summary;
-	}
-	if (changedCount > 1) {
-		const summary = `Updated ${changedCount} ${pluralize(changedCount, "file")}`;
-		return durationMs >= thresholdMs ? `${summary} in ${formatDuration(durationMs)}` : summary;
-	}
-
-	const readCount = state.readFiles.size;
-	if (readCount === 1) {
-		const [file] = [...state.readFiles];
-		const summary = `Reviewed ${basename(file)}`;
-		return durationMs >= thresholdMs ? `${summary} in ${formatDuration(durationMs)}` : summary;
-	}
-	if (readCount > 1) {
-		const summary = `Reviewed ${readCount} ${pluralize(readCount, "file")}`;
-		return durationMs >= thresholdMs ? `${summary} in ${formatDuration(durationMs)}` : summary;
-	}
-
-	if (state.searchCount > 0 && state.bashCount > 0) {
-		const summary = `Ran ${state.searchCount} ${pluralize(state.searchCount, "search")} and ${state.bashCount} ${pluralize(state.bashCount, "shell command")}`;
-		return durationMs >= thresholdMs ? `${summary} in ${formatDuration(durationMs)}` : summary;
-	}
-	if (state.searchCount > 0) {
-		const summary = state.searchCount === 1 ? "Searched the codebase" : `Ran ${state.searchCount} searches`;
-		return durationMs >= thresholdMs ? `${summary} in ${formatDuration(durationMs)}` : summary;
-	}
-	if (state.bashCount > 0) {
-		const summary = `Ran ${state.bashCount} ${pluralize(state.bashCount, "shell command")}`;
-		return durationMs >= thresholdMs ? `${summary} in ${formatDuration(durationMs)}` : summary;
-	}
-	return durationMs >= thresholdMs
-		? `Finished in ${formatDuration(durationMs)}`
-		: "Finished and waiting for input";
-}
-
-function isAssistantMessage(message: unknown): message is AssistantMessageLike {
-	return typeof message === "object" && message !== null && (message as { role?: unknown }).role === "assistant";
-}
-
-function getLastAssistantMessage(messages: readonly unknown[]): AssistantMessageLike | undefined {
-	for (let index = messages.length - 1; index >= 0; index -= 1) {
-		const message = messages[index];
-		if (isAssistantMessage(message)) return message;
-	}
-	return undefined;
-}
-
-function summarizeAssistantText(message: AssistantMessageLike): string | undefined {
-	if (!Array.isArray(message.content)) return undefined;
-
-	const text = message.content
-		.filter(
-			(part): part is { type: "text"; text: string } =>
-				typeof part === "object" &&
-				part !== null &&
-				part.type === "text" &&
-				typeof part.text === "string" &&
-				part.text.trim().length > 0,
-		)
-		.map((part) => part.text.trim())
-		.join("\n")
-		.trim();
-
-	if (text.length === 0) return undefined;
-	return text.length > 120 ? `${text.slice(0, 117)}...` : text;
-}
-
-function summarizeRunError(messages: readonly unknown[], fallbackError?: string): string | undefined {
-	const assistantMessage = getLastAssistantMessage(messages);
-	if (!assistantMessage) return fallbackError;
-	if (assistantMessage.stopReason !== "error" && assistantMessage.stopReason !== "aborted") {
-		return undefined;
-	}
-
-	const summary = assistantMessage.errorMessage?.trim() || summarizeAssistantText(assistantMessage) || fallbackError || "Agent run failed";
-	return summary.length > 120 ? `${summary.slice(0, 117)}...` : summary;
-}
-
-function buildSubtitle(hasRunError: boolean, state: RunState, durationMs: number, thresholdMs: number): string {
-	if (hasRunError) return "Error";
-	if (state.changedFiles.size > 0 || durationMs >= thresholdMs) return "Task Complete";
-	return "Waiting";
-}
-
-function shouldNotify(level: NotifyLevel, subtitle: string): boolean {
-	if (level === "disabled") return false;
-	if (level === "all") return true;
-	if (level === "medium") return subtitle === "Task Complete" || subtitle === "Error";
-	if (level === "low") return subtitle === "Error";
-	return true;
-}
-
-function createEmptyRunState(): RunState {
-	return {
-		startedAt: Date.now(),
-		readFiles: new Set<string>(),
-		changedFiles: new Set<string>(),
-		searchCount: 0,
-		bashCount: 0,
-		firstToolError: undefined,
-	};
-}
-
-function getDefaultBackend(): NotifyBackend {
-	if (process.platform === "darwin") return "osascript";
-	if (process.platform === "linux") return "notify-send";
-	return "unavailable";
-}
-
-function escapeAppleScriptString(value: string): string {
-	return `"${value.replace(/\\/g, "\\\\").replace(/"/g, '\\"')}"`;
-}
-
-export default function zvNotifyExtension(pi: ExtensionAPI) {
-	const thresholdMs = getNumberFromEnv("PI_ZV_NOTIFY_THRESHOLD_MS", DEFAULT_THRESHOLD_MS);
-	const debounceMs = getNumberFromEnv("PI_ZV_NOTIFY_DEBOUNCE_MS", DEFAULT_DEBOUNCE_MS);
-	const notifyLevel = getNotifyLevelFromEnv();
-	const title = process.env.PI_ZV_NOTIFY_TITLE || "Pi";
-
-	let runState = createEmptyRunState();
-	let lastNotificationAt = 0;
-	let lastNotificationKey = "";
-	let notifyBackend: NotifyBackend = "unknown";
-
-	const sendNotification = async (subtitle: string, body: string): Promise<{ ok: boolean; error?: string }> => {
-		if (notifyBackend === "unknown") {
-			notifyBackend = getDefaultBackend();
-		}
-		if (notifyBackend === "unavailable") {
-			return { ok: false, error: "desktop notifications are unavailable on this platform" };
-		}
-
-		const notificationKey = `${subtitle}\n${body}`;
-		const now = Date.now();
-		if (notificationKey === lastNotificationKey && now - lastNotificationAt < debounceMs) {
-			return { ok: true };
-		}
-
-		const result =
-			notifyBackend === "osascript"
-				? await pi.exec(
-						"osascript",
-						[
-							"-e",
-							`display notification ${escapeAppleScriptString(body)} with title ${escapeAppleScriptString(title)} subtitle ${escapeAppleScriptString(subtitle)}`,
-						],
-						{ timeout: NOTIFY_TIMEOUT_MS },
-				  )
-				: await pi.exec("notify-send", [`${title} — ${subtitle}`, body], { timeout: NOTIFY_TIMEOUT_MS });
-
-		if (result.killed) {
-			return { ok: false, error: "notification command timed out" };
-		}
-		if (result.code !== 0) {
-			const error = result.stderr.trim() || result.stdout.trim() || `notification command exited with code ${result.code}`;
-			if (error.includes("not found") || error.includes("ENOENT")) {
-				notifyBackend = "unavailable";
-			}
-			return { ok: false, error };
-		}
-
-		lastNotificationAt = now;
-		lastNotificationKey = notificationKey;
-		return { ok: true };
-	};
-
-	pi.on("agent_start", async () => {
-		runState = createEmptyRunState();
-	});
-
-	pi.on("tool_result", async (event) => {
-		if (event.isError && !runState.firstToolError) {
-			runState.firstToolError = summarizeError(event);
-		}
-
-		if (isReadToolResult(event)) {
-			const path = getPathFromInput(event);
-			if (path) runState.readFiles.add(path);
-			return;
-		}
-
-		if (isEditToolResult(event) || isWriteToolResult(event)) {
-			const path = getPathFromInput(event);
-			if (path && !event.isError) runState.changedFiles.add(path);
-			return;
-		}
-
-		if (isGrepToolResult(event) || isFindToolResult(event)) {
-			if (!event.isError) runState.searchCount += 1;
-			return;
-		}
-
-		if (isBashToolResult(event) && !event.isError) {
-			runState.bashCount += 1;
-		}
-	});
-
-	pi.on("agent_end", async (event) => {
-		const durationMs = Date.now() - runState.startedAt;
-		const runError = summarizeRunError(event.messages, runState.firstToolError);
-		const subtitle = buildSubtitle(Boolean(runError), runState, durationMs, thresholdMs);
-		if (!shouldNotify(notifyLevel, subtitle)) {
-			return;
-		}
-		const body = runError || summarizeSuccess(runState, durationMs, thresholdMs);
-		await sendNotification(subtitle, body);
-	});
-}