pi-web 0.13.6 → 0.14.0

package/build/server/rpc.js

@@ -25,7 +25,9 @@ export class RpcSession {
                     try {
                         this.opts.onEvent(JSON.parse(line));
                     }
-                    catch { }
+                    catch {
+                        // malformed JSON line — skip
+                    }
                 }
                 idx = this.buffer.indexOf('\n');
             }
@@ -56,9 +58,13 @@ export class RpcSession {
                 try {
                     this.proc.kill('SIGKILL');
                 }
-                catch { }
+                catch {
+                    // process already gone
+                }
             }, 2000);
         }
-        catch { }
+        catch {
+            // process already gone
+        }
     }
 }

package/build/server/server.js

@@ -1,6 +1,6 @@
 import { createServer } from 'node:http';
 import { randomUUID } from 'node:crypto';
-import { createReadStream, existsSync, readFileSync, statSync, unlinkSync, } from 'node:fs';
+import { createReadStream, existsSync, readFileSync, statSync, unlinkSync } from 'node:fs';
 import { readdir } from 'node:fs/promises';
 import { basename, dirname, extname, isAbsolute, join, normalize, relative, resolve, } from 'node:path';
 import { homedir } from 'node:os';
@@ -29,9 +29,7 @@ function getArg(name) {
     if (pair)
         return pair.slice(flag.length);
     const idx = process.argv.indexOf(`--${name}`);
-    if (idx !== -1 &&
-        process.argv[idx + 1] &&
-        !process.argv[idx + 1].startsWith('--'))
+    if (idx !== -1 && process.argv[idx + 1] && !process.argv[idx + 1].startsWith('--'))
         return process.argv[idx + 1];
     return undefined;
 }
@@ -55,11 +53,9 @@ const IDLE_SESSION_TTL_MS = 60_000;
 const isWatchMode = process.argv.includes('--watch') ||
     process.execArgv.some((arg) => arg === '--watch' || arg.startsWith('--watch-'));
 const isDev = isWatchMode;
-const distDirCandidates = [
-    join(__dirname, 'dist'),
-    join(__dirname, '..', '..', 'dist'),
-];
-const distDir = distDirCandidates.find((candidate) => existsSync(join(candidate, 'index.html'))) ?? distDirCandidates[0];
+const distDirCandidates = [join(__dirname, 'dist'), join(__dirname, '..', '..', 'dist')];
+const distDir = distDirCandidates.find((candidate) => existsSync(join(candidate, 'index.html'))) ??
+    distDirCandidates[0];
 const htmlPath = join(distDir, 'index.html');
 const htmlCache = isDev || !existsSync(htmlPath) ? null : readFileSync(htmlPath, 'utf-8');
 const HOME_DIR = resolve(homedir() || '/');
@@ -208,16 +204,12 @@ const server = createServer((req, res) => {
             .replace(/^(\.\.[/\\])+/, '')
             .replace(/^[/\\]+/, '');
         const filePath = resolve(join(distDir, safePath));
-        if (isWithinRoot(filePath, distDir) &&
-            existsSync(filePath) &&
-            statSync(filePath).isFile()) {
+        if (isWithinRoot(filePath, distDir) && existsSync(filePath) && statSync(filePath).isFile()) {
             serveFile(filePath, res);
             return;
         }
         const acceptsHtml = (req.headers.accept ?? '').includes('text/html');
-        if (req.method === 'GET' &&
-            !url.pathname.startsWith('/api/') &&
-            acceptsHtml) {
+        if (req.method === 'GET' && !url.pathname.startsWith('/api/') && acceptsHtml) {
             if (!existsSync(htmlPath)) {
                 res.writeHead(503, { 'Content-Type': 'text/plain' });
                 res.end('frontend not built. run: npm run build');
@@ -339,9 +331,9 @@ function detachSocket(ws) {
     cleanupIfIdle(current);
 }
 function registerDiscoveredSessionKey(managed, event) {
-    if (event?.type !== 'response' || event?.command !== 'get_state')
+    if (event.type !== 'response' || event.command !== 'get_state' || !event.success)
         return;
-    const sessionPath = event?.data?.sessionFile;
+    const sessionPath = event.data?.sessionFile;
     if (typeof sessionPath !== 'string' || sessionPath.length === 0)
         return;
     const key = buildSessionKey(managed.cwd, basename(sessionPath));
@@ -356,8 +348,6 @@ function deriveModelSupportsImages(model) {
     return input.includes('image');
 }
 function updateSessionModelCapability(managed, event) {
-    if (!event || typeof event !== 'object')
-        return;
     if (event.type === 'model_changed') {
         const supports = deriveModelSupportsImages(event.model);
         if (supports != null)
@@ -365,7 +355,7 @@ function updateSessionModelCapability(managed, event) {
         return;
     }
     if (event.type === 'response') {
-        if (event.command === 'get_state') {
+        if (event.command === 'get_state' && event.success) {
             const supports = deriveModelSupportsImages(event.data?.model);
             if (supports != null)
                 managed.currentModelSupportsImages = supports;
@@ -379,9 +369,7 @@ function updateSessionModelCapability(managed, event) {
     }
 }
 function createManagedSession(cwd, sessionFile, initialKey) {
-    const sessionPath = sessionFile
-        ? getSessionFilePath(cwd, sessionFile, AGENT)
-        : undefined;
+    const sessionPath = sessionFile ? getSessionFilePath(cwd, sessionFile, AGENT) : undefined;
     let managed = null;
     const rpc = new RpcSession({
         piCmd: AGENT_CMD,
@@ -390,11 +378,11 @@ function createManagedSession(cwd, sessionFile, initialKey) {
         onEvent: (event) => {
             if (!managed)
                 return;
-            if (event?.type === 'agent_start') {
+            if (event.type === 'agent_start') {
                 managed.isAgentRunning = true;
                 clearIdleCleanupTimer(managed);
             }
-            if (event?.type === 'agent_end') {
+            if (event.type === 'agent_end') {
                 managed.isAgentRunning = false;
                 cleanupIfIdle(managed);
             }
@@ -447,9 +435,7 @@ wss.on('connection', (ws) => {
             return;
         }
         if (msg.type === 'start_session') {
-            const cwd = typeof msg.cwd === 'string' && msg.cwd.trim().length > 0
-                ? resolve(msg.cwd)
-                : HOME_DIR;
+            const cwd = typeof msg.cwd === 'string' && msg.cwd.trim().length > 0 ? resolve(msg.cwd) : HOME_DIR;
             const sessionFile = typeof msg.sessionFile === 'string' && msg.sessionFile.length > 0
                 ? basename(msg.sessionFile)
                 : null;
@@ -479,13 +465,9 @@ wss.on('connection', (ws) => {
                 return;
             }
             const command = msg.command;
-            const isPromptLikeCommand = command?.type === 'prompt' ||
-                command?.type === 'steer' ||
-                command?.type === 'follow_up';
-            const hasImages = Array.isArray(command?.images) && command.images.length > 0;
-            if (isPromptLikeCommand &&
-                hasImages &&
-                managed.currentModelSupportsImages === false) {
+            const isPromptLikeCommand = command.type === 'prompt' || command.type === 'steer' || command.type === 'follow_up';
+            const hasImages = 'images' in command && Array.isArray(command.images) && command.images.length > 0;
+            if (isPromptLikeCommand && hasImages && managed.currentModelSupportsImages === false) {
                 sendToSocket(ws, {
                     type: 'error',
                     message: 'selected model does not support file attachments',

package/build/server/sessions.js

@@ -14,9 +14,7 @@ function cwdToSessionDir(cwd, agent) {
         if (normalisedCwd === HOME_DIR ||
             normalisedCwd.startsWith(`${HOME_DIR}/`) ||
             normalisedCwd.startsWith(`${HOME_DIR}\\`)) {
-            const relative = normalisedCwd
-                .slice(HOME_DIR.length)
-                .replace(/^[/\\]/, '');
+            const relative = normalisedCwd.slice(HOME_DIR.length).replace(/^[/\\]/, '');
             return `-${relative.replace(/[/\\:]/g, '-')}`;
         }
     }
@@ -54,13 +52,17 @@ export async function listSessions(opts) {
                     if (info)
                         results.push(info);
                 }
-                catch { }
+                catch {
+                    // unreadable session file — skip
+                }
             }
             if (results.length >= limit)
                 break;
         }
     }
-    catch { }
+    catch {
+        // session directory does not exist or is unreadable
+    }
     results.sort((a, b) => b.timestamp.localeCompare(a.timestamp));
     return results.slice(0, limit);
 }
@@ -105,7 +107,9 @@ export async function readSessionMessages(filePath) {
                     usage: msg.usage,
                 });
             }
-            catch { }
+            catch {
+                // malformed JSON line — skip
+            }
         }
     }
     finally {
@@ -163,7 +167,9 @@ async function readSessionHeader(filePath) {
                     }
                 }
             }
-            catch { }
+            catch {
+                // malformed JSON line — skip
+            }
         }
     }
     finally {
@@ -173,10 +179,10 @@ async function readSessionHeader(filePath) {
     if (!header)
         return null;
     return {
-        id: header.id,
+        id: typeof header.id === 'string' ? header.id : '',
         file: basename(filePath),
-        cwd: header.cwd || '',
-        timestamp: header.timestamp || '',
+        cwd: typeof header.cwd === 'string' ? header.cwd : '',
+        timestamp: typeof header.timestamp === 'string' ? header.timestamp : '',
         firstPrompt,
         messageCount,
     };

package/build/server/shared/pi-types.js

@@ -0,0 +1 @@
+export {};

package/build/server/shared/rpc-event.js

@@ -0,0 +1 @@
+export {};